* [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()
@ 2023-06-15 12:46 YueHaibing
2023-06-15 13:49 ` Maciej Fijalkowski
0 siblings, 1 reply; 5+ messages in thread
From: YueHaibing @ 2023-06-15 12:46 UTC (permalink / raw)
To: bjorn, magnus.karlsson, maciej.fijalkowski, jonathan.lemon,
davem, edumazet, kuba, pabeni, ast, daniel, hawk, john.fastabend
Cc: netdev, bpf, linux-kernel, maxtram95, YueHaibing
commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
left behind this, remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
include/net/xdp_sock_drv.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
index 9c0d860609ba..c243f906ebed 100644
--- a/include/net/xdp_sock_drv.h
+++ b/include/net/xdp_sock_drv.h
@@ -255,10 +255,6 @@ static inline void xsk_buff_free(struct xdp_buff *xdp)
{
}
-static inline void xsk_buff_discard(struct xdp_buff *xdp)
-{
-}
-
static inline void xsk_buff_set_size(struct xdp_buff *xdp, u32 size)
{
}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()
2023-06-15 12:46 [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard() YueHaibing
@ 2023-06-15 13:49 ` Maciej Fijalkowski
2023-06-15 13:51 ` Maciej Fijalkowski
0 siblings, 1 reply; 5+ messages in thread
From: Maciej Fijalkowski @ 2023-06-15 13:49 UTC (permalink / raw)
To: YueHaibing
Cc: bjorn, magnus.karlsson, jonathan.lemon, davem, edumazet, kuba,
pabeni, ast, daniel, hawk, john.fastabend, netdev, bpf,
linux-kernel, maxtram95
On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> left behind this, remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Yeah this is a stub for !CONFIG_XDP_SOCKETS...
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> include/net/xdp_sock_drv.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
> index 9c0d860609ba..c243f906ebed 100644
> --- a/include/net/xdp_sock_drv.h
> +++ b/include/net/xdp_sock_drv.h
> @@ -255,10 +255,6 @@ static inline void xsk_buff_free(struct xdp_buff *xdp)
> {
> }
>
> -static inline void xsk_buff_discard(struct xdp_buff *xdp)
> -{
> -}
> -
> static inline void xsk_buff_set_size(struct xdp_buff *xdp, u32 size)
> {
> }
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()
2023-06-15 13:49 ` Maciej Fijalkowski
@ 2023-06-15 13:51 ` Maciej Fijalkowski
2023-06-15 14:40 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Maciej Fijalkowski @ 2023-06-15 13:51 UTC (permalink / raw)
To: YueHaibing
Cc: bjorn, magnus.karlsson, jonathan.lemon, davem, edumazet, kuba,
pabeni, ast, daniel, hawk, john.fastabend, netdev, bpf,
linux-kernel, maxtram95
On Thu, Jun 15, 2023 at 03:49:23PM +0200, Maciej Fijalkowski wrote:
> On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> > commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> > left behind this, remove it.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Yeah this is a stub for !CONFIG_XDP_SOCKETS...
Wait, I am not sure if this should go to bpf tree and have fixes tag
pointing to the cited commit?
Functionally this commit does not fix anything but it feels that
f2f167583601 was incomplete.
>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> > ---
> > include/net/xdp_sock_drv.h | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
> > index 9c0d860609ba..c243f906ebed 100644
> > --- a/include/net/xdp_sock_drv.h
> > +++ b/include/net/xdp_sock_drv.h
> > @@ -255,10 +255,6 @@ static inline void xsk_buff_free(struct xdp_buff *xdp)
> > {
> > }
> >
> > -static inline void xsk_buff_discard(struct xdp_buff *xdp)
> > -{
> > -}
> > -
> > static inline void xsk_buff_set_size(struct xdp_buff *xdp, u32 size)
> > {
> > }
> > --
> > 2.34.1
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()
2023-06-15 13:51 ` Maciej Fijalkowski
@ 2023-06-15 14:40 ` Simon Horman
2023-06-16 1:34 ` YueHaibing
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2023-06-15 14:40 UTC (permalink / raw)
To: Maciej Fijalkowski
Cc: YueHaibing, bjorn, magnus.karlsson, jonathan.lemon, davem,
edumazet, kuba, pabeni, ast, daniel, hawk, john.fastabend,
netdev, bpf, linux-kernel, maxtram95
On Thu, Jun 15, 2023 at 03:51:49PM +0200, Maciej Fijalkowski wrote:
> On Thu, Jun 15, 2023 at 03:49:23PM +0200, Maciej Fijalkowski wrote:
> > On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> > > commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> > > left behind this, remove it.
> > >
> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >
> > Yeah this is a stub for !CONFIG_XDP_SOCKETS...
>
> Wait, I am not sure if this should go to bpf tree and have fixes tag
> pointing to the cited commit?
>
> Functionally this commit does not fix anything but it feels that
> f2f167583601 was incomplete.
FWIIW, I think that bpf-next is appropriate for this patch
as it doesn't address a bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()
2023-06-15 14:40 ` Simon Horman
@ 2023-06-16 1:34 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2023-06-16 1:34 UTC (permalink / raw)
To: Simon Horman, Maciej Fijalkowski
Cc: bjorn, magnus.karlsson, jonathan.lemon, davem, edumazet, kuba,
pabeni, ast, daniel, hawk, john.fastabend, netdev, bpf,
linux-kernel, maxtram95
On 2023/6/15 22:40, Simon Horman wrote:
> On Thu, Jun 15, 2023 at 03:51:49PM +0200, Maciej Fijalkowski wrote:
>> On Thu, Jun 15, 2023 at 03:49:23PM +0200, Maciej Fijalkowski wrote:
>>> On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
>>>> commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
>>>> left behind this, remove it.
>>>>
>>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>>
>>> Yeah this is a stub for !CONFIG_XDP_SOCKETS...
>>
>> Wait, I am not sure if this should go to bpf tree and have fixes tag
>> pointing to the cited commit?
>>
>> Functionally this commit does not fix anything but it feels that
>> f2f167583601 was incomplete.
>
> FWIIW, I think that bpf-next is appropriate for this patch
> as it doesn't address a bug.
Ok , will send v2 target to bpf-next.
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-16 1:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15 12:46 [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard() YueHaibing
2023-06-15 13:49 ` Maciej Fijalkowski
2023-06-15 13:51 ` Maciej Fijalkowski
2023-06-15 14:40 ` Simon Horman
2023-06-16 1:34 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.