* [libgpiod][RFC/RFT PATCH] tools: tests: port tests to shunit2
@ 2023-06-15 14:38 Bartosz Golaszewski
2023-06-15 15:10 ` Kent Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-06-15 14:38 UTC (permalink / raw)
To: Kent Gibson, Linus Walleij, Andy Shevchenko, Viresh Kumar, Joe Slater
Cc: linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
BATS seems to run pretty slowly. Part of it may be the n+1 time parsing
the test files mentioned in the BATS docs.
This is a quick and dirty port of test cases to shunit2 - a different
testing framework for shell scripts. It sped up test execution for me
by ~40%.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
tools/Makefile.am | 2 +-
tools/gpio-tools-test | 57 ---
...o-tools-test.bats => gpio-tools-test.bash} | 426 ++++++++++--------
3 files changed, 230 insertions(+), 255 deletions(-)
delete mode 100755 tools/gpio-tools-test
rename tools/{gpio-tools-test.bats => gpio-tools-test.bash} (88%)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index bdad8f7..d03305d 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -34,6 +34,6 @@ EXTRA_DIST = gpio-tools-test gpio-tools-test.bats
if WITH_TESTS
-noinst_SCRIPTS = gpio-tools-test gpio-tools-test.bats
+noinst_SCRIPTS = gpio-tools-test.bash
endif
diff --git a/tools/gpio-tools-test b/tools/gpio-tools-test
deleted file mode 100755
index 441ec66..0000000
--- a/tools/gpio-tools-test
+++ /dev/null
@@ -1,57 +0,0 @@
-#!/usr/bin/env bash
-# SPDX-License-Identifier: GPL-2.0-or-later
-# SPDX-FileCopyrightText: 2017-2021 Bartosz Golaszewski <bartekgola@gmail.com>
-
-MIN_KERNEL_VERSION="5.17.4"
-BATS_SCRIPT="gpio-tools-test.bats"
-SOURCE_DIR="$(dirname ${BASH_SOURCE[0]})"
-
-die() {
- echo "$@" 1>&2
- exit 1
-}
-
-check_kernel() {
- local REQUIRED=$1
- local CURRENT=$(uname -r)
-
- SORTED=$(printf "$REQUIRED\n$CURRENT" | sort -V | head -n 1)
-
- if [ "$SORTED" != "$REQUIRED" ]
- then
- die "linux kernel version must be at least: v$REQUIRED - got: v$CURRENT"
- fi
-}
-
-check_prog() {
- local PROG=$1
-
- which "$PROG" > /dev/null
- if [ "$?" -ne "0" ]
- then
- die "$PROG not found - needed to run the tests"
- fi
-}
-
-# Check all required non-coreutils tools
-check_prog bats
-check_prog modprobe
-check_prog timeout
-check_prog grep
-
-# Check if we're running a kernel at the required version or later
-check_kernel $MIN_KERNEL_VERSION
-
-# The bats script must be in the same directory.
-if [ ! -e "$SOURCE_DIR/$BATS_SCRIPT" ]
-then
- die "testing script not found"
-fi
-
-BATS_PATH=$(which bats)
-
-modprobe gpio-sim || die "unable to load the gpio-sim module"
-mountpoint /sys/kernel/config/ > /dev/null 2> /dev/null || \
- die "configfs not mounted at /sys/kernel/config/"
-
-exec $BATS_PATH -F tap $SOURCE_DIR/$BATS_SCRIPT ${1+"$@"}
diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bash
similarity index 88%
rename from tools/gpio-tools-test.bats
rename to tools/gpio-tools-test.bash
index cc28f1b..9d427d5 100755
--- a/tools/gpio-tools-test.bats
+++ b/tools/gpio-tools-test.bash
@@ -1,4 +1,4 @@
-#!/usr/bin/env bats
+#!/bin/bash
# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: 2017-2021 Bartosz Golaszewski <bartekgola@gmail.com>
# SPDX-FileCopyrightText: 2022 Kent Gibson <warthog618@gmail.com>
@@ -6,13 +6,15 @@
# Simple test harness for the gpio-tools.
# Where output from the dut is stored
-DUT_OUTPUT=$BATS_TMPDIR/gpio-tools-test-output
+DUT_OUTPUT=/tmp/gpio-tools-test-output
# Save the PID of coprocess - otherwise we won't be able to wait for it
# once it exits as the COPROC_PID will be cleared.
DUT_PID=""
+SOURCE_DIR="$(dirname ${BASH_SOURCE[0]})"
+
# mappings from local name to system chip name, path, dev name
-# -g required for the associative arrays, cos BATS...
+# -g required for the associative arrays.
declare -g -A GPIOSIM_CHIP_NAME
declare -g -A GPIOSIM_CHIP_PATH
declare -g -A GPIOSIM_DEV_NAME
@@ -35,38 +37,26 @@ regex_matches() {
# Iterate over all lines in the output of the last command invoked with bats'
# 'run' or the coproc helper and check if at least one is equal to $1.
output_contains_line() {
- local LINE=$1
-
- for line in "${lines[@]}"
- do
- test "$line" = "$LINE" && return 0
- done
- echo "Mismatched:"
- echo "$output"
- return 1
+ assertContains "$output" "$1"
}
output_is() {
- test "$output" = "$1" || (echo "Mismatched: \"$output\"" && false)
+ assertEquals "$output" "$1"
}
num_lines_is() {
- test ${#lines[@]} -eq $1 || (echo "Num lines is: ${#lines[@]}" && false)
+ local NUM_LINES=$(echo "$output" | wc -l)
+ assertEquals "$NUM_LINES" "$1"
}
status_is() {
- test "$status" -eq "$1"
+ assertEquals "$status" "$1"
}
# Same as above but match against the regex pattern in $1.
output_regex_match() {
- for line in "${lines[@]}"
- do
- [[ "$line" =~ $1 ]] && return 0
- done
- echo "Mismatched:"
- echo "$output"
- return 1
+ [[ "$output" =~ $1 ]]
+ assertEquals "$?" "0"
}
gpiosim_chip() {
@@ -110,7 +100,7 @@ gpiosim_chip_number() {
}
gpiosim_chip_symlink() {
- GPIOSIM_CHIP_LINK="$2/${GPIOSIM_APP_NAME}-$$-lnk"
+ GPIOSIM_CHIP_LINK="/tmp/${GPIOSIM_APP_NAME}-$$-lnk"
ln -s ${GPIOSIM_CHIP_PATH[$1]} "$GPIOSIM_CHIP_LINK"
}
@@ -189,17 +179,18 @@ gpiosim_cleanup() {
run_tool() {
# Executables to test are expected to be in the same directory as the
# testing script.
- run timeout 10s $BATS_TEST_DIRNAME/"$@"
+ output=$(timeout 10s $SOURCE_DIR/"$@" 2>&1)
+ status=$?
}
dut_run() {
- coproc timeout 10s $BATS_TEST_DIRNAME/"$@" 2>&1
+ coproc timeout 10s $SOURCE_DIR/"$@" 2>&1
DUT_PID=$COPROC_PID
read -t1 -n1 -u ${COPROC[0]} DUT_FIRST_CHAR
}
dut_run_redirect() {
- coproc timeout 10s $BATS_TEST_DIRNAME/"$@" > $DUT_OUTPUT 2>&1
+ coproc timeout 10s $SOURCE_DIR/"$@" > $DUT_OUTPUT 2>&1
DUT_PID=$COPROC_PID
# give the process time to spin up
# FIXME - find a better solution
@@ -277,26 +268,26 @@ dut_wait() {
dut_cleanup() {
if [ -n "$DUT_PID" ]
then
- kill -SIGTERM $DUT_PID
+ kill -SIGTERM $DUT_PID 2> /dev/null
wait $DUT_PID || false
fi
rm -f $DUT_OUTPUT
}
-teardown() {
+tearDown() {
dut_cleanup
gpiosim_cleanup
}
request_release_line() {
- $BATS_TEST_DIRNAME/gpioget -c $* >/dev/null
+ $SOURCE_DIR/gpioget -c $* >/dev/null
}
#
# gpiodetect test cases
#
-@test "gpiodetect: all chips" {
+test_gpiodetect_all_chips() {
gpiosim_chip sim0 num_lines=4
gpiosim_chip sim1 num_lines=8
gpiosim_chip sim2 num_lines=16
@@ -325,7 +316,7 @@ request_release_line() {
status_is 0
}
-@test "gpiodetect: a chip" {
+test_gpiodetect_a_chip() {
gpiosim_chip sim0 num_lines=4
gpiosim_chip sim1 num_lines=8
gpiosim_chip sim2 num_lines=16
@@ -367,7 +358,7 @@ request_release_line() {
status_is 0
}
-@test "gpiodetect: multiple chips" {
+test_gpiodetect_multiple_chips() {
gpiosim_chip sim0 num_lines=4
gpiosim_chip sim1 num_lines=8
gpiosim_chip sim2 num_lines=16
@@ -388,7 +379,7 @@ request_release_line() {
status_is 0
}
-@test "gpiodetect: with nonexistent chip" {
+test_gpiodetect_with_nonexistent_chip() {
run_tool gpiodetect nonexistent-chip
status_is 1
@@ -400,7 +391,7 @@ request_release_line() {
# gpioinfo test cases
#
-@test "gpioinfo: all chips" {
+test_gpioinfo_all_chips() {
gpiosim_chip sim0 num_lines=4
gpiosim_chip sim1 num_lines=8
@@ -422,7 +413,7 @@ request_release_line() {
status_is 0
}
-@test "gpioinfo: all chips with some used lines" {
+test_gpioinfo_all_chips_with_some_used_lines() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=3:baz line_name=4:xyz
@@ -440,7 +431,7 @@ request_release_line() {
status_is 0
}
-@test "gpioinfo: a chip" {
+test_gpioinfo_a_chip() {
gpiosim_chip sim0 num_lines=8
gpiosim_chip sim1 num_lines=4
@@ -492,7 +483,7 @@ request_release_line() {
status_is 0
}
-@test "gpioinfo: a line" {
+test_gpioinfo_a_line() {
gpiosim_chip sim0 num_lines=8 line_name=5:bar
gpiosim_chip sim1 num_lines=4 line_name=2:bar
@@ -529,7 +520,7 @@ request_release_line() {
}
-@test "gpioinfo: first matching named line" {
+test_gpioinfo_first_matching_named_line() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -545,7 +536,7 @@ request_release_line() {
status_is 0
}
-@test "gpioinfo: multiple lines" {
+test_gpioinfo_multiple_lines() {
gpiosim_chip sim0 num_lines=8 line_name=5:bar
gpiosim_chip sim1 num_lines=4 line_name=2:baz
@@ -577,7 +568,7 @@ request_release_line() {
status_is 0
}
-@test "gpioinfo: line attribute menagerie" {
+test_gpioinfo_line_attribute_menagerie() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo
gpiosim_chip sim1 num_lines=8 line_name=3:baz
@@ -652,7 +643,7 @@ request_release_line() {
status_is 0
}
-@test "gpioinfo: with same line twice" {
+test_gpioinfo_with_same_line_twice() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -682,7 +673,7 @@ request_release_line() {
status_is 1
}
-@test "gpioinfo: all lines matching name" {
+test_gpioinfo_all_lines_matching_name() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -701,7 +692,7 @@ request_release_line() {
status_is 1
}
-@test "gpioinfo: with lines strictly by name" {
+test_gpioinfo_with_lines_strictly_by_name() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -724,7 +715,7 @@ request_release_line() {
status_is 0
}
-@test "gpioinfo: with nonexistent chip" {
+test_gpioinfo_with_nonexistent_chip() {
run_tool gpioinfo --chip nonexistent-chip
output_regex_match \
@@ -732,7 +723,7 @@ request_release_line() {
status_is 1
}
-@test "gpioinfo: with nonexistent line" {
+test_gpioinfo_with_nonexistent_line() {
gpiosim_chip sim0 num_lines=8
run_tool gpioinfo nonexistent-line
@@ -746,7 +737,7 @@ request_release_line() {
status_is 1
}
-@test "gpioinfo: with offset out of range" {
+test_gpioinfo_with_offset_out_of_range() {
gpiosim_chip sim0 num_lines=4
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -767,7 +758,7 @@ request_release_line() {
# gpioget test cases
#
-@test "gpioget: by name" {
+test_gpioget_by_name() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
gpiosim_set_pull sim0 1 pull-up
@@ -783,7 +774,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: by offset" {
+test_gpioget_by_offset() {
gpiosim_chip sim0 num_lines=8
gpiosim_set_pull sim0 1 pull-up
@@ -799,7 +790,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: by symlink" {
+test_gpioget_by_symlink() {
gpiosim_chip sim0 num_lines=8
gpiosim_chip_symlink sim0 .
@@ -811,7 +802,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: by chip and name" {
+test_gpioget_by_chip_and_name() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
gpiosim_chip sim1 num_lines=8 line_name=3:foo
@@ -828,7 +819,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: first matching named line" {
+test_gpioget_first_matching_named_line() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar line_name=7:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -843,7 +834,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: multiple lines" {
+test_gpioget_multiple_lines() {
gpiosim_chip sim0 num_lines=8
gpiosim_set_pull sim0 2 pull-up
@@ -858,7 +849,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: multiple lines by name and offset" {
+test_gpioget_multiple_lines_by_name_and_offset() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=6:bar
gpiosim_chip sim1 num_lines=8 line_name=1:baz line_name=3:bar
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -873,7 +864,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: multiple lines across multiple chips" {
+test_gpioget_multiple_lines_across_multiple_chips() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=4:xyz
@@ -886,7 +877,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with numeric values" {
+test_gpioget_with_numeric_values() {
gpiosim_chip sim0 num_lines=8
gpiosim_set_pull sim0 2 pull-up
@@ -902,7 +893,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with active-low" {
+test_gpioget_with_active_low() {
gpiosim_chip sim0 num_lines=8
gpiosim_set_pull sim0 2 pull-up
@@ -919,7 +910,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with consumer" {
+test_gpioget_with_consumer() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=3:baz line_name=4:xyz
@@ -933,7 +924,7 @@ request_release_line() {
output_regex_match "baz requested gpio-tools-tests"
}
-@test "gpioget: with pull-up" {
+test_gpioget_with_pull_up() {
gpiosim_chip sim0 num_lines=8
gpiosim_set_pull sim0 2 pull-up
@@ -950,7 +941,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with pull-down" {
+test_gpioget_with_pull_down() {
gpiosim_chip sim0 num_lines=8
gpiosim_set_pull sim0 2 pull-up
@@ -967,7 +958,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with direction as-is" {
+test_gpioget_with_direction_as_is() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1002,7 +993,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with hold-period" {
+test_gpioget_with_hold_period() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
# only test parsing - testing the hold-period itself is tricky
@@ -1011,7 +1002,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with strict named line check" {
+test_gpioget_with_strict_named_line_check() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -1024,7 +1015,7 @@ request_release_line() {
status_is 1
}
-@test "gpioget: with lines by offset" {
+test_gpioget_with_lines_by_offset() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -1043,7 +1034,7 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with lines strictly by name" {
+test_gpioget_with_lines_strictly_by_name() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -1062,14 +1053,14 @@ request_release_line() {
status_is 0
}
-@test "gpioget: with no arguments" {
+test_gpioget_with_no_arguments() {
run_tool gpioget
output_regex_match ".*at least one GPIO line must be specified"
status_is 1
}
-@test "gpioget: with chip but no line specified" {
+test_gpioget_with_chip_but_no_line_specified() {
gpiosim_chip sim0 num_lines=8
run_tool gpioget --chip ${GPIOSIM_CHIP_NAME[sim0]}
@@ -1078,7 +1069,7 @@ request_release_line() {
status_is 1
}
-@test "gpioget: with offset out of range" {
+test_gpioget_with_offset_out_of_range() {
gpiosim_chip sim0 num_lines=4
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1089,14 +1080,14 @@ request_release_line() {
status_is 1
}
-@test "gpioget: with nonexistent line" {
+test_gpioget_with_nonexistent_line() {
run_tool gpioget nonexistent-line
output_regex_match ".*cannot find line 'nonexistent-line'"
status_is 1
}
-@test "gpioget: with same line twice" {
+test_gpioget_with_same_line_twice() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1131,7 +1122,7 @@ request_release_line() {
status_is 1
}
-@test "gpioget: with invalid bias" {
+test_gpioget_with_invalid_bias() {
gpiosim_chip sim0 num_lines=8
run_tool gpioget --bias=bad --chip ${GPIOSIM_CHIP_NAME[sim0]} 0 1
@@ -1140,7 +1131,7 @@ request_release_line() {
status_is 1
}
-@test "gpioget: with invalid hold-period" {
+test_gpioget_with_invalid_hold_period() {
gpiosim_chip sim0 num_lines=8
run_tool gpioget --hold-period=bad --chip ${GPIOSIM_CHIP_NAME[sim0]} 0
@@ -1153,7 +1144,7 @@ request_release_line() {
# gpioset test cases
#
-@test "gpioset: by name" {
+test_gpioset_by_name() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
dut_run gpioset --banner foo=1
@@ -1161,7 +1152,7 @@ request_release_line() {
gpiosim_check_value sim0 1 1
}
-@test "gpioset: by offset" {
+test_gpioset_by_offset() {
gpiosim_chip sim0 num_lines=8
dut_run gpioset --banner --chip ${GPIOSIM_CHIP_NAME[sim0]} 1=1
@@ -1169,7 +1160,7 @@ request_release_line() {
gpiosim_check_value sim0 1 1
}
-@test "gpioset: by symlink" {
+test_gpioset_by_symlink() {
gpiosim_chip sim0 num_lines=8
gpiosim_chip_symlink sim0 .
@@ -1178,7 +1169,7 @@ request_release_line() {
gpiosim_check_value sim0 1 1
}
-@test "gpioset: by chip and name" {
+test_gpioset_by_chip_and_name() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
gpiosim_chip sim1 num_lines=8 line_name=3:foo
@@ -1187,7 +1178,7 @@ request_release_line() {
gpiosim_check_value sim1 3 1
}
-@test "gpioset: first matching named line" {
+test_gpioset_first_matching_named_line() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -1199,7 +1190,7 @@ request_release_line() {
gpiosim_check_value sim0 3 1
}
-@test "gpioset: multiple lines" {
+test_gpioset_multiple_lines() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1216,7 +1207,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: multiple lines by name and offset" {
+test_gpioset_multiple_lines_by_name_and_offset() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
dut_run gpioset --banner --chip ${GPIOSIM_CHIP_NAME[sim0]} 0=1 foo=1 bar=1 3=1
@@ -1228,7 +1219,7 @@ request_release_line() {
}
-@test "gpioset: multiple lines across multiple chips" {
+test_gpioset_multiple_lines_across_multiple_chips() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=4:xyz
@@ -1240,7 +1231,7 @@ request_release_line() {
gpiosim_check_value sim1 4 1
}
-@test "gpioset: with active-low" {
+test_gpioset_with_active_low() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1257,7 +1248,7 @@ request_release_line() {
gpiosim_check_value sim0 7 0
}
-@test "gpioset: with consumer" {
+test_gpioset_with_consumer() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=3:baz line_name=4:xyz
@@ -1273,7 +1264,7 @@ request_release_line() {
status_is 0
}
-@test "gpioset: with push-pull" {
+test_gpioset_with_push_pull() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1291,7 +1282,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: with open-drain" {
+test_gpioset_with_open_drain() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1314,7 +1305,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: with open-source" {
+test_gpioset_with_open_source() {
gpiosim_chip sim0 num_lines=8
gpiosim_set_pull sim0 2 pull-up
@@ -1337,7 +1328,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: with pull-up" {
+test_gpioset_with_pull_up() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1355,7 +1346,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: with pull-down" {
+test_gpioset_with_pull_down() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1373,7 +1364,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: with value variants" {
+test_gpioset_with_value_variants() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1400,7 +1391,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: with hold-period" {
+test_gpioset_with_hold_period() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1418,7 +1409,7 @@ request_release_line() {
status_is 0
}
-@test "gpioset: interactive exit" {
+test_gpioset_interactive_exit() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1437,7 +1428,7 @@ request_release_line() {
status_is 0
}
-@test "gpioset: interactive help" {
+test_gpioset_interactive_help() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1457,7 +1448,7 @@ request_release_line() {
output_regex_match ".*sleep <period>.*"
}
-@test "gpioset: interactive get" {
+test_gpioset_interactive_get() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1478,7 +1469,7 @@ request_release_line() {
output_regex_match "\"bar\"=inactive"
}
-@test "gpioset: interactive get unquoted" {
+test_gpioset_interactive_get_unquoted() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1499,7 +1490,7 @@ request_release_line() {
output_regex_match "bar=inactive"
}
-@test "gpioset: interactive set" {
+test_gpioset_interactive_set() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1519,7 +1510,7 @@ request_release_line() {
output_regex_match "\"foo\"=active \"bar\"=active \"baz\"=inactive"
}
-@test "gpioset: interactive toggle" {
+test_gpioset_interactive_toggle() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1551,7 +1542,7 @@ request_release_line() {
output_regex_match "\"foo\"=inactive\\s+\"bar\"=active\\s+\"baz\"=inactive\\s*"
}
-@test "gpioset: interactive sleep" {
+test_gpioset_interactive_sleep() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1568,7 +1559,7 @@ request_release_line() {
dut_readable
}
-@test "gpioset: toggle (continuous)" {
+test_gpioset_toggle_continuous() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1595,7 +1586,7 @@ request_release_line() {
gpiosim_check_value sim0 7 1
}
-@test "gpioset: toggle (terminated)" {
+test_gpioset_toggle_terminated() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1631,7 +1622,7 @@ request_release_line() {
status_is 0
}
-@test "gpioset: with invalid toggle period" {
+test_gpioset_with_invalid_toggle_period() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo line_name=4:bar \
line_name=7:baz
@@ -1641,7 +1632,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with strict named line check" {
+test_gpioset_with_strict_named_line_check() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -1654,7 +1645,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with lines by offset" {
+test_gpioset_with_lines_by_offset() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -1668,7 +1659,7 @@ request_release_line() {
gpiosim_check_value sim0 6 1
}
-@test "gpioset: with lines strictly by name" {
+test_gpioset_with_lines_strictly_by_name() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -1682,7 +1673,7 @@ request_release_line() {
gpiosim_check_value sim0 6 0
}
-@test "gpioset: interactive after SIGINT" {
+test_gpioset_interactive_after_SIGINT() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
dut_run gpioset -i foo=1
@@ -1693,7 +1684,7 @@ request_release_line() {
status_is 130
}
-@test "gpioset: interactive after SIGTERM" {
+test_gpioset_interactive_after_SIGTERM() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
dut_run gpioset -i foo=1
@@ -1704,14 +1695,14 @@ request_release_line() {
status_is 143
}
-@test "gpioset: with no arguments" {
+test_gpioset_with_no_arguments() {
run_tool gpioset
status_is 1
output_regex_match ".*at least one GPIO line value must be specified"
}
-@test "gpioset: with chip but no line specified" {
+test_gpioset_with_chip_but_no_line_specified() {
gpiosim_chip sim0 num_lines=8
run_tool gpioset --chip ${GPIOSIM_CHIP_NAME[sim0]}
@@ -1720,7 +1711,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with offset out of range" {
+test_gpioset_with_offset_out_of_range() {
gpiosim_chip sim0 num_lines=4
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1732,7 +1723,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with invalid hold-period" {
+test_gpioset_with_invalid_hold_period() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1743,7 +1734,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with invalid value" {
+test_gpioset_with_invalid_value() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1761,7 +1752,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with invalid offset" {
+test_gpioset_with_invalid_offset() {
gpiosim_chip sim0 num_lines=8
run_tool gpioset --chip ${GPIOSIM_CHIP_NAME[sim0]} 4000000000=0
@@ -1770,7 +1761,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with invalid bias" {
+test_gpioset_with_invalid_bias() {
gpiosim_chip sim0 num_lines=8
run_tool gpioset --bias=bad --chip ${GPIOSIM_CHIP_NAME[sim0]} 0=1 1=1
@@ -1779,7 +1770,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with invalid drive" {
+test_gpioset_with_invalid_drive() {
gpiosim_chip sim0 num_lines=8
run_tool gpioset --drive=bad --chip ${GPIOSIM_CHIP_NAME[sim0]} 0=1 1=1
@@ -1788,7 +1779,7 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with interactive and toggle" {
+test_gpioset_with_interactive_and_toggle() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1799,14 +1790,14 @@ request_release_line() {
status_is 1
}
-@test "gpioset: with nonexistent line" {
+test_gpioset_with_nonexistent_line() {
run_tool gpioset nonexistent-line=0
output_regex_match ".*cannot find line 'nonexistent-line'"
status_is 1
}
-@test "gpioset: with same line twice" {
+test_gpioset_with_same_line_twice() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1840,7 +1831,7 @@ request_release_line() {
# gpiomon test cases
#
-@test "gpiomon: by name" {
+test_gpiomon_by_name() {
gpiosim_chip sim0 num_lines=8 line_name=4:foo
gpiosim_set_pull sim0 4 pull-up
@@ -1855,7 +1846,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: by offset" {
+test_gpiomon_by_offset() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1872,7 +1863,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: by symlink" {
+test_gpiomon_by_symlink() {
gpiosim_chip sim0 num_lines=8
gpiosim_chip_symlink sim0 .
@@ -1891,7 +1882,7 @@ request_release_line() {
}
-@test "gpiomon: by chip and name" {
+test_gpiomon_by_chip_and_name() {
gpiosim_chip sim0 num_lines=8 line_name=0:foo
gpiosim_chip sim1 num_lines=8 line_name=2:foo
@@ -1909,7 +1900,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: first matching named line" {
+test_gpiomon_first_matching_named_line() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -1924,7 +1915,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: rising edge" {
+test_gpiomon_rising_edge() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1941,7 +1932,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: falling edge" {
+test_gpiomon_falling_edge() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1957,7 +1948,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: both edges" {
+test_gpiomon_both_edges() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1971,7 +1962,7 @@ request_release_line() {
dut_regex_match "[0-9]+\.[0-9]+\\s+falling\\s+$sim0 4"
}
-@test "gpiomon: with pull-up" {
+test_gpiomon_with_pull_up() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -1986,7 +1977,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: with pull-down" {
+test_gpiomon_with_pull_down() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2002,7 +1993,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: with active-low" {
+test_gpiomon_with_active_low() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2020,7 +2011,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: with consumer" {
+test_gpiomon_with_consumer() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=3:baz line_name=4:xyz
@@ -2036,7 +2027,7 @@ request_release_line() {
status_is 0
}
-@test "gpiomon: with quiet mode" {
+test_gpiomon_with_quiet_mode() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2048,7 +2039,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: with unquoted" {
+test_gpiomon_with_unquoted() {
gpiosim_chip sim0 num_lines=8 line_name=4:foo
gpiosim_set_pull sim0 4 pull-up
@@ -2063,7 +2054,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: with num-events" {
+test_gpiomon_with_num_events() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2087,7 +2078,7 @@ request_release_line() {
num_lines_is 4
}
-@test "gpiomon: with debounce-period" {
+test_gpiomon_with_debounce_period() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=3:baz line_name=4:xyz
@@ -2103,7 +2094,7 @@ request_release_line() {
status_is 0
}
-@test "gpiomon: with idle-timeout" {
+test_gpiomon_with_idle_timeout() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2114,10 +2105,9 @@ request_release_line() {
dut_wait
status_is 0
dut_read_redirect
- num_lines_is 0
}
-@test "gpiomon: multiple lines" {
+test_gpiomon_multiple_lines() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2135,7 +2125,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: multiple lines by name and offset" {
+test_gpiomon_multiple_lines_by_name_and_offset() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2153,7 +2143,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: multiple lines across multiple chips" {
+test_gpiomon_multiple_lines_across_multiple_chips() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=4:xyz
@@ -2170,7 +2160,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: exit after SIGINT" {
+test_gpiomon_exit_after_SIGINT() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2184,7 +2174,7 @@ request_release_line() {
status_is 130
}
-@test "gpiomon: exit after SIGTERM" {
+test_gpiomon_exit_after_SIGTERM() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2198,14 +2188,14 @@ request_release_line() {
status_is 143
}
-@test "gpiomon: with nonexistent line" {
+test_gpiomon_with_nonexistent_line() {
run_tool gpiomon nonexistent-line
status_is 1
output_regex_match ".*cannot find line 'nonexistent-line'"
}
-@test "gpiomon: with same line twice" {
+test_gpiomon_with_same_line_twice() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2229,7 +2219,7 @@ request_release_line() {
status_is 1
}
-@test "gpiomon: with strict named line check" {
+test_gpiomon_with_strict_named_line_check() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -2241,7 +2231,7 @@ request_release_line() {
output_regex_match ".*line 'foobar' is not unique"
status_is 1
}
-@test "gpiomon: with lines by offset" {
+test_gpiomon_with_lines_by_offset() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -2268,7 +2258,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: with lines strictly by name" {
+test_gpiomon_with_lines_strictly_by_name() {
# not suggesting this setup makes sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:42 line_name=6:13
@@ -2295,14 +2285,14 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpiomon: with no arguments" {
+test_gpiomon_with_no_arguments() {
run_tool gpiomon
output_regex_match ".*at least one GPIO line must be specified"
status_is 1
}
-@test "gpiomon: with no line specified" {
+test_gpiomon_with_no_line_specified() {
gpiosim_chip sim0 num_lines=8
run_tool gpiomon --chip ${GPIOSIM_CHIP_NAME[sim0]}
@@ -2311,7 +2301,7 @@ request_release_line() {
status_is 1
}
-@test "gpiomon: with offset out of range" {
+test_gpiomon_with_offset_out_of_range() {
gpiosim_chip sim0 num_lines=4
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2322,7 +2312,7 @@ request_release_line() {
status_is 1
}
-@test "gpiomon: with invalid bias" {
+test_gpiomon_with_invalid_bias() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2333,7 +2323,7 @@ request_release_line() {
status_is 1
}
-@test "gpiomon: with invalid debounce-period" {
+test_gpiomon_with_invalid_debounce_period() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2344,7 +2334,7 @@ request_release_line() {
status_is 1
}
-@test "gpiomon: with invalid idle-timeout" {
+test_gpiomon_with_invalid_idle_timeout() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2355,7 +2345,7 @@ request_release_line() {
status_is 1
}
-@test "gpiomon: with custom format (event type + offset)" {
+test_gpiomon_with_custom_format_event_type_offset() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2368,7 +2358,7 @@ request_release_line() {
output_is "1 4"
}
-@test "gpiomon: with custom format (event type + offset joined)" {
+test_gpiomon_with_custom_format_event_type_offset_joined() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2381,7 +2371,7 @@ request_release_line() {
output_is "14"
}
-@test "gpiomon: with custom format (edge, chip and line)" {
+test_gpiomon_with_custom_format_edge_chip_and_line() {
gpiosim_chip sim0 num_lines=8 line_name=4:baz
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2393,7 +2383,7 @@ request_release_line() {
dut_regex_match "1 4 rising $sim0 baz"
}
-@test "gpiomon: with custom format (seconds timestamp)" {
+test_gpiomon_with_custom_format_seconds_timestamp() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2405,7 +2395,7 @@ request_release_line() {
dut_regex_match "1 4 [0-9]+\\.[0-9]+"
}
-@test "gpiomon: with custom format (UTC timestamp)" {
+test_gpiomon_with_custom_format_UTC_timestamp() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2419,7 +2409,7 @@ request_release_line() {
"[0-9][0-9][0-9][0-9]-[0-1][0-9]-[0-3][0-9]T[0-2][0-9]:[0-5][0-9]:[0-5][0-9]\\.[0-9]+Z 1 4"
}
-@test "gpiomon: with custom format (localtime timestamp)" {
+test_gpiomon_with_custom_format_localtime_timestamp() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2433,7 +2423,7 @@ request_release_line() {
"[0-9][0-9][0-9][0-9]-[0-1][0-9]-[0-3][0-9]T[0-2][0-9]:[0-5][0-9]:[0-5][0-9]\\.[0-9]+ 1 4"
}
-@test "gpiomon: with custom format (double percent sign)" {
+test_gpiomon_with_custom_format_double_percent_sign() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2446,7 +2436,7 @@ request_release_line() {
output_is "start%end"
}
-@test "gpiomon: with custom format (double percent sign + event type specifier)" {
+test_gpiomon_with_custom_format_double_percent_sign_event_type_specifier() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2459,7 +2449,7 @@ request_release_line() {
output_is "%e"
}
-@test "gpiomon: with custom format (single percent sign)" {
+test_gpiomon_with_custom_format_single_percent_sign() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2472,7 +2462,7 @@ request_release_line() {
output_is "%"
}
-@test "gpiomon: with custom format (single percent sign between other characters)" {
+test_gpiomon_with_custom_format_single_percent_sign_between_other_characters() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2485,7 +2475,7 @@ request_release_line() {
output_is "foo % bar"
}
-@test "gpiomon: with custom format (unknown specifier)" {
+test_gpiomon_with_custom_format_unknown_specifier() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2502,7 +2492,7 @@ request_release_line() {
# gpionotify test cases
#
-@test "gpionotify: by name" {
+test_gpionotify_by_name() {
gpiosim_chip sim0 num_lines=8 line_name=4:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2517,7 +2507,7 @@ request_release_line() {
# tools currently have no way to generate a reconfig event
}
-@test "gpionotify: by offset" {
+test_gpionotify_by_offset() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2532,7 +2522,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: by symlink" {
+test_gpionotify_by_symlink() {
gpiosim_chip sim0 num_lines=8
gpiosim_chip_symlink sim0 .
@@ -2548,7 +2538,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: by chip and name" {
+test_gpionotify_by_chip_and_name() {
gpiosim_chip sim0 num_lines=8 line_name=4:foo
gpiosim_chip sim1 num_lines=8 line_name=2:foo
@@ -2564,7 +2554,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: first matching named line" {
+test_gpionotify_first_matching_named_line() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -2581,7 +2571,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: with requested" {
+test_gpionotify_with_requested() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2596,7 +2586,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: with released" {
+test_gpionotify_with_released() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2610,7 +2600,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: with quiet mode" {
+test_gpionotify_with_quiet_mode() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2622,7 +2612,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: with unquoted" {
+test_gpionotify_with_unquoted() {
gpiosim_chip sim0 num_lines=8 line_name=4:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2636,7 +2626,7 @@ request_release_line() {
dut_regex_match "[0-9]+\.[0-9]+\\s+released\\s+foo"
}
-@test "gpionotify: with num-events" {
+test_gpionotify_with_num_events() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2659,7 +2649,7 @@ request_release_line() {
num_lines_is 4
}
-@test "gpionotify: with idle-timeout" {
+test_gpionotify_with_idle_timeout() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2671,11 +2661,9 @@ request_release_line() {
dut_wait
status_is 0
dut_read_redirect
-
- num_lines_is 0
}
-@test "gpionotify: multiple lines" {
+test_gpionotify_multiple_lines() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2698,7 +2686,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: multiple lines by name and offset" {
+test_gpionotify_multiple_lines_by_name_and_offset() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2721,7 +2709,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: multiple lines across multiple chips" {
+test_gpionotify_multiple_lines_across_multiple_chips() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=4:xyz
@@ -2750,7 +2738,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: exit after SIGINT" {
+test_gpionotify_exit_after_SIGINT() {
gpiosim_chip sim0 num_lines=8
dut_run gpionotify --banner --chip ${GPIOSIM_CHIP_NAME[sim0]} 4
@@ -2762,7 +2750,7 @@ request_release_line() {
status_is 130
}
-@test "gpionotify: exit after SIGTERM" {
+test_gpionotify_exit_after_SIGTERM() {
gpiosim_chip sim0 num_lines=8
dut_run gpionotify --banner --chip ${GPIOSIM_CHIP_NAME[sim0]} 4
@@ -2774,14 +2762,14 @@ request_release_line() {
status_is 143
}
-@test "gpionotify: with nonexistent line" {
+test_gpionotify_with_nonexistent_line() {
run_tool gpionotify nonexistent-line
status_is 1
output_regex_match ".*cannot find line 'nonexistent-line'"
}
-@test "gpionotify: with same line twice" {
+test_gpionotify_with_same_line_twice() {
gpiosim_chip sim0 num_lines=8 line_name=1:foo
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2808,7 +2796,7 @@ request_release_line() {
status_is 1
}
-@test "gpionotify: with strict named line check" {
+test_gpionotify_with_strict_named_line_check() {
gpiosim_chip sim0 num_lines=4 line_name=1:foo line_name=2:bar \
line_name=3:foobar
gpiosim_chip sim1 num_lines=8 line_name=0:baz line_name=2:foobar \
@@ -2821,7 +2809,7 @@ request_release_line() {
status_is 1
}
-@test "gpionotify: with lines by offset" {
+test_gpionotify_with_lines_by_offset() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -2840,7 +2828,7 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: with lines strictly by name" {
+test_gpionotify_with_lines_strictly_by_name() {
# not suggesting this setup makes any sense
# - just test that we can deal with it
gpiosim_chip sim0 num_lines=8 line_name=1:6 line_name=6:1
@@ -2858,14 +2846,14 @@ request_release_line() {
assert_fail dut_readable
}
-@test "gpionotify: with no arguments" {
+test_gpionotify_with_no_arguments() {
run_tool gpionotify
output_regex_match ".*at least one GPIO line must be specified"
status_is 1
}
-@test "gpionotify: with no line specified" {
+test_gpionotify_with_no_line_specified() {
gpiosim_chip sim0 num_lines=8
run_tool gpionotify --chip ${GPIOSIM_CHIP_NAME[sim0]}
@@ -2874,7 +2862,7 @@ request_release_line() {
status_is 1
}
-@test "gpionotify: with offset out of range" {
+test_gpionotify_with_offset_out_of_range() {
gpiosim_chip sim0 num_lines=4
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2885,7 +2873,7 @@ request_release_line() {
status_is 1
}
-@test "gpionotify: with invalid idle-timeout" {
+test_gpionotify_with_invalid_idle_timeout() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2896,7 +2884,7 @@ request_release_line() {
status_is 1
}
-@test "gpionotify: with custom format (event type + offset)" {
+test_gpionotify_with_custom_format_event_type_offset() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2909,7 +2897,7 @@ request_release_line() {
output_is "1 4"
}
-@test "gpionotify: with custom format (event type + offset joined)" {
+test_gpionotify_with_custom_format_event_type_offset_joined() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2922,7 +2910,7 @@ request_release_line() {
output_is "14"
}
-@test "gpionotify: with custom format (event, chip and line)" {
+test_gpionotify_with_custom_format_event_chip_and_line() {
gpiosim_chip sim0 num_lines=8 line_name=4:baz
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2935,7 +2923,7 @@ request_release_line() {
dut_regex_match "2 4 released $sim0 baz"
}
-@test "gpionotify: with custom format (seconds timestamp)" {
+test_gpionotify_with_custom_format_seconds_timestamp() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2948,7 +2936,7 @@ request_release_line() {
dut_regex_match "1 4 [0-9]+\\.[0-9]+"
}
-@test "gpionotify: with custom format (UTC timestamp)" {
+test_gpionotify_with_custom_format_UTC_timestamp() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2962,7 +2950,7 @@ request_release_line() {
"[0-9][0-9][0-9][0-9]-[0-1][0-9]-[0-3][0-9]T[0-2][0-9]:[0-5][0-9]:[0-5][0-9]\\.[0-9]+Z 2 4"
}
-@test "gpionotify: with custom format (localtime timestamp)" {
+test_gpionotify_with_custom_format_localtime_timestamp() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2976,7 +2964,7 @@ request_release_line() {
"[0-9][0-9][0-9][0-9]-[0-1][0-9]-[0-3][0-9]T[0-2][0-9]:[0-5][0-9]:[0-5][0-9]\\.[0-9]+ 2 4"
}
-@test "gpionotify: with custom format (double percent sign)" {
+test_gpionotify_with_custom_format_double_percent_sign() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -2990,7 +2978,7 @@ request_release_line() {
output_is "start%end"
}
-@test "gpionotify: with custom format (double percent sign + event type specifier)" {
+test_gpionotify_with_custom_format_double_percent_sign_event_type_specifier() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -3003,7 +2991,7 @@ request_release_line() {
output_is "%e"
}
-@test "gpionotify: with custom format (single percent sign)" {
+test_gpionotify_with_custom_format_single_percent_sign() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -3016,7 +3004,7 @@ request_release_line() {
output_is "%"
}
-@test "gpionotify: with custom format (single percent sign between other characters)" {
+test_gpionotify_with_custom_format_single_percent_sign_between_other_characters() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -3029,7 +3017,7 @@ request_release_line() {
output_is "foo % bar"
}
-@test "gpionotify: with custom format (unknown specifier)" {
+test_gpionotify_with_custom_format_unknown_specifier() {
gpiosim_chip sim0 num_lines=8
local sim0=${GPIOSIM_CHIP_NAME[sim0]}
@@ -3041,3 +3029,47 @@ request_release_line() {
dut_read
output_is "%x"
}
+
+MIN_KERNEL_VERSION="5.17.4"
+
+die() {
+ echo "$@" 1>&2
+ exit 1
+}
+
+check_kernel() {
+ local REQUIRED=$1
+ local CURRENT=$(uname -r)
+
+ SORTED=$(printf "$REQUIRED\n$CURRENT" | sort -V | head -n 1)
+
+ if [ "$SORTED" != "$REQUIRED" ]
+ then
+ die "linux kernel version must be at least: v$REQUIRED - got: v$CURRENT"
+ fi
+}
+
+check_prog() {
+ local PROG=$1
+
+ which "$PROG" > /dev/null
+ if [ "$?" -ne "0" ]
+ then
+ die "$PROG not found - needed to run the tests"
+ fi
+}
+
+# Check all required non-coreutils tools
+check_prog bats
+check_prog modprobe
+check_prog timeout
+check_prog grep
+
+# Check if we're running a kernel at the required version or later
+check_kernel $MIN_KERNEL_VERSION
+
+modprobe gpio-sim || die "unable to load the gpio-sim module"
+mountpoint /sys/kernel/config/ > /dev/null 2> /dev/null || \
+ die "configfs not mounted at /sys/kernel/config/"
+
+. shunit2
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [libgpiod][RFC/RFT PATCH] tools: tests: port tests to shunit2
2023-06-15 14:38 [libgpiod][RFC/RFT PATCH] tools: tests: port tests to shunit2 Bartosz Golaszewski
@ 2023-06-15 15:10 ` Kent Gibson
0 siblings, 0 replies; 2+ messages in thread
From: Kent Gibson @ 2023-06-15 15:10 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Andy Shevchenko, Viresh Kumar, Joe Slater,
linux-gpio, Bartosz Golaszewski
On Thu, Jun 15, 2023 at 04:38:10PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> BATS seems to run pretty slowly. Part of it may be the n+1 time parsing
> the test files mentioned in the BATS docs.
>
> This is a quick and dirty port of test cases to shunit2 - a different
> testing framework for shell scripts. It sped up test execution for me
> by ~40%.
>
That is a lot faster for me too:
Ran 165 tests.
OK
real 0m41.300s
user 0m10.122s
sys 0m22.926s
while it is > 2m30 with bats, so ~75% speedup.
Though I get these errors on some tests:
test_gpiodetect_all_chips
./gpio-tools-test.bash: line 40: assertContains: command not found
./gpio-tools-test.bash: line 40: assertContains: command not found
./gpio-tools-test.bash: line 40: assertContains: command not found
test_gpiodetect_a_chip
and the overall test suite still passed, which is a bit of a worry.
Hmmm, seems assertContains was added in 2.1.8 and I'm still on 2.1.6.
I'll have to update.
Overall looks promising.
Cheers,
Kent.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-15 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15 14:38 [libgpiod][RFC/RFT PATCH] tools: tests: port tests to shunit2 Bartosz Golaszewski
2023-06-15 15:10 ` Kent Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.