* [PATCH net-next v1] net: phy-c45: Fix genphy_c45_ethtool_set_eee description
@ 2023-06-19 22:03 Andrew Lunn
2023-06-21 3:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2023-06-19 22:03 UTC (permalink / raw)
To: netdev; +Cc: Heiner Kallweit, Russell King, Andrew Lunn
The text has been cut/paste from genphy_c45_ethtool_get_eee but not
changed to reflect it performs set.
Additionally, extend the comment. This function implements the logic
that eee_enabled has global control over EEE. When eee_enabled is
false, no link modes will be advertised, and as a result, the MAC
should not transmit LPI.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
Since v0:
Rework documentation as suggested by Russell King
drivers/net/phy/phy-c45.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index fee514b96ab1..93ed07223377 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -1425,12 +1425,15 @@ int genphy_c45_ethtool_get_eee(struct phy_device *phydev,
EXPORT_SYMBOL(genphy_c45_ethtool_get_eee);
/**
- * genphy_c45_ethtool_set_eee - get EEE supported and status
+ * genphy_c45_ethtool_set_eee - set EEE supported and status
* @phydev: target phy_device struct
* @data: ethtool_eee data
*
- * Description: it reportes the Supported/Advertisement/LP Advertisement
- * capabilities.
+ * Description: sets the Supported/Advertisement/LP Advertisement
+ * capabilities. If eee_enabled is false, no links modes are
+ * advertised, but the previously advertised link modes are
+ * retained. This allows EEE to be enabled/disabled in a
+ * non-destructive way.
*/
int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
struct ethtool_eee *data)
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v1] net: phy-c45: Fix genphy_c45_ethtool_set_eee description
2023-06-19 22:03 [PATCH net-next v1] net: phy-c45: Fix genphy_c45_ethtool_set_eee description Andrew Lunn
@ 2023-06-21 3:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-21 3:40 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, hkallweit1, rmk+kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 20 Jun 2023 00:03:32 +0200 you wrote:
> The text has been cut/paste from genphy_c45_ethtool_get_eee but not
> changed to reflect it performs set.
>
> Additionally, extend the comment. This function implements the logic
> that eee_enabled has global control over EEE. When eee_enabled is
> false, no link modes will be advertised, and as a result, the MAC
> should not transmit LPI.
>
> [...]
Here is the summary with links:
- [net-next,v1] net: phy-c45: Fix genphy_c45_ethtool_set_eee description
https://git.kernel.org/netdev/net-next/c/b7c31ccd60d1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-21 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-19 22:03 [PATCH net-next v1] net: phy-c45: Fix genphy_c45_ethtool_set_eee description Andrew Lunn
2023-06-21 3:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.