All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Rong <yangrong@vivo.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org (open list:MEMORY TECHNOLOGY
	DEVICES (MTD)), linux-kernel@vger.kernel.org (open list)
Cc: opensource.kernel@vivo.com, luhongfei@vivo.com,
	Yang Rong <yangrong@vivo.com>
Subject: [PATCH] drivers: mtd: Fix potential memory leak in mtd_check_of_node
Date: Wed, 21 Jun 2023 10:43:22 +0800	[thread overview]
Message-ID: <20230621024517.1155-1-yangrong@vivo.com> (raw)

The for_each_child_of_node API internally increases the reference count
for each child node traversed. If a break statement is encountered inside
the loop, it leaves one reference unbalanced leading to a memory leak.

The function mtd_check_of_node in drivers/mtd/mtdcore.c uses such a loop
and a break statement without a corresponding of_node_put.

This patch fixes the potential memory leak by adding a call to
of_node_put before the break statement inside the for_each_child_of_node
loop in the function mtd_check_of_node.

Signed-off-by: Yang Rong <yangrong@vivo.com>
---
 drivers/mtd/mtdcore.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index e00b12aa5ec9..b02cb8b1a38d 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -591,6 +591,7 @@ static void mtd_check_of_node(struct mtd_info *mtd)
                if (plen == mtd_name_len &&
                    !strncmp(mtd->name, pname + offset, plen)) {
                        mtd_set_of_node(mtd, mtd_dn);
+                       of_node_put(mtd_dn);
                        break;
                }
        }
--
2.35.3


________________________________
本邮件及其附件内容可能含有机密和/或隐私信息，仅供指定个人或机构使用。若您非发件人指定收件人或其代理人，请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件，请即以回复或电话方式通知发件人，并将原始邮件、附件及其所有复本删除。谢谢。
The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately.
Thank you

WARNING: multiple messages have this Message-ID (diff)
From: Yang Rong <yangrong@vivo.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org (open list:MEMORY TECHNOLOGY
	DEVICES (MTD)), linux-kernel@vger.kernel.org (open list)
Cc: opensource.kernel@vivo.com, luhongfei@vivo.com,
	Yang Rong <yangrong@vivo.com>
Subject: [PATCH] drivers: mtd: Fix potential memory leak in mtd_check_of_node
Date: Wed, 21 Jun 2023 10:43:22 +0800	[thread overview]
Message-ID: <20230621024517.1155-1-yangrong@vivo.com> (raw)

The for_each_child_of_node API internally increases the reference count
for each child node traversed. If a break statement is encountered inside
the loop, it leaves one reference unbalanced leading to a memory leak.

The function mtd_check_of_node in drivers/mtd/mtdcore.c uses such a loop
and a break statement without a corresponding of_node_put.

This patch fixes the potential memory leak by adding a call to
of_node_put before the break statement inside the for_each_child_of_node
loop in the function mtd_check_of_node.

Signed-off-by: Yang Rong <yangrong@vivo.com>
---
 drivers/mtd/mtdcore.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index e00b12aa5ec9..b02cb8b1a38d 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -591,6 +591,7 @@ static void mtd_check_of_node(struct mtd_info *mtd)
                if (plen == mtd_name_len &&
                    !strncmp(mtd->name, pname + offset, plen)) {
                        mtd_set_of_node(mtd, mtd_dn);
+                       of_node_put(mtd_dn);
                        break;
                }
        }
--
2.35.3


________________________________
本邮件及其附件内容可能含有机密和/或隐私信息，仅供指定个人或机构使用。若您非发件人指定收件人或其代理人，请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件，请即以回复或电话方式通知发件人，并将原始邮件、附件及其所有复本删除。谢谢。
The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately.
Thank you

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

             reply	other threads:[~2023-06-21  2:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  2:43 Yang Rong [this message]
2023-06-21  2:43 ` [PATCH] drivers: mtd: Fix potential memory leak in mtd_check_of_node Yang Rong
2023-06-22 21:02 ` Miquel Raynal
2023-06-22 21:02   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230621024517.1155-1-yangrong@vivo.com \
    --to=yangrong@vivo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=luhongfei@vivo.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=opensource.kernel@vivo.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.