[LTP] [PATCH] syscalls/prctl04: Allow __NR_waitid in the syscall filter

[LTP] [PATCH] syscalls/prctl04: Allow __NR_waitid in the syscall filter

[Randolph Lin]

From: Randolph <randolph@andestech.com>

The __NR_wait4 syscall is not available in y2038 safe 32-bit systems,
waitid should be used instead. In the 32ABI system, the __NR_waitid
must be allowed as well in the filter.

refer:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9b2cf9482a9397c4711c9e7f42f8d718b6306bdc
linux: Use waitid on wait4 if __NR_wait4 is not defined

Signed-off-by: Randolph <randolph@andestech.com>
Signed-off-by: Dylan Jhong <dylan@andestech.com>
---
 testcases/kernel/syscalls/prctl/prctl04.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/syscalls/prctl/prctl04.c b/testcases/kernel/syscalls/prctl/prctl04.c
index f6e1f0fea..8b135d611 100644
--- a/testcases/kernel/syscalls/prctl/prctl04.c
+++ b/testcases/kernel/syscalls/prctl/prctl04.c
@@ -45,6 +45,7 @@
 static const struct sock_filter  strict_filter[] = {
 	BPF_STMT(BPF_LD | BPF_W | BPF_ABS, (offsetof(struct seccomp_data, nr))),
 
+	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_waitid, 7, 0),
 	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_rt_sigprocmask, 6, 0),
 	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_close, 5, 0),
 	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_exit,  4, 0),
-- 
2.34.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/prctl04: Allow __NR_waitid in the syscall filter

[Petr Vorel]

Hi Randolph,

> From: Randolph <randolph@andestech.com>

> The __NR_wait4 syscall is not available in y2038 safe 32-bit systems,
> waitid should be used instead. In the 32ABI system, the __NR_waitid
> must be allowed as well in the filter.

Acked-by: Petr Vorel <pvorel@suse.cz>
LGTM, thanks!

Kind regards,
Petr

> refer:
> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9b2cf9482a9397c4711c9e7f42f8d718b6306bdc
> linux: Use waitid on wait4 if __NR_wait4 is not defined

> Signed-off-by: Randolph <randolph@andestech.com>
> Signed-off-by: Dylan Jhong <dylan@andestech.com>
> ---
>  testcases/kernel/syscalls/prctl/prctl04.c | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/testcases/kernel/syscalls/prctl/prctl04.c b/testcases/kernel/syscalls/prctl/prctl04.c
> index f6e1f0fea..8b135d611 100644
> --- a/testcases/kernel/syscalls/prctl/prctl04.c
> +++ b/testcases/kernel/syscalls/prctl/prctl04.c
> @@ -45,6 +45,7 @@
>  static const struct sock_filter  strict_filter[] = {
>  	BPF_STMT(BPF_LD | BPF_W | BPF_ABS, (offsetof(struct seccomp_data, nr))),

> +	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_waitid, 7, 0),
>  	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_rt_sigprocmask, 6, 0),
>  	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_close, 5, 0),
>  	BPF_JUMP(BPF_JMP | BPF_JEQ, __NR_exit,  4, 0),

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/prctl04: Allow __NR_waitid in the syscall filter

[Petr Vorel]

Hi Randolph, all,

thanks, merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp