Re: [PATCH v9 05/10] usb: dwc3: core: Refactor PHY logic to support Multiport Controller

[kernel test robot <lkp@intel.com>]

Hi Krishna,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus robh/for-next linus/master v6.4]
[cannot apply to next-20230627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Krishna-Kurapati/dt-bindings-usb-qcom-dwc3-Add-bindings-for-SC8280-Multiport/20230621-124117
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20230621043628.21485-6-quic_kriskura%40quicinc.com
patch subject: [PATCH v9 05/10] usb: dwc3: core: Refactor PHY logic to support Multiport Controller
config: arm-randconfig-m041-20230627 (https://download.01.org/0day-ci/archive/20230628/202306280340.7mq13HUk-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230628/202306280340.7mq13HUk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306280340.7mq13HUk-lkp@intel.com/

New smatch warnings:
drivers/usb/dwc3/core.c:2239 dwc3_resume_common() warn: inconsistent indenting

Old smatch warnings:
drivers/usb/dwc3/core.c:501 dwc3_alloc_event_buffers() warn: passing a valid pointer to 'PTR_ERR'

vim +2239 drivers/usb/dwc3/core.c

  2202	
  2203	static int dwc3_resume_common(struct dwc3 *dwc, pm_message_t msg)
  2204	{
  2205		unsigned long	flags;
  2206		int		ret;
  2207		u32		reg;
  2208		int		i;
  2209	
  2210		switch (dwc->current_dr_role) {
  2211		case DWC3_GCTL_PRTCAP_DEVICE:
  2212			ret = dwc3_core_init_for_resume(dwc);
  2213			if (ret)
  2214				return ret;
  2215	
  2216			dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_DEVICE);
  2217			dwc3_gadget_resume(dwc);
  2218			break;
  2219		case DWC3_GCTL_PRTCAP_HOST:
  2220			if (!PMSG_IS_AUTO(msg) && !device_may_wakeup(dwc->dev)) {
  2221				ret = dwc3_core_init_for_resume(dwc);
  2222				if (ret)
  2223					return ret;
  2224				dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_HOST);
  2225				break;
  2226			}
  2227			/* Restore GUSB2PHYCFG bits that were modified in suspend */
  2228			 for (i = 0; i < dwc->num_usb2_ports; i++) {
  2229				reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(i));
  2230				if (dwc->dis_u2_susphy_quirk)
  2231					reg &= ~DWC3_GUSB2PHYCFG_SUSPHY;
  2232	
  2233				if (dwc->dis_enblslpm_quirk)
  2234					reg &= ~DWC3_GUSB2PHYCFG_ENBLSLPM;
  2235	
  2236				dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(i), reg);
  2237			}
  2238	
> 2239			for (i = 0; i < dwc->num_usb2_ports; i++) {
  2240				phy_pm_runtime_get_sync(dwc->usb2_generic_phy[i]);
  2241				phy_pm_runtime_get_sync(dwc->usb3_generic_phy[i]);
  2242			}
  2243			break;
  2244		case DWC3_GCTL_PRTCAP_OTG:
  2245			/* nothing to do on runtime_resume */
  2246			if (PMSG_IS_AUTO(msg))
  2247				break;
  2248	
  2249			ret = dwc3_core_init_for_resume(dwc);
  2250			if (ret)
  2251				return ret;
  2252	
  2253			dwc3_set_prtcap(dwc, dwc->current_dr_role);
  2254	
  2255			dwc3_otg_init(dwc);
  2256			if (dwc->current_otg_role == DWC3_OTG_ROLE_HOST) {
  2257				dwc3_otg_host_init(dwc);
  2258			} else if (dwc->current_otg_role == DWC3_OTG_ROLE_DEVICE) {
  2259				spin_lock_irqsave(&dwc->lock, flags);
  2260				dwc3_gadget_resume(dwc);
  2261				spin_unlock_irqrestore(&dwc->lock, flags);
  2262			}
  2263	
  2264			break;
  2265		default:
  2266			/* do nothing */
  2267			break;
  2268		}
  2269	
  2270		return 0;
  2271	}
  2272	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki