[igt-dev] [V5 i-g-t 00/81] Document KMS tests

[igt-dev] [V5 i-g-t 00/81] Document KMS tests

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

This series also includes:
- Move all kms helpers to lib
- New config field to differentiate b/w the drivers
- Add documentation for all kms tests

V2: - Include testdisplay.c
V3: - Improve documentation for kms_fb_coherency.c
    - Other minor cleanups
V4: - Rebase
V5: - Rebase
    - Fixes in testplan

Bhanuprakash Modem (81):
  testplan/kms: Keep category as high level entity
  testplan/kms: Add support to differentiate b/w drivers
  testplan/kms: Include testdisplay to kms testplan config
  testplan/kms: Exclude kms helpers form testplan
  tests/chamelium/kms_chamelium_audio: Document each subtest for
    testplan
  tests/chamelium/kms_chamelium_color: Document each subtest for
    testplan
  tests/chamelium/kms_chamelium_edid: Document each subtest for testplan
  tests/chamelium/kms_chamelium_frames: Document each subtest for
    testplan
  tests/chamelium/kms_chamelium_hpd: Document each subtest for testplan
  tests/i915/kms_big_fb: Document each subtest for testplan
  tests/i915/kms_big_joiner: Document each subtest for testplan
  tests/i915/kms_busy: Document each subtest for testplan
  tests/i915/kms_ccs: Document each subtest for testplan
  tests/i915/kms_cdclk: Document each subtest for testplan
  tests/i915/kms_draw_crc: Document each subtest for testplan
  tests/i915/kms_dsc: Document each subtest for testplan
  tests/i915/kms_fb_coherency: Document each subtest for testplan
  tests/i915/kms_fbcon_fbt: Document each subtest for testplan
  tests/i915/kms_fence_pin_leak: Document each subtest for testplan
  tests/i915/kms_flip_scaled_crc: Document each subtest for testplan
  tests/i915/kms_flip_tiling: Document each subtest for testplan
  tests/i915/kms_frontbuffer_tracking: Document each subtest for
    testplan
  tests/i915/kms_legacy_colorkey: Document each subtest for testplan
  tests/i915/kms_mmap_write_crc: Document each subtest for testplan
  tests/i915/kms_pipe_b_c_ivb: Document each subtest for testplan
  tests/i915/kms_psr: Document each subtest for testplan
  tests/i915/kms_psr2_sf: Document each subtest for testplan
  tests/i915/kms_psr2_su: Document each subtest for testplan
  tests/i915/kms_psr_stress_test: Document each subtest for testplan
  tests/i915/kms_pwrite_crc: Document each subtest for testplan
  tests/kms_3d: Document each subtest for testplan
  tests/kms_addfb_basic: Document each subtest for testplan
  tests/kms_async_flips: Document each subtest for testplan
  tests/kms_atomic: Document each subtest for testplan
  tests/kms_atomic_interruptible: Document each subtest for testplan
  tests/kms_atomic_transition: Document each subtest for testplan
  tests/kms_bw: Document each subtest for testplan
  tests/kms_color: Document each subtest for testplan
  tests/kms_concurrent: Document each subtest for testplan
  tests/kms_content_protection: Document each subtest for testplan
  tests/kms_cursor_crc: Document each subtest for testplan
  tests/kms_cursor_edge_walk: Document each subtest for testplan
  tests/kms_cursor_legacy: Document each subtest for testplan
  tests/kms_display_modes: Document each subtest for testplan
  tests/kms_dither: Document each subtest for testplan
  tests/kms_dp_aux_dev: Document each subtest for testplan
  tests/kms_dp_tiled_display: Document each subtest for testplan
  tests/kms_flip: Document each subtest for testplan
  tests/kms_flip_event_leak: Document each subtest for testplan
  tests/kms_force_connector_basic: Document each subtest for testplan
  tests/kms_getfb: Document each subtest for testplan
  tests/kms_hdmi_inject: Document each subtest for testplan
  tests/kms_hdr: Document each subtest for testplan
  tests/kms_invalid_mode: Document each subtest for testplan
  tests/kms_lease: Document each subtest for testplan
  tests/kms_multipipe_modeset: Document each subtest for testplan
  tests/kms_panel_fitting: Document each subtest for testplan
  tests/kms_pipe_crc_basic: Document each subtest for testplan
  tests/kms_plane: Document each subtest for testplan
  tests/kms_plane_alpha_blend: Document each subtest for testplan
  tests/kms_plane_cursor: Document each subtest for testplan
  tests/kms_plane_lowres: Document each subtest for testplan
  tests/kms_plane_multiple: Document each subtest for testplan
  tests/kms_plane_scaling: Document each subtest for testplan
  tests/kms_prime: Document each subtest for testplan
  tests/kms_prop_blob: Document each subtest for testplan
  tests/kms_properties: Document each subtest for testplan
  tests/kms_rmfb: Document each subtest for testplan
  tests/kms_rotation_crc: Document each subtest for testplan
  tests/kms_scaling_modes: Document each subtest for testplan
  tests/kms_selftest: Document each subtest for testplan
  tests/kms_sequence: Document each subtest for testplan
  tests/kms_setmode: Document each subtest for testplan
  tests/kms_sysfs_edid_timing: Document each subtest for testplan
  tests/kms_tv_load_detect: Document each subtest for testplan
  tests/kms_universal_plane: Document each subtest for testplan
  tests/kms_vblank: Document each subtest for testplan
  tests/kms_vrr: Document each subtest for testplan
  tests/kms_writeback: Document each subtest for testplan
  tests/testdisplay: Document each subtest for testplan
  testplan/kms: Make documentation is mandatory for all kms subtests

 docs/testplan/meson.build              |   4 +-
 tests/chamelium/kms_chamelium_audio.c  |  44 ++
 tests/chamelium/kms_chamelium_color.c  |  45 ++
 tests/chamelium/kms_chamelium_edid.c   |  90 ++-
 tests/chamelium/kms_chamelium_frames.c | 101 +++-
 tests/chamelium/kms_chamelium_hpd.c    | 186 +++++-
 tests/i915/kms_big_fb.c                | 132 ++++
 tests/i915/kms_big_joiner.c            |  33 +
 tests/i915/kms_busy.c                  |  62 ++
 tests/i915/kms_ccs.c                   |  89 +++
 tests/i915/kms_cdclk.c                 |  32 +
 tests/i915/kms_draw_crc.c              |  49 +-
 tests/i915/kms_dsc.c                   |  27 +
 tests/i915/kms_fb_coherency.c          |   4 +
 tests/i915/kms_fbcon_fbt.c             |  42 ++
 tests/i915/kms_fence_pin_leak.c        |  13 +
 tests/i915/kms_flip_scaled_crc.c       | 191 ++++++
 tests/i915/kms_flip_tiling.c           |  13 +
 tests/i915/kms_frontbuffer_tracking.c  | 808 +++++++++++++++++++++++++
 tests/i915/kms_legacy_colorkey.c       |  21 +
 tests/i915/kms_mmap_write_crc.c        |  14 +
 tests/i915/kms_pipe_b_c_ivb.c          |  52 ++
 tests/i915/kms_psr.c                   | 213 ++++++-
 tests/i915/kms_psr2_sf.c               |  85 +++
 tests/i915/kms_psr2_su.c               |  27 +
 tests/i915/kms_psr_stress_test.c       |  22 +
 tests/i915/kms_pwrite_crc.c            |  15 +
 tests/kms_3d.c                         |  13 +
 tests/kms_addfb_basic.c                | 188 ++++--
 tests/kms_async_flips.c                |  62 ++
 tests/kms_atomic.c                     | 102 +++-
 tests/kms_atomic_interruptible.c       |  50 ++
 tests/kms_atomic_transition.c          | 100 +++
 tests/kms_bw.c                         |  20 +
 tests/kms_color.c                      |  91 +++
 tests/kms_concurrent.c                 |  26 +
 tests/kms_content_protection.c         |  81 +++
 tests/kms_cursor_crc.c                 |  65 ++
 tests/kms_cursor_edge_walk.c           |  26 +
 tests/kms_cursor_legacy.c              | 217 ++++++-
 tests/kms_display_modes.c              |  25 +
 tests/kms_dither.c                     |  22 +
 tests/kms_dp_aux_dev.c                 |  13 +
 tests/kms_flip.c                       | 178 +++++-
 tests/kms_flip_event_leak.c            |  19 +
 tests/kms_force_connector_basic.c      |  15 +-
 tests/kms_getfb.c                      |  90 +++
 tests/kms_hdmi_inject.c                |  25 +
 tests/kms_hdr.c                        |  52 ++
 tests/kms_invalid_mode.c               |  32 +
 tests/kms_lease.c                      | 180 ++++++
 tests/kms_multipipe_modeset.c          |  14 +
 tests/kms_panel_fitting.c              |  21 +
 tests/kms_pipe_crc_basic.c             |  30 +-
 tests/kms_plane.c                      |  58 ++
 tests/kms_plane_alpha_blend.c          |  55 ++
 tests/kms_plane_cursor.c               |  30 +
 tests/kms_plane_lowres.c               |  24 +
 tests/kms_plane_multiple.c             |  24 +
 tests/kms_plane_scaling.c              | 261 ++++++++
 tests/kms_prime.c                      |  35 ++
 tests/kms_prop_blob.c                  |  46 +-
 tests/kms_properties.c                 |  40 ++
 tests/kms_rmfb.c                       |  24 +
 tests/kms_rotation_crc.c               | 130 ++++
 tests/kms_scaling_modes.c              |  20 +
 tests/kms_selftest.c                   |  23 +
 tests/kms_sequence.c                   |  36 ++
 tests/kms_setmode.c                    |  58 ++
 tests/kms_sysfs_edid_timing.c          |  21 +
 tests/kms_test_config.json             |  27 +-
 tests/kms_tiled_display.c              |  21 +
 tests/kms_tv_load_detect.c             |  13 +
 tests/kms_universal_plane.c            |  67 ++
 tests/kms_vblank.c                     |  69 +++
 tests/kms_vrr.c                        |  47 ++
 tests/kms_writeback.c                  |  42 ++
 tests/testdisplay.c                    |  13 +
 78 files changed, 5291 insertions(+), 64 deletions(-)

--
2.40.0

[igt-dev] [V5 i-g-t 01/81] testplan/kms: Keep category as high level entity

[Bhanuprakash Modem]

Update kms testplan to keep the category as high level entity.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_test_config.json | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tests/kms_test_config.json b/tests/kms_test_config.json
index 5fbe40bdc..447a13337 100644
--- a/tests/kms_test_config.json
+++ b/tests/kms_test_config.json
@@ -6,21 +6,21 @@
         "Category": {
             "_properties_": {
                 "description": "Contains the major group for the tested functionality 'Display'"
-            }
-        },
-        "Mega feature": {
-            "_properties_": {
-                "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
             },
-            "Functionality": {
+            "Mega feature": {
                 "_properties_": {
-                    "description": "Groups tests on buckets containg more detailed functionality"
+                    "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
+                },
+                "Functionality": {
+                    "_properties_": {
+                        "description": "Groups tests on buckets containg more detailed functionality"
+                    }
+                }
+            },
+            "Run type": {
+                "_properties_": {
+                    "description": "Defines what category of testlist it belongs"
                 }
-            }
-        },
-        "Run type": {
-            "_properties_": {
-                "description": "Defines what category of testlist it belongs"
             }
         },
         "Test category": {
-- 
2.40.0

[igt-dev] [V5 i-g-t 02/81] testplan/kms: Add support to differentiate b/w drivers

[Bhanuprakash Modem]

Add support to differentiate the subtests based on the driver
support, since many kms tests supports both i915 & xe drivers.

Add a new field "Driver requirement" to test_config.json

Example:
- Driver requirement: i915 (i915 specific test)
- Driver requirement: xe   (xe specific test)
- Driver requirement: any  (tests supports both i915 & xe)

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/kms_test_config.json | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/kms_test_config.json b/tests/kms_test_config.json
index 447a13337..7a43da74e 100644
--- a/tests/kms_test_config.json
+++ b/tests/kms_test_config.json
@@ -23,6 +23,11 @@
                 }
             }
         },
+        "Driver requirement": {
+            "_properties_": {
+                "description": "Describes any Driver specific requrirement, like i915/xe."
+            }
+        },
         "Test category": {
             "_properties_": {
                 "description": "Defines the test category. Usually used at subtest level."
-- 
2.40.0

[igt-dev] [V5 i-g-t 03/81] testplan/kms: Include testdisplay to kms testplan config

[Bhanuprakash Modem]

As testdisplay.c is belongs to display, add it to the kms
testplan config.

V2: - Rebase

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/kms_test_config.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_test_config.json b/tests/kms_test_config.json
index 7a43da74e..499f418ab 100644
--- a/tests/kms_test_config.json
+++ b/tests/kms_test_config.json
@@ -1,7 +1,7 @@
 {
     "description": "JSON file to be used to parse KMS documentation",
     "name": "Display and KMS Tests for Intel i915 and Xe Drivers",
-    "files": [ "chamelium/kms_*.c", "i915/kms_*.c", "kms_*.c" ],
+    "files": [ "chamelium/kms_*.c", "i915/kms_*.c", "kms_*.c", "testdisplay.c" ],
     "fields": {
         "Category": {
             "_properties_": {
-- 
2.40.0

[igt-dev] [V5 i-g-t 04/81] testplan/kms: Exclude kms helpers form testplan

[Bhanuprakash Modem]

As we are using wild cards in testplan, it'll expect a binary
for each source (.c) file. Exclude kms helpers from testplan
to avoid the build failures.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_test_config.json | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_test_config.json b/tests/kms_test_config.json
index 499f418ab..9219ae4eb 100644
--- a/tests/kms_test_config.json
+++ b/tests/kms_test_config.json
@@ -2,6 +2,8 @@
     "description": "JSON file to be used to parse KMS documentation",
     "name": "Display and KMS Tests for Intel i915 and Xe Drivers",
     "files": [ "chamelium/kms_*.c", "i915/kms_*.c", "kms_*.c", "testdisplay.c" ],
+    "exclude_files": [ "chamelium/kms_chamelium_helper.c", "i915/kms_dsc_helper.c",
+                       "kms_color_helper.c"],
     "fields": {
         "Category": {
             "_properties_": {
-- 
2.40.0

[igt-dev] [V5 i-g-t 05/81] tests/chamelium/kms_chamelium_audio: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/chamelium/kms_chamelium_audio.c | 44 +++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/tests/chamelium/kms_chamelium_audio.c b/tests/chamelium/kms_chamelium_audio.c
index 8fbc1f80e..453f3518a 100644
--- a/tests/chamelium/kms_chamelium_audio.c
+++ b/tests/chamelium/kms_chamelium_audio.c
@@ -28,6 +28,12 @@
 #include "igt_infoframe.h"
 #include "kms_chamelium_helper.h"
 
+/**
+ * TEST: kms chamelium audio
+ * Category: Display
+ * Description: Testing Audio with a Chamelium board
+ */
+
 /* Playback parameters control the audio signal we synthesize and send */
 #define PLAYBACK_CHANNELS 2
 #define PLAYBACK_SAMPLES 1024
@@ -669,6 +675,25 @@ static bool check_audio_configuration(struct alsa *alsa,
 	return true;
 }
 
+/**
+ * SUBTEST: dp-audio
+ * Description: Playback various audio signals with various audio formats/rates,
+ *              capture them and check they are correct
+ * Functionality: dp_audio
+ * Mega feature: DP
+ * Run type: FULL
+ * Test category: functionality test
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-audio
+ * Description: Playback various audio signals with various audio formats/rates,
+ *              capture them and check they are correct
+ * Functionality: hdmi_audio
+ * Mega feature: HDMI
+ * Run type: FULL
+ * Test category: functionality test
+ * Driver requirement: any
+ */
 static const char test_display_audio_desc[] =
 	"Playback various audio signals with various audio formats/rates, "
 	"capture them and check they are correct";
@@ -763,6 +788,25 @@ static void test_display_audio(chamelium_data_t *data,
 	free(alsa);
 }
 
+/**
+ * SUBTEST: dp-audio-edid
+ * Description: Plug a connector with an EDID suitable for audio, check ALSA's
+ *              EDID-Like Data reports the correct audio parameters
+ * Functionality: dp_audio
+ * Mega feature: DP
+ * Run type: FULL
+ * Test category: functionality test
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-audio-edid
+ * Description: Plug a connector with an EDID suitable for audio, check ALSA's
+ *              EDID-Like Data reports the correct audio parameters
+ * Functionality: hdmi_audio
+ * Mega feature: HDMI
+ * Run type: FULL
+ * Test category: functionality test
+ * Driver requirement: any
+ */
 static const char test_display_audio_edid_desc[] =
 	"Plug a connector with an EDID suitable for audio, check ALSA's "
 	"EDID-Like Data reports the correct audio parameters";
-- 
2.40.0

[igt-dev] [V5 i-g-t 06/81] tests/chamelium/kms_chamelium_color: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/chamelium/kms_chamelium_color.c | 45 +++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/tests/chamelium/kms_chamelium_color.c b/tests/chamelium/kms_chamelium_color.c
index 26239a6b8..aca57095f 100644
--- a/tests/chamelium/kms_chamelium_color.c
+++ b/tests/chamelium/kms_chamelium_color.c
@@ -22,10 +22,25 @@
  *
  */
 
+/**
+ * TEST: kms chamelium color
+ * Category: Display
+ * Description: Test Color Features at Pipe level using Chamelium to verify instead of CRC
+ */
+
 #include "kms_color_helper.h"
 
 IGT_TEST_DESCRIPTION("Test Color Features at Pipe level using Chamelium to verify instead of CRC");
 
+/**
+ * SUBTEST: degamma
+ * Description: Verify that degamma LUT transformation works correctly
+ * Functionality: colorspace
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ * Driver requirement: any
+ */
 /*
  * Draw 3 gradient rectangles in red, green and blue, with a maxed out
  * degamma LUT and verify we have the same frame dump as drawing solid color
@@ -115,6 +130,15 @@ static bool test_pipe_degamma(data_t *data,
 	return ret;
 }
 
+/**
+ * SUBTEST: gamma
+ * Description: Verify that gamma LUT transformation works correctly
+ * Functionality: colorspace_gamma
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ * Driver requirement: any
+ */
 /*
  * Draw 3 gradient rectangles in red, green and blue, with a maxed out
  * gamma LUT and verify we have the same frame dump as drawing solid
@@ -465,6 +489,27 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p,
 		igt_assert(test_t(data, data->primary, data->ports[port_idx]));
 }
 
+/**
+ * SUBTEST: ctm-%s
+ * Description: Check the color transformation %arg[1]
+ * Functionality: colorspace
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @0-25:            for 0.25 transparancy
+ * @0-50:            for 0.50 transparancy
+ * @0-75:            for 0.75 transparancy
+ * @blue-to-red:     from blue to red
+ * @green-to-red:    from green to red
+ * @limited-range:   with identity matrix
+ * @max:             for max transparancy
+ * @negative:        for negative transparancy
+ * @red-to-blue:     from red to blue
+ */
 static void
 run_ctm_tests_for_pipe(data_t *data, enum pipe p,
 		       color_t *expected_colors,
-- 
2.40.0

[igt-dev] [V5 i-g-t 07/81] tests/chamelium/kms_chamelium_edid: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/chamelium/kms_chamelium_edid.c | 90 +++++++++++++++++++++++++++-
 1 file changed, 89 insertions(+), 1 deletion(-)

diff --git a/tests/chamelium/kms_chamelium_edid.c b/tests/chamelium/kms_chamelium_edid.c
index 446bbd204..579d61d15 100644
--- a/tests/chamelium/kms_chamelium_edid.c
+++ b/tests/chamelium/kms_chamelium_edid.c
@@ -25,8 +25,9 @@
  */
 
 /**
- * TEST: Tests behaviour of edid & timings using chamelium
+ * TEST: kms chamelium edid
  * Category: Display
+ * Description: Testing EDID with a Chamelium board
  */
 
 #include <fcntl.h>
@@ -151,6 +152,7 @@ static void check_mode(struct chamelium *chamelium, struct chamelium_port *port,
  * Run type: BAT
  * Functionality: dp
  * Mega feature: DP
+ * Driver requirement: any
  *
  * SUBTEST: hdmi-edid-read
  * Description: Make sure the EDID exposed by KMS is the same as the screen's
@@ -158,6 +160,7 @@ static void check_mode(struct chamelium *chamelium, struct chamelium_port *port,
  * Run type: BAT
  * Functionality: hdmi
  * Mega feature: HDMI
+ * Driver requirement: any
  *
  * SUBTEST: vga-edid-read
  * Description: Make sure the EDID exposed by KMS is the same as the screen's
@@ -165,6 +168,7 @@ static void check_mode(struct chamelium *chamelium, struct chamelium_port *port,
  * Run type: BAT
  * Functionality: vga
  * Mega feature: VGA
+ * Driver requirement: any
  */
 static const char igt_custom_edid_type_read_desc[] =
 	"Make sure the EDID exposed by KMS is the same as the screen's";
@@ -205,6 +209,32 @@ static void igt_custom_edid_type_read(chamelium_data_t *data,
 	drmModeFreeConnector(connector);
 }
 
+/**
+ * SUBTEST: dp-edid-stress-resolution-%s
+ * Description: Stress test the DUT by testing multiple EDIDs, one right after
+ *              the other, and ensure their validity by check the real screen
+ *              resolution vs the advertised mode (%arg[1]) resolution.
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-edid-stress-resolution-%s
+ * Description: Stress test the DUT by testing multiple EDIDs, one right after
+ *              the other, and ensure their validity by check the real screen
+ *              resolution vs the advertised mode (%arg[1]) resolution.
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @4k:      4K
+ * @non-4k:  Non 4K
+ */
 static const char igt_edid_stress_resolution_desc[] =
 	"Stress test the DUT by testing multiple EDIDs, one right after the other, "
 	"and ensure their validity by check the real screen resolution vs the "
@@ -274,6 +304,17 @@ static void edid_stress_resolution(chamelium_data_t *data,
 			      data->ports, data->port_count);
 }
 
+/**
+ * SUBTEST: dp-edid-resolution-list
+ * Description: Get an EDID with many modes of different configurations, set
+ *              them on the screen and check the screen resolution matches the
+ *              mode resolution.
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ */
 static const char igt_edid_resolution_list_desc[] =
 	"Get an EDID with many modes of different configurations, set them on the screen and check the"
 	" screen resolution matches the mode resolution.";
@@ -337,6 +378,32 @@ static void edid_resolution_list(chamelium_data_t *data,
 	drmModeFreeConnector(connector);
 }
 
+/**
+ * SUBTEST: dp-edid-change-during-%s
+ * Description: Simulate a screen being unplugged and another screen being
+ *              plugged during suspend, check that a uevent is sent and
+ *              connector status is updated during %arg[1]
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-edid-change-during-%s
+ * Description: Simulate a screen being unplugged and another screen being
+ *              plugged during suspend, check that a uevent is sent and
+ *              connector status is updated during %arg[1]
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @hibernate:    hibernation
+ * @suspend:      suspend
+ */
 static const char test_suspend_resume_edid_change_desc[] =
 	"Simulate a screen being unplugged and another screen being plugged "
 	"during suspend, check that a uevent is sent and connector status is "
@@ -389,6 +456,27 @@ static void test_suspend_resume_edid_change(chamelium_data_t *data,
 			    link_status_failed[1][p]);
 }
 
+/**
+ * SUBTEST: dp-mode-timings
+ * Description: For each mode of the IGT base EDID, perform a modeset and check
+ *              the mode detected by the Chamelium receiver matches the mode we
+ *              set
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-mode-timings
+ * Description: For each mode of the IGT base EDID, perform a modeset and check
+ *              the mode detected by the Chamelium receiver matches the mode we
+ *              set
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ */
 static const char test_mode_timings_desc[] =
 	"For each mode of the IGT base EDID, perform a modeset and check the "
 	"mode detected by the Chamelium receiver matches the mode we set";
-- 
2.40.0

[igt-dev] [V5 i-g-t 08/81] tests/chamelium/kms_chamelium_frames: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/chamelium/kms_chamelium_frames.c | 101 ++++++++++++++++++++++++-
 1 file changed, 99 insertions(+), 2 deletions(-)

diff --git a/tests/chamelium/kms_chamelium_frames.c b/tests/chamelium/kms_chamelium_frames.c
index a56afada4..698681c4c 100644
--- a/tests/chamelium/kms_chamelium_frames.c
+++ b/tests/chamelium/kms_chamelium_frames.c
@@ -25,10 +25,10 @@
  */
 
 /**
- * TEST: Tests to capture frames using chamelium
+ * TEST: kms chamelium frames
  * Category: Display
+ * Description: Tests requiring a Chamelium board
  */
-
 #include "igt_eld.h"
 #include "igt_infoframe.h"
 #include "kms_chamelium_helper.h"
@@ -547,6 +547,7 @@ static void prepare_randomized_plane(chamelium_data_t *data,
  * Run type: BAT
  * Functionality: dp
  * Mega feature: DP
+ * Driver requirement: any
  *
  * SUBTEST: hdmi-crc-fast
  * Description: Pick the first mode of the IGT base EDID, display and capture
@@ -555,6 +556,23 @@ static void prepare_randomized_plane(chamelium_data_t *data,
  * Run type: BAT
  * Functionality: hdmi
  * Mega feature: HDMI
+ * Driver requirement: any
+ */
+
+/**
+ * SUBTEST: hdmi-%s-formats
+ * Description: Pick the first mode of the IGT base EDID, display and capture a
+ *              few frames, then check captured frames are correct
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @crc-nonplanar:     CRC with non planar formats
+ * @cmp-planar:        Compare with planar formats
  */
 static const char test_display_one_mode_desc[] =
 	"Pick the first mode of the IGT base EDID, display and capture a few "
@@ -592,6 +610,39 @@ static void test_display_one_mode(chamelium_data_t *data,
 	drmModeFreeConnector(connector);
 }
 
+/**
+ * SUBTEST: vga-frame-dump
+ * Description: For each mode of the IGT base EDID, display and capture a few
+ *              frames, then check captured frames are correct
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: vga
+ * Mega feature: VGA
+ * Driver requirement: any
+ *
+ * SUBTEST: dp-crc-%s
+ * Description: For each mode of the IGT base EDID, display and capture a %arg[1]
+ *              frame(s), then check captured frame(s) are correct
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-crc-%s
+ * Description: For each mode of the IGT base EDID, display and capture a %arg[1]
+ *              frame(s), then check captured frame(s) are correct
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @single:    single
+ * @multiple:  multiple
+ */
 static const char test_display_all_modes_desc[] =
 	"For each mode of the IGT base EDID, display and capture a few "
 	"frames, then check captured frames are correct";
@@ -650,6 +701,27 @@ static void test_display_all_modes(chamelium_data_t *data,
 	} while (++i < count_modes);
 }
 
+/**
+ * SUBTEST: dp-frame-dump
+ * Description: For each mode of the IGT base EDID, display and capture a few
+ *              frames, then download the captured frames and compare them
+ *              bit-by-bit to the sent ones
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-frame-dump
+ * Description: For each mode of the IGT base EDID, display and capture a few
+ *              frames, then download the captured frames and compare them
+ *              bit-by-bit to the sent ones
+ * Test category: functionality test
+ * Run type: BAT
+ * Functionality: hdmi
+ * Mega feature: HDMI
+ * Driver requirement: any
+ */
 static const char test_display_frame_dump_desc[] =
 	"For each mode of the IGT base EDID, display and capture a few "
 	"frames, then download the captured frames and compare them "
@@ -718,6 +790,16 @@ static void test_display_frame_dump(chamelium_data_t *data,
 	} while (++i < count_modes);
 }
 
+/**
+ * SUBTEST: hdmi-aspect-ratio
+ * Description: Pick a mode with a picture aspect-ratio, capture AVI InfoFrames
+ *              and check they include the relevant fields
+ * Test category: functionality test
+ * Run type: BAT
+ * Functionality: hdmi
+ * Mega feature: HDMI
+ * Driver requirement: any
+ */
 static const char test_display_aspect_ratio_desc[] =
 	"Pick a mode with a picture aspect-ratio, capture AVI InfoFrames and "
 	"check they include the relevant fields";
@@ -798,6 +880,21 @@ static void test_display_aspect_ratio(chamelium_data_t *data,
 	drmModeFreeConnector(connector);
 }
 
+/**
+ * SUBTEST: hdmi-%s-planes-random
+ * Description: Setup a few overlay planes with random parameters, capture the
+ *              frame and check it matches the expected output
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @crc:     CRC check
+ * @cmp:     Compare
+ */
 static const char test_display_planes_random_desc[] =
 	"Setup a few overlay planes with random parameters, capture the frame "
 	"and check it matches the expected output";
-- 
2.40.0

[igt-dev] [V5 i-g-t 09/81] tests/chamelium/kms_chamelium_hpd: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/chamelium/kms_chamelium_hpd.c | 186 +++++++++++++++++++++++++++-
 1 file changed, 185 insertions(+), 1 deletion(-)

diff --git a/tests/chamelium/kms_chamelium_hpd.c b/tests/chamelium/kms_chamelium_hpd.c
index 8b3189ca0..d7b9f0707 100644
--- a/tests/chamelium/kms_chamelium_hpd.c
+++ b/tests/chamelium/kms_chamelium_hpd.c
@@ -25,8 +25,9 @@
  */
 
 /**
- * TEST: Tests behaviour of hpd using chamelium
+ * TEST: kms chamelium hpd
  * Category: Display
+ * Description: Testing HPD with a Chamelium board
  */
 
 #include "kms_chamelium_helper.h"
@@ -117,6 +118,7 @@ static void try_suspend_resume_hpd(chamelium_data_t *data,
  * Run type: BAT
  * Functionality: dp_hotplug
  * Mega feature: DP
+ * Driver requirement: any
  *
  * SUBTEST: hdmi-hpd-fast
  * Description: Check that we get uevents and updated connector status on
@@ -125,6 +127,7 @@ static void try_suspend_resume_hpd(chamelium_data_t *data,
  * Run type: BAT
  * Functionality: hdmi_hotplug
  * Mega feature: HDMI
+ * Driver requirement: any
  *
  * SUBTEST: vga-hpd-fast
  * Description: Check that we get uevents and updated connector status on
@@ -133,6 +136,66 @@ static void try_suspend_resume_hpd(chamelium_data_t *data,
  * Run type: BAT
  * Functionality: vga_hotplug
  * Mega feature: VGA
+ * Driver requirement: any
+ *
+ * SUBTEST: dp-hpd
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp_hotplug
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-hpd
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi_hotplug
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * SUBTEST: vga-hpd
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: vga_hotplug
+ * Mega feature: VGA
+ * Driver requirement: any
+ *
+ * SUBTEST: dp-hpd-%s
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp_hotplug
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-hpd-%s
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi_hotplug
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * SUBTEST: vga-hpd-%s
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: vga_hotplug
+ * Mega feature: VGA
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @enable-disable-mode:     Toggle the mode
+ * @with-enabled-mode:       Enabling the mode
  */
 static const char test_basic_hotplug_desc[] =
 	"Check that we get uevents and updated connector status on "
@@ -200,6 +263,34 @@ static void test_hotplug(chamelium_data_t *data, struct chamelium_port *port,
 	igt_remove_fb(data->drm_fd, &fb);
 }
 
+/**
+ * SUBTEST: dp-hpd-for-each-pipe
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug for each pipe with valid output
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp_hotplug
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-hpd-for-each-pipe
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug for each pipe with valid output
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi_hotplug
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * SUBTEST: vga-hpd-for-each-pipe
+ * Description: Check that we get uevents and updated connector status on
+ *              hotplug and unplug for each pipe with valid output
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: vga_hotplug
+ * Mega feature: VGA
+ * Driver requirement: any
+ */
 static const char test_hotplug_for_each_pipe_desc[] =
 	"Check that we get uevents and updated connector status on "
 	"hotplug and unplug for each pipe with valid output";
@@ -245,6 +336,39 @@ static void test_hotplug_for_each_pipe(chamelium_data_t *data,
 	igt_hpd_storm_reset(data->drm_fd);
 }
 
+/**
+ * SUBTEST: dp-hpd-after-%s
+ * Description: Toggle HPD during %arg[1], check that uevents are sent and
+ *              connector status is updated
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp_hotplug
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-hpd-after-%s
+ * Description: Toggle HPD during %arg[1], check that uevents are sent and
+ *              connector status is updated
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi_hotplug
+ * Mega feature: HDMI
+ * Driver requirement: any
+ *
+ * SUBTEST: vga-hpd-after-%s
+ * Description: Toggle HPD during %arg[1], check that uevents are sent and
+ *              connector status is updated
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: vga_hotplug
+ * Mega feature: VGA
+ * Driver requirement: any
+ *
+ * arg[1]:
+ *
+ * @hibernate:     Hibernation
+ * @suspend:       Suspend
+ */
 static const char test_suspend_resume_hpd_desc[] =
 	"Toggle HPD during suspend, check that uevents are sent and connector "
 	"status is updated";
@@ -276,6 +400,16 @@ static void test_suspend_resume_hpd(chamelium_data_t *data,
  * Run type: BAT
  * Functionality: hotplug
  * Mega feature: General Display Features
+ * Driver requirement: any
+ *
+ * SUBTEST: common-hpd-after-hibernate
+ * Description: Toggle HPD during suspend on all connectors, check that uevents
+ *              are sent and connector status is updated
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hotplug
+ * Mega feature: General Display Features
+ * Driver requirement: any
  */
 static const char test_suspend_resume_hpd_common_desc[] =
 	"Toggle HPD during suspend on all connectors, check that uevents are "
@@ -306,6 +440,16 @@ static void test_suspend_resume_hpd_common(chamelium_data_t *data,
 	igt_cleanup_uevents(mon);
 }
 
+/**
+ * SUBTEST: vga-hpd-without-ddc
+ * Description: Disable DDC on a VGA connector, check we still get a uevent on
+ *              hotplug
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: vga_hotplug
+ * Mega feature: VGA
+ * Driver requirement: any
+ */
 static const char test_hpd_without_ddc_desc[] =
 	"Disable DDC on a VGA connector, check we still get a uevent on hotplug";
 static void test_hpd_without_ddc(chamelium_data_t *data,
@@ -332,6 +476,27 @@ static void test_hpd_without_ddc(chamelium_data_t *data,
 	igt_cleanup_uevents(mon);
 }
 
+/**
+ * SUBTEST: dp-hpd-storm
+ * Description: Trigger a series of hotplugs in a very small timeframe to
+ *              simulate abad cable, check the kernel falls back to polling
+ *              to avoid a hotplug storm
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp_hotplug
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-hpd-storm
+ * Description: Trigger a series of hotplugs in a very small timeframe to
+ *              simulate abad cable, check the kernel falls back to polling
+ *              to avoid a hotplug storm
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi_hotplug
+ * Mega feature: HDMI
+ * Driver requirement: any
+ */
 static const char test_hpd_storm_detect_desc[] =
 	"Trigger a series of hotplugs in a very small timeframe to simulate a"
 	"bad cable, check the kernel falls back to polling to avoid a hotplug "
@@ -366,6 +531,25 @@ static void test_hpd_storm_detect(chamelium_data_t *data,
 	igt_hpd_storm_reset(data->drm_fd);
 }
 
+/**
+ * SUBTEST: dp-hpd-storm-disable
+ * Description: Disable HPD storm detection, trigger a storm and check the
+ *              kernel doesn't detect one
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: dp_hotplug
+ * Mega feature: DP
+ * Driver requirement: any
+ *
+ * SUBTEST: hdmi-hpd-storm-disable
+ * Description: Disable HPD storm detection, trigger a storm and check the
+ *              kernel doesn't detect one
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: hdmi_hotplug
+ * Mega feature: HDMI
+ * Driver requirement: any
+ */
 static const char test_hpd_storm_disable_desc[] =
 	"Disable HPD storm detection, trigger a storm and check the kernel "
 	"doesn't detect one";
-- 
2.40.0

[igt-dev] [V5 i-g-t 10/81] tests/i915/kms_big_fb: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Fix driver requirement

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_big_fb.c | 132 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 132 insertions(+)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 44ea117a1..84485e244 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -21,6 +21,12 @@
  * IN THE SOFTWARE.
  */
 
+/**
+ * TEST: kms big fb
+ * Category: Display
+ * Description: Test big framebuffers
+ */
+
 #include "igt.h"
 #include <errno.h>
 #include <stdbool.h>
@@ -582,6 +588,78 @@ max_hw_stride_async_flip_test(data_t *data)
 	return true;
 }
 
+/**
+ * SUBTEST: %s-%dbpp-rotate-%d
+ * Description: Sanity check if addfb ioctl works correctly for given combination
+ *              of %arg[1] with %arg[2]-bpp & %arg[3]-rotation
+ * Driver requirement: any
+ * Functionality: xorg_big_displays
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @linear:             Linear modifier
+ * @4-tiled:            TILE-4 modifier
+ * @x-tiled:            TILE-X modifier
+ * @y-tiled:            TILE-Y modifier
+ * @yf-tiled:           TILE-YF modifier
+ *
+ * arg[2].values:       8, 16, 32, 64
+ * arg[3].values:       0, 90, 180, 270
+ */
+
+/**
+ * SUBTEST: %s-max-hw-stride-%dbpp-rotate-%d
+ * Description: Test maximum hardware supported stride length for given combination
+ *              of %arg[1] modifier with max hardware stride length, %arg[2]-bpp,
+ *              and %arg[3]-rotation
+ * Driver requirement: any
+ * Functionality: xorg_big_displays
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @linear:             Linear modifier
+ * @4-tiled:            TILE-4 modifier
+ * @x-tiled:            TILE-X modifier
+ * @y-tiled:            TILE-Y modifier
+ * @yf-tiled:           TILE-YF modifier
+ *
+ * arg[2].values:       32, 64
+ * arg[3].values:       0, 180
+ */
+
+/**
+ * SUBTEST: %s-max-hw-stride-%dbpp-rotate-%d-%s
+ * Description: Test maximum hardware supported stride length for given combination
+ *              of %arg[1] modifier with max hardware stride length, %arg[2]-bpp,
+ *              and %arg[3]-rotation with %arg[4] mode
+ * Driver requirement: any
+ * Functionality: xorg_big_displays
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @4-tiled:            TILE-4 modifier
+ * @x-tiled:            TILE-X modifier
+ * @y-tiled:            TILE-Y modifier
+ * @yf-tiled:           TILE-YF modifier
+ *
+ * arg[2].values:       32, 64
+ * arg[3].values:       0, 180
+ *
+ * arg[4]:
+ *
+ * @async-flip:         Async flip
+ * @hflip:              H-flip
+ * @hflip-async-flip:   Async & H-flip
+ */
 static void test_scanout(data_t *data)
 {
 	igt_output_t *output;
@@ -627,6 +705,24 @@ static void test_scanout(data_t *data)
 	igt_skip("unsupported configuration\n");
 }
 
+/**
+ * SUBTEST: %s-addfb-size-overflow
+ * Description: Sanity check if addfb ioctl fails correctly for (%arg[1]) modifier
+ *              with small bo.
+ * Driver requirement: any
+ * Functionality: xorg_big_displays
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @linear:     Linear
+ * @4-tiled:    TILE-4
+ * @x-tiled:    TILE-X
+ * @y-tiled:    TILE-Y
+ * @yf-tiled:   TILE-YF
+ */
 static void
 test_size_overflow(data_t *data)
 {
@@ -671,6 +767,24 @@ test_size_overflow(data_t *data)
 	gem_close(data->drm_fd, bo);
 }
 
+/**
+ * SUBTEST: %s-addfb-size-offset-overflow
+ * Description: Sanity check if addfb ioctl fails correctly for (%arg[1]) modifier
+ *              and offsets with small bo
+ * Driver requirement: any
+ * Functionality: xorg_big_displays
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @linear:     Linear
+ * @4-tiled:    TILE-4
+ * @x-tiled:    TILE-X
+ * @y-tiled:    TILE-Y
+ * @yf-tiled:   TILE-YF
+ */
 static void
 test_size_offset_overflow(data_t *data)
 {
@@ -729,6 +843,24 @@ static int rmfb(int fd, uint32_t id)
 	return err;
 }
 
+/**
+ * SUBTEST: %s-addfb
+ * Description: Sanity check if addfb ioctl works correctly with %arg[1] modifier
+ *              for given size and strides of fb
+ * Driver requirement: any
+ * Functionality: xorg_big_displays
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @linear:     Linear
+ * @4-tiled:    TILE-4
+ * @x-tiled:    TILE-X
+ * @y-tiled:    TILE-Y
+ * @yf-tiled:   TILE-YF
+ */
 static void
 test_addfb(data_t *data)
 {
-- 
2.40.0

[igt-dev] [V5 i-g-t 11/81] tests/i915/kms_big_joiner: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_big_joiner.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/tests/i915/kms_big_joiner.c b/tests/i915/kms_big_joiner.c
index 2ff23398a..c448853c5 100644
--- a/tests/i915/kms_big_joiner.c
+++ b/tests/i915/kms_big_joiner.c
@@ -24,6 +24,11 @@
  *  Karthik B S <karthik.b.s@intel.com>
  */
 
+/**
+ * TEST: kms big joiner
+ * Category: Display
+ * Description: Test big joiner
+ */
 #include "igt.h"
 
 #define MAX_HDISPLAY_PER_PIPE 5120
@@ -40,6 +45,16 @@ typedef struct {
 	uint32_t big_joiner_output[2];
 } data_t;
 
+/**
+ * SUBTEST: invalid-modeset
+ * Description: Verify if the modeset on the adjoining pipe is rejected when
+ *              the pipe is active with a big joiner modeset
+ * Driver requirement: any
+ * Functionality: 2p1p
+ * Mega feature: Bigjoiner
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_invalid_modeset(data_t *data)
 {
 	igt_output_t *output;
@@ -80,6 +95,15 @@ static void test_invalid_modeset(data_t *data)
 	igt_assert_lt(ret, 0);
 }
 
+/**
+ * SUBTEST: basic
+ * Description: Verify the basic modeset on big joiner mode on all pipes
+ * Driver requirement: any
+ * Functionality: 2p1p
+ * Mega feature: Bigjoiner
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_basic_modeset(data_t *data)
 {
 	drmModeModeInfo *mode;
@@ -118,6 +142,15 @@ static void test_basic_modeset(data_t *data)
 	igt_display_commit2(display, COMMIT_ATOMIC);
 }
 
+/**
+ * SUBTEST: 2x-modeset
+ * Description: Verify simultaneous modeset on 2 big joiner outputs
+ * Driver requirement: any
+ * Functionality: 2p1p
+ * Mega feature: Bigjoiner
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_dual_display(data_t *data)
 {
 	drmModeModeInfo *mode;
-- 
2.40.0

[igt-dev] [V5 i-g-t 12/81] tests/i915/kms_busy: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_busy.c | 62 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
index ecc7f02d9..e5a6049f2 100644
--- a/tests/i915/kms_busy.c
+++ b/tests/i915/kms_busy.c
@@ -21,6 +21,11 @@
  * IN THE SOFTWARE.
  */
 
+/**
+ * TEST: kms busy
+ * Category: Display
+ * Description: Basic check of KMS ABI with busy framebuffers.
+ */
 #include <sys/poll.h>
 #include <signal.h>
 #include <time.h>
@@ -131,6 +136,23 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,
 	put_ahnd(ahnd);
 }
 
+/**
+ * SUBTEST: basic
+ * Description: Test for basic check of KMS ABI with busy framebuffers.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: basic-hang
+ * Description: Test for basic check of KMS ABI with busy framebuffers.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_flip(igt_display_t *dpy, int pipe,
 		      igt_output_t *output, bool modeset)
 {
@@ -223,6 +245,37 @@ static void test_atomic_commit_hang(igt_display_t *dpy, igt_plane_t *primary,
 	put_ahnd(ahnd);
 }
 
+/**
+ * SUBTEST: extended-modeset-hang-%s
+ * Description: Test for basic check of KMS ABI with busy framebuffers.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @newfb:                New framebuffer
+ * @oldfb:                Old framebuffer
+ * @newfb-with-reset:     New framebuffer with reset
+ * @oldfb-with-reset:     Old framebuffer with reset
+ */
+
+/**
+ * SUBTEST: extended-pageflip-hang-%s
+ * Description: Test for basic check of KMS ABI with busy framebuffers.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @newfb:     New framebuffer
+ * @oldfb:     Old framebuffer
+ */
 static void test_hang(igt_display_t *dpy,
 		      enum pipe pipe, igt_output_t *output,
 		      bool modeset, bool hang_newfb)
@@ -270,6 +323,15 @@ static void test_hang(igt_display_t *dpy,
 	igt_remove_fb(dpy->drm_fd, &fb[0]);
 }
 
+/**
+ * SUBTEST: extended-pageflip-modeset-hang-oldfb
+ * Description: Test for basic check of KMS ABI with busy framebuffers.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void
 test_pageflip_modeset_hang(igt_display_t *dpy,
 			   igt_output_t *output, enum pipe pipe)
-- 
2.40.0

[igt-dev] [V5 i-g-t 13/81] tests/i915/kms_ccs: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Include mtl ccs tests

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_ccs.c | 89 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 89 insertions(+)

diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
index f04552dd7..995e0a589 100644
--- a/tests/i915/kms_ccs.c
+++ b/tests/i915/kms_ccs.c
@@ -22,10 +22,99 @@
  *
  */
 
+/**
+ * TEST: kms ccs
+ * Category: Display
+ * Description: Test render compression (RC), in which the main surface is
+ *              complemented by a color control surface (CCS) that the display
+ *              uses to interpret the compressed data.
+ */
 #include "igt.h"
 
 #include "i915/gem_create.h"
 
+/**
+ * SUBTEST: %s-%s-%s
+ * Description: Test %arg[2] with given %arg[3] modifier
+ * Driver requirement: any
+ * Functionality: ccs
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @pipe-A:                    Pipe A
+ * @pipe-B:                    Pipe B
+ * @pipe-C:                    Pipe C
+ * @pipe-D:                    Pipe D
+ * @pipe-E:                    Pipe E
+ * @pipe-F:                    Pipe F
+ * @pipe-G:                    Pipe G
+ * @pipe-H:                    Pipe H
+ *
+ * arg[2]:
+ *
+ * @bad-aux-stride:            Bad AUX stride
+ * @ccs-on-another-bo:         CCS with different BO
+ * @missing-ccs-buffer:        Missing CCS buffer
+ *
+ * arg[3]:
+ *
+ * @y_tiled_ccs:               Y tiled ccs
+ * @y_tiled_gen12_mc_ccs:      Y tiled gen12 mc ccs
+ * @y_tiled_gen12_rc_ccs:      Y tiled gen12 rc ccs
+ * @y_tiled_gen12_rc_ccs_cc:   Y tiled gen12 rc ccs cc
+ * @yf_tiled_ccs:              YF tiled ccs
+ * @4_tiled_mtl_mc_ccs:        4 tiled mtl mc ccs
+ * @4_tiled_mtl_rc_ccs:        4 tiled mtl rc ccs
+ * @4_tiled_mtl_rc_ccs_cc:     4 tiled mtl rc ccs cc
+ */
+
+/**
+ * SUBTEST: %s-%s-%s
+ * Description: Test %arg[2] with %arg[3] modifier
+ * Driver requirement: any
+ * Functionality: ccs
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @pipe-A:                      Pipe A
+ * @pipe-B:                      Pipe B
+ * @pipe-C:                      Pipe C
+ * @pipe-D:                      Pipe D
+ * @pipe-E:                      Pipe E
+ * @pipe-F:                      Pipe F
+ * @pipe-G:                      Pipe G
+ * @pipe-H:                      Pipe H
+ *
+ * arg[2]:
+ *
+ * @bad-pixel-format:            Bad pixel format
+ * @bad-rotation-90:             90 degree rotation
+ * @crc-primary-basic:           Primary plane CRC compatibility
+ * @crc-primary-rotation-180:    180 degree rotation
+ * @crc-sprite-planes-basic:     Sprite plane CRC compatability
+ * @random-ccs-data:             Random CCS data
+ *
+ * arg[3]:
+ *
+ * @4_tiled_dg2_mc_ccs:        4 tiled mc ccs
+ * @4_tiled_dg2_rc_ccs:        4 tiled dg2 rc ccs
+ * @4_tiled_dg2_rc_ccs_cc:     4 tiled dg2 rc ccs cc
+ * @4_tiled_mtl_mc_ccs:        4 tiled mtl mc ccs
+ * @4_tiled_mtl_rc_ccs:        4 tiled mtl rc ccs
+ * @4_tiled_mtl_rc_ccs_cc:     4 tiled mtl rc ccs cc
+ * @y_tiled_ccs:               Y tiled ccs
+ * @y_tiled_gen12_mc_ccs:      Y tiled gen12 mc ccs
+ * @y_tiled_gen12_rc_ccs:      Y tiled gen12 rc ccs
+ * @y_tiled_gen12_rc_ccs_cc:   Y tiled gen12 rc ccs cc
+ * @yf_tiled_ccs:              YF tiled ccs
+ */
+
 #define SDR_PLANE_BASE	3
 
 IGT_TEST_DESCRIPTION("Test render compression (RC), in which the main surface "
-- 
2.40.0

[igt-dev] [V5 i-g-t 14/81] tests/i915/kms_cdclk: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_cdclk.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/tests/i915/kms_cdclk.c b/tests/i915/kms_cdclk.c
index 40eca24f0..276cda4c4 100644
--- a/tests/i915/kms_cdclk.c
+++ b/tests/i915/kms_cdclk.c
@@ -24,6 +24,11 @@
  *  Swati Sharma <swati2.sharma@intel.com>
  */
 
+/**
+ * TEST: kms cdclk
+ * Category: Display
+ * Description: Test cdclk features : crawling and squashing
+ */
 #include "igt.h"
 
 IGT_TEST_DESCRIPTION("Test cdclk features : crawling and squashing");
@@ -248,6 +253,16 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
 	igt_remove_fb(display->drm_fd, &fb);
 }
 
+/**
+ * SUBTEST: mode-transition-all-outputs
+ * Description: Mode transition (low to high) test to validate cdclk frequency
+ *              change by simultaneous modesets on all pipes with valid outputs.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_mode_transition_on_all_outputs(data_t *data)
 {
 	igt_display_t *display = &data->display;
@@ -344,6 +359,23 @@ static void test_mode_transition_on_all_outputs(data_t *data)
 	igt_remove_fb(data->drm_fd, &fb);
 }
 
+/**
+ * SUBTEST: mode-transition
+ * Description: Mode transition (low to high) test to validate cdclk frequency change.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-scaling
+ * Description: Plane scaling test to validate cdclk frequency change.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void run_cdclk_test(data_t *data, uint32_t flags)
 {
 	igt_display_t *display = &data->display;
-- 
2.40.0

[igt-dev] [V5 i-g-t 15/81] tests/i915/kms_draw_crc: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_draw_crc.c | 49 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 47 insertions(+), 2 deletions(-)

diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c
index 01ecb7bb9..8a001f6b6 100644
--- a/tests/i915/kms_draw_crc.c
+++ b/tests/i915/kms_draw_crc.c
@@ -22,8 +22,11 @@
  *
  */
 
-/* This program tests whether the igt_draw library actually works. */
-
+/**
+ * TEST: kms draw crc
+ * Category: Display
+ * Description: Tests whether the igt_draw library actually works.
+ */
 #include "i915/gem.h"
 #include "igt.h"
 
@@ -140,6 +143,39 @@ static void get_method_crc(enum igt_draw_method method, uint32_t drm_format,
 	igt_remove_fb(drm_fd, &fb);
 }
 
+/**
+ * SUBTEST: draw-method-%s
+ * Description: Verify that igt draw library works for the %arg[1] method with
+ *              different modifiers & DRM formats.
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @blt:          Blitter
+ * @mmap-wc:      MMAP-WC
+ * @render:       Render
+ */
+
+/**
+ * SUBTEST: draw-method-%s
+ * Description: Verify that igt draw library works for the %arg[1] method with
+ *              different modifiers & DRM formats.
+ * Driver requirement: i915
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @mmap-cpu:     MMAP-CPU
+ * @mmap-gtt:     MMAP-GTT
+ * @pwrite:       PWRITE
+ */
 static void draw_method_subtest(enum igt_draw_method method,
 				uint32_t format_index, uint64_t modifier)
 {
@@ -179,6 +215,15 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t *crc)
 	igt_remove_fb(drm_fd, &fb);
 }
 
+/**
+ * SUBTEST: fill-fb
+ * Description: This subtest verifies CRC after filling fb with x-tiling or none.
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void fill_fb_subtest(void)
 {
 	int rc;
-- 
2.40.0

[igt-dev] [V5 i-g-t 16/81] tests/i915/kms_dsc: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_dsc.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
index 0a3e29924..4cce7face 100644
--- a/tests/i915/kms_dsc.c
+++ b/tests/i915/kms_dsc.c
@@ -30,8 +30,35 @@
  *
  */
 
+/**
+ * TEST: kms dsc
+ * Category: Display
+ * Description: Test to validate display stream compression
+ */
 #include "kms_dsc_helper.h"
 
+/**
+ * SUBTEST: dsc-%s
+ * Description: Tests basic display stream compression functionality if supported
+ *              by a connector by forcing %arg[1]
+ * Driver requirement: any
+ * Functionality: dsc
+ * Mega feature: VDSC
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @basic:                DSC on all connectors that support it with default parameters
+ * @with-bpc:             DSC on all connectors that support it with certain input BPC
+ *                        for the connector
+ * @with-bpc-formats:     DSC on all connectors that support it with certain input
+ *                        BPC for the connector with diff formats
+ * @with-formats:         DSC on all connectors that support it with default parameters
+ *                        and creating fb with diff formats
+ * @with-output-formats:  DSC and output format on all connectors that support it
+ */
+
 IGT_TEST_DESCRIPTION("Test to validate display stream compression");
 
 enum dsc_test_type {
-- 
2.40.0

[igt-dev] [V5 i-g-t 17/81] tests/i915/kms_fb_coherency: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_fb_coherency.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/i915/kms_fb_coherency.c b/tests/i915/kms_fb_coherency.c
index edb5ba460..8a553613a 100644
--- a/tests/i915/kms_fb_coherency.c
+++ b/tests/i915/kms_fb_coherency.c
@@ -5,6 +5,7 @@
 
 /**
  * TEST: kms_fb_coherency
+ * Category: Display
  * Description: Exercise coherency of future scanout buffer objects
  */
 
@@ -245,6 +246,9 @@ igt_main
 	 *		mmapped with different mmap methods and different caching modes.
 	 * Mega feature: General Display Features
 	 * Functionality: gtt
+	 * Driver requirement: any
+	 * Run type: FULL
+	 * Test category: functionality test
 	 */
 	igt_subtest_with_dynamic("memset-crc") {
 		if (gem_has_mappable_ggtt(data.drm_fd)) {
-- 
2.40.0

[igt-dev] [V5 i-g-t 18/81] tests/i915/kms_fbcon_fbt: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_fbcon_fbt.c | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/tests/i915/kms_fbcon_fbt.c b/tests/i915/kms_fbcon_fbt.c
index 71c5285f1..990d31a23 100644
--- a/tests/i915/kms_fbcon_fbt.c
+++ b/tests/i915/kms_fbcon_fbt.c
@@ -32,6 +32,48 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 
+/**
+ * TEST: kms fbcon fbt
+ * Category: Display
+ * Description: Test the relationship between fbcon and the frontbuffer tracking
+ *              infrastructure.
+ *
+ * SUBTEST: fbc
+ * Description: Test the relationship between fbcon and the frontbuffer tracking
+ *              infrastructure with fbc enabled.
+ * Driver requirement: any
+ * Functionality: fbc, fbcon
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: fbc-suspend
+ * Description: Suspend test to validate  the relationship between fbcon and the
+ *              frontbuffer tracking infrastructure with fbc enabled.
+ * Driver requirement: any
+ * Functionality: fbc, fbcon
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr
+ * Description: Test the relationship between fbcon and the frontbuffer tracking
+ *              infrastructure with psr enabled.
+ * Driver requirement: any
+ * Functionality: fbcon, psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr-suspend
+ * Description: Suspend test to validate the relationship between fbcon and the
+ *              frontbuffer tracking infrastructure with psr enabled.
+ * Driver requirement: any
+ * Functionality: fbcon, psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Test the relationship between fbcon and the frontbuffer "
 		     "tracking infrastructure.");
-- 
2.40.0

[igt-dev] [V5 i-g-t 19/81] tests/i915/kms_fence_pin_leak: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_fence_pin_leak.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/i915/kms_fence_pin_leak.c b/tests/i915/kms_fence_pin_leak.c
index 3d63acfef..0321aa3cb 100644
--- a/tests/i915/kms_fence_pin_leak.c
+++ b/tests/i915/kms_fence_pin_leak.c
@@ -30,6 +30,19 @@
 
 #include "i915/gem.h"
 #include "igt.h"
+/**
+ * TEST: kms fence pin leak
+ * Category: Display
+ * Description: Exercises full ppgtt fence pin_count leak in the kernel.
+ *
+ * SUBTEST:
+ * Description: Exercises full ppgtt fence pin_count leak in the kernel.
+ * Driver requirement: i915
+ * Functionality: kms_core, synchronization
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Exercises full ppgtt fence pin_count leak in the "
 		     "kernel.");
-- 
2.40.0

[igt-dev] [V5 i-g-t 20/81] tests/i915/kms_flip_scaled_crc: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_flip_scaled_crc.c | 191 +++++++++++++++++++++++++++++++
 1 file changed, 191 insertions(+)

diff --git a/tests/i915/kms_flip_scaled_crc.c b/tests/i915/kms_flip_scaled_crc.c
index 30da1fcf3..f8eefa293 100644
--- a/tests/i915/kms_flip_scaled_crc.c
+++ b/tests/i915/kms_flip_scaled_crc.c
@@ -22,8 +22,199 @@
  *
  */
 
+/**
+ * TEST: kms flip scaled crc
+ * Category: Display
+ * Description: Test flipping between scaled/nonscaled framebuffers
+ */
 #include "igt.h"
 
+/**
+ * SUBTEST: flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling
+ * Description: Flip from 64bpp non scaled fb to 32bpp upscaled fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling
+ * Description: Flip from 64bpp non scaled fb to 32bpp downscaled fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-linear-to-64bpp-linear-%s
+ * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-%s
+ * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-4tile-to-64bpp-4tile-%s
+ * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-xtile-to-64bpp-xtile-%s
+ * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-yftile-to-32bpp-yftileccs-%s
+ * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-yftile-to-64bpp-yftile-%s
+ * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-yftileccs-to-64bpp-yftile-%s
+ * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-ytile-to-32bpp-ytileccs-%s
+ * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-%s
+ * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-ytile-to-64bpp-ytile-%s
+ * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-32bpp-ytileccs-to-64bpp-ytile-%s
+ * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-%s
+ * Description: Flip from 64bpp non scaled fb to 32bpp %arg[1] fb to stress CD
+ *              clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @downscaling:        Downscaled
+ * @upscaling:          Upscaled
+ */
+
+/**
+ * SUBTEST: flip-64bpp-4tile-to-%dbpp-4tile-%s
+ * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
+ *              CD clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-64bpp-xtile-to-%dbpp-xtile-%s
+ * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
+ *              CD clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-64bpp-yftile-to-%dbpp-yftile-%s
+ * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
+ *              CD clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-64bpp-ytile-to-%dbpp-ytile-%s
+ * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
+ *              CD clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-64bpp-linear-to-%dbpp-linear-%s
+ * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
+ *              CD clock programming
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1].values: 16, 32
+ * arg[2]:
+ *
+ * @downscaling:        Downscaled
+ * @upscaling:          Upscaled
+ */
+
 IGT_TEST_DESCRIPTION("Test flipping between scaled/nonscaled framebuffers");
 
 typedef struct {
-- 
2.40.0

[igt-dev] [V5 i-g-t 21/81] tests/i915/kms_flip_tiling: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_flip_tiling.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/i915/kms_flip_tiling.c b/tests/i915/kms_flip_tiling.c
index 02a5fe8e3..6cb85e9d3 100644
--- a/tests/i915/kms_flip_tiling.c
+++ b/tests/i915/kms_flip_tiling.c
@@ -30,6 +30,19 @@
 #include <string.h>
 
 #include "igt.h"
+/**
+ * TEST: kms flip tiling
+ * Category: Display
+ * Description: Test page flips and tiling scenarios
+ *
+ * SUBTEST: flip-change-tiling
+ * Description: Check pageflip between modifiers
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Test page flips and tiling scenarios");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 22/81] tests/i915/kms_frontbuffer_tracking: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Note: This documentation is generated by the script & made changes
on top of it.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_frontbuffer_tracking.c | 808 ++++++++++++++++++++++++++
 1 file changed, 808 insertions(+)

diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
index b2183b08e..64f9b9412 100644
--- a/tests/i915/kms_frontbuffer_tracking.c
+++ b/tests/i915/kms_frontbuffer_tracking.c
@@ -24,6 +24,11 @@
  *
  */
 
+/**
+ * TEST: kms frontbuffer tracking
+ * Category: Display
+ * Description: Test the Kernel's frontbuffer tracking mechanism and its related features: FBC, PSR and DRRS
+ */
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
@@ -1952,6 +1957,28 @@ static void prepare_subtest(const struct test_mode *t,
 	prepare_subtest_screens(t);
 }
 
+/**
+ * SUBTEST: %s-%dp-rte
+ * Description: Sanity test to enable %arg[1] with %arg[2] panels.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ */
+
 /*
  * rte - the basic sanity test
  *
@@ -2012,6 +2039,308 @@ static bool op_disables_psr(const struct test_mode *t,
 	return false;
 }
 
+/**
+ * SUBTEST: %s-1p-offscren-pri-%s-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @indfb:          Individual fb
+ * @shrfb:          Shared fb
+ *
+ * arg[3]:
+ *
+ * @blt:            Blitter
+ * @mmap-wc:        MMAP-WC
+ * @render:         Render
+ */
+
+/**
+ * SUBTEST: %s-1p-offscren-pri-%s-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @indfb:          Individual fb
+ * @shrfb:          Shared fb
+ *
+ * arg[3]:
+ *
+ * @mmap-cpu:       MMAP-CPU
+ * @mmap-gtt:       MMAP-GTT
+ * @pwrite:         PWRITE
+ */
+
+/**
+ * SUBTEST: %s-%dp-primscrn-%s-indfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @cur:            Cursor plane
+ * @pri:            Primary plane
+ * @spr:            Sprite plane
+ *
+ * arg[4]:
+ *
+ * @mmap-cpu:       MMAP-CPU
+ * @mmap-gtt:       MMAP-GTT
+ * @pwrite:         PWRITE
+ */
+
+/**
+ * SUBTEST: %s-%dp-primscrn-%s-indfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @cur:            Cursor plane
+ * @pri:            Primary plane
+ * @spr:            Sprite plane
+ *
+ * arg[4]:
+ *
+ * @blt:            Blitter
+ * @mmap-wc:        MMAP-WC
+ * @render:         Render
+ */
+
+/**
+ * SUBTEST: %s-%dp-primscrn-pri-shrfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @blt:            Blitter
+ * @mmap-wc:        MMAP-WC
+ * @render:         Render
+ */
+
+/**
+ * SUBTEST: %s-%dp-primscrn-pri-shrfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @mmap-cpu:       MMAP-CPU
+ * @mmap-gtt:       MMAP-GTT
+ * @pwrite:         PWRITE
+ */
+
+/**
+ * SUBTEST: %s-2p-scndscrn-%s-indfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @cur:            Cursor plane
+ * @pri:            Primary plane
+ * @spr:            Sprite plane
+ *
+ * arg[3]:
+ *
+ * @blt:            Blitter
+ * @mmap-wc:        MMAP-WC
+ * @render:         Render
+ */
+
+/**
+ * SUBTEST: %s-2p-scndscrn-%s-indfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @cur:            Cursor plane
+ * @pri:            Primary plane
+ * @spr:            Sprite plane
+ *
+ * arg[3]:
+ *
+ * @mmap-cpu:       MMAP-CPU
+ * @mmap-gtt:       MMAP-GTT
+ * @pwrite:         PWRITE
+ */
+
+/**
+ * SUBTEST: %s-2p-scndscrn-pri-shrfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @blt:            Blitter
+ * @mmap-wc:        MMAP-WC
+ * @render:         Render
+ */
+
+/**
+ * SUBTEST: %s-2p-scndscrn-pri-shrfb-draw-%s
+ * Description: Draw a set of rectangles on the screen using the provided method
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @mmap-cpu:       MMAP-CPU
+ * @mmap-gtt:       MMAP-GTT
+ * @pwrite:         PWRITE
+ */
+
 /*
  * draw - draw a set of rectangles on the screen using the provided method
  *
@@ -2085,6 +2414,28 @@ static void draw_subtest(const struct test_mode *t)
 	}
 }
 
+/**
+ * SUBTEST: %s-%dp-pri-indfb-multidraw
+ * Description: Draw a set of rectangles on the screen using alternated drawing methods
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ */
+
 /*
  * multidraw - draw a set of rectangles on the screen using alternated drawing
  *             methods
@@ -2233,6 +2584,68 @@ static void badformat_subtest(const struct test_mode *t)
 	do_assertions(assertions);
 }
 
+/**
+ * SUBTEST: %s-%s-draw-%s
+ * Description: Test pixel formats (%arg[2]) that are not FORMAT_DEFAULT
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @rgb101010:      FORMAT_RGB101010
+ * @rgb565:         FORMAT_RGB565
+ *
+ * arg[3]:
+ *
+ * @blt:            Blitter
+ * @mmap-wc:        MMAP-WC
+ * @render:         Render
+ */
+
+/**
+ * SUBTEST: %s-%s-draw-%s
+ * Description: Test pixel formats (%arg[2]) that are not FORMAT_DEFAULT
+ * Driver requirement: i915
+ * Functionality: kms_core, gtt
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @rgb101010:      FORMAT_RGB101010
+ * @rgb565:         FORMAT_RGB565
+ *
+ * arg[3]:
+ *
+ * @mmap-cpu:       MMAP-CPU
+ * @mmap-gtt:       MMAP-GTT
+ * @pwrite:         PWRITE
+ */
+
 /*
  * format_draw - test pixel formats that are not FORMAT_DEFAULT
  *
@@ -2276,6 +2689,25 @@ static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
 	}
 }
 
+/**
+ * SUBTEST: %s-slowdraw
+ * Description: Sleep a little bit between drawing operations with %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ */
+
 /*
  * slow_draw - sleep a little bit between drawing operations
  *
@@ -2382,6 +2814,70 @@ static void page_flip_for_params(struct modeset_params *params,
 	}
 }
 
+/**
+ * SUBTEST: %s-%dp-primscrn-%s-%sflip-blt
+ * Description: Just exercise page flips with the patterns we have
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @indfb:          Individual fb
+ * @shrfb:          Shared fb
+ *
+ * arg[4]:
+ *
+ * @ms:             Modeset
+ * @pg:             Page flip
+ * @pl:             Plane change
+ */
+
+/**
+ * SUBTEST: %s-2p-scndscrn-%s-%sflip-blt
+ * Description: Just exercise page flips with the patterns we have
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @indfb:          Individual fb
+ * @shrfb:          Shared fb
+ *
+ * arg[3]:
+ *
+ * @ms:             Modeset
+ * @pg:             Page flip
+ * @pl:             Plane change
+ */
+
 /*
  * flip - just exercise page flips with the patterns we have
  *
@@ -2442,6 +2938,30 @@ static void flip_subtest(const struct test_mode *t)
 	igt_remove_fb(drm.fd, &fb2);
 }
 
+/**
+ * SUBTEST: %s-%dp-%s-fliptrack-mmap-gtt
+ * Description: Check if the hardware tracking works after page flips
+ * Driver requirement: i915
+ * Functionality: fbc, gtt, kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @fbc:            FBC
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @indfb:          Individual fb
+ * @shrfb:          Shared fb
+ */
+
 /*
  * fliptrack - check if the hardware tracking works after page flips
  *
@@ -2490,6 +3010,58 @@ static void fliptrack_subtest(const struct test_mode *t, enum flip_type type)
 	igt_remove_fb(drm.fd, &fb2);
 }
 
+/**
+ * SUBTEST: %s-%dp-primscrn-%s-indfb-move
+ * Description: Just move the %arg[3] around
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @spr:            Sprite plane
+ * @cur:            Cursor plane
+ */
+
+/**
+ * SUBTEST: %s-2p-scndscrn-%s-indfb-move
+ * Description: Just move the %arg[2] around
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @spr:            Sprite plane
+ * @cur:            Cursor plane
+ */
+
 /*
  * move - just move the sprite or cursor around
  *
@@ -2543,6 +3115,58 @@ static void move_subtest(const struct test_mode *t)
 	}
 }
 
+/**
+ * SUBTEST: %s-%dp-primscrn-%s-indfb-onoff
+ * Description: Just enable and disable the %arg[3] a few times
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ *
+ * arg[3]:
+ *
+ * @spr:            Sprite plane
+ * @cur:            Cursor plane
+ */
+
+/**
+ * SUBTEST: %s-2p-scndscrn-%s-indfb-onoff
+ * Description: Just enable and disable the %arg[2] a few times
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @spr:            Sprite plane
+ * @cur:            Cursor plane
+ */
+
 /*
  * onoff - just enable and disable the sprite or cursor plane a few times
  *
@@ -2602,6 +3226,36 @@ static bool prim_plane_disabled(void)
 	return !prim_mode_params.primary.plane->values[IGT_PLANE_FB_ID];
 }
 
+/**
+ * SUBTEST: %s-%dp-primscrn-spr-indfb-fullscreen
+ * Description: Put a fullscreen plane covering the whole screen
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: %s-2p-scndscrn-spr-indfb-fullscreen
+ * Description: Put a fullscreen plane covering the whole screen
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2].values:   1, 2
+ */
+
 /*
  * fullscreen_plane - put a fullscreen plane covering the whole screen
  *
@@ -2663,6 +3317,31 @@ static void fullscreen_plane_subtest(const struct test_mode *t)
 	igt_remove_fb(drm.fd, &fullscreen_fb);
 }
 
+/**
+ * SUBTEST: %s-%s-scaledprimary
+ * Description: Try different primary plane scaling strategies
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @indfb:          Individual fb
+ * @shrfb:          Shared fb
+ */
+
 /*
  * scaledprimary - try different primary plane scaling strategies
  *
@@ -2768,6 +3447,27 @@ static void scaledprimary_subtest(const struct test_mode *t)
 
 	igt_remove_fb(drm.fd, &new_fb);
 }
+
+/**
+ * SUBTEST: %s-modesetfrombusy
+ * Description: Modeset from a busy buffer to a non-busy buffer with %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ */
+
 /**
  * modesetfrombusy - modeset from a busy buffer to a non-busy buffer
  *
@@ -2811,6 +3511,26 @@ static void modesetfrombusy_subtest(const struct test_mode *t)
 	igt_remove_fb(drm.fd, &fb2);
 }
 
+/**
+ * SUBTEST: %s-suspend
+ * Description: Make sure suspend/resume keeps us on the same state of %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ */
+
 /**
  * suspend - make sure suspend/resume keeps us on the same state
  *
@@ -2843,6 +3563,26 @@ static void suspend_subtest(const struct test_mode *t)
 	do_assertions(0);
 }
 
+/**
+ * SUBTEST: %s-farfromfence-mmap-gtt
+ * Description: Test drawing as far from the fence start as possible
+ * Driver requirement: i915
+ * Functionality: gtt, kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drrs:           DRRS
+ * @fbc:            FBC
+ * @psr:            PSR
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @psrdrrs:        PSR and DRRS
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ */
+
 /**
  * farfromfence - test drawing as far from the fence start as possible
  *
@@ -2939,6 +3679,23 @@ static void try_invalid_strides(void)
 	gem_close(drm.fd, gem_handle);
 }
 
+/**
+ * SUBTEST: %s-badstride
+ * Description: Try to use buffers with strides that are not supported
+ * Driver requirement: any
+ * Functionality: fbc, kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @fbc:            FBC
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ */
+
 /**
  * badstride - try to use buffers with strides that are not supported
  *
@@ -3007,6 +3764,23 @@ static void badstride_subtest(const struct test_mode *t)
 	igt_remove_fb(drm.fd, &wide_fb);
 }
 
+/**
+ * SUBTEST: %s-stridechange
+ * Description: Change the frontbuffer stride by doing a modeset
+ * Driver requirement: any
+ * Functionality: fbc, kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @fbc:            FBC
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ */
+
 /**
  * stridechange - change the frontbuffer stride by doing a modeset
  *
@@ -3071,6 +3845,30 @@ static void stridechange_subtest(const struct test_mode *t)
 	do_assertions(rc ? 0 : DONT_ASSERT_FBC_STATUS);
 }
 
+/**
+ * SUBTEST: %s-tiling-%s
+ * Description: Test %arg[2] formats, if the tiling format supports FBC do the
+ *              basic drawing test, else set the mode & test if FBC is disabled
+ * Driver requirement: any
+ * Functionality: fbc, kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @fbc:            FBC
+ * @fbcdrrs:        FBC and DRRS
+ * @fbcpsr:         FBC and PSR
+ * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
+ *
+ * arg[2]:
+ *
+ * @4:              4 tiling
+ * @linear:         Linear tiling
+ * @y:              Y tiling
+ */
+
 /**
  * tiling_disable_fbc_subtest - Check if tiling is unsupported by FBC
  *
@@ -3120,6 +3918,16 @@ static void tiling_disable_fbc_subtest(const struct test_mode *t)
 	igt_remove_fb(drm.fd, &new_fb);
 }
 
+/**
+ * SUBTEST: basic
+ * Description: Do some basic operations regardless of which features are enabled
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 /*
  * basic - do some basic operations regardless of which features are enabled
  *
-- 
2.40.0

[igt-dev] [V5 i-g-t 23/81] tests/i915/kms_legacy_colorkey: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_legacy_colorkey.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tests/i915/kms_legacy_colorkey.c b/tests/i915/kms_legacy_colorkey.c
index 450cb2e3f..fb1952113 100644
--- a/tests/i915/kms_legacy_colorkey.c
+++ b/tests/i915/kms_legacy_colorkey.c
@@ -24,6 +24,27 @@
 #include "igt.h"
 #include <errno.h>
 
+/**
+ * TEST: kms legacy colorkey
+ * Category: Display
+ * Description: Check that the legacy set colorkey ioctl only works on sprite planes.
+ *
+ * SUBTEST: basic
+ * Description: Test to check the legacy set colorkey ioctl only works for sprite planes.
+ * Driver requirement: i915
+ * Functionality: xorg_xv
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid-plane
+ * Description: Check invalid plane id's, zero and outrange
+ * Driver requirement: i915
+ * Functionality: xorg_xv
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Check that the legacy set colorkey ioctl only works on sprite planes.");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 24/81] tests/i915/kms_mmap_write_crc: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_mmap_write_crc.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tests/i915/kms_mmap_write_crc.c b/tests/i915/kms_mmap_write_crc.c
index 5a9eeec48..2a51d77ac 100644
--- a/tests/i915/kms_mmap_write_crc.c
+++ b/tests/i915/kms_mmap_write_crc.c
@@ -37,6 +37,20 @@
 #include "intel_chipset.h"
 #include "ioctl_wrappers.h"
 #include "igt_aux.h"
+/**
+ * TEST: kms mmap write crc
+ * Category: Display
+ * Description: Use the display CRC support to validate mmap write to an already
+ *              uncached future scanout buffer.
+ *
+ * SUBTEST: main
+ * Description: Tests that caching mode has become UC/WT and flushed using mmap write
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION(
    "Use the display CRC support to validate mmap write to an already uncached future scanout buffer.");
-- 
2.40.0

[igt-dev] [V5 i-g-t 25/81] tests/i915/kms_pipe_b_c_ivb: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_pipe_b_c_ivb.c | 52 +++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
index 192771794..f19355511 100644
--- a/tests/i915/kms_pipe_b_c_ivb.c
+++ b/tests/i915/kms_pipe_b_c_ivb.c
@@ -25,6 +25,58 @@
  */
 
 #include "igt.h"
+/**
+ * TEST: kms pipe b c ivb
+ * Category: Display
+ * Description: Exercise the FDI lane bifurcation code for IVB in the kernel by
+ *              setting different combinations of modes for pipes B and C.
+ *
+ * SUBTEST: disable-pipe-B-enable-pipe-C
+ * Description: Tests pipe-B and pipe-C interactions in IVB by disabling pipe-B
+ *              and then setting mode on pipe-C.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: enable-pipe-C-while-B-has-3-lanes
+ * Description: Tests pipe-B and pipe-C interactions in IVB by enabling pipe-C
+ *              while pipe-B has 3-lanes
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: from-pipe-C-to-B-with-3-lanes
+ * Description: Tests pipe-B and pipe-C interactions in IVB by enabling pipe-B
+ *              with 3 lanes from pipe-C.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: pipe-B-double-modeset-then-modeset-pipe-C
+ * Description: Tests pipe-B and pipe-C interactions in IVB by enabling two
+ *              different modes on pipe-B and then a single mode on pipe-C.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: pipe-B-dpms-off-modeset-pipe-C
+ * Description: Tests pipe-B and pipe-C interactions in IVB by enabling pipe-B
+ *              with mode that requires 3 lanes and then enabling pipe-c with
+ *              dpms off/on pipe-B.
+ * Driver requirement: i915
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION(
 "Exercise the FDI lane bifurcation code for IVB in the kernel by setting"
-- 
2.40.0

[igt-dev] [V5 i-g-t 26/81] tests/i915/kms_psr: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Add missing "Driver requirement" field

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_psr.c | 213 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 212 insertions(+), 1 deletion(-)

diff --git a/tests/i915/kms_psr.c b/tests/i915/kms_psr.c
index 3f8f83b42..72043ba89 100644
--- a/tests/i915/kms_psr.c
+++ b/tests/i915/kms_psr.c
@@ -23,8 +23,9 @@
  */
 
 /**
- * TEST: Tests behaviour of PSR & PSR2
+ * TEST: kms psr
  * Category: Display
+ * Description: Tests behaviour of PSR & PSR2
  */
 
 #include "igt.h"
@@ -36,6 +37,213 @@
 #include <string.h>
 #include "xe/xe_ioctl.h"
 
+/**
+ * SUBTEST: basic
+ * Description: Basic check for psr if it is detecting changes made in planes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: %s_%s
+ * Description: Check if psr is detecting memory mapping, rendering and plane
+ *              operations performed on %arg[1]
+ * Driver requirement: i915
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:             Cursor plane
+ * @primary:            Primary plane
+ * @sprite:             Sprite plane
+ *
+ * arg[2]:
+ *
+ * @mmap_cpu:           MMAP CPU
+ * @mmap_gtt:           MMAP GTT
+ */
+
+/**
+ * SUBTEST: sprite_plane_move
+ * Description: Check if psr is detecting memory mapping, rendering and plane
+ *              operations performed on sprite planes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: %s_%s
+ * Description: Check if psr is detecting memory mapping, rendering and plane
+ *              operations performed on %arg[1] planes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:             Cursor plane
+ * @sprite:             Sprite plane
+ *
+ * arg[2]:
+ *
+ * @blt:                Blitter
+ * @render:             Render
+ * @plane_onoff:        Plane On off
+ */
+
+/**
+ * SUBTEST: primary_%s
+ * Description: Check if psr is detecting memory mapping, rendering and plane
+ *              operations performed on %arg[1] planes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @blt:                Blitter
+ * @render:             Render
+ */
+
+/**
+ * SUBTEST: dpms
+ * Description: Check if psr is detecting changes when rendering operation is
+ *              performed  with dpms enabled or disabled
+ * Driver requirement: any
+ * Functionality: dpms, psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: no_drrs
+ * Description: Check if psr is detecting changes when drrs is disabled
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: suspend
+ * Description: Check if psr is detecting changes when plane operation
+ *              is performed with suspend resume cycles
+ * Driver requirement: any
+ * Functionality: psr, suspend
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr2_dpms
+ * Description: Check if psr is detecting changes when rendering operation
+ *              is performed  with dpms enabled or disabled
+ * Driver requirement: any
+ * Functionality: psr, psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr2_no_drrs
+ * Description: Check if psr is detecting changes when drrs is disabled
+ * Driver requirement: any
+ * Functionality: psr, psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr2_suspend
+ * Description: Check if psr is detecting changes when plane operation is
+ *              performed with suspend resume cycles
+ * Driver requirement: any
+ * Functionality: psr, psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr2_basic
+ * Description: Basic check for psr if it is detecting changes made in planes
+ * Driver requirement: any
+ * Functionality: psr, psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr2_%s_%s
+ * Description: Check if psr2 is detecting memory mapping, rendering and plane
+ *              operations performed on %arg[1] planes
+ * Driver requirement: i915
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:             Cursor plane
+ * @primary:            Primary plane
+ * @sprite:             Sprite plane
+ *
+ * arg[2]:
+ *
+ * @mmap_cpu:           MMAP CPU
+ * @mmap_gtt:           MMAP GTT
+ */
+
+/**
+ * SUBTEST: psr2_primary_page_flip
+ * Description: Check if psr is detecting memory mapping, rendering and plane
+ *              operations performed on primary planes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: psr2_primary_%s
+ * Description: Check if psr is detecting memory mapping, rendering and plane
+ *              operations performed on primary planes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @blt:                Blitter
+ * @render:             Render
+ */
+
+/**
+ * SUBTEST: psr2_%s_%s
+ * Description: Check if psr is detecting memory mapping, rendering and plane
+ *              operations performed on %arg[1] planes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:             Cursor plane
+ * @sprite:             Sprite plane
+ *
+ * arg[2]:
+ *
+ * @blt:                Blitter
+ * @render:             Render
+ * @plane_onoff:        Plane On off
+ * @plane_move:         Move plane position
+ */
+
 enum operations {
 	PAGE_FLIP,
 	MMAP_GTT,
@@ -309,6 +517,7 @@ static void fb_dirty_fb_ioctl(data_t *data, struct igt_fb *fb)
  * SUBTEST: cursor_plane_move
  * Description: Check if psr is detecting the plane operations performed on
  *		cursor planes
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: psr
@@ -317,6 +526,7 @@ static void fb_dirty_fb_ioctl(data_t *data, struct igt_fb *fb)
  * SUBTEST: primary_page_flip
  * Description: Check if psr is detecting page-flipping operations performed
  *		on primary planes
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: psr
@@ -325,6 +535,7 @@ static void fb_dirty_fb_ioctl(data_t *data, struct igt_fb *fb)
  * SUBTEST: sprite_plane_onoff
  * Description: Check if psr is detecting the plane operations performed on
  *		sprite planes
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: psr
-- 
2.40.0

[igt-dev] [V5 i-g-t 27/81] tests/i915/kms_psr2_sf: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_psr2_sf.c | 85 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
index b4734e5f1..60946ed92 100644
--- a/tests/i915/kms_psr2_sf.c
+++ b/tests/i915/kms_psr2_sf.c
@@ -30,6 +30,91 @@
 #include <stdbool.h>
 #include <stdio.h>
 #include <string.h>
+/**
+ * TEST: kms psr2 sf
+ * Category: Display
+ * Description: Tests to varify PSR2 selective fetch by sending multiple damaged
+ *              areas
+ *
+ * SUBTEST: %s-plane-move-continuous-%s
+ * Description: Test that selective fetch works on moving %arg[1] plane %arg[2]
+ *              visible area (no update)
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:               Cursor
+ * @overlay:              Overlay
+ *
+ * arg[2]:
+ *
+ * @exceed-fully-sf:      exceeding fully
+ * @exceed-sf:            exceeding paritally
+ * @sf:                   default
+ */
+
+/**
+ * SUBTEST: cursor-plane-update-sf
+ * Description: Test that selective fetch works on cursor plane
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: overlay-plane-update-continuous-sf
+ * Description: Test that selective fetch works on overlay plane
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: overlay-plane-update-sf-dmg-area
+ * Description: Test that selective fetch works on overlay plane
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: overlay-primary-update-sf-dmg-area
+ * Description: Test that selective fetch works on primary plane with blended
+ *              overlay plane
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-move-sf-dmg-area
+ * Description: Test that selective fetch works on moving overlay plane
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: primary-plane-update-sf-dmg-area
+ * Description: Test that selective fetch works on primary plane
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: primary-plane-update-sf-dmg-area-big-fb
+ * Description: Test that selective fetch works on primary plane with big fb
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Tests to varify PSR2 selective fetch by sending multiple"
 		     " damaged areas");
-- 
2.40.0

[igt-dev] [V5 i-g-t 28/81] tests/i915/kms_psr2_su: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_psr2_su.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/tests/i915/kms_psr2_su.c b/tests/i915/kms_psr2_su.c
index 3081887ca..6da283643 100644
--- a/tests/i915/kms_psr2_su.c
+++ b/tests/i915/kms_psr2_su.c
@@ -30,6 +30,33 @@
 #include <stdio.h>
 #include <string.h>
 #include <sys/timerfd.h>
+/**
+ * TEST: kms psr2 su
+ * Category: Display
+ * Description: Test PSR2 selective update
+ *
+ * SUBTEST: frontbuffer-XRGB8888
+ * Description: Test that selective update works when screen changes
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: page_flip-%s
+ * Description: Test the selective update with %arg[1] when screen changes
+ * Driver requirement: any
+ * Functionality: psr2
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @NV12:        NV12 format
+ * @P010:        P010 format
+ * @XRGB8888:    XRGB8888 format
+ */
 
 IGT_TEST_DESCRIPTION("Test PSR2 selective update");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 29/81] tests/i915/kms_psr_stress_test: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_psr_stress_test.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tests/i915/kms_psr_stress_test.c b/tests/i915/kms_psr_stress_test.c
index 23dcb4077..356d3cea0 100644
--- a/tests/i915/kms_psr_stress_test.c
+++ b/tests/i915/kms_psr_stress_test.c
@@ -7,6 +7,28 @@
 #include <stdio.h>
 #include <string.h>
 #include <sys/timerfd.h>
+/**
+ * TEST: kms psr stress test
+ * Category: Display
+ *
+ * SUBTEST: flip-primary-invalidate-overlay
+ * Description: Mix page flips in primary plane and frontbuffer writes to overlay
+ *              plane and check for warnings, underruns or PSR state changes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalidate-primary-flip-overlay
+ * Description: Mix frontbuffer writes to the primary plane and page flips in the
+ *              overlay plane and check for warnings, underruns or PSR state changes
+ * Driver requirement: any
+ * Functionality: psr
+ * Mega feature: PSR
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 #define INVALIDATES_PER_SEC 15
 #define FLIPS_PER_SEC 30
-- 
2.40.0

[igt-dev] [V5 i-g-t 30/81] tests/i915/kms_pwrite_crc: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_pwrite_crc.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tests/i915/kms_pwrite_crc.c b/tests/i915/kms_pwrite_crc.c
index 7bddeecba..38f466bae 100644
--- a/tests/i915/kms_pwrite_crc.c
+++ b/tests/i915/kms_pwrite_crc.c
@@ -29,6 +29,21 @@
 #include <stdio.h>
 #include <string.h>
 
+/**
+ * TEST: kms pwrite crc
+ * Category: Display
+ * Description: Use the display CRC support to validate pwrite to an already
+ *              uncached future scanout buffer.
+ *
+ * SUBTEST:
+ * Description: Use the display CRC support to validate pwrite to an already
+ *              uncached future scanout buffer.
+ * Driver requirement: i915
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION(
    "Use the display CRC support to validate pwrite to an already uncached future scanout buffer.");
-- 
2.40.0

[igt-dev] [V5 i-g-t 31/81] tests/kms_3d: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_3d.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/kms_3d.c b/tests/kms_3d.c
index c7a9d42d2..df0b54b37 100644
--- a/tests/kms_3d.c
+++ b/tests/kms_3d.c
@@ -24,6 +24,19 @@
 
 #include "igt.h"
 #include "xe/xe_query.h"
+/**
+ * TEST: kms 3d
+ * Category: Display
+ * Description: Tests 3D mode setting.
+ *
+ * SUBTEST:
+ * Description: Tests 3D mode setting.
+ * Driver requirement: any
+ * Functionality: stereoscopic
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Tests 3D mode setting.");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 32/81] tests/kms_addfb_basic: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_addfb_basic.c | 188 ++++++++++++++++++++++++++++++++--------
 1 file changed, 152 insertions(+), 36 deletions(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 065f21975..114b9c0f8 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -26,8 +26,9 @@
  */
 
 /**
- * TEST: Sanity test for ioctls DRM_IOCTL_MODE_ADDFB2 & DRM_IOCTL_MODE_RMFB.
+ * TEST: kms addfb basic
  * Category: Display
+ * Description: Sanity test for ioctls DRM_IOCTL_MODE_ADDFB2 & DRM_IOCTL_MODE_RMFB.
  */
 
 #include "igt.h"
@@ -66,33 +67,45 @@ static int legacy_addfb(int fd, struct drm_mode_fb_cmd *arg)
 }
 
 /**
- * SUBTEST: unused-handle
- * Description: Test that addfb2 call fails correctly for unused handle
+ * SUBTEST: unused-%s
+ * Description: Test that addfb2 call fails correctly for unused %arg[1]
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
  * Mega feature: General Display Features
  *
- * SUBTEST: unused-pitches
- * Description: Test that addfb2 call fails correctly for unused pitches
- * Test category: functionality test
- * Run type: BAT
- * Functionality: kms_gem_interop
+ * SUBTEST: clobberred-modifier
+ * Description: Check if addfb2 call works for clobbered modifier
+ * Driver requirement: i915
+ * Functionality: gtt, kms_gem_interop
  * Mega feature: General Display Features
- *
- * SUBTEST: unused-offsets
- * Description: Test that addfb2 call fails correctly for unused offset
+ * Run type: FULL
  * Test category: functionality test
- * Run type: BAT
+ *
+ * SUBTEST: invalid-smem-bo-on-discrete
+ * Description: Check if addfb2 with a system memory gem object fails correctly
+ *              if device requires local memory framebuffers
+ * Driver requirement: any
  * Functionality: kms_gem_interop
  * Mega feature: General Display Features
- *
- * SUBTEST: unused-modifier
- * Description: Test that addfb2 call fails correctly for unused modifier
+ * Run type: FULL
  * Test category: functionality test
- * Run type: BAT
+ *
+ * SUBTEST: legacy-format
+ * Description: Check if addfb2 call works for legacy formats
+ * Driver requirement: any
  * Functionality: kms_gem_interop
  * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @handle:       Handle
+ * @pitches:      Pitches
+ * @offsets:      Offsets
+ * @modifier:     Modifiers
  */
 static void invalid_tests(int fd)
 {
@@ -310,6 +323,7 @@ static void invalid_tests(int fd)
 /**
  * SUBTEST: no-handle
  * Description: Test that addfb2 call fails correctly without handle
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -317,6 +331,7 @@ static void invalid_tests(int fd)
  *
  * SUBTEST: basic
  * Description: Check if addfb2 call works with given handle
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -324,6 +339,7 @@ static void invalid_tests(int fd)
  *
  * SUBTEST: bad-pitch-%i
  * Description: bad-pitch-%arg[1]: Test that addfb2 call fails correctly for bad-pitches
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -378,6 +394,36 @@ static void pitch_tests(int fd)
 		gem_close(fd, gem_bo);
 }
 
+/**
+ * SUBTEST: basic-%s-tiled-legacy
+ * Description: Check if addfb2 and rmfb call works for basic %arg[1] test
+ * Driver requirement: any
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ *
+ * SUBTEST: framebuffer-vs-set-tiling
+ * Description: Check if addfb2 call works for x and y tiling
+ * Driver requirement: i915
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ *
+ * SUBTEST: tile-pitch-mismatch
+ * Description: Test that addfb2 call fails correctly for pitches mismatch
+ * Driver requirement: i915
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ *
+ * arg[1]:
+ *
+ * @x:        x-tiling
+ * @y:        y-tiling
+ */
 static void tiling_tests(int fd)
 {
 	struct drm_mode_fb_cmd2 f = {};
@@ -460,6 +506,7 @@ static void tiling_tests(int fd)
 /**
  * SUBTEST: size-max
  * Description: Check if addfb2 call works with max size of buffer object
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -467,6 +514,7 @@ static void tiling_tests(int fd)
  *
  * SUBTEST: too-wide
  * Description: Test that addfb2 call fails correctly with increased width of fb
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -474,6 +522,7 @@ static void tiling_tests(int fd)
  *
  * SUBTEST: too-high
  * Description: Test that addfb2 call fails correctly with increased height of fb
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -481,6 +530,7 @@ static void tiling_tests(int fd)
  *
  * SUBTEST: bo-too-small
  * Description: Test that addfb2 call fails correctly with small size of buffer object
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -488,10 +538,20 @@ static void tiling_tests(int fd)
  *
  * SUBTEST: small-bo
  * Description: Check if addfb2 call works for given height
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
  * Mega feature: General Display Features
+ *
+ * SUBTEST: bo-too-small-due-to-tiling
+ * Description: Test that addfb2 call fails correctly with small buffer object
+ *              after changing tile
+ * Driver requirement: any
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
  */
 static void size_tests(int fd)
 {
@@ -611,6 +671,7 @@ static void size_tests(int fd)
 /**
  * SUBTEST: addfb25-modifier-no-flag
  * Description: Test that addfb2 call fails correctly for x-tiling with given modifier
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
@@ -618,10 +679,35 @@ static void size_tests(int fd)
  *
  * SUBTEST: addfb25-bad-modifier
  * Description: Test that addfb2 call fails correctly for irrelevant modifier
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
  * Mega feature: General Display Features
+ *
+ * SUBTEST: addfb25-x-tiled-mismatch-legacy
+ * Description: Test that addfb2 call fails correctly for irrelevant x-tiling
+ * Driver requirement: any
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ *
+ * SUBTEST: addfb25-x-tiled-legacy
+ * Description: Check if addfb2 call works for x-tiling
+ * Driver requirement: any
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ *
+ * SUBTEST: addfb25-framebuffer-vs-set-tiling
+ * Description: Check if addfb2 call works for relevant combination of tiling and fbs
+ * Driver requirement: any
+ * Test category: functionality test
+ * Run type: FULL
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
  */
 static void addfb25_tests(int fd)
 {
@@ -705,6 +791,28 @@ static int addfb_expected_ret(igt_display_t *disp, struct drm_mode_fb_cmd2 *f)
 					  f->modifier[0]) ? 0 : -1;
 }
 
+/**
+ * SUBTEST: addfb25-y-tiled-%s
+ * Description: Check if addfb2 call works for y-tiling %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: addfb25-yf-tiled-legacy
+ * Description: Check if addfb2 call works for yf-tiling
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @legacy:               with default size
+ * @small-legacy:         with given size & modifier
+ */
 static void addfb25_ytile(int fd)
 {
 	struct drm_mode_fb_cmd2 f = {};
@@ -771,6 +879,15 @@ static void addfb25_ytile(int fd)
 	}
 }
 
+/**
+ * SUBTEST: addfb25-4-tiled
+ * Description: Check if addfb2 call works for tiling-4
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void addfb25_4tile(int fd)
 {
 	struct drm_mode_fb_cmd2 f = {};
@@ -810,33 +927,23 @@ static void addfb25_4tile(int fd)
 }
 
 /**
- * SUBTEST: invalid-get-prop-any
- * Description: Test that get-properties ioctl call fails correctly for invalid object type
+ * SUBTEST: invalid-%s-%s
+ * Description: Test that %arg[1] ioctl call fails correctly for %arg[2] object
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_gem_interop
  * Mega feature: General Display Features
  *
- * SUBTEST: invalid-get-prop
- * Description: Test that get-properties ioctl call fails correctly for fb mode object
- * Test category: functionality test
- * Run type: BAT
- * Functionality: kms_gem_interop
- * Mega feature: General Display Features
+ * arg[1]:
  *
- * SUBTEST: invalid-set-prop-any
- * Description: Test that set-properties ioctl call fails correctly for invalid object type
- * Test category: functionality test
- * Run type: BAT
- * Functionality: kms_gem_interop
- * Mega feature: General Display Features
+ * @get:           get-properties
+ * @set:           set-properties
  *
- * SUBTEST: invalid-set-prop
- * Description: Test that get-properties ioctl call fails correctly for fb mode object
- * Test category: functionality test
- * Run type: BAT
- * Functionality: kms_gem_interop
- * Mega feature: General Display Features
+ * arg[2]:
+ *
+ * @prop:          fb mode
+ * @prop-any:      invalid
  */
 static void prop_tests(int fd)
 {
@@ -903,6 +1010,15 @@ static void prop_tests(int fd)
 	}
 }
 
+/**
+ * SUBTEST: master-rmfb
+ * Description: Check that only master can rmfb
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void master_tests(int fd)
 {
 	struct drm_mode_fb_cmd2 f = {};
-- 
2.40.0

[igt-dev] [V5 i-g-t 33/81] tests/kms_async_flips: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_async_flips.c | 62 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 0a1199158..73021e800 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -25,6 +25,11 @@
  *  Karthik B S <karthik.b.s@intel.com>
  */
 
+/**
+ * TEST: kms async flips
+ * Category: Display
+ * Description: Test asynchronous page flips.
+ */
 #include "igt.h"
 #include "igt_aux.h"
 #include "igt_psr.h"
@@ -197,6 +202,25 @@ static void test_init_fbs(data_t *data)
 	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 }
 
+/**
+ * SUBTEST: alternate-sync-async-flip
+ * Description: Verify the async flip functionality and the fps during async flips
+ *              Alternate between sync and async flips
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: async-flip-with-page-flip-events
+ * Description: Verify the async flip functionality and the fps during async flips
+ *              Wait for page flip events in between successive asynchronous flips
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_async_flip(data_t *data)
 {
 	int ret, frame;
@@ -292,6 +316,17 @@ static void wait_for_vblank(data_t *data, unsigned long *vbl_time, unsigned int
 	*seq = wait_vbl.reply.sequence;
 }
 
+/**
+ * SUBTEST: test-time-stamp
+ * Description: Verify the async flip functionality and the fps during async flips
+ *              Verify that the async flip timestamp does not coincide with either
+ *              previous or next vblank
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_timestamp(data_t *data)
 {
 	int flags = DRM_MODE_PAGE_FLIP_ASYNC | DRM_MODE_PAGE_FLIP_EVENT;
@@ -336,6 +371,15 @@ static void test_timestamp(data_t *data)
 		     "Async flip time stamp is expected to be in between 2 vblank time stamps\n");
 }
 
+/**
+ * SUBTEST: test-cursor
+ * Description: Verify that the DRM_IOCTL_MODE_CURSOR passes after async flip
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_cursor(data_t *data)
 {
 	int flags = DRM_MODE_PAGE_FLIP_ASYNC | DRM_MODE_PAGE_FLIP_EVENT;
@@ -488,6 +532,15 @@ static unsigned int clock_ms(void)
 	return ts.tv_sec * 1000 + ts.tv_nsec / 1000000;
 }
 
+/**
+ * SUBTEST: crc
+ * Description: Use CRC to verify async flip scans out the correct framebuffer
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_crc(data_t *data)
 {
 	unsigned int frame = 0;
@@ -550,6 +603,15 @@ static void test_crc(data_t *data)
 	igt_assert_lt(data->frame_count * 2, data->flip_count);
 }
 
+/**
+ * SUBTEST: invalid-async-flip
+ * Description: Negative case to verify if changes in fb are rejected from kernel as expected
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void run_test(data_t *data, void (*test)(data_t *))
 {
 	igt_display_t *display = &data->display;
-- 
2.40.0

[igt-dev] [V5 i-g-t 34/81] tests/kms_atomic: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_atomic.c | 102 ++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 100 insertions(+), 2 deletions(-)

diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index b65045abc..f07d47abc 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -27,8 +27,10 @@
  *    Pekka Paalanen <pekka.paalanen@collabora.co.uk>
  */
 
-/*
- * Testcase: testing atomic modesetting API
+/**
+ * TEST: kms atomic
+ * Category: Display
+ * Description: Test atomic modesetting API
  */
 
 #include <unistd.h>
@@ -287,6 +289,16 @@ static uint32_t plane_get_igt_format(igt_plane_t *plane)
 	return 0;
 }
 
+/**
+ * SUBTEST: plane-primary-overlay-mutable-zpos
+ * Description: Verify that the overlay plane can cover the primary one (and
+ *              vice versa) by changing their zpos property.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void
 plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
 				   igt_plane_t *primary, igt_plane_t *overlay,
@@ -369,6 +381,16 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
 	igt_assert_eq_u64(igt_plane_get_prop(overlay, IGT_PLANE_ZPOS), 1);
 }
 
+/**
+ * SUBTEST: plane-immutable-zpos
+ * Description: Verify the reported zpos property of planes by making sure only
+ *              higher zpos planes cover the lower zpos ones.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void
 plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
 		     igt_output_t *output)
@@ -505,6 +527,22 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
 	igt_remove_fb(display->drm_fd, &fb_upper);
 }
 
+/**
+ * SUBTEST: plane-%s-legacy
+ * Description: Test for KMS atomic modesetting on %arg[1] and ensure coherency
+ *              between legacy and atomic interfaces.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:         Cursor plane
+ * @overlay:        Overlay plane
+ * @primary:        Primary plane
+ */
 static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *plane)
 {
 	drmModeModeInfo *mode = igt_output_get_mode(output);
@@ -579,6 +617,17 @@ static void plane_primary(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *f
 	plane_commit(plane, COMMIT_UNIVERSAL, ATOMIC_RELAX_NONE);
 }
 
+/**
+ * SUBTEST: test-only
+ * Description: Test to ensure that DRM_MODE_ATOMIC_TEST_ONLY really only touches
+ *              the free-standing state objects and nothing else.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 /* test to ensure that DRM_MODE_ATOMIC_TEST_ONLY really only touches the
  * free-standing state objects and nothing else.
  */
@@ -687,6 +736,20 @@ static void plane_cursor(igt_pipe_t *pipe_obj,
 	plane_commit(cursor, COMMIT_LEGACY, ATOMIC_RELAX_NONE);
 }
 
+/**
+ * SUBTEST: plane-invalid-%s
+ * Description: Test error handling when invalid %arg[1] are passed
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @params:           plane parameters
+ * @params-fence:     plane fence parameters
+ */
 static void plane_invalid_params(igt_pipe_t *pipe,
 				 igt_output_t *output,
 				 igt_plane_t *plane,
@@ -776,6 +839,20 @@ static void plane_invalid_params_fence(igt_pipe_t *pipe,
 	close(timeline);
 }
 
+/**
+ * SUBTEST: crtc-invalid-%s
+ * Description: Test error handling when invalid %arg[1] are passed
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @params:           crtc parameters
+ * @params-fence:     crtc fence parameters
+ */
 static void crtc_invalid_params(igt_pipe_t *pipe,
 				igt_output_t *output,
 				igt_plane_t *plane,
@@ -923,6 +1000,18 @@ static void crtc_invalid_params_fence(igt_pipe_t *pipe,
 	igt_assert(pipe->out_fence_fd != -1);
 }
 
+/**
+ * SUBTEST: atomic-invalid-params
+ * Description: Test abuse the atomic ioctl directly in order to test various
+ *              invalid conditions which the libdrm wrapper won't allow us to
+ *              create.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 /* Abuse the atomic ioctl directly in order to test various invalid conditions,
  * which the libdrm wrapper won't allow us to create. */
 static void atomic_invalid_params(igt_pipe_t *pipe,
@@ -1064,6 +1153,15 @@ static void atomic_invalid_params(igt_pipe_t *pipe,
 	do_ioctl_err(display->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);
 }
 
+/**
+ * SUBTEST: atomic_plane_damage
+ * Description: Simple test cases to use FB_DAMAGE_CLIPS plane property
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *fb)
 {
 	struct drm_mode_rect damage[2];
-- 
2.40.0

[igt-dev] [V5 i-g-t 35/81] tests/kms_atomic_interruptible: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_atomic_interruptible.c | 50 ++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
index 2acdcb29d..10bfa6c1b 100644
--- a/tests/kms_atomic_interruptible.c
+++ b/tests/kms_atomic_interruptible.c
@@ -21,6 +21,11 @@
  * IN THE SOFTWARE.
  */
 
+/**
+ * TEST: kms atomic interruptible
+ * Category: Display
+ * Description: Tests that interrupt various atomic ioctls.
+ */
 #include <signal.h>
 
 #include "igt.h"
@@ -74,6 +79,51 @@ static drmEventContext drm_events = {
 	.page_flip_handler = ev_page_flip
 };
 
+/**
+ * SUBTEST: %s-setmode
+ * Description: Tests the interrupt properties of %arg[1] modeset
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @atomic:      atomic
+ * @legacy:      legacy
+ */
+
+/**
+ * SUBTEST: legacy-%s
+ * Description: Tests the interrupt properties for %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:         Cursor
+ * @dpms:           DPMS
+ * @pageflip:       Page flip
+ */
+
+/**
+ * SUBTEST: universal-setplane-%s
+ * Description: Tests the interrupt properties for %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor:         Cursor plane
+ * @primary:        Primary plane
+ */
 static void run_plane_test(igt_display_t *display, enum pipe pipe, igt_output_t *output,
 			   enum plane_test_type test_type, unsigned plane_type)
 {
-- 
2.40.0

[igt-dev] [V5 i-g-t 36/81] tests/kms_atomic_transition: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_atomic_transition.c | 100 ++++++++++++++++++++++++++++++++++
 1 file changed, 100 insertions(+)

diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 6ab5267ca..196736df2 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -21,6 +21,10 @@
  * IN THE SOFTWARE.
  */
 
+/**
+ * TEST: kms atomic transition
+ * Category: Display
+ */
 #include "igt.h"
 #include "igt_rand.h"
 #include "drmtest.h"
@@ -58,6 +62,15 @@ int *timeline;
 pthread_t *thread;
 int *seqno;
 
+/**
+ * SUBTEST: plane-primary-toggle-with-vblank-wait
+ * Description: Check toggling of primary plane with vblank
+ * Driver requirement: any
+ * Functionality: watermark
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void
 run_primary_test(data_t *data, enum pipe pipe, igt_output_t *output)
 {
@@ -470,6 +483,77 @@ static void wait_for_transition(data_t *data, enum pipe pipe, bool nonblocking,
 	}
 }
 
+/**
+ * SUBTEST: plane-all-modeset-%s
+ * Description: Modeset test for all plane combinations %arg[1]
+ * Driver requirement: any
+ * Functionality: watermark
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @transition:                           default
+ * @transition-fencing:                   with fencing commit
+ */
+
+/**
+ * SUBTEST: plane-all-modeset-%s
+ * Description: Modeset test for all plane combinations %arg[1]
+ * Driver requirement: any
+ * Functionality: watermark
+ * Mega feature: eDP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @transition-fencing-internal-panels:   on internal panels with fencing commit
+ * @transition-internal-panels:           on internal panels
+ */
+
+/**
+ * SUBTEST: plane-all-%s
+ * Description: Transition test for all plane combinations %arg[1]
+ * Driver requirement: any
+ * Functionality: watermark
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @transition:                           default
+ * @transition-fencing:                   with fencing commit
+ * @transition-nonblocking:               with non-blocking commit
+ * @transition-nonblocking-fencing:       with non-blocking & fencing commit
+ */
+
+/**
+ * SUBTEST: plane-toggle-modeset-transition
+ * Description: Check toggling and modeset transition on plane
+ * Driver requirement: any
+ * Functionality: watermark
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-use-after-nonblocking-%s
+ * Description: Transition test with non %arg[1] and make sure commit of disabled
+ *              plane has to complete before atomic commit on that plane
+ * Driver requirement: any
+ * Functionality: watermark
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @unbind:           blocking commit
+ * @unbind-fencing:   blocking commit with fencing
+ */
+
 /*
  * 1. Set primary plane to a known fb.
  * 2. Make sure getcrtc returns the correct fb id.
@@ -959,6 +1043,22 @@ retry:
 	}
 }
 
+/**
+ * SUBTEST: modeset-%s
+ * Description: Modeset transition tests for combinations of %arg[1]
+ * Driver requirement: any
+ * Functionality: watermark
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @transition:                     crtc enabled
+ * @transition-fencing:             crtc enabled with fencing commit
+ * @transition-nonblocking:         crtc enabled with nonblocking commit
+ * @transition-nonblocking-fencing: crtc enabled with nonblocking & fencing commit
+ */
 static void run_modeset_transition(data_t *data, int requested_outputs, bool nonblocking, bool fencing)
 {
 	igt_output_t *outputs[IGT_MAX_PIPES] = {};
-- 
2.40.0

[igt-dev] [V5 i-g-t 37/81] tests/kms_bw: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_bw.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tests/kms_bw.c b/tests/kms_bw.c
index b66473e60..331be5755 100644
--- a/tests/kms_bw.c
+++ b/tests/kms_bw.c
@@ -25,6 +25,26 @@
 #include "drm.h"
 #include <stdio.h>
 #include <xf86drmMode.h>
+/**
+ * TEST: kms bw
+ * Category: Display
+ *
+ * SUBTEST: linear-tiling-%d-displays-%s
+ * Description: bw test with %arg[2]
+ * Driver requirement: any
+ * Functionality: obsolete
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1].values: 1, 2, 3, 4, 5, 6, 7, 8
+ *
+ * arg[2]:
+ *
+ * @1920x1080p:       1920x1080 resolution
+ * @2560x1440p:       2560x1440 resolution
+ * @3840x2160p:       3840x2160 resolution
+ */
 
 /* Common test data. */
 typedef struct data {
-- 
2.40.0

[igt-dev] [V5 i-g-t 38/81] tests/kms_color: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Include ctm-signed test

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_color.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 91 insertions(+)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index b15b9572c..3c837d258 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -22,10 +22,24 @@
  *
  */
 
+/**
+ * TEST: kms color
+ * Category: Display
+ * Description: Test Color Features at Pipe level
+ */
 #include "kms_color_helper.h"
 
 IGT_TEST_DESCRIPTION("Test Color Features at Pipe level");
 
+/**
+ * SUBTEST: degamma
+ * Description: Verify that degamma LUT transformation works correctly
+ * Driver requirement: any
+ * Functionality: colorspace
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static bool test_pipe_degamma(data_t *data,
 			      igt_plane_t *primary)
 {
@@ -114,6 +128,16 @@ static bool test_pipe_degamma(data_t *data,
 	return ret;
 }
 
+/**
+ * SUBTEST: gamma
+ * Description: Verify that gamma LUT transformation works correctly
+ * Driver requirement: any
+ * Functionality: colorspace, colorspace_gamma
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 /*
  * Draw 3 gradient rectangles in red, green and blue, with a maxed out gamma
  * LUT and verify we have the same CRC as drawing solid color rectangles.
@@ -202,6 +226,16 @@ static bool test_pipe_gamma(data_t *data,
 	return ret;
 }
 
+/**
+ * SUBTEST: legacy-gamma
+ * Description: Verify that legacy gamma LUT transformation works correctly
+ * Driver requirement: any
+ * Functionality: colorspace, colorspace_gamma
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 /*
  * Draw 3 gradient rectangles in red, green and blue, with a maxed out legacy
  * gamma LUT and verify we have the same CRC as drawing solid color rectangles
@@ -314,6 +348,17 @@ static bool test_pipe_legacy_gamma(data_t *data,
 	return ret;
 }
 
+/**
+ * SUBTEST: legacy-gamma-reset
+ * Description: Verify that setting the legacy gamma LUT resets the gamma LUT
+ *              set through GAMMA_LUT property
+ * Driver requirement: any
+ * Functionality: colorspace, colorspace_gamma
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 /*
  * Verify that setting the legacy gamma LUT resets the gamma LUT set
  * through the GAMMA_LUT property.
@@ -448,6 +493,28 @@ end:
 	return ret;
 }
 
+/**
+ * SUBTEST: ctm-%s
+ * Description: Check the color transformation %arg[1]
+ * Driver requirement: any
+ * Functionality: colorspace
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @0-25:           for 0.25 transparency
+ * @0-50:           for 0.50 transparency
+ * @0-75:           for 0.75 transparency
+ * @blue-to-red:    from blue to red
+ * @green-to-red:   from green to red
+ * @max:            for maximum transparency
+ * @negative:       for negative transparency
+ * @red-to-blue:    from red to blue
+ * @signed:         for correct signed handling
+ */
+
 /*
  * Draw 3 rectangles using before colors with the ctm matrix apply and verify
  * the CRC is equal to using after colors with an identify ctm matrix.
@@ -807,6 +874,15 @@ out:
 	test_cleanup(data);
 }
 
+/**
+ * SUBTEST: deep-color
+ * Description: Verify that deep color works correctly
+ * Driver requirement: any
+ * Functionality: colorspace
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void
 run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
 {
@@ -899,6 +975,21 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
 	test_cleanup(data);
 }
 
+/**
+ * SUBTEST: invalid-%s-sizes
+ * Description: Negative check for %arg[1] sizes
+ * Driver requirement: any
+ * Functionality: colorspace
+ * Mega feature: Color mgmt
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @ctm-matrix:         Color transformation matrix
+ * @degamma-lut:        Degamma LUT
+ * @gamma-lut:          Gamma LUT
+ */
 static void
 run_invalid_tests_for_pipe(data_t *data)
 {
-- 
2.40.0

[igt-dev] [V5 i-g-t 39/81] tests/kms_concurrent: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_concurrent.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d915a98b2..f5fe321a2 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -24,6 +24,32 @@
 
 #include "igt.h"
 #include "drmtest.h"
+/**
+ * TEST: kms concurrent
+ * Category: Display
+ * Description: Test atomic mode setting concurrently with multiple planes and
+ *              screen resolution
+ *
+ * SUBTEST: pipe-%s
+ * Description: Test atomic mode setting concurrently with multiple planes and
+ *              screen resolution on %arg[1].
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @A:      pipe A
+ * @B:      pipe B
+ * @C:      pipe C
+ * @D:      pipe D
+ * @E:      pipe E
+ * @F:      pipe F
+ * @G:      pipe G
+ * @H:      pipe H
+ */
 
 IGT_TEST_DESCRIPTION("Test atomic mode setting concurrently with multiple planes and screen resolution");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 40/81] tests/kms_content_protection: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_content_protection.c | 81 ++++++++++++++++++++++++++++++++++
 1 file changed, 81 insertions(+)

diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
index 6cdf81a28..50929d8d5 100644
--- a/tests/kms_content_protection.c
+++ b/tests/kms_content_protection.c
@@ -22,6 +22,11 @@
  *
  */
 
+/**
+ * TEST: kms content protection
+ * Category: Display
+ * Description: Test content protection (HDCP)
+ */
 #include <poll.h>
 #include <fcntl.h>
 #include <sys/epoll.h>
@@ -485,6 +490,66 @@ test_fini(igt_output_t *output, enum igt_commit_style s)
 	igt_display_commit2(&data.display, s);
 }
 
+/**
+ * SUBTEST: LIC
+ * Description: Test for the integrity of link.
+ * Driver requirement: any
+ * Functionality: hdcp
+ * Mega feature: HDCP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: content_type_change
+ * Description: Test the content type change when the content protection already
+ *              enabled
+ * Driver requirement: any
+ * Functionality: hdcp, hdcp2.2
+ * Mega feature: HDCP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: mei_interface
+ * Description: Test the teardown and rebuild of the interface between Intel
+ *              and mei hdcp.
+ * Driver requirement: any
+ * Functionality: hdcp, hdcp2.2
+ * Mega feature: HDCP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: srm
+ * Description: This test writes the facsimile SRM into the /lib/firmware/ and
+ *              check the kernel parsing of it by invoking the hdcp authentication.
+ * Driver requirement: any
+ * Functionality: hdcp
+ * Mega feature: HDCP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: uevent
+ * Description: Test to detect the HDCP status change when we are reading the
+ *              uevent sent with the corresponding connector id and property id.
+ * Driver requirement: any
+ * Functionality: hdcp
+ * Mega feature: HDCP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: %s
+ * Description: Test content protection with %arg[1]
+ * Driver requirement: any
+ * Functionality: hdcp
+ * Mega feature: HDCP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @atomic:         atomic modesetting
+ * @atomic-dpms:    DPMS ON/OFF during atomic modesetting.
+ * @legacy:         legacy style commit
+ * @type1:          content type 1 that can be handled only through HDCP2.2.
+ */
 static void
 test_content_protection(enum igt_commit_style s, int content_type)
 {
@@ -602,6 +667,22 @@ static void test_cp_lic_on_mst(igt_output_t *mst_outputs[], int valid_outputs, b
 	}
 }
 
+/**
+ * SUBTEST: dp-mst-%s
+ * Description: Test Content protection %arg[1] over DP MST.
+ * Driver requirement: any
+ * Functionality: hdcp
+ * Mega feature: HDCP
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @lic-type-0:   Type 0 with LIC
+ * @lic-type-1:   Type 1 with LIC.
+ * @type-0:       Type 0
+ * @type-1:       Type 1
+ */
 static void
 test_content_protection_mst(int content_type)
 {
-- 
2.40.0

[igt-dev] [V5 i-g-t 41/81] tests/kms_cursor_crc: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_cursor_crc.c | 65 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 0506fd6f1..d91376fa4 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -29,6 +29,19 @@
 #include <stdio.h>
 #include <string.h>
 
+/**
+ * TEST: kms cursor crc
+ * Category: Display
+ * Description: Use the display CRC support to validate cursor plane functionality.
+ *              The test will position the cursor plane either fully onscreen,
+ *              partially onscreen, or fully offscreen, using either a fully
+ *              opaque or fully transparent surface. In each case, it enables
+ *              the cursor plane and then reads the PF CRC (hardware test) and
+ *              compares it with the CRC value obtained when the cursor plane
+ *              was disabled and its drawing is directly inserted on the PF by
+ *              software.
+ */
+
 IGT_TEST_DESCRIPTION(
    "Use the display CRC support to validate cursor plane functionality. "
    "The test will position the cursor plane either fully onscreen, "
@@ -641,6 +654,27 @@ static bool require_cursor_size(data_t *data, int w, int h)
 	return !!ret;
 }
 
+/**
+ * SUBTEST: cursor-%s
+ * Description: %arg[1]
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @alpha-opaque:       Validates the composition of a fully opaque cursor plane,
+ *                      i.e., alpha channel equal to 1.0.
+ * @alpha-transparent:  Validates the composition of a fully transparent cursor
+ *                      plane, i.e., alpha channel equal to 0.0.
+ * @dpms:               Check random placement of a cursor with DPMS.
+ * @size-change:        Create a maximum size cursor, then change the size in
+ *                      flight to smaller ones to see that the size is applied
+ *                      correctly.
+ * @suspend:            Check random placement of a cursor with suspend.
+ */
 static void run_test(data_t *data, void (*testfunc)(data_t *), int cursor_w, int cursor_h)
 {
 	prepare_crtc(data, cursor_w, cursor_h);
@@ -738,6 +772,37 @@ static bool execution_constraint(enum pipe pipe)
 }
 
 
+/**
+ * SUBTEST: cursor-%s-%s
+ * Description: Check if a %arg[2] cursor is %arg[1].
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @offscreen:             well-positioned outside the screen
+ * @onscreen:              well-positioned inside the screen
+ * @random:                randomly placed
+ * @rapid-movement:        rapidly udates for movements
+ * @sliding:               smooth for horizontal, vertical & diagonal movements
+ *
+ * arg[2]:
+ *
+ * @128x128:               128x128 size
+ * @128x42:                128x42 size
+ * @256x256:               256x256 size
+ * @256x85:                256x85 size
+ * @32x10:                 32x10 size
+ * @32x32:                 32x32 size
+ * @512x170:               512x170 size
+ * @512x512:               512x512 size
+ * @64x21:                 64x21 size
+ * @64x64:                 64x64 size
+ * @max-size:              Max supported size
+ */
 static void run_size_tests(data_t *data, int w, int h)
 {
 	enum pipe pipe;
-- 
2.40.0

[igt-dev] [V5 i-g-t 42/81] tests/kms_cursor_edge_walk: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_cursor_edge_walk.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
index 462b51e20..9010aa0f7 100644
--- a/tests/kms_cursor_edge_walk.c
+++ b/tests/kms_cursor_edge_walk.c
@@ -28,6 +28,32 @@
 #include <stdbool.h>
 #include <stdio.h>
 #include <string.h>
+/**
+ * TEST: kms cursor edge walk
+ * Category: Display
+ * Description: Exercise CHV pipe C cursor fail
+ *
+ * SUBTEST: %s-%s
+ * Description: Checking cursor size %arg[1] by walking %arg[2] of screen
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @128x128:          128x128
+ * @256x256:          256x256
+ * @64x64:            64x64
+ *
+ * arg[2]:
+ *
+ * @left-edge:        Left edge
+ * @right-edge:       Right edge
+ * @top-bottom:       Top to bottom
+ * @top-edge:         Top edge
+ */
 
 IGT_TEST_DESCRIPTION("Exercise CHV pipe C cursor fail");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 43/81] tests/kms_cursor_legacy: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_cursor_legacy.c | 217 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 216 insertions(+), 1 deletion(-)

diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 06dea27d6..c09dff8d9 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -23,8 +23,9 @@
  */
 
 /**
- * TEST: Stress legacy cursor ioctl
+ * TEST: kms cursor legacy
  * Category: Display
+ * Description: Stress legacy cursor ioctl
  */
 
 #include <sched.h>
@@ -77,6 +78,28 @@ static void override_output_modes(igt_display_t *display,
 	igt_output_set_pipe(output2, PIPE_NONE);
 }
 
+/**
+ * SUBTEST: %s-%s
+ * Description: Test checks how many cursor updates we can fit between vblanks
+ *              on single/all pipes with different modes, priority and number
+ *              of processes
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @single:      Single
+ * @torture:     Torture
+ * @forked:      Forked
+ *
+ * arg[2]:
+ *
+ * @bo:          BO
+ * @move:        Move
+ */
 static void stress(igt_display_t *display,
 		   enum pipe pipe, int num_children, unsigned mode,
 		   int timeout)
@@ -544,11 +567,20 @@ enum basic_flip_cursor {
 /**
  * SUBTEST: basic-busy-flip-before-cursor-%s
  * Description: Cursor test with %arg[1] mode
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: cursor
  * Mega feature: General Display Features
  *
+ * SUBTEST: basic-busy-flip-before-cursor-varying-size
+ * Description: Change the size of cursor b/w 64*64 to maxw x maxh.
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
  * arg[1]:
  *
  * @atomic:	atomic
@@ -558,6 +590,7 @@ enum basic_flip_cursor {
 /**
  * SUBTEST: basic-flip-after-cursor-%s
  * Description: Cursor test with %arg[1]
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: cursor
@@ -565,6 +598,7 @@ enum basic_flip_cursor {
  *
  * SUBTEST: basic-flip-before-cursor-%s
  * Description: Cursor test with %arg[1]
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: cursor
@@ -576,6 +610,53 @@ enum basic_flip_cursor {
  * @legacy:        legacy mode
  * @varying-size:  varying size
  */
+
+/**
+ * SUBTEST: %s-flip-before-cursor-%s
+ * Description: Adds variety of tests:
+ *		- varying-size: change the size of cursor b/w 64*64 to maxw x maxh.\n
+ *		- atomic-transition: alternates between a full screen sprite plane
+ *		                     and full screen primary plane.\n"
+ *		- toggle: which toggles cursor visibility and make sure cursor moves
+ *		          between updates.
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @short:
+ * @short-busy:
+ *
+ * arg[2]:
+ *
+ * @atomic-transitions:
+ * @atomic-transitions-varying-size:
+ * @toggle:
+ */
+
+/**
+ * SUBTEST: short-flip-after-cursor-%s
+ * Description: Adds variety of tests:
+ *		- varying-size: change the size of cursor b/w 64*64 to maxw x maxh.\n
+ *		- atomic-transition: alternates between a full screen sprite plane
+ *		                     and full screen primary plane.\n"
+ *		- toggle: which toggles cursor visibility and make sure cursor moves
+ *		          between updates.
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @atomic-transitions:
+ * @atomic-transitions-varying-size:
+ * @toggle:
+ */
 static void basic_flip_cursor(igt_display_t *display,
 			      enum flip_test mode,
 			      enum basic_flip_cursor order,
@@ -897,6 +978,25 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloo
 		igt_remove_fb(display->drm_fd, &cursor_fb2);
 }
 
+/**
+ * SUBTEST: long-nonblocking-modeset-vs-cursor-atomic
+ * Description: Test checks how many cursor updates we can fit between vblanks
+ *              on all pipes with different modes, priority and number of processes
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: nonblocking-modeset-vs-cursor-atomic
+ * Description: Test checks how many cursor updates we can fit between vblanks
+ *              on all pipes with different modes, priority and number of processes
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops)
 {
 	struct igt_fb fb_info, cursor_fb;
@@ -996,6 +1096,44 @@ static void wait_for_modeset(igt_display_t *display, unsigned flags, int timeout
 	igt_reset_timeout();
 }
 
+/**
+ * SUBTEST: 2x-%s-%s
+ * Description: This test executes flips on both CRTCs while running cursor
+ *              updates in parallel
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @flip-vs-cursor:
+ * @flip-vs-cursor:
+ * @long-flip-vs-cursor:
+ * @long-flip-vs-cursor:
+ *
+ * arg[2]:
+ *
+ * @atomic:
+ * @legacy:
+ */
+
+/**
+ * SUBTEST: 2x-%s-atomic
+ * Description: This test executes flips on both CRTCs while running cursor
+ *              updates in parallel
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @long-nonblocking-modeset-vs-cursor:
+ * @nonblocking-modeset-vs-cursor:
+ */
 static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool modeset, bool atomic)
 {
 	struct drm_mode_cursor arg1[2], arg2[2];
@@ -1183,6 +1321,34 @@ done:
 	munmap((void *)shared, PAGE_SIZE);
 }
 
+/**
+ * SUBTEST: %s-%s
+ * Description: The essence of the basic test is that neither the cursor nor the
+ *              nonblocking flip stall the application of the next
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor-vs-flip:
+ * @cursorA-vs-flipA:
+ * @cursorA-vs-flipB:
+ * @cursorB-vs-flipA:
+ * @cursorB-vs-flipB:
+ * @flip-vs-cursor:
+ *
+ * arg[2]:
+ *
+ * @atomic:
+ * @atomic-transitions:
+ * @atomic-transitions-varying-size:
+ * @legacy:
+ * @toggle:
+ * @varying-size:
+ */
 static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloops)
 {
 	struct drm_mode_cursor arg[2];
@@ -1295,6 +1461,27 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
 		igt_remove_fb(display->drm_fd, &cursor_fb2);
 }
 
+/**
+ * SUBTEST: 2x-%s-%s
+ * Description: This test executes flips on both CRTCs while running cursor updates in parallel
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @cursor-vs-flip:
+ * @cursor-vs-flip:
+ * @long-cursor-vs-flip:
+ * @long-cursor-vs-flip:
+ *
+ * arg[2]:
+ *
+ * @atomic:
+ * @legacy:
+ */
 static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool atomic)
 {
 	struct drm_mode_cursor arg[2][2];
@@ -1423,6 +1610,20 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
 	munmap((void *)shared, PAGE_SIZE);
 }
 
+/**
+ * SUBTEST: flip-vs-cursor-crc-%s
+ * Description: this test perform a page flip followed by a cursor update
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @atomic:
+ * @legacy:
+ */
 static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
 {
 	struct drm_mode_cursor arg[2];
@@ -1495,6 +1696,20 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
 	igt_remove_fb(display->drm_fd, &cursor_fb);
 }
 
+/**
+ * SUBTEST: flip-vs-cursor-busy-crc-%s
+ * Description: this test perform a busy bo update followed by a cursor update
+ * Driver requirement: any
+ * Functionality: cursor
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @atomic:
+ * @legacy:
+ */
 static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
 {
 	struct drm_mode_cursor arg[2];
-- 
2.40.0

[igt-dev] [V5 i-g-t 44/81] tests/kms_display_modes: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Add missing documentation

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_display_modes.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index 93d91ef5b..b26a3f71a 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -24,6 +24,11 @@
  *  Jeevan B <jeevan.b@intel.com>
  */
 
+/**
+ * TEST: kms display modes
+ * Category: Display
+ * Description: Test Display Modes
+ */
 #include "igt.h"
 
 #define HDISPLAY_4K	3840
@@ -231,6 +236,16 @@ static void run_extendedmode_basic(data_t *data,
 	for_each_connected_output_local((display), (output)) \
 		for_each_if (igt_pipe_connector_valid((pipe), (output)))
 
+/**
+ * SUBTEST: extended-mode-basic
+ * Description: Test for validating display extended mode with a pair of connected
+ *              displays
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void run_extendedmode_test(data_t *data) {
 	enum pipe pipe1, pipe2;
 	igt_output_t *output1, *output2;
@@ -276,6 +291,16 @@ static void run_extendedmode_test(data_t *data) {
 	}
 }
 
+/**
+ * SUBTEST: mst-extended-mode-negative
+ * Description: Negative test for validating display extended mode with a pair
+ *		of connected 2k-4k or 4k-4k displays.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void run_extendedmode_negative(data_t *data, int pipe1, int pipe2)
 {
 	struct igt_fb fbs[2];
-- 
2.40.0

[igt-dev] [V5 i-g-t 45/81] tests/kms_dither: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_dither.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tests/kms_dither.c b/tests/kms_dither.c
index d6c16dd0b..79a002d46 100644
--- a/tests/kms_dither.c
+++ b/tests/kms_dither.c
@@ -25,6 +25,11 @@
  *
  */
 
+/**
+ * TEST: kms dither
+ * Category: Display
+ * Description: Test Dithering block status
+ */
 #include "igt.h"
 #include <fcntl.h>
 #include <termios.h>
@@ -181,6 +186,23 @@ static bool is_supported(igt_output_t *output)
 		igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
 }
 
+/**
+ * SUBTEST: FB-8BPC-Vs-Panel-6BPC
+ * Description: Framebuffer BPC:8, Panel BPC:6, Expected Dither:Enable
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: FB-8BPC-Vs-Panel-8BPC
+ * Description: Framebuffer BPC:8, Panel BPC:8, Expected Dither:Disable
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void
 run_dither_test(data_t *data, int fb_bpc, int fb_format, int output_bpc)
 {
-- 
2.40.0

[igt-dev] [V5 i-g-t 46/81] tests/kms_dp_aux_dev: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_dp_aux_dev.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
index 19cbe216a..383a2e0b4 100644
--- a/tests/kms_dp_aux_dev.c
+++ b/tests/kms_dp_aux_dev.c
@@ -31,6 +31,19 @@
 
 #include "igt.h"
 #include "igt_kms.h"
+/**
+ * TEST: kms dp aux dev
+ * Category: Display
+ * Description: Test that /dev/drm_dp_aux reads work
+ *
+ * SUBTEST:
+ * Description: Test that /dev/drm_dp_aux reads work
+ * Driver requirement: any
+ * Functionality: dp
+ * Mega feature: DP
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Test that /dev/drm_dp_aux reads work");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 47/81] tests/kms_dp_tiled_display: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_tiled_display.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tests/kms_tiled_display.c b/tests/kms_tiled_display.c
index eba1b2764..4652ef4e4 100644
--- a/tests/kms_tiled_display.c
+++ b/tests/kms_tiled_display.c
@@ -36,12 +36,33 @@
  * the displays supported by the kernel at the moment.
  */
 
+/**
+ * TEST: kms dp tiled display
+ * Category: Display
+ * Description: Test for Transcoder Port Sync for Display Port Tiled Displays
+ */
 #include "igt.h"
 #include "poll.h"
 #include "drm_mode.h"
 #include "drm_fourcc.h"
 #include "igt_edid.h"
 
+/**
+ * SUBTEST: basic-test-%s
+ * Description: Make sure the Tiled CRTCs are synchronized and we get page flips
+ *              for all tiled CRTCs in one vblank (%arg[1]).
+ * Driver requirement: any
+ * Functionality: tiled_display
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @pattern:                  executes on real panel
+ * @pattern-with-chamelium:   executes on chamelium.
+ */
+
 IGT_TEST_DESCRIPTION("Test for genlocked CRTCs with tiled displays");
 
 typedef struct {
-- 
2.40.0

[igt-dev] [V5 i-g-t 48/81] tests/kms_flip: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_flip.c | 178 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 176 insertions(+), 2 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index d57990240..dd7921656 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -22,8 +22,9 @@
  */
 
 /**
- * TEST: Tests for validating modeset, dpms and pageflips
+ * TEST: kms flip
  * Category: Display
+ * Description: Tests for validating modeset, dpms and pageflips
  */
 
 #include "config.h"
@@ -39,6 +40,169 @@
 #include <sys/poll.h>
 #include <sys/time.h>
 #include <sys/ioctl.h>
+/**
+ * SUBTEST: 2x-flip-vs-fences
+ * Description: Test for validating modeset, dpms and pageflips with a pair of connected displays
+ * Driver requirement: i915
+ * Functionality: gtt, vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: 2x-flip-vs-fences-interruptible
+ * Description: Interrupt test for validating modeset, dpms and pageflips with pair of connected displays
+ * Driver requirement: any
+ * Functionality: gtt, vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-vs-fences
+ * Description: Basic test for validating modeset, dpms and pageflips
+ * Driver requirement: i915
+ * Functionality: gtt, vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-vs-fences-interruptible
+ * Description: Interrupt test for validating modeset, dpms and pageflips
+ * Driver requirement: i915
+ * Functionality: gtt, vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
+/**
+ * SUBTEST: %s
+ * Description: Basic test for validating modeset, dpms and pageflips
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @dpms-off-confusion:
+ * @bo-too-big:
+ */
+
+/**
+ * SUBTEST: %s
+ * Description: Basic test for validating modeset, dpms and pageflips
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: 2x-%s
+ * Description: Test for validating modeset, dpms and pageflips with a pair of
+ *              connected displays
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @wf_vblank-ts-check:
+ * @blocking-wf_vblank:
+ * @absolute-wf_vblank:
+ * @blocking-absolute-wf_vblank:
+ * @busy-flip:
+ * @plain-flip-ts-check:
+ * @plain-flip-fb-recreate:
+ * @flip-vs-rmfb:
+ * @flip-vs-panning:
+ * @flip-vs-expired-vblank:
+ * @flip-vs-absolute-wf_vblank:
+ * @flip-vs-blocking-wf-vblank:
+ * @flip-vs-modeset-vs-hang:
+ * @flip-vs-panning-vs-hang:
+ * @flip-vs-dpms-off-vs-modeset:
+ * @single-buffer-flip-vs-dpms-off-vs-modeset:
+ * @nonexisting-fb:
+ * @dpms-vs-vblank-race:
+ * @modeset-vs-vblank-race:
+ * @flip-vs-suspend:
+ */
+
+/**
+ * SUBTEST: 2x-%s
+ * Description: Test for validating modeset, dpms and pageflips with a pair of
+ *              connected displays
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @plain-flip:
+ * @flip-vs-dpms:
+ * @flip-vs-modeset:
+ * @flip-vs-wf_vblank:
+ */
+
+/**
+ * SUBTEST: %s-interruptible
+ * Description: Basic test for validating modeset, dpms and pageflips
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @dpms-off-confusion:
+ * @bo-too-big:
+ */
+
+/**
+ * SUBTEST: %s-interruptible
+ * Description: Basic test for validating modeset, dpms and pageflips
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: 2x-%s-interruptible
+ * Description: Test for validating modeset, dpms and pageflips with a pair of
+ *              connected displays
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @wf_vblank-ts-check:
+ * @absolute-wf_vblank:
+ * @blocking-absolute-wf_vblank:
+ * @plain-flip:
+ * @plain-flip-ts-check:
+ * @plain-flip-fb-recreate:
+ * @flip-vs-rmfb:
+ * @flip-vs-panning:
+ * @flip-vs-expired-vblank:
+ * @flip-vs-absolute-wf_vblank:
+ * @flip-vs-wf_vblank:
+ * @flip-vs-dpms-off-vs-modeset:
+ * @single-buffer-flip-vs-dpms-off-vs-modeset:
+ * @nonexisting-fb:
+ * @dpms-vs-vblank-race:
+ * @modeset-vs-vblank-race:
+ * @flip-vs-suspend:
+ */
+
 #ifdef HAVE_LINUX_KD_H
 #include <linux/kd.h>
 #elif HAVE_SYS_KD_H
@@ -1564,6 +1728,7 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
 /**
  * SUBTEST: basic-flip-vs-%s
  * Description: Basic test to valide %arg[1]
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: vblank
@@ -1577,12 +1742,12 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
  *
  * SUBTEST: basic-plain-flip
  * Description: Basic test for validating page flip
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: vblank
  * Mega feature: General Display Features
  */
-
 static void run_test(int duration, int flags)
 {
 	struct test_output o;
@@ -1759,6 +1924,15 @@ static void kms_flip_exit_handler(int sig)
 		kmstest_set_connector_dpms(drm_fd, last_connector, DRM_MODE_DPMS_ON);
 }
 
+/**
+ * SUBTEST: nonblocking-read
+ * Description: Tests that nonblocking reading fails correctly
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_nonblocking_read(int in)
 {
 	char buffer[1024];
-- 
2.40.0

[igt-dev] [V5 i-g-t 49/81] tests/kms_flip_event_leak: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_flip_event_leak.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c
index 423ce40df..a1b614771 100644
--- a/tests/kms_flip_event_leak.c
+++ b/tests/kms_flip_event_leak.c
@@ -30,6 +30,25 @@
 
 #include "igt_device.h"
 #include "xe/xe_query.h"
+/**
+ * TEST: kms flip event leak
+ * Category: Display
+ * Description: This test tries to provoke the kernel into leaking a pending
+ *              page flip event when the fd is closed before the flip has
+ *              completed. The test itself won't fail even if the kernel leaks
+ *              the event, but the resulting dmesg WARN will indicate a failure.
+ *
+ * SUBTEST: basic
+ * Description: This test tries to provoke the kernel into leaking a pending
+ *              page flip event when the fd is closed before the flip has
+ *              completed. The test itself won't fail even if the kernel leaks
+ *              the event, but the resulting dmesg WARN will indicate a failure.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 typedef struct {
 	int drm_fd;
-- 
2.40.0

[igt-dev] [V5 i-g-t 50/81] tests/kms_force_connector_basic: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_force_connector_basic.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
index 950af8d8a..80e0822c3 100644
--- a/tests/kms_force_connector_basic.c
+++ b/tests/kms_force_connector_basic.c
@@ -23,8 +23,9 @@
  */
 
 /**
- * TEST: Check the debugfs force connector/edid features work correctly
+ * TEST: kms force connector basic
  * Category: Display
+ * Description: Check the debugfs force connector/edid features work correctly.
  */
 
 #include "igt.h"
@@ -68,6 +69,15 @@ static void reset_connectors(void)
 	drm_close_driver(drm_fd);
 }
 
+/**
+ * SUBTEST: force-load-detect
+ * Description: Test to detect forced load.
+ * Driver requirement: i915
+ * Functionality: force_connector, vga
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void force_load_detect(int drm_fd, drmModeConnectorPtr connector, drmModeRes *res)
 {
 	int i, j, w = 64, h = 64;
@@ -159,6 +169,7 @@ static void force_load_detect(int drm_fd, drmModeConnectorPtr connector, drmMode
 /**
  * SUBTEST: force-connector-state
  * Description: Test to check the forced connector state
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: force_connector
@@ -206,6 +217,7 @@ static void force_connector_state(int drm_fd, drmModeConnectorPtr connector)
 /**
  * SUBTEST: force-edid
  * Description: Test to check the values after forcing edid
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: force_connector
@@ -255,6 +267,7 @@ static void force_edid(int drm_fd, drmModeConnectorPtr connector)
 /**
  * SUBTEST: prune-stale-modes
  * Description: Tests pruning of stale modes
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: force_connector
-- 
2.40.0

[igt-dev] [V5 i-g-t 51/81] tests/kms_getfb: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_getfb.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 90 insertions(+)

diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
index afcf07fe8..b35cd4152 100644
--- a/tests/kms_getfb.c
+++ b/tests/kms_getfb.c
@@ -27,6 +27,11 @@
  *
  */
 
+/**
+ * TEST: kms getfb
+ * Category: Display
+ * Description: Tests GETFB and GETFB2 ioctls.
+ */
 #include "igt.h"
 #include <unistd.h>
 #include <stdlib.h>
@@ -169,6 +174,22 @@ static uint32_t get_any_prop_id(int fd)
 	return 0;
 }
 
+/**
+ * SUBTEST: getfb-handle-%s
+ * Description: Tests error handling %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @closed:       when passing a handle that has been closed.
+ * @not-fb:       when passing an invalid handle.
+ * @valid:        when passing an valid handle.
+ * @zero:         for a zero'd input.
+ */
 static void test_handle_input(int fd)
 {
 	struct drm_mode_fb_cmd2 add = {};
@@ -224,6 +245,30 @@ static void test_handle_input(int fd)
 		gem_close(fd, add.handles[0]);
 }
 
+/**
+ * SUBTEST: getfb-reject-ccs
+ * Description: Tests error handling while requesting CCS buffers it should
+ *              refuse because getfb supports returning a single buffer handle.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: getfb-%s-different-handles
+ * Description: Tests error handling while requesting for two different handles
+ *              from %arg[1].
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @addfb:           same fd
+ * @repeated:        different fd
+ */
 static void test_duplicate_handles(int fd)
 {
 	struct drm_mode_fb_cmd2 add = {};
@@ -289,6 +334,37 @@ static void test_duplicate_handles(int fd)
 	}
 }
 
+/**
+ * SUBTEST: getfb2-accept-ccs
+ * Description: Tests outputs are correct when retrieving a CCS framebuffer.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: getfb2-into-addfb2
+ * Description: Output check by passing the output of GETFB2 into ADDFB2.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: getfb2-handle-%s
+ * Description: Tests error handling %arg[1].
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @closed:                  when passing a handle that has been closed
+ * @not-fb:                  when passing an invalid handle
+ * @zero:                    for a zero'd input
+ */
 static void test_getfb2(int fd)
 {
 	struct drm_mode_fb_cmd2 add_basic = {};
@@ -397,6 +473,20 @@ static void test_getfb2(int fd)
 	}
 }
 
+/**
+ * SUBTEST: %s-handle-protection
+ * Description: Make sure %arg[1] return handles if caller is non-root or non-master.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @getfb:      GETFB ioctl
+ * @getfb2:     GETFB2 ioctl
+ */
 static void test_handle_protection(void) {
 	int non_master_fd;
 	struct drm_mode_fb_cmd2 non_master_add = {};
-- 
2.40.0

[igt-dev] [V5 i-g-t 52/81] tests/kms_hdmi_inject: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_hdmi_inject.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
index 9aa5c59fc..436f34a8c 100644
--- a/tests/kms_hdmi_inject.c
+++ b/tests/kms_hdmi_inject.c
@@ -30,6 +30,31 @@
 #include "igt_edid.h"
 #include "igt_eld.h"
 #include "xe/xe_query.h"
+/**
+ * TEST: kms hdmi inject
+ * Category: Display
+ * Description: Test that in-kernel EDID parsing is producing expected results
+ *              by forcing a HDMI connector with a known EDID and checking that
+ *              the metadata exposed to user space matches.
+ *
+ * SUBTEST: inject-4k
+ * Description: Make sure that 4K modes exposed by DRM match the forced EDID and
+ *              modesetting using it succeed.
+ * Driver requirement: any
+ * Functionality: force_connector
+ * Mega feature: HDMI
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: inject-audio
+ * Description: Make sure that audio information exposed by ALSA match the forced
+ *              EDID.
+ * Driver requirement: any
+ * Functionality: force_connector
+ * Mega feature: Disply Audio
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 #define HDISPLAY_4K	3840
 #define VDISPLAY_4K	2160
-- 
2.40.0

[igt-dev] [V5 i-g-t 53/81] tests/kms_hdr: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_hdr.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index ba19761e2..0442cc168 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -20,6 +20,11 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
+/**
+ * TEST: kms hdr
+ * Category: Display
+ * Description: Test HDR metadata interfaces and bpc switch
+ */
 #include "igt.h"
 #include <fcntl.h>
 #include <termios.h>
@@ -208,6 +213,21 @@ static bool has_max_bpc(igt_output_t *output)
 	       igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
 }
 
+/**
+ * SUBTEST: bpc-%s
+ * Description: Tests switching between different display output bpc modes %arg[1]
+ * Driver requirement: any
+ * Functionality: kms_hdr
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @switch:              default
+ * @switch-dpms:         with dpms
+ * @switch-suspend:      with suspend
+ */
 static void test_bpc_switch(data_t *data, uint32_t flags)
 {
 	igt_display_t *display = &data->display;
@@ -561,6 +581,38 @@ static bool has_hdr(igt_output_t *output)
 	return igt_output_has_prop(output, IGT_CONNECTOR_HDR_OUTPUT_METADATA);
 }
 
+/**
+ * SUBTEST: invalid-hdr
+ * Description: Test to ensure HDR is not enabled on non-HDR panel
+ * Driver requirement: any
+ * Functionality: kms_hdr
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid-metadata-sizes
+ * Description: Tests invalid HDR metadata sizes
+ * Driver requirement: any
+ * Functionality: kms_hdr
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: static-%s
+ * Description: Tests %arg[1].
+ * Driver requirement: any
+ * Functionality: kms_hdr
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @swap:                    swapping static HDR metadata
+ * @toggle:                  entering and exiting HDR mode
+ * @toggle-dpms:             static toggle with dpms
+ * @toggle-suspend:          static toggle with suspend
+ */
 static void test_hdr(data_t *data, uint32_t flags)
 {
 	igt_display_t *display = &data->display;
-- 
2.40.0

[igt-dev] [V5 i-g-t 54/81] tests/kms_invalid_mode: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_invalid_mode.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index c26f8befe..f9d953014 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -22,10 +22,42 @@
  *
  */
 
+/**
+ * TEST: kms invalid mode
+ * Category: Display
+ * Description: Make sure all modesets are rejected when the requested mode is
+ *              invalid
+ */
 #include "igt.h"
 #include <limits.h>
 #include <stdbool.h>
 
+/**
+ * SUBTEST: %s
+ * Description: Make sure all modesets are rejected when the requested mode is
+ *              invalid
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @bad-hsync-end:
+ * @bad-hsync-start:
+ * @bad-htotal:
+ * @bad-vsync-end:
+ * @bad-vsync-start:
+ * @bad-vtotal:
+ * @clock-too-high:
+ * @int-max-clock:
+ * @uint-max-clock:
+ * @zero-clock:
+ * @zero-hdisplay:
+ * @zero-vdisplay:
+ */
+
 IGT_TEST_DESCRIPTION("Make sure all modesets are rejected when the requested mode is invalid");
 
 typedef struct _data data_t;
-- 
2.40.0

[igt-dev] [V5 i-g-t 55/81] tests/kms_lease: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_lease.c | 180 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 180 insertions(+)

diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index c8ae98206..2f41ab52f 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -26,6 +26,11 @@
  * This is a test of DRM leases
  */
 
+/**
+ * TEST: kms lease
+ * Category: Display
+ * Description: Test of CreateLease.
+ */
 
 #include "igt.h"
 #include <stdlib.h>
@@ -45,6 +50,181 @@
 #include <drm.h>
 #include "igt_device.h"
 
+/**
+ * SUBTEST: atomic_implicit_crtc
+ * Description: Negative test by using a different crtc with atomic ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: cursor_implicit_plane
+ * Description: Negative test by using a non-primary plane with setcursor ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: empty_lease
+ * Description: Check that creating an empty lease works
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: implicit-plane-lease
+ * Description: Tests the implicitly added planes.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid-create-leases
+ * Description: Tests error handling while creating invalid corner-cases for
+ *              create-lease ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease-uevent
+ * Description: Tests all the uevent cases
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_again
+ * Description: Tests leasing objects more than once
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_get
+ * Description: Tests getting the required contents of a lease
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_invalid_connector
+ * Description: Tests leasing an invalid connector
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_invalid_crtc
+ * Description: Tests leasing an invalid crtc
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_invalid_plane
+ * Description: Tests leasing an invalid plane
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_revoke
+ * Description: Tests revocation of lease
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_unleased_connector
+ * Description: Negative test by trying to use an unleased connector
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_unleased_crtc
+ * Description: Negative test by trying to use an unleased crtc
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lessee_list
+ * Description: Check if listed lease is same as created one
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: master-vs-lease
+ * Description: Tests the drop/set_master interactions.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: multimaster-lease
+ * Description: Tests that the 2nd master can only create leases while being
+ *              active master, and that leases on the first master don't prevent
+ *              lease creation for the 2nd master.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: page_flip_implicit_plane
+ * Description: Negative test by using a non-primary plane with the page flip ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: possible-crtcs-filtering
+ * Description: Tests that  possible_crtcs logically match between master and
+ *              lease, and that the values are correctly renumbered on the lease
+ *              side.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: setcrtc_implicit_plane
+ * Description: Negative test by using a non-primary plane with the setcrtc ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: simple_lease
+ * Description: Check if create lease ioctl call works
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 IGT_TEST_DESCRIPTION("Test of CreateLease.");
 
 typedef struct {
-- 
2.40.0

[igt-dev] [V5 i-g-t 56/81] tests/kms_multipipe_modeset: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_multipipe_modeset.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tests/kms_multipipe_modeset.c b/tests/kms_multipipe_modeset.c
index 1fdfb9a9f..a06a6c4b5 100644
--- a/tests/kms_multipipe_modeset.c
+++ b/tests/kms_multipipe_modeset.c
@@ -25,6 +25,20 @@
  */
 
 #include "igt.h"
+/**
+ * TEST: kms multipipe modeset
+ * Category: Display
+ * Description: Test simultaneous modeset on all the supported pipes
+ *
+ * SUBTEST: basic-max-pipe-crc-check
+ * Description: Verify if simultaneous modesets on all the supported pipes is
+ *              successful. Validate using CRC verification
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Test simultaneous modeset on all the supported pipes");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 57/81] tests/kms_panel_fitting: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_panel_fitting.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index ae1c65928..82d34831a 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -26,6 +26,27 @@
 #include <limits.h>
 #include <math.h>
 #include <sys/stat.h>
+/**
+ * TEST: kms panel fitting
+ * Category: Display
+ * Description: Test display panel fitting
+ *
+ * SUBTEST: atomic-fastset
+ * Description: Tests panel fitting usages with atomic fastset.
+ * Driver requirement: any
+ * Functionality: eDP, panel_fitting
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: legacy
+ * Description: Tests panel fitting usages with legacy style commit.
+ * Driver requirement: any
+ * Functionality: eDP, panel_fitting
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Test display panel fitting");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 58/81] tests/kms_pipe_crc_basic: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Add missing "Driver requirement" field

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_pipe_crc_basic.c | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 95cc1d7fa..9e800b285 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -23,8 +23,9 @@
  */
 
 /**
- * TEST: Tests behaviour of CRC
+ * TEST: kms pipe crc basic
  * Category: Display
+ * Description: Tests behaviour of CRC
  */
 
 #include "igt.h"
@@ -64,6 +65,15 @@ static bool simulation_constraint(enum pipe pipe)
 	return false;
 }
 
+/**
+ * SUBTEST: bad-source
+ * Description: Tests error handling when the bad source is set.
+ * Driver requirement: any
+ * Functionality: crc
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_bad_source(data_t *data)
 {
 	errno = 0;
@@ -88,6 +98,7 @@ enum {
 /**
  * SUBTEST: read-crc
  * Description: Test for pipe CRC reads
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: crc
@@ -95,6 +106,7 @@ enum {
  *
  * SUBTEST: read-crc-frame-sequence
  * Description: Tests the pipe CRC read and ensure frame sequence
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: crc
@@ -102,6 +114,7 @@ enum {
  *
  * SUBTEST: nonblocking-crc
  * Description: Test for O_NONBLOCK CRC reads
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: crc
@@ -109,6 +122,7 @@ enum {
  *
  * SUBTEST: nonblocking-crc-frame-sequence
  * Description: Test for O_NONBLOCK CRC reads and ensure frame sequence
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: crc
@@ -116,6 +130,7 @@ enum {
  *
  * SUBTEST: suspend-read-crc
  * Description: Suspend test for pipe CRC reads
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: crc
@@ -123,12 +138,12 @@ enum {
  *
  * SUBTEST: hang-read-crc
  * Description: Hang test for pipe CRC read
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: crc
  * Mega feature: General Display Features
  */
-
 static void test_read_crc(data_t *data, enum pipe pipe,
 			  igt_output_t *output, unsigned flags)
 {
@@ -229,6 +244,7 @@ static void test_read_crc(data_t *data, enum pipe pipe,
 /**
  * SUBTEST: compare-crc-sanitycheck-%s
  * Description: Basic sanity check for CRC mismatches with %arg[1]
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: crc
@@ -305,6 +321,16 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output,
 	igt_remove_fb(data->drm_fd, &fb1);
 }
 
+/**
+ * SUBTEST: disable-crc-after-crtc
+ * Description: Check that disabling CRCs on a CRTC after having disabled the
+ *              CRTC does not cause issues.
+ * Driver requirement: any
+ * Functionality: crc
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_disable_crc_after_crtc(data_t *data, enum pipe pipe,
 					igt_output_t *output)
 {
-- 
2.40.0

[igt-dev] [V5 i-g-t 59/81] tests/kms_plane: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_plane.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 67cff61d6..8c6ce78f3 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -24,6 +24,11 @@
  *   Damien Lespiau <damien.lespiau@intel.com>
  */
 
+/**
+ * TEST: kms plane
+ * Category: Display
+ * Description: Testes for KMS Plane
+ */
 #include "igt.h"
 #include "igt_vec.h"
 #include <errno.h>
@@ -273,6 +278,21 @@ test_plane_position_with_output(data_t *data,
 	igt_remove_fb(data->drm_fd, &sprite_fb);
 }
 
+/**
+ * SUBTEST: plane-position-%s
+ * Description: Verify plane position using two planes to create a %arg[1]
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @covered:           fully covered screen
+ * @hole:              partially covered screen
+ * @hole-dpms:         partially covered screen and check for DPMS
+ */
 static void
 test_plane_position(data_t *data, enum pipe pipe)
 {
@@ -381,6 +401,21 @@ test_plane_panning_with_output(data_t *data,
 	igt_remove_fb(data->drm_fd, &primary_fb);
 }
 
+/**
+ * SUBTEST: plane-panning-%s
+ * Description: Verify plane panning at %arg[1] using primary plane
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @bottom-right:               bottom-right position
+ * @bottom-right-suspend:       bottom-right position with suspend
+ * @top-left:                   top-left position
+ */
 static void
 test_plane_panning(data_t *data, enum pipe pipe)
 {
@@ -1101,6 +1136,20 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
 	return index != 0 && index != 3 && index != 5;
 }
 
+/**
+ * SUBTEST: pixel-%s
+ * Description: verify the pixel formats for given plane and pipe
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @format:
+ * @format-source-clamping:          with source clamping
+ */
 static void
 test_pixel_formats(data_t *data, enum pipe pipe)
 {
@@ -1157,6 +1206,15 @@ test_pixel_formats(data_t *data, enum pipe pipe)
 	igt_assert_f(result, "At least one CRC mismatch happened\n");
 }
 
+/**
+ * SUBTEST: invalid-pixel-format-settings
+ * Description: verify invalid settings for pixel format are not accepted
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_invalid_settings(data_t *data)
 {
 	enum pipe pipe = PIPE_A;
-- 
2.40.0

[igt-dev] [V5 i-g-t 60/81] tests/kms_plane_alpha_blend: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_plane_alpha_blend.c | 55 +++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
index 341b85c7e..d139f2367 100644
--- a/tests/kms_plane_alpha_blend.c
+++ b/tests/kms_plane_alpha_blend.c
@@ -24,6 +24,11 @@
  *   Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
  */
 
+/**
+ * TEST: kms plane alpha blend
+ * Category: Display
+ * Description: Test plane alpha and blending mode properties
+ */
 #include "igt.h"
 
 IGT_TEST_DESCRIPTION("Test plane alpha and blending mode properties");
@@ -477,6 +482,56 @@ static void coverage_premult_constant(data_t *data, enum pipe pipe, igt_plane_t
 	igt_pipe_crc_stop(data->pipe_crc);
 }
 
+/**
+ * SUBTEST: alpha-%s
+ * Description: Test to %arg[1]
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @7efc:                validate alpha values 0x7e and 0xfc are swappable on
+ *                       pre-multiplied blend mode.
+ * @basic:               basic plane alpha properties.
+ * @opaque-fb:           alpha properties with opaque fb.
+ * @transparent-fb:      alpha property with transparent fb.
+ */
+
+/**
+ * SUBTEST: coverage-vs-premult-vs-constant
+ * Description: Tests pipe coverage blending properties.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: coverage-7efc
+ * Description: Uses alpha values 0x7e and 0xfc to validate fg.alpha and
+ *              plane_alpha are swappable on coverage blend mode.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: constant-alpha-%s
+ * Description: Tests plane alpha and blending properties with %arg[1].
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @max:            maximum alpha value
+ * @mid:            medium  alpha value
+ * @min:            minimum alpha value
+ */
 static void run_test_on_pipe_planes(data_t *data, enum pipe pipe, igt_output_t *output,
 				    bool blend, bool must_multiply,
 				    void(*test)(data_t *, enum pipe, igt_plane_t *))
-- 
2.40.0

[igt-dev] [V5 i-g-t 61/81] tests/kms_plane_cursor: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_plane_cursor.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index a7acb18e1..bf217fbcb 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -21,6 +21,36 @@
  */
 
 #include "igt.h"
+/**
+ * TEST: kms plane cursor
+ * Category: Display
+ * Description: Tests cursor interactions with primary and overlay planes.
+ *
+ * SUBTEST: overlay
+ * Description: Tests atomic cursor positioning on primary plane and overlay plane
+ * Driver requirement: any
+ * Functionality: cursor, plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: primary
+ * Description: Tests atomic cursor positioning on primary plane
+ * Driver requirement: any
+ * Functionality: cursor, plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: viewport
+ * Description: Tests atomic cursor positioning on primary plane and overlay plane
+ *              with buffer larger than viewport used for display
+ * Driver requirement: any
+ * Functionality: cursor, plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 /*
  * This file tests cursor interactions with primary and overlay planes.
-- 
2.40.0

[igt-dev] [V5 i-g-t 62/81] tests/kms_plane_lowres: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_plane_lowres.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
index 7aaf83c41..65d1dd183 100644
--- a/tests/kms_plane_lowres.c
+++ b/tests/kms_plane_lowres.c
@@ -22,6 +22,12 @@
  *
  */
 
+/**
+ * TEST: kms plane lowres
+ * Category: Display
+ * Description: Test atomic mode setting with a plane by switching between high
+ *              and low resolutions
+ */
 #include "igt.h"
 #include "drmtest.h"
 #include <errno.h>
@@ -261,6 +267,24 @@ static void test_cleanup(data_t *data)
 	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 }
 
+/**
+ * SUBTEST: tiling-%s
+ * Description: Tests the visibility of the planes when switching between high
+ *              and low resolution with %arg[1]
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @none:        Linear buffer (no tiling)
+ * @4:           4-tiling
+ * @x:           x-tiling
+ * @y:           y-tiling
+ * @yf:          yf-tiling
+ */
 static void run_test(data_t *data, uint64_t modifier)
 {
 	enum pipe pipe;
-- 
2.40.0

[igt-dev] [V5 i-g-t 63/81] tests/kms_plane_multiple: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_plane_multiple.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 1f2bd65c3..3e6f4411e 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -22,6 +22,11 @@
  *
  */
 
+/**
+ * TEST: kms plane multiple
+ * Category: Display
+ * Description: Test atomic mode setting with multiple planes.
+ */
 #include "igt.h"
 #include "drmtest.h"
 #include <errno.h>
@@ -373,6 +378,25 @@ test_plane_position(data_t *data, enum pipe pipe, igt_output_t *output, uint64_t
 					n_planes, modifier);
 }
 
+/**
+ * SUBTEST: tiling-%s
+ * Description: Check that the kernel handles atomic updates of multiple planes
+ *              correctly by changing their geometry and making sure the changes
+ *              are reflected immediately after each commit.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @none:        Linear buffer (no tiling)
+ * @4:           4-tiling
+ * @x:           x-tiling
+ * @y:           y-tiling
+ * @yf:          yf-tiling
+ */
 static void run_test(data_t *data, uint64_t modifier)
 {
 	enum pipe pipe;
-- 
2.40.0

[igt-dev] [V5 i-g-t 64/81] tests/kms_plane_scaling: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Fix the documentation for renamed tests

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_plane_scaling.c | 261 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 261 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 920290e4d..efe772dec 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -22,6 +22,11 @@
  *
  */
 
+/**
+ * TEST: kms plane scaling
+ * Category: Display
+ * Description: Test display plane scaling
+ */
 #include "igt.h"
 #include "igt_vec.h"
 #include <math.h>
@@ -524,6 +529,52 @@ static const uint64_t modifiers[] = {
 	I915_FORMAT_MOD_4_TILED
 };
 
+/**
+ * SUBTEST: plane-scaler-with-modifiers-unity-scaling
+ * Description: Tests scaling with modifiers, unity scaling.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-scaler-with-clipping-clamping-modifiers
+ * Description: Tests scaling with clipping and clamping, modifiers.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-upscale-with-modifiers-%s
+ * Description: Tests upscaling with modifiers %arg[1].
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @20x20:          from 20x20 fb
+ * @factor-0-25:    for 0.25 scaling factor
+ */
+
+/**
+ * SUBTEST: plane-downscale-with-modifiers-factor-%s
+ * Description: Tests downscaling with modifiers for %arg[1] scaling factor.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @0-25:   0.25
+ * @0-5:    0.5
+ * @0-75:   0.75
+ */
 static void test_scaler_with_modifier_pipe(data_t *d,
 					   int width, int height,
 					   bool is_upscale,
@@ -560,6 +611,52 @@ static void test_scaler_with_modifier_pipe(data_t *d,
 	}
 }
 
+/**
+ * SUBTEST: plane-scaler-with-rotation-unity-scaling
+ * Description: Tests scaling with rotation, unity scaling.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-scaler-with-clipping-clamping-rotation
+ * Description: Tests scaling with clipping and clamping, rotation.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-upscale-with-rotation-%s
+ * Description: Tests upscaling with rotation %arg[1].
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @20x20:          from 20x20 fb
+ * @factor-0-25:    for 0.25 scaling factor
+ */
+
+/**
+ * SUBTEST: plane-downscale-with-rotation-factor-%s
+ * Description: Tests downscaling with rotation for %arg[1] scaling factor.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @0-25:   0.25
+ * @0-5:    0.5
+ * @0-75:   0.75
+ */
 static void test_scaler_with_rotation_pipe(data_t *d,
 					   int width, int height,
 					   bool is_upscale,
@@ -592,7 +689,52 @@ static void test_scaler_with_rotation_pipe(data_t *d,
 		}
 	}
 }
+/**
+ * SUBTEST: plane-scaler-with-pixel-format-unity-scaling
+ * Description: Tests scaling with pixel formats, unity scaling.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-scaler-with-clipping-clamping-pixel-formats
+ * Description: Tests scaling with clipping and clamping, pixel formats.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: plane-upscale-with-pixel-format-%s
+ * Description: Tests upscaling with pixel formats %arg[1].
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @20x20:          from 20x20 fb
+ * @factor-0-25:    for 0.25 scaling factor
+ */
 
+/**
+ * SUBTEST: plane-downscale-with-pixel-format-factor-%s
+ * Description: Tests downscaling with pixel formats for %arg[1] scaling factor.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @0-25:   0.25
+ * @0-5:    0.5
+ * @0-75:   0.75
+ */
 static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, bool is_upscale,
 					       enum pipe pipe, igt_output_t *output)
 {
@@ -728,6 +870,88 @@ static void setup_fb(int fd, int width, int height, struct igt_fb *fb)
 		      fb);
 }
 
+/**
+ * SUBTEST: planes-downscale-factor-%s
+ * Description: Tests downscaling of 2 planes for %arg[1] scaling factor.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @0-25:  0.25
+ * @0-5:   0.5
+ * @0-75:  0.75
+ */
+/**
+ * SUBTEST: planes-downscale-factor-%s-%s
+ * Description: Tests downscaling (scaling factor %arg[1]) and upscaling (%arg[2])
+ *              of 2 planes.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @0-25:  0.25
+ * @0-5:   0.5
+ * @0-75:  0.75
+ *
+ * arg[2]:
+ *
+ * @upscale-20x20:           upscale 20x20
+ * @upscale-factor-0-25:     scaling factor 0.25
+ * @unity-scaling:           Unity
+ */
+/**
+ * SUBTEST: planes-scaler-unity-scaling
+ * Description: Tests scaling of 2 planes, unity scaling.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: planes-upscale-%s
+ * Description: Tests upscaling of 2 planes %arg[1].
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @20x20:          from 20x20 fb
+ * @factor-0-25:    for 0.25 scaling factor
+ */
+/**
+ * SUBTEST: planes-%s-downscale-factor-%s
+ * Description: Tests scaling (%arg[1]) and downscaling (scaling factor %arg[2])
+ *              of 2 planes.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @unity-scaling:           Unity
+ * @upscale-factor-0-25:     scaling factor 0.25
+ * @upscale-20x20:           upscale 20x20
+ *
+ * arg[2]:
+ *
+ * @0-25:  0.25
+ * @0-5:   0.5
+ * @0-75:  0.75
+ */
+
 static void
 test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
 			  enum pipe pipe, igt_output_t *output,
@@ -786,6 +1010,15 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
 	cleanup_fbs(d);
 }
 
+/**
+ * SUBTEST: invalid-num-scalers
+ * Description: Negative test for number of scalers per pipe.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void
 test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
 {
@@ -851,6 +1084,15 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
 	cleanup_fbs(d);
 }
 
+/**
+ * SUBTEST: 2x-scaler-multi-pipe
+ * Description: Tests scaling with multi-pipe.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_scaler_with_multi_pipe_plane(data_t *d)
 {
 	igt_display_t *display = &d->display;
@@ -935,6 +1177,15 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	igt_assert_eq(ret1 && ret2, 0);
 }
 
+/**
+ * SUBTEST: invalid-parameters
+ * Description: test parameters which should not be accepted
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void invalid_parameter_tests(data_t *d)
 {
 	enum pipe pipe = PIPE_A;
@@ -1015,6 +1266,16 @@ static drmModeModeInfo *find_mode(data_t *data, igt_output_t *output, const uint
 	return mode;
 }
 
+/**
+ * SUBTEST: intel-max-src-size
+ * Description: Test for validating max source size.
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 /*
  *	Max source/destination width/height for intel driver.
  *	These numbers are coming from
-- 
2.40.0

[igt-dev] [V5 i-g-t 65/81] tests/kms_prime: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_prime.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/tests/kms_prime.c b/tests/kms_prime.c
index 52f587961..3e46aafb9 100644
--- a/tests/kms_prime.c
+++ b/tests/kms_prime.c
@@ -30,6 +30,41 @@
 #include <sys/ioctl.h>
 #include <sys/poll.h>
 #include <time.h>
+/**
+ * TEST: kms prime
+ * Category: Display
+ * Description: Prime tests, focusing on KMS side
+ *
+ * SUBTEST: D3hot
+ * Description: Validate pci state of dGPU when dGPU is idle and  scanout is on iGPU
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: basic-modeset-hybrid
+ * Description: Basic modeset on the one device when the other device is active
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: basic-crc-%s
+ * Description: Make a dumb color buffer, export to another device and compare
+ *              the CRCs with a buffer native to that device
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @hybrid:
+ * @vgem:
+ */
 
 #define KMS_HELPER "/sys/module/drm_kms_helper/parameters/"
 #define KMS_POLL_DISABLE 0
-- 
2.40.0

[igt-dev] [V5 i-g-t 66/81] tests/kms_prop_blob: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_prop_blob.c | 46 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/tests/kms_prop_blob.c b/tests/kms_prop_blob.c
index fc172b5a3..e4f5dd71f 100644
--- a/tests/kms_prop_blob.c
+++ b/tests/kms_prop_blob.c
@@ -26,8 +26,9 @@
  */
 
 /**
- * TEST: Tests behaviour of mass-data 'blob' properties
+ * TEST: kms prop blob
  * Category: Display
+ * Description: Tests behaviour of mass-data 'blob' properties.
  */
 #include "igt.h"
 #include <errno.h>
@@ -122,6 +123,29 @@ destroy_prop(int fd, uint32_t prop_id)
 	return 0;
 }
 
+/**
+ * SUBTEST: blob-multiple
+ * Description: Test validates destroying multiple properties explicitly works as needed.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: blob-prop-%s
+ * Description: Tests validates the %arg[1] of the properties created.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @core:        validity
+ * @lifetime:    lifetime
+ * @validate:    blob size
+ */
 static void
 test_validate(int fd)
 {
@@ -245,6 +269,7 @@ test_core(int fd)
 /**
  * SUBTEST: basic
  * Description: Test to ensure property support exists
+ * Driver requirement: any
  * Test category: functionality test
  * Run type: BAT
  * Functionality: kms_core
@@ -260,6 +285,25 @@ test_basic(int fd)
 	igt_assert_eq(destroy_prop(fd, prop_id), 0);
 }
 
+/**
+ * SUBTEST: invalid-%s-%s
+ * Description: Tests error handling when invalid properties are %ar[1] with %arg[2].
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @get:            fetched
+ * @set:            set
+ *
+ * arg[2]:
+ *
+ * @prop:           blob object type
+ * @prop-any:       object of any type
+ */
 static void prop_tests(int fd)
 {
 	struct drm_mode_obj_get_properties get_props = {};
-- 
2.40.0

[igt-dev] [V5 i-g-t 67/81] tests/kms_properties: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_properties.c | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index 8645808d1..197c72065 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -28,6 +28,31 @@
 #include <stdio.h>
 #include <string.h>
 #include <time.h>
+/**
+ * TEST: kms properties
+ * Category: Display
+ *
+ * SUBTEST: %s-properties-%s
+ * Description: Tests %arg[1] properties with %arg[2] commit
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @connector:       Connector
+ * @crtc:            CRTC
+ * @plane:           Plane
+ * @invalid:         Invalid (connector/crtc/plane)
+ *
+ * arg[2]:
+ *
+ * @atomic:          atomic
+ * @legacy:          legacy
+ */
+
 
 struct additional_test {
 	const char *name;
@@ -687,6 +712,21 @@ static void expect_no_props(int fd, uint32_t obj_type, uint32_t obj_id)
 	igt_assert_neq(drmIoctl(fd, DRM_IOCTL_MODE_OBJ_GETPROPERTIES, &properties), 0);
 }
 
+/**
+ * SUBTEST: get_properties-sanity-%s
+ * Description: Test validates the properties of all planes, crtc and connectors
+ *              with %arg[1] commit
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @atomic:          atomic
+ * @non-atomic:      legacy
+ */
 static void get_prop_sanity(igt_display_t *display, bool atomic)
 {
 	int fd = display->drm_fd;
-- 
2.40.0

[igt-dev] [V5 i-g-t 68/81] tests/kms_rmfb: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_rmfb.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
index 9a41c1d14..7348251f8 100644
--- a/tests/kms_rmfb.c
+++ b/tests/kms_rmfb.c
@@ -28,6 +28,30 @@
 #include <stdio.h>
 #include <string.h>
 #include <time.h>
+/**
+ * TEST: kms rmfb
+ * Category: Display
+ * Description: This tests rmfb and close-fd behavior. In these casesthe
+ *              framebuffers should be removed from the crtc.
+ *
+ * SUBTEST: close-fd
+ * Description: RMFB is supposed to free the framebuffers from any and all planes
+ *              so test this and make sure it works with fd close and reopen.
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: rmfb-ioctl
+ * Description: RMFB is supposed to free the framebuffers from any and all planes
+ *              so test this and make sure it works.
+ * Driver requirement: any
+ * Functionality: kms_gem_interop
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 #ifndef DRM_CAP_CURSOR_WIDTH
 #define DRM_CAP_CURSOR_WIDTH 0x8
-- 
2.40.0

[igt-dev] [V5 i-g-t 69/81] tests/kms_rotation_crc: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_rotation_crc.c | 130 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 130 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 5ad04407d..6009afe95 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -22,6 +22,11 @@
  *
  */
 
+/**
+ * TEST: kms rotation crc
+ * Category: Display
+ * Description: Tests different rotations with different planes & formats
+ */
 #include "igt.h"
 #include "igt_vec.h"
 #include <math.h>
@@ -474,6 +479,97 @@ static bool test_format(data_t *data,
 	return true;
 }
 
+/**
+ * SUBTEST: %s-rotation-180
+ * Description: Rotation test with 180 degree for %arg[1] planes
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @primary:    primary
+ * @sprite:     sprite
+ * @cursor:     cursor
+ */
+
+/**
+ * SUBTEST: %s-rotation-%d
+ * Description: Rotation test with %arg[2] degree for %arg[1] planes of gen9+
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @primary:    primary
+ * @sprite:     sprite
+ *
+ * arg[2].values: 90, 270
+ */
+
+/**
+ * SUBTEST: bad-%s
+ * Description: Checking unsupported %arg[1] for gen9+ with 90 degree of rotation
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @pixel-format:       pixel format
+ * @tiling:             tiling
+ */
+
+/**
+ * SUBTEST: primary-%s-tiled-reflect-x-%d
+ * Description: Test for %arg[1] & %arg[2] degree rotation on primary plane
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @4:      4 tiling
+ * @x:      x tiling
+ * @y:      y tiling
+ * @yf:     yf tiling
+ *
+ * arg[2].values: 0, 180
+ */
+
+/**
+ * SUBTEST: primary-%s-tiled-reflect-x-%d
+ * Description: Test for %arg[1] & %arg[2] degree rotation on primary plane
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @y:      y tiling
+ * @yf:     yf tiling
+ *
+ * arg[2].values: 90, 270
+ *
+ * SUBTEST: sprite-rotation-90-pos-100-0
+ * Description: Rotation test with 90 degree for a plane of gen9+ with given position
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_format)
 {
 	igt_display_t *display = &data->display;
@@ -792,6 +888,31 @@ static bool reusecrcfromlastround(planeinfos p[2], int lastroundp1format,
 
 	return true;
 }
+
+/**
+ * SUBTEST: multiplane-rotation
+ * Description: Rotation test on both planes by making them fully visible
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: multiplane-rotation-cropping-%s
+ * Description: Rotation test on both planes by cropping left/%arg[1] corner of
+ *              primary plane and right/%arg[1] corner of sprite plane
+ * Driver requirement: any
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @bottom:   bottom
+ * @top:      top
+ */
+
 /*
  * Here is pipe parameter which is now used only for first pipe.
  * It is left here if this test ever was wanted to be run on
@@ -993,6 +1114,15 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
 	igt_require_f(found, "No valid pipe/output combo found.\n");
 }
 
+/**
+ * SUBTEST: exhaust-fences
+ * Description: This test intends to check for fence leaks exhaustively
+ * Driver requirement: i915
+ * Functionality: rotation
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 static void test_plane_rotation_exhaust_fences(data_t *data,
 					       enum pipe pipe,
 					       igt_output_t *output,
-- 
2.40.0

[igt-dev] [V5 i-g-t 70/81] tests/kms_scaling_modes: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_scaling_modes.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
index 31b806ae2..88e6471b8 100644
--- a/tests/kms_scaling_modes.c
+++ b/tests/kms_scaling_modes.c
@@ -25,6 +25,26 @@
  */
 
 #include "igt.h"
+/**
+ * TEST: kms scaling modes
+ * Category: Display
+ * Description: Test display scaling modes
+ *
+ * SUBTEST: scaling-mode-%s
+ * Description: Tests %arg[1] display scaling mode
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @center:           center
+ * @full:             full
+ * @full-aspect:      full aspect
+ * @none:             none (no scaling)
+ */
 
 IGT_TEST_DESCRIPTION("Test display scaling modes");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 71/81] tests/kms_selftest: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

V2: - Fix the documentation for renamed tests

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_selftest.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/tests/kms_selftest.c b/tests/kms_selftest.c
index 5495c24f2..940fc3d8d 100644
--- a/tests/kms_selftest.c
+++ b/tests/kms_selftest.c
@@ -23,6 +23,29 @@
 
 #include "igt.h"
 #include "igt_kmod.h"
+/**
+ * TEST: kms selftest
+ * Category: Display
+ * Description: Basic sanity check of KMS selftests.
+ *
+ * SUBTEST: %s
+ * Description: Basic sanity check of KMS selftest %arg[1].
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @drm_cmdline:            drm cmdline
+ * @drm_damage:             drm damage
+ * @drm_dp_mst:             drm dp mst
+ * @drm_format_helper:      drm format helper
+ * @drm_format:             drm format
+ * @drm_plane:              drm plane
+ * @framebuffer:            framebuffer
+ */
 
 IGT_TEST_DESCRIPTION("Basic sanity check of KMS selftests.");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 72/81] tests/kms_sequence: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_sequence.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tests/kms_sequence.c b/tests/kms_sequence.c
index 1b96f0017..12c3396f5 100644
--- a/tests/kms_sequence.c
+++ b/tests/kms_sequence.c
@@ -27,6 +27,11 @@
  * This is a test of drmCrtcGetSequence and drmCrtcQueueSequence
  */
 
+/**
+ * TEST: kms sequence
+ * Category: Display
+ * Description: Test CrtcGetSequence and CrtcQueueSequence.
+ */
 #include "igt.h"
 #include <stdlib.h>
 #include <stdio.h>
@@ -136,6 +141,37 @@ static int crtc_queue_sequence(int fd, struct drm_crtc_queue_sequence *cqs)
 	return err;
 }
 
+/**
+ * SUBTEST: get-%s
+ * Description: This is a test of drmCrtcGetSequence and drmCrtcQueueSequence
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @busy:
+ * @forked:
+ * @forked-busy:
+ * @idle:
+ */
+
+/**
+ * SUBTEST: queue-%s
+ * Description: This is a test of drmCrtcGetSequence and drmCrtcQueueSequence
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @busy:
+ * @idle:
+ */
 static void run_test(data_t *data, int fd, void (*testfunc)(data_t *, int, int))
 {
 	int nchildren =
-- 
2.40.0

[igt-dev] [V5 i-g-t 73/81] tests/kms_setmode: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_setmode.c | 58 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 035bbd0b0..bce41fc3b 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -31,6 +31,64 @@
 #include <sys/time.h>
 #include <math.h>
 #include "xe/xe_query.h"
+/**
+ * TEST: kms setmode
+ * Category: Display
+ *
+ * SUBTEST: basic
+ * Description: Tests the mode by iterating through all valid/invalid crtc/connector
+ *              combinations
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: basic-clone-single-crtc
+ * Description: Tests the mode by iterating through all valid/invalid crtc/connector
+ *              combinations
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: clone-exclusive-crtc
+ * Description: Tests the mode by iterating through all valid/invalid crtc/connector
+ *              combinations
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid-clone-exclusive-crtc
+ * Description: Tests the mode by iterating through all valid/invalid crtc/connector
+ *              combinations
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid-clone-single-crtc
+ * Description: Tests the mode by iterating through all valid/invalid crtc/connector
+ *              combinations
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid-clone-single-crtc-stealing
+ * Description: Tests the mode by iterating through all valid/invalid crtc/connector
+ *              combinations
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 #define MAX_CONNECTORS  10
 #define MAX_CRTCS       6
-- 
2.40.0

[igt-dev] [V5 i-g-t 74/81] tests/kms_sysfs_edid_timing: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_sysfs_edid_timing.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 775211089..e185eaf6d 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -25,6 +25,27 @@
 #include <dirent.h>
 #include <fcntl.h>
 #include <sys/stat.h>
+/**
+ * TEST: kms sysfs edid timing
+ * Category: Display
+ * Description: This test checks the time it takes to reprobe each connector and
+ *              fails if either the time it takes for one reprobe is too long or
+ *              if the mean time it takes to reprobe one connector is too long.
+ *              Additionally, make sure that the mean time for all connectors is
+ *              not too long.
+ *
+ * SUBTEST:
+ * Description: This test checks the time it takes to reprobe each connector and
+ *              fails if either the time it takes for one reprobe is too long or
+ *              if the mean time it takes to reprobe one connector is too long.
+ *              Additionally, make sure that the mean time for all connectors is
+ *              not too long.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 #define THRESHOLD_PER_CONNECTOR		150
 #define THRESHOLD_PER_CONNECTOR_MEAN	140
-- 
2.40.0

[igt-dev] [V5 i-g-t 75/81] tests/kms_tv_load_detect: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_tv_load_detect.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/kms_tv_load_detect.c b/tests/kms_tv_load_detect.c
index c8e5338d2..ceefe26d2 100644
--- a/tests/kms_tv_load_detect.c
+++ b/tests/kms_tv_load_detect.c
@@ -23,6 +23,19 @@
  */
 
 #include "igt.h"
+/**
+ * TEST: kms tv load detect
+ * Category: Display
+ * Description: Check tv load detection works correctly.
+ *
+ * SUBTEST: load-detect
+ * Description: Check tv load detection works correctly.
+ * Driver requirement: any
+ * Functionality: obsolete
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION("Check tv load detection works correctly.");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 76/81] tests/kms_universal_plane: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_universal_plane.c | 67 +++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index 957d600f1..358b7ae18 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -28,6 +28,73 @@
 #include <string.h>
 #include <fcntl.h>
 
+/**
+ * TEST: kms universal plane
+ * Category: Display
+ *
+ * SUBTEST: cursor-fb-leak-pipe-%s
+ * Description: Check for cursor leaks after performing cursor operations
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: disable-primary-vs-flip-pipe-%s
+ * Description: Check pageflips while primary plane is disabled before IOCTL or
+ *              between IOCTL and pageflip execution
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: universal-plane-pageflip-windowed-pipe-%s
+ * Description: Check if pageflip succeeds in windowed setting
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @A:
+ * @B:
+ * @C:
+ * @D:
+ * @E:
+ * @F:
+ * @G:
+ * @H:
+ */
+
+/**
+ * SUBTEST: universal-plane-pipe-%s-%s
+ * Description: Check %arg[1]
+ * Driver requirement: any
+ * Functionality: plane
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @A:
+ * @B:
+ * @C:
+ * @D:
+ * @E:
+ * @F:
+ * @G:
+ * @H:
+ *
+ * arg[2]:
+ *
+ * @functional: the switching between different primary plane fbs with CRTC off
+ * @sanity:     for scale-up or scale-down using universal plane API without
+ *              covering CRTC
+ */
 
 typedef struct {
 	int drm_fd;
-- 
2.40.0

[igt-dev] [V5 i-g-t 77/81] tests/kms_vblank: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_vblank.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 1aa8c1083..86ff5fce8 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -40,6 +40,75 @@
 #include <sys/wait.h>
 
 #include <drm.h>
+/**
+ * TEST: kms vblank
+ * Category: Display
+ * Description: Test speed of WaitVblank.
+ *
+ * SUBTEST: crtc-id
+ * Description: check the Vblank and flip events works with given crtc id
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid
+ * Description: Negative test for vblank request
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: pipe-%s-%s
+ * Description: Check if test run while hanging by introducing NOHANG flag (or)
+ *              Check if injected hang is working properly
+ * Driver requirement: any
+ * Functionality: vblank
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * arg[1]:
+ *
+ * @A:
+ * @B:
+ * @C:
+ * @D:
+ * @E:
+ * @F:
+ * @G:
+ * @H:
+ *
+ * arg[2]:
+ *
+ * @accuracy-idle:
+ * @query-busy:
+ * @query-busy-hang:
+ * @query-forked:
+ * @query-forked-busy:
+ * @query-forked-busy-hang:
+ * @query-forked-hang:
+ * @query-idle:
+ * @query-idle-hang:
+ * @ts-continuation-dpms-rpm:
+ * @ts-continuation-dpms-suspend:
+ * @ts-continuation-idle:
+ * @ts-continuation-idle-hang:
+ * @ts-continuation-modeset:
+ * @ts-continuation-modeset-hang:
+ * @ts-continuation-modeset-rpm:
+ * @ts-continuation-suspend:
+ * @wait-busy:
+ * @wait-busy-hang:
+ * @wait-forked:
+ * @wait-forked-busy:
+ * @wait-forked-busy-hang:
+ * @wait-forked-hang:
+ * @wait-idle:
+ * @wait-idle-hang:
+ */
 
 IGT_TEST_DESCRIPTION("Test speed of WaitVblank.");
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 78/81] tests/kms_vrr: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_vrr.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 6a766bfb9..286f071e9 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -24,6 +24,53 @@
 #include "sw_sync.h"
 #include <fcntl.h>
 #include <signal.h>
+/**
+ * TEST: kms vrr
+ * Category: Display
+ *
+ * SUBTEST: flip-basic
+ * Description: Tests that VRR is enabled and that the difference between flip
+ *              timestamps converges to the requested rate
+ * Driver requirement: any
+ * Functionality: vrr
+ * Mega feature: VRR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-dpms
+ * Description: Tests with DPMS that VRR is enabled and that the difference
+ *              between flip timestamps converges to the requested rate.
+ * Driver requirement: any
+ * Functionality: vrr
+ * Mega feature: VRR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flip-suspend
+ * Description: Tests that VRR is enabled and that the difference between flip
+ *              timestamps converges to the requested rate in a suspend test
+ * Driver requirement: any
+ * Functionality: vrr
+ * Mega feature: VRR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: flipline
+ * Description: Make sure that flips happen at flipline decision boundary.
+ * Driver requirement: any
+ * Functionality: vrr
+ * Mega feature: VRR
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: negative-basic
+ * Description: Make sure that VRR should not be enabled on the Non-VRR panel.
+ * Driver requirement: any
+ * Functionality: vrr
+ * Mega feature: VRR
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 #define NSECS_PER_SEC (1000000000ull)
 
-- 
2.40.0

[igt-dev] [V5 i-g-t 79/81] tests/kms_writeback: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_writeback.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index db1f0884f..8c6f3fdc3 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -32,6 +32,48 @@
 #include "igt_core.h"
 #include "igt_fb.h"
 #include "sw_sync.h"
+/**
+ * TEST: kms writeback
+ * Category: Display
+ * Description: This test validates the expected behavior of the writeback
+ *              connectors feature by checking if the target device support
+ *              writeback; it validates bad and good combination, check color
+ *              format, and check the output result by using CRC.
+ *
+ * SUBTEST: writeback-check-output
+ * Description: Check writeback output with CRC validation
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: writeback-fb-id
+ * Description: Validate WRITEBACK_FB_ID with valid and invalid options
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: writeback-invalid-parameters
+ * Description: Writeback has a couple of parameters linked together(output
+ *              framebuffer and fence); this test goes throughthe combination
+ *              of possible bad options
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: writeback-pixel-formats
+ * Description: Check the writeback format
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 
 IGT_TEST_DESCRIPTION(
    "This test validates the expected behavior of the writeback connectors "
-- 
2.40.0

[igt-dev] [V5 i-g-t 80/81] tests/testdisplay: Document each subtest for testplan

[Bhanuprakash Modem]

Add documentation for all kms tests which is used by IGT testplan
documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/testdisplay.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/testdisplay.c b/tests/testdisplay.c
index 294d4c604..2a88eb64e 100644
--- a/tests/testdisplay.c
+++ b/tests/testdisplay.c
@@ -69,6 +69,19 @@
 #include <stdlib.h>
 #include <signal.h>
 
+/**
+ * TEST: testdisplay
+ * Category: Display
+ * Description: Tests basic display functionality.
+ *
+ * SUBTEST:
+ * Description: Tests basic display functionality.
+ * Driver requirement: any
+ * Functionality: kms_core
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
 IGT_TEST_DESCRIPTION("Tests basic display functionality.");
 
 enum {
-- 
2.40.0

[igt-dev] [V5 i-g-t 81/81] testplan/kms: Make documentation is mandatory for all kms subtests

[Bhanuprakash Modem]

As testplan documentation is ready for all kms tests, update the
testplan config to make sure we are not missing the documentation
all the kms tests.

V2, V3, V4, V5: - Rebase

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 docs/testplan/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
index bf73dd32a..8b8ee5abd 100644
--- a/docs/testplan/meson.build
+++ b/docs/testplan/meson.build
@@ -31,13 +31,13 @@ xe_test_dict = {
 if build_xe
 	test_dict = {
 		'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
-		'kms_tests': { 'input': kms_test_config, 'extra_args': [] },
+		'kms_tests': { 'input': kms_test_config, 'extra_args': check_testlist },
 		'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist }
 	    }
 else
 	test_dict = {
 	      'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
-	      'kms_tests': { 'input': kms_test_config, 'extra_args': [] }
+	      'kms_tests': { 'input': kms_test_config, 'extra_args': check_testlist }
 	    }
 endif
 
-- 
2.40.0

[igt-dev] ✓ Fi.CI.BAT: success for Document KMS tests (rev12)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 11813 bytes --]

== Series Details ==

Series: Document KMS tests (rev12)
URL   : https://patchwork.freedesktop.org/series/117749/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13336 -> IGTPW_9303
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/index.html

Participating hosts (41 -> 42)
------------------------------

  Additional (2): fi-kbl-soraka bat-dg1-8 
  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_9303:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@xe_create@create-massive-size}:
    - {bat-dg1-8}:        NOTRUN -> [FAIL][1] +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-dg1-8/igt@xe_create@create-massive-size.html

  * igt@xe_guc_pc@rc6_on_idle:
    - {bat-dg1-8}:        NOTRUN -> [INCOMPLETE][2] +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-dg1-8/igt@xe_guc_pc@rc6_on_idle.html

  
Known issues
------------

  Here are the changes found in IGTPW_9303 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s0@smem:
    - bat-jsl-3:          [PASS][3] -> [ABORT][4] ([i915#5122])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - bat-mtlp-8:         NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@i915_pm_rps@basic-api:
    - bat-mtlp-8:         NOTRUN -> [SKIP][8] ([i915#6621])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-8:         NOTRUN -> [DMESG-FAIL][9] ([i915#7059])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][10] ([i915#1886] / [i915#7913])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@migrate:
    - bat-dg2-11:         [PASS][11] -> [DMESG-WARN][12] ([i915#7699])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-dg2-11/igt@i915_selftest@live@migrate.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-dg2-11/igt@i915_selftest@live@migrate.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-2:         [PASS][13] -> [ABORT][14] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-rpls-2/igt@i915_selftest@live@reset.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-rpls-2/igt@i915_selftest@live@reset.html

  * igt@i915_selftest@live@slpc:
    - bat-mtlp-8:         NOTRUN -> [DMESG-WARN][15] ([i915#6367])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@i915_selftest@live@slpc.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-jsl-3:          [PASS][16] -> [FAIL][17] ([fdo#103375])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][18] ([i915#6645])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-mtlp-8:         NOTRUN -> [SKIP][19] ([i915#7828])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
    - bat-jsl-1:          NOTRUN -> [SKIP][20] ([i915#7828])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-jsl-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
    - fi-bsw-n3050:       NOTRUN -> [SKIP][21] ([fdo#109271])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/fi-bsw-n3050/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][22] ([fdo#109271]) +14 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/fi-kbl-soraka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_psr@primary_page_flip:
    - bat-rplp-1:         NOTRUN -> [SKIP][23] ([i915#1072]) +3 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-rplp-1/igt@kms_psr@primary_page_flip.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-rplp-1:         NOTRUN -> [ABORT][24] ([i915#4579] / [i915#8260] / [i915#8668])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
    - fi-kbl-soraka:      NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4579])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-read:
    - bat-mtlp-8:         NOTRUN -> [SKIP][26] ([i915#3708]) +2 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-gtt:
    - bat-mtlp-8:         NOTRUN -> [SKIP][27] ([i915#3708] / [i915#4077]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@prime_vgem@basic-gtt.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - bat-mtlp-8:         [ABORT][28] ([i915#7077] / [i915#7977]) -> [PASS][29]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_selftest@live@execlists:
    - fi-bsw-n3050:       [ABORT][30] ([i915#7911] / [i915#7913]) -> [PASS][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/fi-bsw-n3050/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@gt_heartbeat:
    - bat-jsl-3:          [DMESG-FAIL][32] ([i915#5334]) -> [PASS][33]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-jsl-3/igt@i915_selftest@live@gt_heartbeat.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-jsl-3/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@gt_pm:
    - bat-rpls-2:         [DMESG-FAIL][34] ([i915#4258] / [i915#7913]) -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-rpls-2/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@migrate:
    - bat-jsl-1:          [INCOMPLETE][36] -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-jsl-1/igt@i915_selftest@live@migrate.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-jsl-1/igt@i915_selftest@live@migrate.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
    - bat-rplp-1:         [ABORT][38] ([i915#8442] / [i915#8668]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
  [i915#8513]: https://gitlab.freedesktop.org/drm/intel/issues/8513
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8676]: https://gitlab.freedesktop.org/drm/intel/issues/8676
  [i915#8698]: https://gitlab.freedesktop.org/drm/intel/issues/8698
  [i915#8700]: https://gitlab.freedesktop.org/drm/intel/issues/8700


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7356 -> IGTPW_9303

  CI-20190529: 20190529
  CI_DRM_13336: 1423126050a5bb0317e86e61395e4413e0ad013b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9303: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/index.html
  IGT_7356: 66452bb0118e8d3a78d054cef50a60a9858a00a9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/index.html

[-- Attachment #2: Type: text/html, Size: 13235 bytes --]

[igt-dev] ✓ Fi.CI.IGT: success for Document KMS tests (rev12)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 41660 bytes --]

== Series Details ==

Series: Document KMS tests (rev12)
URL   : https://patchwork.freedesktop.org/series/117749/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13336_full -> IGTPW_9303_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/index.html

Participating hosts (8 -> 8)
------------------------------

  No changes in participating hosts

New tests
---------

  New tests have been introduced between CI_DRM_13336_full and IGTPW_9303_full:

### New IGT tests (8) ###

  * igt@kms_cursor_crc@cursor-dpms@pipe-a-hdmi-a-3:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@cursor-dpms@pipe-d-hdmi-a-3:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-3:
    - Statuses : 1 fail(s) 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-3:
    - Statuses : 2 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@read-crc@pipe-a-hdmi-a-3:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@read-crc@pipe-b-hdmi-a-3:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@read-crc@pipe-c-hdmi-a-3:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@read-crc@pipe-d-hdmi-a-3:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_9303_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_bad_reloc@negative-reloc-bltcopy:
    - shard-rkl:          NOTRUN -> [SKIP][1] ([i915#3281])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@gem_bad_reloc@negative-reloc-bltcopy.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - shard-tglu:         [PASS][2] -> [FAIL][3] ([i915#6268])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-tglu-10/igt@gem_ctx_exec@basic-nohangcheck.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-tglu-7/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_ctx_isolation@preservation-s3@bcs0:
    - shard-rkl:          [PASS][4] -> [FAIL][5] ([fdo#103375]) +2 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-4/igt@gem_ctx_isolation@preservation-s3@bcs0.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@gem_ctx_isolation@preservation-s3@bcs0.html

  * igt@gem_ctx_isolation@preservation-s3@ccs1:
    - shard-dg2:          [PASS][6] -> [FAIL][7] ([fdo#103375]) +2 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-11/igt@gem_ctx_isolation@preservation-s3@ccs1.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@gem_ctx_isolation@preservation-s3@ccs1.html

  * igt@gem_ctx_persistence@engines-hostile:
    - shard-snb:          NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb6/igt@gem_ctx_persistence@engines-hostile.html

  * igt@gem_ctx_persistence@heartbeat-hostile:
    - shard-dg2:          NOTRUN -> [SKIP][9] ([i915#8555])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@gem_ctx_persistence@heartbeat-hostile.html

  * igt@gem_eio@kms:
    - shard-dg2:          [PASS][10] -> [FAIL][11] ([i915#5784])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-11/igt@gem_eio@kms.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@gem_eio@kms.html

  * igt@gem_exec_balancer@parallel-ordering:
    - shard-rkl:          NOTRUN -> [SKIP][12] ([i915#4525])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-2/igt@gem_exec_balancer@parallel-ordering.html

  * igt@gem_exec_fair@basic-none-share:
    - shard-dg2:          NOTRUN -> [SKIP][13] ([i915#3539] / [i915#4852])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@gem_exec_fair@basic-none-share.html

  * igt@gem_exec_fair@basic-none@vecs0:
    - shard-rkl:          [PASS][14] -> [FAIL][15] ([i915#2842]) +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-1/igt@gem_exec_fair@basic-none@vecs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-2/igt@gem_exec_fair@basic-none@vecs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglu:         [PASS][16] -> [FAIL][17] ([i915#2842])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-tglu-7/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-tglu-4/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-glk:          [PASS][18] -> [FAIL][19] ([i915#2842]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-glk3/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_reloc@basic-gtt-read:
    - shard-dg2:          NOTRUN -> [SKIP][20] ([i915#3281]) +5 similar issues
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-8/igt@gem_exec_reloc@basic-gtt-read.html

  * igt@gem_lmem_swapping@random:
    - shard-apl:          NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl1/igt@gem_lmem_swapping@random.html

  * igt@gem_lmem_swapping@smem-oom@lmem0:
    - shard-dg2:          [PASS][22] -> [TIMEOUT][23] ([i915#5493])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-3/igt@gem_lmem_swapping@smem-oom@lmem0.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-7/igt@gem_lmem_swapping@smem-oom@lmem0.html

  * igt@gem_mmap_gtt@fault-concurrent-y:
    - shard-dg2:          NOTRUN -> [SKIP][24] ([i915#4077]) +2 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-6/igt@gem_mmap_gtt@fault-concurrent-y.html
    - shard-snb:          [PASS][25] -> [ABORT][26] ([i915#5161])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-snb5/igt@gem_mmap_gtt@fault-concurrent-y.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb5/igt@gem_mmap_gtt@fault-concurrent-y.html

  * igt@gem_partial_pwrite_pread@writes-after-reads-display:
    - shard-dg2:          NOTRUN -> [SKIP][27] ([i915#3282]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-8/igt@gem_partial_pwrite_pread@writes-after-reads-display.html
    - shard-rkl:          NOTRUN -> [SKIP][28] ([i915#3282])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-6/igt@gem_partial_pwrite_pread@writes-after-reads-display.html

  * igt@gem_ppgtt@blt-vs-render-ctxn:
    - shard-snb:          [PASS][29] -> [DMESG-FAIL][30] ([i915#8186] / [i915#8295])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctxn.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctxn.html

  * igt@gem_userptr_blits@invalid-mmap-offset-unsync:
    - shard-dg2:          NOTRUN -> [SKIP][31] ([i915#3297])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-3/igt@gem_userptr_blits@invalid-mmap-offset-unsync.html

  * igt@gen3_mixed_blits:
    - shard-dg2:          NOTRUN -> [SKIP][32] ([fdo#109289]) +3 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@gen3_mixed_blits.html
    - shard-rkl:          NOTRUN -> [SKIP][33] ([fdo#109289]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@gen3_mixed_blits.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-apl:          [PASS][34] -> [ABORT][35] ([i915#5566])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-apl1/igt@gen9_exec_parse@allowed-single.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl1/igt@gen9_exec_parse@allowed-single.html

  * igt@gen9_exec_parse@valid-registers:
    - shard-dg2:          NOTRUN -> [SKIP][36] ([i915#2856])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-10/igt@gen9_exec_parse@valid-registers.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-dg2:          NOTRUN -> [WARN][37] ([i915#6596] / [i915#7356])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_backlight@basic-brightness:
    - shard-dg2:          NOTRUN -> [SKIP][38] ([i915#5354] / [i915#7561])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-1/igt@i915_pm_backlight@basic-brightness.html
    - shard-rkl:          NOTRUN -> [SKIP][39] ([i915#7561])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-1/igt@i915_pm_backlight@basic-brightness.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [PASS][40] -> [SKIP][41] ([fdo#109271])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl3/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_freq_api@freq-reset:
    - shard-tglu:         NOTRUN -> [SKIP][42] ([i915#8399])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-tglu-4/igt@i915_pm_freq_api@freq-reset.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-dg2:          [PASS][43] -> [SKIP][44] ([i915#1937] / [i915#4579])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-12/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
    - shard-rkl:          [PASS][45] -> [SKIP][46] ([i915#1937] / [i915#4579])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga:
    - shard-snb:          NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#4579]) +13 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga.html

  * igt@i915_pm_rpm@dpms-non-lpsp:
    - shard-rkl:          [PASS][48] -> [SKIP][49] ([i915#1397]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-4/igt@i915_pm_rpm@dpms-non-lpsp.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html

  * igt@i915_pm_rpm@modeset-lpsp:
    - shard-rkl:          NOTRUN -> [SKIP][50] ([i915#1397])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp.html

  * igt@i915_pm_rps@reset:
    - shard-snb:          [PASS][51] -> [INCOMPLETE][52] ([i915#7790])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-snb2/igt@i915_pm_rps@reset.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb4/igt@i915_pm_rps@reset.html

  * igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling:
    - shard-dg2:          NOTRUN -> [SKIP][53] ([i915#4212]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-3/igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling.html

  * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][54] ([i915#8502]) +3 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs.html

  * igt@kms_big_fb@4-tiled-addfb:
    - shard-rkl:          NOTRUN -> [SKIP][55] ([i915#5286]) +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@kms_big_fb@4-tiled-addfb.html

  * igt@kms_big_fb@yf-tiled-addfb-size-overflow:
    - shard-dg2:          NOTRUN -> [SKIP][56] ([i915#5190]) +3 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_big_fb@yf-tiled-addfb-size-overflow.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
    - shard-rkl:          NOTRUN -> [SKIP][57] ([fdo#110723])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - shard-dg2:          NOTRUN -> [SKIP][58] ([i915#4538] / [i915#5190]) +1 similar issue
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_rc_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][59] ([i915#5354] / [i915#6095]) +1 similar issue
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-1/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_rc_ccs.html

  * igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs:
    - shard-dg2:          NOTRUN -> [SKIP][60] ([i915#3689] / [i915#5354]) +3 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
    - shard-apl:          NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#3886])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl6/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][62] ([i915#3734] / [i915#5354] / [i915#6095])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_ccs.html

  * igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_mtl_mc_ccs:
    - shard-dg2:          NOTRUN -> [SKIP][63] ([i915#5354]) +17 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-8/igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_mtl_mc_ccs.html

  * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
    - shard-dg2:          NOTRUN -> [SKIP][64] ([i915#3689] / [i915#3886] / [i915#5354]) +5 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-8/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][65] ([i915#5354]) +5 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-6/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_mc_ccs.html

  * igt@kms_cdclk@mode-transition@pipe-a-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][66] ([i915#4087]) +5 similar issues
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_cdclk@mode-transition@pipe-a-dp-4.html

  * igt@kms_cdclk@mode-transition@pipe-d-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][67] ([i915#4087] / [i915#4579]) +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_cdclk@mode-transition@pipe-d-dp-4.html

  * igt@kms_chamelium_color@ctm-max:
    - shard-dg2:          NOTRUN -> [SKIP][68] ([fdo#111827])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@kms_chamelium_color@ctm-max.html

  * igt@kms_chamelium_hpd@dp-hpd-after-suspend:
    - shard-dg2:          NOTRUN -> [SKIP][69] ([i915#7828])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-7/igt@kms_chamelium_hpd@dp-hpd-after-suspend.html
    - shard-rkl:          NOTRUN -> [SKIP][70] ([i915#7828])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-6/igt@kms_chamelium_hpd@dp-hpd-after-suspend.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-dg2:          NOTRUN -> [SKIP][71] ([i915#4579] / [i915#7118])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-6/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@lic@pipe-a-dp-4:
    - shard-dg2:          NOTRUN -> [TIMEOUT][72] ([i915#7173]) +1 similar issue
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_content_protection@lic@pipe-a-dp-4.html

  * igt@kms_content_protection@uevent@pipe-a-dp-2:
    - shard-dg2:          NOTRUN -> [FAIL][73] ([i915#1339])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@kms_content_protection@uevent@pipe-a-dp-2.html

  * igt@kms_cursor_crc@cursor-rapid-movement-32x10:
    - shard-apl:          NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#4579])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl6/igt@kms_cursor_crc@cursor-rapid-movement-32x10.html

  * igt@kms_cursor_crc@cursor-rapid-movement-512x170:
    - shard-dg2:          NOTRUN -> [SKIP][75] ([i915#3359])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_cursor_crc@cursor-rapid-movement-512x170.html

  * igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-3 (NEW):
    - shard-dg2:          NOTRUN -> [FAIL][76] ([fdo#103375])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-3.html

  * igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
    - shard-dg2:          NOTRUN -> [SKIP][77] ([fdo#109274] / [i915#5354])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
    - shard-rkl:          NOTRUN -> [SKIP][78] ([fdo#111825]) +2 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [PASS][79] -> [FAIL][80] ([i915#2346])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-glk:          [PASS][81] -> [FAIL][82] ([i915#2346])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_flip@2x-flip-vs-blocking-wf-vblank:
    - shard-snb:          NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111767]) +1 similar issue
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb7/igt@kms_flip@2x-flip-vs-blocking-wf-vblank.html

  * igt@kms_flip@2x-flip-vs-panning-interruptible:
    - shard-dg2:          NOTRUN -> [SKIP][84] ([fdo#109274]) +1 similar issue
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-10/igt@kms_flip@2x-flip-vs-panning-interruptible.html

  * igt@kms_flip@2x-nonexisting-fb:
    - shard-apl:          NOTRUN -> [SKIP][85] ([fdo#109271]) +15 similar issues
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl3/igt@kms_flip@2x-nonexisting-fb.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
    - shard-tglu:         NOTRUN -> [SKIP][86] ([i915#2587] / [i915#2672] / [i915#4579])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-tglu-6/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-valid-mode:
    - shard-dg2:          NOTRUN -> [SKIP][87] ([i915#2672] / [i915#4579])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-valid-mode.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
    - shard-rkl:          NOTRUN -> [SKIP][88] ([i915#3023]) +1 similar issue
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-wc:
    - shard-dg2:          NOTRUN -> [SKIP][89] ([i915#8708]) +5 similar issues
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-blt:
    - shard-rkl:          NOTRUN -> [SKIP][90] ([fdo#111825] / [i915#1825]) +7 similar issues
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
    - shard-dg2:          NOTRUN -> [SKIP][91] ([i915#3458]) +5 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
    - shard-tglu:         NOTRUN -> [SKIP][92] ([fdo#110189])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-tglu-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite.html

  * igt@kms_hdr@static-toggle:
    - shard-dg2:          NOTRUN -> [SKIP][93] ([i915#3555] / [i915#4579]) +4 similar issues
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-8/igt@kms_hdr@static-toggle.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][94] ([i915#5176]) +2 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][95] ([i915#4579] / [i915#5176]) +2 similar issues
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-2.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][96] ([i915#4579] / [i915#5176]) +2 similar issues
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-dp-4.html

  * igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3:
    - shard-dg2:          NOTRUN -> [SKIP][97] ([i915#5176]) +8 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3.html

  * igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1:
    - shard-snb:          NOTRUN -> [SKIP][98] ([fdo#109271]) +44 similar issues
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb7/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-dp-2:
    - shard-dg2:          NOTRUN -> [SKIP][99] ([i915#5235]) +14 similar issues
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-dp-2.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][100] ([i915#4579] / [i915#5235]) +1 similar issue
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-dp-4:
    - shard-dg2:          NOTRUN -> [SKIP][101] ([i915#4579] / [i915#5235]) +4 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-dp-4.html

  * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][102] ([i915#5235]) +1 similar issue
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1.html

  * igt@kms_psr2_su@frontbuffer-xrgb8888:
    - shard-dg2:          NOTRUN -> [SKIP][103] ([i915#658])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-7/igt@kms_psr2_su@frontbuffer-xrgb8888.html

  * igt@kms_psr@suspend:
    - shard-dg2:          NOTRUN -> [SKIP][104] ([i915#1072])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@kms_psr@suspend.html

  * igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
    - shard-dg2:          NOTRUN -> [SKIP][105] ([i915#4235])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html

  * igt@kms_tv_load_detect@load-detect:
    - shard-dg2:          NOTRUN -> [SKIP][106] ([fdo#109309])
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-6/igt@kms_tv_load_detect@load-detect.html

  * igt@kms_vblank@pipe-c-query-busy:
    - shard-rkl:          NOTRUN -> [SKIP][107] ([i915#4070] / [i915#6768])
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-2/igt@kms_vblank@pipe-c-query-busy.html

  * igt@kms_vrr@flipline:
    - shard-rkl:          NOTRUN -> [SKIP][108] ([i915#3555] / [i915#4579]) +1 similar issue
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_vrr@flipline.html

  * igt@perf_pmu@rc6@other-idle-gt0:
    - shard-dg2:          NOTRUN -> [SKIP][109] ([i915#8516])
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@perf_pmu@rc6@other-idle-gt0.html

  * igt@prime_vgem@basic-fence-read:
    - shard-dg2:          NOTRUN -> [SKIP][110] ([i915#3291] / [i915#3708])
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@prime_vgem@basic-fence-read.html
    - shard-rkl:          NOTRUN -> [SKIP][111] ([fdo#109295] / [i915#3291] / [i915#3708])
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@prime_vgem@basic-fence-read.html

  * igt@v3d/v3d_perfmon@create-perfmon-exceed:
    - shard-tglu:         NOTRUN -> [SKIP][112] ([fdo#109315] / [i915#2575])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-tglu-4/igt@v3d/v3d_perfmon@create-perfmon-exceed.html

  * igt@v3d/v3d_submit_cl@bad-multisync-extension:
    - shard-rkl:          NOTRUN -> [SKIP][113] ([fdo#109315])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@v3d/v3d_submit_cl@bad-multisync-extension.html

  * igt@v3d/v3d_submit_cl@simple-flush-cache:
    - shard-dg2:          NOTRUN -> [SKIP][114] ([i915#2575]) +2 similar issues
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@v3d/v3d_submit_cl@simple-flush-cache.html

  * igt@vc4/vc4_dmabuf_poll@poll-read-waits-until-write-done:
    - shard-rkl:          NOTRUN -> [SKIP][115] ([i915#7711])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-4/igt@vc4/vc4_dmabuf_poll@poll-read-waits-until-write-done.html

  * igt@vc4/vc4_perfmon@get-values-invalid-perfmon:
    - shard-dg2:          NOTRUN -> [SKIP][116] ([i915#7711]) +2 similar issues
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-10/igt@vc4/vc4_perfmon@get-values-invalid-perfmon.html

  
#### Possible fixes ####

  * igt@gem_barrier_race@remote-request@rcs0:
    - shard-apl:          [ABORT][117] ([i915#7461] / [i915#8211] / [i915#8234]) -> [PASS][118]
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-apl4/igt@gem_barrier_race@remote-request@rcs0.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-apl3/igt@gem_barrier_race@remote-request@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-rkl:          [FAIL][119] ([i915#2842]) -> [PASS][120]
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_softpin@noreloc-s3:
    - shard-dg2:          [FAIL][121] ([fdo#103375]) -> [PASS][122] +1 similar issue
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-5/igt@gem_softpin@noreloc-s3.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-12/igt@gem_softpin@noreloc-s3.html

  * igt@i915_module_load@reload:
    - shard-snb:          [ABORT][123] ([i915#4528]) -> [PASS][124]
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-snb6/igt@i915_module_load@reload.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-snb5/igt@i915_module_load@reload.html

  * igt@i915_pm_rpm@dpms-mode-unset-lpsp:
    - {shard-dg1}:        [SKIP][125] ([i915#1397]) -> [PASS][126]
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg1-12/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg1-19/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html

  * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
    - shard-dg2:          [SKIP][127] ([i915#1397]) -> [PASS][128] +2 similar issues
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-10/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-8/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
    - shard-rkl:          [FAIL][129] ([i915#3743]) -> [PASS][130]
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
    - shard-dg2:          [FAIL][131] ([i915#6880]) -> [PASS][132]
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html

  * igt@kms_hdmi_inject@inject-audio:
    - shard-tglu:         [SKIP][133] ([i915#433]) -> [PASS][134]
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-tglu-3/igt@kms_hdmi_inject@inject-audio.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-tglu-10/igt@kms_hdmi_inject@inject-audio.html

  * igt@perf_pmu@busy-double-start@vecs0:
    - {shard-dg1}:        [FAIL][135] ([i915#4349]) -> [PASS][136] +2 similar issues
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg1-16/igt@perf_pmu@busy-double-start@vecs0.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg1-17/igt@perf_pmu@busy-double-start@vecs0.html

  
#### Warnings ####

  * igt@kms_content_protection@mei_interface:
    - shard-dg2:          [SKIP][137] ([i915#4579] / [i915#7118]) -> [SKIP][138] ([i915#4579] / [i915#7118] / [i915#7162]) +1 similar issue
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-1/igt@kms_content_protection@mei_interface.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-11/igt@kms_content_protection@mei_interface.html

  * igt@kms_fbcon_fbt@psr:
    - shard-rkl:          [SKIP][139] ([i915#3955]) -> [SKIP][140] ([fdo#110189] / [i915#3955])
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-4/igt@kms_fbcon_fbt@psr.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-2/igt@kms_fbcon_fbt@psr.html

  * igt@kms_force_connector_basic@force-load-detect:
    - shard-rkl:          [SKIP][141] ([fdo#109285] / [i915#4098]) -> [SKIP][142] ([fdo#109285])
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-2/igt@kms_force_connector_basic@force-load-detect.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-rkl:          [SKIP][143] ([i915#4070] / [i915#4816]) -> [SKIP][144] ([i915#4816])
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-rkl-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-rkl-7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
    - shard-dg2:          [CRASH][145] ([i915#7331]) -> [INCOMPLETE][146] ([i915#5493])
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13336/shard-dg2-6/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/shard-dg2-8/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
  [i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6596]: https://gitlab.freedesktop.org/drm/intel/issues/6596
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
  [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
  [i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
  [i915#7356]: https://gitlab.freedesktop.org/drm/intel/issues/7356
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#8186]: https://gitlab.freedesktop.org/drm/intel/issues/8186
  [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
  [i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
  [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
  [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
  [i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
  [i915#8399]: https://gitlab.freedesktop.org/drm/intel/issues/8399
  [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
  [i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
  [i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
  [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
  [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
  [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7356 -> IGTPW_9303
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_13336: 1423126050a5bb0317e86e61395e4413e0ad013b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9303: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/index.html
  IGT_7356: 66452bb0118e8d3a78d054cef50a60a9858a00a9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9303/index.html

[-- Attachment #2: Type: text/html, Size: 49404 bytes --]

Re: [igt-dev] [V5 i-g-t 56/81] tests/kms_multipipe_modeset: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_multipipe_modeset.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/tests/kms_multipipe_modeset.c b/tests/kms_multipipe_modeset.c
> index 1fdfb9a9f..a06a6c4b5 100644
> --- a/tests/kms_multipipe_modeset.c
> +++ b/tests/kms_multipipe_modeset.c
> @@ -25,6 +25,20 @@
>    */
>   
>   #include "igt.h"
> +/**
> + * TEST: kms multipipe modeset
> + * Category: Display
> + * Description: Test simultaneous modeset on all the supported pipes
> + *
> + * SUBTEST: basic-max-pipe-crc-check
> + * Description: Verify if simultaneous modesets on all the supported pipes is
> + *              successful. Validate using CRC verification
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Test simultaneous modeset on all the supported pipes");
>   

Re: [igt-dev] [V5 i-g-t 47/81] tests/kms_dp_tiled_display: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_tiled_display.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/tests/kms_tiled_display.c b/tests/kms_tiled_display.c
> index eba1b2764..4652ef4e4 100644
> --- a/tests/kms_tiled_display.c
> +++ b/tests/kms_tiled_display.c
> @@ -36,12 +36,33 @@
>    * the displays supported by the kernel at the moment.
>    */
>   
> +/**
> + * TEST: kms dp tiled display
> + * Category: Display
> + * Description: Test for Transcoder Port Sync for Display Port Tiled Displays
> + */
>   #include "igt.h"
>   #include "poll.h"
>   #include "drm_mode.h"
>   #include "drm_fourcc.h"
>   #include "igt_edid.h"
>   
> +/**
> + * SUBTEST: basic-test-%s
> + * Description: Make sure the Tiled CRTCs are synchronized and we get page flips
> + *              for all tiled CRTCs in one vblank (%arg[1]).
> + * Driver requirement: any
> + * Functionality: tiled_display
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @pattern:                  executes on real panel
> + * @pattern-with-chamelium:   executes on chamelium.
> + */
> +
>   IGT_TEST_DESCRIPTION("Test for genlocked CRTCs with tiled displays");
>   
>   typedef struct {

Re: [igt-dev] [V5 i-g-t 33/81] tests/kms_async_flips: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_async_flips.c | 62 +++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 62 insertions(+)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 0a1199158..73021e800 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -25,6 +25,11 @@
>    *  Karthik B S <karthik.b.s@intel.com>
>    */
>   
> +/**
> + * TEST: kms async flips
> + * Category: Display
> + * Description: Test asynchronous page flips.
> + */
>   #include "igt.h"
>   #include "igt_aux.h"
>   #include "igt_psr.h"
> @@ -197,6 +202,25 @@ static void test_init_fbs(data_t *data)
>   	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
>   }
>   
> +/**
> + * SUBTEST: alternate-sync-async-flip
> + * Description: Verify the async flip functionality and the fps during async flips
> + *              Alternate between sync and async flips
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: async-flip-with-page-flip-events
> + * Description: Verify the async flip functionality and the fps during async flips
> + *              Wait for page flip events in between successive asynchronous flips
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_async_flip(data_t *data)
>   {
>   	int ret, frame;
> @@ -292,6 +316,17 @@ static void wait_for_vblank(data_t *data, unsigned long *vbl_time, unsigned int
>   	*seq = wait_vbl.reply.sequence;
>   }
>   
> +/**
> + * SUBTEST: test-time-stamp
> + * Description: Verify the async flip functionality and the fps during async flips
> + *              Verify that the async flip timestamp does not coincide with either
> + *              previous or next vblank
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_timestamp(data_t *data)
>   {
>   	int flags = DRM_MODE_PAGE_FLIP_ASYNC | DRM_MODE_PAGE_FLIP_EVENT;
> @@ -336,6 +371,15 @@ static void test_timestamp(data_t *data)
>   		     "Async flip time stamp is expected to be in between 2 vblank time stamps\n");
>   }
>   
> +/**
> + * SUBTEST: test-cursor
> + * Description: Verify that the DRM_IOCTL_MODE_CURSOR passes after async flip
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_cursor(data_t *data)
>   {
>   	int flags = DRM_MODE_PAGE_FLIP_ASYNC | DRM_MODE_PAGE_FLIP_EVENT;
> @@ -488,6 +532,15 @@ static unsigned int clock_ms(void)
>   	return ts.tv_sec * 1000 + ts.tv_nsec / 1000000;
>   }
>   
> +/**
> + * SUBTEST: crc
> + * Description: Use CRC to verify async flip scans out the correct framebuffer
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_crc(data_t *data)
>   {
>   	unsigned int frame = 0;
> @@ -550,6 +603,15 @@ static void test_crc(data_t *data)
>   	igt_assert_lt(data->frame_count * 2, data->flip_count);
>   }
>   
> +/**
> + * SUBTEST: invalid-async-flip
> + * Description: Negative case to verify if changes in fb are rejected from kernel as expected
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void run_test(data_t *data, void (*test)(data_t *))
>   {
>   	igt_display_t *display = &data->display;

Re: [igt-dev] [V5 i-g-t 65/81] tests/kms_prime: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_prime.c | 35 +++++++++++++++++++++++++++++++++++
>   1 file changed, 35 insertions(+)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c
> index 52f587961..3e46aafb9 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -30,6 +30,41 @@
>   #include <sys/ioctl.h>
>   #include <sys/poll.h>
>   #include <time.h>
> +/**
> + * TEST: kms prime
> + * Category: Display
> + * Description: Prime tests, focusing on KMS side
> + *
> + * SUBTEST: D3hot
> + * Description: Validate pci state of dGPU when dGPU is idle and  scanout is on iGPU
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: basic-modeset-hybrid
> + * Description: Basic modeset on the one device when the other device is active
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: basic-crc-%s
> + * Description: Make a dumb color buffer, export to another device and compare
> + *              the CRCs with a buffer native to that device
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @hybrid:
> + * @vgem:
> + */
>   
>   #define KMS_HELPER "/sys/module/drm_kms_helper/parameters/"
>   #define KMS_POLL_DISABLE 0

Re: [igt-dev] [V5 i-g-t 47/81] tests/kms_dp_tiled_display: Document each subtest for testplan

[Karthik B S]

Just noticed that there is a small error on the subject line. 
'kms_dp_tiled_display -> kms_tiled_display'. Please update this before 
merging.

Thanks,
Karthik.B.S

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_tiled_display.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/tests/kms_tiled_display.c b/tests/kms_tiled_display.c
> index eba1b2764..4652ef4e4 100644
> --- a/tests/kms_tiled_display.c
> +++ b/tests/kms_tiled_display.c
> @@ -36,12 +36,33 @@
>    * the displays supported by the kernel at the moment.
>    */
>   
> +/**
> + * TEST: kms dp tiled display
> + * Category: Display
> + * Description: Test for Transcoder Port Sync for Display Port Tiled Displays
> + */
>   #include "igt.h"
>   #include "poll.h"
>   #include "drm_mode.h"
>   #include "drm_fourcc.h"
>   #include "igt_edid.h"
>   
> +/**
> + * SUBTEST: basic-test-%s
> + * Description: Make sure the Tiled CRTCs are synchronized and we get page flips
> + *              for all tiled CRTCs in one vblank (%arg[1]).
> + * Driver requirement: any
> + * Functionality: tiled_display
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @pattern:                  executes on real panel
> + * @pattern-with-chamelium:   executes on chamelium.
> + */
> +
>   IGT_TEST_DESCRIPTION("Test for genlocked CRTCs with tiled displays");
>   
>   typedef struct {

Re: [igt-dev] [V5 i-g-t 49/81] tests/kms_flip_event_leak: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_flip_event_leak.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
>
> diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c
> index 423ce40df..a1b614771 100644
> --- a/tests/kms_flip_event_leak.c
> +++ b/tests/kms_flip_event_leak.c
> @@ -30,6 +30,25 @@
>   
>   #include "igt_device.h"
>   #include "xe/xe_query.h"
> +/**
> + * TEST: kms flip event leak
> + * Category: Display
> + * Description: This test tries to provoke the kernel into leaking a pending
> + *              page flip event when the fd is closed before the flip has
> + *              completed. The test itself won't fail even if the kernel leaks
> + *              the event, but the resulting dmesg WARN will indicate a failure.
> + *
> + * SUBTEST: basic
> + * Description: This test tries to provoke the kernel into leaking a pending
> + *              page flip event when the fd is closed before the flip has
> + *              completed. The test itself won't fail even if the kernel leaks
> + *              the event, but the resulting dmesg WARN will indicate a failure.

Hi,

The test and subtest description are same? I understand that there is 
only one subtest currently, but could the test description be updated to 
be more a high level description may be?

Thanks,
Karthik.B.S
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   typedef struct {
>   	int drm_fd;

Re: [igt-dev] [V5 i-g-t 11/81] tests/i915/kms_big_joiner: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/i915/kms_big_joiner.c | 33 +++++++++++++++++++++++++++++++++
>   1 file changed, 33 insertions(+)
>
> diff --git a/tests/i915/kms_big_joiner.c b/tests/i915/kms_big_joiner.c
> index 2ff23398a..c448853c5 100644
> --- a/tests/i915/kms_big_joiner.c
> +++ b/tests/i915/kms_big_joiner.c
> @@ -24,6 +24,11 @@
>    *  Karthik B S <karthik.b.s@intel.com>
>    */
>   
> +/**
> + * TEST: kms big joiner
> + * Category: Display
> + * Description: Test big joiner
> + */
>   #include "igt.h"
>   
>   #define MAX_HDISPLAY_PER_PIPE 5120
> @@ -40,6 +45,16 @@ typedef struct {
>   	uint32_t big_joiner_output[2];
>   } data_t;
>   
> +/**
> + * SUBTEST: invalid-modeset
> + * Description: Verify if the modeset on the adjoining pipe is rejected when
> + *              the pipe is active with a big joiner modeset
> + * Driver requirement: any
> + * Functionality: 2p1p
> + * Mega feature: Bigjoiner
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_invalid_modeset(data_t *data)
>   {
>   	igt_output_t *output;
> @@ -80,6 +95,15 @@ static void test_invalid_modeset(data_t *data)
>   	igt_assert_lt(ret, 0);
>   }
>   
> +/**
> + * SUBTEST: basic
> + * Description: Verify the basic modeset on big joiner mode on all pipes
> + * Driver requirement: any
> + * Functionality: 2p1p
> + * Mega feature: Bigjoiner
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_basic_modeset(data_t *data)
>   {
>   	drmModeModeInfo *mode;
> @@ -118,6 +142,15 @@ static void test_basic_modeset(data_t *data)
>   	igt_display_commit2(display, COMMIT_ATOMIC);
>   }
>   
> +/**
> + * SUBTEST: 2x-modeset
> + * Description: Verify simultaneous modeset on 2 big joiner outputs
> + * Driver requirement: any
> + * Functionality: 2p1p
> + * Mega feature: Bigjoiner
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_dual_display(data_t *data)
>   {
>   	drmModeModeInfo *mode;

Re: [igt-dev] [V5 i-g-t 73/81] tests/kms_setmode: Document each subtest for testplan

[Karthik B S]

Hi,

On 6/29/2023 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_setmode.c | 58 +++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 58 insertions(+)
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index 035bbd0b0..bce41fc3b 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -31,6 +31,64 @@
>   #include <sys/time.h>
>   #include <math.h>
>   #include "xe/xe_query.h"
> +/**
> + * TEST: kms setmode
> + * Category: Display

Description missing?

> + *
> + * SUBTEST: basic
> + * Description: Tests the mode by iterating through all valid/invalid crtc/connector
> + *              combinations
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: basic-clone-single-crtc
> + * Description: Tests the mode by iterating through all valid/invalid crtc/connector
> + *              combinations
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: clone-exclusive-crtc
> + * Description: Tests the mode by iterating through all valid/invalid crtc/connector
> + *              combinations
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: invalid-clone-exclusive-crtc
> + * Description: Tests the mode by iterating through all valid/invalid crtc/connector
> + *              combinations
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: invalid-clone-single-crtc
> + * Description: Tests the mode by iterating through all valid/invalid crtc/connector
> + *              combinations
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: invalid-clone-single-crtc-stealing
> + * Description: Tests the mode by iterating through all valid/invalid crtc/connector
> + *              combinations
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */

All the subtests are having the same description. Could you please add 
subtest specific details. May be the current description of subtests 
could be the overall test description.

Thanks,
Karthik.B.S
>   
>   #define MAX_CONNECTORS  10
>   #define MAX_CRTCS       6

Re: [igt-dev] [V5 i-g-t 40/81] tests/kms_content_protection: Document each subtest for testplan

[Karthik B S]

Hi,

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_content_protection.c | 81 ++++++++++++++++++++++++++++++++++
>   1 file changed, 81 insertions(+)
>
> diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
> index 6cdf81a28..50929d8d5 100644
> --- a/tests/kms_content_protection.c
> +++ b/tests/kms_content_protection.c
> @@ -22,6 +22,11 @@
>    *
>    */
>   
> +/**
> + * TEST: kms content protection
> + * Category: Display
> + * Description: Test content protection (HDCP)
> + */
>   #include <poll.h>
>   #include <fcntl.h>
>   #include <sys/epoll.h>
> @@ -485,6 +490,66 @@ test_fini(igt_output_t *output, enum igt_commit_style s)
>   	igt_display_commit2(&data.display, s);
>   }
>   
> +/**
> + * SUBTEST: LIC
> + * Description: Test for the integrity of link.
> + * Driver requirement: any
> + * Functionality: hdcp
> + * Mega feature: HDCP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: content_type_change
> + * Description: Test the content type change when the content protection already
> + *              enabled
> + * Driver requirement: any
> + * Functionality: hdcp, hdcp2.2
> + * Mega feature: HDCP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: mei_interface
> + * Description: Test the teardown and rebuild of the interface between Intel
> + *              and mei hdcp.
> + * Driver requirement: any
> + * Functionality: hdcp, hdcp2.2

Since we're explicitly mentioning HDCP2.2, could/should the other 
component be hdcp1.4 instead of just hdcp?

Thanks,
Karthik.B.S
> + * Mega feature: HDCP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: srm
> + * Description: This test writes the facsimile SRM into the /lib/firmware/ and
> + *              check the kernel parsing of it by invoking the hdcp authentication.
> + * Driver requirement: any
> + * Functionality: hdcp
> + * Mega feature: HDCP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: uevent
> + * Description: Test to detect the HDCP status change when we are reading the
> + *              uevent sent with the corresponding connector id and property id.
> + * Driver requirement: any
> + * Functionality: hdcp
> + * Mega feature: HDCP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: %s
> + * Description: Test content protection with %arg[1]
> + * Driver requirement: any
> + * Functionality: hdcp
> + * Mega feature: HDCP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @atomic:         atomic modesetting
> + * @atomic-dpms:    DPMS ON/OFF during atomic modesetting.
> + * @legacy:         legacy style commit
> + * @type1:          content type 1 that can be handled only through HDCP2.2.
> + */
>   static void
>   test_content_protection(enum igt_commit_style s, int content_type)
>   {
> @@ -602,6 +667,22 @@ static void test_cp_lic_on_mst(igt_output_t *mst_outputs[], int valid_outputs, b
>   	}
>   }
>   
> +/**
> + * SUBTEST: dp-mst-%s
> + * Description: Test Content protection %arg[1] over DP MST.
> + * Driver requirement: any
> + * Functionality: hdcp
> + * Mega feature: HDCP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @lic-type-0:   Type 0 with LIC
> + * @lic-type-1:   Type 1 with LIC.
> + * @type-0:       Type 0
> + * @type-1:       Type 1
> + */
>   static void
>   test_content_protection_mst(int content_type)
>   {

Re: [igt-dev] [V5 i-g-t 48/81] tests/kms_flip: Document each subtest for testplan

[Karthik B S]

Hi,

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_flip.c | 178 ++++++++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 176 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index d57990240..dd7921656 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -22,8 +22,9 @@
>    */
>   
>   /**
> - * TEST: Tests for validating modeset, dpms and pageflips
> + * TEST: kms flip
>    * Category: Display
> + * Description: Tests for validating modeset, dpms and pageflips
>    */
>   
>   #include "config.h"
> @@ -39,6 +40,169 @@
>   #include <sys/poll.h>
>   #include <sys/time.h>
>   #include <sys/ioctl.h>
> +/**
> + * SUBTEST: 2x-flip-vs-fences
> + * Description: Test for validating modeset, dpms and pageflips with a pair of connected displays
> + * Driver requirement: i915
> + * Functionality: gtt, vblank
Functionality mentions 'gtt', but description is mostly same as the 
overall test description. Could you please make this more specific?
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: 2x-flip-vs-fences-interruptible
> + * Description: Interrupt test for validating modeset, dpms and pageflips with pair of connected displays
> + * Driver requirement: any
> + * Functionality: gtt, vblank
Same as above.
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-vs-fences
> + * Description: Basic test for validating modeset, dpms and pageflips
> + * Driver requirement: i915
> + * Functionality: gtt, vblank
Same as above.
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-vs-fences-interruptible
> + * Description: Interrupt test for validating modeset, dpms and pageflips
> + * Driver requirement: i915
> + * Functionality: gtt, vblank
Same as above.
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
> +/**
> + * SUBTEST: %s
> + * Description: Basic test for validating modeset, dpms and pageflips
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @dpms-off-confusion:
> + * @bo-too-big:
> + */
> +
> +/**
> + * SUBTEST: %s
> + * Description: Basic test for validating modeset, dpms and pageflips
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: 2x-%s
> + * Description: Test for validating modeset, dpms and pageflips with a pair of
> + *              connected displays
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @wf_vblank-ts-check:
> + * @blocking-wf_vblank:
> + * @absolute-wf_vblank:
> + * @blocking-absolute-wf_vblank:
> + * @busy-flip:
> + * @plain-flip-ts-check:
> + * @plain-flip-fb-recreate:
> + * @flip-vs-rmfb:
> + * @flip-vs-panning:
> + * @flip-vs-expired-vblank:
> + * @flip-vs-absolute-wf_vblank:
> + * @flip-vs-blocking-wf-vblank:
> + * @flip-vs-modeset-vs-hang:
> + * @flip-vs-panning-vs-hang:
> + * @flip-vs-dpms-off-vs-modeset:
> + * @single-buffer-flip-vs-dpms-off-vs-modeset:
> + * @nonexisting-fb:
> + * @dpms-vs-vblank-race:
> + * @modeset-vs-vblank-race:
> + * @flip-vs-suspend:
> + */
> +
> +/**
> + * SUBTEST: 2x-%s
> + * Description: Test for validating modeset, dpms and pageflips with a pair of
> + *              connected displays
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @plain-flip:
> + * @flip-vs-dpms:
> + * @flip-vs-modeset:
> + * @flip-vs-wf_vblank:
> + */
> +
> +/**
> + * SUBTEST: %s-interruptible
> + * Description: Basic test for validating modeset, dpms and pageflips
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @dpms-off-confusion:
> + * @bo-too-big:
> + */
> +
> +/**
> + * SUBTEST: %s-interruptible
> + * Description: Basic test for validating modeset, dpms and pageflips
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: 2x-%s-interruptible
> + * Description: Test for validating modeset, dpms and pageflips with a pair of
> + *              connected displays
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @wf_vblank-ts-check:
> + * @absolute-wf_vblank:
> + * @blocking-absolute-wf_vblank:
> + * @plain-flip:
> + * @plain-flip-ts-check:
> + * @plain-flip-fb-recreate:
> + * @flip-vs-rmfb:
> + * @flip-vs-panning:
> + * @flip-vs-expired-vblank:
> + * @flip-vs-absolute-wf_vblank:
> + * @flip-vs-wf_vblank:
> + * @flip-vs-dpms-off-vs-modeset:
> + * @single-buffer-flip-vs-dpms-off-vs-modeset:
> + * @nonexisting-fb:
> + * @dpms-vs-vblank-race:
> + * @modeset-vs-vblank-race:
> + * @flip-vs-suspend:
> + */
> +

All the above subtests are having mostly common/generic descriptions. 
Could you please update this to make it more subtest specific.

Thanks,
Karthik.B.S
>   #ifdef HAVE_LINUX_KD_H
>   #include <linux/kd.h>
>   #elif HAVE_SYS_KD_H
> @@ -1564,6 +1728,7 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
>   /**
>    * SUBTEST: basic-flip-vs-%s
>    * Description: Basic test to valide %arg[1]
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: vblank
> @@ -1577,12 +1742,12 @@ static void run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
>    *
>    * SUBTEST: basic-plain-flip
>    * Description: Basic test for validating page flip
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: vblank
>    * Mega feature: General Display Features
>    */
> -
>   static void run_test(int duration, int flags)
>   {
>   	struct test_output o;
> @@ -1759,6 +1924,15 @@ static void kms_flip_exit_handler(int sig)
>   		kmstest_set_connector_dpms(drm_fd, last_connector, DRM_MODE_DPMS_ON);
>   }
>   
> +/**
> + * SUBTEST: nonblocking-read
> + * Description: Tests that nonblocking reading fails correctly
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_nonblocking_read(int in)
>   {
>   	char buffer[1024];

Re: [igt-dev] [V5 i-g-t 13/81] tests/i915/kms_ccs: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> V2: - Include mtl ccs tests
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/i915/kms_ccs.c | 89 ++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 89 insertions(+)
>
> diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
> index f04552dd7..995e0a589 100644
> --- a/tests/i915/kms_ccs.c
> +++ b/tests/i915/kms_ccs.c
> @@ -22,10 +22,99 @@
>    *
>    */
>   
> +/**
> + * TEST: kms ccs
> + * Category: Display
> + * Description: Test render compression (RC), in which the main surface is
> + *              complemented by a color control surface (CCS) that the display
> + *              uses to interpret the compressed data.
> + */
>   #include "igt.h"
>   
>   #include "i915/gem_create.h"
>   
> +/**
> + * SUBTEST: %s-%s-%s
> + * Description: Test %arg[2] with given %arg[3] modifier
> + * Driver requirement: any
> + * Functionality: ccs
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @pipe-A:                    Pipe A
> + * @pipe-B:                    Pipe B
> + * @pipe-C:                    Pipe C
> + * @pipe-D:                    Pipe D
> + * @pipe-E:                    Pipe E
> + * @pipe-F:                    Pipe F
> + * @pipe-G:                    Pipe G
> + * @pipe-H:                    Pipe H
> + *
> + * arg[2]:
> + *
> + * @bad-aux-stride:            Bad AUX stride
> + * @ccs-on-another-bo:         CCS with different BO
> + * @missing-ccs-buffer:        Missing CCS buffer
> + *
> + * arg[3]:
> + *
> + * @y_tiled_ccs:               Y tiled ccs
> + * @y_tiled_gen12_mc_ccs:      Y tiled gen12 mc ccs
> + * @y_tiled_gen12_rc_ccs:      Y tiled gen12 rc ccs
> + * @y_tiled_gen12_rc_ccs_cc:   Y tiled gen12 rc ccs cc
> + * @yf_tiled_ccs:              YF tiled ccs
> + * @4_tiled_mtl_mc_ccs:        4 tiled mtl mc ccs
> + * @4_tiled_mtl_rc_ccs:        4 tiled mtl rc ccs
> + * @4_tiled_mtl_rc_ccs_cc:     4 tiled mtl rc ccs cc
> + */
> +
> +/**
> + * SUBTEST: %s-%s-%s
> + * Description: Test %arg[2] with %arg[3] modifier
> + * Driver requirement: any
> + * Functionality: ccs
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @pipe-A:                      Pipe A
> + * @pipe-B:                      Pipe B
> + * @pipe-C:                      Pipe C
> + * @pipe-D:                      Pipe D
> + * @pipe-E:                      Pipe E
> + * @pipe-F:                      Pipe F
> + * @pipe-G:                      Pipe G
> + * @pipe-H:                      Pipe H
> + *
> + * arg[2]:
> + *
> + * @bad-pixel-format:            Bad pixel format
> + * @bad-rotation-90:             90 degree rotation
> + * @crc-primary-basic:           Primary plane CRC compatibility
> + * @crc-primary-rotation-180:    180 degree rotation
> + * @crc-sprite-planes-basic:     Sprite plane CRC compatability
> + * @random-ccs-data:             Random CCS data
> + *
> + * arg[3]:
> + *
> + * @4_tiled_dg2_mc_ccs:        4 tiled mc ccs
> + * @4_tiled_dg2_rc_ccs:        4 tiled dg2 rc ccs
> + * @4_tiled_dg2_rc_ccs_cc:     4 tiled dg2 rc ccs cc
> + * @4_tiled_mtl_mc_ccs:        4 tiled mtl mc ccs
> + * @4_tiled_mtl_rc_ccs:        4 tiled mtl rc ccs
> + * @4_tiled_mtl_rc_ccs_cc:     4 tiled mtl rc ccs cc
> + * @y_tiled_ccs:               Y tiled ccs
> + * @y_tiled_gen12_mc_ccs:      Y tiled gen12 mc ccs
> + * @y_tiled_gen12_rc_ccs:      Y tiled gen12 rc ccs
> + * @y_tiled_gen12_rc_ccs_cc:   Y tiled gen12 rc ccs cc
> + * @yf_tiled_ccs:              YF tiled ccs
> + */
> +
>   #define SDR_PLANE_BASE	3
>   
>   IGT_TEST_DESCRIPTION("Test render compression (RC), in which the main surface "

Re: [igt-dev] [V5 i-g-t 31/81] tests/kms_3d: Document each subtest for testplan

[Sharma, Swati2]

LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_3d.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/tests/kms_3d.c b/tests/kms_3d.c
> index c7a9d42d2..df0b54b37 100644
> --- a/tests/kms_3d.c
> +++ b/tests/kms_3d.c
> @@ -24,6 +24,19 @@
>   
>   #include "igt.h"
>   #include "xe/xe_query.h"
> +/**
> + * TEST: kms 3d
> + * Category: Display
> + * Description: Tests 3D mode setting.
> + *
> + * SUBTEST:
> + * Description: Tests 3D mode setting.
> + * Driver requirement: any
> + * Functionality: stereoscopic
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Tests 3D mode setting.");
>   

Re: [igt-dev] [V5 i-g-t 37/81] tests/kms_bw: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_bw.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/tests/kms_bw.c b/tests/kms_bw.c
> index b66473e60..331be5755 100644
> --- a/tests/kms_bw.c
> +++ b/tests/kms_bw.c
> @@ -25,6 +25,26 @@
>   #include "drm.h"
>   #include <stdio.h>
>   #include <xf86drmMode.h>
> +/**
> + * TEST: kms bw
> + * Category: Display
> + *
> + * SUBTEST: linear-tiling-%d-displays-%s
> + * Description: bw test with %arg[2]
> + * Driver requirement: any
> + * Functionality: obsolete

Why functionality is obsolete?

> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1].values: 1, 2, 3, 4, 5, 6, 7, 8
> + *
> + * arg[2]:
> + *
> + * @1920x1080p:       1920x1080 resolution
> + * @2560x1440p:       2560x1440 resolution
> + * @3840x2160p:       3840x2160 resolution
> + */
>   
>   /* Common test data. */
>   typedef struct data {

Re: [igt-dev] [V5 i-g-t 52/81] tests/kms_hdmi_inject: Document each subtest for testplan

[Sharma, Swati2]

LGTM.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_hdmi_inject.c | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
> index 9aa5c59fc..436f34a8c 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -30,6 +30,31 @@
>   #include "igt_edid.h"
>   #include "igt_eld.h"
>   #include "xe/xe_query.h"
> +/**
> + * TEST: kms hdmi inject
> + * Category: Display
> + * Description: Test that in-kernel EDID parsing is producing expected results
> + *              by forcing a HDMI connector with a known EDID and checking that
> + *              the metadata exposed to user space matches.
> + *
> + * SUBTEST: inject-4k
> + * Description: Make sure that 4K modes exposed by DRM match the forced EDID and
> + *              modesetting using it succeed.
> + * Driver requirement: any
> + * Functionality: force_connector
> + * Mega feature: HDMI
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: inject-audio
> + * Description: Make sure that audio information exposed by ALSA match the forced
> + *              EDID.
> + * Driver requirement: any
> + * Functionality: force_connector
> + * Mega feature: Disply Audio
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   #define HDISPLAY_4K	3840
>   #define VDISPLAY_4K	2160

Re: [igt-dev] [V5 i-g-t 44/81] tests/kms_display_modes: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 44/81] tests/kms_display_modes: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> V2: - Add missing documentation
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/kms_display_modes.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c index
> 93d91ef5b..b26a3f71a 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -24,6 +24,11 @@
>   *  Jeevan B <jeevan.b@intel.com>
>   */
> 
> +/**
> + * TEST: kms display modes
> + * Category: Display
> + * Description: Test Display Modes
> + */
>  #include "igt.h"
> 
>  #define HDISPLAY_4K	3840
> @@ -231,6 +236,16 @@ static void run_extendedmode_basic(data_t *data,
>  	for_each_connected_output_local((display), (output)) \
>  		for_each_if (igt_pipe_connector_valid((pipe), (output)))
> 
> +/**
> + * SUBTEST: extended-mode-basic
> + * Description: Test for validating display extended mode with a pair of
> connected
> + *              displays
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>  static void run_extendedmode_test(data_t *data) {
>  	enum pipe pipe1, pipe2;
>  	igt_output_t *output1, *output2;
> @@ -276,6 +291,16 @@ static void run_extendedmode_test(data_t *data) {
>  	}
>  }
> 
> +/**
> + * SUBTEST: mst-extended-mode-negative
> + * Description: Negative test for validating display extended mode with a
> pair
> + *		of connected 2k-4k or 4k-4k displays.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>  static void run_extendedmode_negative(data_t *data, int pipe1, int pipe2)
> {
>  	struct igt_fb fbs[2];
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 41/81] tests/kms_cursor_crc: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 41/81] tests/kms_cursor_crc: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/kms_cursor_crc.c | 65
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index
> 0506fd6f1..d91376fa4 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -29,6 +29,19 @@
>  #include <stdio.h>
>  #include <string.h>
> 
> +/**
> + * TEST: kms cursor crc
> + * Category: Display
> + * Description: Use the display CRC support to validate cursor plane
> functionality.
> + *              The test will position the cursor plane either fully onscreen,
> + *              partially onscreen, or fully offscreen, using either a fully
> + *              opaque or fully transparent surface. In each case, it enables
> + *              the cursor plane and then reads the PF CRC (hardware test) and
> + *              compares it with the CRC value obtained when the cursor plane
> + *              was disabled and its drawing is directly inserted on the PF by
> + *              software.
> + */
> +
>  IGT_TEST_DESCRIPTION(
>     "Use the display CRC support to validate cursor plane functionality. "
>     "The test will position the cursor plane either fully onscreen, "
> @@ -641,6 +654,27 @@ static bool require_cursor_size(data_t *data, int w,
> int h)
>  	return !!ret;
>  }
> 
> +/**
> + * SUBTEST: cursor-%s
> + * Description: %arg[1]
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @alpha-opaque:       Validates the composition of a fully opaque cursor
> plane,
> + *                      i.e., alpha channel equal to 1.0.
> + * @alpha-transparent:  Validates the composition of a fully transparent
> cursor
> + *                      plane, i.e., alpha channel equal to 0.0.
> + * @dpms:               Check random placement of a cursor with DPMS.
> + * @size-change:        Create a maximum size cursor, then change the size in
> + *                      flight to smaller ones to see that the size is applied
> + *                      correctly.
> + * @suspend:            Check random placement of a cursor with suspend.
> + */
>  static void run_test(data_t *data, void (*testfunc)(data_t *), int cursor_w,
> int cursor_h)  {
>  	prepare_crtc(data, cursor_w, cursor_h); @@ -738,6 +772,37 @@
> static bool execution_constraint(enum pipe pipe)  }
> 
> 
> +/**
> + * SUBTEST: cursor-%s-%s
> + * Description: Check if a %arg[2] cursor is %arg[1].
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @offscreen:             well-positioned outside the screen
> + * @onscreen:              well-positioned inside the screen
> + * @random:                randomly placed
> + * @rapid-movement:        rapidly udates for movements
> + * @sliding:               smooth for horizontal, vertical & diagonal movements
> + *
> + * arg[2]:
> + *
> + * @128x128:               128x128 size
> + * @128x42:                128x42 size
> + * @256x256:               256x256 size
> + * @256x85:                256x85 size
> + * @32x10:                 32x10 size
> + * @32x32:                 32x32 size
> + * @512x170:               512x170 size
> + * @512x512:               512x512 size
> + * @64x21:                 64x21 size
> + * @64x64:                 64x64 size
> + * @max-size:              Max supported size
> + */
>  static void run_size_tests(data_t *data, int w, int h)  {
>  	enum pipe pipe;
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 53/81] tests/kms_hdr: Document each subtest for testplan

[Sharma, Swati2]

LGTM.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_hdr.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 52 insertions(+)
> 
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> index ba19761e2..0442cc168 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -20,6 +20,11 @@
>    * OTHER DEALINGS IN THE SOFTWARE.
>    */
>   
> +/**
> + * TEST: kms hdr
> + * Category: Display
> + * Description: Test HDR metadata interfaces and bpc switch
> + */
>   #include "igt.h"
>   #include <fcntl.h>
>   #include <termios.h>
> @@ -208,6 +213,21 @@ static bool has_max_bpc(igt_output_t *output)
>   	       igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
>   }
>   
> +/**
> + * SUBTEST: bpc-%s
> + * Description: Tests switching between different display output bpc modes %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_hdr
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @switch:              default
> + * @switch-dpms:         with dpms
> + * @switch-suspend:      with suspend
> + */
>   static void test_bpc_switch(data_t *data, uint32_t flags)
>   {
>   	igt_display_t *display = &data->display;
> @@ -561,6 +581,38 @@ static bool has_hdr(igt_output_t *output)
>   	return igt_output_has_prop(output, IGT_CONNECTOR_HDR_OUTPUT_METADATA);
>   }
>   
> +/**
> + * SUBTEST: invalid-hdr
> + * Description: Test to ensure HDR is not enabled on non-HDR panel
> + * Driver requirement: any
> + * Functionality: kms_hdr
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: invalid-metadata-sizes
> + * Description: Tests invalid HDR metadata sizes
> + * Driver requirement: any
> + * Functionality: kms_hdr
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: static-%s
> + * Description: Tests %arg[1].
> + * Driver requirement: any
> + * Functionality: kms_hdr
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @swap:                    swapping static HDR metadata
> + * @toggle:                  entering and exiting HDR mode
> + * @toggle-dpms:             static toggle with dpms
> + * @toggle-suspend:          static toggle with suspend
> + */
>   static void test_hdr(data_t *data, uint32_t flags)
>   {
>   	igt_display_t *display = &data->display;

Re: [igt-dev] [V5 i-g-t 42/81] tests/kms_cursor_edge_walk: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 42/81] tests/kms_cursor_edge_walk: Document
> each subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/kms_cursor_edge_walk.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
> index 462b51e20..9010aa0f7 100644
> --- a/tests/kms_cursor_edge_walk.c
> +++ b/tests/kms_cursor_edge_walk.c
> @@ -28,6 +28,32 @@
>  #include <stdbool.h>
>  #include <stdio.h>
>  #include <string.h>
> +/**
> + * TEST: kms cursor edge walk
> + * Category: Display
> + * Description: Exercise CHV pipe C cursor fail
> + *
> + * SUBTEST: %s-%s
> + * Description: Checking cursor size %arg[1] by walking %arg[2] of
> +screen
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @128x128:          128x128
> + * @256x256:          256x256
> + * @64x64:            64x64
> + *
> + * arg[2]:
> + *
> + * @left-edge:        Left edge
> + * @right-edge:       Right edge
> + * @top-bottom:       Top to bottom
> + * @top-edge:         Top edge
> + */
> 
>  IGT_TEST_DESCRIPTION("Exercise CHV pipe C cursor fail");
> 
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 21/81] tests/i915/kms_flip_tiling: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:18 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 21/81] tests/i915/kms_flip_tiling: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/i915/kms_flip_tiling.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/i915/kms_flip_tiling.c b/tests/i915/kms_flip_tiling.c index
> 02a5fe8e3..6cb85e9d3 100644
> --- a/tests/i915/kms_flip_tiling.c
> +++ b/tests/i915/kms_flip_tiling.c
> @@ -30,6 +30,19 @@
>  #include <string.h>
> 
>  #include "igt.h"
> +/**
> + * TEST: kms flip tiling
> + * Category: Display
> + * Description: Test page flips and tiling scenarios
> + *
> + * SUBTEST: flip-change-tiling
> + * Description: Check pageflip between modifiers
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
> 
>  IGT_TEST_DESCRIPTION("Test page flips and tiling scenarios");
> 
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 62/81] tests/kms_plane_lowres: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 62/81] tests/kms_plane_lowres: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/kms_plane_lowres.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c index
> 7aaf83c41..65d1dd183 100644
> --- a/tests/kms_plane_lowres.c
> +++ b/tests/kms_plane_lowres.c
> @@ -22,6 +22,12 @@
>   *
>   */
> 
> +/**
> + * TEST: kms plane lowres
> + * Category: Display
> + * Description: Test atomic mode setting with a plane by switching between
> high
> + *              and low resolutions
> + */
>  #include "igt.h"
>  #include "drmtest.h"
>  #include <errno.h>
> @@ -261,6 +267,24 @@ static void test_cleanup(data_t *data)
>  	igt_display_commit2(&data->display, COMMIT_ATOMIC);  }
> 
> +/**
> + * SUBTEST: tiling-%s
> + * Description: Tests the visibility of the planes when switching between
> high
> + *              and low resolution with %arg[1]
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @none:        Linear buffer (no tiling)
> + * @4:           4-tiling
> + * @x:           x-tiling
> + * @y:           y-tiling
> + * @yf:          yf-tiling
> + */
>  static void run_test(data_t *data, uint64_t modifier)  {
>  	enum pipe pipe;
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 54/81] tests/kms_invalid_mode: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_invalid_mode.c | 32 ++++++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
> 
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index c26f8befe..f9d953014 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -22,10 +22,42 @@
>    *
>    */
>   
> +/**
> + * TEST: kms invalid mode
> + * Category: Display
> + * Description: Make sure all modesets are rejected when the requested mode is
> + *              invalid
> + */
>   #include "igt.h"
>   #include <limits.h>
>   #include <stdbool.h>
>   
> +/**
> + * SUBTEST: %s
> + * Description: Make sure all modesets are rejected when the requested mode is
> + *              invalid
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @bad-hsync-end:
> + * @bad-hsync-start:
> + * @bad-htotal:
> + * @bad-vsync-end:
> + * @bad-vsync-start:
> + * @bad-vtotal:
> + * @clock-too-high:
> + * @int-max-clock:
> + * @uint-max-clock:
> + * @zero-clock:
> + * @zero-hdisplay:
> + * @zero-vdisplay:
> + */
> +

Do we need to write description of all these subtests?

>   IGT_TEST_DESCRIPTION("Make sure all modesets are rejected when the requested mode is invalid");
>   
>   typedef struct _data data_t;

Re: [igt-dev] [V5 i-g-t 64/81] tests/kms_plane_scaling: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> V2: - Fix the documentation for renamed tests
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_plane_scaling.c | 261 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 261 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 920290e4d..efe772dec 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -22,6 +22,11 @@
>    *
>    */
>   
> +/**
> + * TEST: kms plane scaling
> + * Category: Display
> + * Description: Test display plane scaling
> + */
>   #include "igt.h"
>   #include "igt_vec.h"
>   #include <math.h>
> @@ -524,6 +529,52 @@ static const uint64_t modifiers[] = {
>   	I915_FORMAT_MOD_4_TILED
>   };
>   
> +/**
> + * SUBTEST: plane-scaler-with-modifiers-unity-scaling
> + * Description: Tests scaling with modifiers, unity scaling.
> + * Driver requirement: any
> + * Functionality: plane

Add scaling as functionality too. Applicable for
remaining subtests aswell.

> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-scaler-with-clipping-clamping-modifiers
> + * Description: Tests scaling with clipping and clamping, modifiers.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-upscale-with-modifiers-%s
> + * Description: Tests upscaling with modifiers %arg[1].
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @20x20:          from 20x20 fb
> + * @factor-0-25:    for 0.25 scaling factor
> + */
> +
> +/**
> + * SUBTEST: plane-downscale-with-modifiers-factor-%s
> + * Description: Tests downscaling with modifiers for %arg[1] scaling factor.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @0-25:   0.25
> + * @0-5:    0.5
> + * @0-75:   0.75
> + */
>   static void test_scaler_with_modifier_pipe(data_t *d,
>   					   int width, int height,
>   					   bool is_upscale,
> @@ -560,6 +611,52 @@ static void test_scaler_with_modifier_pipe(data_t *d,
>   	}
>   }
>   
> +/**
> + * SUBTEST: plane-scaler-with-rotation-unity-scaling
> + * Description: Tests scaling with rotation, unity scaling.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-scaler-with-clipping-clamping-rotation
> + * Description: Tests scaling with clipping and clamping, rotation.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-upscale-with-rotation-%s
> + * Description: Tests upscaling with rotation %arg[1].
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @20x20:          from 20x20 fb
> + * @factor-0-25:    for 0.25 scaling factor
> + */
> +
> +/**
> + * SUBTEST: plane-downscale-with-rotation-factor-%s
> + * Description: Tests downscaling with rotation for %arg[1] scaling factor.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @0-25:   0.25
> + * @0-5:    0.5
> + * @0-75:   0.75
> + */
>   static void test_scaler_with_rotation_pipe(data_t *d,
>   					   int width, int height,
>   					   bool is_upscale,
> @@ -592,7 +689,52 @@ static void test_scaler_with_rotation_pipe(data_t *d,
>   		}
>   	}
>   }
> +/**
> + * SUBTEST: plane-scaler-with-pixel-format-unity-scaling
> + * Description: Tests scaling with pixel formats, unity scaling.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-scaler-with-clipping-clamping-pixel-formats
> + * Description: Tests scaling with clipping and clamping, pixel formats.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-upscale-with-pixel-format-%s
> + * Description: Tests upscaling with pixel formats %arg[1].
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @20x20:          from 20x20 fb
> + * @factor-0-25:    for 0.25 scaling factor
> + */
>   
> +/**
> + * SUBTEST: plane-downscale-with-pixel-format-factor-%s
> + * Description: Tests downscaling with pixel formats for %arg[1] scaling factor.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @0-25:   0.25
> + * @0-5:    0.5
> + * @0-75:   0.75
> + */
>   static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, bool is_upscale,
>   					       enum pipe pipe, igt_output_t *output)
>   {
> @@ -728,6 +870,88 @@ static void setup_fb(int fd, int width, int height, struct igt_fb *fb)
>   		      fb);
>   }
>   
> +/**
> + * SUBTEST: planes-downscale-factor-%s
> + * Description: Tests downscaling of 2 planes for %arg[1] scaling factor.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @0-25:  0.25
> + * @0-5:   0.5
> + * @0-75:  0.75
> + */
> +/**
> + * SUBTEST: planes-downscale-factor-%s-%s
> + * Description: Tests downscaling (scaling factor %arg[1]) and upscaling (%arg[2])
> + *              of 2 planes.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @0-25:  0.25
> + * @0-5:   0.5
> + * @0-75:  0.75
> + *
> + * arg[2]:
> + *
> + * @upscale-20x20:           upscale 20x20
> + * @upscale-factor-0-25:     scaling factor 0.25
> + * @unity-scaling:           Unity
> + */
> +/**
> + * SUBTEST: planes-scaler-unity-scaling
> + * Description: Tests scaling of 2 planes, unity scaling.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: planes-upscale-%s
> + * Description: Tests upscaling of 2 planes %arg[1].
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @20x20:          from 20x20 fb
> + * @factor-0-25:    for 0.25 scaling factor
> + */
> +/**
> + * SUBTEST: planes-%s-downscale-factor-%s
> + * Description: Tests scaling (%arg[1]) and downscaling (scaling factor %arg[2])
> + *              of 2 planes.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @unity-scaling:           Unity
> + * @upscale-factor-0-25:     scaling factor 0.25
> + * @upscale-20x20:           upscale 20x20
> + *
> + * arg[2]:
> + *
> + * @0-25:  0.25
> + * @0-5:   0.5
> + * @0-75:  0.75
> + */
> +
>   static void
>   test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
>   			  enum pipe pipe, igt_output_t *output,
> @@ -786,6 +1010,15 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
>   	cleanup_fbs(d);
>   }
>   
> +/**
> + * SUBTEST: invalid-num-scalers
> + * Description: Negative test for number of scalers per pipe.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void
>   test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
>   {
> @@ -851,6 +1084,15 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
>   	cleanup_fbs(d);
>   }
>   
> +/**
> + * SUBTEST: 2x-scaler-multi-pipe
> + * Description: Tests scaling with multi-pipe.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_scaler_with_multi_pipe_plane(data_t *d)
>   {
>   	igt_display_t *display = &d->display;
> @@ -935,6 +1177,15 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
>   	igt_assert_eq(ret1 && ret2, 0);
>   }
>   
> +/**
> + * SUBTEST: invalid-parameters
> + * Description: test parameters which should not be accepted
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void invalid_parameter_tests(data_t *d)
>   {
>   	enum pipe pipe = PIPE_A;
> @@ -1015,6 +1266,16 @@ static drmModeModeInfo *find_mode(data_t *data, igt_output_t *output, const uint
>   	return mode;
>   }
>   
> +/**
> + * SUBTEST: intel-max-src-size
> + * Description: Test for validating max source size.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
>   /*
>    *	Max source/destination width/height for intel driver.
>    *	These numbers are coming from

Re: [igt-dev] [V5 i-g-t 20/81] tests/i915/kms_flip_scaled_crc: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_flip_scaled_crc.c | 191 +++++++++++++++++++++++++++++++
>   1 file changed, 191 insertions(+)
> 
> diff --git a/tests/i915/kms_flip_scaled_crc.c b/tests/i915/kms_flip_scaled_crc.c
> index 30da1fcf3..f8eefa293 100644
> --- a/tests/i915/kms_flip_scaled_crc.c
> +++ b/tests/i915/kms_flip_scaled_crc.c
> @@ -22,8 +22,199 @@
>    *
>    */
>   
> +/**
> + * TEST: kms flip scaled crc
> + * Category: Display
> + * Description: Test flipping between scaled/nonscaled framebuffers
> + */
>   #include "igt.h"
>   
> +/**
> + * SUBTEST: flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling
> + * Description: Flip from 64bpp non scaled fb to 32bpp upscaled fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank

Add scaling as well in functionality. Applicable for remaining subtests too.

> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling
> + * Description: Flip from 64bpp non scaled fb to 32bpp downscaled fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-linear-to-64bpp-linear-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-4tile-to-64bpp-4tile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-xtile-to-64bpp-xtile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-yftile-to-32bpp-yftileccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-yftile-to-64bpp-yftile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-yftileccs-to-64bpp-yftile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytile-to-32bpp-ytileccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytile-to-64bpp-ytile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytileccs-to-64bpp-ytile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-%s
> + * Description: Flip from 64bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @downscaling:        Downscaled
> + * @upscaling:          Upscaled
> + */
> +
> +/**
> + * SUBTEST: flip-64bpp-4tile-to-%dbpp-4tile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-xtile-to-%dbpp-xtile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-yftile-to-%dbpp-yftile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-ytile-to-%dbpp-ytile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-linear-to-%dbpp-linear-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1].values: 16, 32
> + * arg[2]:
> + *
> + * @downscaling:        Downscaled
> + * @upscaling:          Upscaled
> + */
> +
>   IGT_TEST_DESCRIPTION("Test flipping between scaled/nonscaled framebuffers");
>   
>   typedef struct {

Re: [igt-dev] [V5 i-g-t 20/81] tests/i915/kms_flip_scaled_crc: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_flip_scaled_crc.c | 191 +++++++++++++++++++++++++++++++
>   1 file changed, 191 insertions(+)
> 
> diff --git a/tests/i915/kms_flip_scaled_crc.c b/tests/i915/kms_flip_scaled_crc.c
> index 30da1fcf3..f8eefa293 100644
> --- a/tests/i915/kms_flip_scaled_crc.c
> +++ b/tests/i915/kms_flip_scaled_crc.c
> @@ -22,8 +22,199 @@
>    *
>    */
>   
> +/**
> + * TEST: kms flip scaled crc
> + * Category: Display
> + * Description: Test flipping between scaled/nonscaled framebuffers
> + */
>   #include "igt.h"
>   
> +/**
> + * SUBTEST: flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling
> + * Description: Flip from 64bpp non scaled fb to 32bpp upscaled fb to stress CD
> + *              clock programming
> + * Driver requirement: any

This is i915/xe specific test.

> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling
> + * Description: Flip from 64bpp non scaled fb to 32bpp downscaled fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-linear-to-64bpp-linear-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-4tile-to-64bpp-4tile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-xtile-to-64bpp-xtile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-yftile-to-32bpp-yftileccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-yftile-to-64bpp-yftile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-yftileccs-to-64bpp-yftile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytile-to-32bpp-ytileccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-%s
> + * Description: Flip from 32bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytile-to-64bpp-ytile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-32bpp-ytileccs-to-64bpp-ytile-%s
> + * Description: Flip from 32bpp non scaled fb to 64bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-%s
> + * Description: Flip from 64bpp non scaled fb to 32bpp %arg[1] fb to stress CD
> + *              clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @downscaling:        Downscaled
> + * @upscaling:          Upscaled
> + */
> +
> +/**
> + * SUBTEST: flip-64bpp-4tile-to-%dbpp-4tile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-xtile-to-%dbpp-xtile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-yftile-to-%dbpp-yftile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-ytile-to-%dbpp-ytile-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-64bpp-linear-to-%dbpp-linear-%s
> + * Description: Flip from 64bpp non scaled fb to %arg[1]bpp %arg[2] fb to stress
> + *              CD clock programming
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1].values: 16, 32
> + * arg[2]:
> + *
> + * @downscaling:        Downscaled
> + * @upscaling:          Upscaled
> + */
> +
>   IGT_TEST_DESCRIPTION("Test flipping between scaled/nonscaled framebuffers");
>   
>   typedef struct {

Re: [igt-dev] [V5 i-g-t 16/81] tests/i915/kms_dsc: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_dsc.c | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
> 
> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> index 0a3e29924..4cce7face 100644
> --- a/tests/i915/kms_dsc.c
> +++ b/tests/i915/kms_dsc.c
> @@ -30,8 +30,35 @@
>    *
>    */
>   
> +/**
> + * TEST: kms dsc
> + * Category: Display
> + * Description: Test to validate display stream compression
> + */
>   #include "kms_dsc_helper.h"
>   
> +/**
> + * SUBTEST: dsc-%s
> + * Description: Tests basic display stream compression functionality if supported
> + *              by a connector by forcing %arg[1]

forcing DSC on all connectors that support it with %arg[1]
(remove this from below subtests description)

> + * Driver requirement: any

This is intel specific test.

> + * Functionality: dsc
> + * Mega feature: VDSC
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @basic:                DSC on all connectors that support it with default parameters
> + * @with-bpc:             DSC on all connectors that support it with certain input BPC
> + *                        for the connector
> + * @with-bpc-formats:     DSC on all connectors that support it with certain input
> + *                        BPC for the connector with diff formats
> + * @with-formats:         DSC on all connectors that support it with default parameters
> + *                        and creating fb with diff formats
> + * @with-output-formats:  DSC and output format on all connectors that support it
> + */
> +

dsc-with-output-formats-with-bpc subtest is added too recently. please add.

>   IGT_TEST_DESCRIPTION("Test to validate display stream compression");
>   
>   enum dsc_test_type {

Re: [igt-dev] [V5 i-g-t 57/81] tests/kms_panel_fitting: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_panel_fitting.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index ae1c65928..82d34831a 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -26,6 +26,27 @@
>   #include <limits.h>
>   #include <math.h>
>   #include <sys/stat.h>
> +/**
> + * TEST: kms panel fitting
> + * Category: Display
> + * Description: Test display panel fitting
> + *
> + * SUBTEST: atomic-fastset
> + * Description: Tests panel fitting usages with atomic fastset.
> + * Driver requirement: any
> + * Functionality: eDP, panel_fitting

scaling should also be added as part of functionality.

> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: legacy
> + * Description: Tests panel fitting usages with legacy style commit.
> + * Driver requirement: any
> + * Functionality: eDP, panel_fitting
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Test display panel fitting");
>   

Re: [igt-dev] [V5 i-g-t 70/81] tests/kms_scaling_modes: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_scaling_modes.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
> index 31b806ae2..88e6471b8 100644
> --- a/tests/kms_scaling_modes.c
> +++ b/tests/kms_scaling_modes.c
> @@ -25,6 +25,26 @@
>    */
>   
>   #include "igt.h"
> +/**
> + * TEST: kms scaling modes
> + * Category: Display
> + * Description: Test display scaling modes
> + *
> + * SUBTEST: scaling-mode-%s
> + * Description: Tests %arg[1] display scaling mode
> + * Driver requirement: any
> + * Functionality: plane

scaling, eDP should be added in functionality.

> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @center:           center
> + * @full:             full
> + * @full-aspect:      full aspect
> + * @none:             none (no scaling)
> + */
>   
>   IGT_TEST_DESCRIPTION("Test display scaling modes");
>   

Re: [igt-dev] [V5 i-g-t 79/81] tests/kms_writeback: Document each subtest for testplan

[Sharma, Swati2]

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_writeback.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 42 insertions(+)
> 
> diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
> index db1f0884f..8c6f3fdc3 100644
> --- a/tests/kms_writeback.c
> +++ b/tests/kms_writeback.c
> @@ -32,6 +32,48 @@
>   #include "igt_core.h"
>   #include "igt_fb.h"
>   #include "sw_sync.h"
> +/**
> + * TEST: kms writeback
> + * Category: Display
> + * Description: This test validates the expected behavior of the writeback
> + *              connectors feature by checking if the target device support
> + *              writeback; it validates bad and good combination, check color
> + *              format, and check the output result by using CRC.
> + *
> + * SUBTEST: writeback-check-output
> + * Description: Check writeback output with CRC validation
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: writeback-fb-id
> + * Description: Validate WRITEBACK_FB_ID with valid and invalid options
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: writeback-invalid-parameters
> + * Description: Writeback has a couple of parameters linked together(output
> + *              framebuffer and fence); this test goes throughthe combination
> + *              of possible bad options
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: writeback-pixel-formats
> + * Description: Check the writeback format
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION(
>      "This test validates the expected behavior of the writeback connectors "

Re: [igt-dev] [V5 i-g-t 14/81] tests/i915/kms_cdclk: Document each subtest for testplan

[Sharma, Swati2]

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_cdclk.c | 32 ++++++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
> 
> diff --git a/tests/i915/kms_cdclk.c b/tests/i915/kms_cdclk.c
> index 40eca24f0..276cda4c4 100644
> --- a/tests/i915/kms_cdclk.c
> +++ b/tests/i915/kms_cdclk.c
> @@ -24,6 +24,11 @@
>    *  Swati Sharma <swati2.sharma@intel.com>
>    */
>   
> +/**
> + * TEST: kms cdclk
> + * Category: Display
> + * Description: Test cdclk features : crawling and squashing
> + */
>   #include "igt.h"
>   
>   IGT_TEST_DESCRIPTION("Test cdclk features : crawling and squashing");
> @@ -248,6 +253,16 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
>   	igt_remove_fb(display->drm_fd, &fb);
>   }
>   
> +/**
> + * SUBTEST: mode-transition-all-outputs
> + * Description: Mode transition (low to high) test to validate cdclk frequency
> + *              change by simultaneous modesets on all pipes with valid outputs.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_mode_transition_on_all_outputs(data_t *data)
>   {
>   	igt_display_t *display = &data->display;
> @@ -344,6 +359,23 @@ static void test_mode_transition_on_all_outputs(data_t *data)
>   	igt_remove_fb(data->drm_fd, &fb);
>   }
>   
> +/**
> + * SUBTEST: mode-transition
> + * Description: Mode transition (low to high) test to validate cdclk frequency change.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-scaling
> + * Description: Plane scaling test to validate cdclk frequency change.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void run_cdclk_test(data_t *data, uint32_t flags)
>   {
>   	igt_display_t *display = &data->display;

Re: [igt-dev] [V5 i-g-t 68/81] tests/kms_rmfb: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_rmfb.c | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c
> index 9a41c1d14..7348251f8 100644
> --- a/tests/kms_rmfb.c
> +++ b/tests/kms_rmfb.c
> @@ -28,6 +28,30 @@
>   #include <stdio.h>
>   #include <string.h>
>   #include <time.h>
> +/**
> + * TEST: kms rmfb
> + * Category: Display
> + * Description: This tests rmfb and close-fd behavior. In these casesthe
> + *              framebuffers should be removed from the crtc.
> + *
> + * SUBTEST: close-fd
> + * Description: RMFB is supposed to free the framebuffers from any and all planes
> + *              so test this and make sure it works with fd close and reopen.
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: rmfb-ioctl
> + * Description: RMFB is supposed to free the framebuffers from any and all planes
> + *              so test this and make sure it works.
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   #ifndef DRM_CAP_CURSOR_WIDTH
>   #define DRM_CAP_CURSOR_WIDTH 0x8

Re: [igt-dev] [V5 i-g-t 51/81] tests/kms_getfb: Document each subtest for testplan

[Karthik B S]

Hi,

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_getfb.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 90 insertions(+)
>
> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
> index afcf07fe8..b35cd4152 100644
> --- a/tests/kms_getfb.c
> +++ b/tests/kms_getfb.c
> @@ -27,6 +27,11 @@
>    *
>    */
>   
> +/**
> + * TEST: kms getfb
> + * Category: Display
> + * Description: Tests GETFB and GETFB2 ioctls.
> + */
>   #include "igt.h"
>   #include <unistd.h>
>   #include <stdlib.h>
> @@ -169,6 +174,22 @@ static uint32_t get_any_prop_id(int fd)
>   	return 0;
>   }
>   
> +/**
> + * SUBTEST: getfb-handle-%s
> + * Description: Tests error handling %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_core
Should this also be 'kms_gem_interop', like in other fb related tests?
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @closed:       when passing a handle that has been closed.
> + * @not-fb:       when passing an invalid handle.
> + * @valid:        when passing an valid handle.
> + * @zero:         for a zero'd input.
> + */
>   static void test_handle_input(int fd)
>   {
>   	struct drm_mode_fb_cmd2 add = {};
> @@ -224,6 +245,30 @@ static void test_handle_input(int fd)
>   		gem_close(fd, add.handles[0]);
>   }
>   
> +/**
> + * SUBTEST: getfb-reject-ccs
> + * Description: Tests error handling while requesting CCS buffers it should
> + *              refuse because getfb supports returning a single buffer handle.
> + * Driver requirement: any
> + * Functionality: kms_core
Please add 'ccs' also here.
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: getfb-%s-different-handles
> + * Description: Tests error handling while requesting for two different handles
> + *              from %arg[1].
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @addfb:           same fd
> + * @repeated:        different fd
> + */
>   static void test_duplicate_handles(int fd)
>   {
>   	struct drm_mode_fb_cmd2 add = {};
> @@ -289,6 +334,37 @@ static void test_duplicate_handles(int fd)
>   	}
>   }
>   
> +/**
> + * SUBTEST: getfb2-accept-ccs
> + * Description: Tests outputs are correct when retrieving a CCS framebuffer.
> + * Driver requirement: any
> + * Functionality: kms_core

Please add 'ccs' also here.

Thanks,
Karthik.B.S
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: getfb2-into-addfb2
> + * Description: Output check by passing the output of GETFB2 into ADDFB2.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: getfb2-handle-%s
> + * Description: Tests error handling %arg[1].
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @closed:                  when passing a handle that has been closed
> + * @not-fb:                  when passing an invalid handle
> + * @zero:                    for a zero'd input
> + */
>   static void test_getfb2(int fd)
>   {
>   	struct drm_mode_fb_cmd2 add_basic = {};
> @@ -397,6 +473,20 @@ static void test_getfb2(int fd)
>   	}
>   }
>   
> +/**
> + * SUBTEST: %s-handle-protection
> + * Description: Make sure %arg[1] return handles if caller is non-root or non-master.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @getfb:      GETFB ioctl
> + * @getfb2:     GETFB2 ioctl
> + */
>   static void test_handle_protection(void) {
>   	int non_master_fd;
>   	struct drm_mode_fb_cmd2 non_master_add = {};

Re: [igt-dev] [V5 i-g-t 74/81] tests/kms_sysfs_edid_timing: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_sysfs_edid_timing.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 775211089..e185eaf6d 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -25,6 +25,27 @@
>   #include <dirent.h>
>   #include <fcntl.h>
>   #include <sys/stat.h>
> +/**
> + * TEST: kms sysfs edid timing
> + * Category: Display
> + * Description: This test checks the time it takes to reprobe each connector and
> + *              fails if either the time it takes for one reprobe is too long or
> + *              if the mean time it takes to reprobe one connector is too long.
> + *              Additionally, make sure that the mean time for all connectors is
> + *              not too long.
> + *
> + * SUBTEST:

There is no subtest defined in this test, still we are duplicating same 
description for test and subtest. Is this okay?

> + * Description: This test checks the time it takes to reprobe each connector and
> + *              fails if either the time it takes for one reprobe is too long or
> + *              if the mean time it takes to reprobe one connector is too long.
> + *              Additionally, make sure that the mean time for all connectors is
> + *              not too long.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   #define THRESHOLD_PER_CONNECTOR		150
>   #define THRESHOLD_PER_CONNECTOR_MEAN	140

Re: [igt-dev] [V5 i-g-t 77/81] tests/kms_vblank: Document each subtest for testplan

[Karthik B S]

Hi,

This patch has unaddressed comments on previous revision. Please take a 
look.

Thanks,
Karthik.B.S
On 6/29/2023 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_vblank.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 69 insertions(+)
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 1aa8c1083..86ff5fce8 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -40,6 +40,75 @@
>   #include <sys/wait.h>
>   
>   #include <drm.h>
> +/**
> + * TEST: kms vblank
> + * Category: Display
> + * Description: Test speed of WaitVblank.
> + *
> + * SUBTEST: crtc-id
> + * Description: check the Vblank and flip events works with given crtc id
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: invalid
> + * Description: Negative test for vblank request
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: pipe-%s-%s
> + * Description: Check if test run while hanging by introducing NOHANG flag (or)
> + *              Check if injected hang is working properly
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @A:
> + * @B:
> + * @C:
> + * @D:
> + * @E:
> + * @F:
> + * @G:
> + * @H:
> + *
> + * arg[2]:
> + *
> + * @accuracy-idle:
> + * @query-busy:
> + * @query-busy-hang:
> + * @query-forked:
> + * @query-forked-busy:
> + * @query-forked-busy-hang:
> + * @query-forked-hang:
> + * @query-idle:
> + * @query-idle-hang:
> + * @ts-continuation-dpms-rpm:
> + * @ts-continuation-dpms-suspend:
> + * @ts-continuation-idle:
> + * @ts-continuation-idle-hang:
> + * @ts-continuation-modeset:
> + * @ts-continuation-modeset-hang:
> + * @ts-continuation-modeset-rpm:
> + * @ts-continuation-suspend:
> + * @wait-busy:
> + * @wait-busy-hang:
> + * @wait-forked:
> + * @wait-forked-busy:
> + * @wait-forked-busy-hang:
> + * @wait-forked-hang:
> + * @wait-idle:
> + * @wait-idle-hang:
> + */
>   
>   IGT_TEST_DESCRIPTION("Test speed of WaitVblank.");
>   

Re: [igt-dev] [V5 i-g-t 71/81] tests/kms_selftest: Document each subtest for testplan

[Sharma, Swati2]

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> V2: - Fix the documentation for renamed tests
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_selftest.c | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/tests/kms_selftest.c b/tests/kms_selftest.c
> index 5495c24f2..940fc3d8d 100644
> --- a/tests/kms_selftest.c
> +++ b/tests/kms_selftest.c
> @@ -23,6 +23,29 @@
>   
>   #include "igt.h"
>   #include "igt_kmod.h"
> +/**
> + * TEST: kms selftest
> + * Category: Display
> + * Description: Basic sanity check of KMS selftests.
> + *
> + * SUBTEST: %s
> + * Description: Basic sanity check of KMS selftest %arg[1].
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drm_cmdline:            drm cmdline
> + * @drm_damage:             drm damage
> + * @drm_dp_mst:             drm dp mst
> + * @drm_format_helper:      drm format helper
> + * @drm_format:             drm format
> + * @drm_plane:              drm plane
> + * @framebuffer:            framebuffer
> + */
>   
>   IGT_TEST_DESCRIPTION("Basic sanity check of KMS selftests.");
>   

Re: [igt-dev] [V5 i-g-t 80/81] tests/testdisplay: Document each subtest for testplan

[Sharma, Swati2]

Hi Bhanu,

Review comments from v4 are not addressed in v5.

On 29-Jun-23 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/testdisplay.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index 294d4c604..2a88eb64e 100644
> --- a/tests/testdisplay.c
> +++ b/tests/testdisplay.c
> @@ -69,6 +69,19 @@
>   #include <stdlib.h>
>   #include <signal.h>
>   
> +/**
> + * TEST: testdisplay
> + * Category: Display
> + * Description: Tests basic display functionality.
> + *
> + * SUBTEST:
> + * Description: Tests basic display functionality.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   IGT_TEST_DESCRIPTION("Tests basic display functionality.");
>   
>   enum {

Re: [igt-dev] [V5 i-g-t 17/81] tests/i915/kms_fb_coherency: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/i915/kms_fb_coherency.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/tests/i915/kms_fb_coherency.c b/tests/i915/kms_fb_coherency.c
> index edb5ba460..8a553613a 100644
> --- a/tests/i915/kms_fb_coherency.c
> +++ b/tests/i915/kms_fb_coherency.c
> @@ -5,6 +5,7 @@
>   
>   /**
>    * TEST: kms_fb_coherency
> + * Category: Display
>    * Description: Exercise coherency of future scanout buffer objects
>    */
>   
> @@ -245,6 +246,9 @@ igt_main
>   	 *		mmapped with different mmap methods and different caching modes.
>   	 * Mega feature: General Display Features
>   	 * Functionality: gtt
> +	 * Driver requirement: any
> +	 * Run type: FULL
> +	 * Test category: functionality test
>   	 */
>   	igt_subtest_with_dynamic("memset-crc") {
>   		if (gem_has_mappable_ggtt(data.drm_fd)) {

Re: [igt-dev] [V5 i-g-t 78/81] tests/kms_vrr: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_vrr.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 47 insertions(+)
> 
> diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
> index 6a766bfb9..286f071e9 100644
> --- a/tests/kms_vrr.c
> +++ b/tests/kms_vrr.c
> @@ -24,6 +24,53 @@
>   #include "sw_sync.h"
>   #include <fcntl.h>
>   #include <signal.h>
> +/**
> + * TEST: kms vrr
> + * Category: Display
> + *
> + * SUBTEST: flip-basic
> + * Description: Tests that VRR is enabled and that the difference between flip
> + *              timestamps converges to the requested rate
> + * Driver requirement: any
> + * Functionality: vrr
> + * Mega feature: VRR
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-dpms
> + * Description: Tests with DPMS that VRR is enabled and that the difference
> + *              between flip timestamps converges to the requested rate.
> + * Driver requirement: any
> + * Functionality: vrr
> + * Mega feature: VRR
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flip-suspend
> + * Description: Tests that VRR is enabled and that the difference between flip
> + *              timestamps converges to the requested rate in a suspend test
> + * Driver requirement: any
> + * Functionality: vrr
> + * Mega feature: VRR
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: flipline
> + * Description: Make sure that flips happen at flipline decision boundary.
> + * Driver requirement: any
> + * Functionality: vrr
> + * Mega feature: VRR
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: negative-basic
> + * Description: Make sure that VRR should not be enabled on the Non-VRR panel.
> + * Driver requirement: any
> + * Functionality: vrr
> + * Mega feature: VRR

Shouldn't this be under Generic Display Features?

> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   #define NSECS_PER_SEC (1000000000ull)
>   

Re: [igt-dev] [V5 i-g-t 75/81] tests/kms_tv_load_detect: Document each subtest for testplan

[Sharma, Swati2]

Hi Bhanu,

Review comments from v4 are not addressed in v5.

On 29-Jun-23 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_tv_load_detect.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/tests/kms_tv_load_detect.c b/tests/kms_tv_load_detect.c
> index c8e5338d2..ceefe26d2 100644
> --- a/tests/kms_tv_load_detect.c
> +++ b/tests/kms_tv_load_detect.c
> @@ -23,6 +23,19 @@
>    */
>   
>   #include "igt.h"
> +/**
> + * TEST: kms tv load detect
> + * Category: Display
> + * Description: Check tv load detection works correctly.
> + *
> + * SUBTEST: load-detect
> + * Description: Check tv load detection works correctly.
> + * Driver requirement: any
> + * Functionality: obsolete
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Check tv load detection works correctly.");
>   

Re: [igt-dev] [V5 i-g-t 69/81] tests/kms_rotation_crc: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_rotation_crc.c | 130 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 130 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 5ad04407d..6009afe95 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -22,6 +22,11 @@
>    *
>    */
>   
> +/**
> + * TEST: kms rotation crc
> + * Category: Display
> + * Description: Tests different rotations with different planes & formats
> + */
>   #include "igt.h"
>   #include "igt_vec.h"
>   #include <math.h>
> @@ -474,6 +479,97 @@ static bool test_format(data_t *data,
>   	return true;
>   }
>   
> +/**
> + * SUBTEST: %s-rotation-180
> + * Description: Rotation test with 180 degree for %arg[1] planes
> + * Driver requirement: any
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @primary:    primary
> + * @sprite:     sprite
> + * @cursor:     cursor
> + */
> +
> +/**
> + * SUBTEST: %s-rotation-%d
> + * Description: Rotation test with %arg[2] degree for %arg[1] planes of gen9+
> + * Driver requirement: any
> + * Functionality: rotation

Should we add plane in functionality too?
Same with other subtests.

> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @primary:    primary
> + * @sprite:     sprite
> + *
> + * arg[2].values: 90, 270
> + */
> +
> +/**
> + * SUBTEST: bad-%s
> + * Description: Checking unsupported %arg[1] for gen9+ with 90 degree of rotation
> + * Driver requirement: any
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @pixel-format:       pixel format
> + * @tiling:             tiling
> + */
> +
> +/**
> + * SUBTEST: primary-%s-tiled-reflect-x-%d
> + * Description: Test for %arg[1] & %arg[2] degree rotation on primary plane
> + * Driver requirement: any
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @4:      4 tiling
> + * @x:      x tiling
> + * @y:      y tiling
> + * @yf:     yf tiling
> + *
> + * arg[2].values: 0, 180
> + */
> +
> +/**
> + * SUBTEST: primary-%s-tiled-reflect-x-%d
> + * Description: Test for %arg[1] & %arg[2] degree rotation on primary plane
> + * Driver requirement: any
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @y:      y tiling
> + * @yf:     yf tiling
> + *
> + * arg[2].values: 90, 270
> + *
> + * SUBTEST: sprite-rotation-90-pos-100-0
> + * Description: Rotation test with 90 degree for a plane of gen9+ with given position
> + * Driver requirement: any
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_format)
>   {
>   	igt_display_t *display = &data->display;
> @@ -792,6 +888,31 @@ static bool reusecrcfromlastround(planeinfos p[2], int lastroundp1format,
>   
>   	return true;
>   }
> +
> +/**
> + * SUBTEST: multiplane-rotation
> + * Description: Rotation test on both planes by making them fully visible
> + * Driver requirement: any
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: multiplane-rotation-cropping-%s
> + * Description: Rotation test on both planes by cropping left/%arg[1] corner of
> + *              primary plane and right/%arg[1] corner of sprite plane
> + * Driver requirement: any
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @bottom:   bottom
> + * @top:      top
> + */
> +
>   /*
>    * Here is pipe parameter which is now used only for first pipe.
>    * It is left here if this test ever was wanted to be run on
> @@ -993,6 +1114,15 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
>   	igt_require_f(found, "No valid pipe/output combo found.\n");
>   }
>   
> +/**
> + * SUBTEST: exhaust-fences
> + * Description: This test intends to check for fence leaks exhaustively
> + * Driver requirement: i915
> + * Functionality: rotation
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void test_plane_rotation_exhaust_fences(data_t *data,
>   					       enum pipe pipe,
>   					       igt_output_t *output,

Re: [igt-dev] [V5 i-g-t 38/81] tests/kms_color: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> V2: - Include ctm-signed test
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_color.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 91 insertions(+)
> 
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index b15b9572c..3c837d258 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -22,10 +22,24 @@
>    *
>    */
>   
> +/**
> + * TEST: kms color
> + * Category: Display
> + * Description: Test Color Features at Pipe level
> + */
>   #include "kms_color_helper.h"
>   
>   IGT_TEST_DESCRIPTION("Test Color Features at Pipe level");
>   
> +/**
> + * SUBTEST: degamma
> + * Description: Verify that degamma LUT transformation works correctly
> + * Driver requirement: any
> + * Functionality: colorspace
> + * Mega feature: Color mgmt
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static bool test_pipe_degamma(data_t *data,
>   			      igt_plane_t *primary)
>   {
> @@ -114,6 +128,16 @@ static bool test_pipe_degamma(data_t *data,
>   	return ret;
>   }
>   
> +/**
> + * SUBTEST: gamma
> + * Description: Verify that gamma LUT transformation works correctly
> + * Driver requirement: any
> + * Functionality: colorspace, colorspace_gamma

colorspace_gamma not required. Lets have unified functionality as 
colorspace since there is no colorspace_degamma, colorspace_ctm.

> + * Mega feature: Color mgmt
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
>   /*
>    * Draw 3 gradient rectangles in red, green and blue, with a maxed out gamma
>    * LUT and verify we have the same CRC as drawing solid color rectangles.
> @@ -202,6 +226,16 @@ static bool test_pipe_gamma(data_t *data,
>   	return ret;
>   }
>   
> +/**
> + * SUBTEST: legacy-gamma
> + * Description: Verify that legacy gamma LUT transformation works correctly
> + * Driver requirement: any
> + * Functionality: colorspace, colorspace_gamma
> + * Mega feature: Color mgmt
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
>   /*
>    * Draw 3 gradient rectangles in red, green and blue, with a maxed out legacy
>    * gamma LUT and verify we have the same CRC as drawing solid color rectangles
> @@ -314,6 +348,17 @@ static bool test_pipe_legacy_gamma(data_t *data,
>   	return ret;
>   }
>   
> +/**
> + * SUBTEST: legacy-gamma-reset
> + * Description: Verify that setting the legacy gamma LUT resets the gamma LUT
> + *              set through GAMMA_LUT property
> + * Driver requirement: any
> + * Functionality: colorspace, colorspace_gamma
> + * Mega feature: Color mgmt
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
>   /*
>    * Verify that setting the legacy gamma LUT resets the gamma LUT set
>    * through the GAMMA_LUT property.
> @@ -448,6 +493,28 @@ end:
>   	return ret;
>   }
>   
> +/**
> + * SUBTEST: ctm-%s
> + * Description: Check the color transformation %arg[1]
> + * Driver requirement: any
> + * Functionality: colorspace
> + * Mega feature: Color mgmt
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @0-25:           for 0.25 transparency
> + * @0-50:           for 0.50 transparency
> + * @0-75:           for 0.75 transparency
> + * @blue-to-red:    from blue to red
> + * @green-to-red:   from green to red
> + * @max:            for maximum transparency
> + * @negative:       for negative transparency
> + * @red-to-blue:    from red to blue
> + * @signed:         for correct signed handling
> + */
> +
>   /*
>    * Draw 3 rectangles using before colors with the ctm matrix apply and verify
>    * the CRC is equal to using after colors with an identify ctm matrix.
> @@ -807,6 +874,15 @@ out:
>   	test_cleanup(data);
>   }
>   
> +/**
> + * SUBTEST: deep-color
> + * Description: Verify that deep color works correctly
> + * Driver requirement: any
> + * Functionality: colorspace
> + * Mega feature: Color mgmt
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void
>   run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
>   {
> @@ -899,6 +975,21 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
>   	test_cleanup(data);
>   }
>   
> +/**
> + * SUBTEST: invalid-%s-sizes
> + * Description: Negative check for %arg[1] sizes
> + * Driver requirement: any
> + * Functionality: colorspace
> + * Mega feature: Color mgmt
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @ctm-matrix:         Color transformation matrix
> + * @degamma-lut:        Degamma LUT
> + * @gamma-lut:          Gamma LUT
> + */
>   static void
>   run_invalid_tests_for_pipe(data_t *data)
>   {

Re: [igt-dev] [V5 i-g-t 32/81] tests/kms_addfb_basic: Document each subtest for testplan

[Karthik B S]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_addfb_basic.c | 188 ++++++++++++++++++++++++++++++++--------
>   1 file changed, 152 insertions(+), 36 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 065f21975..114b9c0f8 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -26,8 +26,9 @@
>    */
>   
>   /**
> - * TEST: Sanity test for ioctls DRM_IOCTL_MODE_ADDFB2 & DRM_IOCTL_MODE_RMFB.
> + * TEST: kms addfb basic
>    * Category: Display
> + * Description: Sanity test for ioctls DRM_IOCTL_MODE_ADDFB2 & DRM_IOCTL_MODE_RMFB.
>    */
>   
>   #include "igt.h"
> @@ -66,33 +67,45 @@ static int legacy_addfb(int fd, struct drm_mode_fb_cmd *arg)
>   }
>   
>   /**
> - * SUBTEST: unused-handle
> - * Description: Test that addfb2 call fails correctly for unused handle
> + * SUBTEST: unused-%s
> + * Description: Test that addfb2 call fails correctly for unused %arg[1]
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
>    * Mega feature: General Display Features
>    *
> - * SUBTEST: unused-pitches
> - * Description: Test that addfb2 call fails correctly for unused pitches
> - * Test category: functionality test
> - * Run type: BAT
> - * Functionality: kms_gem_interop
> + * SUBTEST: clobberred-modifier
> + * Description: Check if addfb2 call works for clobbered modifier
> + * Driver requirement: i915
> + * Functionality: gtt, kms_gem_interop
>    * Mega feature: General Display Features
> - *
> - * SUBTEST: unused-offsets
> - * Description: Test that addfb2 call fails correctly for unused offset
> + * Run type: FULL
>    * Test category: functionality test
> - * Run type: BAT
> + *
> + * SUBTEST: invalid-smem-bo-on-discrete
> + * Description: Check if addfb2 with a system memory gem object fails correctly
> + *              if device requires local memory framebuffers
> + * Driver requirement: any
>    * Functionality: kms_gem_interop
>    * Mega feature: General Display Features
> - *
> - * SUBTEST: unused-modifier
> - * Description: Test that addfb2 call fails correctly for unused modifier
> + * Run type: FULL
>    * Test category: functionality test
> - * Run type: BAT
> + *
> + * SUBTEST: legacy-format
> + * Description: Check if addfb2 call works for legacy formats
> + * Driver requirement: any
>    * Functionality: kms_gem_interop
>    * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @handle:       Handle
> + * @pitches:      Pitches
> + * @offsets:      Offsets
> + * @modifier:     Modifiers
>    */
>   static void invalid_tests(int fd)
>   {
> @@ -310,6 +323,7 @@ static void invalid_tests(int fd)
>   /**
>    * SUBTEST: no-handle
>    * Description: Test that addfb2 call fails correctly without handle
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -317,6 +331,7 @@ static void invalid_tests(int fd)
>    *
>    * SUBTEST: basic
>    * Description: Check if addfb2 call works with given handle
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -324,6 +339,7 @@ static void invalid_tests(int fd)
>    *
>    * SUBTEST: bad-pitch-%i
>    * Description: bad-pitch-%arg[1]: Test that addfb2 call fails correctly for bad-pitches
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -378,6 +394,36 @@ static void pitch_tests(int fd)
>   		gem_close(fd, gem_bo);
>   }
>   
> +/**
> + * SUBTEST: basic-%s-tiled-legacy
> + * Description: Check if addfb2 and rmfb call works for basic %arg[1] test
> + * Driver requirement: any
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + *
> + * SUBTEST: framebuffer-vs-set-tiling
> + * Description: Check if addfb2 call works for x and y tiling
> + * Driver requirement: i915
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + *
> + * SUBTEST: tile-pitch-mismatch
> + * Description: Test that addfb2 call fails correctly for pitches mismatch
> + * Driver requirement: i915
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + *
> + * arg[1]:
> + *
> + * @x:        x-tiling
> + * @y:        y-tiling
> + */
>   static void tiling_tests(int fd)
>   {
>   	struct drm_mode_fb_cmd2 f = {};
> @@ -460,6 +506,7 @@ static void tiling_tests(int fd)
>   /**
>    * SUBTEST: size-max
>    * Description: Check if addfb2 call works with max size of buffer object
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -467,6 +514,7 @@ static void tiling_tests(int fd)
>    *
>    * SUBTEST: too-wide
>    * Description: Test that addfb2 call fails correctly with increased width of fb
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -474,6 +522,7 @@ static void tiling_tests(int fd)
>    *
>    * SUBTEST: too-high
>    * Description: Test that addfb2 call fails correctly with increased height of fb
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -481,6 +530,7 @@ static void tiling_tests(int fd)
>    *
>    * SUBTEST: bo-too-small
>    * Description: Test that addfb2 call fails correctly with small size of buffer object
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -488,10 +538,20 @@ static void tiling_tests(int fd)
>    *
>    * SUBTEST: small-bo
>    * Description: Check if addfb2 call works for given height
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
>    * Mega feature: General Display Features
> + *
> + * SUBTEST: bo-too-small-due-to-tiling
> + * Description: Test that addfb2 call fails correctly with small buffer object
> + *              after changing tile
> + * Driver requirement: any
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
>    */
>   static void size_tests(int fd)
>   {
> @@ -611,6 +671,7 @@ static void size_tests(int fd)
>   /**
>    * SUBTEST: addfb25-modifier-no-flag
>    * Description: Test that addfb2 call fails correctly for x-tiling with given modifier
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
> @@ -618,10 +679,35 @@ static void size_tests(int fd)
>    *
>    * SUBTEST: addfb25-bad-modifier
>    * Description: Test that addfb2 call fails correctly for irrelevant modifier
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
>    * Mega feature: General Display Features
> + *
> + * SUBTEST: addfb25-x-tiled-mismatch-legacy
> + * Description: Test that addfb2 call fails correctly for irrelevant x-tiling
> + * Driver requirement: any
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + *
> + * SUBTEST: addfb25-x-tiled-legacy
> + * Description: Check if addfb2 call works for x-tiling
> + * Driver requirement: any
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + *
> + * SUBTEST: addfb25-framebuffer-vs-set-tiling
> + * Description: Check if addfb2 call works for relevant combination of tiling and fbs
> + * Driver requirement: any
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
>    */
>   static void addfb25_tests(int fd)
>   {
> @@ -705,6 +791,28 @@ static int addfb_expected_ret(igt_display_t *disp, struct drm_mode_fb_cmd2 *f)
>   					  f->modifier[0]) ? 0 : -1;
>   }
>   
> +/**
> + * SUBTEST: addfb25-y-tiled-%s
> + * Description: Check if addfb2 call works for y-tiling %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: addfb25-yf-tiled-legacy
> + * Description: Check if addfb2 call works for yf-tiling
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @legacy:               with default size
> + * @small-legacy:         with given size & modifier
> + */
>   static void addfb25_ytile(int fd)
>   {
>   	struct drm_mode_fb_cmd2 f = {};
> @@ -771,6 +879,15 @@ static void addfb25_ytile(int fd)
>   	}
>   }
>   
> +/**
> + * SUBTEST: addfb25-4-tiled
> + * Description: Check if addfb2 call works for tiling-4
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void addfb25_4tile(int fd)
>   {
>   	struct drm_mode_fb_cmd2 f = {};
> @@ -810,33 +927,23 @@ static void addfb25_4tile(int fd)
>   }
>   
>   /**
> - * SUBTEST: invalid-get-prop-any
> - * Description: Test that get-properties ioctl call fails correctly for invalid object type
> + * SUBTEST: invalid-%s-%s
> + * Description: Test that %arg[1] ioctl call fails correctly for %arg[2] object
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_gem_interop
>    * Mega feature: General Display Features
>    *
> - * SUBTEST: invalid-get-prop
> - * Description: Test that get-properties ioctl call fails correctly for fb mode object
> - * Test category: functionality test
> - * Run type: BAT
> - * Functionality: kms_gem_interop
> - * Mega feature: General Display Features
> + * arg[1]:
>    *
> - * SUBTEST: invalid-set-prop-any
> - * Description: Test that set-properties ioctl call fails correctly for invalid object type
> - * Test category: functionality test
> - * Run type: BAT
> - * Functionality: kms_gem_interop
> - * Mega feature: General Display Features
> + * @get:           get-properties
> + * @set:           set-properties
>    *
> - * SUBTEST: invalid-set-prop
> - * Description: Test that get-properties ioctl call fails correctly for fb mode object
> - * Test category: functionality test
> - * Run type: BAT
> - * Functionality: kms_gem_interop
> - * Mega feature: General Display Features
> + * arg[2]:
> + *
> + * @prop:          fb mode
> + * @prop-any:      invalid
>    */
>   static void prop_tests(int fd)
>   {
> @@ -903,6 +1010,15 @@ static void prop_tests(int fd)
>   	}
>   }
>   
> +/**
> + * SUBTEST: master-rmfb
> + * Description: Check that only master can rmfb
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void master_tests(int fd)
>   {
>   	struct drm_mode_fb_cmd2 f = {};

Re: [igt-dev] [V5 i-g-t 19/81] tests/i915/kms_fence_pin_leak: Document each subtest for testplan

[Karthik B S]

Hi,

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_fence_pin_leak.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/tests/i915/kms_fence_pin_leak.c b/tests/i915/kms_fence_pin_leak.c
> index 3d63acfef..0321aa3cb 100644
> --- a/tests/i915/kms_fence_pin_leak.c
> +++ b/tests/i915/kms_fence_pin_leak.c
> @@ -30,6 +30,19 @@
>   
>   #include "i915/gem.h"
>   #include "igt.h"
> +/**
> + * TEST: kms fence pin leak
> + * Category: Display
> + * Description: Exercises full ppgtt fence pin_count leak in the kernel.

This test actually has no subtest defined. Do we need duplicate 
definitions in this case?

Thanks,
Karthik.B.S

> + *
> + * SUBTEST:
> + * Description: Exercises full ppgtt fence pin_count leak in the kernel.
> + * Driver requirement: i915
> + * Functionality: kms_core, synchronization
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Exercises full ppgtt fence pin_count leak in the "
>   		     "kernel.");

Re: [igt-dev] [V5 i-g-t 30/81] tests/i915/kms_pwrite_crc: Document each subtest for testplan

[Karthik B S]

Hi,

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_pwrite_crc.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/tests/i915/kms_pwrite_crc.c b/tests/i915/kms_pwrite_crc.c
> index 7bddeecba..38f466bae 100644
> --- a/tests/i915/kms_pwrite_crc.c
> +++ b/tests/i915/kms_pwrite_crc.c
> @@ -29,6 +29,21 @@
>   #include <stdio.h>
>   #include <string.h>
>   
> +/**
> + * TEST: kms pwrite crc
> + * Category: Display
> + * Description: Use the display CRC support to validate pwrite to an already
> + *              uncached future scanout buffer.

This test actually has no subtest defined. Do we need to duplicate 
definitions in this case?

Thanks,
Karthik.B.S
> + *
> + * SUBTEST:
> + * Description: Use the display CRC support to validate pwrite to an already
> + *              uncached future scanout buffer.
> + * Driver requirement: i915
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION(
>      "Use the display CRC support to validate pwrite to an already uncached future scanout buffer.");

Re: [igt-dev] [V5 i-g-t 45/81] tests/kms_dither: Document each subtest for testplan

[Sharma, Swati2]

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_dither.c | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> diff --git a/tests/kms_dither.c b/tests/kms_dither.c
> index d6c16dd0b..79a002d46 100644
> --- a/tests/kms_dither.c
> +++ b/tests/kms_dither.c
> @@ -25,6 +25,11 @@
>    *
>    */
>   
> +/**
> + * TEST: kms dither
> + * Category: Display
> + * Description: Test Dithering block status
> + */
>   #include "igt.h"
>   #include <fcntl.h>
>   #include <termios.h>
> @@ -181,6 +186,23 @@ static bool is_supported(igt_output_t *output)
>   		igt_output_get_prop(output, IGT_CONNECTOR_MAX_BPC);
>   }
>   
> +/**
> + * SUBTEST: FB-8BPC-Vs-Panel-6BPC
> + * Description: Framebuffer BPC:8, Panel BPC:6, Expected Dither:Enable
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: FB-8BPC-Vs-Panel-8BPC
> + * Description: Framebuffer BPC:8, Panel BPC:8, Expected Dither:Disable
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void
>   run_dither_test(data_t *data, int fb_bpc, int fb_format, int output_bpc)
>   {

Re: [igt-dev] [V5 i-g-t 23/81] tests/i915/kms_legacy_colorkey: Document each subtest for testplan

[Sharma, Swati2]

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_legacy_colorkey.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/tests/i915/kms_legacy_colorkey.c b/tests/i915/kms_legacy_colorkey.c
> index 450cb2e3f..fb1952113 100644
> --- a/tests/i915/kms_legacy_colorkey.c
> +++ b/tests/i915/kms_legacy_colorkey.c
> @@ -24,6 +24,27 @@
>   #include "igt.h"
>   #include <errno.h>
>   
> +/**
> + * TEST: kms legacy colorkey
> + * Category: Display
> + * Description: Check that the legacy set colorkey ioctl only works on sprite planes.
> + *
> + * SUBTEST: basic
> + * Description: Test to check the legacy set colorkey ioctl only works for sprite planes.

Test description and subtest description is same.

> + * Driver requirement: i915
> + * Functionality: xorg_xv
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: invalid-plane
> + * Description: Check invalid plane id's, zero and outrange
> + * Driver requirement: i915
> + * Functionality: xorg_xv
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Check that the legacy set colorkey ioctl only works on sprite planes.");
>   

Re: [igt-dev] [V5 i-g-t 24/81] tests/i915/kms_mmap_write_crc: Document each subtest for testplan

[Sharma, Swati2]

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_mmap_write_crc.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/tests/i915/kms_mmap_write_crc.c b/tests/i915/kms_mmap_write_crc.c
> index 5a9eeec48..2a51d77ac 100644
> --- a/tests/i915/kms_mmap_write_crc.c
> +++ b/tests/i915/kms_mmap_write_crc.c
> @@ -37,6 +37,20 @@
>   #include "intel_chipset.h"
>   #include "ioctl_wrappers.h"
>   #include "igt_aux.h"
> +/**
> + * TEST: kms mmap write crc
> + * Category: Display
> + * Description: Use the display CRC support to validate mmap write to an already
> + *              uncached future scanout buffer.
> + *
> + * SUBTEST: main
> + * Description: Tests that caching mode has become UC/WT and flushed using mmap write
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION(
>      "Use the display CRC support to validate mmap write to an already uncached future scanout buffer.");

Re: [igt-dev] [V5 i-g-t 39/81] tests/kms_concurrent: Document each subtest for testplan

[Sharma, Swati2]

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_concurrent.c | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index d915a98b2..f5fe321a2 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -24,6 +24,32 @@
>   
>   #include "igt.h"
>   #include "drmtest.h"
> +/**
> + * TEST: kms concurrent
> + * Category: Display
> + * Description: Test atomic mode setting concurrently with multiple planes and
> + *              screen resolution
> + *
> + * SUBTEST: pipe-%s
> + * Description: Test atomic mode setting concurrently with multiple planes and
> + *              screen resolution on %arg[1].
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @A:      pipe A
> + * @B:      pipe B
> + * @C:      pipe C
> + * @D:      pipe D
> + * @E:      pipe E
> + * @F:      pipe F
> + * @G:      pipe G
> + * @H:      pipe H
> + */
>   
>   IGT_TEST_DESCRIPTION("Test atomic mode setting concurrently with multiple planes and screen resolution");
>   

Re: [igt-dev] [V5 i-g-t 66/81] tests/kms_prop_blob: Document each subtest for testplan

[Sharma, Swati2]

LGTM.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_prop_blob.c | 46 ++++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 45 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_prop_blob.c b/tests/kms_prop_blob.c
> index fc172b5a3..e4f5dd71f 100644
> --- a/tests/kms_prop_blob.c
> +++ b/tests/kms_prop_blob.c
> @@ -26,8 +26,9 @@
>    */
>   
>   /**
> - * TEST: Tests behaviour of mass-data 'blob' properties
> + * TEST: kms prop blob
>    * Category: Display
> + * Description: Tests behaviour of mass-data 'blob' properties.
>    */
>   #include "igt.h"
>   #include <errno.h>
> @@ -122,6 +123,29 @@ destroy_prop(int fd, uint32_t prop_id)
>   	return 0;
>   }
>   
> +/**
> + * SUBTEST: blob-multiple
> + * Description: Test validates destroying multiple properties explicitly works as needed.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: blob-prop-%s
> + * Description: Tests validates the %arg[1] of the properties created.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @core:        validity
> + * @lifetime:    lifetime
> + * @validate:    blob size
> + */
>   static void
>   test_validate(int fd)
>   {
> @@ -245,6 +269,7 @@ test_core(int fd)
>   /**
>    * SUBTEST: basic
>    * Description: Test to ensure property support exists
> + * Driver requirement: any
>    * Test category: functionality test
>    * Run type: BAT
>    * Functionality: kms_core
> @@ -260,6 +285,25 @@ test_basic(int fd)
>   	igt_assert_eq(destroy_prop(fd, prop_id), 0);
>   }
>   
> +/**
> + * SUBTEST: invalid-%s-%s
> + * Description: Tests error handling when invalid properties are %ar[1] with %arg[2].
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @get:            fetched
> + * @set:            set
> + *
> + * arg[2]:
> + *
> + * @prop:           blob object type
> + * @prop-any:       object of any type
> + */
>   static void prop_tests(int fd)
>   {
>   	struct drm_mode_obj_get_properties get_props = {};

Re: [igt-dev] [V5 i-g-t 67/81] tests/kms_properties: Document each subtest for testplan

[Sharma, Swati2]

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_properties.c | 40 ++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 40 insertions(+)
> 
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index 8645808d1..197c72065 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -28,6 +28,31 @@
>   #include <stdio.h>
>   #include <string.h>
>   #include <time.h>
> +/**
> + * TEST: kms properties
> + * Category: Display
> + *
> + * SUBTEST: %s-properties-%s
> + * Description: Tests %arg[1] properties with %arg[2] commit
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @connector:       Connector
> + * @crtc:            CRTC
> + * @plane:           Plane
> + * @invalid:         Invalid (connector/crtc/plane)
> + *
> + * arg[2]:
> + *
> + * @atomic:          atomic
> + * @legacy:          legacy
> + */
> +
>   
>   struct additional_test {
>   	const char *name;
> @@ -687,6 +712,21 @@ static void expect_no_props(int fd, uint32_t obj_type, uint32_t obj_id)
>   	igt_assert_neq(drmIoctl(fd, DRM_IOCTL_MODE_OBJ_GETPROPERTIES, &properties), 0);
>   }
>   
> +/**
> + * SUBTEST: get_properties-sanity-%s
> + * Description: Test validates the properties of all planes, crtc and connectors
> + *              with %arg[1] commit
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @atomic:          atomic
> + * @non-atomic:      legacy
> + */
>   static void get_prop_sanity(igt_display_t *display, bool atomic)
>   {
>   	int fd = display->drm_fd;

Re: [igt-dev] [V5, i-g-t, 34/81] tests/kms_atomic: Document each subtest for testplan

[Gupta, Nidhi1]

LGTM
Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com>

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_atomic.c | 102 ++++++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 100 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index b65045abc..f07d47abc 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -27,8 +27,10 @@
>    *    Pekka Paalanen <pekka.paalanen@collabora.co.uk>
>    */
>   
> -/*
> - * Testcase: testing atomic modesetting API
> +/**
> + * TEST: kms atomic
> + * Category: Display
> + * Description: Test atomic modesetting API
>    */
>   
>   #include <unistd.h>
> @@ -287,6 +289,16 @@ static uint32_t plane_get_igt_format(igt_plane_t *plane)
>   	return 0;
>   }
>   
> +/**
> + * SUBTEST: plane-primary-overlay-mutable-zpos
> + * Description: Verify that the overlay plane can cover the primary one (and
> + *              vice versa) by changing their zpos property.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void
>   plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
>   				   igt_plane_t *primary, igt_plane_t *overlay,
> @@ -369,6 +381,16 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
>   	igt_assert_eq_u64(igt_plane_get_prop(overlay, IGT_PLANE_ZPOS), 1);
>   }
>   
> +/**
> + * SUBTEST: plane-immutable-zpos
> + * Description: Verify the reported zpos property of planes by making sure only
> + *              higher zpos planes cover the lower zpos ones.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void
>   plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>   		     igt_output_t *output)
> @@ -505,6 +527,22 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>   	igt_remove_fb(display->drm_fd, &fb_upper);
>   }
>   
> +/**
> + * SUBTEST: plane-%s-legacy
> + * Description: Test for KMS atomic modesetting on %arg[1] and ensure coherency
> + *              between legacy and atomic interfaces.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @cursor:         Cursor plane
> + * @overlay:        Overlay plane
> + * @primary:        Primary plane
> + */
>   static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *plane)
>   {
>   	drmModeModeInfo *mode = igt_output_get_mode(output);
> @@ -579,6 +617,17 @@ static void plane_primary(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *f
>   	plane_commit(plane, COMMIT_UNIVERSAL, ATOMIC_RELAX_NONE);
>   }
>   
> +/**
> + * SUBTEST: test-only
> + * Description: Test to ensure that DRM_MODE_ATOMIC_TEST_ONLY really only touches
> + *              the free-standing state objects and nothing else.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
>   /* test to ensure that DRM_MODE_ATOMIC_TEST_ONLY really only touches the
>    * free-standing state objects and nothing else.
>    */
> @@ -687,6 +736,20 @@ static void plane_cursor(igt_pipe_t *pipe_obj,
>   	plane_commit(cursor, COMMIT_LEGACY, ATOMIC_RELAX_NONE);
>   }
>   
> +/**
> + * SUBTEST: plane-invalid-%s
> + * Description: Test error handling when invalid %arg[1] are passed
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @params:           plane parameters
> + * @params-fence:     plane fence parameters
> + */
>   static void plane_invalid_params(igt_pipe_t *pipe,
>   				 igt_output_t *output,
>   				 igt_plane_t *plane,
> @@ -776,6 +839,20 @@ static void plane_invalid_params_fence(igt_pipe_t *pipe,
>   	close(timeline);
>   }
>   
> +/**
> + * SUBTEST: crtc-invalid-%s
> + * Description: Test error handling when invalid %arg[1] are passed
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @params:           crtc parameters
> + * @params-fence:     crtc fence parameters
> + */
>   static void crtc_invalid_params(igt_pipe_t *pipe,
>   				igt_output_t *output,
>   				igt_plane_t *plane,
> @@ -923,6 +1000,18 @@ static void crtc_invalid_params_fence(igt_pipe_t *pipe,
>   	igt_assert(pipe->out_fence_fd != -1);
>   }
>   
> +/**
> + * SUBTEST: atomic-invalid-params
> + * Description: Test abuse the atomic ioctl directly in order to test various
> + *              invalid conditions which the libdrm wrapper won't allow us to
> + *              create.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
>   /* Abuse the atomic ioctl directly in order to test various invalid conditions,
>    * which the libdrm wrapper won't allow us to create. */
>   static void atomic_invalid_params(igt_pipe_t *pipe,
> @@ -1064,6 +1153,15 @@ static void atomic_invalid_params(igt_pipe_t *pipe,
>   	do_ioctl_err(display->drm_fd, DRM_IOCTL_MODE_ATOMIC, &ioc, EFAULT);
>   }
>   
> +/**
> + * SUBTEST: atomic_plane_damage
> + * Description: Simple test cases to use FB_DAMAGE_CLIPS plane property
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *fb)
>   {
>   	struct drm_mode_rect damage[2];

-- 
~Nidhi Gupta

Re: [igt-dev] [V5, i-g-t, 35/81] tests/kms_atomic_interruptible: Document each subtest for testplan

[Gupta, Nidhi1]

LGTM
Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com>

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_atomic_interruptible.c | 50 ++++++++++++++++++++++++++++++++
>   1 file changed, 50 insertions(+)
> 
> diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
> index 2acdcb29d..10bfa6c1b 100644
> --- a/tests/kms_atomic_interruptible.c
> +++ b/tests/kms_atomic_interruptible.c
> @@ -21,6 +21,11 @@
>    * IN THE SOFTWARE.
>    */
>   
> +/**
> + * TEST: kms atomic interruptible
> + * Category: Display
> + * Description: Tests that interrupt various atomic ioctls.
> + */
>   #include <signal.h>
>   
>   #include "igt.h"
> @@ -74,6 +79,51 @@ static drmEventContext drm_events = {
>   	.page_flip_handler = ev_page_flip
>   };
>   
> +/**
> + * SUBTEST: %s-setmode
> + * Description: Tests the interrupt properties of %arg[1] modeset
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @atomic:      atomic
> + * @legacy:      legacy
> + */
> +
> +/**
> + * SUBTEST: legacy-%s
> + * Description: Tests the interrupt properties for %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @cursor:         Cursor
> + * @dpms:           DPMS
> + * @pageflip:       Page flip
> + */
> +
> +/**
> + * SUBTEST: universal-setplane-%s
> + * Description: Tests the interrupt properties for %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @cursor:         Cursor plane
> + * @primary:        Primary plane
> + */
>   static void run_plane_test(igt_display_t *display, enum pipe pipe, igt_output_t *output,
>   			   enum plane_test_type test_type, unsigned plane_type)
>   {

-- 
~Nidhi Gupta

Re: [igt-dev] [V5, i-g-t, 36/81] tests/kms_atomic_transition: Document each subtest for testplan

[Gupta, Nidhi1]

LGTM
Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com>

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_atomic_transition.c | 100 ++++++++++++++++++++++++++++++++++
>   1 file changed, 100 insertions(+)
> 
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 6ab5267ca..196736df2 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -21,6 +21,10 @@
>    * IN THE SOFTWARE.
>    */
>   
> +/**
> + * TEST: kms atomic transition
> + * Category: Display
> + */
>   #include "igt.h"
>   #include "igt_rand.h"
>   #include "drmtest.h"
> @@ -58,6 +62,15 @@ int *timeline;
>   pthread_t *thread;
>   int *seqno;
>   
> +/**
> + * SUBTEST: plane-primary-toggle-with-vblank-wait
> + * Description: Check toggling of primary plane with vblank
> + * Driver requirement: any
> + * Functionality: watermark
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   static void
>   run_primary_test(data_t *data, enum pipe pipe, igt_output_t *output)
>   {
> @@ -470,6 +483,77 @@ static void wait_for_transition(data_t *data, enum pipe pipe, bool nonblocking,
>   	}
>   }
>   
> +/**
> + * SUBTEST: plane-all-modeset-%s
> + * Description: Modeset test for all plane combinations %arg[1]
> + * Driver requirement: any
> + * Functionality: watermark
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @transition:                           default
> + * @transition-fencing:                   with fencing commit
> + */
> +
> +/**
> + * SUBTEST: plane-all-modeset-%s
> + * Description: Modeset test for all plane combinations %arg[1]
> + * Driver requirement: any
> + * Functionality: watermark
> + * Mega feature: eDP
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @transition-fencing-internal-panels:   on internal panels with fencing commit
> + * @transition-internal-panels:           on internal panels
> + */
> +
> +/**
> + * SUBTEST: plane-all-%s
> + * Description: Transition test for all plane combinations %arg[1]
> + * Driver requirement: any
> + * Functionality: watermark
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @transition:                           default
> + * @transition-fencing:                   with fencing commit
> + * @transition-nonblocking:               with non-blocking commit
> + * @transition-nonblocking-fencing:       with non-blocking & fencing commit
> + */
> +
> +/**
> + * SUBTEST: plane-toggle-modeset-transition
> + * Description: Check toggling and modeset transition on plane
> + * Driver requirement: any
> + * Functionality: watermark
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: plane-use-after-nonblocking-%s
> + * Description: Transition test with non %arg[1] and make sure commit of disabled
> + *              plane has to complete before atomic commit on that plane
> + * Driver requirement: any
> + * Functionality: watermark
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @unbind:           blocking commit
> + * @unbind-fencing:   blocking commit with fencing
> + */
> +
>   /*
>    * 1. Set primary plane to a known fb.
>    * 2. Make sure getcrtc returns the correct fb id.
> @@ -959,6 +1043,22 @@ retry:
>   	}
>   }
>   
> +/**
> + * SUBTEST: modeset-%s
> + * Description: Modeset transition tests for combinations of %arg[1]
> + * Driver requirement: any
> + * Functionality: watermark
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @transition:                     crtc enabled
> + * @transition-fencing:             crtc enabled with fencing commit
> + * @transition-nonblocking:         crtc enabled with nonblocking commit
> + * @transition-nonblocking-fencing: crtc enabled with nonblocking & fencing commit
> + */
>   static void run_modeset_transition(data_t *data, int requested_outputs, bool nonblocking, bool fencing)
>   {
>   	igt_output_t *outputs[IGT_MAX_PIPES] = {};

-- 
~Nidhi Gupta

Re: [igt-dev] [V5, i-g-t, 72/81] tests/kms_sequence: Document each subtest for testplan

[Gupta, Nidhi1]

LGTM
Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com>

On 6/29/2023 8:19 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_sequence.c | 36 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 36 insertions(+)
> 
> diff --git a/tests/kms_sequence.c b/tests/kms_sequence.c
> index 1b96f0017..12c3396f5 100644
> --- a/tests/kms_sequence.c
> +++ b/tests/kms_sequence.c
> @@ -27,6 +27,11 @@
>    * This is a test of drmCrtcGetSequence and drmCrtcQueueSequence
>    */
>   
> +/**
> + * TEST: kms sequence
> + * Category: Display
> + * Description: Test CrtcGetSequence and CrtcQueueSequence.
> + */
>   #include "igt.h"
>   #include <stdlib.h>
>   #include <stdio.h>
> @@ -136,6 +141,37 @@ static int crtc_queue_sequence(int fd, struct drm_crtc_queue_sequence *cqs)
>   	return err;
>   }
>   
> +/**
> + * SUBTEST: get-%s
> + * Description: This is a test of drmCrtcGetSequence and drmCrtcQueueSequence
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @busy:
> + * @forked:
> + * @forked-busy:
> + * @idle:
> + */
> +
> +/**
> + * SUBTEST: queue-%s
> + * Description: This is a test of drmCrtcGetSequence and drmCrtcQueueSequence
> + * Driver requirement: any
> + * Functionality: vblank
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @busy:
> + * @idle:
> + */
>   static void run_test(data_t *data, int fd, void (*testfunc)(data_t *, int, int))
>   {
>   	int nchildren =

-- 
~Nidhi Gupta

Re: [igt-dev] [V5, i-g-t, 18/81] tests/i915/kms_fbcon_fbt: Document each subtest for testplan

[Gupta, Nidhi1]

LGTM
Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com>

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_fbcon_fbt.c | 42 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 42 insertions(+)
> 
> diff --git a/tests/i915/kms_fbcon_fbt.c b/tests/i915/kms_fbcon_fbt.c
> index 71c5285f1..990d31a23 100644
> --- a/tests/i915/kms_fbcon_fbt.c
> +++ b/tests/i915/kms_fbcon_fbt.c
> @@ -32,6 +32,48 @@
>   #include <sys/stat.h>
>   #include <fcntl.h>
>   
> +/**
> + * TEST: kms fbcon fbt
> + * Category: Display
> + * Description: Test the relationship between fbcon and the frontbuffer tracking
> + *              infrastructure.
> + *
> + * SUBTEST: fbc
> + * Description: Test the relationship between fbcon and the frontbuffer tracking
> + *              infrastructure with fbc enabled.
> + * Driver requirement: any
> + * Functionality: fbc, fbcon
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: fbc-suspend
> + * Description: Suspend test to validate  the relationship between fbcon and the
> + *              frontbuffer tracking infrastructure with fbc enabled.
> + * Driver requirement: any
> + * Functionality: fbc, fbcon
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: psr
> + * Description: Test the relationship between fbcon and the frontbuffer tracking
> + *              infrastructure with psr enabled.
> + * Driver requirement: any
> + * Functionality: fbcon, psr
> + * Mega feature: PSR
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: psr-suspend
> + * Description: Suspend test to validate the relationship between fbcon and the
> + *              frontbuffer tracking infrastructure with psr enabled.
> + * Driver requirement: any
> + * Functionality: fbcon, psr
> + * Mega feature: PSR
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Test the relationship between fbcon and the frontbuffer "
>   		     "tracking infrastructure.");

-- 
~Nidhi Gupta

Re: [igt-dev] [V5 i-g-t 55/81] tests/kms_lease: Document each subtest for testplan

[Thasleem, Mohammed]

LGTM:
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Bhanuprakash Modem
Sent: Thursday, June 29, 2023 8:19 PM
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [V5 i-g-t 55/81] tests/kms_lease: Document each subtest for testplan

Add documentation for all kms tests which is used by IGT testplan documentation.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_lease.c | 180 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 180 insertions(+)

diff --git a/tests/kms_lease.c b/tests/kms_lease.c index c8ae98206..2f41ab52f 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -26,6 +26,11 @@
  * This is a test of DRM leases
  */
 
+/**
+ * TEST: kms lease
+ * Category: Display
+ * Description: Test of CreateLease.
+ */
 
 #include "igt.h"
 #include <stdlib.h>
@@ -45,6 +50,181 @@
 #include <drm.h>
 #include "igt_device.h"
 
+/**
+ * SUBTEST: atomic_implicit_crtc
+ * Description: Negative test by using a different crtc with atomic 
+ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: cursor_implicit_plane
+ * Description: Negative test by using a non-primary plane with 
+setcursor ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: empty_lease
+ * Description: Check that creating an empty lease works
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: implicit-plane-lease
+ * Description: Tests the implicitly added planes.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: invalid-create-leases
+ * Description: Tests error handling while creating invalid corner-cases for
+ *              create-lease ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease-uevent
+ * Description: Tests all the uevent cases
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_again
+ * Description: Tests leasing objects more than once
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_get
+ * Description: Tests getting the required contents of a lease
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_invalid_connector
+ * Description: Tests leasing an invalid connector
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_invalid_crtc
+ * Description: Tests leasing an invalid crtc
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_invalid_plane
+ * Description: Tests leasing an invalid plane
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_revoke
+ * Description: Tests revocation of lease
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_unleased_connector
+ * Description: Negative test by trying to use an unleased connector
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lease_unleased_crtc
+ * Description: Negative test by trying to use an unleased crtc
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: lessee_list
+ * Description: Check if listed lease is same as created one
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: master-vs-lease
+ * Description: Tests the drop/set_master interactions.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: multimaster-lease
+ * Description: Tests that the 2nd master can only create leases while being
+ *              active master, and that leases on the first master don't prevent
+ *              lease creation for the 2nd master.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: page_flip_implicit_plane
+ * Description: Negative test by using a non-primary plane with the 
+page flip ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: possible-crtcs-filtering
+ * Description: Tests that  possible_crtcs logically match between master and
+ *              lease, and that the values are correctly renumbered on the lease
+ *              side.
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: setcrtc_implicit_plane
+ * Description: Negative test by using a non-primary plane with the 
+setcrtc ioctl
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ *
+ * SUBTEST: simple_lease
+ * Description: Check if create lease ioctl call works
+ * Driver requirement: any
+ * Functionality: lease
+ * Mega feature: General Display Features
+ * Run type: FULL
+ * Test category: functionality test
+ */
+
 IGT_TEST_DESCRIPTION("Test of CreateLease.");
 
 typedef struct {
--
2.40.0

[igt-dev] ✗ Fi.CI.BUILD: failure for Document KMS tests (rev13)

[Patchwork]

== Series Details ==

Series: Document KMS tests (rev13)
URL   : https://patchwork.freedesktop.org/series/117749/
State : failure

== Summary ==

Applying: testplan/kms: Keep category as high level entity
Applying: testplan/kms: Add support to differentiate b/w drivers
Applying: testplan/kms: Include testdisplay to kms testplan config
Applying: testplan/kms: Exclude kms helpers form testplan
Applying: tests/chamelium/kms_chamelium_audio: Document each subtest for testplan
Applying: tests/chamelium/kms_chamelium_color: Document each subtest for testplan
Applying: tests/chamelium/kms_chamelium_edid: Document each subtest for testplan
Applying: tests/chamelium/kms_chamelium_frames: Document each subtest for testplan
Applying: tests/chamelium/kms_chamelium_hpd: Document each subtest for testplan
Applying: tests/i915/kms_big_fb: Document each subtest for testplan
Applying: tests/i915/kms_big_joiner: Document each subtest for testplan
Applying: tests/i915/kms_busy: Document each subtest for testplan
Applying: tests/i915/kms_ccs: Document each subtest for testplan
Applying: tests/i915/kms_cdclk: Document each subtest for testplan
Applying: tests/i915/kms_draw_crc: Document each subtest for testplan
Applying: tests/i915/kms_dsc: Document each subtest for testplan
Using index info to reconstruct a base tree...
M	tests/i915/kms_dsc.c
Falling back to patching base and 3-way merge...
Auto-merging tests/i915/kms_dsc.c
Applying: tests/i915/kms_fb_coherency: Document each subtest for testplan
Applying: tests/i915/kms_fbcon_fbt: Document each subtest for testplan
Applying: tests/i915/kms_fence_pin_leak: Document each subtest for testplan
Applying: tests/i915/kms_flip_scaled_crc: Document each subtest for testplan
Applying: tests/i915/kms_flip_tiling: Document each subtest for testplan
Applying: tests/i915/kms_frontbuffer_tracking: Document each subtest for testplan
Applying: tests/i915/kms_legacy_colorkey: Document each subtest for testplan
Applying: tests/i915/kms_mmap_write_crc: Document each subtest for testplan
Applying: tests/i915/kms_pipe_b_c_ivb: Document each subtest for testplan
Applying: tests/i915/kms_psr: Document each subtest for testplan
Using index info to reconstruct a base tree...
M	tests/i915/kms_psr.c
Falling back to patching base and 3-way merge...
Auto-merging tests/i915/kms_psr.c
Applying: tests/i915/kms_psr2_sf: Document each subtest for testplan
Applying: tests/i915/kms_psr2_su: Document each subtest for testplan
Applying: tests/i915/kms_psr_stress_test: Document each subtest for testplan
Applying: tests/i915/kms_pwrite_crc: Document each subtest for testplan
Applying: tests/kms_3d: Document each subtest for testplan
Applying: tests/kms_addfb_basic: Document each subtest for testplan
Applying: tests/kms_async_flips: Document each subtest for testplan
Applying: tests/kms_atomic: Document each subtest for testplan
Applying: tests/kms_atomic_interruptible: Document each subtest for testplan
Applying: tests/kms_atomic_transition: Document each subtest for testplan
Applying: tests/kms_bw: Document each subtest for testplan
Applying: tests/kms_color: Document each subtest for testplan
Applying: tests/kms_concurrent: Document each subtest for testplan
Applying: tests/kms_content_protection: Document each subtest for testplan
Applying: tests/kms_cursor_crc: Document each subtest for testplan
Applying: tests/kms_cursor_edge_walk: Document each subtest for testplan
Applying: tests/kms_cursor_legacy: Document each subtest for testplan
Applying: tests/kms_display_modes: Document each subtest for testplan
Applying: tests/kms_dither: Document each subtest for testplan
Applying: tests/kms_dp_aux_dev: Document each subtest for testplan
Applying: tests/kms_dp_tiled_display: Document each subtest for testplan
Applying: tests/kms_flip: Document each subtest for testplan
Applying: tests/kms_flip_event_leak: Document each subtest for testplan
Applying: tests/kms_force_connector_basic: Document each subtest for testplan
Applying: tests/kms_getfb: Document each subtest for testplan
Applying: tests/kms_hdmi_inject: Document each subtest for testplan
Applying: tests/kms_hdr: Document each subtest for testplan
Applying: tests/kms_invalid_mode: Document each subtest for testplan
Applying: tests/kms_lease: Document each subtest for testplan
Patch failed at 0055 tests/kms_lease: Document each subtest for testplan
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Re: [igt-dev] [V5, i-g-t, 05/81] tests/chamelium/kms_chamelium_audio: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/chamelium/kms_chamelium_audio.c | 44 +++++++++++++++++++++++++++
>   1 file changed, 44 insertions(+)
>
> diff --git a/tests/chamelium/kms_chamelium_audio.c b/tests/chamelium/kms_chamelium_audio.c
> index 8fbc1f80e..453f3518a 100644
> --- a/tests/chamelium/kms_chamelium_audio.c
> +++ b/tests/chamelium/kms_chamelium_audio.c
> @@ -28,6 +28,12 @@
>   #include "igt_infoframe.h"
>   #include "kms_chamelium_helper.h"
>   
> +/**
> + * TEST: kms chamelium audio
> + * Category: Display
> + * Description: Testing Audio with a Chamelium board
> + */
> +
>   /* Playback parameters control the audio signal we synthesize and send */
>   #define PLAYBACK_CHANNELS 2
>   #define PLAYBACK_SAMPLES 1024
> @@ -669,6 +675,25 @@ static bool check_audio_configuration(struct alsa *alsa,
>   	return true;
>   }
>   
> +/**
> + * SUBTEST: dp-audio
> + * Description: Playback various audio signals with various audio formats/rates,
> + *              capture them and check they are correct
> + * Functionality: dp_audio
> + * Mega feature: DP
> + * Run type: FULL
> + * Test category: functionality test
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-audio
> + * Description: Playback various audio signals with various audio formats/rates,
> + *              capture them and check they are correct
> + * Functionality: hdmi_audio
> + * Mega feature: HDMI

Can we keep one more mega feature here as Audio, so that we can either 
generate testlist for all audio test cases
or for checking overall Audio passrate across HDMI, DP ...

> + * Run type: FULL
> + * Test category: functionality test
> + * Driver requirement: any
> + */
>   static const char test_display_audio_desc[] =
>   	"Playback various audio signals with various audio formats/rates, "
>   	"capture them and check they are correct";
> @@ -763,6 +788,25 @@ static void test_display_audio(chamelium_data_t *data,
>   	free(alsa);
>   }
>   
> +/**
> + * SUBTEST: dp-audio-edid
> + * Description: Plug a connector with an EDID suitable for audio, check ALSA's
> + *              EDID-Like Data reports the correct audio parameters
> + * Functionality: dp_audio
> + * Mega feature: DP
> + * Run type: FULL
> + * Test category: functionality test
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-audio-edid
> + * Description: Plug a connector with an EDID suitable for audio, check ALSA's
> + *              EDID-Like Data reports the correct audio parameters
> + * Functionality: hdmi_audio
> + * Mega feature: HDMI
> + * Run type: FULL
> + * Test category: functionality test
> + * Driver requirement: any


Can we have something like requirement as well like driver requirement,
For this chamelium will be required


Also we need to have chamelium somewhere in here to populate chamelium only
testlist/ results
> + */
>   static const char test_display_audio_edid_desc[] =
>   	"Plug a connector with an EDID suitable for audio, check ALSA's "
>   	"EDID-Like Data reports the correct audio parameters";


Apart from this everything looks good

Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5 i-g-t 58/81] tests/kms_pipe_crc_basic: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 58/81] tests/kms_pipe_crc_basic: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> V2: - Add missing "Driver requirement" field
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Jeevan B <jeevan.b@intel.com>

> ---
>  tests/kms_pipe_crc_basic.c | 30 ++++++++++++++++++++++++++++--
>  1 file changed, 28 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index
> 95cc1d7fa..9e800b285 100644
> --- a/tests/kms_pipe_crc_basic.c
> +++ b/tests/kms_pipe_crc_basic.c
> @@ -23,8 +23,9 @@
>   */
> 
>  /**
> - * TEST: Tests behaviour of CRC
> + * TEST: kms pipe crc basic
>   * Category: Display
> + * Description: Tests behaviour of CRC
>   */
> 
>  #include "igt.h"
> @@ -64,6 +65,15 @@ static bool simulation_constraint(enum pipe pipe)
>  	return false;
>  }
> 
> +/**
> + * SUBTEST: bad-source
> + * Description: Tests error handling when the bad source is set.
> + * Driver requirement: any
> + * Functionality: crc
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>  static void test_bad_source(data_t *data)  {
>  	errno = 0;
> @@ -88,6 +98,7 @@ enum {
>  /**
>   * SUBTEST: read-crc
>   * Description: Test for pipe CRC reads
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: crc
> @@ -95,6 +106,7 @@ enum {
>   *
>   * SUBTEST: read-crc-frame-sequence
>   * Description: Tests the pipe CRC read and ensure frame sequence
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: crc
> @@ -102,6 +114,7 @@ enum {
>   *
>   * SUBTEST: nonblocking-crc
>   * Description: Test for O_NONBLOCK CRC reads
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: crc
> @@ -109,6 +122,7 @@ enum {
>   *
>   * SUBTEST: nonblocking-crc-frame-sequence
>   * Description: Test for O_NONBLOCK CRC reads and ensure frame sequence
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: crc
> @@ -116,6 +130,7 @@ enum {
>   *
>   * SUBTEST: suspend-read-crc
>   * Description: Suspend test for pipe CRC reads
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: crc
> @@ -123,12 +138,12 @@ enum {
>   *
>   * SUBTEST: hang-read-crc
>   * Description: Hang test for pipe CRC read
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: crc
>   * Mega feature: General Display Features
>   */
> -
>  static void test_read_crc(data_t *data, enum pipe pipe,
>  			  igt_output_t *output, unsigned flags)  { @@ -229,6
> +244,7 @@ static void test_read_crc(data_t *data, enum pipe pipe,
>  /**
>   * SUBTEST: compare-crc-sanitycheck-%s
>   * Description: Basic sanity check for CRC mismatches with %arg[1]
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: crc
> @@ -305,6 +321,16 @@ static void test_compare_crc(data_t *data, enum
> pipe pipe, igt_output_t *output,
>  	igt_remove_fb(data->drm_fd, &fb1);
>  }
> 
> +/**
> + * SUBTEST: disable-crc-after-crtc
> + * Description: Check that disabling CRCs on a CRTC after having disabled the
> + *              CRTC does not cause issues.
> + * Driver requirement: any
> + * Functionality: crc
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>  static void test_disable_crc_after_crtc(data_t *data, enum pipe pipe,
>  					igt_output_t *output)
>  {
> --
> 2.40.0

Re: [igt-dev] [V5, i-g-t, 06/81] tests/chamelium/kms_chamelium_color: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5 i-g-t 15/81] tests/i915/kms_draw_crc: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:18 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 15/81] tests/i915/kms_draw_crc: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/i915/kms_draw_crc.c | 49
> +++++++++++++++++++++++++++++++++++++--
>  1 file changed, 47 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c index
> 01ecb7bb9..8a001f6b6 100644
> --- a/tests/i915/kms_draw_crc.c
> +++ b/tests/i915/kms_draw_crc.c
> @@ -22,8 +22,11 @@
>   *
>   */
> 
> -/* This program tests whether the igt_draw library actually works. */
> -
> +/**
> + * TEST: kms draw crc
> + * Category: Display
> + * Description: Tests whether the igt_draw library actually works.
> + */
>  #include "i915/gem.h"
>  #include "igt.h"
> 
> @@ -140,6 +143,39 @@ static void get_method_crc(enum igt_draw_method
> method, uint32_t drm_format,
>  	igt_remove_fb(drm_fd, &fb);
>  }
> 
> +/**
> + * SUBTEST: draw-method-%s
> + * Description: Verify that igt draw library works for the %arg[1] method
> with
> + *              different modifiers & DRM formats.
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @blt:          Blitter
> + * @mmap-wc:      MMAP-WC
> + * @render:       Render
> + */
> +
> +/**
> + * SUBTEST: draw-method-%s
> + * Description: Verify that igt draw library works for the %arg[1] method
> with
> + *              different modifiers & DRM formats.
> + * Driver requirement: i915
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @mmap-cpu:     MMAP-CPU
> + * @mmap-gtt:     MMAP-GTT
> + * @pwrite:       PWRITE
> + */
>  static void draw_method_subtest(enum igt_draw_method method,
>  				uint32_t format_index, uint64_t modifier)  {
> @@ -179,6 +215,15 @@ static void get_fill_crc(uint64_t modifier, igt_crc_t
> *crc)
>  	igt_remove_fb(drm_fd, &fb);
>  }
> 
> +/**
> + * SUBTEST: fill-fb
> + * Description: This subtest verifies CRC after filling fb with x-tiling or none.
> + * Driver requirement: any
> + * Functionality: kms_gem_interop
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>  static void fill_fb_subtest(void)
>  {
>  	int rc;
> --
> 2.40.0

Re: [igt-dev] [V5, i-g-t, 08/81] tests/chamelium/kms_chamelium_frames: Document each subtest for testplan

[Joshi, Kunal1]

[-- Attachment #1: Type: text/plain, Size: 6090 bytes --]


On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem<bhanuprakash.modem@intel.com>
> ---
>   tests/chamelium/kms_chamelium_frames.c | 101 ++++++++++++++++++++++++-
>   1 file changed, 99 insertions(+), 2 deletions(-)
>
> diff --git a/tests/chamelium/kms_chamelium_frames.c b/tests/chamelium/kms_chamelium_frames.c
> index a56afada4..698681c4c 100644
> --- a/tests/chamelium/kms_chamelium_frames.c
> +++ b/tests/chamelium/kms_chamelium_frames.c
> @@ -25,10 +25,10 @@
>    */
>   
>   /**
> - * TEST: Tests to capture frames using chamelium
> + * TEST: kms chamelium frames
>    * Category: Display
> + * Description: Tests requiring a Chamelium board
>    */
> -
>   #include "igt_eld.h"
>   #include "igt_infoframe.h"
>   #include "kms_chamelium_helper.h"
> @@ -547,6 +547,7 @@ static void prepare_randomized_plane(chamelium_data_t *data,
>    * Run type: BAT
>    * Functionality: dp
>    * Mega feature: DP
> + * Driver requirement: any
>    *
>    * SUBTEST: hdmi-crc-fast
>    * Description: Pick the first mode of the IGT base EDID, display and capture
> @@ -555,6 +556,23 @@ static void prepare_randomized_plane(chamelium_data_t *data,
>    * Run type: BAT
>    * Functionality: hdmi
>    * Mega feature: HDMI
> + * Driver requirement: any
> + */
> +
> +/**
> + * SUBTEST: hdmi-%s-formats
> + * Description: Pick the first mode of the IGT base EDID, display and capture a
> + *              few frames, then check captured frames are correct
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * arg[1]:
> + *
> + * @crc-nonplanar:     CRC with non planar formats
> + * @cmp-planar:        Compare with planar formats
>    */
>   static const char test_display_one_mode_desc[] =
>   	"Pick the first mode of the IGT base EDID, display and capture a few "
> @@ -592,6 +610,39 @@ static void test_display_one_mode(chamelium_data_t *data,
>   	drmModeFreeConnector(connector);
>   }
>   
> +/**
> + * SUBTEST: vga-frame-dump
> + * Description: For each mode of the IGT base EDID, display and capture a few
> + *              frames, then check captured frames are correct
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: vga
> + * Mega feature: VGA
> + * Driver requirement: any
> + *
> + * SUBTEST: dp-crc-%s
> + * Description: For each mode of the IGT base EDID, display and capture a %arg[1]
> + *              frame(s), then check captured frame(s) are correct
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-crc-%s
> + * Description: For each mode of the IGT base EDID, display and capture a %arg[1]
> + *              frame(s), then check captured frame(s) are correct
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * arg[1]:
> + *
> + * @single:    single
> + * @multiple:  multiple
> + */
>   static const char test_display_all_modes_desc[] =
>   	"For each mode of the IGT base EDID, display and capture a few "
>   	"frames, then check captured frames are correct";
> @@ -650,6 +701,27 @@ static void test_display_all_modes(chamelium_data_t *data,
>   	} while (++i < count_modes);
>   }
>   
> +/**
> + * SUBTEST: dp-frame-dump
> + * Description: For each mode of the IGT base EDID, display and capture a few
> + *              frames, then download the captured frames and compare them
> + *              bit-by-bit to the sent ones
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-frame-dump
> + * Description: For each mode of the IGT base EDID, display and capture a few
> + *              frames, then download the captured frames and compare them
> + *              bit-by-bit to the sent ones
> + * Test category: functionality test
> + * Run type: BAT
> + * Functionality: hdmi
> + * Mega feature: HDMI
> + * Driver requirement: any
> + */
>   static const char test_display_frame_dump_desc[] =
>   	"For each mode of the IGT base EDID, display and capture a few "
>   	"frames, then download the captured frames and compare them "
> @@ -718,6 +790,16 @@ static void test_display_frame_dump(chamelium_data_t *data,
>   	} while (++i < count_modes);
>   }
>   
> +/**
> + * SUBTEST: hdmi-aspect-ratio
> + * Description: Pick a mode with a picture aspect-ratio, capture AVI InfoFrames
>
> + *              and check they include the relevant fields
> + * Test category: functionality test
> + * Run type: BAT
> + * Functionality: hdmi
> + * Mega feature: HDMI
> + * Driver requirement: any
> + */
>   static const char test_display_aspect_ratio_desc[] =
>   	"Pick a mode with a picture aspect-ratio, capture AVI InfoFrames and "
>   	"check they include the relevant fields";
> @@ -798,6 +880,21 @@ static void test_display_aspect_ratio(chamelium_data_t *data,
>   	drmModeFreeConnector(connector);
>   }
>   
> +/**
> + * SUBTEST: hdmi-%s-planes-random
> + * Description: Setup a few overlay planes with random parameters, capture the
> + *              frame and check it matches the expected output
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * arg[1]:
> + *
> + * @crc:     CRC check
> + * @cmp:     Compare
> + */
>   static const char test_display_planes_random_desc[] =
>   	"Setup a few overlay planes with random parameters, capture the frame "
>   	"and check it matches the expected output";

1) Same for all chamelium tests, we should have a some identifier for 
getting testlist
    for chamelium test

2) Plane random test is not used now, do we need something additional so 
that we don't run it on CI?

3) Here we can add mega feature as frame integrity


[-- Attachment #2: Type: text/html, Size: 6268 bytes --]

Re: [igt-dev] [V5, i-g-t, 07/81] tests/chamelium/kms_chamelium_edid: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/chamelium/kms_chamelium_edid.c | 90 +++++++++++++++++++++++++++-
>   1 file changed, 89 insertions(+), 1 deletion(-)
>
> diff --git a/tests/chamelium/kms_chamelium_edid.c b/tests/chamelium/kms_chamelium_edid.c
> index 446bbd204..579d61d15 100644
> --- a/tests/chamelium/kms_chamelium_edid.c
> +++ b/tests/chamelium/kms_chamelium_edid.c
> @@ -25,8 +25,9 @@
>    */
>   
>   /**
> - * TEST: Tests behaviour of edid & timings using chamelium
> + * TEST: kms chamelium edid
>    * Category: Display
> + * Description: Testing EDID with a Chamelium board
>    */
>   
>   #include <fcntl.h>
> @@ -151,6 +152,7 @@ static void check_mode(struct chamelium *chamelium, struct chamelium_port *port,
>    * Run type: BAT
>    * Functionality: dp
>    * Mega feature: DP
> + * Driver requirement: any
>    *
>    * SUBTEST: hdmi-edid-read
>    * Description: Make sure the EDID exposed by KMS is the same as the screen's
> @@ -158,6 +160,7 @@ static void check_mode(struct chamelium *chamelium, struct chamelium_port *port,
>    * Run type: BAT
>    * Functionality: hdmi
>    * Mega feature: HDMI
> + * Driver requirement: any
>    *
>    * SUBTEST: vga-edid-read
>    * Description: Make sure the EDID exposed by KMS is the same as the screen's
> @@ -165,6 +168,7 @@ static void check_mode(struct chamelium *chamelium, struct chamelium_port *port,
>    * Run type: BAT
>    * Functionality: vga
>    * Mega feature: VGA
> + * Driver requirement: any
>    */
>   static const char igt_custom_edid_type_read_desc[] =
>   	"Make sure the EDID exposed by KMS is the same as the screen's";
> @@ -205,6 +209,32 @@ static void igt_custom_edid_type_read(chamelium_data_t *data,
>   	drmModeFreeConnector(connector);
>   }
>   
> +/**
> + * SUBTEST: dp-edid-stress-resolution-%s
> + * Description: Stress test the DUT by testing multiple EDIDs, one right after
> + *              the other, and ensure their validity by check the real screen
> + *              resolution vs the advertised mode (%arg[1]) resolution.
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-edid-stress-resolution-%s
> + * Description: Stress test the DUT by testing multiple EDIDs, one right after
> + *              the other, and ensure their validity by check the real screen
> + *              resolution vs the advertised mode (%arg[1]) resolution.
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * arg[1]:
> + *
> + * @4k:      4K
> + * @non-4k:  Non 4K
> + */
>   static const char igt_edid_stress_resolution_desc[] =
>   	"Stress test the DUT by testing multiple EDIDs, one right after the other, "
>   	"and ensure their validity by check the real screen resolution vs the "
> @@ -274,6 +304,17 @@ static void edid_stress_resolution(chamelium_data_t *data,
>   			      data->ports, data->port_count);
>   }
>   
> +/**
> + * SUBTEST: dp-edid-resolution-list
> + * Description: Get an EDID with many modes of different configurations, set
> + *              them on the screen and check the screen resolution matches the
> + *              mode resolution.
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + */
>   static const char igt_edid_resolution_list_desc[] =
>   	"Get an EDID with many modes of different configurations, set them on the screen and check the"
>   	" screen resolution matches the mode resolution.";
> @@ -337,6 +378,32 @@ static void edid_resolution_list(chamelium_data_t *data,
>   	drmModeFreeConnector(connector);
>   }
>   
> +/**
> + * SUBTEST: dp-edid-change-during-%s
> + * Description: Simulate a screen being unplugged and another screen being
> + *              plugged during suspend, check that a uevent is sent and
> + *              connector status is updated during %arg[1]
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-edid-change-during-%s
> + * Description: Simulate a screen being unplugged and another screen being
> + *              plugged during suspend, check that a uevent is sent and
> + *              connector status is updated during %arg[1]
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * arg[1]:
> + *
> + * @hibernate:    hibernation
> + * @suspend:      suspend
> + */
>   static const char test_suspend_resume_edid_change_desc[] =
>   	"Simulate a screen being unplugged and another screen being plugged "
>   	"during suspend, check that a uevent is sent and connector status is "
> @@ -389,6 +456,27 @@ static void test_suspend_resume_edid_change(chamelium_data_t *data,
>   			    link_status_failed[1][p]);
>   }
>   
> +/**
> + * SUBTEST: dp-mode-timings
> + * Description: For each mode of the IGT base EDID, perform a modeset and check
> + *              the mode detected by the Chamelium receiver matches the mode we
> + *              set
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-mode-timings
> + * Description: For each mode of the IGT base EDID, perform a modeset and check
> + *              the mode detected by the Chamelium receiver matches the mode we
> + *              set
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp
> + * Mega feature: DP
> + * Driver requirement: any
> + */
>   static const char test_mode_timings_desc[] =
>   	"For each mode of the IGT base EDID, perform a modeset and check the "
>   	"mode detected by the Chamelium receiver matches the mode we set";


1) Same for all chamelium tests, we should have a some identifier for 
getting testlist
    for chamelium test

2) Have Functionality as DP-EDID-READ or something?

Re: [igt-dev] [V5, i-g-t, 09/81] tests/chamelium/kms_chamelium_hpd: Document each subtest for testplan

[Joshi, Kunal1]

1) Same for all chamelium tests, we should have a some identifier for 
getting testlist
    for chamelium test

2) Have Functionality/Mega Feature as  Hotplug to identify all tests 
which validates hotplug?

On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/chamelium/kms_chamelium_hpd.c | 186 +++++++++++++++++++++++++++-
>   1 file changed, 185 insertions(+), 1 deletion(-)
>
> diff --git a/tests/chamelium/kms_chamelium_hpd.c b/tests/chamelium/kms_chamelium_hpd.c
> index 8b3189ca0..d7b9f0707 100644
> --- a/tests/chamelium/kms_chamelium_hpd.c
> +++ b/tests/chamelium/kms_chamelium_hpd.c
> @@ -25,8 +25,9 @@
>    */
>   
>   /**
> - * TEST: Tests behaviour of hpd using chamelium
> + * TEST: kms chamelium hpd
>    * Category: Display
> + * Description: Testing HPD with a Chamelium board
>    */
>   
>   #include "kms_chamelium_helper.h"
> @@ -117,6 +118,7 @@ static void try_suspend_resume_hpd(chamelium_data_t *data,
>    * Run type: BAT
>    * Functionality: dp_hotplug
>    * Mega feature: DP
> + * Driver requirement: any
>    *
>    * SUBTEST: hdmi-hpd-fast
>    * Description: Check that we get uevents and updated connector status on
> @@ -125,6 +127,7 @@ static void try_suspend_resume_hpd(chamelium_data_t *data,
>    * Run type: BAT
>    * Functionality: hdmi_hotplug
>    * Mega feature: HDMI
> + * Driver requirement: any
>    *
>    * SUBTEST: vga-hpd-fast
>    * Description: Check that we get uevents and updated connector status on
> @@ -133,6 +136,66 @@ static void try_suspend_resume_hpd(chamelium_data_t *data,
>    * Run type: BAT
>    * Functionality: vga_hotplug
>    * Mega feature: VGA
> + * Driver requirement: any
> + *
> + * SUBTEST: dp-hpd
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp_hotplug
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-hpd
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi_hotplug
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * SUBTEST: vga-hpd
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: vga_hotplug
> + * Mega feature: VGA
> + * Driver requirement: any
> + *
> + * SUBTEST: dp-hpd-%s
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp_hotplug
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-hpd-%s
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi_hotplug
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * SUBTEST: vga-hpd-%s
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: vga_hotplug
> + * Mega feature: VGA
> + * Driver requirement: any
> + *
> + * arg[1]:
> + *
> + * @enable-disable-mode:     Toggle the mode
> + * @with-enabled-mode:       Enabling the mode
>    */
>   static const char test_basic_hotplug_desc[] =
>   	"Check that we get uevents and updated connector status on "
> @@ -200,6 +263,34 @@ static void test_hotplug(chamelium_data_t *data, struct chamelium_port *port,
>   	igt_remove_fb(data->drm_fd, &fb);
>   }
>   
> +/**
> + * SUBTEST: dp-hpd-for-each-pipe
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug for each pipe with valid output
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp_hotplug
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-hpd-for-each-pipe
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug for each pipe with valid output
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi_hotplug
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * SUBTEST: vga-hpd-for-each-pipe
> + * Description: Check that we get uevents and updated connector status on
> + *              hotplug and unplug for each pipe with valid output
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: vga_hotplug
> + * Mega feature: VGA
> + * Driver requirement: any
> + */
>   static const char test_hotplug_for_each_pipe_desc[] =
>   	"Check that we get uevents and updated connector status on "
>   	"hotplug and unplug for each pipe with valid output";
> @@ -245,6 +336,39 @@ static void test_hotplug_for_each_pipe(chamelium_data_t *data,
>   	igt_hpd_storm_reset(data->drm_fd);
>   }
>   
> +/**
> + * SUBTEST: dp-hpd-after-%s
> + * Description: Toggle HPD during %arg[1], check that uevents are sent and
> + *              connector status is updated
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp_hotplug
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-hpd-after-%s
> + * Description: Toggle HPD during %arg[1], check that uevents are sent and
> + *              connector status is updated
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi_hotplug
> + * Mega feature: HDMI
> + * Driver requirement: any
> + *
> + * SUBTEST: vga-hpd-after-%s
> + * Description: Toggle HPD during %arg[1], check that uevents are sent and
> + *              connector status is updated
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: vga_hotplug
> + * Mega feature: VGA
> + * Driver requirement: any
> + *
> + * arg[1]:
> + *
> + * @hibernate:     Hibernation
> + * @suspend:       Suspend
> + */
>   static const char test_suspend_resume_hpd_desc[] =
>   	"Toggle HPD during suspend, check that uevents are sent and connector "
>   	"status is updated";
> @@ -276,6 +400,16 @@ static void test_suspend_resume_hpd(chamelium_data_t *data,
>    * Run type: BAT
>    * Functionality: hotplug
>    * Mega feature: General Display Features
> + * Driver requirement: any
> + *
> + * SUBTEST: common-hpd-after-hibernate
> + * Description: Toggle HPD during suspend on all connectors, check that uevents
> + *              are sent and connector status is updated
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hotplug
> + * Mega feature: General Display Features
> + * Driver requirement: any
>    */
>   static const char test_suspend_resume_hpd_common_desc[] =
>   	"Toggle HPD during suspend on all connectors, check that uevents are "
> @@ -306,6 +440,16 @@ static void test_suspend_resume_hpd_common(chamelium_data_t *data,
>   	igt_cleanup_uevents(mon);
>   }
>   
> +/**
> + * SUBTEST: vga-hpd-without-ddc
> + * Description: Disable DDC on a VGA connector, check we still get a uevent on
> + *              hotplug
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: vga_hotplug
> + * Mega feature: VGA
> + * Driver requirement: any
> + */
>   static const char test_hpd_without_ddc_desc[] =
>   	"Disable DDC on a VGA connector, check we still get a uevent on hotplug";
>   static void test_hpd_without_ddc(chamelium_data_t *data,
> @@ -332,6 +476,27 @@ static void test_hpd_without_ddc(chamelium_data_t *data,
>   	igt_cleanup_uevents(mon);
>   }
>   
> +/**
> + * SUBTEST: dp-hpd-storm
> + * Description: Trigger a series of hotplugs in a very small timeframe to
> + *              simulate abad cable, check the kernel falls back to polling
> + *              to avoid a hotplug storm
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp_hotplug
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-hpd-storm
> + * Description: Trigger a series of hotplugs in a very small timeframe to
> + *              simulate abad cable, check the kernel falls back to polling
> + *              to avoid a hotplug storm
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi_hotplug
> + * Mega feature: HDMI
> + * Driver requirement: any
> + */
>   static const char test_hpd_storm_detect_desc[] =
>   	"Trigger a series of hotplugs in a very small timeframe to simulate a"
>   	"bad cable, check the kernel falls back to polling to avoid a hotplug "
> @@ -366,6 +531,25 @@ static void test_hpd_storm_detect(chamelium_data_t *data,
>   	igt_hpd_storm_reset(data->drm_fd);
>   }
>   
> +/**
> + * SUBTEST: dp-hpd-storm-disable
> + * Description: Disable HPD storm detection, trigger a storm and check the
> + *              kernel doesn't detect one
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: dp_hotplug
> + * Mega feature: DP
> + * Driver requirement: any
> + *
> + * SUBTEST: hdmi-hpd-storm-disable
> + * Description: Disable HPD storm detection, trigger a storm and check the
> + *              kernel doesn't detect one
> + * Test category: functionality test
> + * Run type: FULL
> + * Functionality: hdmi_hotplug
> + * Mega feature: HDMI
> + * Driver requirement: any
> + */
>   static const char test_hpd_storm_disable_desc[] =
>   	"Disable HPD storm detection, trigger a storm and check the kernel "
>   	"doesn't detect one";

Re: [igt-dev] [V5, i-g-t, 46/81] tests/kms_dp_aux_dev: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_dp_aux_dev.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
> index 19cbe216a..383a2e0b4 100644
> --- a/tests/kms_dp_aux_dev.c
> +++ b/tests/kms_dp_aux_dev.c
> @@ -31,6 +31,19 @@
>   
>   #include "igt.h"
>   #include "igt_kms.h"
> +/**
> + * TEST: kms dp aux dev
> + * Category: Display
> + * Description: Test that /dev/drm_dp_aux reads work
> + *
> + * SUBTEST:
> + * Description: Test that /dev/drm_dp_aux reads work
> + * Driver requirement: any
> + * Functionality: dp
> + * Mega feature: DP
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION("Test that /dev/drm_dp_aux reads work");
>   
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5, i-g-t, 12/81] tests/i915/kms_busy: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5, i-g-t, 22/81] tests/i915/kms_frontbuffer_tracking: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Note: This documentation is generated by the script & made changes
> on top of it.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_frontbuffer_tracking.c | 808 ++++++++++++++++++++++++++
>   1 file changed, 808 insertions(+)
>
> diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
> index b2183b08e..64f9b9412 100644
> --- a/tests/i915/kms_frontbuffer_tracking.c
> +++ b/tests/i915/kms_frontbuffer_tracking.c
> @@ -24,6 +24,11 @@
>    *
>    */
>   
> +/**
> + * TEST: kms frontbuffer tracking
> + * Category: Display
> + * Description: Test the Kernel's frontbuffer tracking mechanism and its related features: FBC, PSR and DRRS
> + */
>   #include <sys/types.h>
>   #include <sys/stat.h>
>   #include <fcntl.h>
> @@ -1952,6 +1957,28 @@ static void prepare_subtest(const struct test_mode *t,
>   	prepare_subtest_screens(t);
>   }
>   
> +/**
> + * SUBTEST: %s-%dp-rte
> + * Description: Sanity test to enable %arg[1] with %arg[2] panels.
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *

In Functionality can we have PSR, DRRS and FBC and FBT as well?
Applicable almost on all test except basic
Apart from that
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + */
> +
>   /*
>    * rte - the basic sanity test
>    *
> @@ -2012,6 +2039,308 @@ static bool op_disables_psr(const struct test_mode *t,
>   	return false;
>   }
>   
> +/**
> + * SUBTEST: %s-1p-offscren-pri-%s-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @indfb:          Individual fb
> + * @shrfb:          Shared fb
> + *
> + * arg[3]:
> + *
> + * @blt:            Blitter
> + * @mmap-wc:        MMAP-WC
> + * @render:         Render
> + */
> +
> +/**
> + * SUBTEST: %s-1p-offscren-pri-%s-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @indfb:          Individual fb
> + * @shrfb:          Shared fb
> + *
> + * arg[3]:
> + *
> + * @mmap-cpu:       MMAP-CPU
> + * @mmap-gtt:       MMAP-GTT
> + * @pwrite:         PWRITE
> + */
> +
> +/**
> + * SUBTEST: %s-%dp-primscrn-%s-indfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @cur:            Cursor plane
> + * @pri:            Primary plane
> + * @spr:            Sprite plane
> + *
> + * arg[4]:
> + *
> + * @mmap-cpu:       MMAP-CPU
> + * @mmap-gtt:       MMAP-GTT
> + * @pwrite:         PWRITE
> + */
> +
> +/**
> + * SUBTEST: %s-%dp-primscrn-%s-indfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @cur:            Cursor plane
> + * @pri:            Primary plane
> + * @spr:            Sprite plane
> + *
> + * arg[4]:
> + *
> + * @blt:            Blitter
> + * @mmap-wc:        MMAP-WC
> + * @render:         Render
> + */
> +
> +/**
> + * SUBTEST: %s-%dp-primscrn-pri-shrfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @blt:            Blitter
> + * @mmap-wc:        MMAP-WC
> + * @render:         Render
> + */
> +
> +/**
> + * SUBTEST: %s-%dp-primscrn-pri-shrfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @mmap-cpu:       MMAP-CPU
> + * @mmap-gtt:       MMAP-GTT
> + * @pwrite:         PWRITE
> + */
> +
> +/**
> + * SUBTEST: %s-2p-scndscrn-%s-indfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @cur:            Cursor plane
> + * @pri:            Primary plane
> + * @spr:            Sprite plane
> + *
> + * arg[3]:
> + *
> + * @blt:            Blitter
> + * @mmap-wc:        MMAP-WC
> + * @render:         Render
> + */
> +
> +/**
> + * SUBTEST: %s-2p-scndscrn-%s-indfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @cur:            Cursor plane
> + * @pri:            Primary plane
> + * @spr:            Sprite plane
> + *
> + * arg[3]:
> + *
> + * @mmap-cpu:       MMAP-CPU
> + * @mmap-gtt:       MMAP-GTT
> + * @pwrite:         PWRITE
> + */
> +
> +/**
> + * SUBTEST: %s-2p-scndscrn-pri-shrfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @blt:            Blitter
> + * @mmap-wc:        MMAP-WC
> + * @render:         Render
> + */
> +
> +/**
> + * SUBTEST: %s-2p-scndscrn-pri-shrfb-draw-%s
> + * Description: Draw a set of rectangles on the screen using the provided method
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @mmap-cpu:       MMAP-CPU
> + * @mmap-gtt:       MMAP-GTT
> + * @pwrite:         PWRITE
> + */
> +
>   /*
>    * draw - draw a set of rectangles on the screen using the provided method
>    *
> @@ -2085,6 +2414,28 @@ static void draw_subtest(const struct test_mode *t)
>   	}
>   }
>   
> +/**
> + * SUBTEST: %s-%dp-pri-indfb-multidraw
> + * Description: Draw a set of rectangles on the screen using alternated drawing methods
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + */
> +
>   /*
>    * multidraw - draw a set of rectangles on the screen using alternated drawing
>    *             methods
> @@ -2233,6 +2584,68 @@ static void badformat_subtest(const struct test_mode *t)
>   	do_assertions(assertions);
>   }
>   
> +/**
> + * SUBTEST: %s-%s-draw-%s
> + * Description: Test pixel formats (%arg[2]) that are not FORMAT_DEFAULT
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @rgb101010:      FORMAT_RGB101010
> + * @rgb565:         FORMAT_RGB565
> + *
> + * arg[3]:
> + *
> + * @blt:            Blitter
> + * @mmap-wc:        MMAP-WC
> + * @render:         Render
> + */
> +
> +/**
> + * SUBTEST: %s-%s-draw-%s
> + * Description: Test pixel formats (%arg[2]) that are not FORMAT_DEFAULT
> + * Driver requirement: i915
> + * Functionality: kms_core, gtt
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @rgb101010:      FORMAT_RGB101010
> + * @rgb565:         FORMAT_RGB565
> + *
> + * arg[3]:
> + *
> + * @mmap-cpu:       MMAP-CPU
> + * @mmap-gtt:       MMAP-GTT
> + * @pwrite:         PWRITE
> + */
> +
>   /*
>    * format_draw - test pixel formats that are not FORMAT_DEFAULT
>    *
> @@ -2276,6 +2689,25 @@ static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
>   	}
>   }
>   
> +/**
> + * SUBTEST: %s-slowdraw
> + * Description: Sleep a little bit between drawing operations with %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + */
> +
>   /*
>    * slow_draw - sleep a little bit between drawing operations
>    *
> @@ -2382,6 +2814,70 @@ static void page_flip_for_params(struct modeset_params *params,
>   	}
>   }
>   
> +/**
> + * SUBTEST: %s-%dp-primscrn-%s-%sflip-blt
> + * Description: Just exercise page flips with the patterns we have
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @indfb:          Individual fb
> + * @shrfb:          Shared fb
> + *
> + * arg[4]:
> + *
> + * @ms:             Modeset
> + * @pg:             Page flip
> + * @pl:             Plane change
> + */
> +
> +/**
> + * SUBTEST: %s-2p-scndscrn-%s-%sflip-blt
> + * Description: Just exercise page flips with the patterns we have
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @indfb:          Individual fb
> + * @shrfb:          Shared fb
> + *
> + * arg[3]:
> + *
> + * @ms:             Modeset
> + * @pg:             Page flip
> + * @pl:             Plane change
> + */
> +
>   /*
>    * flip - just exercise page flips with the patterns we have
>    *
> @@ -2442,6 +2938,30 @@ static void flip_subtest(const struct test_mode *t)
>   	igt_remove_fb(drm.fd, &fb2);
>   }
>   
> +/**
> + * SUBTEST: %s-%dp-%s-fliptrack-mmap-gtt
> + * Description: Check if the hardware tracking works after page flips
> + * Driver requirement: i915
> + * Functionality: fbc, gtt, kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @fbc:            FBC
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @indfb:          Individual fb
> + * @shrfb:          Shared fb
> + */
> +
>   /*
>    * fliptrack - check if the hardware tracking works after page flips
>    *
> @@ -2490,6 +3010,58 @@ static void fliptrack_subtest(const struct test_mode *t, enum flip_type type)
>   	igt_remove_fb(drm.fd, &fb2);
>   }
>   
> +/**
> + * SUBTEST: %s-%dp-primscrn-%s-indfb-move
> + * Description: Just move the %arg[3] around
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @spr:            Sprite plane
> + * @cur:            Cursor plane
> + */
> +
> +/**
> + * SUBTEST: %s-2p-scndscrn-%s-indfb-move
> + * Description: Just move the %arg[2] around
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @spr:            Sprite plane
> + * @cur:            Cursor plane
> + */
> +
>   /*
>    * move - just move the sprite or cursor around
>    *
> @@ -2543,6 +3115,58 @@ static void move_subtest(const struct test_mode *t)
>   	}
>   }
>   
> +/**
> + * SUBTEST: %s-%dp-primscrn-%s-indfb-onoff
> + * Description: Just enable and disable the %arg[3] a few times
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + *
> + * arg[3]:
> + *
> + * @spr:            Sprite plane
> + * @cur:            Cursor plane
> + */
> +
> +/**
> + * SUBTEST: %s-2p-scndscrn-%s-indfb-onoff
> + * Description: Just enable and disable the %arg[2] a few times
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @spr:            Sprite plane
> + * @cur:            Cursor plane
> + */
> +
>   /*
>    * onoff - just enable and disable the sprite or cursor plane a few times
>    *
> @@ -2602,6 +3226,36 @@ static bool prim_plane_disabled(void)
>   	return !prim_mode_params.primary.plane->values[IGT_PLANE_FB_ID];
>   }
>   
> +/**
> + * SUBTEST: %s-%dp-primscrn-spr-indfb-fullscreen
> + * Description: Put a fullscreen plane covering the whole screen
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: %s-2p-scndscrn-spr-indfb-fullscreen
> + * Description: Put a fullscreen plane covering the whole screen
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2].values:   1, 2
> + */
> +
>   /*
>    * fullscreen_plane - put a fullscreen plane covering the whole screen
>    *
> @@ -2663,6 +3317,31 @@ static void fullscreen_plane_subtest(const struct test_mode *t)
>   	igt_remove_fb(drm.fd, &fullscreen_fb);
>   }
>   
> +/**
> + * SUBTEST: %s-%s-scaledprimary
> + * Description: Try different primary plane scaling strategies
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @indfb:          Individual fb
> + * @shrfb:          Shared fb
> + */
> +
>   /*
>    * scaledprimary - try different primary plane scaling strategies
>    *
> @@ -2768,6 +3447,27 @@ static void scaledprimary_subtest(const struct test_mode *t)
>   
>   	igt_remove_fb(drm.fd, &new_fb);
>   }
> +
> +/**
> + * SUBTEST: %s-modesetfrombusy
> + * Description: Modeset from a busy buffer to a non-busy buffer with %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + */
> +
>   /**
>    * modesetfrombusy - modeset from a busy buffer to a non-busy buffer
>    *
> @@ -2811,6 +3511,26 @@ static void modesetfrombusy_subtest(const struct test_mode *t)
>   	igt_remove_fb(drm.fd, &fb2);
>   }
>   
> +/**
> + * SUBTEST: %s-suspend
> + * Description: Make sure suspend/resume keeps us on the same state of %arg[1]
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + */
> +
>   /**
>    * suspend - make sure suspend/resume keeps us on the same state
>    *
> @@ -2843,6 +3563,26 @@ static void suspend_subtest(const struct test_mode *t)
>   	do_assertions(0);
>   }
>   
> +/**
> + * SUBTEST: %s-farfromfence-mmap-gtt
> + * Description: Test drawing as far from the fence start as possible
> + * Driver requirement: i915
> + * Functionality: gtt, kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @drrs:           DRRS
> + * @fbc:            FBC
> + * @psr:            PSR
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @psrdrrs:        PSR and DRRS
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + */
> +
>   /**
>    * farfromfence - test drawing as far from the fence start as possible
>    *
> @@ -2939,6 +3679,23 @@ static void try_invalid_strides(void)
>   	gem_close(drm.fd, gem_handle);
>   }
>   
> +/**
> + * SUBTEST: %s-badstride
> + * Description: Try to use buffers with strides that are not supported
> + * Driver requirement: any
> + * Functionality: fbc, kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @fbc:            FBC
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + */
> +
>   /**
>    * badstride - try to use buffers with strides that are not supported
>    *
> @@ -3007,6 +3764,23 @@ static void badstride_subtest(const struct test_mode *t)
>   	igt_remove_fb(drm.fd, &wide_fb);
>   }
>   
> +/**
> + * SUBTEST: %s-stridechange
> + * Description: Change the frontbuffer stride by doing a modeset
> + * Driver requirement: any
> + * Functionality: fbc, kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @fbc:            FBC
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + */
> +
>   /**
>    * stridechange - change the frontbuffer stride by doing a modeset
>    *
> @@ -3071,6 +3845,30 @@ static void stridechange_subtest(const struct test_mode *t)
>   	do_assertions(rc ? 0 : DONT_ASSERT_FBC_STATUS);
>   }
>   
> +/**
> + * SUBTEST: %s-tiling-%s
> + * Description: Test %arg[2] formats, if the tiling format supports FBC do the
> + *              basic drawing test, else set the mode & test if FBC is disabled
> + * Driver requirement: any
> + * Functionality: fbc, kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @fbc:            FBC
> + * @fbcdrrs:        FBC and DRRS
> + * @fbcpsr:         FBC and PSR
> + * @fbcpsrdrrs:     All features (DRRS, FBC & PSR)
> + *
> + * arg[2]:
> + *
> + * @4:              4 tiling
> + * @linear:         Linear tiling
> + * @y:              Y tiling
> + */
> +
>   /**
>    * tiling_disable_fbc_subtest - Check if tiling is unsupported by FBC
>    *
> @@ -3120,6 +3918,16 @@ static void tiling_disable_fbc_subtest(const struct test_mode *t)
>   	igt_remove_fb(drm.fd, &new_fb);
>   }
>   
> +/**
> + * SUBTEST: basic
> + * Description: Do some basic operations regardless of which features are enabled
> + * Driver requirement: any
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
> +
>   /*
>    * basic - do some basic operations regardless of which features are enabled
>    *

Re: [igt-dev] [V5, i-g-t, 26/81] tests/i915/kms_psr: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> V2: - Add missing "Driver requirement" field
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5, i-g-t, 29/81] tests/i915/kms_psr_stress_test: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5, i-g-t, 28/81] tests/i915/kms_psr2_su: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_psr2_su.c | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/tests/i915/kms_psr2_su.c b/tests/i915/kms_psr2_su.c
> index 3081887ca..6da283643 100644
> --- a/tests/i915/kms_psr2_su.c
> +++ b/tests/i915/kms_psr2_su.c
> @@ -30,6 +30,33 @@
>   #include <stdio.h>
>   #include <string.h>
>   #include <sys/timerfd.h>
> +/**
> + * TEST: kms psr2 su
> + * Category: Display
> + * Description: Test PSR2 selective update
> + *
> + * SUBTEST: frontbuffer-XRGB8888
> + * Description: Test that selective update works when screen changes
> + * Driver requirement: any
> + * Functionality: psr2
> + * Mega feature: PSR
> + * Run type: FULL
> + * Test category: functionality test
Here we can have FBT also as functionality
Also we need to add selective update as a functionality
Apart from that
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
> + *
> + * SUBTEST: page_flip-%s
> + * Description: Test the selective update with %arg[1] when screen changes
> + * Driver requirement: any
> + * Functionality: psr2
> + * Mega feature: PSR
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @NV12:        NV12 format
> + * @P010:        P010 format
> + * @XRGB8888:    XRGB8888 format
> + */
>   
>   IGT_TEST_DESCRIPTION("Test PSR2 selective update");
>   

Re: [igt-dev] [V5, i-g-t, 27/81] tests/i915/kms_psr2_sf: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
How do you see adding selective fetch also as Functionality?
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5, i-g-t, 50/81] tests/kms_force_connector_basic: Document each subtest for testplan

[Joshi, Kunal1]

On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>

Re: [igt-dev] [V5 i-g-t 63/81] tests/kms_plane_multiple: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 63/81] tests/kms_plane_multiple: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/kms_plane_multiple.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c index
> 1f2bd65c3..3e6f4411e 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -22,6 +22,11 @@
>   *
>   */
> 
> +/**
> + * TEST: kms plane multiple
> + * Category: Display
> + * Description: Test atomic mode setting with multiple planes.
> + */
>  #include "igt.h"
>  #include "drmtest.h"
>  #include <errno.h>
> @@ -373,6 +378,25 @@ test_plane_position(data_t *data, enum pipe pipe,
> igt_output_t *output, uint64_t
>  					n_planes, modifier);
>  }
> 
> +/**
> + * SUBTEST: tiling-%s
> + * Description: Check that the kernel handles atomic updates of multiple planes
> + *              correctly by changing their geometry and making sure the changes
> + *              are reflected immediately after each commit.
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @none:        Linear buffer (no tiling)
> + * @4:           4-tiling
> + * @x:           x-tiling
> + * @y:           y-tiling
> + * @yf:          yf-tiling
> + */
>  static void run_test(data_t *data, uint64_t modifier)  {
>  	enum pipe pipe;
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 76/81] tests/kms_universal_plane: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 76/81] tests/kms_universal_plane: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  tests/kms_universal_plane.c | 67 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 67 insertions(+)
> 
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c index
> 957d600f1..358b7ae18 100644
> --- a/tests/kms_universal_plane.c
> +++ b/tests/kms_universal_plane.c
> @@ -28,6 +28,73 @@
>  #include <string.h>
>  #include <fcntl.h>
> 
> +/**
> + * TEST: kms universal plane
> + * Category: Display
> + *
> + * SUBTEST: cursor-fb-leak-pipe-%s
> + * Description: Check for cursor leaks after performing cursor
> +operations
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: disable-primary-vs-flip-pipe-%s
> + * Description: Check pageflips while primary plane is disabled before IOCTL or
> + *              between IOCTL and pageflip execution
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: universal-plane-pageflip-windowed-pipe-%s
> + * Description: Check if pageflip succeeds in windowed setting
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @A:
> + * @B:
> + * @C:
> + * @D:
> + * @E:
> + * @F:
> + * @G:
> + * @H:
> + */
> +
Other subtest details missing. 
> +/**
> + * SUBTEST: universal-plane-pipe-%s-%s
> + * Description: Check %arg[1]
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @A:
> + * @B:
> + * @C:
> + * @D:
> + * @E:
> + * @F:
> + * @G:
> + * @H:
> + *
> + * arg[2]:
> + *
> + * @functional: the switching between different primary plane fbs with CRTC
> off
> + * @sanity:     for scale-up or scale-down using universal plane API without
> + *              covering CRTC
> + */
> 
>  typedef struct {
>  	int drm_fd;
> --
> 2.40.0

Re: [igt-dev] [V5, i-g-t, 05/81] tests/chamelium/kms_chamelium_audio: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Kunal,

On Thu-10-08-2023 10:27 am, Joshi, Kunal1 wrote:
> 
> On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/chamelium/kms_chamelium_audio.c | 44 +++++++++++++++++++++++++++
>>   1 file changed, 44 insertions(+)
>>
>> diff --git a/tests/chamelium/kms_chamelium_audio.c 
>> b/tests/chamelium/kms_chamelium_audio.c
>> index 8fbc1f80e..453f3518a 100644
>> --- a/tests/chamelium/kms_chamelium_audio.c
>> +++ b/tests/chamelium/kms_chamelium_audio.c
>> @@ -28,6 +28,12 @@
>>   #include "igt_infoframe.h"
>>   #include "kms_chamelium_helper.h"
>> +/**
>> + * TEST: kms chamelium audio
>> + * Category: Display
>> + * Description: Testing Audio with a Chamelium board
>> + */
>> +
>>   /* Playback parameters control the audio signal we synthesize and 
>> send */
>>   #define PLAYBACK_CHANNELS 2
>>   #define PLAYBACK_SAMPLES 1024
>> @@ -669,6 +675,25 @@ static bool check_audio_configuration(struct alsa 
>> *alsa,
>>       return true;
>>   }
>> +/**
>> + * SUBTEST: dp-audio
>> + * Description: Playback various audio signals with various audio 
>> formats/rates,
>> + *              capture them and check they are correct
>> + * Functionality: dp_audio
>> + * Mega feature: DP
>> + * Run type: FULL
>> + * Test category: functionality test
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-audio
>> + * Description: Playback various audio signals with various audio 
>> formats/rates,
>> + *              capture them and check they are correct
>> + * Functionality: hdmi_audio
>> + * Mega feature: HDMI
> 
> Can we keep one more mega feature here as Audio, so that we can either 
> generate testlist for all audio test cases
> or for checking overall Audio passrate across HDMI, DP ...

Will add this in next rev.

> 
>> + * Run type: FULL
>> + * Test category: functionality test
>> + * Driver requirement: any
>> + */
>>   static const char test_display_audio_desc[] =
>>       "Playback various audio signals with various audio formats/rates, "
>>       "capture them and check they are correct";
>> @@ -763,6 +788,25 @@ static void test_display_audio(chamelium_data_t 
>> *data,
>>       free(alsa);
>>   }
>> +/**
>> + * SUBTEST: dp-audio-edid
>> + * Description: Plug a connector with an EDID suitable for audio, 
>> check ALSA's
>> + *              EDID-Like Data reports the correct audio parameters
>> + * Functionality: dp_audio
>> + * Mega feature: DP
>> + * Run type: FULL
>> + * Test category: functionality test
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-audio-edid
>> + * Description: Plug a connector with an EDID suitable for audio, 
>> check ALSA's
>> + *              EDID-Like Data reports the correct audio parameters
>> + * Functionality: hdmi_audio
>> + * Mega feature: HDMI
>> + * Run type: FULL
>> + * Test category: functionality test
>> + * Driver requirement: any
> 
> 
> Can we have something like requirement as well like driver requirement,
> For this chamelium will be required
> 
> 
> Also we need to have chamelium somewhere in here to populate chamelium only
> testlist/ results

Adding chamelium to the Functionality seems the best option to me.

>> + */
>>   static const char test_display_audio_edid_desc[] =
>>       "Plug a connector with an EDID suitable for audio, check ALSA's "
>>       "EDID-Like Data reports the correct audio parameters";
> 
> 
> Apart from this everything looks good
> 
> Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
> 

Re: [igt-dev] [V5, i-g-t, 07/81] tests/chamelium/kms_chamelium_edid: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Kunal,

On Thu-10-08-2023 11:38 am, Joshi, Kunal1 wrote:
> 
> On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/chamelium/kms_chamelium_edid.c | 90 +++++++++++++++++++++++++++-
>>   1 file changed, 89 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/chamelium/kms_chamelium_edid.c 
>> b/tests/chamelium/kms_chamelium_edid.c
>> index 446bbd204..579d61d15 100644
>> --- a/tests/chamelium/kms_chamelium_edid.c
>> +++ b/tests/chamelium/kms_chamelium_edid.c
>> @@ -25,8 +25,9 @@
>>    */
>>   /**
>> - * TEST: Tests behaviour of edid & timings using chamelium
>> + * TEST: kms chamelium edid
>>    * Category: Display
>> + * Description: Testing EDID with a Chamelium board
>>    */
>>   #include <fcntl.h>
>> @@ -151,6 +152,7 @@ static void check_mode(struct chamelium 
>> *chamelium, struct chamelium_port *port,
>>    * Run type: BAT
>>    * Functionality: dp
>>    * Mega feature: DP
>> + * Driver requirement: any
>>    *
>>    * SUBTEST: hdmi-edid-read
>>    * Description: Make sure the EDID exposed by KMS is the same as the 
>> screen's
>> @@ -158,6 +160,7 @@ static void check_mode(struct chamelium 
>> *chamelium, struct chamelium_port *port,
>>    * Run type: BAT
>>    * Functionality: hdmi
>>    * Mega feature: HDMI
>> + * Driver requirement: any
>>    *
>>    * SUBTEST: vga-edid-read
>>    * Description: Make sure the EDID exposed by KMS is the same as the 
>> screen's
>> @@ -165,6 +168,7 @@ static void check_mode(struct chamelium 
>> *chamelium, struct chamelium_port *port,
>>    * Run type: BAT
>>    * Functionality: vga
>>    * Mega feature: VGA
>> + * Driver requirement: any
>>    */
>>   static const char igt_custom_edid_type_read_desc[] =
>>       "Make sure the EDID exposed by KMS is the same as the screen's";
>> @@ -205,6 +209,32 @@ static void 
>> igt_custom_edid_type_read(chamelium_data_t *data,
>>       drmModeFreeConnector(connector);
>>   }
>> +/**
>> + * SUBTEST: dp-edid-stress-resolution-%s
>> + * Description: Stress test the DUT by testing multiple EDIDs, one 
>> right after
>> + *              the other, and ensure their validity by check the 
>> real screen
>> + *              resolution vs the advertised mode (%arg[1]) resolution.
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-edid-stress-resolution-%s
>> + * Description: Stress test the DUT by testing multiple EDIDs, one 
>> right after
>> + *              the other, and ensure their validity by check the 
>> real screen
>> + *              resolution vs the advertised mode (%arg[1]) resolution.
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * arg[1]:
>> + *
>> + * @4k:      4K
>> + * @non-4k:  Non 4K
>> + */
>>   static const char igt_edid_stress_resolution_desc[] =
>>       "Stress test the DUT by testing multiple EDIDs, one right after 
>> the other, "
>>       "and ensure their validity by check the real screen resolution 
>> vs the "
>> @@ -274,6 +304,17 @@ static void 
>> edid_stress_resolution(chamelium_data_t *data,
>>                     data->ports, data->port_count);
>>   }
>> +/**
>> + * SUBTEST: dp-edid-resolution-list
>> + * Description: Get an EDID with many modes of different 
>> configurations, set
>> + *              them on the screen and check the screen resolution 
>> matches the
>> + *              mode resolution.
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + */
>>   static const char igt_edid_resolution_list_desc[] =
>>       "Get an EDID with many modes of different configurations, set 
>> them on the screen and check the"
>>       " screen resolution matches the mode resolution.";
>> @@ -337,6 +378,32 @@ static void edid_resolution_list(chamelium_data_t 
>> *data,
>>       drmModeFreeConnector(connector);
>>   }
>> +/**
>> + * SUBTEST: dp-edid-change-during-%s
>> + * Description: Simulate a screen being unplugged and another screen 
>> being
>> + *              plugged during suspend, check that a uevent is sent and
>> + *              connector status is updated during %arg[1]
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-edid-change-during-%s
>> + * Description: Simulate a screen being unplugged and another screen 
>> being
>> + *              plugged during suspend, check that a uevent is sent and
>> + *              connector status is updated during %arg[1]
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * arg[1]:
>> + *
>> + * @hibernate:    hibernation
>> + * @suspend:      suspend
>> + */
>>   static const char test_suspend_resume_edid_change_desc[] =
>>       "Simulate a screen being unplugged and another screen being 
>> plugged "
>>       "during suspend, check that a uevent is sent and connector 
>> status is "
>> @@ -389,6 +456,27 @@ static void 
>> test_suspend_resume_edid_change(chamelium_data_t *data,
>>                   link_status_failed[1][p]);
>>   }
>> +/**
>> + * SUBTEST: dp-mode-timings
>> + * Description: For each mode of the IGT base EDID, perform a modeset 
>> and check
>> + *              the mode detected by the Chamelium receiver matches 
>> the mode we
>> + *              set
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-mode-timings
>> + * Description: For each mode of the IGT base EDID, perform a modeset 
>> and check
>> + *              the mode detected by the Chamelium receiver matches 
>> the mode we
>> + *              set
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + */
>>   static const char test_mode_timings_desc[] =
>>       "For each mode of the IGT base EDID, perform a modeset and check 
>> the "
>>       "mode detected by the Chamelium receiver matches the mode we set";
> 
> 
> 1) Same for all chamelium tests, we should have a some identifier for 
> getting testlist
>     for chamelium test

Sure will add it to Functionality

> 
> 2) Have Functionality as DP-EDID-READ or something?

Probably dp-edid/hdmi-edid?

- Bhanu
> 

Re: [igt-dev] [V5, i-g-t, 08/81] tests/chamelium/kms_chamelium_frames: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Sure,

On Thu-10-08-2023 11:32 am, Joshi, Kunal1 wrote:
> 
> On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem<bhanuprakash.modem@intel.com>
>> ---
>>   tests/chamelium/kms_chamelium_frames.c | 101 ++++++++++++++++++++++++-
>>   1 file changed, 99 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/chamelium/kms_chamelium_frames.c b/tests/chamelium/kms_chamelium_frames.c
>> index a56afada4..698681c4c 100644
>> --- a/tests/chamelium/kms_chamelium_frames.c
>> +++ b/tests/chamelium/kms_chamelium_frames.c
>> @@ -25,10 +25,10 @@
>>    */
>>   
>>   /**
>> - * TEST: Tests to capture frames using chamelium
>> + * TEST: kms chamelium frames
>>    * Category: Display
>> + * Description: Tests requiring a Chamelium board
>>    */
>> -
>>   #include "igt_eld.h"
>>   #include "igt_infoframe.h"
>>   #include "kms_chamelium_helper.h"
>> @@ -547,6 +547,7 @@ static void prepare_randomized_plane(chamelium_data_t *data,
>>    * Run type: BAT
>>    * Functionality: dp
>>    * Mega feature: DP
>> + * Driver requirement: any
>>    *
>>    * SUBTEST: hdmi-crc-fast
>>    * Description: Pick the first mode of the IGT base EDID, display and capture
>> @@ -555,6 +556,23 @@ static void prepare_randomized_plane(chamelium_data_t *data,
>>    * Run type: BAT
>>    * Functionality: hdmi
>>    * Mega feature: HDMI
>> + * Driver requirement: any
>> + */
>> +
>> +/**
>> + * SUBTEST: hdmi-%s-formats
>> + * Description: Pick the first mode of the IGT base EDID, display and capture a
>> + *              few frames, then check captured frames are correct
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * arg[1]:
>> + *
>> + * @crc-nonplanar:     CRC with non planar formats
>> + * @cmp-planar:        Compare with planar formats
>>    */
>>   static const char test_display_one_mode_desc[] =
>>   	"Pick the first mode of the IGT base EDID, display and capture a few "
>> @@ -592,6 +610,39 @@ static void test_display_one_mode(chamelium_data_t *data,
>>   	drmModeFreeConnector(connector);
>>   }
>>   
>> +/**
>> + * SUBTEST: vga-frame-dump
>> + * Description: For each mode of the IGT base EDID, display and capture a few
>> + *              frames, then check captured frames are correct
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: vga
>> + * Mega feature: VGA
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: dp-crc-%s
>> + * Description: For each mode of the IGT base EDID, display and capture a %arg[1]
>> + *              frame(s), then check captured frame(s) are correct
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-crc-%s
>> + * Description: For each mode of the IGT base EDID, display and capture a %arg[1]
>> + *              frame(s), then check captured frame(s) are correct
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * arg[1]:
>> + *
>> + * @single:    single
>> + * @multiple:  multiple
>> + */
>>   static const char test_display_all_modes_desc[] =
>>   	"For each mode of the IGT base EDID, display and capture a few "
>>   	"frames, then check captured frames are correct";
>> @@ -650,6 +701,27 @@ static void test_display_all_modes(chamelium_data_t *data,
>>   	} while (++i < count_modes);
>>   }
>>   
>> +/**
>> + * SUBTEST: dp-frame-dump
>> + * Description: For each mode of the IGT base EDID, display and capture a few
>> + *              frames, then download the captured frames and compare them
>> + *              bit-by-bit to the sent ones
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-frame-dump
>> + * Description: For each mode of the IGT base EDID, display and capture a few
>> + *              frames, then download the captured frames and compare them
>> + *              bit-by-bit to the sent ones
>> + * Test category: functionality test
>> + * Run type: BAT
>> + * Functionality: hdmi
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + */
>>   static const char test_display_frame_dump_desc[] =
>>   	"For each mode of the IGT base EDID, display and capture a few "
>>   	"frames, then download the captured frames and compare them "
>> @@ -718,6 +790,16 @@ static void test_display_frame_dump(chamelium_data_t *data,
>>   	} while (++i < count_modes);
>>   }
>>   
>> +/**
>> + * SUBTEST: hdmi-aspect-ratio
>> + * Description: Pick a mode with a picture aspect-ratio, capture AVI InfoFrames
>>
>> + *              and check they include the relevant fields
>> + * Test category: functionality test
>> + * Run type: BAT
>> + * Functionality: hdmi
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + */
>>   static const char test_display_aspect_ratio_desc[] =
>>   	"Pick a mode with a picture aspect-ratio, capture AVI InfoFrames and "
>>   	"check they include the relevant fields";
>> @@ -798,6 +880,21 @@ static void test_display_aspect_ratio(chamelium_data_t *data,
>>   	drmModeFreeConnector(connector);
>>   }
>>   
>> +/**
>> + * SUBTEST: hdmi-%s-planes-random
>> + * Description: Setup a few overlay planes with random parameters, capture the
>> + *              frame and check it matches the expected output
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * arg[1]:
>> + *
>> + * @crc:     CRC check
>> + * @cmp:     Compare
>> + */
>>   static const char test_display_planes_random_desc[] =
>>   	"Setup a few overlay planes with random parameters, capture the frame "
>>   	"and check it matches the expected output";
> 
> 1) Same for all chamelium tests, we should have a some identifier for 
> getting testlist
>     for chamelium test
> 
> 2) Plane random test is not used now, do we need something additional so 
> that we don't run it on CI?

It's up to you to write the query to generate any type of testlist.

> 
> 3) Here we can add mega feature as frame integrity

I think, it can be the Functionality not a Mega feature.

- Bhanu
> 
> 

Re: [igt-dev] [V5, i-g-t, 09/81] tests/chamelium/kms_chamelium_hpd: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Kunal,

On Thu-10-08-2023 11:40 am, Joshi, Kunal1 wrote:
> 1) Same for all chamelium tests, we should have a some identifier for 
> getting testlist
>     for chamelium test
> 
> 2) Have Functionality/Mega Feature as  Hotplug to identify all tests 
> which validates hotplug?

I think, Mega feature can be same (DP, HDMI etc..), and sure we can add 
hotplug to the Functionality.

- Bhanu

> 
> On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/chamelium/kms_chamelium_hpd.c | 186 +++++++++++++++++++++++++++-
>>   1 file changed, 185 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/chamelium/kms_chamelium_hpd.c 
>> b/tests/chamelium/kms_chamelium_hpd.c
>> index 8b3189ca0..d7b9f0707 100644
>> --- a/tests/chamelium/kms_chamelium_hpd.c
>> +++ b/tests/chamelium/kms_chamelium_hpd.c
>> @@ -25,8 +25,9 @@
>>    */
>>   /**
>> - * TEST: Tests behaviour of hpd using chamelium
>> + * TEST: kms chamelium hpd
>>    * Category: Display
>> + * Description: Testing HPD with a Chamelium board
>>    */
>>   #include "kms_chamelium_helper.h"
>> @@ -117,6 +118,7 @@ static void 
>> try_suspend_resume_hpd(chamelium_data_t *data,
>>    * Run type: BAT
>>    * Functionality: dp_hotplug
>>    * Mega feature: DP
>> + * Driver requirement: any
>>    *
>>    * SUBTEST: hdmi-hpd-fast
>>    * Description: Check that we get uevents and updated connector 
>> status on
>> @@ -125,6 +127,7 @@ static void 
>> try_suspend_resume_hpd(chamelium_data_t *data,
>>    * Run type: BAT
>>    * Functionality: hdmi_hotplug
>>    * Mega feature: HDMI
>> + * Driver requirement: any
>>    *
>>    * SUBTEST: vga-hpd-fast
>>    * Description: Check that we get uevents and updated connector 
>> status on
>> @@ -133,6 +136,66 @@ static void 
>> try_suspend_resume_hpd(chamelium_data_t *data,
>>    * Run type: BAT
>>    * Functionality: vga_hotplug
>>    * Mega feature: VGA
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: dp-hpd
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp_hotplug
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-hpd
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi_hotplug
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: vga-hpd
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: vga_hotplug
>> + * Mega feature: VGA
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: dp-hpd-%s
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp_hotplug
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-hpd-%s
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi_hotplug
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: vga-hpd-%s
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: vga_hotplug
>> + * Mega feature: VGA
>> + * Driver requirement: any
>> + *
>> + * arg[1]:
>> + *
>> + * @enable-disable-mode:     Toggle the mode
>> + * @with-enabled-mode:       Enabling the mode
>>    */
>>   static const char test_basic_hotplug_desc[] =
>>       "Check that we get uevents and updated connector status on "
>> @@ -200,6 +263,34 @@ static void test_hotplug(chamelium_data_t *data, 
>> struct chamelium_port *port,
>>       igt_remove_fb(data->drm_fd, &fb);
>>   }
>> +/**
>> + * SUBTEST: dp-hpd-for-each-pipe
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug for each pipe with valid output
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp_hotplug
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-hpd-for-each-pipe
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug for each pipe with valid output
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi_hotplug
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: vga-hpd-for-each-pipe
>> + * Description: Check that we get uevents and updated connector 
>> status on
>> + *              hotplug and unplug for each pipe with valid output
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: vga_hotplug
>> + * Mega feature: VGA
>> + * Driver requirement: any
>> + */
>>   static const char test_hotplug_for_each_pipe_desc[] =
>>       "Check that we get uevents and updated connector status on "
>>       "hotplug and unplug for each pipe with valid output";
>> @@ -245,6 +336,39 @@ static void 
>> test_hotplug_for_each_pipe(chamelium_data_t *data,
>>       igt_hpd_storm_reset(data->drm_fd);
>>   }
>> +/**
>> + * SUBTEST: dp-hpd-after-%s
>> + * Description: Toggle HPD during %arg[1], check that uevents are 
>> sent and
>> + *              connector status is updated
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp_hotplug
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-hpd-after-%s
>> + * Description: Toggle HPD during %arg[1], check that uevents are 
>> sent and
>> + *              connector status is updated
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi_hotplug
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: vga-hpd-after-%s
>> + * Description: Toggle HPD during %arg[1], check that uevents are 
>> sent and
>> + *              connector status is updated
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: vga_hotplug
>> + * Mega feature: VGA
>> + * Driver requirement: any
>> + *
>> + * arg[1]:
>> + *
>> + * @hibernate:     Hibernation
>> + * @suspend:       Suspend
>> + */
>>   static const char test_suspend_resume_hpd_desc[] =
>>       "Toggle HPD during suspend, check that uevents are sent and 
>> connector "
>>       "status is updated";
>> @@ -276,6 +400,16 @@ static void 
>> test_suspend_resume_hpd(chamelium_data_t *data,
>>    * Run type: BAT
>>    * Functionality: hotplug
>>    * Mega feature: General Display Features
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: common-hpd-after-hibernate
>> + * Description: Toggle HPD during suspend on all connectors, check 
>> that uevents
>> + *              are sent and connector status is updated
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hotplug
>> + * Mega feature: General Display Features
>> + * Driver requirement: any
>>    */
>>   static const char test_suspend_resume_hpd_common_desc[] =
>>       "Toggle HPD during suspend on all connectors, check that uevents 
>> are "
>> @@ -306,6 +440,16 @@ static void 
>> test_suspend_resume_hpd_common(chamelium_data_t *data,
>>       igt_cleanup_uevents(mon);
>>   }
>> +/**
>> + * SUBTEST: vga-hpd-without-ddc
>> + * Description: Disable DDC on a VGA connector, check we still get a 
>> uevent on
>> + *              hotplug
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: vga_hotplug
>> + * Mega feature: VGA
>> + * Driver requirement: any
>> + */
>>   static const char test_hpd_without_ddc_desc[] =
>>       "Disable DDC on a VGA connector, check we still get a uevent on 
>> hotplug";
>>   static void test_hpd_without_ddc(chamelium_data_t *data,
>> @@ -332,6 +476,27 @@ static void test_hpd_without_ddc(chamelium_data_t 
>> *data,
>>       igt_cleanup_uevents(mon);
>>   }
>> +/**
>> + * SUBTEST: dp-hpd-storm
>> + * Description: Trigger a series of hotplugs in a very small 
>> timeframe to
>> + *              simulate abad cable, check the kernel falls back to 
>> polling
>> + *              to avoid a hotplug storm
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp_hotplug
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-hpd-storm
>> + * Description: Trigger a series of hotplugs in a very small 
>> timeframe to
>> + *              simulate abad cable, check the kernel falls back to 
>> polling
>> + *              to avoid a hotplug storm
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi_hotplug
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + */
>>   static const char test_hpd_storm_detect_desc[] =
>>       "Trigger a series of hotplugs in a very small timeframe to 
>> simulate a"
>>       "bad cable, check the kernel falls back to polling to avoid a 
>> hotplug "
>> @@ -366,6 +531,25 @@ static void 
>> test_hpd_storm_detect(chamelium_data_t *data,
>>       igt_hpd_storm_reset(data->drm_fd);
>>   }
>> +/**
>> + * SUBTEST: dp-hpd-storm-disable
>> + * Description: Disable HPD storm detection, trigger a storm and 
>> check the
>> + *              kernel doesn't detect one
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: dp_hotplug
>> + * Mega feature: DP
>> + * Driver requirement: any
>> + *
>> + * SUBTEST: hdmi-hpd-storm-disable
>> + * Description: Disable HPD storm detection, trigger a storm and 
>> check the
>> + *              kernel doesn't detect one
>> + * Test category: functionality test
>> + * Run type: FULL
>> + * Functionality: hdmi_hotplug
>> + * Mega feature: HDMI
>> + * Driver requirement: any
>> + */
>>   static const char test_hpd_storm_disable_desc[] =
>>       "Disable HPD storm detection, trigger a storm and check the 
>> kernel "
>>       "doesn't detect one";

Re: [igt-dev] [V5 i-g-t 16/81] tests/i915/kms_dsc: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Swati,

On Wed-09-08-2023 01:20 pm, Sharma, Swati2 wrote:
> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/i915/kms_dsc.c | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>
>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
>> index 0a3e29924..4cce7face 100644
>> --- a/tests/i915/kms_dsc.c
>> +++ b/tests/i915/kms_dsc.c
>> @@ -30,8 +30,35 @@
>>    *
>>    */
>> +/**
>> + * TEST: kms dsc
>> + * Category: Display
>> + * Description: Test to validate display stream compression
>> + */
>>   #include "kms_dsc_helper.h"
>> +/**
>> + * SUBTEST: dsc-%s
>> + * Description: Tests basic display stream compression functionality 
>> if supported
>> + *              by a connector by forcing %arg[1]
> 
> forcing DSC on all connectors that support it with %arg[1]
> (remove this from below subtests description)

This description is adopted from igt_describe(), Feel free to update the 
subtest description I can pick it from there.

> 
>> + * Driver requirement: any
> 
> This is intel specific test.

Yes. As this kms testplan is designed for Intel, the allowed values are:

i915: supports i915 driver only
xe: supports xe driver only
any: supports both i915 & xe

> 
>> + * Functionality: dsc
>> + * Mega feature: VDSC
>> + * Run type: FULL
>> + * Test category: functionality test
>> + *
>> + * arg[1]:
>> + *
>> + * @basic:                DSC on all connectors that support it with 
>> default parameters
>> + * @with-bpc:             DSC on all connectors that support it with 
>> certain input BPC
>> + *                        for the connector
>> + * @with-bpc-formats:     DSC on all connectors that support it with 
>> certain input
>> + *                        BPC for the connector with diff formats
>> + * @with-formats:         DSC on all connectors that support it with 
>> default parameters
>> + *                        and creating fb with diff formats
>> + * @with-output-formats:  DSC and output format on all connectors 
>> that support it
>> + */
>> +
> 
> dsc-with-output-formats-with-bpc subtest is added too recently. please add.

Will add in next rev.

- Bhanu

> 
>>   IGT_TEST_DESCRIPTION("Test to validate display stream compression");
>>   enum dsc_test_type {

Re: [igt-dev] [V5 i-g-t 43/81] tests/kms_cursor_legacy: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 43/81] tests/kms_cursor_legacy: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/kms_cursor_legacy.c | 217 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 216 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c index
> 06dea27d6..c09dff8d9 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -23,8 +23,9 @@
>   */
> 
>  /**
> - * TEST: Stress legacy cursor ioctl
> + * TEST: kms cursor legacy
>   * Category: Display
> + * Description: Stress legacy cursor ioctl
>   */
> 
>  #include <sched.h>
> @@ -77,6 +78,28 @@ static void override_output_modes(igt_display_t
> *display,
>  	igt_output_set_pipe(output2, PIPE_NONE);  }
> 
> +/**
> + * SUBTEST: %s-%s
> + * Description: Test checks how many cursor updates we can fit between
> vblanks
> + *              on single/all pipes with different modes, priority and number
> + *              of processes
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @single:      Single
> + * @torture:     Torture
> + * @forked:      Forked
> + *
> + * arg[2]:
> + *
> + * @bo:          BO
> + * @move:        Move
> + */
>  static void stress(igt_display_t *display,
>  		   enum pipe pipe, int num_children, unsigned mode,
>  		   int timeout)
> @@ -544,11 +567,20 @@ enum basic_flip_cursor {
>  /**
>   * SUBTEST: basic-busy-flip-before-cursor-%s
>   * Description: Cursor test with %arg[1] mode
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: cursor
>   * Mega feature: General Display Features
>   *
> + * SUBTEST: basic-busy-flip-before-cursor-varying-size
> + * Description: Change the size of cursor b/w 64*64 to maxw x maxh.
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
>   * arg[1]:
>   *
>   * @atomic:	atomic
> @@ -558,6 +590,7 @@ enum basic_flip_cursor {
>  /**
>   * SUBTEST: basic-flip-after-cursor-%s
>   * Description: Cursor test with %arg[1]
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: cursor
> @@ -565,6 +598,7 @@ enum basic_flip_cursor {
>   *
>   * SUBTEST: basic-flip-before-cursor-%s
>   * Description: Cursor test with %arg[1]
> + * Driver requirement: any
>   * Test category: functionality test
>   * Run type: BAT
>   * Functionality: cursor
> @@ -576,6 +610,53 @@ enum basic_flip_cursor {
>   * @legacy:        legacy mode
>   * @varying-size:  varying size
>   */
> +
> +/**
> + * SUBTEST: %s-flip-before-cursor-%s
> + * Description: Adds variety of tests:
> + *		- varying-size: change the size of cursor b/w 64*64 to maxw x
> maxh.\n
> + *		- atomic-transition: alternates between a full screen sprite
> plane
> + *		                     and full screen primary plane.\n"
> + *		- toggle: which toggles cursor visibility and make sure cursor
> moves
> + *		          between updates.
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @short:
> + * @short-busy:
> + *
> + * arg[2]:
> + *
> + * @atomic-transitions:
> + * @atomic-transitions-varying-size:
> + * @toggle:
> + */
> +
> +/**
> + * SUBTEST: short-flip-after-cursor-%s
> + * Description: Adds variety of tests:
> + *		- varying-size: change the size of cursor b/w 64*64 to maxw x
> maxh.\n
> + *		- atomic-transition: alternates between a full screen sprite
> plane
> + *		                     and full screen primary plane.\n"
> + *		- toggle: which toggles cursor visibility and make sure cursor
> moves
> + *		          between updates.
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @atomic-transitions:
> + * @atomic-transitions-varying-size:
> + * @toggle:
> + */
>  static void basic_flip_cursor(igt_display_t *display,
>  			      enum flip_test mode,
>  			      enum basic_flip_cursor order,
> @@ -897,6 +978,25 @@ static void flip_vs_cursor(igt_display_t *display, enum
> flip_test mode, int nloo
>  		igt_remove_fb(display->drm_fd, &cursor_fb2);  }
> 
> +/**
> + * SUBTEST: long-nonblocking-modeset-vs-cursor-atomic
> + * Description: Test checks how many cursor updates we can fit between
> vblanks
> + *              on all pipes with different modes, priority and number of processes
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: nonblocking-modeset-vs-cursor-atomic
> + * Description: Test checks how many cursor updates we can fit between
> vblanks
> + *              on all pipes with different modes, priority and number of processes
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>  static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops)  {
>  	struct igt_fb fb_info, cursor_fb;
> @@ -996,6 +1096,44 @@ static void wait_for_modeset(igt_display_t *display,
> unsigned flags, int timeout
>  	igt_reset_timeout();
>  }
> 
> +/**
> + * SUBTEST: 2x-%s-%s
> + * Description: This test executes flips on both CRTCs while running cursor
> + *              updates in parallel
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @flip-vs-cursor:
> + * @flip-vs-cursor:
> + * @long-flip-vs-cursor:
> + * @long-flip-vs-cursor:
> + *
> + * arg[2]:
> + *
> + * @atomic:
> + * @legacy:
> + */
> +
> +/**
> + * SUBTEST: 2x-%s-atomic
> + * Description: This test executes flips on both CRTCs while running cursor
> + *              updates in parallel
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @long-nonblocking-modeset-vs-cursor:
> + * @nonblocking-modeset-vs-cursor:
> + */
>  static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
> modeset, bool atomic)  {
>  	struct drm_mode_cursor arg1[2], arg2[2]; @@ -1183,6 +1321,34 @@
> done:
>  	munmap((void *)shared, PAGE_SIZE);
>  }
> 
> +/**
> + * SUBTEST: %s-%s
> + * Description: The essence of the basic test is that neither the cursor nor the
> + *              nonblocking flip stall the application of the next
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @cursor-vs-flip:
> + * @cursorA-vs-flipA:
> + * @cursorA-vs-flipB:
> + * @cursorB-vs-flipA:
> + * @cursorB-vs-flipB:
> + * @flip-vs-cursor:
> + *
> + * arg[2]:
> + *
> + * @atomic:
> + * @atomic-transitions:
> + * @atomic-transitions-varying-size:
> + * @legacy:
> + * @toggle:
> + * @varying-size:
> + */
>  static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int
> nloops)  {
>  	struct drm_mode_cursor arg[2];
> @@ -1295,6 +1461,27 @@ static void cursor_vs_flip(igt_display_t *display,
> enum flip_test mode, int nloo
>  		igt_remove_fb(display->drm_fd, &cursor_fb2);  }
> 
> +/**
> + * SUBTEST: 2x-%s-%s
> + * Description: This test executes flips on both CRTCs while running
> +cursor updates in parallel
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @cursor-vs-flip:
> + * @cursor-vs-flip:
> + * @long-cursor-vs-flip:
> + * @long-cursor-vs-flip:
> + *
> + * arg[2]:
> + *
> + * @atomic:
> + * @legacy:
> + */
>  static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
> atomic)  {
>  	struct drm_mode_cursor arg[2][2];
> @@ -1423,6 +1610,20 @@ static void two_screens_cursor_vs_flip(igt_display_t
> *display, int nloops, bool
>  	munmap((void *)shared, PAGE_SIZE);
>  }
> 
> +/**
> + * SUBTEST: flip-vs-cursor-crc-%s
> + * Description: this test perform a page flip followed by a cursor
> +update
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @atomic:
> + * @legacy:
> + */
>  static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)  {
>  	struct drm_mode_cursor arg[2];
> @@ -1495,6 +1696,20 @@ static void flip_vs_cursor_crc(igt_display_t *display,
> bool atomic)
>  	igt_remove_fb(display->drm_fd, &cursor_fb);  }
> 
> +/**
> + * SUBTEST: flip-vs-cursor-busy-crc-%s
> + * Description: this test perform a busy bo update followed by a cursor
> +update
> + * Driver requirement: any
> + * Functionality: cursor
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @atomic:
> + * @legacy:
> + */
>  static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)  {
>  	struct drm_mode_cursor arg[2];
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 59/81] tests/kms_plane: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 59/81] tests/kms_plane: Document each subtest for
> testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/kms_plane.c | 58
> +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 67cff61d6..8c6ce78f3
> 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -24,6 +24,11 @@
>   *   Damien Lespiau <damien.lespiau@intel.com>
>   */
> 
> +/**
> + * TEST: kms plane
> + * Category: Display
> + * Description: Testes for KMS Plane
> + */
>  #include "igt.h"
>  #include "igt_vec.h"
>  #include <errno.h>
> @@ -273,6 +278,21 @@ test_plane_position_with_output(data_t *data,
>  	igt_remove_fb(data->drm_fd, &sprite_fb);  }
> 
> +/**
> + * SUBTEST: plane-position-%s
> + * Description: Verify plane position using two planes to create a
> +%arg[1]
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @covered:           fully covered screen
> + * @hole:              partially covered screen
> + * @hole-dpms:         partially covered screen and check for DPMS
> + */
>  static void
>  test_plane_position(data_t *data, enum pipe pipe)  { @@ -381,6 +401,21 @@
> test_plane_panning_with_output(data_t *data,
>  	igt_remove_fb(data->drm_fd, &primary_fb);  }
> 
> +/**
> + * SUBTEST: plane-panning-%s
> + * Description: Verify plane panning at %arg[1] using primary plane
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @bottom-right:               bottom-right position
> + * @bottom-right-suspend:       bottom-right position with suspend
> + * @top-left:                   top-left position
> + */
>  static void
>  test_plane_panning(data_t *data, enum pipe pipe)  { @@ -1101,6 +1136,20
> @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
>  	return index != 0 && index != 3 && index != 5;  }
> 
> +/**
> + * SUBTEST: pixel-%s
> + * Description: verify the pixel formats for given plane and pipe
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @format:
> + * @format-source-clamping:          with source clamping
> + */
>  static void
>  test_pixel_formats(data_t *data, enum pipe pipe)  { @@ -1157,6 +1206,15 @@
> test_pixel_formats(data_t *data, enum pipe pipe)
>  	igt_assert_f(result, "At least one CRC mismatch happened\n");  }
> 
> +/**
> + * SUBTEST: invalid-pixel-format-settings
> + * Description: verify invalid settings for pixel format are not
> +accepted
> + * Driver requirement: any
> + * Functionality: plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>  static void test_invalid_settings(data_t *data)  {
>  	enum pipe pipe = PIPE_A;
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 19/81] tests/i915/kms_fence_pin_leak: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Karthik,

On Wed-09-08-2023 02:50 pm, Karthik B S wrote:
> Hi,
> 
> On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/i915/kms_fence_pin_leak.c | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/tests/i915/kms_fence_pin_leak.c 
>> b/tests/i915/kms_fence_pin_leak.c
>> index 3d63acfef..0321aa3cb 100644
>> --- a/tests/i915/kms_fence_pin_leak.c
>> +++ b/tests/i915/kms_fence_pin_leak.c
>> @@ -30,6 +30,19 @@
>>   #include "i915/gem.h"
>>   #include "igt.h"
>> +/**
>> + * TEST: kms fence pin leak
>> + * Category: Display
>> + * Description: Exercises full ppgtt fence pin_count leak in the kernel.
> 
> This test actually has no subtest defined. Do we need duplicate 
> definitions in this case?

Purpose of these two descriptions are different (One is for overall test 
& another is for each subtest).

Please try to check using these two methods, you can understand:

./scripts/igt_doc.py --config=tests/kms_test_config.json 
--filter-field=Functionality=~'kms_core, synchronization'

./scripts/igt_doc.py --config=tests/kms_test_config.json 
--filter-field=Functionality=~'kms_core, synchronization' --per-test

- Bhanu

> 
> Thanks,
> Karthik.B.S
> 
>> + *
>> + * SUBTEST:
>> + * Description: Exercises full ppgtt fence pin_count leak in the kernel.
>> + * Driver requirement: i915
>> + * Functionality: kms_core, synchronization
>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + */
>>   IGT_TEST_DESCRIPTION("Exercises full ppgtt fence pin_count leak in 
>> the "
>>                "kernel.");

Re: [igt-dev] [V5 i-g-t 61/81] tests/kms_plane_cursor: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Thursday, June 29, 2023 8:19 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [V5 i-g-t 61/81] tests/kms_plane_cursor: Document each
> subtest for testplan
> 
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>

> ---
>  tests/kms_plane_cursor.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c index
> a7acb18e1..bf217fbcb 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -21,6 +21,36 @@
>   */
> 
>  #include "igt.h"
> +/**
> + * TEST: kms plane cursor
> + * Category: Display
> + * Description: Tests cursor interactions with primary and overlay planes.
> + *
> + * SUBTEST: overlay
> + * Description: Tests atomic cursor positioning on primary plane and
> +overlay plane
> + * Driver requirement: any
> + * Functionality: cursor, plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: primary
> + * Description: Tests atomic cursor positioning on primary plane
> + * Driver requirement: any
> + * Functionality: cursor, plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: viewport
> + * Description: Tests atomic cursor positioning on primary plane and overlay
> plane
> + *              with buffer larger than viewport used for display
> + * Driver requirement: any
> + * Functionality: cursor, plane
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
> 
>  /*
>   * This file tests cursor interactions with primary and overlay planes.
> --
> 2.40.0

Re: [igt-dev] [V5 i-g-t 04/81] testplan/kms: Exclude kms helpers form testplan

[Kamil Konieczny]

Hi Bhanuprakash,

small nit in subject:
testplan/kms: Exclude kms helpers form testplan
---------------------------------- ^^
s/form/from/

With that fixed,
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

--
Kamil

On 2023-06-29 at 20:17:53 +0530, Bhanuprakash Modem wrote:
> As we are using wild cards in testplan, it'll expect a binary
> for each source (.c) file. Exclude kms helpers from testplan
> to avoid the build failures.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  tests/kms_test_config.json | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_test_config.json b/tests/kms_test_config.json
> index 499f418ab..9219ae4eb 100644
> --- a/tests/kms_test_config.json
> +++ b/tests/kms_test_config.json
> @@ -2,6 +2,8 @@
>      "description": "JSON file to be used to parse KMS documentation",
>      "name": "Display and KMS Tests for Intel i915 and Xe Drivers",
>      "files": [ "chamelium/kms_*.c", "i915/kms_*.c", "kms_*.c", "testdisplay.c" ],
> +    "exclude_files": [ "chamelium/kms_chamelium_helper.c", "i915/kms_dsc_helper.c",
> +                       "kms_color_helper.c"],
>      "fields": {
>          "Category": {
>              "_properties_": {
> -- 
> 2.40.0
> 

Re: [igt-dev] [V5 i-g-t 01/81] testplan/kms: Keep category as high level entity

[Kamil Konieczny]

Hi Bhanuprakash,
On 2023-06-29 at 20:17:50 +0530, Bhanuprakash Modem wrote:
> Update kms testplan to keep the category as high level entity.
> 
+cc Mauro

> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  tests/kms_test_config.json | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/tests/kms_test_config.json b/tests/kms_test_config.json
> index 5fbe40bdc..447a13337 100644
> --- a/tests/kms_test_config.json
> +++ b/tests/kms_test_config.json
> @@ -6,21 +6,21 @@
>          "Category": {
>              "_properties_": {
>                  "description": "Contains the major group for the tested functionality 'Display'"
> -            }
> -        },
> -        "Mega feature": {
> -            "_properties_": {
> -                "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
>              },
> -            "Functionality": {
> +            "Mega feature": {
>                  "_properties_": {
> -                    "description": "Groups tests on buckets containg more detailed functionality"
> +                    "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
> +                },
> +                "Functionality": {
> +                    "_properties_": {
> +                        "description": "Groups tests on buckets containg more detailed functionality"
> +                    }
> +                }
> +            },
> +            "Run type": {
> +                "_properties_": {
> +                    "description": "Defines what category of testlist it belongs"
>                  }
> -            }
> -        },
> -        "Run type": {
> -            "_properties_": {
> -                "description": "Defines what category of testlist it belongs"
>              }
>          },
>          "Test category": {
> -- 
> 2.40.0
> 

Re: [igt-dev] [V5 i-g-t 23/81] tests/i915/kms_legacy_colorkey: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Swati,

On Wed-09-08-2023 05:22 pm, Sharma, Swati2 wrote:
> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/i915/kms_legacy_colorkey.c | 21 +++++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>
>> diff --git a/tests/i915/kms_legacy_colorkey.c 
>> b/tests/i915/kms_legacy_colorkey.c
>> index 450cb2e3f..fb1952113 100644
>> --- a/tests/i915/kms_legacy_colorkey.c
>> +++ b/tests/i915/kms_legacy_colorkey.c
>> @@ -24,6 +24,27 @@
>>   #include "igt.h"
>>   #include <errno.h>
>> +/**
>> + * TEST: kms legacy colorkey
>> + * Category: Display
>> + * Description: Check that the legacy set colorkey ioctl only works 
>> on sprite planes.
>> + *
>> + * SUBTEST: basic
>> + * Description: Test to check the legacy set colorkey ioctl only 
>> works for sprite planes.
> 
> Test description and subtest description is same.

This is simply adopted from igt_describe(), please feel free to fix that.

- Bhanu

> 
>> + * Driver requirement: i915
>> + * Functionality: xorg_xv
>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + *
>> + * SUBTEST: invalid-plane
>> + * Description: Check invalid plane id's, zero and outrange
>> + * Driver requirement: i915
>> + * Functionality: xorg_xv
>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + */
>>   IGT_TEST_DESCRIPTION("Check that the legacy set colorkey ioctl only 
>> works on sprite planes.");

Re: [igt-dev] [V5 i-g-t 10/81] tests/i915/kms_big_fb: Document each subtest for testplan

[Karthik B S]

Hi,

On 6/29/2023 8:17 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
>
> V2: - Fix driver requirement
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_big_fb.c | 132 ++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 132 insertions(+)
>
> diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
> index 44ea117a1..84485e244 100644
> --- a/tests/i915/kms_big_fb.c
> +++ b/tests/i915/kms_big_fb.c
> @@ -21,6 +21,12 @@
>    * IN THE SOFTWARE.
>    */
>   
> +/**
> + * TEST: kms big fb
> + * Category: Display
> + * Description: Test big framebuffers
> + */
> +
>   #include "igt.h"
>   #include <errno.h>
>   #include <stdbool.h>
> @@ -582,6 +588,78 @@ max_hw_stride_async_flip_test(data_t *data)
>   	return true;
>   }
>   
> +/**
> + * SUBTEST: %s-%dbpp-rotate-%d
> + * Description: Sanity check if addfb ioctl works correctly for given combination
> + *              of %arg[1] with %arg[2]-bpp & %arg[3]-rotation
> + * Driver requirement: any
> + * Functionality: xorg_big_displays

Overall the patch LGTM. Just one query. Do we also need 
'kms_gem_interop' added in Functionality for all the subtests like other 
fb binaries.

Thanks,
Karthik.B.S
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @linear:             Linear modifier
> + * @4-tiled:            TILE-4 modifier
> + * @x-tiled:            TILE-X modifier
> + * @y-tiled:            TILE-Y modifier
> + * @yf-tiled:           TILE-YF modifier
> + *
> + * arg[2].values:       8, 16, 32, 64
> + * arg[3].values:       0, 90, 180, 270
> + */
> +
> +/**
> + * SUBTEST: %s-max-hw-stride-%dbpp-rotate-%d
> + * Description: Test maximum hardware supported stride length for given combination
> + *              of %arg[1] modifier with max hardware stride length, %arg[2]-bpp,
> + *              and %arg[3]-rotation
> + * Driver requirement: any
> + * Functionality: xorg_big_displays
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @linear:             Linear modifier
> + * @4-tiled:            TILE-4 modifier
> + * @x-tiled:            TILE-X modifier
> + * @y-tiled:            TILE-Y modifier
> + * @yf-tiled:           TILE-YF modifier
> + *
> + * arg[2].values:       32, 64
> + * arg[3].values:       0, 180
> + */
> +
> +/**
> + * SUBTEST: %s-max-hw-stride-%dbpp-rotate-%d-%s
> + * Description: Test maximum hardware supported stride length for given combination
> + *              of %arg[1] modifier with max hardware stride length, %arg[2]-bpp,
> + *              and %arg[3]-rotation with %arg[4] mode
> + * Driver requirement: any
> + * Functionality: xorg_big_displays
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @4-tiled:            TILE-4 modifier
> + * @x-tiled:            TILE-X modifier
> + * @y-tiled:            TILE-Y modifier
> + * @yf-tiled:           TILE-YF modifier
> + *
> + * arg[2].values:       32, 64
> + * arg[3].values:       0, 180
> + *
> + * arg[4]:
> + *
> + * @async-flip:         Async flip
> + * @hflip:              H-flip
> + * @hflip-async-flip:   Async & H-flip
> + */
>   static void test_scanout(data_t *data)
>   {
>   	igt_output_t *output;
> @@ -627,6 +705,24 @@ static void test_scanout(data_t *data)
>   	igt_skip("unsupported configuration\n");
>   }
>   
> +/**
> + * SUBTEST: %s-addfb-size-overflow
> + * Description: Sanity check if addfb ioctl fails correctly for (%arg[1]) modifier
> + *              with small bo.
> + * Driver requirement: any
> + * Functionality: xorg_big_displays
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @linear:     Linear
> + * @4-tiled:    TILE-4
> + * @x-tiled:    TILE-X
> + * @y-tiled:    TILE-Y
> + * @yf-tiled:   TILE-YF
> + */
>   static void
>   test_size_overflow(data_t *data)
>   {
> @@ -671,6 +767,24 @@ test_size_overflow(data_t *data)
>   	gem_close(data->drm_fd, bo);
>   }
>   
> +/**
> + * SUBTEST: %s-addfb-size-offset-overflow
> + * Description: Sanity check if addfb ioctl fails correctly for (%arg[1]) modifier
> + *              and offsets with small bo
> + * Driver requirement: any
> + * Functionality: xorg_big_displays
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @linear:     Linear
> + * @4-tiled:    TILE-4
> + * @x-tiled:    TILE-X
> + * @y-tiled:    TILE-Y
> + * @yf-tiled:   TILE-YF
> + */
>   static void
>   test_size_offset_overflow(data_t *data)
>   {
> @@ -729,6 +843,24 @@ static int rmfb(int fd, uint32_t id)
>   	return err;
>   }
>   
> +/**
> + * SUBTEST: %s-addfb
> + * Description: Sanity check if addfb ioctl works correctly with %arg[1] modifier
> + *              for given size and strides of fb
> + * Driver requirement: any
> + * Functionality: xorg_big_displays
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * arg[1]:
> + *
> + * @linear:     Linear
> + * @4-tiled:    TILE-4
> + * @x-tiled:    TILE-X
> + * @y-tiled:    TILE-Y
> + * @yf-tiled:   TILE-YF
> + */
>   static void
>   test_addfb(data_t *data)
>   {

Re: [igt-dev] [V5 i-g-t 25/81] tests/i915/kms_pipe_b_c_ivb: Document each subtest for testplan

[Thasleem, Mohammed]

LGTM:
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>


On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote:
> Add documentation for all kms tests which is used by IGT testplan
> documentation.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/i915/kms_pipe_b_c_ivb.c | 52 +++++++++++++++++++++++++++++++++++
>   1 file changed, 52 insertions(+)
> 
> diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
> index 192771794..f19355511 100644
> --- a/tests/i915/kms_pipe_b_c_ivb.c
> +++ b/tests/i915/kms_pipe_b_c_ivb.c
> @@ -25,6 +25,58 @@
>    */
>   
>   #include "igt.h"
> +/**
> + * TEST: kms pipe b c ivb
> + * Category: Display
> + * Description: Exercise the FDI lane bifurcation code for IVB in the kernel by
> + *              setting different combinations of modes for pipes B and C.
> + *
> + * SUBTEST: disable-pipe-B-enable-pipe-C
> + * Description: Tests pipe-B and pipe-C interactions in IVB by disabling pipe-B
> + *              and then setting mode on pipe-C.
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: enable-pipe-C-while-B-has-3-lanes
> + * Description: Tests pipe-B and pipe-C interactions in IVB by enabling pipe-C
> + *              while pipe-B has 3-lanes
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: from-pipe-C-to-B-with-3-lanes
> + * Description: Tests pipe-B and pipe-C interactions in IVB by enabling pipe-B
> + *              with 3 lanes from pipe-C.
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: pipe-B-double-modeset-then-modeset-pipe-C
> + * Description: Tests pipe-B and pipe-C interactions in IVB by enabling two
> + *              different modes on pipe-B and then a single mode on pipe-C.
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + *
> + * SUBTEST: pipe-B-dpms-off-modeset-pipe-C
> + * Description: Tests pipe-B and pipe-C interactions in IVB by enabling pipe-B
> + *              with mode that requires 3 lanes and then enabling pipe-c with
> + *              dpms off/on pipe-B.
> + * Driver requirement: i915
> + * Functionality: kms_core
> + * Mega feature: General Display Features
> + * Run type: FULL
> + * Test category: functionality test
> + */
>   
>   IGT_TEST_DESCRIPTION(
>   "Exercise the FDI lane bifurcation code for IVB in the kernel by setting"

Re: [igt-dev] [V5 i-g-t 16/81] tests/i915/kms_dsc: Document each subtest for testplan

[Sharma, Swati2]

On 10-Aug-23 10:53 PM, Modem, Bhanuprakash wrote:
> Hi Swati,
> 
> On Wed-09-08-2023 01:20 pm, Sharma, Swati2 wrote:
>> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
>>> Add documentation for all kms tests which is used by IGT testplan
>>> documentation.
>>>
>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>> ---
>>>   tests/i915/kms_dsc.c | 27 +++++++++++++++++++++++++++
>>>   1 file changed, 27 insertions(+)
>>>
>>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
>>> index 0a3e29924..4cce7face 100644
>>> --- a/tests/i915/kms_dsc.c
>>> +++ b/tests/i915/kms_dsc.c
>>> @@ -30,8 +30,35 @@
>>>    *
>>>    */
>>> +/**
>>> + * TEST: kms dsc
>>> + * Category: Display
>>> + * Description: Test to validate display stream compression
>>> + */
>>>   #include "kms_dsc_helper.h"
>>> +/**
>>> + * SUBTEST: dsc-%s
>>> + * Description: Tests basic display stream compression functionality 
>>> if supported
>>> + *              by a connector by forcing %arg[1]
>>
>> forcing DSC on all connectors that support it with %arg[1]
>> (remove this from below subtests description)
> 
> This description is adopted from igt_describe(), Feel free to update the 
> subtest description I can pick it from there.

But you haven't copied it as it is..right? Its the optimized version
of igt_describe(). I simply meant.
"forcing DSC on all connectors that support it with %arg[1]" => is 
redundant in descriptions you have written below for each subtest.
We don't have to change igt_describe() for this. This should be handled 
here.

> 
>>
>>> + * Driver requirement: any
>>
>> This is intel specific test.
> 
> Yes. As this kms testplan is designed for Intel, the allowed values are:
> 
> i915: supports i915 driver only
> xe: supports xe driver only
> any: supports both i915 & xe

This ANY seems to correspond to drm_open_driver_master(DRIVER_ANY).
IDK this is right. @mauro do you have any inputs here?
Shouldn't "any" correspond to "any" driver. Even if this documentation
is specific to intel but tests outside i915/ directory are used by other
vendors too.

> 
>>
>>> + * Functionality: dsc
>>> + * Mega feature: VDSC
>>> + * Run type: FULL
>>> + * Test category: functionality test
>>> + *
>>> + * arg[1]:
>>> + *
>>> + * @basic:                DSC on all connectors that support it with 
>>> default parameters
>>> + * @with-bpc:             DSC on all connectors that support it with 
>>> certain input BPC
>>> + *                        for the connector
>>> + * @with-bpc-formats:     DSC on all connectors that support it with 
>>> certain input
>>> + *                        BPC for the connector with diff formats
>>> + * @with-formats:         DSC on all connectors that support it with 
>>> default parameters
>>> + *                        and creating fb with diff formats
>>> + * @with-output-formats:  DSC and output format on all connectors 
>>> that support it
>>> + */
>>> +
>>
>> dsc-with-output-formats-with-bpc subtest is added too recently. please 
>> add.
> 
> Will add in next rev.
> 
> - Bhanu
> 
>>
>>>   IGT_TEST_DESCRIPTION("Test to validate display stream compression");
>>>   enum dsc_test_type {

Re: [igt-dev] [V5 i-g-t 23/81] tests/i915/kms_legacy_colorkey: Document each subtest for testplan

[Sharma, Swati2]

On 10-Aug-23 11:35 PM, Modem, Bhanuprakash wrote:
> Hi Swati,
> 
> On Wed-09-08-2023 05:22 pm, Sharma, Swati2 wrote:
>> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
>>> Add documentation for all kms tests which is used by IGT testplan
>>> documentation.
>>>
>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>> ---
>>>   tests/i915/kms_legacy_colorkey.c | 21 +++++++++++++++++++++
>>>   1 file changed, 21 insertions(+)
>>>
>>> diff --git a/tests/i915/kms_legacy_colorkey.c 
>>> b/tests/i915/kms_legacy_colorkey.c
>>> index 450cb2e3f..fb1952113 100644
>>> --- a/tests/i915/kms_legacy_colorkey.c
>>> +++ b/tests/i915/kms_legacy_colorkey.c
>>> @@ -24,6 +24,27 @@
>>>   #include "igt.h"
>>>   #include <errno.h>
>>> +/**
>>> + * TEST: kms legacy colorkey
>>> + * Category: Display
>>> + * Description: Check that the legacy set colorkey ioctl only works 
>>> on sprite planes.
>>> + *
>>> + * SUBTEST: basic
>>> + * Description: Test to check the legacy set colorkey ioctl only 
>>> works for sprite planes.
>>
>> Test description and subtest description is same.
> 
> This is simply adopted from igt_describe(), please feel free to fix that.
> 
> - Bhanu

Hi Bhanu,
I don't agree. If efforts are done to improve documentation. It should 
be done here. In the end, once this activity is done, igt_describe() and
IGT_DESC() will be removed.

> 
>>
>>> + * Driver requirement: i915
>>> + * Functionality: xorg_xv
>>> + * Mega feature: General Display Features
>>> + * Run type: FULL
>>> + * Test category: functionality test
>>> + *
>>> + * SUBTEST: invalid-plane
>>> + * Description: Check invalid plane id's, zero and outrange
>>> + * Driver requirement: i915
>>> + * Functionality: xorg_xv
>>> + * Mega feature: General Display Features
>>> + * Run type: FULL
>>> + * Test category: functionality test
>>> + */
>>>   IGT_TEST_DESCRIPTION("Check that the legacy set colorkey ioctl only 
>>> works on sprite planes.");

Re: [igt-dev] [V5 i-g-t 39/81] tests/kms_concurrent: Document each subtest for testplan

[Sharma, Swati2]

On 09-Aug-23 5:35 PM, Sharma, Swati2 wrote:
> LGTM
> Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
> 
> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/kms_concurrent.c | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
>> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
>> index d915a98b2..f5fe321a2 100644
>> --- a/tests/kms_concurrent.c
>> +++ b/tests/kms_concurrent.c
>> @@ -24,6 +24,32 @@
>>   #include "igt.h"
>>   #include "drmtest.h"
>> +/**
>> + * TEST: kms concurrent
>> + * Category: Display
>> + * Description: Test atomic mode setting concurrently with multiple 
>> planes and
>> + *              screen resolution
>> + *
>> + * SUBTEST: pipe-%s
>> + * Description: Test atomic mode setting concurrently with multiple 
>> planes and
>> + *              screen resolution on %arg[1].
>> + * Driver requirement: any
>> + * Functionality: kms_core

Sorry, missed in previous review. Add plane as functionality too.

>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + *
>> + * arg[1]:
>> + *
>> + * @A:      pipe A
>> + * @B:      pipe B
>> + * @C:      pipe C
>> + * @D:      pipe D
>> + * @E:      pipe E
>> + * @F:      pipe F
>> + * @G:      pipe G
>> + * @H:      pipe H
>> + */
>>   IGT_TEST_DESCRIPTION("Test atomic mode setting concurrently with 
>> multiple planes and screen resolution");

Re: [igt-dev] [V5 i-g-t 44/81] tests/kms_display_modes: Document each subtest for testplan

[Sharma, Swati2]

On 09-Aug-23 10:57 AM, B, Jeevan wrote:
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
>> Bhanuprakash Modem
>> Sent: Thursday, June 29, 2023 8:19 PM
>> To: igt-dev@lists.freedesktop.org
>> Subject: [igt-dev] [V5 i-g-t 44/81] tests/kms_display_modes: Document each
>> subtest for testplan
>>
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> V2: - Add missing documentation
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> 
> LGTM.
> Reviewed-by: Jeevan B <jeevan.b@intel.com>
>> ---
>>   tests/kms_display_modes.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c index
>> 93d91ef5b..b26a3f71a 100644
>> --- a/tests/kms_display_modes.c
>> +++ b/tests/kms_display_modes.c
>> @@ -24,6 +24,11 @@
>>    *  Jeevan B <jeevan.b@intel.com>
>>    */
>>
>> +/**
>> + * TEST: kms display modes
>> + * Category: Display
>> + * Description: Test Display Modes
>> + */
>>   #include "igt.h"
>>
>>   #define HDISPLAY_4K	3840
>> @@ -231,6 +236,16 @@ static void run_extendedmode_basic(data_t *data,
>>   	for_each_connected_output_local((display), (output)) \
>>   		for_each_if (igt_pipe_connector_valid((pipe), (output)))
>>
>> +/**
>> + * SUBTEST: extended-mode-basic
>> + * Description: Test for validating display extended mode with a pair of
>> connected
>> + *              displays
>> + * Driver requirement: any
>> + * Functionality: kms_core
>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + */
>>   static void run_extendedmode_test(data_t *data) {
>>   	enum pipe pipe1, pipe2;
>>   	igt_output_t *output1, *output2;
>> @@ -276,6 +291,16 @@ static void run_extendedmode_test(data_t *data) {
>>   	}
>>   }
>>
>> +/**
>> + * SUBTEST: mst-extended-mode-negative
>> + * Description: Negative test for validating display extended mode with a
>> pair
>> + *		of connected 2k-4k or 4k-4k displays.
>> + * Driver requirement: any
>> + * Functionality: kms_core

Should we add functionality as mst here?

>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + */
>>   static void run_extendedmode_negative(data_t *data, int pipe1, int pipe2)
>> {
>>   	struct igt_fb fbs[2];
>> --
>> 2.40.0
> 

Re: [igt-dev] [V5 i-g-t 16/81] tests/i915/kms_dsc: Document each subtest for testplan

[Mauro Carvalho Chehab]

On Mon, 14 Aug 2023 10:34:52 +0530
"Sharma, Swati2" <swati2.sharma@intel.com> wrote:

> On 10-Aug-23 10:53 PM, Modem, Bhanuprakash wrote:
> > Hi Swati,
> > 
> > On Wed-09-08-2023 01:20 pm, Sharma, Swati2 wrote:  
> >> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:  
> >>> Add documentation for all kms tests which is used by IGT testplan
> >>> documentation.
> >>>
> >>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> >>> ---
> >>>   tests/i915/kms_dsc.c | 27 +++++++++++++++++++++++++++
> >>>   1 file changed, 27 insertions(+)
> >>>
> >>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> >>> index 0a3e29924..4cce7face 100644
> >>> --- a/tests/i915/kms_dsc.c
> >>> +++ b/tests/i915/kms_dsc.c
> >>> @@ -30,8 +30,35 @@
> >>>    *
> >>>    */
> >>> +/**
> >>> + * TEST: kms dsc
> >>> + * Category: Display
> >>> + * Description: Test to validate display stream compression
> >>> + */
> >>>   #include "kms_dsc_helper.h"
> >>> +/**
> >>> + * SUBTEST: dsc-%s
> >>> + * Description: Tests basic display stream compression functionality 
> >>> if supported
> >>> + *              by a connector by forcing %arg[1]  
> >>
> >> forcing DSC on all connectors that support it with %arg[1]
> >> (remove this from below subtests description)  
> > 
> > This description is adopted from igt_describe(), Feel free to update the 
> > subtest description I can pick it from there.  
> 
> But you haven't copied it as it is..right? Its the optimized version
> of igt_describe(). I simply meant.
> "forcing DSC on all connectors that support it with %arg[1]" => is 
> redundant in descriptions you have written below for each subtest.
> We don't have to change igt_describe() for this. This should be handled 
> here.
> 
> >   
> >>  
> >>> + * Driver requirement: any  
> >>
> >> This is intel specific test.  
> > 
> > Yes. As this kms testplan is designed for Intel, the allowed values are:
> > 
> > i915: supports i915 driver only
> > xe: supports xe driver only
> > any: supports both i915 & xe  
> 
> This ANY seems to correspond to drm_open_driver_master(DRIVER_ANY).
> IDK this is right. @mauro do you have any inputs here?
> Shouldn't "any" correspond to "any" driver. Even if this documentation
> is specific to intel but tests outside i915/ directory are used by other
> vendors too.

IMO, the best here is to provide a list of drivers that support the test,
e. g.:

	Driver requirement: i915, xe

Rationale:

- It lets it clear that only Intel drivers are supported;
- It is clear what drivers support it;
- There's no need to document somewhere what "any" means;
- If in the future we have a new XYZ driver that it is not supported
  by this test, there won't be any need to change existing documentation;
- We already use comma-separated lists for other fields, like feature
  (used on some core tests and at i915 driver).

Regards,
Mauro

Re: [igt-dev] [V5 i-g-t 01/81] testplan/kms: Keep category as high level entity

[Mauro Carvalho Chehab]

On Thu, 10 Aug 2023 19:51:05 +0200
Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:

> Hi Bhanuprakash,
> On 2023-06-29 at 20:17:50 +0530, Bhanuprakash Modem wrote:
> > Update kms testplan to keep the category as high level entity.
> >   
> +cc Mauro
> 
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > ---
> >  tests/kms_test_config.json | 24 ++++++++++++------------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> > 
> > diff --git a/tests/kms_test_config.json b/tests/kms_test_config.json
> > index 5fbe40bdc..447a13337 100644
> > --- a/tests/kms_test_config.json
> > +++ b/tests/kms_test_config.json
> > @@ -6,21 +6,21 @@
> >          "Category": {
> >              "_properties_": {
> >                  "description": "Contains the major group for the tested functionality 'Display'"
> > -            }
> > -        },
> > -        "Mega feature": {
> > -            "_properties_": {
> > -                "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
> >              },
> > -            "Functionality": {
> > +            "Mega feature": {
> >                  "_properties_": {
> > -                    "description": "Groups tests on buckets containg more detailed functionality"
> > +                    "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
> > +                },
> > +                "Functionality": {
> > +                    "_properties_": {
> > +                        "description": "Groups tests on buckets containg more detailed functionality"
> > +                    }
> > +                }
> > +            },
> > +            "Run type": {
> > +                "_properties_": {
> > +                    "description": "Defines what category of testlist it belongs"
> >                  }
> > -            }
> > -        },
> > -        "Run type": {
> > -            "_properties_": {
> > -                "description": "Defines what category of testlist it belongs"
> >              }
> >          },
> >          "Test category": {

LGTM.

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Re: [igt-dev] [V5 i-g-t 16/81] tests/i915/kms_dsc: Document each subtest for testplan

[Sharma, Swati2]

On 14-Aug-23 3:09 PM, Mauro Carvalho Chehab wrote:
> On Mon, 14 Aug 2023 10:34:52 +0530
> "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
> 
>> On 10-Aug-23 10:53 PM, Modem, Bhanuprakash wrote:
>>> Hi Swati,
>>>
>>> On Wed-09-08-2023 01:20 pm, Sharma, Swati2 wrote:
>>>> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
>>>>> Add documentation for all kms tests which is used by IGT testplan
>>>>> documentation.
>>>>>
>>>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>>>> ---
>>>>>    tests/i915/kms_dsc.c | 27 +++++++++++++++++++++++++++
>>>>>    1 file changed, 27 insertions(+)
>>>>>
>>>>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
>>>>> index 0a3e29924..4cce7face 100644
>>>>> --- a/tests/i915/kms_dsc.c
>>>>> +++ b/tests/i915/kms_dsc.c
>>>>> @@ -30,8 +30,35 @@
>>>>>     *
>>>>>     */
>>>>> +/**
>>>>> + * TEST: kms dsc
>>>>> + * Category: Display
>>>>> + * Description: Test to validate display stream compression
>>>>> + */
>>>>>    #include "kms_dsc_helper.h"
>>>>> +/**
>>>>> + * SUBTEST: dsc-%s
>>>>> + * Description: Tests basic display stream compression functionality
>>>>> if supported
>>>>> + *              by a connector by forcing %arg[1]
>>>>
>>>> forcing DSC on all connectors that support it with %arg[1]
>>>> (remove this from below subtests description)
>>>
>>> This description is adopted from igt_describe(), Feel free to update the
>>> subtest description I can pick it from there.
>>
>> But you haven't copied it as it is..right? Its the optimized version
>> of igt_describe(). I simply meant.
>> "forcing DSC on all connectors that support it with %arg[1]" => is
>> redundant in descriptions you have written below for each subtest.
>> We don't have to change igt_describe() for this. This should be handled
>> here.
>>
>>>    
>>>>   
>>>>> + * Driver requirement: any
>>>>
>>>> This is intel specific test.
>>>
>>> Yes. As this kms testplan is designed for Intel, the allowed values are:
>>>
>>> i915: supports i915 driver only
>>> xe: supports xe driver only
>>> any: supports both i915 & xe
>>
>> This ANY seems to correspond to drm_open_driver_master(DRIVER_ANY).
>> IDK this is right. @mauro do you have any inputs here?
>> Shouldn't "any" correspond to "any" driver. Even if this documentation
>> is specific to intel but tests outside i915/ directory are used by other
>> vendors too.
> 
> IMO, the best here is to provide a list of drivers that support the test,
> e. g.:
> 
> 	Driver requirement: i915, xe
> 
> Rationale:
> 
> - It lets it clear that only Intel drivers are supported;
> - It is clear what drivers support it;
> - There's no need to document somewhere what "any" means;
> - If in the future we have a new XYZ driver that it is not supported
>    by this test, there won't be any need to change existing documentation;
> - We already use comma-separated lists for other fields, like feature
>    (used on some core tests and at i915 driver).

Agree. @modem can we make these changes in complete series?

> 
> Regards,
> Mauro

Re: [igt-dev] [V5 i-g-t 16/81] tests/i915/kms_dsc: Document each subtest for testplan

[Modem, Bhanuprakash]

Hi Swati,

On Mon-14-08-2023 10:34 am, Sharma, Swati2 wrote:
> 
> On 10-Aug-23 10:53 PM, Modem, Bhanuprakash wrote:
>> Hi Swati,
>>
>> On Wed-09-08-2023 01:20 pm, Sharma, Swati2 wrote:
>>> On 29-Jun-23 8:18 PM, Bhanuprakash Modem wrote:
>>>> Add documentation for all kms tests which is used by IGT testplan
>>>> documentation.
>>>>
>>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>>> ---
>>>>   tests/i915/kms_dsc.c | 27 +++++++++++++++++++++++++++
>>>>   1 file changed, 27 insertions(+)
>>>>
>>>> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
>>>> index 0a3e29924..4cce7face 100644
>>>> --- a/tests/i915/kms_dsc.c
>>>> +++ b/tests/i915/kms_dsc.c
>>>> @@ -30,8 +30,35 @@
>>>>    *
>>>>    */
>>>> +/**
>>>> + * TEST: kms dsc
>>>> + * Category: Display
>>>> + * Description: Test to validate display stream compression
>>>> + */
>>>>   #include "kms_dsc_helper.h"
>>>> +/**
>>>> + * SUBTEST: dsc-%s
>>>> + * Description: Tests basic display stream compression 
>>>> functionality if supported
>>>> + *              by a connector by forcing %arg[1]
>>>
>>> forcing DSC on all connectors that support it with %arg[1]
>>> (remove this from below subtests description)
>>
>> This description is adopted from igt_describe(), Feel free to update 
>> the subtest description I can pick it from there.
> 
> But you haven't copied it as it is..right? Its the optimized version
> of igt_describe(). I simply meant.

No, I have copied as it is.
You can verify by comparing [1] & [2] from igt repo.

[1]: ./scripts/igt_doc.py --config=tests/kms_test_config.json 
--files=tests/i915/kms_dsc.c --per-test
[2]: ./build/tests/kms_dsc --describe

> "forcing DSC on all connectors that support it with %arg[1]" => is 
> redundant in descriptions you have written below for each subtest.

You mean to say to remove "DSC on all connectors that support it" from 
the description?

Then it'll become:

* SUBTEST: dsc-%s
* Description: Tests Display Stream Compression functionality if 
supported with %arg[1]
*
* arg[1]:
*
* @basic:                default parameters
* @with-bpc:             certain input BPC for that connector

...

- Bhanu

> We don't have to change igt_describe() for this. This should be handled 
> here.
> 
>>
>>>
>>>> + * Driver requirement: any
>>>
>>> This is intel specific test.
>>
>> Yes. As this kms testplan is designed for Intel, the allowed values are:
>>
>> i915: supports i915 driver only
>> xe: supports xe driver only
>> any: supports both i915 & xe
> 
> This ANY seems to correspond to drm_open_driver_master(DRIVER_ANY).
> IDK this is right. @mauro do you have any inputs here?
> Shouldn't "any" correspond to "any" driver. Even if this documentation
> is specific to intel but tests outside i915/ directory are used by other
> vendors too.
> 
>>
>>>
>>>> + * Functionality: dsc
>>>> + * Mega feature: VDSC
>>>> + * Run type: FULL
>>>> + * Test category: functionality test
>>>> + *
>>>> + * arg[1]:
>>>> + *
>>>> + * @basic:                DSC on all connectors that support it 
>>>> with default parameters
>>>> + * @with-bpc:             DSC on all connectors that support it 
>>>> with certain input BPC
>>>> + *                        for the connector
>>>> + * @with-bpc-formats:     DSC on all connectors that support it 
>>>> with certain input
>>>> + *                        BPC for the connector with diff formats
>>>> + * @with-formats:         DSC on all connectors that support it 
>>>> with default parameters
>>>> + *                        and creating fb with diff formats
>>>> + * @with-output-formats:  DSC and output format on all connectors 
>>>> that support it
>>>> + */
>>>> +
>>>
>>> dsc-with-output-formats-with-bpc subtest is added too recently. 
>>> please add.
>>
>> Will add in next rev.
>>
>> - Bhanu
>>
>>>
>>>>   IGT_TEST_DESCRIPTION("Test to validate display stream compression");
>>>>   enum dsc_test_type {