* [PATCH 4/7] net/mlx5: fix the return value of vport action
@ 2023-06-30 6:33 Bing Zhao
2023-06-30 9:21 ` [PATCH v2] " Bing Zhao
0 siblings, 1 reply; 3+ messages in thread
From: Bing Zhao @ 2023-06-30 6:33 UTC (permalink / raw)
To: matan, viacheslavo, orika, suanmingm, rasland; +Cc: dev, dsosnowski
The "rte_flow_error" should be set in case a invalid pointer access
to the message member.
Fixes: 1939eb6f660c ("net/mlx5: support flow port action with HWS")
Cc: dsosnowski@nvidia.com
Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_hw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index 6683bcbc7f..87584c1e94 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -7830,7 +7830,8 @@ flow_hw_configure(struct rte_eth_dev *dev,
if (is_proxy) {
ret = flow_hw_create_vport_actions(priv);
if (ret) {
- rte_errno = -ret;
+ rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL, "Failed to create vport actions.");
goto err;
}
ret = flow_hw_create_ctrl_tables(dev);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] net/mlx5: fix the return value of vport action
2023-06-30 6:33 [PATCH 4/7] net/mlx5: fix the return value of vport action Bing Zhao
@ 2023-06-30 9:21 ` Bing Zhao
2023-07-03 10:41 ` Raslan Darawsheh
0 siblings, 1 reply; 3+ messages in thread
From: Bing Zhao @ 2023-06-30 9:21 UTC (permalink / raw)
To: matan, viacheslavo, orika, suanmingm, rasland; +Cc: dev, dsosnowski, stable
The "rte_flow_error" should be set in case a invalid pointer access
to the message member.
Fixes: 1939eb6f660c ("net/mlx5: support flow port action with HWS")
Cc: dsosnowski@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
v2: add CC stable
---
drivers/net/mlx5/mlx5_flow_hw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index 6683bcbc7f..87584c1e94 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -7830,7 +7830,8 @@ flow_hw_configure(struct rte_eth_dev *dev,
if (is_proxy) {
ret = flow_hw_create_vport_actions(priv);
if (ret) {
- rte_errno = -ret;
+ rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+ NULL, "Failed to create vport actions.");
goto err;
}
ret = flow_hw_create_ctrl_tables(dev);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2] net/mlx5: fix the return value of vport action
2023-06-30 9:21 ` [PATCH v2] " Bing Zhao
@ 2023-07-03 10:41 ` Raslan Darawsheh
0 siblings, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2023-07-03 10:41 UTC (permalink / raw)
To: Bing Zhao, Matan Azrad, Slava Ovsiienko, Ori Kam, Suanming Mou
Cc: dev, Dariusz Sosnowski, stable
Hi,
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Friday, June 30, 2023 12:22 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>
> Cc: dev@dpdk.org; Dariusz Sosnowski <dsosnowski@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix the return value of vport action
>
> The "rte_flow_error" should be set in case a invalid pointer access to the
> message member.
>
> Fixes: 1939eb6f660c ("net/mlx5: support flow port action with HWS")
> Cc: dsosnowski@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
> v2: add CC stable
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-03 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-30 6:33 [PATCH 4/7] net/mlx5: fix the return value of vport action Bing Zhao
2023-06-30 9:21 ` [PATCH v2] " Bing Zhao
2023-07-03 10:41 ` Raslan Darawsheh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.