From: Nathan Chancellor <nathan@kernel.org>
To: broonie@kernel.org
Cc: lgirdwood@gmail.com, vkarpovi@opensource.cirrus.com,
rf@opensource.cirrus.com, ckeepax@opensource.cirrus.com,
alsa-devel@alsa-project.org, patches@lists.linux.dev,
stable@vger.kernel.org, Marcus Seyfarth <m.seyfarth@gmail.com>,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] ASoC: cs35l45: Select REGMAP_IRQ
Date: Mon, 03 Jul 2023 14:43:15 -0700 [thread overview]
Message-ID: <20230703-cs35l45-select-regmap_irq-v1-1-37d7e838b614@kernel.org> (raw)
After commit 6085f9e6dc19 ("ASoC: cs35l45: IRQ support"), without any
other configuration that selects CONFIG_REGMAP_IRQ, modpost errors out
with:
ERROR: modpost: "regmap_irq_get_virq" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined!
ERROR: modpost: "devm_regmap_add_irq_chip" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined!
Add the Kconfig selection to ensure these functions get built and
included, which resolves the build failure.
Cc: stable@vger.kernel.org
Fixes: 6085f9e6dc19 ("ASoC: cs35l45: IRQ support")
Reported-by: Marcus Seyfarth <m.seyfarth@gmail.com>
Closes: https://github.com/ClangBuiltLinux/linux/issues/1882
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 0cd107fa112f..76ddd3ffc496 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -715,6 +715,7 @@ config SND_SOC_CS35L41_I2C
config SND_SOC_CS35L45
tristate
+ select REGMAP_IRQ
config SND_SOC_CS35L45_SPI
tristate "Cirrus Logic CS35L45 CODEC (SPI)"
---
base-commit: 6f49256897083848ce9a59651f6b53fc80462397
change-id: 20230703-cs35l45-select-regmap_irq-0fd9d631763c
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
next reply other threads:[~2023-07-03 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 21:43 Nathan Chancellor [this message]
2023-07-05 16:05 ` [PATCH] ASoC: cs35l45: Select REGMAP_IRQ Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703-cs35l45-select-regmap_irq-v1-1-37d7e838b614@kernel.org \
--to=nathan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=m.seyfarth@gmail.com \
--cc=patches@lists.linux.dev \
--cc=rf@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
--cc=vkarpovi@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.