All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: cs35l45: Select REGMAP_IRQ
@ 2023-07-03 21:43 Nathan Chancellor
  2023-07-05 16:05 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2023-07-03 21:43 UTC (permalink / raw)
  To: broonie
  Cc: lgirdwood, vkarpovi, rf, ckeepax, alsa-devel, patches, stable,
	Marcus Seyfarth, Nathan Chancellor

After commit 6085f9e6dc19 ("ASoC: cs35l45: IRQ support"), without any
other configuration that selects CONFIG_REGMAP_IRQ, modpost errors out
with:

  ERROR: modpost: "regmap_irq_get_virq" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined!
  ERROR: modpost: "devm_regmap_add_irq_chip" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined!

Add the Kconfig selection to ensure these functions get built and
included, which resolves the build failure.

Cc: stable@vger.kernel.org
Fixes: 6085f9e6dc19 ("ASoC: cs35l45: IRQ support")
Reported-by: Marcus Seyfarth <m.seyfarth@gmail.com>
Closes: https://github.com/ClangBuiltLinux/linux/issues/1882
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 0cd107fa112f..76ddd3ffc496 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -715,6 +715,7 @@ config SND_SOC_CS35L41_I2C
 
 config SND_SOC_CS35L45
 	tristate
+	select REGMAP_IRQ
 
 config SND_SOC_CS35L45_SPI
 	tristate "Cirrus Logic CS35L45 CODEC (SPI)"

---
base-commit: 6f49256897083848ce9a59651f6b53fc80462397
change-id: 20230703-cs35l45-select-regmap_irq-0fd9d631763c

Best regards,
-- 
Nathan Chancellor <nathan@kernel.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: cs35l45: Select REGMAP_IRQ
  2023-07-03 21:43 [PATCH] ASoC: cs35l45: Select REGMAP_IRQ Nathan Chancellor
@ 2023-07-05 16:05 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-07-05 16:05 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: lgirdwood, vkarpovi, rf, ckeepax, alsa-devel, patches, stable,
	Marcus Seyfarth

On Mon, 03 Jul 2023 14:43:15 -0700, Nathan Chancellor wrote:
> After commit 6085f9e6dc19 ("ASoC: cs35l45: IRQ support"), without any
> other configuration that selects CONFIG_REGMAP_IRQ, modpost errors out
> with:
> 
>   ERROR: modpost: "regmap_irq_get_virq" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined!
>   ERROR: modpost: "devm_regmap_add_irq_chip" [sound/soc/codecs/snd-soc-cs35l45.ko] undefined!
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l45: Select REGMAP_IRQ
      commit: d9ba2975e98a4bec0a9f8d4be4c1de8883fccb71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-05 16:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 21:43 [PATCH] ASoC: cs35l45: Select REGMAP_IRQ Nathan Chancellor
2023-07-05 16:05 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.