* [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation
@ 2023-07-03 23:00 Randy Dunlap
2023-07-04 0:08 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2023-07-03 23:00 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Sebastian Reichel, Dmitry Torokhov, linux-input
Change the beginning "/**" in the file to "/*" since it is not a
kernel-doc comment. This prevents a kernel-doc warning:
drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* CPCAP Power Button Input Driver
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
---
drivers/input/misc/cpcap-pwrbutton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
--- a/drivers/input/misc/cpcap-pwrbutton.c
+++ b/drivers/input/misc/cpcap-pwrbutton.c
@@ -1,4 +1,4 @@
-/**
+/*
* CPCAP Power Button Input Driver
*
* Copyright (C) 2017 Sebastian Reichel <sre@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation
2023-07-03 23:00 [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation Randy Dunlap
@ 2023-07-04 0:08 ` Sebastian Reichel
2023-07-05 19:28 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2023-07-04 0:08 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Dmitry Torokhov, linux-input
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
Hi,
On Mon, Jul 03, 2023 at 04:00:05PM -0700, Randy Dunlap wrote:
> Change the beginning "/**" in the file to "/*" since it is not a
> kernel-doc comment. This prevents a kernel-doc warning:
>
> drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * CPCAP Power Button Input Driver
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> drivers/input/misc/cpcap-pwrbutton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
> --- a/drivers/input/misc/cpcap-pwrbutton.c
> +++ b/drivers/input/misc/cpcap-pwrbutton.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * CPCAP Power Button Input Driver
> *
> * Copyright (C) 2017 Sebastian Reichel <sre@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation
2023-07-04 0:08 ` Sebastian Reichel
@ 2023-07-05 19:28 ` Dmitry Torokhov
2023-07-05 21:28 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2023-07-05 19:28 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Randy Dunlap, linux-kernel, linux-input
On Tue, Jul 04, 2023 at 02:08:21AM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Jul 03, 2023 at 04:00:05PM -0700, Randy Dunlap wrote:
> > Change the beginning "/**" in the file to "/*" since it is not a
> > kernel-doc comment. This prevents a kernel-doc warning:
> >
> > drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > * CPCAP Power Button Input Driver
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: linux-input@vger.kernel.org
> > ---
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Applied, thank you.
BTW, the driver is missing SPDX annotation, Sebastian I wonder if you
could send a patch addressing this (given you are the author it is
better coming from you).
Thanks!
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation
2023-07-05 19:28 ` Dmitry Torokhov
@ 2023-07-05 21:28 ` Sebastian Reichel
2023-07-05 21:51 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2023-07-05 21:28 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Randy Dunlap, linux-kernel, linux-input
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
Hi,
On Wed, Jul 05, 2023 at 12:28:50PM -0700, Dmitry Torokhov wrote:
> On Tue, Jul 04, 2023 at 02:08:21AM +0200, Sebastian Reichel wrote:
> > Hi,
> >
> > On Mon, Jul 03, 2023 at 04:00:05PM -0700, Randy Dunlap wrote:
> > > Change the beginning "/**" in the file to "/*" since it is not a
> > > kernel-doc comment. This prevents a kernel-doc warning:
> > >
> > > drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > > * CPCAP Power Button Input Driver
> > >
> > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Cc: linux-input@vger.kernel.org
> > > ---
> >
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Applied, thank you.
>
> BTW, the driver is missing SPDX annotation, Sebastian I wonder if you
> could send a patch addressing this (given you are the author it is
> better coming from you).
DONE: https://lore.kernel.org/all/20230705212231.631525-1-sre@kernel.org/
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation
2023-07-05 21:28 ` Sebastian Reichel
@ 2023-07-05 21:51 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2023-07-05 21:51 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Randy Dunlap, linux-kernel, linux-input
On Wed, Jul 05, 2023 at 11:28:45PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jul 05, 2023 at 12:28:50PM -0700, Dmitry Torokhov wrote:
> > On Tue, Jul 04, 2023 at 02:08:21AM +0200, Sebastian Reichel wrote:
> > > Hi,
> > >
> > > On Mon, Jul 03, 2023 at 04:00:05PM -0700, Randy Dunlap wrote:
> > > > Change the beginning "/**" in the file to "/*" since it is not a
> > > > kernel-doc comment. This prevents a kernel-doc warning:
> > > >
> > > > drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > > > * CPCAP Power Button Input Driver
> > > >
> > > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > Cc: linux-input@vger.kernel.org
> > > > ---
> > >
> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> >
> > Applied, thank you.
> >
> > BTW, the driver is missing SPDX annotation, Sebastian I wonder if you
> > could send a patch addressing this (given you are the author it is
> > better coming from you).
>
> DONE: https://lore.kernel.org/all/20230705212231.631525-1-sre@kernel.org/
Thank you, much appreciated.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-05 21:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-03 23:00 [PATCH RESEND] input: cpcap-pwrbutton: remove initial kernel-doc notation Randy Dunlap
2023-07-04 0:08 ` Sebastian Reichel
2023-07-05 19:28 ` Dmitry Torokhov
2023-07-05 21:28 ` Sebastian Reichel
2023-07-05 21:51 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.