* [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
@ 2023-07-13 1:42 ` Wang Ming
0 siblings, 0 replies; 4+ messages in thread
From: Wang Ming @ 2023-07-13 1:42 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Shannon Nelson, Jeff Kirsher,
intel-wired-lan, netdev, linux-kernel
Cc: opensource.kernel, Wang Ming
The debugfs_create_dir() function returns error pointers.
It never returns NULL. Most incorrect error checks were fixed,
but the one in i40e_dbg_init() was forgotten.
Fix the remaining error check.
Signed-off-by: Wang Ming <machel@vivo.com>
Fixes: 02e9c290814c ("i40e: debugfs interface")
---
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 9954493cd448..62497f5565c5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -1839,7 +1839,7 @@ void i40e_dbg_pf_exit(struct i40e_pf *pf)
void i40e_dbg_init(void)
{
i40e_dbg_root = debugfs_create_dir(i40e_driver_name, NULL);
- if (!i40e_dbg_root)
+ if (IS_ERR(i40e_dbg_root))
pr_info("init of debugfs failed\n");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
@ 2023-07-13 1:42 ` Wang Ming
0 siblings, 0 replies; 4+ messages in thread
From: Wang Ming @ 2023-07-13 1:42 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Shannon Nelson, Jeff Kirsher,
intel-wired-lan, netdev, linux-kernel
Cc: Wang Ming, opensource.kernel
The debugfs_create_dir() function returns error pointers.
It never returns NULL. Most incorrect error checks were fixed,
but the one in i40e_dbg_init() was forgotten.
Fix the remaining error check.
Signed-off-by: Wang Ming <machel@vivo.com>
Fixes: 02e9c290814c ("i40e: debugfs interface")
---
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 9954493cd448..62497f5565c5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -1839,7 +1839,7 @@ void i40e_dbg_pf_exit(struct i40e_pf *pf)
void i40e_dbg_init(void)
{
i40e_dbg_root = debugfs_create_dir(i40e_driver_name, NULL);
- if (!i40e_dbg_root)
+ if (IS_ERR(i40e_dbg_root))
pr_info("init of debugfs failed\n");
}
--
2.25.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
2023-07-13 1:42 ` [Intel-wired-lan] " Wang Ming
@ 2023-07-18 5:26 ` Pucha, HimasekharX Reddy
-1 siblings, 0 replies; 4+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-07-18 5:26 UTC (permalink / raw)
To: Wang Ming, Brandeburg, Jesse, Nguyen, Anthony L, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Shannon Nelson,
Jeff Kirsher, intel-wired-lan, netdev, linux-kernel
Cc: opensource.kernel
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Wang Ming
> Sent: Thursday, July 13, 2023 7:13 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Shannon Nelson <shannon.nelson@intel.com>; Jeff Kirsher <jeffrey.t.kirsher@intel.com>; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Wang Ming <machel@vivo.com>; opensource.kernel@vivo.com
> Subject: [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
>
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. Most incorrect error checks were fixed, but the one in i40e_dbg_init() was forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
>
> Fixes: 02e9c290814c ("i40e: debugfs interface")
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
@ 2023-07-18 5:26 ` Pucha, HimasekharX Reddy
0 siblings, 0 replies; 4+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-07-18 5:26 UTC (permalink / raw)
To: Wang Ming, Brandeburg, Jesse, Nguyen, Anthony L, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Shannon Nelson,
Jeff Kirsher, intel-wired-lan, netdev, linux-kernel
Cc: opensource.kernel
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Wang Ming
> Sent: Thursday, July 13, 2023 7:13 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Shannon Nelson <shannon.nelson@intel.com>; Jeff Kirsher <jeffrey.t.kirsher@intel.com>; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Wang Ming <machel@vivo.com>; opensource.kernel@vivo.com
> Subject: [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
>
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. Most incorrect error checks were fixed, but the one in i40e_dbg_init() was forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
>
> Fixes: 02e9c290814c ("i40e: debugfs interface")
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-18 5:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 1:42 [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir() Wang Ming
2023-07-13 1:42 ` [Intel-wired-lan] " Wang Ming
2023-07-18 5:26 ` Pucha, HimasekharX Reddy
2023-07-18 5:26 ` Pucha, HimasekharX Reddy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.