* [PATCH] mdadm: add util-linux-blockdev ptest dependency
@ 2023-07-21 10:58 ovidiu.panait
2023-07-23 12:08 ` [OE-core] " Alexander Kanavin
0 siblings, 1 reply; 3+ messages in thread
From: ovidiu.panait @ 2023-07-21 10:58 UTC (permalink / raw)
To: openembedded-core
From: Ovidiu Panait <ovidiu.panait@windriver.com>
07revert-inplace test logs contain the following:
func.sh: line 335: /sbin/blockdev: No such file or directory
Add the missing util-linux-blockdev dependency.
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
meta/recipes-extended/mdadm/mdadm_4.2.bb | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/mdadm/mdadm_4.2.bb b/meta/recipes-extended/mdadm/mdadm_4.2.bb
index 50d9548747..fa50325f1f 100644
--- a/meta/recipes-extended/mdadm/mdadm_4.2.bb
+++ b/meta/recipes-extended/mdadm/mdadm_4.2.bb
@@ -107,7 +107,14 @@ do_install_ptest() {
}
RDEPENDS:${PN} += "bash"
-RDEPENDS:${PN}-ptest += "bash e2fsprogs-mke2fs util-linux-lsblk util-linux-losetup strace"
+RDEPENDS:${PN}-ptest += " \
+ bash \
+ e2fsprogs-mke2fs \
+ util-linux-lsblk \
+ util-linux-losetup \
+ util-linux-blockdev \
+ strace \
+"
RRECOMMENDS:${PN}-ptest += " \
coreutils \
kernel-module-loop \
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] mdadm: add util-linux-blockdev ptest dependency
2023-07-21 10:58 [PATCH] mdadm: add util-linux-blockdev ptest dependency ovidiu.panait
@ 2023-07-23 12:08 ` Alexander Kanavin
2023-07-23 14:39 ` Ovidiu Panait
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kanavin @ 2023-07-23 12:08 UTC (permalink / raw)
To: ovidiu.panait; +Cc: openembedded-core
Can you please check why the test doesn't fail with the dependency absent?
Alex
On Fri, 21 Jul 2023 at 12:58, Ovidiu Panait via lists.openembedded.org
<ovidiu.panait=windriver.com@lists.openembedded.org> wrote:
>
> From: Ovidiu Panait <ovidiu.panait@windriver.com>
>
> 07revert-inplace test logs contain the following:
> func.sh: line 335: /sbin/blockdev: No such file or directory
>
> Add the missing util-linux-blockdev dependency.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
> meta/recipes-extended/mdadm/mdadm_4.2.bb | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/mdadm/mdadm_4.2.bb b/meta/recipes-extended/mdadm/mdadm_4.2.bb
> index 50d9548747..fa50325f1f 100644
> --- a/meta/recipes-extended/mdadm/mdadm_4.2.bb
> +++ b/meta/recipes-extended/mdadm/mdadm_4.2.bb
> @@ -107,7 +107,14 @@ do_install_ptest() {
> }
>
> RDEPENDS:${PN} += "bash"
> -RDEPENDS:${PN}-ptest += "bash e2fsprogs-mke2fs util-linux-lsblk util-linux-losetup strace"
> +RDEPENDS:${PN}-ptest += " \
> + bash \
> + e2fsprogs-mke2fs \
> + util-linux-lsblk \
> + util-linux-losetup \
> + util-linux-blockdev \
> + strace \
> +"
> RRECOMMENDS:${PN}-ptest += " \
> coreutils \
> kernel-module-loop \
> --
> 2.39.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#184682): https://lists.openembedded.org/g/openembedded-core/message/184682
> Mute This Topic: https://lists.openembedded.org/mt/100274537/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] mdadm: add util-linux-blockdev ptest dependency
2023-07-23 12:08 ` [OE-core] " Alexander Kanavin
@ 2023-07-23 14:39 ` Ovidiu Panait
0 siblings, 0 replies; 3+ messages in thread
From: Ovidiu Panait @ 2023-07-23 14:39 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: openembedded-core
On 7/23/23 15:08, Alexander Kanavin wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> Can you please check why the test doesn't fail with the dependency absent?
The testcase fails intermittently:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15159
But it is not clear if it's related to the missing blockdev dependency,
as I was unable to reproduce the failure manually and we can't get the
logs from the autobuilder.
blockdev not being available doesn't make the testcase fail directly,
but it affects some calculations, so I think it should be added as a
dependency:
...
+++ /sbin/blockdev --getsize /dev/md0
/usr/lib/mdadm/ptest/tests/func.sh: line 334: /sbin/blockdev: No such
file or directory
++ '[' -eq 0 ']'
/usr/lib/mdadm/ptest/tests/func.sh: line 334: [: -eq: unary operator
expected
+++ /sbin/blockdev --getsize /dev/md0
/usr/lib/mdadm/ptest/tests/func.sh: line 335: /sbin/blockdev: No such
file or directory
++ _sz=
++ '[' 119808 -lt -o 95846 -gt ']'
/usr/lib/mdadm/ptest/tests/func.sh: line 336: [: -o: integer expression
expected
Ovidiu
> Alex
>
> On Fri, 21 Jul 2023 at 12:58, Ovidiu Panait via lists.openembedded.org
> <ovidiu.panait=windriver.com@lists.openembedded.org> wrote:
>> From: Ovidiu Panait <ovidiu.panait@windriver.com>
>>
>> 07revert-inplace test logs contain the following:
>> func.sh: line 335: /sbin/blockdev: No such file or directory
>>
>> Add the missing util-linux-blockdev dependency.
>>
>> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
>> ---
>> meta/recipes-extended/mdadm/mdadm_4.2.bb | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-extended/mdadm/mdadm_4.2.bb b/meta/recipes-extended/mdadm/mdadm_4.2.bb
>> index 50d9548747..fa50325f1f 100644
>> --- a/meta/recipes-extended/mdadm/mdadm_4.2.bb
>> +++ b/meta/recipes-extended/mdadm/mdadm_4.2.bb
>> @@ -107,7 +107,14 @@ do_install_ptest() {
>> }
>>
>> RDEPENDS:${PN} += "bash"
>> -RDEPENDS:${PN}-ptest += "bash e2fsprogs-mke2fs util-linux-lsblk util-linux-losetup strace"
>> +RDEPENDS:${PN}-ptest += " \
>> + bash \
>> + e2fsprogs-mke2fs \
>> + util-linux-lsblk \
>> + util-linux-losetup \
>> + util-linux-blockdev \
>> + strace \
>> +"
>> RRECOMMENDS:${PN}-ptest += " \
>> coreutils \
>> kernel-module-loop \
>> --
>> 2.39.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#184682): https://lists.openembedded.org/g/openembedded-core/message/184682
>> Mute This Topic: https://lists.openembedded.org/mt/100274537/1686489
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-23 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-21 10:58 [PATCH] mdadm: add util-linux-blockdev ptest dependency ovidiu.panait
2023-07-23 12:08 ` [OE-core] " Alexander Kanavin
2023-07-23 14:39 ` Ovidiu Panait
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.