* [amir73il:sb_write_barrier 19/30] include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here
@ 2023-07-21 3:18 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-07-21 3:18 UTC (permalink / raw)
To: Amir Goldstein; +Cc: oe-kbuild-all
tree: https://github.com/amir73il/linux sb_write_barrier
head: bf9a41c874c7b090a3eb10204ac607fde16fdfb3
commit: 96f25a6844cc4a544a7003caee9e966c6e7f0195 [19/30] fsnotify: introduce pre-content permission event
config: x86_64-randconfig-r011-20230720 (https://download.01.org/0day-ci/archive/20230721/202307211105.zGLTcrGx-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230721/202307211105.zGLTcrGx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307211105.zGLTcrGx-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from fs/nfs/unlink.c:12:
In file included from include/linux/sunrpc/sched.h:19:
include/linux/sunrpc/xdr.h:778:10: warning: result of comparison of constant 4611686018427387903 with expression of type '__u32' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare]
if (len > SIZE_MAX / sizeof(*p))
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
In file included from fs/nfs/unlink.c:18:
>> include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here [-Wuninitialized]
fsnotify_mask |= FS_PRE_MODIFY;
^~~~~~~~~~~~~
include/linux/fsnotify.h:110:21: note: initialize the variable 'fsnotify_mask' to silence this warning
__u32 fsnotify_mask;
^
= 0
2 warnings generated.
vim +/fsnotify_mask +126 include/linux/fsnotify.h
103
104 /*
105 * fsnotify_file_perm - permission hook before file access/modify
106 */
107 static inline int fsnotify_file_perm(struct file *file, int mask)
108 {
109 struct inode *inode = file_inode(file);
110 __u32 fsnotify_mask;
111
112 /*
113 * Content of file may be written on pre-content events, so sb freeze
114 * protection must not be held.
115 */
116 lockdep_assert_once(file_write_not_started(file));
117
118 /*
119 * Pre-content events are onlt reported for regular files and dirs.
120 */
121 if (mask & MAY_READ) {
122 fsnotify_mask = FS_ACCESS_PERM;
123 if (S_ISDIR(inode->i_mode) || S_ISREG(inode->i_mode))
124 fsnotify_mask |= FS_PRE_ACCESS;
125 } else if (mask & MAY_WRITE && S_ISREG(inode->i_mode)) {
> 126 fsnotify_mask |= FS_PRE_MODIFY;
127 } else {
128 return 0;
129 }
130
131 return fsnotify_file(file, fsnotify_mask);
132 }
133
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [amir73il:sb_write_barrier 19/30] include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here
@ 2023-08-11 1:57 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-08-11 1:57 UTC (permalink / raw)
To: Amir Goldstein; +Cc: oe-kbuild-all
tree: https://github.com/amir73il/linux sb_write_barrier
head: 6244858442fbea61e470f07868adeec37a538b4a
commit: 76c0334488361dea127211945f8a553428d7509c [19/30] fsnotify: introduce pre-content permission event
config: s390-randconfig-r032-20230811 (https://download.01.org/0day-ci/archive/20230811/202308110924.wECNXk9c-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230811/202308110924.wECNXk9c-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308110924.wECNXk9c-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from fs/libfs.c:23:
>> include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here [-Wuninitialized]
126 | fsnotify_mask |= FS_PRE_MODIFY;
| ^~~~~~~~~~~~~
include/linux/fsnotify.h:110:21: note: initialize the variable 'fsnotify_mask' to silence this warning
110 | __u32 fsnotify_mask;
| ^
| = 0
1 warning generated.
--
In file included from fs/attr.c:15:
>> include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here [-Wuninitialized]
126 | fsnotify_mask |= FS_PRE_MODIFY;
| ^~~~~~~~~~~~~
include/linux/fsnotify.h:110:21: note: initialize the variable 'fsnotify_mask' to silence this warning
110 | __u32 fsnotify_mask;
| ^
| = 0
In file included from fs/attr.c:20:
In file included from include/linux/ima.h:13:
In file included from include/linux/kexec.h:19:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
| ^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
| ^
In file included from fs/attr.c:20:
In file included from include/linux/ima.h:13:
In file included from include/linux/kexec.h:19:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
| ^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
| ^
In file included from fs/attr.c:20:
In file included from include/linux/ima.h:13:
In file included from include/linux/kexec.h:19:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
692 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
700 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
708 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
717 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
726 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
735 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
13 warnings generated.
--
In file included from fs/inode.c:15:
In file included from include/linux/memblock.h:13:
In file included from arch/s390/include/asm/dma.h:5:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
| ^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
| ^
In file included from fs/inode.c:15:
In file included from include/linux/memblock.h:13:
In file included from arch/s390/include/asm/dma.h:5:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
| ^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
| ^
In file included from fs/inode.c:15:
In file included from include/linux/memblock.h:13:
In file included from arch/s390/include/asm/dma.h:5:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
692 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
700 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
708 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
717 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
726 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
735 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
In file included from fs/inode.c:16:
>> include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here [-Wuninitialized]
126 | fsnotify_mask |= FS_PRE_MODIFY;
| ^~~~~~~~~~~~~
include/linux/fsnotify.h:110:21: note: initialize the variable 'fsnotify_mask' to silence this warning
110 | __u32 fsnotify_mask;
| ^
| = 0
13 warnings generated.
--
In file included from kernel/trace/trace.c:48:
>> include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here [-Wuninitialized]
126 | fsnotify_mask |= FS_PRE_MODIFY;
| ^~~~~~~~~~~~~
include/linux/fsnotify.h:110:21: note: initialize the variable 'fsnotify_mask' to silence this warning
110 | __u32 fsnotify_mask;
| ^
| = 0
In file included from kernel/trace/trace.c:54:
In file included from kernel/trace/trace.h:9:
In file included from include/linux/clocksource.h:22:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
| ^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
| ^
In file included from kernel/trace/trace.c:54:
In file included from kernel/trace/trace.h:9:
In file included from include/linux/clocksource.h:22:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
| ^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
| ^
In file included from kernel/trace/trace.c:54:
In file included from kernel/trace/trace.h:9:
In file included from include/linux/clocksource.h:22:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
692 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
700 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
708 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
717 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
726 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
735 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
kernel/trace/trace.c:2116:19: warning: unused function 'run_tracer_selftest' [-Wunused-function]
2116 | static inline int run_tracer_selftest(struct tracer *type)
| ^
14 warnings generated.
vim +/fsnotify_mask +126 include/linux/fsnotify.h
103
104 /*
105 * fsnotify_file_perm - permission hook before file access/modify
106 */
107 static inline int fsnotify_file_perm(struct file *file, int mask)
108 {
109 struct inode *inode = file_inode(file);
110 __u32 fsnotify_mask;
111
112 /*
113 * Content of file may be written on pre-content events, so sb freeze
114 * protection must not be held.
115 */
116 lockdep_assert_once(file_write_not_started(file));
117
118 /*
119 * Pre-content events are onlt reported for regular files and dirs.
120 */
121 if (mask & MAY_READ) {
122 fsnotify_mask = FS_ACCESS_PERM;
123 if (S_ISDIR(inode->i_mode) || S_ISREG(inode->i_mode))
124 fsnotify_mask |= FS_PRE_ACCESS;
125 } else if (mask & MAY_WRITE && S_ISREG(inode->i_mode)) {
> 126 fsnotify_mask |= FS_PRE_MODIFY;
127 } else {
128 return 0;
129 }
130
131 return fsnotify_file(file, fsnotify_mask);
132 }
133
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-11 1:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-21 3:18 [amir73il:sb_write_barrier 19/30] include/linux/fsnotify.h:126:3: warning: variable 'fsnotify_mask' is uninitialized when used here kernel test robot
2023-08-11 1:57 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.