From: kernel test robot <lkp@intel.com> To: Marco Felsch <m.felsch@pengutronix.de>, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com Cc: oe-kbuild-all@lists.linux.dev, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 2/2] net: stmmac: add support for phy-supply Date: Sat, 22 Jul 2023 04:31:17 +0800 [thread overview] Message-ID: <202307220459.2gaQtSqH-lkp@intel.com> (raw) In-Reply-To: <20230720072304.3358701-2-m.felsch@pengutronix.de> Hi Marco, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Marco-Felsch/net-stmmac-add-support-for-phy-supply/20230720-152642 base: net-next/main patch link: https://lore.kernel.org/r/20230720072304.3358701-2-m.felsch%40pengutronix.de patch subject: [PATCH net-next v3 2/2] net: stmmac: add support for phy-supply config: x86_64-kexec (https://download.01.org/0day-ci/archive/20230722/202307220459.2gaQtSqH-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230722/202307220459.2gaQtSqH-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307220459.2gaQtSqH-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_suspend': >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7706:32: error: 'struct plat_stmmacenet_data' has no member named 'use_phy_wol' 7706 | if (!priv->plat->use_phy_wol) | ^~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_resume': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7790:32: error: 'struct plat_stmmacenet_data' has no member named 'use_phy_wol' 7790 | if (!priv->plat->use_phy_wol) | ^~ vim +7706 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 7651 7652 /** 7653 * stmmac_suspend - suspend callback 7654 * @dev: device pointer 7655 * Description: this is the function to suspend the device and it is called 7656 * by the platform driver to stop the network queue, release the resources, 7657 * program the PMT register (for WoL), clean and release driver resources. 7658 */ 7659 int stmmac_suspend(struct device *dev) 7660 { 7661 struct net_device *ndev = dev_get_drvdata(dev); 7662 struct stmmac_priv *priv = netdev_priv(ndev); 7663 u32 chan; 7664 7665 if (!ndev || !netif_running(ndev)) 7666 return 0; 7667 7668 mutex_lock(&priv->lock); 7669 7670 netif_device_detach(ndev); 7671 7672 stmmac_disable_all_queues(priv); 7673 7674 for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++) 7675 hrtimer_cancel(&priv->dma_conf.tx_queue[chan].txtimer); 7676 7677 if (priv->eee_enabled) { 7678 priv->tx_path_in_lpi_mode = false; 7679 del_timer_sync(&priv->eee_ctrl_timer); 7680 } 7681 7682 /* Stop TX/RX DMA */ 7683 stmmac_stop_all_dma(priv); 7684 7685 if (priv->plat->serdes_powerdown) 7686 priv->plat->serdes_powerdown(ndev, priv->plat->bsp_priv); 7687 7688 /* Enable Power down mode by programming the PMT regs */ 7689 if (device_may_wakeup(priv->device) && priv->plat->pmt) { 7690 stmmac_pmt(priv, priv->hw, priv->wolopts); 7691 priv->irq_wake = 1; 7692 } else { 7693 stmmac_mac_set(priv, priv->ioaddr, false); 7694 pinctrl_pm_select_sleep_state(priv->device); 7695 } 7696 7697 mutex_unlock(&priv->lock); 7698 7699 rtnl_lock(); 7700 if (device_may_wakeup(priv->device) && priv->plat->pmt) { 7701 phylink_suspend(priv->phylink, true); 7702 } else { 7703 if (device_may_wakeup(priv->device)) 7704 phylink_speed_down(priv->phylink, false); 7705 phylink_suspend(priv->phylink, false); > 7706 if (!priv->plat->use_phy_wol) 7707 stmmac_phy_power_off(priv); 7708 } 7709 rtnl_unlock(); 7710 7711 if (priv->dma_cap.fpesel) { 7712 /* Disable FPE */ 7713 stmmac_fpe_configure(priv, priv->ioaddr, 7714 priv->plat->tx_queues_to_use, 7715 priv->plat->rx_queues_to_use, false); 7716 7717 stmmac_fpe_handshake(priv, false); 7718 stmmac_fpe_stop_wq(priv); 7719 } 7720 7721 priv->speed = SPEED_UNKNOWN; 7722 return 0; 7723 } 7724 EXPORT_SYMBOL_GPL(stmmac_suspend); 7725 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: Marco Felsch <m.felsch@pengutronix.de>, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com Cc: oe-kbuild-all@lists.linux.dev, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 2/2] net: stmmac: add support for phy-supply Date: Sat, 22 Jul 2023 04:31:17 +0800 [thread overview] Message-ID: <202307220459.2gaQtSqH-lkp@intel.com> (raw) In-Reply-To: <20230720072304.3358701-2-m.felsch@pengutronix.de> Hi Marco, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Marco-Felsch/net-stmmac-add-support-for-phy-supply/20230720-152642 base: net-next/main patch link: https://lore.kernel.org/r/20230720072304.3358701-2-m.felsch%40pengutronix.de patch subject: [PATCH net-next v3 2/2] net: stmmac: add support for phy-supply config: x86_64-kexec (https://download.01.org/0day-ci/archive/20230722/202307220459.2gaQtSqH-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230722/202307220459.2gaQtSqH-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202307220459.2gaQtSqH-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_suspend': >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7706:32: error: 'struct plat_stmmacenet_data' has no member named 'use_phy_wol' 7706 | if (!priv->plat->use_phy_wol) | ^~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_resume': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7790:32: error: 'struct plat_stmmacenet_data' has no member named 'use_phy_wol' 7790 | if (!priv->plat->use_phy_wol) | ^~ vim +7706 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 7651 7652 /** 7653 * stmmac_suspend - suspend callback 7654 * @dev: device pointer 7655 * Description: this is the function to suspend the device and it is called 7656 * by the platform driver to stop the network queue, release the resources, 7657 * program the PMT register (for WoL), clean and release driver resources. 7658 */ 7659 int stmmac_suspend(struct device *dev) 7660 { 7661 struct net_device *ndev = dev_get_drvdata(dev); 7662 struct stmmac_priv *priv = netdev_priv(ndev); 7663 u32 chan; 7664 7665 if (!ndev || !netif_running(ndev)) 7666 return 0; 7667 7668 mutex_lock(&priv->lock); 7669 7670 netif_device_detach(ndev); 7671 7672 stmmac_disable_all_queues(priv); 7673 7674 for (chan = 0; chan < priv->plat->tx_queues_to_use; chan++) 7675 hrtimer_cancel(&priv->dma_conf.tx_queue[chan].txtimer); 7676 7677 if (priv->eee_enabled) { 7678 priv->tx_path_in_lpi_mode = false; 7679 del_timer_sync(&priv->eee_ctrl_timer); 7680 } 7681 7682 /* Stop TX/RX DMA */ 7683 stmmac_stop_all_dma(priv); 7684 7685 if (priv->plat->serdes_powerdown) 7686 priv->plat->serdes_powerdown(ndev, priv->plat->bsp_priv); 7687 7688 /* Enable Power down mode by programming the PMT regs */ 7689 if (device_may_wakeup(priv->device) && priv->plat->pmt) { 7690 stmmac_pmt(priv, priv->hw, priv->wolopts); 7691 priv->irq_wake = 1; 7692 } else { 7693 stmmac_mac_set(priv, priv->ioaddr, false); 7694 pinctrl_pm_select_sleep_state(priv->device); 7695 } 7696 7697 mutex_unlock(&priv->lock); 7698 7699 rtnl_lock(); 7700 if (device_may_wakeup(priv->device) && priv->plat->pmt) { 7701 phylink_suspend(priv->phylink, true); 7702 } else { 7703 if (device_may_wakeup(priv->device)) 7704 phylink_speed_down(priv->phylink, false); 7705 phylink_suspend(priv->phylink, false); > 7706 if (!priv->plat->use_phy_wol) 7707 stmmac_phy_power_off(priv); 7708 } 7709 rtnl_unlock(); 7710 7711 if (priv->dma_cap.fpesel) { 7712 /* Disable FPE */ 7713 stmmac_fpe_configure(priv, priv->ioaddr, 7714 priv->plat->tx_queues_to_use, 7715 priv->plat->rx_queues_to_use, false); 7716 7717 stmmac_fpe_handshake(priv, false); 7718 stmmac_fpe_stop_wq(priv); 7719 } 7720 7721 priv->speed = SPEED_UNKNOWN; 7722 return 0; 7723 } 7724 EXPORT_SYMBOL_GPL(stmmac_suspend); 7725 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-21 20:31 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-20 7:23 [PATCH net-next v3 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Marco Felsch 2023-07-20 7:23 ` Marco Felsch 2023-07-20 7:23 ` [PATCH net-next v3 2/2] net: stmmac: add support for phy-supply Marco Felsch 2023-07-20 7:23 ` Marco Felsch 2023-07-21 3:11 ` Jakub Kicinski 2023-07-21 3:11 ` Jakub Kicinski 2023-07-21 9:38 ` Marco Felsch 2023-07-21 9:38 ` Marco Felsch 2023-07-21 20:31 ` kernel test robot [this message] 2023-07-21 20:31 ` kernel test robot 2023-07-31 8:54 ` Marco Felsch 2023-07-31 8:54 ` Marco Felsch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202307220459.2gaQtSqH-lkp@intel.com \ --to=lkp@intel.com \ --cc=alexandre.torgue@foss.st.com \ --cc=conor+dt@kernel.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=joabreu@synopsys.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=m.felsch@pengutronix.de \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=oe-kbuild-all@lists.linux.dev \ --cc=pabeni@redhat.com \ --cc=peppe.cavallaro@st.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.