* [PATCH] kstrtox: Remove strtobool()
@ 2023-07-20 20:40 Christophe JAILLET
2023-07-21 10:22 ` Andy Shevchenko
2023-07-24 18:05 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Christophe JAILLET @ 2023-07-20 20:40 UTC (permalink / raw)
To: akpm, andriy.shevchenko; +Cc: linux-kernel, kernel-janitors, Christophe JAILLET
The conversion from strtobool() to kstrtobool() is completed.
So strtobool() can now be removed.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Unless I missed something, the last strtobool() calls have been removed
from -next just 1 or 2 days ago.
So it is maybe good to wait a few days or weeks to apply this patch in
order not to break something somewhere.
For now, see if build-bots agree with me :)
get_maintainer.pl is of now help here, so adding just Andrew Morton, and
Andy Shevchenko (who splitted out this file from kernel.h)
---
include/linux/kstrtox.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/kstrtox.h b/include/linux/kstrtox.h
index 529974e22ea7..7fcf29a4e0de 100644
--- a/include/linux/kstrtox.h
+++ b/include/linux/kstrtox.h
@@ -147,9 +147,4 @@ extern long simple_strtol(const char *,char **,unsigned int);
extern unsigned long long simple_strtoull(const char *,char **,unsigned int);
extern long long simple_strtoll(const char *,char **,unsigned int);
-static inline int strtobool(const char *s, bool *res)
-{
- return kstrtobool(s, res);
-}
-
#endif /* _LINUX_KSTRTOX_H */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kstrtox: Remove strtobool()
2023-07-20 20:40 [PATCH] kstrtox: Remove strtobool() Christophe JAILLET
@ 2023-07-21 10:22 ` Andy Shevchenko
2023-07-24 18:05 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-07-21 10:22 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: akpm, linux-kernel, kernel-janitors
On Thu, Jul 20, 2023 at 10:40:35PM +0200, Christophe JAILLET wrote:
> The conversion from strtobool() to kstrtobool() is completed.
> So strtobool() can now be removed.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Unless I missed something, the last strtobool() calls have been removed
> from -next just 1 or 2 days ago.
>
> So it is maybe good to wait a few days or weeks to apply this patch in
> order not to break something somewhere.
>
> For now, see if build-bots agree with me :)
> get_maintainer.pl is of now help here, so adding just Andrew Morton, and
> Andy Shevchenko (who splitted out this file from kernel.h)
Kees Cook from recent times.
As this is about Linux Next, you need to talk to Torvalds to apply this before
v6.6-rc1.
Code wise it's good, feel free to add:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kstrtox: Remove strtobool()
2023-07-20 20:40 [PATCH] kstrtox: Remove strtobool() Christophe JAILLET
2023-07-21 10:22 ` Andy Shevchenko
@ 2023-07-24 18:05 ` Andrew Morton
2023-07-24 19:16 ` Christophe JAILLET
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2023-07-24 18:05 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: andriy.shevchenko, linux-kernel, kernel-janitors
On Thu, 20 Jul 2023 22:40:35 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> The conversion from strtobool() to kstrtobool() is completed.
> So strtobool() can now be removed.
I still have some strtobool()s in mm.git, so I can't apply this.
Probably nobody can apply this to their tree at this stage. A resend
after 6.6-rc1 would be the simplest approach.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kstrtox: Remove strtobool()
2023-07-24 18:05 ` Andrew Morton
@ 2023-07-24 19:16 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2023-07-24 19:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: andriy.shevchenko, linux-kernel, kernel-janitors
Le 24/07/2023 à 20:05, Andrew Morton a écrit :
> On Thu, 20 Jul 2023 22:40:35 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
>> The conversion from strtobool() to kstrtobool() is completed.
>> So strtobool() can now be removed.
>
> I still have some strtobool()s in mm.git, so I can't apply this.
>
> Probably nobody can apply this to their tree at this stage. A resend
> after 6.6-rc1 would be the simplest approach.
>
>
Let's do it then.
Note that in -next there is still some strtobool but only in tools/.
I thinks it is ok to leave it as-is.
git grep -w strtobool
tools/include/linux/string.h:int strtobool(const char *s, bool *res);
tools/lib/string.c: * More specifically, the first copied function was
strtobool, which
tools/lib/string.c: * d0f1fed29e6e ("Add a strtobool function matching
semantics of existing in kernel equivalents")
tools/lib/string.c: * strtobool - convert common user inputs into
boolean values
tools/lib/string.c:int strtobool(const char *s, bool *res)
tools/perf/util/bpf-loader.c: err = strtobool(value, &bool_value);
CJ
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-24 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-20 20:40 [PATCH] kstrtox: Remove strtobool() Christophe JAILLET
2023-07-21 10:22 ` Andy Shevchenko
2023-07-24 18:05 ` Andrew Morton
2023-07-24 19:16 ` Christophe JAILLET
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.