All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/mpg123: force arm mode instead of Thumb mode
@ 2023-07-28 18:08 Bernd Kuhls
  2023-07-28 19:25 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2023-07-28 18:08 UTC (permalink / raw)
  To: buildroot

Fix the following build failure:
Error: selected processor does not support `smull r3,ip,r2,r10' in Thumb mode

Fixes:
http://autobuild.buildroot.net/results/848/8484fc6be618f3edbf39a13928ab9a4b7b442235/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/mpg123/mpg123.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/mpg123/mpg123.mk b/package/mpg123/mpg123.mk
index 64c8e0d8e5..5ec5590267 100644
--- a/package/mpg123/mpg123.mk
+++ b/package/mpg123/mpg123.mk
@@ -13,6 +13,13 @@ MPG123_LICENSE_FILES = COPYING
 MPG123_CPE_ID_VENDOR = mpg123
 MPG123_DEPENDENCIES = host-pkgconf
 
+# mpg123 has some assembly function that is not present in Thumb mode:
+# Error: selected processor does not support `smull r3,ip,r2,r10' in Thumb mode
+# so, we desactivate Thumb mode
+ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
+MPG123_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -marm"
+endif
+
 MPG123_CPU = $(if $(BR2_SOFT_FLOAT),generic_nofpu,generic_fpu)
 
 ifeq ($(BR2_aarch64),y)
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/mpg123: force arm mode instead of Thumb mode
  2023-07-28 18:08 [Buildroot] [PATCH 1/1] package/mpg123: force arm mode instead of Thumb mode Bernd Kuhls
@ 2023-07-28 19:25 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-28 19:25 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

On Fri, 28 Jul 2023 20:08:54 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fix the following build failure:
> Error: selected processor does not support `smull r3,ip,r2,r10' in Thumb mode
> 
> Fixes:
> http://autobuild.buildroot.net/results/848/8484fc6be618f3edbf39a13928ab9a4b7b442235/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/mpg123/mpg123.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-28 19:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-28 18:08 [Buildroot] [PATCH 1/1] package/mpg123: force arm mode instead of Thumb mode Bernd Kuhls
2023-07-28 19:25 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.