From: Nishanth Menon <nm@ti.com> To: Jai Luthra <j-luthra@ti.com> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Apurva Nandan <a-nandan@ti.com>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Esteban Blanc <eblanc@baylibre.com>, <jneanne@baylibre.com>, <aseketeli@baylibre.com>, <jpanis@baylibre.com>, <u-kumar1@ti.com>, Vaishnav Achath <vaishnav.a@ti.com>, Hari Nagalla <hnagalla@ti.com>, Devarsh Thakkar <devarsht@ti.com> Subject: Re: [PATCH v6 0/7] Add TPS6594 PMIC support on several boards Date: Wed, 9 Aug 2023 21:47:00 -0500 [thread overview] Message-ID: <20230810024700.4qhgygd6mma4sw2u@kobold> (raw) In-Reply-To: <20230810-tps6594-v6-0-2b2e2399e2ef@ti.com> On 01:16-20230810, Jai Luthra wrote: > arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 95 +++++++++++ > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 157 ++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 163 +++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 199 +++++++++++++++++++++++ Sigh.. Thanks Jai for stepping and trying to make this work, but I think this series is a lot out of whack. Apparently somewhere in this series is a patch for j721s2 that breaks proper boot. I spent quite a while bisecting across boards to find it, So, I am just going to skip this series for this release (and dependencies) Next time for this series: I recommend submitter provide test logs for every single platform touched. https://gist.github.com/nmenon/72e5f9b344e9207863d93491f5bf4f8e I have'nt debugged, but typically that looks like some one decided to pull the voltage low on a key rail. Let me see if I can pick the interrupt range fix at least since should'nt be dependent on this. > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 104 ++++++++++++ > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 2 +- > arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 +- > arch/arm64/configs/defconfig | 1 + > 8 files changed, 721 insertions(+), 2 deletions(-) > --- > base-commit: 21ef7b1e17d039053edaeaf41142423810572741 > change-id: 20230809-tps6594-e450b5738e66 > > Best regards, > -- > Jai Luthra <j-luthra@ti.com> > bisect log: (commit sha's dont mean a thing.. but anyways..) git bisect start # good: [f2e72716f089d6fcc4bf7b8cb7ac874b79ed05b1] iommu: dev->iommu->iommu_dev must be set before ops->device_group() git bisect good f2e72716f089d6fcc4bf7b8cb7ac874b79ed05b1 # bad: [31f83ee5e42290c39e0bce42118ad1267eaf2790] arm64: dts: ti: k3-am64: Enable TSCADC nodes at the board level git bisect bad 31f83ee5e42290c39e0bce42118ad1267eaf2790 # bad: [f51a52fc98cddb7b99ecb19d86c40845f7e8d91e] arm64: dts: ti: k3-am62a7-sk: Split vcc_3v3 regulators git bisect bad f51a52fc98cddb7b99ecb19d86c40845f7e8d91e # good: [0cc1aecdc1024eced6914f015dbc43c28f5ac6aa] arm64: dts: ti: k3-j721s2-som-p0: Add TP6594 family PMICs git bisect good 0cc1aecdc1024eced6914f015dbc43c28f5ac6aa # good: [8b4e4f23f60df9c8aadb0e26cb86b13735ed810b] arm64: dts: ti: k3-j784s4-evm: Add support for TPS6594 PMIC git bisect good 8b4e4f23f60df9c8aadb0e26cb86b13735ed810b # bad: [38ff20140c2cf09ba140234732dd03a9743ebd32] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A git bisect bad 38ff20140c2cf09ba140234732dd03a9743ebd32 # good: [3e98e865a6135bef7d801b5c5236a42a0ef1bff2] arm64: dts: ti: k3-am62a7-sk: Add support for TPS6593 PMIC git bisect good 3e98e865a6135bef7d801b5c5236a42a0ef1bff2 # first bad commit: [38ff20140c2cf09ba140234732dd03a9743ebd32] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com> To: Jai Luthra <j-luthra@ti.com> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Apurva Nandan <a-nandan@ti.com>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Esteban Blanc <eblanc@baylibre.com>, <jneanne@baylibre.com>, <aseketeli@baylibre.com>, <jpanis@baylibre.com>, <u-kumar1@ti.com>, Vaishnav Achath <vaishnav.a@ti.com>, Hari Nagalla <hnagalla@ti.com>, Devarsh Thakkar <devarsht@ti.com> Subject: Re: [PATCH v6 0/7] Add TPS6594 PMIC support on several boards Date: Wed, 9 Aug 2023 21:47:00 -0500 [thread overview] Message-ID: <20230810024700.4qhgygd6mma4sw2u@kobold> (raw) In-Reply-To: <20230810-tps6594-v6-0-2b2e2399e2ef@ti.com> On 01:16-20230810, Jai Luthra wrote: > arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 95 +++++++++++ > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 157 ++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 163 +++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 199 +++++++++++++++++++++++ Sigh.. Thanks Jai for stepping and trying to make this work, but I think this series is a lot out of whack. Apparently somewhere in this series is a patch for j721s2 that breaks proper boot. I spent quite a while bisecting across boards to find it, So, I am just going to skip this series for this release (and dependencies) Next time for this series: I recommend submitter provide test logs for every single platform touched. https://gist.github.com/nmenon/72e5f9b344e9207863d93491f5bf4f8e I have'nt debugged, but typically that looks like some one decided to pull the voltage low on a key rail. Let me see if I can pick the interrupt range fix at least since should'nt be dependent on this. > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 104 ++++++++++++ > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 2 +- > arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 2 +- > arch/arm64/configs/defconfig | 1 + > 8 files changed, 721 insertions(+), 2 deletions(-) > --- > base-commit: 21ef7b1e17d039053edaeaf41142423810572741 > change-id: 20230809-tps6594-e450b5738e66 > > Best regards, > -- > Jai Luthra <j-luthra@ti.com> > bisect log: (commit sha's dont mean a thing.. but anyways..) git bisect start # good: [f2e72716f089d6fcc4bf7b8cb7ac874b79ed05b1] iommu: dev->iommu->iommu_dev must be set before ops->device_group() git bisect good f2e72716f089d6fcc4bf7b8cb7ac874b79ed05b1 # bad: [31f83ee5e42290c39e0bce42118ad1267eaf2790] arm64: dts: ti: k3-am64: Enable TSCADC nodes at the board level git bisect bad 31f83ee5e42290c39e0bce42118ad1267eaf2790 # bad: [f51a52fc98cddb7b99ecb19d86c40845f7e8d91e] arm64: dts: ti: k3-am62a7-sk: Split vcc_3v3 regulators git bisect bad f51a52fc98cddb7b99ecb19d86c40845f7e8d91e # good: [0cc1aecdc1024eced6914f015dbc43c28f5ac6aa] arm64: dts: ti: k3-j721s2-som-p0: Add TP6594 family PMICs git bisect good 0cc1aecdc1024eced6914f015dbc43c28f5ac6aa # good: [8b4e4f23f60df9c8aadb0e26cb86b13735ed810b] arm64: dts: ti: k3-j784s4-evm: Add support for TPS6594 PMIC git bisect good 8b4e4f23f60df9c8aadb0e26cb86b13735ed810b # bad: [38ff20140c2cf09ba140234732dd03a9743ebd32] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A git bisect bad 38ff20140c2cf09ba140234732dd03a9743ebd32 # good: [3e98e865a6135bef7d801b5c5236a42a0ef1bff2] arm64: dts: ti: k3-am62a7-sk: Add support for TPS6593 PMIC git bisect good 3e98e865a6135bef7d801b5c5236a42a0ef1bff2 # first bad commit: [38ff20140c2cf09ba140234732dd03a9743ebd32] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-10 2:47 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-09 19:46 [PATCH v6 0/7] Add TPS6594 PMIC support on several boards Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-09 19:46 ` [PATCH v6 1/7] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-09 19:46 ` [PATCH v6 2/7] arm64: dts: ti: k3-j721s2-som-p0: " Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-09 19:46 ` [PATCH v6 3/7] arm64: dts: ti: k3-j721e-som-p0: " Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-09 19:46 ` [PATCH v6 4/7] arm64: dts: ti: k3-j784s4: Fix interrupt ranges for wkup & main gpio Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-09 19:46 ` [PATCH v6 5/7] arm64: dts: ti: k3-j784s4-evm: Add support for TPS6594 PMIC Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-09 19:46 ` [PATCH v6 6/7] arm64: dts: ti: k3-am62a7-sk: Add support for TPS6593 PMIC Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-09 19:46 ` [PATCH v6 7/7] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A Jai Luthra 2023-08-09 19:46 ` Jai Luthra 2023-08-10 2:47 ` Nishanth Menon [this message] 2023-08-10 2:47 ` [PATCH v6 0/7] Add TPS6594 PMIC support on several boards Nishanth Menon 2023-08-10 5:21 ` (subset) " Nishanth Menon 2023-08-10 5:21 ` Nishanth Menon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230810024700.4qhgygd6mma4sw2u@kobold \ --to=nm@ti.com \ --cc=a-nandan@ti.com \ --cc=aseketeli@baylibre.com \ --cc=conor+dt@kernel.org \ --cc=devarsht@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=eblanc@baylibre.com \ --cc=hnagalla@ti.com \ --cc=j-luthra@ti.com \ --cc=jneanne@baylibre.com \ --cc=jpanis@baylibre.com \ --cc=kristo@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=u-kumar1@ti.com \ --cc=vaishnav.a@ti.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.