* [PATCH v5 0/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
@ 2023-08-18 11:10 ` Josua Mayer
0 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Li Yang
Add support for the SolidRun LX2162A System on Module (SoM), and the
Clearfog evaluation board.
This patch-set introduces:
- dt node for lx2160a serdes block #2
- dtsi for lx2162a system on module
- dts for lx2162 clearfog
Firstly Please note that checkpatch was complaining about the EEPROMS:
- DT compatible string "st,24c02" appears un-documented
- DT compatible string "st,24c2048" appears un-documented
- DT compatible string "atmel,24c2048" appears un-documented
However to my eyes these *are* already documented in at24.yaml,
and are also used in existing device-tree.
checkpatch is also complaining about various parts of lx2160a.dtsi,
as well as the use of "sfp" property in dpmac nodes - which are common
across layerscape based dts.
Secondly the MAINTAINERS file has not been modified.
Is it required I add myself or *someone* for these new dts?
Changes since v4:
- extended commit hash reference to 12 characters in description
Changes since v3:
- moved status properties to be last
- changed ethernet-phy on som from /delete-node/ to disabled,
Changes since v2:
- fixed property order in som dts such that compatible is first property
- added reviewed-by tags to bindings patches
Changes since v1:
- fixed DT binding changes to not break existing boards
- explained new board / som DT binding in commit message
- added missing DT binding for dpaa2 mac "phys" property
- reordered "compatible" and "reg" properties: first "compatible", then "reg"
- replaced chip-specific DT node names with generic ones
Josua Mayer (4):
arm64: dts: lx2160a: describe the SerDes block #2
dt-bindings: net: dpaa2 mac: add phys property
dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board
arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
.../devicetree/bindings/arm/fsl.yaml | 9 +-
.../bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 +
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 +
.../dts/freescale/fsl-lx2162a-clearfog.dts | 373 ++++++++++++++++++
.../dts/freescale/fsl-lx2162a-sr-som.dtsi | 73 ++++
6 files changed, 465 insertions(+), 1 deletion(-)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Li Yang <leoyang.li@nxp.com>
--
2.35.3
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v5 1/4] arm64: dts: lx2160a: describe the SerDes block #2
2023-08-18 11:10 ` Josua Mayer
@ 2023-08-18 11:10 ` Josua Mayer
-1 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Shawn Guo, Li Yang, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Add description for the LX2160A second SerDes block.
It is functionally identical to the first one already added in
commit 3cbe93a1f540 ("arch: arm64: dts: lx2160a: describe the SerDes
block #1").
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
V4 -> V5: expand commit hash reference in commit message
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index ea6a94b57aeb..2e68c05181dd 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -626,6 +626,12 @@ serdes_1: phy@1ea0000 {
#phy-cells = <1>;
};
+ serdes_2: phy@1eb0000 {
+ compatible = "fsl,lynx-28g";
+ reg = <0x0 0x1eb0000 0x0 0x1e30>;
+ #phy-cells = <1>;
+ };
+
crypto: crypto@8000000 {
compatible = "fsl,sec-v5.0", "fsl,sec-v4.0";
fsl,sec-era = <10>;
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v5 1/4] arm64: dts: lx2160a: describe the SerDes block #2
@ 2023-08-18 11:10 ` Josua Mayer
0 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Shawn Guo, Li Yang, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Add description for the LX2160A second SerDes block.
It is functionally identical to the first one already added in
commit 3cbe93a1f540 ("arch: arm64: dts: lx2160a: describe the SerDes
block #1").
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
V4 -> V5: expand commit hash reference in commit message
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index ea6a94b57aeb..2e68c05181dd 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -626,6 +626,12 @@ serdes_1: phy@1ea0000 {
#phy-cells = <1>;
};
+ serdes_2: phy@1eb0000 {
+ compatible = "fsl,lynx-28g";
+ reg = <0x0 0x1eb0000 0x0 0x1e30>;
+ #phy-cells = <1>;
+ };
+
crypto: crypto@8000000 {
compatible = "fsl,sec-v5.0", "fsl,sec-v4.0";
fsl,sec-era = <10>;
--
2.35.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v5 1/4] arm64: dts: lx2160a: describe the SerDes block #2
2023-08-18 11:10 ` Josua Mayer
@ 2023-09-17 14:33 ` Josua Mayer
-1 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-09-17 14:33 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Hello everyone,
This is one of the patches in my series that hasn't received any
feedback yet ...
(apart from Krzysztof correctly pointing out commit a description
formatting mistake).
Please note that I intend on changing the new serdes_2 node to add
status disabled by default.
Since the lynx-28g driver currently only supports network protocols,
enabling it by default could interfere with configurations using those
SerDes's as PCI.
Am 18.08.23 um 13:10 schrieb Josua Mayer:
> Add description for the LX2160A second SerDes block.
> It is functionally identical to the first one already added in
> commit 3cbe93a1f540 ("arch: arm64: dts: lx2160a: describe the SerDes
> block #1").
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
> V4 -> V5: expand commit hash reference in commit message
>
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index ea6a94b57aeb..2e68c05181dd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -626,6 +626,12 @@ serdes_1: phy@1ea0000 {
> #phy-cells = <1>;
> };
>
> + serdes_2: phy@1eb0000 {
> + compatible = "fsl,lynx-28g";
> + reg = <0x0 0x1eb0000 0x0 0x1e30>;
> + #phy-cells = <1>;
> + };
> +
> crypto: crypto@8000000 {
> compatible = "fsl,sec-v5.0", "fsl,sec-v4.0";
> fsl,sec-era = <10>;
- Josua Mayer
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v5 1/4] arm64: dts: lx2160a: describe the SerDes block #2
@ 2023-09-17 14:33 ` Josua Mayer
0 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-09-17 14:33 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Hello everyone,
This is one of the patches in my series that hasn't received any
feedback yet ...
(apart from Krzysztof correctly pointing out commit a description
formatting mistake).
Please note that I intend on changing the new serdes_2 node to add
status disabled by default.
Since the lynx-28g driver currently only supports network protocols,
enabling it by default could interfere with configurations using those
SerDes's as PCI.
Am 18.08.23 um 13:10 schrieb Josua Mayer:
> Add description for the LX2160A second SerDes block.
> It is functionally identical to the first one already added in
> commit 3cbe93a1f540 ("arch: arm64: dts: lx2160a: describe the SerDes
> block #1").
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
> V4 -> V5: expand commit hash reference in commit message
>
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index ea6a94b57aeb..2e68c05181dd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -626,6 +626,12 @@ serdes_1: phy@1ea0000 {
> #phy-cells = <1>;
> };
>
> + serdes_2: phy@1eb0000 {
> + compatible = "fsl,lynx-28g";
> + reg = <0x0 0x1eb0000 0x0 0x1e30>;
> + #phy-cells = <1>;
> + };
> +
> crypto: crypto@8000000 {
> compatible = "fsl,sec-v5.0", "fsl,sec-v4.0";
> fsl,sec-era = <10>;
- Josua Mayer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v5 2/4] dt-bindings: net: dpaa2 mac: add phys property
2023-08-18 11:10 ` Josua Mayer
@ 2023-08-18 11:10 ` Josua Mayer
-1 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Krzysztof Kozlowski, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ioana Ciornei
dpaa2 mac supports runtime configuration of network protocols on a
generic phy object specified via the "phys" property.
It is currently used with the SerDes28G driver to switch SerDes
protocol between SGMII and USXGMII at runtime.
Support was introduced with:
f978fe8 "dpaa2-mac: configure the SerDes phy on a protocol change"
Add bindings description for the missing "phys" property, to fix dtc_chk
errors present in various layerscape based dts:
'phys' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Josua Mayer <josua@solid-run.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
V1 -> V2: this patch is newly added to patch-set
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
index a1b71b35319e..a40c7a84af2a 100644
--- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
@@ -24,6 +24,10 @@ properties:
maxItems: 1
description: The DPMAC number
+ phys:
+ maxItems: 1
+ description: Generic PHY for SerDes runtime configuration.
+
phy-handle: true
phy-connection-type: true
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v5 2/4] dt-bindings: net: dpaa2 mac: add phys property
@ 2023-08-18 11:10 ` Josua Mayer
0 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Krzysztof Kozlowski, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ioana Ciornei
dpaa2 mac supports runtime configuration of network protocols on a
generic phy object specified via the "phys" property.
It is currently used with the SerDes28G driver to switch SerDes
protocol between SGMII and USXGMII at runtime.
Support was introduced with:
f978fe8 "dpaa2-mac: configure the SerDes phy on a protocol change"
Add bindings description for the missing "phys" property, to fix dtc_chk
errors present in various layerscape based dts:
'phys' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Josua Mayer <josua@solid-run.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
V1 -> V2: this patch is newly added to patch-set
Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
index a1b71b35319e..a40c7a84af2a 100644
--- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
@@ -24,6 +24,10 @@ properties:
maxItems: 1
description: The DPMAC number
+ phys:
+ maxItems: 1
+ description: Generic PHY for SerDes runtime configuration.
+
phy-handle: true
phy-connection-type: true
--
2.35.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v5 3/4] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board
2023-08-18 11:10 ` Josua Mayer
@ 2023-08-18 11:10 ` Josua Mayer
-1 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Krzysztof Kozlowski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Marek Vasut,
Stefan Wahren, Frieder Schrempf, Philippe Schenker,
Christoph Niedermaier, Marcel Ziswiler, Li Yang
SolidRun now have 2 product lines around NXP Layerscape SoC:
- LX2160A COM Express 7
- LX2162A System on Module
LX2162 is a smaller package and reduced feature set to LX2160A;
LX2162 SoM is also a smaller form factor and reduced feature set to CEX.
Since both product lines are physically incompatible,
the existing group "SolidRun LX2160A based Boards" has been renamed to
include "CEX" in its name, meaning products based on LX2160A COM Express
Module, following this pattern:
"solidrun,<board>", "solidrun,lx2160a-cex", "fsl,lx2160a"
Add DT compatible for both SolidRun LX2162A SoM, and LX2162 Clearfog
boards to a new group based on LX2162A SoM, following this pattern:
"solidrun,<board>", "solidrun,lx2162a-som", "fsl,lx2160a"
Signed-off-by: Josua Mayer <josua@solid-run.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
V1 -> V2: fixed to not break existing boards
V1 -> V2: explained new board / som DT binding in commit message
Documentation/devicetree/bindings/arm/fsl.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 2510eaa8906d..ff9bf9956972 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1384,7 +1384,7 @@ properties:
- fsl,lx2162a-qds
- const: fsl,lx2160a
- - description: SolidRun LX2160A based Boards
+ - description: SolidRun LX2160A CEX-7 based Boards
items:
- enum:
- solidrun,clearfog-cx
@@ -1392,6 +1392,13 @@ properties:
- const: solidrun,lx2160a-cex7
- const: fsl,lx2160a
+ - description: SolidRun LX2162A SoM based Boards
+ items:
+ - enum:
+ - solidrun,lx2162a-clearfog
+ - const: solidrun,lx2162a-som
+ - const: fsl,lx2160a
+
- description: S32G2 based Boards
items:
- enum:
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v5 3/4] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board
@ 2023-08-18 11:10 ` Josua Mayer
0 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Krzysztof Kozlowski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Marek Vasut,
Stefan Wahren, Frieder Schrempf, Philippe Schenker,
Christoph Niedermaier, Marcel Ziswiler, Li Yang
SolidRun now have 2 product lines around NXP Layerscape SoC:
- LX2160A COM Express 7
- LX2162A System on Module
LX2162 is a smaller package and reduced feature set to LX2160A;
LX2162 SoM is also a smaller form factor and reduced feature set to CEX.
Since both product lines are physically incompatible,
the existing group "SolidRun LX2160A based Boards" has been renamed to
include "CEX" in its name, meaning products based on LX2160A COM Express
Module, following this pattern:
"solidrun,<board>", "solidrun,lx2160a-cex", "fsl,lx2160a"
Add DT compatible for both SolidRun LX2162A SoM, and LX2162 Clearfog
boards to a new group based on LX2162A SoM, following this pattern:
"solidrun,<board>", "solidrun,lx2162a-som", "fsl,lx2160a"
Signed-off-by: Josua Mayer <josua@solid-run.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
V1 -> V2: fixed to not break existing boards
V1 -> V2: explained new board / som DT binding in commit message
Documentation/devicetree/bindings/arm/fsl.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 2510eaa8906d..ff9bf9956972 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1384,7 +1384,7 @@ properties:
- fsl,lx2162a-qds
- const: fsl,lx2160a
- - description: SolidRun LX2160A based Boards
+ - description: SolidRun LX2160A CEX-7 based Boards
items:
- enum:
- solidrun,clearfog-cx
@@ -1392,6 +1392,13 @@ properties:
- const: solidrun,lx2160a-cex7
- const: fsl,lx2160a
+ - description: SolidRun LX2162A SoM based Boards
+ items:
+ - enum:
+ - solidrun,lx2162a-clearfog
+ - const: solidrun,lx2162a-som
+ - const: fsl,lx2160a
+
- description: S32G2 based Boards
items:
- enum:
--
2.35.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
2023-08-18 11:10 ` Josua Mayer
@ 2023-08-18 11:10 ` Josua Mayer
-1 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Li Yang, Philippe Schenker, Fabio Estevam,
Aishwarya Kothari, Marco Felsch, Tim Harvey, Frieder Schrempf,
Marek Vasut, Marcel Ziswiler, Alexander Stein
Add support for the SolidRun LX2162A System on Module (SoM), and the
Clearfog evaluation board.
The SoM has few software-controllable features:
- AR8035 Ethernet PHY
- eMMC
- SPI Flash
- fan controller
- various eeproms
The Clearfog evaluation board provides:
- microSD connector
- USB-A
- 2x 10Gbps SFP+
- 2x 25Gbps SFP+ with a retimer
- 8x 2.5Gbps RJ45
- 2x mPCI (assembly option / disables 2xRJ45)
The 8x RJ45 ports are connected with an 8-port PHY: Marvell 88E2580
supporting up to 5Gbps, while SoC and magnetics are limited to 2.5Gbps.
However 2500 speed is untested due to documentation and drivier
limitations. To avoid confusion the phy nodes have been explicitly
limited to 1000 for now.
The PCI nodes are disabled, but explicitly added to mark that this board
can have pci.
It is expected that the bootloader will patch the status property
"okay" and disable 2x RJ45 ports, according to active serdes configuration.
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
V1 -> V2: reordered "compatible" and "reg" properties
V1 -> V2: replaced chip-specific DT node names with generic ones
V1 -> V2: removed dead code from fspi node
V2 -> V3: dropped deprecated address-cells, address-size props from flash node
V3 -> V4: reordered dt properties such that status is last
V3 -> V4: changed ethernet-phy on som from /delete-node/ to disabled
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../dts/freescale/fsl-lx2162a-clearfog.dts | 373 ++++++++++++++++++
.../dts/freescale/fsl-lx2162a-sr-som.dtsi | 73 ++++
3 files changed, 447 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index a750be13ace8..9448d2effd8a 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
fsl-ls1028a-qds-13bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-13bb.dtbo
fsl-ls1028a-qds-65bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-65bb.dtbo
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
new file mode 100644
index 000000000000..ad57f4cca62d
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
@@ -0,0 +1,373 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2162A Clearfog
+//
+// Copyright 2023 Josua Mayer <josua@solid-run.com>
+
+/dts-v1/;
+
+#include "fsl-lx2160a.dtsi"
+#include "fsl-lx2162a-sr-som.dtsi"
+
+/ {
+ model = "SolidRun LX2162A Clearfog";
+ compatible = "solidrun,lx2162a-clearfog", "solidrun,lx2162a-som", "fsl,lx2160a";
+
+ aliases {
+ crypto = &crypto;
+ i2c0 = &i2c0;
+ i2c1 = &i2c2;
+ i2c2 = &i2c4;
+ i2c3 = &sfp_i2c0;
+ i2c4 = &sfp_i2c1;
+ i2c5 = &sfp_i2c2;
+ i2c6 = &sfp_i2c3;
+ i2c7 = &mpcie1_i2c;
+ i2c8 = &mpcie0_i2c;
+ i2c9 = &pcieclk_i2c;
+ mmc0 = &esdhc0;
+ mmc1 = &esdhc1;
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led_sfp_at: led-sfp-at {
+ gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
+ default-state = "off";
+ };
+ led_sfp_ab: led-sfp-ab {
+ gpios = <&gpio2 11 GPIO_ACTIVE_HIGH>; /* PROC_IRQ11 */
+ default-state = "off";
+ };
+ led_sfp_bt: led-sfp-bt {
+ gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>; /* EVT1_B */
+ default-state = "off";
+ };
+ led_sfp_bb: led-sfp-bb {
+ gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* EVT2_B */
+ default-state = "off";
+ };
+ };
+
+ sfp_at: sfp-at {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c0>;
+ mod-def0-gpios = <&gpio2 16 GPIO_ACTIVE_LOW>; /* EVT4_B */
+ maximum-power-milliwatt = <2000>;
+ };
+
+ sfp_ab: sfp-ab {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c1>;
+ mod-def0-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; /* PROC_IRQ1 */
+ maximum-power-milliwatt = <2000>;
+ };
+
+ sfp_bt: sfp-bt {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c2>;
+ mod-def0-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; /* PROC_IRQ10 */
+ maximum-power-milliwatt = <2000>;
+ };
+
+ sfp_bb: sfp-bb {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c3>;
+ mod-def0-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>; /* EVT3_B */
+ maximum-power-milliwatt = <2000>;
+ };
+};
+
+&i2c2 {
+ status = "okay";
+
+ /* retimer@18 */
+
+ i2c-mux@70 {
+ compatible = "nxp,pca9546";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ sfp_i2c0: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ sfp_i2c1: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ sfp_i2c2: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ sfp_i2c3: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+
+ i2c-mux@71 {
+ compatible = "nxp,pca9546";
+ reg = <0x71>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ mpcie1_i2c: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ mpcie0_i2c: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ pcieclk_i2c: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+
+ /* clock-controller@6b */
+ };
+ };
+};
+
+&dpmac3 {
+ sfp = <&sfp_at>;
+ managed = "in-band-status";
+ phys = <&serdes_1 7>;
+};
+
+&dpmac4 {
+ sfp = <&sfp_ab>;
+ managed = "in-band-status";
+ phys = <&serdes_1 6>;
+};
+
+&dpmac5 {
+ sfp = <&sfp_bt>;
+ managed = "in-band-status";
+ phys = <&serdes_1 5>;
+};
+
+&dpmac6 {
+ sfp = <&sfp_bb>;
+ managed = "in-band-status";
+ phys = <&serdes_1 4>;
+};
+
+&dpmac11 {
+ phys = <&serdes_2 0>;
+ phy-handle = <ðernet_phy3>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac12 {
+ phys = <&serdes_2 1>;
+ phy-handle = <ðernet_phy1>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac13 {
+ phys = <&serdes_2 6>;
+ phy-handle = <ðernet_phy6>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac14 {
+ phys = <&serdes_2 7>;
+ phy-handle = <ðernet_phy8>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac15 {
+ phys = <&serdes_2 4>;
+ phy-handle = <ðernet_phy4>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac16 {
+ phys = <&serdes_2 5>;
+ phy-handle = <ðernet_phy2>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac17 {
+ /* override connection to on-SoM phy */
+ /delete-property/ phy-handle;
+ /delete-property/ phy-connection-type;
+
+ phys = <&serdes_2 2>;
+ phy-handle = <ðernet_phy5>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac18 {
+ phys = <&serdes_2 3>;
+ phy-handle = <ðernet_phy7>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&emdio1 {
+ ethernet_phy1: ethernet-phy@8 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <8>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy2: ethernet-phy@9 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <9>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy3: ethernet-phy@10 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <10>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy4: ethernet-phy@11 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <11>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy5: ethernet-phy@12 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <12>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy6: ethernet-phy@13 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <13>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy7: ethernet-phy@14 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <14>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy8: ethernet-phy@15 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <15>;
+ max-speed = <1000>;
+ };
+};
+
+&esdhc0 {
+ sd-uhs-sdr104;
+ sd-uhs-sdr50;
+ sd-uhs-sdr25;
+ sd-uhs-sdr12;
+ status = "okay";
+};
+
+ðernet_phy0 {
+ /*
+ * SoM has a phy at address 1 connected to SoC Ethernet Controller 1.
+ * It competes for WRIOP MAC17, and no connector has been wired.
+ */
+ status = "disabled";
+};
+
+&pcie3 {
+ status = "disabled";
+};
+
+&pcie4 {
+ status = "disabled";
+};
+
+&pcs_mdio3 {
+ status = "okay";
+};
+
+&pcs_mdio4 {
+ status = "okay";
+};
+
+&pcs_mdio5 {
+ status = "okay";
+};
+
+&pcs_mdio6 {
+ status = "okay";
+};
+
+&pcs_mdio11 {
+ status = "okay";
+};
+
+&pcs_mdio12 {
+ status = "okay";
+};
+
+&pcs_mdio13 {
+ status = "okay";
+};
+
+&pcs_mdio14 {
+ status = "okay";
+};
+
+&pcs_mdio15 {
+ status = "okay";
+};
+
+&pcs_mdio16 {
+ status = "okay";
+};
+
+&pcs_mdio17 {
+ status = "okay";
+};
+
+&pcs_mdio18 {
+ status = "okay";
+};
+
+&serdes_1 {
+ status = "okay";
+};
+
+&serdes_2 {
+ status = "okay";
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
new file mode 100644
index 000000000000..ac3f9bc60265
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2162A-SOM
+//
+// Copyright 2021 Rabeeh Khoury <rabeeh@solid-run.com>
+// Copyright 2023 Josua Mayer <josua@solid-run.com>
+
+&crypto {
+ status = "okay";
+};
+
+&dpmac17 {
+ phy-handle = <ðernet_phy0>;
+ phy-connection-type = "rgmii-id";
+};
+
+&emdio1 {
+ status = "okay";
+
+ ethernet_phy0: ethernet-phy@1 {
+ reg = <1>;
+ };
+};
+
+&esdhc1 {
+ status = "okay";
+ bus-width = <8>;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+};
+
+&fspi {
+ status = "okay";
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ m25p,fast-read;
+ spi-max-frequency = <50000000>;
+ /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+ spi-rx-bus-width = <8>;
+ spi-tx-bus-width = <1>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+
+ fan-controller@18 {
+ compatible = "ti,amc6821";
+ reg = <0x18>;
+ };
+
+ ddr_spd: eeprom@51 {
+ compatible = "st,24c02", "atmel,24c02";
+ reg = <0x51>;
+ read-only;
+ };
+
+ config_eeprom: eeprom@57 {
+ compatible = "st,24c02", "atmel,24c02";
+ reg = <0x57>;
+ };
+};
+
+&i2c4 {
+ status = "okay";
+
+ variable_eeprom: eeprom@54 {
+ compatible = "st,24c2048", "atmel,24c2048";
+ reg = <0x54>;
+ };
+};
--
2.35.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
@ 2023-08-18 11:10 ` Josua Mayer
0 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-08-18 11:10 UTC (permalink / raw)
To: devicetree, linux-kernel, linux-arm-kernel
Cc: Josua Mayer, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Li Yang, Philippe Schenker, Fabio Estevam,
Aishwarya Kothari, Marco Felsch, Tim Harvey, Frieder Schrempf,
Marek Vasut, Marcel Ziswiler, Alexander Stein
Add support for the SolidRun LX2162A System on Module (SoM), and the
Clearfog evaluation board.
The SoM has few software-controllable features:
- AR8035 Ethernet PHY
- eMMC
- SPI Flash
- fan controller
- various eeproms
The Clearfog evaluation board provides:
- microSD connector
- USB-A
- 2x 10Gbps SFP+
- 2x 25Gbps SFP+ with a retimer
- 8x 2.5Gbps RJ45
- 2x mPCI (assembly option / disables 2xRJ45)
The 8x RJ45 ports are connected with an 8-port PHY: Marvell 88E2580
supporting up to 5Gbps, while SoC and magnetics are limited to 2.5Gbps.
However 2500 speed is untested due to documentation and drivier
limitations. To avoid confusion the phy nodes have been explicitly
limited to 1000 for now.
The PCI nodes are disabled, but explicitly added to mark that this board
can have pci.
It is expected that the bootloader will patch the status property
"okay" and disable 2x RJ45 ports, according to active serdes configuration.
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
V1 -> V2: reordered "compatible" and "reg" properties
V1 -> V2: replaced chip-specific DT node names with generic ones
V1 -> V2: removed dead code from fspi node
V2 -> V3: dropped deprecated address-cells, address-size props from flash node
V3 -> V4: reordered dt properties such that status is last
V3 -> V4: changed ethernet-phy on som from /delete-node/ to disabled
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../dts/freescale/fsl-lx2162a-clearfog.dts | 373 ++++++++++++++++++
.../dts/freescale/fsl-lx2162a-sr-som.dtsi | 73 ++++
3 files changed, 447 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index a750be13ace8..9448d2effd8a 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
fsl-ls1028a-qds-13bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-13bb.dtbo
fsl-ls1028a-qds-65bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-65bb.dtbo
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
new file mode 100644
index 000000000000..ad57f4cca62d
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
@@ -0,0 +1,373 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2162A Clearfog
+//
+// Copyright 2023 Josua Mayer <josua@solid-run.com>
+
+/dts-v1/;
+
+#include "fsl-lx2160a.dtsi"
+#include "fsl-lx2162a-sr-som.dtsi"
+
+/ {
+ model = "SolidRun LX2162A Clearfog";
+ compatible = "solidrun,lx2162a-clearfog", "solidrun,lx2162a-som", "fsl,lx2160a";
+
+ aliases {
+ crypto = &crypto;
+ i2c0 = &i2c0;
+ i2c1 = &i2c2;
+ i2c2 = &i2c4;
+ i2c3 = &sfp_i2c0;
+ i2c4 = &sfp_i2c1;
+ i2c5 = &sfp_i2c2;
+ i2c6 = &sfp_i2c3;
+ i2c7 = &mpcie1_i2c;
+ i2c8 = &mpcie0_i2c;
+ i2c9 = &pcieclk_i2c;
+ mmc0 = &esdhc0;
+ mmc1 = &esdhc1;
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led_sfp_at: led-sfp-at {
+ gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
+ default-state = "off";
+ };
+ led_sfp_ab: led-sfp-ab {
+ gpios = <&gpio2 11 GPIO_ACTIVE_HIGH>; /* PROC_IRQ11 */
+ default-state = "off";
+ };
+ led_sfp_bt: led-sfp-bt {
+ gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>; /* EVT1_B */
+ default-state = "off";
+ };
+ led_sfp_bb: led-sfp-bb {
+ gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* EVT2_B */
+ default-state = "off";
+ };
+ };
+
+ sfp_at: sfp-at {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c0>;
+ mod-def0-gpios = <&gpio2 16 GPIO_ACTIVE_LOW>; /* EVT4_B */
+ maximum-power-milliwatt = <2000>;
+ };
+
+ sfp_ab: sfp-ab {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c1>;
+ mod-def0-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; /* PROC_IRQ1 */
+ maximum-power-milliwatt = <2000>;
+ };
+
+ sfp_bt: sfp-bt {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c2>;
+ mod-def0-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; /* PROC_IRQ10 */
+ maximum-power-milliwatt = <2000>;
+ };
+
+ sfp_bb: sfp-bb {
+ compatible = "sff,sfp";
+ i2c-bus = <&sfp_i2c3>;
+ mod-def0-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>; /* EVT3_B */
+ maximum-power-milliwatt = <2000>;
+ };
+};
+
+&i2c2 {
+ status = "okay";
+
+ /* retimer@18 */
+
+ i2c-mux@70 {
+ compatible = "nxp,pca9546";
+ reg = <0x70>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ sfp_i2c0: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ sfp_i2c1: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ sfp_i2c2: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ sfp_i2c3: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
+ };
+
+ i2c-mux@71 {
+ compatible = "nxp,pca9546";
+ reg = <0x71>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ i2c-mux-idle-disconnect;
+
+ mpcie1_i2c: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ };
+
+ mpcie0_i2c: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ pcieclk_i2c: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+
+ /* clock-controller@6b */
+ };
+ };
+};
+
+&dpmac3 {
+ sfp = <&sfp_at>;
+ managed = "in-band-status";
+ phys = <&serdes_1 7>;
+};
+
+&dpmac4 {
+ sfp = <&sfp_ab>;
+ managed = "in-band-status";
+ phys = <&serdes_1 6>;
+};
+
+&dpmac5 {
+ sfp = <&sfp_bt>;
+ managed = "in-band-status";
+ phys = <&serdes_1 5>;
+};
+
+&dpmac6 {
+ sfp = <&sfp_bb>;
+ managed = "in-band-status";
+ phys = <&serdes_1 4>;
+};
+
+&dpmac11 {
+ phys = <&serdes_2 0>;
+ phy-handle = <ðernet_phy3>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac12 {
+ phys = <&serdes_2 1>;
+ phy-handle = <ðernet_phy1>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac13 {
+ phys = <&serdes_2 6>;
+ phy-handle = <ðernet_phy6>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac14 {
+ phys = <&serdes_2 7>;
+ phy-handle = <ðernet_phy8>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac15 {
+ phys = <&serdes_2 4>;
+ phy-handle = <ðernet_phy4>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac16 {
+ phys = <&serdes_2 5>;
+ phy-handle = <ðernet_phy2>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac17 {
+ /* override connection to on-SoM phy */
+ /delete-property/ phy-handle;
+ /delete-property/ phy-connection-type;
+
+ phys = <&serdes_2 2>;
+ phy-handle = <ðernet_phy5>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&dpmac18 {
+ phys = <&serdes_2 3>;
+ phy-handle = <ðernet_phy7>;
+ phy-connection-type = "sgmii";
+ status = "okay";
+};
+
+&emdio1 {
+ ethernet_phy1: ethernet-phy@8 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <8>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy2: ethernet-phy@9 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <9>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy3: ethernet-phy@10 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <10>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy4: ethernet-phy@11 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <11>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy5: ethernet-phy@12 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <12>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy6: ethernet-phy@13 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <13>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy7: ethernet-phy@14 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <14>;
+ max-speed = <1000>;
+ };
+
+ ethernet_phy8: ethernet-phy@15 {
+ compatible = "ethernet-phy-ieee802.3-c45";
+ reg = <15>;
+ max-speed = <1000>;
+ };
+};
+
+&esdhc0 {
+ sd-uhs-sdr104;
+ sd-uhs-sdr50;
+ sd-uhs-sdr25;
+ sd-uhs-sdr12;
+ status = "okay";
+};
+
+ðernet_phy0 {
+ /*
+ * SoM has a phy at address 1 connected to SoC Ethernet Controller 1.
+ * It competes for WRIOP MAC17, and no connector has been wired.
+ */
+ status = "disabled";
+};
+
+&pcie3 {
+ status = "disabled";
+};
+
+&pcie4 {
+ status = "disabled";
+};
+
+&pcs_mdio3 {
+ status = "okay";
+};
+
+&pcs_mdio4 {
+ status = "okay";
+};
+
+&pcs_mdio5 {
+ status = "okay";
+};
+
+&pcs_mdio6 {
+ status = "okay";
+};
+
+&pcs_mdio11 {
+ status = "okay";
+};
+
+&pcs_mdio12 {
+ status = "okay";
+};
+
+&pcs_mdio13 {
+ status = "okay";
+};
+
+&pcs_mdio14 {
+ status = "okay";
+};
+
+&pcs_mdio15 {
+ status = "okay";
+};
+
+&pcs_mdio16 {
+ status = "okay";
+};
+
+&pcs_mdio17 {
+ status = "okay";
+};
+
+&pcs_mdio18 {
+ status = "okay";
+};
+
+&serdes_1 {
+ status = "okay";
+};
+
+&serdes_2 {
+ status = "okay";
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
new file mode 100644
index 000000000000..ac3f9bc60265
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2162A-SOM
+//
+// Copyright 2021 Rabeeh Khoury <rabeeh@solid-run.com>
+// Copyright 2023 Josua Mayer <josua@solid-run.com>
+
+&crypto {
+ status = "okay";
+};
+
+&dpmac17 {
+ phy-handle = <ðernet_phy0>;
+ phy-connection-type = "rgmii-id";
+};
+
+&emdio1 {
+ status = "okay";
+
+ ethernet_phy0: ethernet-phy@1 {
+ reg = <1>;
+ };
+};
+
+&esdhc1 {
+ status = "okay";
+ bus-width = <8>;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+};
+
+&fspi {
+ status = "okay";
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ m25p,fast-read;
+ spi-max-frequency = <50000000>;
+ /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+ spi-rx-bus-width = <8>;
+ spi-tx-bus-width = <1>;
+ };
+};
+
+&i2c0 {
+ status = "okay";
+
+ fan-controller@18 {
+ compatible = "ti,amc6821";
+ reg = <0x18>;
+ };
+
+ ddr_spd: eeprom@51 {
+ compatible = "st,24c02", "atmel,24c02";
+ reg = <0x51>;
+ read-only;
+ };
+
+ config_eeprom: eeprom@57 {
+ compatible = "st,24c02", "atmel,24c02";
+ reg = <0x57>;
+ };
+};
+
+&i2c4 {
+ status = "okay";
+
+ variable_eeprom: eeprom@54 {
+ compatible = "st,24c2048", "atmel,24c2048";
+ reg = <0x54>;
+ };
+};
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
2023-08-18 11:10 ` Josua Mayer
@ 2023-09-24 13:51 ` Shawn Guo
-1 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2023-09-24 13:51 UTC (permalink / raw)
To: Josua Mayer
Cc: devicetree, linux-kernel, linux-arm-kernel, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Li Yang, Philippe Schenker,
Fabio Estevam, Aishwarya Kothari, Marco Felsch, Tim Harvey,
Frieder Schrempf, Marek Vasut, Marcel Ziswiler, Alexander Stein
On Fri, Aug 18, 2023 at 01:10:16PM +0200, Josua Mayer wrote:
> Add support for the SolidRun LX2162A System on Module (SoM), and the
> Clearfog evaluation board.
>
> The SoM has few software-controllable features:
> - AR8035 Ethernet PHY
> - eMMC
> - SPI Flash
> - fan controller
> - various eeproms
>
> The Clearfog evaluation board provides:
> - microSD connector
> - USB-A
> - 2x 10Gbps SFP+
> - 2x 25Gbps SFP+ with a retimer
> - 8x 2.5Gbps RJ45
> - 2x mPCI (assembly option / disables 2xRJ45)
>
> The 8x RJ45 ports are connected with an 8-port PHY: Marvell 88E2580
> supporting up to 5Gbps, while SoC and magnetics are limited to 2.5Gbps.
>
> However 2500 speed is untested due to documentation and drivier
> limitations. To avoid confusion the phy nodes have been explicitly
> limited to 1000 for now.
>
> The PCI nodes are disabled, but explicitly added to mark that this board
> can have pci.
> It is expected that the bootloader will patch the status property
> "okay" and disable 2x RJ45 ports, according to active serdes configuration.
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
> V1 -> V2: reordered "compatible" and "reg" properties
> V1 -> V2: replaced chip-specific DT node names with generic ones
> V1 -> V2: removed dead code from fspi node
> V2 -> V3: dropped deprecated address-cells, address-size props from flash node
> V3 -> V4: reordered dt properties such that status is last
> V3 -> V4: changed ethernet-phy on som from /delete-node/ to disabled
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../dts/freescale/fsl-lx2162a-clearfog.dts | 373 ++++++++++++++++++
> .../dts/freescale/fsl-lx2162a-sr-som.dtsi | 73 ++++
> 3 files changed, 447 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index a750be13ace8..9448d2effd8a 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
Out of alphabetical order.
>
> fsl-ls1028a-qds-13bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-13bb.dtbo
> fsl-ls1028a-qds-65bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-65bb.dtbo
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> new file mode 100644
> index 000000000000..ad57f4cca62d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> @@ -0,0 +1,373 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2162A Clearfog
> +//
> +// Copyright 2023 Josua Mayer <josua@solid-run.com>
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a.dtsi"
> +#include "fsl-lx2162a-sr-som.dtsi"
> +
> +/ {
> + model = "SolidRun LX2162A Clearfog";
> + compatible = "solidrun,lx2162a-clearfog", "solidrun,lx2162a-som", "fsl,lx2160a";
> +
> + aliases {
> + crypto = &crypto;
> + i2c0 = &i2c0;
> + i2c1 = &i2c2;
> + i2c2 = &i2c4;
> + i2c3 = &sfp_i2c0;
> + i2c4 = &sfp_i2c1;
> + i2c5 = &sfp_i2c2;
> + i2c6 = &sfp_i2c3;
> + i2c7 = &mpcie1_i2c;
> + i2c8 = &mpcie0_i2c;
> + i2c9 = &pcieclk_i2c;
> + mmc0 = &esdhc0;
> + mmc1 = &esdhc1;
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led_sfp_at: led-sfp-at {
> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
> + default-state = "off";
> + };
Have a newline between nodes.
> + led_sfp_ab: led-sfp-ab {
> + gpios = <&gpio2 11 GPIO_ACTIVE_HIGH>; /* PROC_IRQ11 */
> + default-state = "off";
> + };
> + led_sfp_bt: led-sfp-bt {
> + gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>; /* EVT1_B */
> + default-state = "off";
> + };
> + led_sfp_bb: led-sfp-bb {
> + gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* EVT2_B */
> + default-state = "off";
> + };
> + };
> +
> + sfp_at: sfp-at {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c0>;
> + mod-def0-gpios = <&gpio2 16 GPIO_ACTIVE_LOW>; /* EVT4_B */
> + maximum-power-milliwatt = <2000>;
> + };
> +
> + sfp_ab: sfp-ab {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c1>;
> + mod-def0-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; /* PROC_IRQ1 */
> + maximum-power-milliwatt = <2000>;
> + };
> +
> + sfp_bt: sfp-bt {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c2>;
> + mod-def0-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; /* PROC_IRQ10 */
> + maximum-power-milliwatt = <2000>;
> + };
> +
> + sfp_bb: sfp-bb {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c3>;
> + mod-def0-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>; /* EVT3_B */
> + maximum-power-milliwatt = <2000>;
> + };
> +};
> +
> +&i2c2 {
This label node seems out of alphabetical order.
> + status = "okay";
> +
> + /* retimer@18 */
> +
> + i2c-mux@70 {
> + compatible = "nxp,pca9546";
> + reg = <0x70>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + i2c-mux-idle-disconnect;
> +
> + sfp_i2c0: i2c@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + };
> +
> + sfp_i2c1: i2c@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + };
> +
> + sfp_i2c2: i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> + };
> +
> + sfp_i2c3: i2c@3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <3>;
> + };
> + };
> +
> + i2c-mux@71 {
> + compatible = "nxp,pca9546";
> + reg = <0x71>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + i2c-mux-idle-disconnect;
> +
> + mpcie1_i2c: i2c@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + };
> +
> + mpcie0_i2c: i2c@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + };
> +
> + pcieclk_i2c: i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> +
> + /* clock-controller@6b */
> + };
> + };
> +};
> +
> +&dpmac3 {
> + sfp = <&sfp_at>;
> + managed = "in-band-status";
> + phys = <&serdes_1 7>;
> +};
> +
> +&dpmac4 {
> + sfp = <&sfp_ab>;
> + managed = "in-band-status";
> + phys = <&serdes_1 6>;
> +};
> +
> +&dpmac5 {
> + sfp = <&sfp_bt>;
> + managed = "in-band-status";
> + phys = <&serdes_1 5>;
> +};
> +
> +&dpmac6 {
> + sfp = <&sfp_bb>;
> + managed = "in-band-status";
> + phys = <&serdes_1 4>;
> +};
> +
> +&dpmac11 {
> + phys = <&serdes_2 0>;
> + phy-handle = <ðernet_phy3>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac12 {
> + phys = <&serdes_2 1>;
> + phy-handle = <ðernet_phy1>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac13 {
> + phys = <&serdes_2 6>;
> + phy-handle = <ðernet_phy6>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac14 {
> + phys = <&serdes_2 7>;
> + phy-handle = <ðernet_phy8>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac15 {
> + phys = <&serdes_2 4>;
> + phy-handle = <ðernet_phy4>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac16 {
> + phys = <&serdes_2 5>;
> + phy-handle = <ðernet_phy2>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac17 {
> + /* override connection to on-SoM phy */
> + /delete-property/ phy-handle;
> + /delete-property/ phy-connection-type;
> +
> + phys = <&serdes_2 2>;
> + phy-handle = <ðernet_phy5>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac18 {
> + phys = <&serdes_2 3>;
> + phy-handle = <ðernet_phy7>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&emdio1 {
> + ethernet_phy1: ethernet-phy@8 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <8>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy2: ethernet-phy@9 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <9>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy3: ethernet-phy@10 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <10>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy4: ethernet-phy@11 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <11>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy5: ethernet-phy@12 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <12>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy6: ethernet-phy@13 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <13>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy7: ethernet-phy@14 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <14>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy8: ethernet-phy@15 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <15>;
> + max-speed = <1000>;
> + };
> +};
> +
> +&esdhc0 {
> + sd-uhs-sdr104;
> + sd-uhs-sdr50;
> + sd-uhs-sdr25;
> + sd-uhs-sdr12;
> + status = "okay";
> +};
> +
> +ðernet_phy0 {
> + /*
> + * SoM has a phy at address 1 connected to SoC Ethernet Controller 1.
> + * It competes for WRIOP MAC17, and no connector has been wired.
> + */
> + status = "disabled";
> +};
> +
> +&pcie3 {
> + status = "disabled";
> +};
> +
> +&pcie4 {
> + status = "disabled";
> +};
> +
> +&pcs_mdio3 {
> + status = "okay";
> +};
> +
> +&pcs_mdio4 {
> + status = "okay";
> +};
> +
> +&pcs_mdio5 {
> + status = "okay";
> +};
> +
> +&pcs_mdio6 {
> + status = "okay";
> +};
> +
> +&pcs_mdio11 {
> + status = "okay";
> +};
> +
> +&pcs_mdio12 {
> + status = "okay";
> +};
> +
> +&pcs_mdio13 {
> + status = "okay";
> +};
> +
> +&pcs_mdio14 {
> + status = "okay";
> +};
> +
> +&pcs_mdio15 {
> + status = "okay";
> +};
> +
> +&pcs_mdio16 {
> + status = "okay";
> +};
> +
> +&pcs_mdio17 {
> + status = "okay";
> +};
> +
> +&pcs_mdio18 {
> + status = "okay";
> +};
> +
> +&serdes_1 {
> + status = "okay";
> +};
> +
> +&serdes_2 {
> + status = "okay";
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
> new file mode 100644
> index 000000000000..ac3f9bc60265
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
> @@ -0,0 +1,73 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2162A-SOM
> +//
> +// Copyright 2021 Rabeeh Khoury <rabeeh@solid-run.com>
> +// Copyright 2023 Josua Mayer <josua@solid-run.com>
> +
> +&crypto {
> + status = "okay";
> +};
> +
> +&dpmac17 {
> + phy-handle = <ðernet_phy0>;
> + phy-connection-type = "rgmii-id";
> +};
> +
> +&emdio1 {
> + status = "okay";
> +
> + ethernet_phy0: ethernet-phy@1 {
> + reg = <1>;
> + };
> +};
> +
> +&esdhc1 {
> + status = "okay";
> + bus-width = <8>;
> + mmc-hs200-1_8v;
> + mmc-hs400-1_8v;
We usually have 'status' be the last property.
Shawn
> +};
> +
> +&fspi {
> + status = "okay";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + m25p,fast-read;
> + spi-max-frequency = <50000000>;
> + /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> + spi-rx-bus-width = <8>;
> + spi-tx-bus-width = <1>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +
> + fan-controller@18 {
> + compatible = "ti,amc6821";
> + reg = <0x18>;
> + };
> +
> + ddr_spd: eeprom@51 {
> + compatible = "st,24c02", "atmel,24c02";
> + reg = <0x51>;
> + read-only;
> + };
> +
> + config_eeprom: eeprom@57 {
> + compatible = "st,24c02", "atmel,24c02";
> + reg = <0x57>;
> + };
> +};
> +
> +&i2c4 {
> + status = "okay";
> +
> + variable_eeprom: eeprom@54 {
> + compatible = "st,24c2048", "atmel,24c2048";
> + reg = <0x54>;
> + };
> +};
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
@ 2023-09-24 13:51 ` Shawn Guo
0 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2023-09-24 13:51 UTC (permalink / raw)
To: Josua Mayer
Cc: devicetree, linux-kernel, linux-arm-kernel, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Li Yang, Philippe Schenker,
Fabio Estevam, Aishwarya Kothari, Marco Felsch, Tim Harvey,
Frieder Schrempf, Marek Vasut, Marcel Ziswiler, Alexander Stein
On Fri, Aug 18, 2023 at 01:10:16PM +0200, Josua Mayer wrote:
> Add support for the SolidRun LX2162A System on Module (SoM), and the
> Clearfog evaluation board.
>
> The SoM has few software-controllable features:
> - AR8035 Ethernet PHY
> - eMMC
> - SPI Flash
> - fan controller
> - various eeproms
>
> The Clearfog evaluation board provides:
> - microSD connector
> - USB-A
> - 2x 10Gbps SFP+
> - 2x 25Gbps SFP+ with a retimer
> - 8x 2.5Gbps RJ45
> - 2x mPCI (assembly option / disables 2xRJ45)
>
> The 8x RJ45 ports are connected with an 8-port PHY: Marvell 88E2580
> supporting up to 5Gbps, while SoC and magnetics are limited to 2.5Gbps.
>
> However 2500 speed is untested due to documentation and drivier
> limitations. To avoid confusion the phy nodes have been explicitly
> limited to 1000 for now.
>
> The PCI nodes are disabled, but explicitly added to mark that this board
> can have pci.
> It is expected that the bootloader will patch the status property
> "okay" and disable 2x RJ45 ports, according to active serdes configuration.
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
> V1 -> V2: reordered "compatible" and "reg" properties
> V1 -> V2: replaced chip-specific DT node names with generic ones
> V1 -> V2: removed dead code from fspi node
> V2 -> V3: dropped deprecated address-cells, address-size props from flash node
> V3 -> V4: reordered dt properties such that status is last
> V3 -> V4: changed ethernet-phy on som from /delete-node/ to disabled
>
> arch/arm64/boot/dts/freescale/Makefile | 1 +
> .../dts/freescale/fsl-lx2162a-clearfog.dts | 373 ++++++++++++++++++
> .../dts/freescale/fsl-lx2162a-sr-som.dtsi | 73 ++++
> 3 files changed, 447 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index a750be13ace8..9448d2effd8a 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
Out of alphabetical order.
>
> fsl-ls1028a-qds-13bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-13bb.dtbo
> fsl-ls1028a-qds-65bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-65bb.dtbo
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> new file mode 100644
> index 000000000000..ad57f4cca62d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
> @@ -0,0 +1,373 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2162A Clearfog
> +//
> +// Copyright 2023 Josua Mayer <josua@solid-run.com>
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a.dtsi"
> +#include "fsl-lx2162a-sr-som.dtsi"
> +
> +/ {
> + model = "SolidRun LX2162A Clearfog";
> + compatible = "solidrun,lx2162a-clearfog", "solidrun,lx2162a-som", "fsl,lx2160a";
> +
> + aliases {
> + crypto = &crypto;
> + i2c0 = &i2c0;
> + i2c1 = &i2c2;
> + i2c2 = &i2c4;
> + i2c3 = &sfp_i2c0;
> + i2c4 = &sfp_i2c1;
> + i2c5 = &sfp_i2c2;
> + i2c6 = &sfp_i2c3;
> + i2c7 = &mpcie1_i2c;
> + i2c8 = &mpcie0_i2c;
> + i2c9 = &pcieclk_i2c;
> + mmc0 = &esdhc0;
> + mmc1 = &esdhc1;
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led_sfp_at: led-sfp-at {
> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
> + default-state = "off";
> + };
Have a newline between nodes.
> + led_sfp_ab: led-sfp-ab {
> + gpios = <&gpio2 11 GPIO_ACTIVE_HIGH>; /* PROC_IRQ11 */
> + default-state = "off";
> + };
> + led_sfp_bt: led-sfp-bt {
> + gpios = <&gpio2 13 GPIO_ACTIVE_HIGH>; /* EVT1_B */
> + default-state = "off";
> + };
> + led_sfp_bb: led-sfp-bb {
> + gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* EVT2_B */
> + default-state = "off";
> + };
> + };
> +
> + sfp_at: sfp-at {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c0>;
> + mod-def0-gpios = <&gpio2 16 GPIO_ACTIVE_LOW>; /* EVT4_B */
> + maximum-power-milliwatt = <2000>;
> + };
> +
> + sfp_ab: sfp-ab {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c1>;
> + mod-def0-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; /* PROC_IRQ1 */
> + maximum-power-milliwatt = <2000>;
> + };
> +
> + sfp_bt: sfp-bt {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c2>;
> + mod-def0-gpios = <&gpio2 10 GPIO_ACTIVE_LOW>; /* PROC_IRQ10 */
> + maximum-power-milliwatt = <2000>;
> + };
> +
> + sfp_bb: sfp-bb {
> + compatible = "sff,sfp";
> + i2c-bus = <&sfp_i2c3>;
> + mod-def0-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>; /* EVT3_B */
> + maximum-power-milliwatt = <2000>;
> + };
> +};
> +
> +&i2c2 {
This label node seems out of alphabetical order.
> + status = "okay";
> +
> + /* retimer@18 */
> +
> + i2c-mux@70 {
> + compatible = "nxp,pca9546";
> + reg = <0x70>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + i2c-mux-idle-disconnect;
> +
> + sfp_i2c0: i2c@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + };
> +
> + sfp_i2c1: i2c@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + };
> +
> + sfp_i2c2: i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> + };
> +
> + sfp_i2c3: i2c@3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <3>;
> + };
> + };
> +
> + i2c-mux@71 {
> + compatible = "nxp,pca9546";
> + reg = <0x71>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + i2c-mux-idle-disconnect;
> +
> + mpcie1_i2c: i2c@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + };
> +
> + mpcie0_i2c: i2c@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + };
> +
> + pcieclk_i2c: i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> +
> + /* clock-controller@6b */
> + };
> + };
> +};
> +
> +&dpmac3 {
> + sfp = <&sfp_at>;
> + managed = "in-band-status";
> + phys = <&serdes_1 7>;
> +};
> +
> +&dpmac4 {
> + sfp = <&sfp_ab>;
> + managed = "in-band-status";
> + phys = <&serdes_1 6>;
> +};
> +
> +&dpmac5 {
> + sfp = <&sfp_bt>;
> + managed = "in-band-status";
> + phys = <&serdes_1 5>;
> +};
> +
> +&dpmac6 {
> + sfp = <&sfp_bb>;
> + managed = "in-band-status";
> + phys = <&serdes_1 4>;
> +};
> +
> +&dpmac11 {
> + phys = <&serdes_2 0>;
> + phy-handle = <ðernet_phy3>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac12 {
> + phys = <&serdes_2 1>;
> + phy-handle = <ðernet_phy1>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac13 {
> + phys = <&serdes_2 6>;
> + phy-handle = <ðernet_phy6>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac14 {
> + phys = <&serdes_2 7>;
> + phy-handle = <ðernet_phy8>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac15 {
> + phys = <&serdes_2 4>;
> + phy-handle = <ðernet_phy4>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac16 {
> + phys = <&serdes_2 5>;
> + phy-handle = <ðernet_phy2>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac17 {
> + /* override connection to on-SoM phy */
> + /delete-property/ phy-handle;
> + /delete-property/ phy-connection-type;
> +
> + phys = <&serdes_2 2>;
> + phy-handle = <ðernet_phy5>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&dpmac18 {
> + phys = <&serdes_2 3>;
> + phy-handle = <ðernet_phy7>;
> + phy-connection-type = "sgmii";
> + status = "okay";
> +};
> +
> +&emdio1 {
> + ethernet_phy1: ethernet-phy@8 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <8>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy2: ethernet-phy@9 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <9>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy3: ethernet-phy@10 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <10>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy4: ethernet-phy@11 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <11>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy5: ethernet-phy@12 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <12>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy6: ethernet-phy@13 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <13>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy7: ethernet-phy@14 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <14>;
> + max-speed = <1000>;
> + };
> +
> + ethernet_phy8: ethernet-phy@15 {
> + compatible = "ethernet-phy-ieee802.3-c45";
> + reg = <15>;
> + max-speed = <1000>;
> + };
> +};
> +
> +&esdhc0 {
> + sd-uhs-sdr104;
> + sd-uhs-sdr50;
> + sd-uhs-sdr25;
> + sd-uhs-sdr12;
> + status = "okay";
> +};
> +
> +ðernet_phy0 {
> + /*
> + * SoM has a phy at address 1 connected to SoC Ethernet Controller 1.
> + * It competes for WRIOP MAC17, and no connector has been wired.
> + */
> + status = "disabled";
> +};
> +
> +&pcie3 {
> + status = "disabled";
> +};
> +
> +&pcie4 {
> + status = "disabled";
> +};
> +
> +&pcs_mdio3 {
> + status = "okay";
> +};
> +
> +&pcs_mdio4 {
> + status = "okay";
> +};
> +
> +&pcs_mdio5 {
> + status = "okay";
> +};
> +
> +&pcs_mdio6 {
> + status = "okay";
> +};
> +
> +&pcs_mdio11 {
> + status = "okay";
> +};
> +
> +&pcs_mdio12 {
> + status = "okay";
> +};
> +
> +&pcs_mdio13 {
> + status = "okay";
> +};
> +
> +&pcs_mdio14 {
> + status = "okay";
> +};
> +
> +&pcs_mdio15 {
> + status = "okay";
> +};
> +
> +&pcs_mdio16 {
> + status = "okay";
> +};
> +
> +&pcs_mdio17 {
> + status = "okay";
> +};
> +
> +&pcs_mdio18 {
> + status = "okay";
> +};
> +
> +&serdes_1 {
> + status = "okay";
> +};
> +
> +&serdes_2 {
> + status = "okay";
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
> new file mode 100644
> index 000000000000..ac3f9bc60265
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
> @@ -0,0 +1,73 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2162A-SOM
> +//
> +// Copyright 2021 Rabeeh Khoury <rabeeh@solid-run.com>
> +// Copyright 2023 Josua Mayer <josua@solid-run.com>
> +
> +&crypto {
> + status = "okay";
> +};
> +
> +&dpmac17 {
> + phy-handle = <ðernet_phy0>;
> + phy-connection-type = "rgmii-id";
> +};
> +
> +&emdio1 {
> + status = "okay";
> +
> + ethernet_phy0: ethernet-phy@1 {
> + reg = <1>;
> + };
> +};
> +
> +&esdhc1 {
> + status = "okay";
> + bus-width = <8>;
> + mmc-hs200-1_8v;
> + mmc-hs400-1_8v;
We usually have 'status' be the last property.
Shawn
> +};
> +
> +&fspi {
> + status = "okay";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + m25p,fast-read;
> + spi-max-frequency = <50000000>;
> + /* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> + spi-rx-bus-width = <8>;
> + spi-tx-bus-width = <1>;
> + };
> +};
> +
> +&i2c0 {
> + status = "okay";
> +
> + fan-controller@18 {
> + compatible = "ti,amc6821";
> + reg = <0x18>;
> + };
> +
> + ddr_spd: eeprom@51 {
> + compatible = "st,24c02", "atmel,24c02";
> + reg = <0x51>;
> + read-only;
> + };
> +
> + config_eeprom: eeprom@57 {
> + compatible = "st,24c02", "atmel,24c02";
> + reg = <0x57>;
> + };
> +};
> +
> +&i2c4 {
> + status = "okay";
> +
> + variable_eeprom: eeprom@54 {
> + compatible = "st,24c2048", "atmel,24c2048";
> + reg = <0x54>;
> + };
> +};
> --
> 2.35.3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
2023-09-24 13:51 ` Shawn Guo
@ 2023-10-01 10:21 ` Josua Mayer
-1 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-10-01 10:21 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, linux-kernel, linux-arm-kernel, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Li Yang, Philippe Schenker,
Fabio Estevam, Aishwarya Kothari, Marco Felsch, Tim Harvey,
Frieder Schrempf, Marek Vasut, Marcel Ziswiler, Alexander Stein
Hi Shawn,
Thank you for the review.
@all - some of you have received this email including HTML,
this is attempted resend as plain text ...
Am 24.09.23 um 15:51 schrieb Shawn Guo:
> On Fri, Aug 18, 2023 at 01:10:16PM +0200, Josua Mayer wrote:
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
>> index a750be13ace8..9448d2effd8a 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
> Out of alphabetical order.
Ack.
>> +
>> + led_sfp_at: led-sfp-at {
>> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
>> + default-state = "off";
>> + };
> Have a newline between nodes.
Ack.
>> +&i2c2 {
> This label node seems out of alphabetical order.
Ack.
>> +&esdhc1 {
>> + status = "okay";
>> + bus-width = <8>;
>> + mmc-hs200-1_8v;
>> + mmc-hs400-1_8v;
> We usually have 'status' be the last property.
You are not the first to notice this, but somehow in each version I
forgot about changing it :(.
v6 will for sure put this status property in last place!
> Shawn
sincerely
Josua Mayer
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
@ 2023-10-01 10:21 ` Josua Mayer
0 siblings, 0 replies; 16+ messages in thread
From: Josua Mayer @ 2023-10-01 10:21 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, linux-kernel, linux-arm-kernel, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Li Yang, Philippe Schenker,
Fabio Estevam, Aishwarya Kothari, Marco Felsch, Tim Harvey,
Frieder Schrempf, Marek Vasut, Marcel Ziswiler, Alexander Stein
Hi Shawn,
Thank you for the review.
@all - some of you have received this email including HTML,
this is attempted resend as plain text ...
Am 24.09.23 um 15:51 schrieb Shawn Guo:
> On Fri, Aug 18, 2023 at 01:10:16PM +0200, Josua Mayer wrote:
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
>> index a750be13ace8..9448d2effd8a 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
> Out of alphabetical order.
Ack.
>> +
>> + led_sfp_at: led-sfp-at {
>> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
>> + default-state = "off";
>> + };
> Have a newline between nodes.
Ack.
>> +&i2c2 {
> This label node seems out of alphabetical order.
Ack.
>> +&esdhc1 {
>> + status = "okay";
>> + bus-width = <8>;
>> + mmc-hs200-1_8v;
>> + mmc-hs400-1_8v;
> We usually have 'status' be the last property.
You are not the first to notice this, but somehow in each version I
forgot about changing it :(.
v6 will for sure put this status property in last place!
> Shawn
sincerely
Josua Mayer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread