* [PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR
@ 2023-08-08 13:42 Elena Popa
2023-08-08 14:01 ` Tom Rini
2023-08-18 17:50 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Elena Popa @ 2023-08-08 13:42 UTC (permalink / raw)
To: u-boot, Tom Rini; +Cc: Marek Vasut, Simon Glass, Elena Popa
When Falcon Mode is enabled, SPL needs to check the value of
CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Unfortunately, it was using the
CONFIG_VAL(SYS_MMCSD_RAW_MODE_ARGS_SECTOR) which converts it into
CONFIG_SPL_SYS_MMCSD_RAW_MODE_ARGS_SECTOR when CONFIG_SPL_BUILD is
enabled. CONFIG_SPL_SYS_MMCSD_RAW_MODE_ARGS_SECTOR does not exist in
common/spl/Kconfig. Replaced with
defined(CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR).
Signed-off-by: Elena Popa <elena.popa@nxp.com>
---
common/spl/spl_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
index a665091b00..20f687e138 100644
--- a/common/spl/spl_mmc.c
+++ b/common/spl/spl_mmc.c
@@ -229,7 +229,7 @@ static int mmc_load_image_raw_os(struct spl_image_info *spl_image,
{
int ret;
-#if CONFIG_VAL(SYS_MMCSD_RAW_MODE_ARGS_SECTOR)
+#if defined(CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR)
unsigned long count;
count = blk_dread(mmc_get_blk_desc(mmc),
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR
2023-08-08 13:42 [PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR Elena Popa
@ 2023-08-08 14:01 ` Tom Rini
2023-08-18 17:50 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2023-08-08 14:01 UTC (permalink / raw)
To: Elena Popa; +Cc: u-boot, Marek Vasut, Simon Glass
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Tue, Aug 08, 2023 at 04:42:15PM +0300, Elena Popa wrote:
> When Falcon Mode is enabled, SPL needs to check the value of
> CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Unfortunately, it was using the
> CONFIG_VAL(SYS_MMCSD_RAW_MODE_ARGS_SECTOR) which converts it into
> CONFIG_SPL_SYS_MMCSD_RAW_MODE_ARGS_SECTOR when CONFIG_SPL_BUILD is
> enabled. CONFIG_SPL_SYS_MMCSD_RAW_MODE_ARGS_SECTOR does not exist in
> common/spl/Kconfig. Replaced with
> defined(CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR).
>
> Signed-off-by: Elena Popa <elena.popa@nxp.com>
Thanks!
Fixes: 103d1aecb0b9 ("Convert CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR et al to Kconfig")
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR
2023-08-08 13:42 [PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR Elena Popa
2023-08-08 14:01 ` Tom Rini
@ 2023-08-18 17:50 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2023-08-18 17:50 UTC (permalink / raw)
To: Elena Popa; +Cc: u-boot, Marek Vasut, Simon Glass
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Tue, Aug 08, 2023 at 04:42:15PM +0300, Elena Popa wrote:
> When Falcon Mode is enabled, SPL needs to check the value of
> CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Unfortunately, it was using the
> CONFIG_VAL(SYS_MMCSD_RAW_MODE_ARGS_SECTOR) which converts it into
> CONFIG_SPL_SYS_MMCSD_RAW_MODE_ARGS_SECTOR when CONFIG_SPL_BUILD is
> enabled. CONFIG_SPL_SYS_MMCSD_RAW_MODE_ARGS_SECTOR does not exist in
> common/spl/Kconfig. Replaced with
> defined(CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR).
>
> Signed-off-by: Elena Popa <elena.popa@nxp.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-18 17:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-08 13:42 [PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR Elena Popa
2023-08-08 14:01 ` Tom Rini
2023-08-18 17:50 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.