[PATCH v1] pinctrl: cherryview: use ACPI_HANDLE() to pass handle

[PATCH v1] pinctrl: cherryview: use ACPI_HANDLE() to pass handle

[Raag Jadav]

Use ACPI_HANDLE() to pass handle to acpi_*_address_space_handler() APIs.

Fixes: a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index 2c619fcf93ca..5a50bee48873 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1650,7 +1650,6 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
 	struct intel_community_context *cctx;
 	struct intel_community *community;
 	struct device *dev = &pdev->dev;
-	struct acpi_device *adev = ACPI_COMPANION(dev);
 	struct intel_pinctrl *pctrl;
 	acpi_status status;
 	unsigned int i;
@@ -1718,7 +1717,7 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	status = acpi_install_address_space_handler(adev->handle,
+	status = acpi_install_address_space_handler(ACPI_HANDLE(dev),
 					community->acpi_space_id,
 					chv_pinctrl_mmio_access_handler,
 					NULL, pctrl);
@@ -1735,7 +1734,7 @@ static int chv_pinctrl_remove(struct platform_device *pdev)
 	struct intel_pinctrl *pctrl = platform_get_drvdata(pdev);
 	const struct intel_community *community = &pctrl->communities[0];
 
-	acpi_remove_address_space_handler(ACPI_COMPANION(&pdev->dev),
+	acpi_remove_address_space_handler(ACPI_HANDLE(&pdev->dev),
 					  community->acpi_space_id,
 					  chv_pinctrl_mmio_access_handler);
 
-- 
2.17.1

Re: [PATCH v1] pinctrl: cherryview: use ACPI_HANDLE() to pass handle

[Mika Westerberg]

On Mon, Aug 21, 2023 at 12:00:02PM +0530, Raag Jadav wrote:
> Use ACPI_HANDLE() to pass handle to acpi_*_address_space_handler() APIs.

Please explain here that this actually fixes a bug on the remove path
where we pass an incorrect pointer. Please adjust the $subject
accordingly.

> Fixes: a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")

Add also Cc: stable@vger.kernel.org