[PATCH v2 1/1] serial: core: Remove unused PORT_* definitions

[PATCH v2 1/1] serial: core: Remove unused PORT_* definitions

[Andy Shevchenko]

For the last couple of years Linux kernel got rid of a few architectures
and many platforms. Hence some PORT_* definitions in the serial_core.h
become unused and redundant. Remove them for good.

Removed IDs are checked for users against Debian Code Search engine.
Hence safe to remove as there are no consumers found (only providers).

While at it, add a note about 0-13, that are defined in the other file.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: tested via DCS (Greg), dropped 1 change due to that, added a note for 0-13
 include/uapi/linux/serial_core.h | 43 +++-----------------------------
 1 file changed, 3 insertions(+), 40 deletions(-)

diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
index 281fa286555c..d19dabd2c20d 100644
--- a/include/uapi/linux/serial_core.h
+++ b/include/uapi/linux/serial_core.h
@@ -25,6 +25,8 @@
 
 /*
  * The type definitions.  These are from Ted Ts'o's serial.h
+ * By historical reasons the values from 0 to 13 are defined
+ * in the include/uapi/linux/serial.h, do not define them here.
  */
 #define PORT_NS16550A	14
 #define PORT_XSCALE	15
@@ -94,15 +96,9 @@
 #define PORT_SCIF	53
 #define PORT_IRDA	54
 
-/* Samsung S3C2410 SoC and derivatives thereof */
-#define PORT_S3C2410    55
-
 /* SGI IP22 aka Indy / Challenge S / Indigo 2 */
 #define PORT_IP22ZILOG	56
 
-/* Sharp LH7a40x -- an ARM9 SoC series */
-#define PORT_LH7A40X	57
-
 /* PPC CPM type number */
 #define PORT_CPM        58
 
@@ -112,51 +108,27 @@
 /* IBM icom */
 #define PORT_ICOM	60
 
-/* Samsung S3C2440 SoC */
-#define PORT_S3C2440	61
-
 /* Motorola i.MX SoC */
 #define PORT_IMX	62
 
-/* Marvell MPSC (obsolete unused) */
-#define PORT_MPSC	63
-
 /* TXX9 type number */
 #define PORT_TXX9	64
 
-/* Samsung S3C2400 SoC */
-#define PORT_S3C2400	67
-
-/* M32R SIO */
-#define PORT_M32R_SIO	68
-
 /*Digi jsm */
 #define PORT_JSM        69
 
 /* SUN4V Hypervisor Console */
 #define PORT_SUNHV	72
 
-#define PORT_S3C2412	73
-
 /* Xilinx uartlite */
 #define PORT_UARTLITE	74
 
-/* Blackfin bf5xx */
-#define PORT_BFIN	75
-
 /* Broadcom SB1250, etc. SOC */
 #define PORT_SB1250_DUART	77
 
 /* Freescale ColdFire */
 #define PORT_MCF	78
 
-/* Blackfin SPORT */
-#define PORT_BFIN_SPORT		79
-
-/* MN10300 on-chip UART numbers */
-#define PORT_MN10300		80
-#define PORT_MN10300_CTS	81
-
 #define PORT_SC26XX	82
 
 /* SH-SCI */
@@ -164,9 +136,6 @@
 
 #define PORT_S3C6400	84
 
-/* NWPSERIAL, now removed */
-#define PORT_NWPSERIAL	85
-
 /* MAX3100 */
 #define PORT_MAX3100    86
 
@@ -225,13 +194,10 @@
 /* ST ASC type numbers */
 #define PORT_ASC       105
 
-/* Tilera TILE-Gx UART */
-#define PORT_TILEGX	106
-
 /* MEN 16z135 UART */
 #define PORT_MEN_Z135	107
 
-/* SC16IS74xx */
+/* SC16IS7xx */
 #define PORT_SC16IS7XX   108
 
 /* MESON */
@@ -243,9 +209,6 @@
 /* SPRD SERIAL  */
 #define PORT_SPRD	111
 
-/* Cris v10 / v32 SoC */
-#define PORT_CRIS	112
-
 /* STM32 USART */
 #define PORT_STM32	113
 
-- 
2.40.0.1.gaa8946217a0b

Re: [PATCH v2 1/1] serial: core: Remove unused PORT_* definitions

[Greg Kroah-Hartman]

On Mon, Aug 21, 2023 at 11:38:57AM +0300, Andy Shevchenko wrote:
> For the last couple of years Linux kernel got rid of a few architectures
> and many platforms. Hence some PORT_* definitions in the serial_core.h
> become unused and redundant. Remove them for good.
> 
> Removed IDs are checked for users against Debian Code Search engine.
> Hence safe to remove as there are no consumers found (only providers).
> 
> While at it, add a note about 0-13, that are defined in the other file.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: tested via DCS (Greg), dropped 1 change due to that, added a note for 0-13
>  include/uapi/linux/serial_core.h | 43 +++-----------------------------
>  1 file changed, 3 insertions(+), 40 deletions(-)

You forgot to cc linux-serial@vger :)

I'll take this now, thanks for cleaning this up.  Hopefully we can
resist the urge to add new ids here.

greg k-h

Re: [PATCH v2 1/1] serial: core: Remove unused PORT_* definitions

[Andy Shevchenko]

On Tue, Aug 22, 2023 at 02:59:37PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 21, 2023 at 11:38:57AM +0300, Andy Shevchenko wrote:
> > For the last couple of years Linux kernel got rid of a few architectures
> > and many platforms. Hence some PORT_* definitions in the serial_core.h
> > become unused and redundant. Remove them for good.
> > 
> > Removed IDs are checked for users against Debian Code Search engine.
> > Hence safe to remove as there are no consumers found (only providers).
> > 
> > While at it, add a note about 0-13, that are defined in the other file.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v2: tested via DCS (Greg), dropped 1 change due to that, added a note for 0-13
> >  include/uapi/linux/serial_core.h | 43 +++-----------------------------
> >  1 file changed, 3 insertions(+), 40 deletions(-)
> 
> You forgot to cc linux-serial@vger :)

Oh, that's because I cooked this patch against v6.5-rcX, where X < 7, and hence
the 238500e2d67c ("MAINTAINERS: Merge TTY layer and serial drivers") is absent.

> I'll take this now, thanks for cleaning this up.  Hopefully we can
> resist the urge to add new ids here.

Thank you!

I want to compress the list based on DCS research, it seems feasible and may
shrink a lot of memory at run-time for the port structure. Let me check that.

-- 
With Best Regards,
Andy Shevchenko