* [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function
@ 2023-08-21 8:41 Zhengchao Shao
2023-08-22 7:18 ` Simon Horman
2023-08-22 13:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Zhengchao Shao @ 2023-08-21 8:41 UTC (permalink / raw)
To: netdev, davem, edumazet, kuba, pabeni, steffen.klassert, herbert,
dsahern
Cc: eyal.birger, paulmck, joel, tglx, mbizon, jmaxwell37,
weiyongjun1, yuehaibing, shaozhengchao
When the ifdown function in the dst_ops structure is referenced, the input
parameter 'how' is always true. In the current implementation of the
ifdown interface, ip6_dst_ifdown does not use the input parameter 'how',
xfrm6_dst_ifdown and xfrm4_dst_ifdown functions use the input parameter
'unregister'. But false judgment on 'unregister' in xfrm6_dst_ifdown and
xfrm4_dst_ifdown is false, so remove the input parameter 'how' in ifdown
function.
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
include/net/dst_ops.h | 2 +-
net/core/dst.c | 2 +-
net/ipv4/xfrm4_policy.c | 11 +----------
net/ipv6/route.c | 5 ++---
net/ipv6/xfrm6_policy.c | 6 +-----
5 files changed, 6 insertions(+), 20 deletions(-)
diff --git a/include/net/dst_ops.h b/include/net/dst_ops.h
index 632086b2f644..6d1c8541183d 100644
--- a/include/net/dst_ops.h
+++ b/include/net/dst_ops.h
@@ -23,7 +23,7 @@ struct dst_ops {
u32 * (*cow_metrics)(struct dst_entry *, unsigned long);
void (*destroy)(struct dst_entry *);
void (*ifdown)(struct dst_entry *,
- struct net_device *dev, int how);
+ struct net_device *dev);
struct dst_entry * (*negative_advice)(struct dst_entry *);
void (*link_failure)(struct sk_buff *);
void (*update_pmtu)(struct dst_entry *dst, struct sock *sk,
diff --git a/net/core/dst.c b/net/core/dst.c
index 79d9306ad1ee..980e2fd2f013 100644
--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -152,7 +152,7 @@ void dst_dev_put(struct dst_entry *dst)
dst->obsolete = DST_OBSOLETE_DEAD;
if (dst->ops->ifdown)
- dst->ops->ifdown(dst, dev, true);
+ dst->ops->ifdown(dst, dev);
dst->input = dst_discard;
dst->output = dst_discard_out;
dst->dev = blackhole_netdev;
diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c
index 57ea394ffa8c..c33bca2c3841 100644
--- a/net/ipv4/xfrm4_policy.c
+++ b/net/ipv4/xfrm4_policy.c
@@ -124,22 +124,13 @@ static void xfrm4_dst_destroy(struct dst_entry *dst)
xfrm_dst_destroy(xdst);
}
-static void xfrm4_dst_ifdown(struct dst_entry *dst, struct net_device *dev,
- int unregister)
-{
- if (!unregister)
- return;
-
- xfrm_dst_ifdown(dst, dev);
-}
-
static struct dst_ops xfrm4_dst_ops_template = {
.family = AF_INET,
.update_pmtu = xfrm4_update_pmtu,
.redirect = xfrm4_redirect,
.cow_metrics = dst_cow_metrics_generic,
.destroy = xfrm4_dst_destroy,
- .ifdown = xfrm4_dst_ifdown,
+ .ifdown = xfrm_dst_ifdown,
.local_out = __ip_local_out,
.gc_thresh = 32768,
};
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 6b46abe0b7da..e82bcfde5bf9 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -90,7 +90,7 @@ unsigned int ip6_mtu(const struct dst_entry *dst);
static struct dst_entry *ip6_negative_advice(struct dst_entry *);
static void ip6_dst_destroy(struct dst_entry *);
static void ip6_dst_ifdown(struct dst_entry *,
- struct net_device *dev, int how);
+ struct net_device *dev);
static void ip6_dst_gc(struct dst_ops *ops);
static int ip6_pkt_discard(struct sk_buff *skb);
@@ -371,8 +371,7 @@ static void ip6_dst_destroy(struct dst_entry *dst)
fib6_info_release(from);
}
-static void ip6_dst_ifdown(struct dst_entry *dst, struct net_device *dev,
- int how)
+static void ip6_dst_ifdown(struct dst_entry *dst, struct net_device *dev)
{
struct rt6_info *rt = (struct rt6_info *)dst;
struct inet6_dev *idev = rt->rt6i_idev;
diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
index 8f931e46b460..41a680c76d2e 100644
--- a/net/ipv6/xfrm6_policy.c
+++ b/net/ipv6/xfrm6_policy.c
@@ -124,14 +124,10 @@ static void xfrm6_dst_destroy(struct dst_entry *dst)
xfrm_dst_destroy(xdst);
}
-static void xfrm6_dst_ifdown(struct dst_entry *dst, struct net_device *dev,
- int unregister)
+static void xfrm6_dst_ifdown(struct dst_entry *dst, struct net_device *dev)
{
struct xfrm_dst *xdst;
- if (!unregister)
- return;
-
xdst = (struct xfrm_dst *)dst;
if (xdst->u.rt6.rt6i_idev->dev == dev) {
struct inet6_dev *loopback_idev =
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function
2023-08-21 8:41 [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function Zhengchao Shao
@ 2023-08-22 7:18 ` Simon Horman
2023-08-22 13:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-08-22 7:18 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, davem, edumazet, kuba, pabeni, steffen.klassert, herbert,
dsahern, eyal.birger, paulmck, joel, tglx, mbizon, jmaxwell37,
weiyongjun1, yuehaibing
On Mon, Aug 21, 2023 at 04:41:04PM +0800, Zhengchao Shao wrote:
> When the ifdown function in the dst_ops structure is referenced, the input
> parameter 'how' is always true. In the current implementation of the
> ifdown interface, ip6_dst_ifdown does not use the input parameter 'how',
> xfrm6_dst_ifdown and xfrm4_dst_ifdown functions use the input parameter
> 'unregister'. But false judgment on 'unregister' in xfrm6_dst_ifdown and
> xfrm4_dst_ifdown is false, so remove the input parameter 'how' in ifdown
> function.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function
2023-08-21 8:41 [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function Zhengchao Shao
2023-08-22 7:18 ` Simon Horman
@ 2023-08-22 13:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-22 13:10 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, davem, edumazet, kuba, pabeni, steffen.klassert, herbert,
dsahern, eyal.birger, paulmck, joel, tglx, mbizon, jmaxwell37,
weiyongjun1, yuehaibing
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 21 Aug 2023 16:41:04 +0800 you wrote:
> When the ifdown function in the dst_ops structure is referenced, the input
> parameter 'how' is always true. In the current implementation of the
> ifdown interface, ip6_dst_ifdown does not use the input parameter 'how',
> xfrm6_dst_ifdown and xfrm4_dst_ifdown functions use the input parameter
> 'unregister'. But false judgment on 'unregister' in xfrm6_dst_ifdown and
> xfrm4_dst_ifdown is false, so remove the input parameter 'how' in ifdown
> function.
>
> [...]
Here is the summary with links:
- [net-next] net: remove unnecessary input parameter 'how' in ifdown function
https://git.kernel.org/netdev/net-next/c/43c2817225fc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-22 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21 8:41 [PATCH net-next] net: remove unnecessary input parameter 'how' in ifdown function Zhengchao Shao
2023-08-22 7:18 ` Simon Horman
2023-08-22 13:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.