From: "Darrick J. Wong" <djwong@kernel.org> To: Matthew Wilcox <willy@infradead.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Andrew Morton <akpm@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List <linux-next@vger.kernel.org>, Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org Subject: Re: linux-next: build failure after merge of the mm tree Date: Mon, 21 Aug 2023 21:00:43 -0700 [thread overview] Message-ID: <20230822040043.GB11263@frogsfrogsfrogs> (raw) In-Reply-To: <ZOQQjmxeLM920/Q/@casper.infradead.org> On Tue, Aug 22, 2023 at 02:34:06AM +0100, Matthew Wilcox wrote: > On Tue, Aug 22, 2023 at 11:22:17AM +1000, Stephen Rothwell wrote: > > Hi Matthew, > > > > On Tue, 22 Aug 2023 02:11:44 +0100 Matthew Wilcox <willy@infradead.org> wrote: > > > > > > On Tue, Aug 22, 2023 at 09:55:37AM +1000, Stephen Rothwell wrote: > > > > In file included from include/trace/trace_events.h:27, > > > > from include/trace/define_trace.h:102, > > > > from fs/xfs/xfs_trace.h:4428, > > > > from fs/xfs/xfs_trace.c:45: > > > > include/linux/pgtable.h:8:25: error: initializer element is not constant > > > > 8 | #define PMD_ORDER (PMD_SHIFT - PAGE_SHIFT) > > > > > > Ummm. PowerPC doesn't have a compile-time constant PMD size? > > > > Yeah, you are not the first (or probably the last) to be caught by that. > > I think this will do the trick. Any comments? > > diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h > index 1904eaf7a2e9..d5a4e6c2dcd1 100644 > --- a/fs/xfs/xfs_trace.h > +++ b/fs/xfs/xfs_trace.h > @@ -796,15 +796,6 @@ DEFINE_INODE_EVENT(xfs_inode_reclaiming); > DEFINE_INODE_EVENT(xfs_inode_set_need_inactive); > DEFINE_INODE_EVENT(xfs_inode_inactivating); > > -/* > - * ftrace's __print_symbolic requires that all enum values be wrapped in the > - * TRACE_DEFINE_ENUM macro so that the enum value can be encoded in the ftrace > - * ring buffer. Somehow this was only worth mentioning in the ftrace sample > - * code. > - */ Please leave this ^^^ comment, because the need for TRACE_DEFINE_ENUM to make enums work in tracepoints is not at all obvious. > -TRACE_DEFINE_ENUM(PMD_ORDER); > -TRACE_DEFINE_ENUM(PUD_ORDER); > - > TRACE_DEFINE_ENUM(XFS_REFC_DOMAIN_SHARED); > TRACE_DEFINE_ENUM(XFS_REFC_DOMAIN_COW); > > @@ -823,13 +814,10 @@ TRACE_EVENT(xfs_filemap_fault, > __entry->order = order; > __entry->write_fault = write_fault; > ), > - TP_printk("dev %d:%d ino 0x%llx %s write_fault %d", > + TP_printk("dev %d:%d ino 0x%llx order:%u write_fault %d", "order %u" to match the (non dev_t) style of the rest of the xfs tracepoints. --D > MAJOR(__entry->dev), MINOR(__entry->dev), > __entry->ino, > - __print_symbolic(__entry->order, > - { 0, "PTE" }, > - { PMD_ORDER, "PMD" }, > - { PUD_ORDER, "PUD" }), > + __entry->order, > __entry->write_fault) > ) > > >
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@kernel.org> To: Matthew Wilcox <willy@infradead.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Nicholas Piggin <npiggin@gmail.com>, linux-xfs@vger.kernel.org, Linux Next Mailing List <linux-next@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, linuxppc-dev@lists.ozlabs.org Subject: Re: linux-next: build failure after merge of the mm tree Date: Mon, 21 Aug 2023 21:00:43 -0700 [thread overview] Message-ID: <20230822040043.GB11263@frogsfrogsfrogs> (raw) In-Reply-To: <ZOQQjmxeLM920/Q/@casper.infradead.org> On Tue, Aug 22, 2023 at 02:34:06AM +0100, Matthew Wilcox wrote: > On Tue, Aug 22, 2023 at 11:22:17AM +1000, Stephen Rothwell wrote: > > Hi Matthew, > > > > On Tue, 22 Aug 2023 02:11:44 +0100 Matthew Wilcox <willy@infradead.org> wrote: > > > > > > On Tue, Aug 22, 2023 at 09:55:37AM +1000, Stephen Rothwell wrote: > > > > In file included from include/trace/trace_events.h:27, > > > > from include/trace/define_trace.h:102, > > > > from fs/xfs/xfs_trace.h:4428, > > > > from fs/xfs/xfs_trace.c:45: > > > > include/linux/pgtable.h:8:25: error: initializer element is not constant > > > > 8 | #define PMD_ORDER (PMD_SHIFT - PAGE_SHIFT) > > > > > > Ummm. PowerPC doesn't have a compile-time constant PMD size? > > > > Yeah, you are not the first (or probably the last) to be caught by that. > > I think this will do the trick. Any comments? > > diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h > index 1904eaf7a2e9..d5a4e6c2dcd1 100644 > --- a/fs/xfs/xfs_trace.h > +++ b/fs/xfs/xfs_trace.h > @@ -796,15 +796,6 @@ DEFINE_INODE_EVENT(xfs_inode_reclaiming); > DEFINE_INODE_EVENT(xfs_inode_set_need_inactive); > DEFINE_INODE_EVENT(xfs_inode_inactivating); > > -/* > - * ftrace's __print_symbolic requires that all enum values be wrapped in the > - * TRACE_DEFINE_ENUM macro so that the enum value can be encoded in the ftrace > - * ring buffer. Somehow this was only worth mentioning in the ftrace sample > - * code. > - */ Please leave this ^^^ comment, because the need for TRACE_DEFINE_ENUM to make enums work in tracepoints is not at all obvious. > -TRACE_DEFINE_ENUM(PMD_ORDER); > -TRACE_DEFINE_ENUM(PUD_ORDER); > - > TRACE_DEFINE_ENUM(XFS_REFC_DOMAIN_SHARED); > TRACE_DEFINE_ENUM(XFS_REFC_DOMAIN_COW); > > @@ -823,13 +814,10 @@ TRACE_EVENT(xfs_filemap_fault, > __entry->order = order; > __entry->write_fault = write_fault; > ), > - TP_printk("dev %d:%d ino 0x%llx %s write_fault %d", > + TP_printk("dev %d:%d ino 0x%llx order:%u write_fault %d", "order %u" to match the (non dev_t) style of the rest of the xfs tracepoints. --D > MAJOR(__entry->dev), MINOR(__entry->dev), > __entry->ino, > - __print_symbolic(__entry->order, > - { 0, "PTE" }, > - { PMD_ORDER, "PMD" }, > - { PUD_ORDER, "PUD" }), > + __entry->order, > __entry->write_fault) > ) > > >
next prev parent reply other threads:[~2023-08-22 4:00 UTC|newest] Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-21 23:55 linux-next: build failure after merge of the mm tree Stephen Rothwell 2023-08-22 1:11 ` Matthew Wilcox 2023-08-22 1:11 ` Matthew Wilcox 2023-08-22 1:22 ` Stephen Rothwell 2023-08-22 1:22 ` Stephen Rothwell 2023-08-22 1:34 ` Matthew Wilcox 2023-08-22 1:34 ` Matthew Wilcox 2023-08-22 4:00 ` Darrick J. Wong [this message] 2023-08-22 4:00 ` Darrick J. Wong 2023-08-22 20:20 ` Matthew Wilcox 2023-08-22 20:20 ` Matthew Wilcox 2023-08-22 7:12 ` Michael Ellerman 2023-08-22 7:12 ` Michael Ellerman -- strict thread matches above, loose matches on Subject: below -- 2024-04-30 0:38 Stephen Rothwell 2024-04-30 2:23 ` Lance Yang 2024-04-23 0:22 Stephen Rothwell 2024-04-12 6:39 Stephen Rothwell 2024-04-11 23:14 Stephen Rothwell 2024-04-07 23:15 Stephen Rothwell 2024-04-08 1:44 ` Barry Song 2024-04-05 2:55 Stephen Rothwell 2024-03-28 4:34 Stephen Rothwell 2024-03-05 4:26 Stephen Rothwell 2024-03-05 6:39 ` Qi Zheng 2024-02-14 3:57 Stephen Rothwell 2024-02-14 15:19 ` Andrew Morton 2024-02-15 3:47 ` Stephen Rothwell 2024-02-07 6:17 Stephen Rothwell 2024-02-01 2:57 Stephen Rothwell 2024-02-01 8:35 ` Marco Elver 2024-01-25 3:29 Stephen Rothwell 2024-01-25 14:29 ` Baoquan He 2024-01-25 18:03 ` Stephen Rothwell 2024-01-24 23:23 Stephen Rothwell 2024-01-24 23:52 ` Suren Baghdasaryan 2024-01-25 2:40 ` Baoquan He 2024-01-23 23:05 Stephen Rothwell 2024-01-23 23:14 ` Suren Baghdasaryan 2023-12-21 7:38 Stephen Rothwell 2023-12-21 7:45 ` Changbin Du 2023-11-28 21:45 Stephen Rothwell 2023-11-28 22:45 ` Andrew Morton 2023-11-29 8:17 ` Dmitry Rokosov 2023-11-30 22:12 ` Stephen Rothwell 2023-11-27 3:44 Stephen Rothwell 2023-12-22 0:16 ` Stephen Rothwell 2023-12-22 6:26 ` Andrew Morton 2023-11-27 2:28 Stephen Rothwell 2023-11-27 3:48 ` Stephen Rothwell 2023-11-27 3:48 ` Stephen Rothwell 2023-11-30 22:04 ` Stephen Rothwell 2023-11-30 22:04 ` Stephen Rothwell 2023-11-30 22:32 ` Andrew Morton 2023-11-30 22:32 ` Andrew Morton 2023-11-30 22:39 ` Michael Ellerman 2023-11-30 22:39 ` Michael Ellerman 2023-11-30 22:52 ` Andrew Morton 2023-11-30 22:52 ` Andrew Morton 2023-12-01 3:12 ` Michael Ellerman 2023-12-01 3:12 ` Michael Ellerman 2023-12-07 12:38 ` Michael Ellerman 2023-10-03 22:50 Stephen Rothwell 2023-09-27 23:22 Stephen Rothwell 2023-09-28 6:47 ` Arnd Bergmann 2023-09-25 23:18 Stephen Rothwell 2023-08-22 22:52 Stephen Rothwell 2023-08-08 4:40 Stephen Rothwell 2023-08-08 15:20 ` Eric DeVolder 2023-08-11 17:16 ` Eric DeVolder 2023-07-26 5:14 Stephen Rothwell 2023-07-26 13:22 ` Kuan-Ying Lee (李冠穎) 2023-07-26 4:53 Stephen Rothwell 2023-07-26 5:22 ` Aneesh Kumar K.V 2023-07-26 6:51 ` Stephen Rothwell 2023-07-19 4:32 Stephen Rothwell 2023-07-19 5:55 ` Alistair Popple 2023-07-18 0:02 Stephen Rothwell 2023-07-18 13:43 ` Andy Shevchenko 2023-07-18 17:34 ` Andrew Morton 2023-07-18 21:07 ` Andy Shevchenko 2023-07-17 23:40 Stephen Rothwell 2023-07-04 2:23 Stephen Rothwell 2023-07-04 2:32 ` Linus Torvalds 2023-07-04 5:51 ` Suren Baghdasaryan 2023-06-13 6:21 Stephen Rothwell 2023-06-13 6:21 ` Stephen Rothwell 2023-06-13 15:58 ` Catalin Marinas 2023-06-13 15:58 ` Catalin Marinas 2023-05-19 2:43 Stephen Rothwell 2023-05-19 8:19 ` Arnd Bergmann 2023-05-17 23:59 Stephen Rothwell 2023-03-06 2:54 Stephen Rothwell 2023-03-06 3:13 ` Andrew Morton 2023-03-06 0:52 Stephen Rothwell 2023-03-06 21:58 ` Stephen Rothwell 2023-02-07 4:37 Stephen Rothwell 2023-02-07 12:17 ` Jason Gunthorpe 2023-02-08 2:41 ` Stephen Rothwell 2023-02-07 14:25 ` David Howells 2023-01-30 5:14 Stephen Rothwell 2023-01-30 8:09 ` Christian Brauner 2023-02-26 22:18 ` Stephen Rothwell 2023-02-27 10:36 ` Christian Brauner 2023-01-27 6:36 Stephen Rothwell 2023-01-27 6:16 Stephen Rothwell 2023-01-27 6:16 ` Stephen Rothwell 2023-01-27 5:59 Stephen Rothwell 2023-01-27 13:11 ` Jan Kara 2023-01-31 21:47 ` Stephen Rothwell 2023-02-24 4:40 ` Stephen Rothwell 2023-02-24 6:01 ` Linus Torvalds 2023-02-24 20:36 ` Stephen Rothwell 2023-01-25 3:05 Stephen Rothwell 2022-12-16 1:26 Stephen Rothwell 2022-12-16 3:04 ` Andrew Morton 2022-12-16 0:21 Stephen Rothwell 2022-12-16 0:35 ` Andrew Morton 2022-12-16 1:03 ` Masami Hiramatsu 2022-11-22 6:53 Stephen Rothwell 2022-11-22 10:31 ` David Hildenbrand 2022-11-03 5:02 Stephen Rothwell 2022-11-02 3:55 Stephen Rothwell 2022-11-02 21:26 ` Andrew Morton 2022-10-18 1:24 Stephen Rothwell 2022-09-23 8:12 Stephen Rothwell 2022-09-23 8:15 ` David Hildenbrand 2022-09-23 7:55 Stephen Rothwell 2022-09-23 9:50 ` Michael Walle 2022-09-23 11:01 ` Naoya Horiguchi 2022-09-15 7:07 Stephen Rothwell 2022-09-15 16:37 ` Mike Kravetz 2022-09-15 20:06 ` Andrew Morton 2022-09-06 11:03 Stephen Rothwell 2022-09-06 12:05 ` Rob Clark 2022-09-06 18:05 ` Stephen Rothwell 2022-08-26 7:10 Stephen Rothwell 2022-08-26 7:32 ` Michal Hocko 2022-07-08 9:44 Stephen Rothwell 2022-07-08 15:17 ` Darrick J. Wong 2022-07-10 22:28 ` Stephen Rothwell 2022-05-12 9:38 Stephen Rothwell 2022-05-12 10:13 ` Baolin Wang 2022-05-12 11:07 ` Catalin Marinas 2022-05-12 11:13 ` Baolin Wang 2022-05-12 13:28 ` Catalin Marinas 2022-05-12 19:10 ` Andrew Morton 2022-05-13 7:18 ` Stephen Rothwell 2022-05-11 8:15 Stephen Rothwell 2022-05-11 8:27 ` Baolin Wang 2022-05-11 8:42 ` Baolin Wang 2022-05-11 23:28 ` Stephen Rothwell 2022-05-10 11:25 Stephen Rothwell 2022-05-05 21:37 Stephen Rothwell 2022-05-02 10:49 Stephen Rothwell 2022-05-02 11:19 ` Matthew Wilcox 2022-05-03 6:45 ` Stephen Rothwell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230822040043.GB11263@frogsfrogsfrogs \ --to=djwong@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=christophe.leroy@csgroup.eu \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ --cc=sfr@canb.auug.org.au \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.