* [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
@ 2023-08-30 7:44 ` coolrrsh
0 siblings, 0 replies; 8+ messages in thread
From: coolrrsh @ 2023-08-30 7:44 UTC (permalink / raw)
To: hverkuil, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, syzbot+e27f3dbdab04e43b9f73
From: Rajeshwar R Shinde <coolrrsh@gmail.com>
Syzkaller reported the following issue:
UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
shift exponent 245 is too large for 32-bit type 'int'
When the value of the variable "sd->params.exposure.gain" exceeds the
number of bits in an integer, a shift-out-of-bounds error is reported. It
is triggered because the variable "currentexp" cannot be left-shifted by
more than the number of bits in an integer. In order to avoid invalid
range during left-shift, the conditional expression is added.
Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com
Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
---
v1->v2
Changed the patch. Instead of avoiding shift operation for invalid
input of 'exposure.gain', throw an error for invalid range.
v2->v3
Changed the commit message details
v3->v4
Removed the trailing spaces in commit message
v4->v5
Replaced the hardcoded value with inbuilt macro
---
drivers/media/usb/gspca/cpia1.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c
index 46ed95483e22..5f5fa851ca64 100644
--- a/drivers/media/usb/gspca/cpia1.c
+++ b/drivers/media/usb/gspca/cpia1.c
@@ -18,6 +18,7 @@
#include <linux/input.h>
#include <linux/sched/signal.h>
+#include <linux/bitops.h>
#include "gspca.h"
@@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev, int on, int apply)
sd->params.exposure.expMode = 2;
sd->exposure_status = EXPOSURE_NORMAL;
}
+ if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
+ return -EINVAL;
currentexp = currentexp << sd->params.exposure.gain;
sd->params.exposure.gain = 0;
/* round down current exposure to nearest value */
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
@ 2023-08-30 7:44 ` coolrrsh
0 siblings, 0 replies; 8+ messages in thread
From: coolrrsh @ 2023-08-30 7:44 UTC (permalink / raw)
To: hverkuil, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, Rajeshwar R Shinde, syzbot+e27f3dbdab04e43b9f73
From: Rajeshwar R Shinde <coolrrsh@gmail.com>
Syzkaller reported the following issue:
UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
shift exponent 245 is too large for 32-bit type 'int'
When the value of the variable "sd->params.exposure.gain" exceeds the
number of bits in an integer, a shift-out-of-bounds error is reported. It
is triggered because the variable "currentexp" cannot be left-shifted by
more than the number of bits in an integer. In order to avoid invalid
range during left-shift, the conditional expression is added.
Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com
Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
---
v1->v2
Changed the patch. Instead of avoiding shift operation for invalid
input of 'exposure.gain', throw an error for invalid range.
v2->v3
Changed the commit message details
v3->v4
Removed the trailing spaces in commit message
v4->v5
Replaced the hardcoded value with inbuilt macro
---
drivers/media/usb/gspca/cpia1.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c
index 46ed95483e22..5f5fa851ca64 100644
--- a/drivers/media/usb/gspca/cpia1.c
+++ b/drivers/media/usb/gspca/cpia1.c
@@ -18,6 +18,7 @@
#include <linux/input.h>
#include <linux/sched/signal.h>
+#include <linux/bitops.h>
#include "gspca.h"
@@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev, int on, int apply)
sd->params.exposure.expMode = 2;
sd->exposure_status = EXPOSURE_NORMAL;
}
+ if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
+ return -EINVAL;
currentexp = currentexp << sd->params.exposure.gain;
sd->params.exposure.gain = 0;
/* round down current exposure to nearest value */
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
2023-08-30 7:44 ` coolrrsh
(?)
@ 2023-09-02 17:56 ` Rajeshwar Shinde
2023-09-04 7:23 ` Hans Verkuil
-1 siblings, 1 reply; 8+ messages in thread
From: Rajeshwar Shinde @ 2023-09-02 17:56 UTC (permalink / raw)
To: hverkuil, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, syzbot+e27f3dbdab04e43b9f73
[-- Attachment #1.1: Type: text/plain, Size: 2319 bytes --]
Remainder
On Wed, 30 Aug, 2023, 1:14 pm , <coolrrsh@gmail.com> wrote:
> From: Rajeshwar R Shinde <coolrrsh@gmail.com>
>
> Syzkaller reported the following issue:
> UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
> shift exponent 245 is too large for 32-bit type 'int'
>
> When the value of the variable "sd->params.exposure.gain" exceeds the
> number of bits in an integer, a shift-out-of-bounds error is reported. It
> is triggered because the variable "currentexp" cannot be left-shifted by
> more than the number of bits in an integer. In order to avoid invalid
> range during left-shift, the conditional expression is added.
>
>
> Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com
> Closes:
> https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com
> Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
> Signed-off-by
> <https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73Signed-off-by>:
> Rajeshwar R Shinde <coolrrsh@gmail.com>
> ---
> v1->v2
> Changed the patch. Instead of avoiding shift operation for invalid
> input of 'exposure.gain', throw an error for invalid range.
> v2->v3
> Changed the commit message details
> v3->v4
> Removed the trailing spaces in commit message
> v4->v5
> Replaced the hardcoded value with inbuilt macro
> ---
> drivers/media/usb/gspca/cpia1.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/gspca/cpia1.c
> b/drivers/media/usb/gspca/cpia1.c
> index 46ed95483e22..5f5fa851ca64 100644
> --- a/drivers/media/usb/gspca/cpia1.c
> +++ b/drivers/media/usb/gspca/cpia1.c
> @@ -18,6 +18,7 @@
>
> #include <linux/input.h>
> #include <linux/sched/signal.h>
> +#include <linux/bitops.h>
>
> #include "gspca.h"
>
> @@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev,
> int on, int apply)
> sd->params.exposure.expMode = 2;
> sd->exposure_status = EXPOSURE_NORMAL;
> }
> + if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
> + return -EINVAL;
> currentexp = currentexp << sd->params.exposure.gain;
> sd->params.exposure.gain = 0;
> /* round down current exposure to nearest value */
> --
> 2.25.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 3380 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
2023-09-02 17:56 ` Rajeshwar Shinde
@ 2023-09-04 7:23 ` Hans Verkuil
0 siblings, 0 replies; 8+ messages in thread
From: Hans Verkuil @ 2023-09-04 7:23 UTC (permalink / raw)
To: Rajeshwar Shinde, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, syzbot+e27f3dbdab04e43b9f73
Relax :-) I'll pick it up the next time I go through simple bug fix patches
like this one, probably in 2-3 weeks or so.
Regards,
Hans
On 02/09/2023 19:56, Rajeshwar Shinde wrote:
> Remainder
>
> On Wed, 30 Aug, 2023, 1:14 pm , <coolrrsh@gmail.com <mailto:coolrrsh@gmail.com>> wrote:
>
> From: Rajeshwar R Shinde <coolrrsh@gmail.com <mailto:coolrrsh@gmail.com>>
>
> Syzkaller reported the following issue:
> UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
> shift exponent 245 is too large for 32-bit type 'int'
>
> When the value of the variable "sd->params.exposure.gain" exceeds the
> number of bits in an integer, a shift-out-of-bounds error is reported. It
> is triggered because the variable "currentexp" cannot be left-shifted by
> more than the number of bits in an integer. In order to avoid invalid
> range during left-shift, the conditional expression is added.
>
>
> Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com <mailto:syzbot%2Be27f3dbdab04e43b9f73@syzkaller.appspotmail.com>
> Closes: https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com <https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com>
> Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
> Signed-off-by <https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73Signed-off-by>: Rajeshwar R Shinde <coolrrsh@gmail.com <mailto:coolrrsh@gmail.com>>
> ---
> v1->v2
> Changed the patch. Instead of avoiding shift operation for invalid
> input of 'exposure.gain', throw an error for invalid range.
> v2->v3
> Changed the commit message details
> v3->v4
> Removed the trailing spaces in commit message
> v4->v5
> Replaced the hardcoded value with inbuilt macro
> ---
> drivers/media/usb/gspca/cpia1.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c
> index 46ed95483e22..5f5fa851ca64 100644
> --- a/drivers/media/usb/gspca/cpia1.c
> +++ b/drivers/media/usb/gspca/cpia1.c
> @@ -18,6 +18,7 @@
>
> #include <linux/input.h>
> #include <linux/sched/signal.h>
> +#include <linux/bitops.h>
>
> #include "gspca.h"
>
> @@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev, int on, int apply)
> sd->params.exposure.expMode = 2;
> sd->exposure_status = EXPOSURE_NORMAL;
> }
> + if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
> + return -EINVAL;
> currentexp = currentexp << sd->params.exposure.gain;
> sd->params.exposure.gain = 0;
> /* round down current exposure to nearest value */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
@ 2023-09-04 7:23 ` Hans Verkuil
0 siblings, 0 replies; 8+ messages in thread
From: Hans Verkuil @ 2023-09-04 7:23 UTC (permalink / raw)
To: Rajeshwar Shinde, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, syzbot+e27f3dbdab04e43b9f73
Relax :-) I'll pick it up the next time I go through simple bug fix patches
like this one, probably in 2-3 weeks or so.
Regards,
Hans
On 02/09/2023 19:56, Rajeshwar Shinde wrote:
> Remainder
>
> On Wed, 30 Aug, 2023, 1:14 pm , <coolrrsh@gmail.com <mailto:coolrrsh@gmail.com>> wrote:
>
> From: Rajeshwar R Shinde <coolrrsh@gmail.com <mailto:coolrrsh@gmail.com>>
>
> Syzkaller reported the following issue:
> UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
> shift exponent 245 is too large for 32-bit type 'int'
>
> When the value of the variable "sd->params.exposure.gain" exceeds the
> number of bits in an integer, a shift-out-of-bounds error is reported. It
> is triggered because the variable "currentexp" cannot be left-shifted by
> more than the number of bits in an integer. In order to avoid invalid
> range during left-shift, the conditional expression is added.
>
>
> Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com <mailto:syzbot%2Be27f3dbdab04e43b9f73@syzkaller.appspotmail.com>
> Closes: https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com <https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com>
> Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
> Signed-off-by <https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73Signed-off-by>: Rajeshwar R Shinde <coolrrsh@gmail.com <mailto:coolrrsh@gmail.com>>
> ---
> v1->v2
> Changed the patch. Instead of avoiding shift operation for invalid
> input of 'exposure.gain', throw an error for invalid range.
> v2->v3
> Changed the commit message details
> v3->v4
> Removed the trailing spaces in commit message
> v4->v5
> Replaced the hardcoded value with inbuilt macro
> ---
> drivers/media/usb/gspca/cpia1.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c
> index 46ed95483e22..5f5fa851ca64 100644
> --- a/drivers/media/usb/gspca/cpia1.c
> +++ b/drivers/media/usb/gspca/cpia1.c
> @@ -18,6 +18,7 @@
>
> #include <linux/input.h>
> #include <linux/sched/signal.h>
> +#include <linux/bitops.h>
>
> #include "gspca.h"
>
> @@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev, int on, int apply)
> sd->params.exposure.expMode = 2;
> sd->exposure_status = EXPOSURE_NORMAL;
> }
> + if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
> + return -EINVAL;
> currentexp = currentexp << sd->params.exposure.gain;
> sd->params.exposure.gain = 0;
> /* round down current exposure to nearest value */
> --
> 2.25.1
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
2023-08-27 18:53 ` coolrrsh
(?)
@ 2023-08-30 7:38 ` Rajeshwar Shinde
-1 siblings, 0 replies; 8+ messages in thread
From: Rajeshwar Shinde @ 2023-08-30 7:38 UTC (permalink / raw)
To: hverkuil, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, syzbot+e27f3dbdab04e43b9f73
[-- Attachment #1.1: Type: text/plain, Size: 2317 bytes --]
remainder
On Mon, 28 Aug 2023 at 00:23, <coolrrsh@gmail.com> wrote:
> From: Rajeshwar R Shinde <coolrrsh@gmail.com>
>
> Syzkaller reported the following issue:
> UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
> shift exponent 245 is too large for 32-bit type 'int'
>
> When the value of the variable "sd->params.exposure.gain" exceeds the
> number of bits in an integer, a shift-out-of-bounds error is reported. It
> is triggered because the variable "currentexp" cannot be left-shifted by
> more than the number of bits in an integer. In order to avoid invalid
> range during left-shift, the conditional expression is added.
>
>
> Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com
> Closes:
> https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com
> Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
> Signed-off-by
> <https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73Signed-off-by>:
> Rajeshwar R Shinde <coolrrsh@gmail.com>
> ---
> v1->v2
> Changed the patch. Instead of avoiding shift operation for invalid
> input of 'exposure.gain', throw an error for invalid range.
> v2->v3
> Changed the commit message details
> v3->v4
> Removed the trailing spaces in commit message
> v4->v5
> Replaced the hardcoded value with inbuilt macro
> ---
> drivers/media/usb/gspca/cpia1.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/gspca/cpia1.c
> b/drivers/media/usb/gspca/cpia1.c
> index 46ed95483e22..5f5fa851ca64 100644
> --- a/drivers/media/usb/gspca/cpia1.c
> +++ b/drivers/media/usb/gspca/cpia1.c
> @@ -18,6 +18,7 @@
>
> #include <linux/input.h>
> #include <linux/sched/signal.h>
> +#include <linux/bitops.h>
>
> #include "gspca.h"
>
> @@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev,
> int on, int apply)
> sd->params.exposure.expMode = 2;
> sd->exposure_status = EXPOSURE_NORMAL;
> }
> + if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
> + return -EINVAL;
> currentexp = currentexp << sd->params.exposure.gain;
> sd->params.exposure.gain = 0;
> /* round down current exposure to nearest value */
> --
> 2.25.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 3325 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
@ 2023-08-27 18:53 ` coolrrsh
0 siblings, 0 replies; 8+ messages in thread
From: coolrrsh @ 2023-08-27 18:53 UTC (permalink / raw)
To: hverkuil, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, syzbot+e27f3dbdab04e43b9f73
From: Rajeshwar R Shinde <coolrrsh@gmail.com>
Syzkaller reported the following issue:
UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
shift exponent 245 is too large for 32-bit type 'int'
When the value of the variable "sd->params.exposure.gain" exceeds the
number of bits in an integer, a shift-out-of-bounds error is reported. It
is triggered because the variable "currentexp" cannot be left-shifted by
more than the number of bits in an integer. In order to avoid invalid
range during left-shift, the conditional expression is added.
Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com
Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
---
v1->v2
Changed the patch. Instead of avoiding shift operation for invalid
input of 'exposure.gain', throw an error for invalid range.
v2->v3
Changed the commit message details
v3->v4
Removed the trailing spaces in commit message
v4->v5
Replaced the hardcoded value with inbuilt macro
---
drivers/media/usb/gspca/cpia1.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c
index 46ed95483e22..5f5fa851ca64 100644
--- a/drivers/media/usb/gspca/cpia1.c
+++ b/drivers/media/usb/gspca/cpia1.c
@@ -18,6 +18,7 @@
#include <linux/input.h>
#include <linux/sched/signal.h>
+#include <linux/bitops.h>
#include "gspca.h"
@@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev, int on, int apply)
sd->params.exposure.expMode = 2;
sd->exposure_status = EXPOSURE_NORMAL;
}
+ if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
+ return -EINVAL;
currentexp = currentexp << sd->params.exposure.gain;
sd->params.exposure.gain = 0;
/* round down current exposure to nearest value */
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker
@ 2023-08-27 18:53 ` coolrrsh
0 siblings, 0 replies; 8+ messages in thread
From: coolrrsh @ 2023-08-27 18:53 UTC (permalink / raw)
To: hverkuil, mchehab, slark_xiao, linux-media, linux-kernel
Cc: linux-kernel-mentees, Rajeshwar R Shinde, syzbot+e27f3dbdab04e43b9f73
From: Rajeshwar R Shinde <coolrrsh@gmail.com>
Syzkaller reported the following issue:
UBSAN: shift-out-of-bounds in drivers/media/usb/gspca/cpia1.c:1031:27
shift exponent 245 is too large for 32-bit type 'int'
When the value of the variable "sd->params.exposure.gain" exceeds the
number of bits in an integer, a shift-out-of-bounds error is reported. It
is triggered because the variable "currentexp" cannot be left-shifted by
more than the number of bits in an integer. In order to avoid invalid
range during left-shift, the conditional expression is added.
Reported-by: syzbot+e27f3dbdab04e43b9f73@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/20230818164522.12806-1-coolrrsh@gmail.com
Link: https://syzkaller.appspot.com/bug?extid=e27f3dbdab04e43b9f73
Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
---
v1->v2
Changed the patch. Instead of avoiding shift operation for invalid
input of 'exposure.gain', throw an error for invalid range.
v2->v3
Changed the commit message details
v3->v4
Removed the trailing spaces in commit message
v4->v5
Replaced the hardcoded value with inbuilt macro
---
drivers/media/usb/gspca/cpia1.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c
index 46ed95483e22..5f5fa851ca64 100644
--- a/drivers/media/usb/gspca/cpia1.c
+++ b/drivers/media/usb/gspca/cpia1.c
@@ -18,6 +18,7 @@
#include <linux/input.h>
#include <linux/sched/signal.h>
+#include <linux/bitops.h>
#include "gspca.h"
@@ -1028,6 +1029,8 @@ static int set_flicker(struct gspca_dev *gspca_dev, int on, int apply)
sd->params.exposure.expMode = 2;
sd->exposure_status = EXPOSURE_NORMAL;
}
+ if (sd->params.exposure.gain >= BITS_PER_TYPE(currentexp))
+ return -EINVAL;
currentexp = currentexp << sd->params.exposure.gain;
sd->params.exposure.gain = 0;
/* round down current exposure to nearest value */
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-09-04 7:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 7:44 [PATCH v5] media: gspca: cpia1: shift-out-of-bounds in set_flicker coolrrsh
2023-08-30 7:44 ` coolrrsh
2023-09-02 17:56 ` Rajeshwar Shinde
2023-09-04 7:23 ` Hans Verkuil
2023-09-04 7:23 ` Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2023-08-27 18:53 coolrrsh
2023-08-27 18:53 ` coolrrsh
2023-08-30 7:38 ` Rajeshwar Shinde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.