* [PATCH v6 0/4] Drop ID table and conditionals around of_node pointers
@ 2023-08-31 8:09 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Uwe Kleine-König, Douglas Anderson, Zhu Wang, dri-devel,
linux-kernel, Andy Shevchenko
This patch series aims to drop ID table and conditionals around of_node
pointers for anx78xx driver.
While at it, drop CONFIG_OF conditionals around of_node pointers from
drm_bridge.h and all the drm/bridge drivers.
v5->v6:
* Dropped CONFIG_OF conditionals from all bridge drivers.
* Added Rb tag from Douglas Anderson and for patch#2 and #3.
* Added Rb tag from Laurent for patch#2.
* Dropped unnecessary CONFIG_OF conditional around
devm_drm_of_get_bridge() and drmm_of_get_bridge().
v4->v5:
* Added Rb tag from Andy and Helen for patch#1.
* Split patch#2 into two
* Added struct device_node forward declaration for patch#2.
* Updated commit description for patch#2
v3->v4:
* Created patch#2 for dropping conditionals around of_node pointers.
* Added Rb tag from Laurent and Douglas Anderson for patch#1.
v2->v3:
* Updated commit header.
v1->v2:
* Dropped ID table support.
Biju Das (4):
drm/bridge/analogix/anx78xx: Drop ID table
drm/bridge: Drop conditionals around of_node pointers
drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
drm/bridge: panel: Drop CONFIG_OF conditional around
*_of_get_bridge()
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 ---------
drivers/gpu/drm/bridge/panel.c | 5 -----
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
include/drm/drm_bridge.h | 4 ++--
5 files changed, 2 insertions(+), 20 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v6 0/4] Drop ID table and conditionals around of_node pointers
@ 2023-08-31 8:09 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter
Cc: Zhu Wang, Jonas Karlman, dri-devel, Douglas Anderson,
Jernej Skrabec, linux-kernel, Laurent Pinchart,
Uwe Kleine-König, Biju Das, Andy Shevchenko
This patch series aims to drop ID table and conditionals around of_node
pointers for anx78xx driver.
While at it, drop CONFIG_OF conditionals around of_node pointers from
drm_bridge.h and all the drm/bridge drivers.
v5->v6:
* Dropped CONFIG_OF conditionals from all bridge drivers.
* Added Rb tag from Douglas Anderson and for patch#2 and #3.
* Added Rb tag from Laurent for patch#2.
* Dropped unnecessary CONFIG_OF conditional around
devm_drm_of_get_bridge() and drmm_of_get_bridge().
v4->v5:
* Added Rb tag from Andy and Helen for patch#1.
* Split patch#2 into two
* Added struct device_node forward declaration for patch#2.
* Updated commit description for patch#2
v3->v4:
* Created patch#2 for dropping conditionals around of_node pointers.
* Added Rb tag from Laurent and Douglas Anderson for patch#1.
v2->v3:
* Updated commit header.
v1->v2:
* Dropped ID table support.
Biju Das (4):
drm/bridge/analogix/anx78xx: Drop ID table
drm/bridge: Drop conditionals around of_node pointers
drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
drm/bridge: panel: Drop CONFIG_OF conditional around
*_of_get_bridge()
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 ---------
drivers/gpu/drm/bridge/panel.c | 5 -----
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
include/drm/drm_bridge.h | 4 ++--
5 files changed, 2 insertions(+), 20 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table
2023-08-31 8:09 ` Biju Das
@ 2023-08-31 8:09 ` Biju Das
-1 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie, Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Douglas Anderson, Uwe Kleine-König, Zhu Wang, dri-devel,
linux-kernel, Andy Shevchenko, Laurent Pinchart, Helen Koike
The driver has an ID table, but it uses the wrong API for retrieving match
data and that will lead to a crash, if it is instantiated by user space or
using ID. From this, there is no user for the ID table and let's drop it
from the driver as it saves some memory.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
---
v5->v6:
* No change.
v4->v5:
* Added Rb tag from Andy and Helen.
v3->v4:
* Added Rb tag from Laurent and Douglas Anderson.
v2->v3:
* Updated commit header.
v1->v2:
* Dropped ID table support.
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
index 800555aef97f..6169db73d2fe 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
@@ -1367,12 +1367,6 @@ static void anx78xx_i2c_remove(struct i2c_client *client)
kfree(anx78xx->edid);
}
-static const struct i2c_device_id anx78xx_id[] = {
- { "anx7814", 0 },
- { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(i2c, anx78xx_id);
-
static const struct of_device_id anx78xx_match_table[] = {
{ .compatible = "analogix,anx7808", .data = anx7808_i2c_addresses },
{ .compatible = "analogix,anx7812", .data = anx781x_i2c_addresses },
@@ -1389,7 +1383,6 @@ static struct i2c_driver anx78xx_driver = {
},
.probe = anx78xx_i2c_probe,
.remove = anx78xx_i2c_remove,
- .id_table = anx78xx_id,
};
module_i2c_driver(anx78xx_driver);
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table
@ 2023-08-31 8:09 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie, Daniel Vetter
Cc: Zhu Wang, Laurent Pinchart, Jonas Karlman, dri-devel,
Douglas Anderson, Jernej Skrabec, linux-kernel, Helen Koike,
Laurent Pinchart, Uwe Kleine-König, Biju Das,
Andy Shevchenko
The driver has an ID table, but it uses the wrong API for retrieving match
data and that will lead to a crash, if it is instantiated by user space or
using ID. From this, there is no user for the ID table and let's drop it
from the driver as it saves some memory.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Helen Koike <helen.koike@collabora.com>
---
v5->v6:
* No change.
v4->v5:
* Added Rb tag from Andy and Helen.
v3->v4:
* Added Rb tag from Laurent and Douglas Anderson.
v2->v3:
* Updated commit header.
v1->v2:
* Dropped ID table support.
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
index 800555aef97f..6169db73d2fe 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
@@ -1367,12 +1367,6 @@ static void anx78xx_i2c_remove(struct i2c_client *client)
kfree(anx78xx->edid);
}
-static const struct i2c_device_id anx78xx_id[] = {
- { "anx7814", 0 },
- { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(i2c, anx78xx_id);
-
static const struct of_device_id anx78xx_match_table[] = {
{ .compatible = "analogix,anx7808", .data = anx7808_i2c_addresses },
{ .compatible = "analogix,anx7812", .data = anx781x_i2c_addresses },
@@ -1389,7 +1383,6 @@ static struct i2c_driver anx78xx_driver = {
},
.probe = anx78xx_i2c_probe,
.remove = anx78xx_i2c_remove,
- .id_table = anx78xx_id,
};
module_i2c_driver(anx78xx_driver);
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers
2023-08-31 8:09 ` Biju Das
@ 2023-08-31 8:09 ` Biju Das
-1 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
dri-devel, linux-kernel, Andy Shevchenko, Douglas Anderson,
Laurent Pinchart
This patch is based on commit c9e358dfc4a8 ("driver-core: remove
conditionals around devicetree pointers").
Having conditional around the of_node pointer of the drm_bridge
structure turns out to make driver code use ugly #ifdef blocks. Drop the
conditionals to simplify drivers. While this slightly increases the size
of struct drm_bridge on non-OF system, the number of bridges used today
and foreseen tomorrow on those systems is very low, so this shouldn't be
an issue.
So drop #if conditionals by adding struct device_node forward declaration.
Suggested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
v5->v6:
* Updated commit description.
* Added Rb tag from Douglas Anderson and Laurent
v5:
* Split from patch#2
* Updated commit description
* Added struct device_node forward declaration.
---
include/drm/drm_bridge.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index c339fc85fd07..843736627f60 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -32,6 +32,8 @@
#include <drm/drm_mode_object.h>
#include <drm/drm_modes.h>
+struct device_node;
+
struct drm_bridge;
struct drm_bridge_timings;
struct drm_connector;
@@ -716,10 +718,8 @@ struct drm_bridge {
struct drm_encoder *encoder;
/** @chain_node: used to form a bridge chain */
struct list_head chain_node;
-#ifdef CONFIG_OF
/** @of_node: device node pointer to the bridge */
struct device_node *of_node;
-#endif
/** @list: to keep track of all added bridges */
struct list_head list;
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers
@ 2023-08-31 8:09 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter
Cc: Jernej Skrabec, Jonas Karlman, linux-kernel, dri-devel,
Douglas Anderson, Laurent Pinchart, Laurent Pinchart, Biju Das,
Andy Shevchenko
This patch is based on commit c9e358dfc4a8 ("driver-core: remove
conditionals around devicetree pointers").
Having conditional around the of_node pointer of the drm_bridge
structure turns out to make driver code use ugly #ifdef blocks. Drop the
conditionals to simplify drivers. While this slightly increases the size
of struct drm_bridge on non-OF system, the number of bridges used today
and foreseen tomorrow on those systems is very low, so this shouldn't be
an issue.
So drop #if conditionals by adding struct device_node forward declaration.
Suggested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
v5->v6:
* Updated commit description.
* Added Rb tag from Douglas Anderson and Laurent
v5:
* Split from patch#2
* Updated commit description
* Added struct device_node forward declaration.
---
include/drm/drm_bridge.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index c339fc85fd07..843736627f60 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -32,6 +32,8 @@
#include <drm/drm_mode_object.h>
#include <drm/drm_modes.h>
+struct device_node;
+
struct drm_bridge;
struct drm_bridge_timings;
struct drm_connector;
@@ -716,10 +718,8 @@ struct drm_bridge {
struct drm_encoder *encoder;
/** @chain_node: used to form a bridge chain */
struct list_head chain_node;
-#ifdef CONFIG_OF
/** @of_node: device node pointer to the bridge */
struct device_node *of_node;
-#endif
/** @list: to keep track of all added bridges */
struct list_head list;
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
2023-08-31 8:09 ` Biju Das
@ 2023-08-31 8:09 ` Biju Das
-1 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie, Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Douglas Anderson, Uwe Kleine-König, Zhu Wang,
Adrián Larumbe, Thierry Reding, Ville Syrjälä,
Guillaume BRUN, Rob Herring, Sandor Yu, Sam Ravnborg,
Ondrej Jirman, dri-devel, linux-kernel, Andy Shevchenko
Having conditional around the of_node pointers turns out to make driver
code use ugly #ifdef and #if blocks. So drop the conditionals.
Suggested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v5->v6:
* Added Rb tag from Douglas Anderson.
* Dropped conditionals from remaining drm/bridge drivers.
v5:
* Split from patch#2
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 --
drivers/gpu/drm/bridge/panel.c | 2 --
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
4 files changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
index 6169db73d2fe..ad8241758896 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
@@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
mutex_init(&anx78xx->lock);
-#if IS_ENABLED(CONFIG_OF)
anx78xx->bridge.of_node = client->dev.of_node;
-#endif
anx78xx->client = client;
i2c_set_clientdata(client, anx78xx);
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 9316384b4474..7f41525f7a6e 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -302,9 +302,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
panel_bridge->panel = panel;
panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs;
-#ifdef CONFIG_OF
panel_bridge->bridge.of_node = panel->dev->of_node;
-#endif
panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES;
panel_bridge->bridge.type = connector_type;
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 6c1d79474505..52d91a0df85e 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -3541,9 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
| DRM_BRIDGE_OP_HPD;
hdmi->bridge.interlace_allowed = true;
hdmi->bridge.ddc = hdmi->ddc;
-#ifdef CONFIG_OF
hdmi->bridge.of_node = pdev->dev.of_node;
-#endif
memset(&pdevinfo, 0, sizeof(pdevinfo));
pdevinfo.parent = dev;
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 04d4a1a10698..a8dd2a2e7c7b 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -1182,9 +1182,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
dsi->bridge.driver_private = dsi;
dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs;
-#ifdef CONFIG_OF
dsi->bridge.of_node = pdev->dev.of_node;
-#endif
return dsi;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
@ 2023-08-31 8:09 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie, Daniel Vetter
Cc: Guillaume BRUN, Zhu Wang, Andy Shevchenko, Jonas Karlman,
Sandor Yu, dri-devel, Adrián Larumbe, Douglas Anderson,
Jernej Skrabec, linux-kernel, Ondrej Jirman, Laurent Pinchart,
Uwe Kleine-König, Biju Das, Thierry Reding, Sam Ravnborg
Having conditional around the of_node pointers turns out to make driver
code use ugly #ifdef and #if blocks. So drop the conditionals.
Suggested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v5->v6:
* Added Rb tag from Douglas Anderson.
* Dropped conditionals from remaining drm/bridge drivers.
v5:
* Split from patch#2
---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 --
drivers/gpu/drm/bridge/panel.c | 2 --
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
4 files changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
index 6169db73d2fe..ad8241758896 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
@@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
mutex_init(&anx78xx->lock);
-#if IS_ENABLED(CONFIG_OF)
anx78xx->bridge.of_node = client->dev.of_node;
-#endif
anx78xx->client = client;
i2c_set_clientdata(client, anx78xx);
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 9316384b4474..7f41525f7a6e 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -302,9 +302,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
panel_bridge->panel = panel;
panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs;
-#ifdef CONFIG_OF
panel_bridge->bridge.of_node = panel->dev->of_node;
-#endif
panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES;
panel_bridge->bridge.type = connector_type;
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 6c1d79474505..52d91a0df85e 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -3541,9 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
| DRM_BRIDGE_OP_HPD;
hdmi->bridge.interlace_allowed = true;
hdmi->bridge.ddc = hdmi->ddc;
-#ifdef CONFIG_OF
hdmi->bridge.of_node = pdev->dev.of_node;
-#endif
memset(&pdevinfo, 0, sizeof(pdevinfo));
pdevinfo.parent = dev;
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 04d4a1a10698..a8dd2a2e7c7b 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -1182,9 +1182,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
dsi->bridge.driver_private = dsi;
dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs;
-#ifdef CONFIG_OF
dsi->bridge.of_node = pdev->dev.of_node;
-#endif
return dsi;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
2023-08-31 8:09 ` Biju Das
@ 2023-08-31 8:09 ` Biju Das
-1 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie, Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
dri-devel, linux-kernel, Andy Shevchenko
Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and
drmm_of_get_bridge() as it is guarded with #if..#else blocks in
drm_bridge.h.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v6:
* New patch.
---
drivers/gpu/drm/bridge/panel.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 7f41525f7a6e..9220a1c23697 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -482,7 +482,6 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
}
EXPORT_SYMBOL(drm_panel_bridge_connector);
-#ifdef CONFIG_OF
/**
* devm_drm_of_get_bridge - Return next bridge in the chain
* @dev: device to tie the bridge lifetime to
@@ -550,5 +549,3 @@ struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
return bridge;
}
EXPORT_SYMBOL(drmm_of_get_bridge);
-
-#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
@ 2023-08-31 8:09 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 8:09 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie, Daniel Vetter
Cc: Jernej Skrabec, Jonas Karlman, linux-kernel, dri-devel,
Laurent Pinchart, Biju Das, Andy Shevchenko
Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and
drmm_of_get_bridge() as it is guarded with #if..#else blocks in
drm_bridge.h.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v6:
* New patch.
---
drivers/gpu/drm/bridge/panel.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 7f41525f7a6e..9220a1c23697 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -482,7 +482,6 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
}
EXPORT_SYMBOL(drm_panel_bridge_connector);
-#ifdef CONFIG_OF
/**
* devm_drm_of_get_bridge - Return next bridge in the chain
* @dev: device to tie the bridge lifetime to
@@ -550,5 +549,3 @@ struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
return bridge;
}
EXPORT_SYMBOL(drmm_of_get_bridge);
-
-#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
2023-08-31 8:09 ` Biju Das
@ 2023-08-31 9:29 ` Laurent Pinchart
-1 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2023-08-31 9:29 UTC (permalink / raw)
To: Biju Das
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Jonas Karlman, Jernej Skrabec, Douglas Anderson,
Uwe Kleine-König, Zhu Wang, Adrián Larumbe,
Thierry Reding, Ville Syrjälä,
Guillaume BRUN, Rob Herring, Sandor Yu, Sam Ravnborg,
Ondrej Jirman, dri-devel, linux-kernel, Andy Shevchenko
Hi Biju,
Thank you for the patch.
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v5->v6:
> * Added Rb tag from Douglas Anderson.
> * Dropped conditionals from remaining drm/bridge drivers.
> v5:
> * Split from patch#2
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 --
> drivers/gpu/drm/bridge/panel.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
> 4 files changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> index 6169db73d2fe..ad8241758896 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> @@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
>
> mutex_init(&anx78xx->lock);
>
> -#if IS_ENABLED(CONFIG_OF)
> anx78xx->bridge.of_node = client->dev.of_node;
> -#endif
>
> anx78xx->client = client;
> i2c_set_clientdata(client, anx78xx);
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 9316384b4474..7f41525f7a6e 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -302,9 +302,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
> panel_bridge->panel = panel;
>
> panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs;
> -#ifdef CONFIG_OF
> panel_bridge->bridge.of_node = panel->dev->of_node;
> -#endif
> panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES;
> panel_bridge->bridge.type = connector_type;
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 6c1d79474505..52d91a0df85e 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3541,9 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
> | DRM_BRIDGE_OP_HPD;
> hdmi->bridge.interlace_allowed = true;
> hdmi->bridge.ddc = hdmi->ddc;
> -#ifdef CONFIG_OF
> hdmi->bridge.of_node = pdev->dev.of_node;
> -#endif
>
> memset(&pdevinfo, 0, sizeof(pdevinfo));
> pdevinfo.parent = dev;
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 04d4a1a10698..a8dd2a2e7c7b 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -1182,9 +1182,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
>
> dsi->bridge.driver_private = dsi;
> dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs;
> -#ifdef CONFIG_OF
> dsi->bridge.of_node = pdev->dev.of_node;
> -#endif
>
> return dsi;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
@ 2023-08-31 9:29 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2023-08-31 9:29 UTC (permalink / raw)
To: Biju Das
Cc: Neil Armstrong, Zhu Wang, Andy Shevchenko, Robert Foss,
Andrzej Hajda, Sam Ravnborg, Jonas Karlman, Sandor Yu, dri-devel,
Adrián Larumbe, Douglas Anderson, Jernej Skrabec,
linux-kernel, Ondrej Jirman, Guillaume BRUN,
Uwe Kleine-König, Thierry Reding
Hi Biju,
Thank you for the patch.
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v5->v6:
> * Added Rb tag from Douglas Anderson.
> * Dropped conditionals from remaining drm/bridge drivers.
> v5:
> * Split from patch#2
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 --
> drivers/gpu/drm/bridge/panel.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
> 4 files changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> index 6169db73d2fe..ad8241758896 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> @@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client)
>
> mutex_init(&anx78xx->lock);
>
> -#if IS_ENABLED(CONFIG_OF)
> anx78xx->bridge.of_node = client->dev.of_node;
> -#endif
>
> anx78xx->client = client;
> i2c_set_clientdata(client, anx78xx);
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 9316384b4474..7f41525f7a6e 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -302,9 +302,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
> panel_bridge->panel = panel;
>
> panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs;
> -#ifdef CONFIG_OF
> panel_bridge->bridge.of_node = panel->dev->of_node;
> -#endif
> panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES;
> panel_bridge->bridge.type = connector_type;
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 6c1d79474505..52d91a0df85e 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3541,9 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
> | DRM_BRIDGE_OP_HPD;
> hdmi->bridge.interlace_allowed = true;
> hdmi->bridge.ddc = hdmi->ddc;
> -#ifdef CONFIG_OF
> hdmi->bridge.of_node = pdev->dev.of_node;
> -#endif
>
> memset(&pdevinfo, 0, sizeof(pdevinfo));
> pdevinfo.parent = dev;
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 04d4a1a10698..a8dd2a2e7c7b 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -1182,9 +1182,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
>
> dsi->bridge.driver_private = dsi;
> dsi->bridge.funcs = &dw_mipi_dsi_bridge_funcs;
> -#ifdef CONFIG_OF
> dsi->bridge.of_node = pdev->dev.of_node;
> -#endif
>
> return dsi;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
2023-08-31 8:09 ` Biju Das
@ 2023-08-31 9:31 ` Laurent Pinchart
-1 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2023-08-31 9:31 UTC (permalink / raw)
To: Biju Das
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Jonas Karlman, Jernej Skrabec, dri-devel,
linux-kernel, Andy Shevchenko
On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
> Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and
> drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> drm_bridge.h.
This will increase the kernel size on non-OF system, to add functions
that are not used. I don't think the #ifdef here is problematic.
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v6:
> * New patch.
> ---
> drivers/gpu/drm/bridge/panel.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7f41525f7a6e..9220a1c23697 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -482,7 +482,6 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
> }
> EXPORT_SYMBOL(drm_panel_bridge_connector);
>
> -#ifdef CONFIG_OF
> /**
> * devm_drm_of_get_bridge - Return next bridge in the chain
> * @dev: device to tie the bridge lifetime to
> @@ -550,5 +549,3 @@ struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
> return bridge;
> }
> EXPORT_SYMBOL(drmm_of_get_bridge);
> -
> -#endif
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
@ 2023-08-31 9:31 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2023-08-31 9:31 UTC (permalink / raw)
To: Biju Das
Cc: Neil Armstrong, Robert Foss, Andrzej Hajda, Jonas Karlman,
linux-kernel, Jernej Skrabec, dri-devel, Andy Shevchenko
On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
> Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and
> drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> drm_bridge.h.
This will increase the kernel size on non-OF system, to add functions
that are not used. I don't think the #ifdef here is problematic.
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v6:
> * New patch.
> ---
> drivers/gpu/drm/bridge/panel.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7f41525f7a6e..9220a1c23697 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -482,7 +482,6 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
> }
> EXPORT_SYMBOL(drm_panel_bridge_connector);
>
> -#ifdef CONFIG_OF
> /**
> * devm_drm_of_get_bridge - Return next bridge in the chain
> * @dev: device to tie the bridge lifetime to
> @@ -550,5 +549,3 @@ struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
> return bridge;
> }
> EXPORT_SYMBOL(drmm_of_get_bridge);
> -
> -#endif
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
2023-08-31 9:31 ` Laurent Pinchart
@ 2023-08-31 10:47 ` Biju Das
-1 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 10:47 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Neil Armstrong, Robert Foss, Andrzej Hajda, Jonas Karlman,
linux-kernel, Jernej Skrabec, dri-devel, Andy Shevchenko
Hi Laurent Pinchart,
> Subject: Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional
> around *_of_get_bridge()
>
> On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
> > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > and
> > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > drm_bridge.h.
>
> This will increase the kernel size on non-OF system, to add functions that
> are not used. I don't think the #ifdef here is problematic.
OK agreed. I guess for NON-OF system it will give build error
for function redefinition, if that is the case I would like to
drop this patch.
static inline struct drm_bridge *devm_drm_of_get_bridge()
vs
struct drm_bridge *devm_drm_of_get_bridge()
Cheers,
Biju
>
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v6:
> > * New patch.
> > ---
> > drivers/gpu/drm/bridge/panel.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c
> > b/drivers/gpu/drm/bridge/panel.c index 7f41525f7a6e..9220a1c23697
> > 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -482,7 +482,6 @@ struct drm_connector
> > *drm_panel_bridge_connector(struct drm_bridge *bridge) }
> > EXPORT_SYMBOL(drm_panel_bridge_connector);
> >
> > -#ifdef CONFIG_OF
> > /**
> > * devm_drm_of_get_bridge - Return next bridge in the chain
> > * @dev: device to tie the bridge lifetime to @@ -550,5 +549,3 @@
> > struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
> > return bridge;
> > }
> > EXPORT_SYMBOL(drmm_of_get_bridge);
> > -
> > -#endif
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
@ 2023-08-31 10:47 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-08-31 10:47 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Jonas Karlman, Jernej Skrabec, dri-devel,
linux-kernel, Andy Shevchenko
Hi Laurent Pinchart,
> Subject: Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional
> around *_of_get_bridge()
>
> On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
> > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > and
> > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > drm_bridge.h.
>
> This will increase the kernel size on non-OF system, to add functions that
> are not used. I don't think the #ifdef here is problematic.
OK agreed. I guess for NON-OF system it will give build error
for function redefinition, if that is the case I would like to
drop this patch.
static inline struct drm_bridge *devm_drm_of_get_bridge()
vs
struct drm_bridge *devm_drm_of_get_bridge()
Cheers,
Biju
>
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v6:
> > * New patch.
> > ---
> > drivers/gpu/drm/bridge/panel.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c
> > b/drivers/gpu/drm/bridge/panel.c index 7f41525f7a6e..9220a1c23697
> > 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -482,7 +482,6 @@ struct drm_connector
> > *drm_panel_bridge_connector(struct drm_bridge *bridge) }
> > EXPORT_SYMBOL(drm_panel_bridge_connector);
> >
> > -#ifdef CONFIG_OF
> > /**
> > * devm_drm_of_get_bridge - Return next bridge in the chain
> > * @dev: device to tie the bridge lifetime to @@ -550,5 +549,3 @@
> > struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
> > return bridge;
> > }
> > EXPORT_SYMBOL(drmm_of_get_bridge);
> > -
> > -#endif
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
2023-08-31 8:09 ` Biju Das
@ 2023-08-31 16:14 ` Andy Shevchenko
-1 siblings, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2023-08-31 16:14 UTC (permalink / raw)
To: Biju Das
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Douglas Anderson, Uwe Kleine-König, Zhu Wang,
Adrián Larumbe, Thierry Reding, Ville Syrjälä,
Guillaume BRUN, Rob Herring, Sandor Yu, Sam Ravnborg,
Ondrej Jirman, dri-devel, linux-kernel
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
...
> anx78xx->bridge.of_node = client->dev.of_node;
> panel_bridge->bridge.of_node = panel->dev->of_node;
> hdmi->bridge.of_node = pdev->dev.of_node;
> dsi->bridge.of_node = pdev->dev.of_node;
Yeah, I would really switch all of these to
bridge->fwnode = dev_fwnode(...);
But it's a suggestion for a separate change that I think can happen
sooner than later.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
@ 2023-08-31 16:14 ` Andy Shevchenko
0 siblings, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2023-08-31 16:14 UTC (permalink / raw)
To: Biju Das
Cc: Guillaume BRUN, Neil Armstrong, Zhu Wang, Robert Foss,
Andrzej Hajda, Sam Ravnborg, Jonas Karlman, Sandor Yu, dri-devel,
Adrián Larumbe, Douglas Anderson, Jernej Skrabec,
linux-kernel, Ondrej Jirman, Laurent Pinchart,
Uwe Kleine-König, Thierry Reding
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
...
> anx78xx->bridge.of_node = client->dev.of_node;
> panel_bridge->bridge.of_node = panel->dev->of_node;
> hdmi->bridge.of_node = pdev->dev.of_node;
> dsi->bridge.of_node = pdev->dev.of_node;
Yeah, I would really switch all of these to
bridge->fwnode = dev_fwnode(...);
But it's a suggestion for a separate change that I think can happen
sooner than later.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
2023-08-31 10:47 ` Biju Das
@ 2023-08-31 16:16 ` Andy Shevchenko
-1 siblings, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2023-08-31 16:16 UTC (permalink / raw)
To: Biju Das
Cc: Laurent Pinchart, Andrzej Hajda, Neil Armstrong, Robert Foss,
David Airlie, Daniel Vetter, Jonas Karlman, Jernej Skrabec,
dri-devel, linux-kernel
On Thu, Aug 31, 2023 at 10:47:24AM +0000, Biju Das wrote:
> > On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
...
> > > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > > and
> > > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > > drm_bridge.h.
> >
> > This will increase the kernel size on non-OF system, to add functions that
> > are not used. I don't think the #ifdef here is problematic.
>
> OK agreed. I guess for NON-OF system it will give build error
> for function redefinition, if that is the case I would like to
> drop this patch.
>
> static inline struct drm_bridge *devm_drm_of_get_bridge()
>
> vs
>
> struct drm_bridge *devm_drm_of_get_bridge()
Yeah, yet another argument in favour of switching to fwnode.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
@ 2023-08-31 16:16 ` Andy Shevchenko
0 siblings, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2023-08-31 16:16 UTC (permalink / raw)
To: Biju Das
Cc: Neil Armstrong, Robert Foss, Andrzej Hajda, Jonas Karlman,
dri-devel, linux-kernel, Jernej Skrabec, Laurent Pinchart
On Thu, Aug 31, 2023 at 10:47:24AM +0000, Biju Das wrote:
> > On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
...
> > > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > > and
> > > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > > drm_bridge.h.
> >
> > This will increase the kernel size on non-OF system, to add functions that
> > are not used. I don't think the #ifdef here is problematic.
>
> OK agreed. I guess for NON-OF system it will give build error
> for function redefinition, if that is the case I would like to
> drop this patch.
>
> static inline struct drm_bridge *devm_drm_of_get_bridge()
>
> vs
>
> struct drm_bridge *devm_drm_of_get_bridge()
Yeah, yet another argument in favour of switching to fwnode.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table
2023-08-31 8:09 ` Biju Das
@ 2023-09-06 15:41 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:41 UTC (permalink / raw)
To: Biju Das
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Uwe Kleine-König, Zhu Wang, dri-devel, linux-kernel,
Andy Shevchenko, Laurent Pinchart, Helen Koike
Hi,
On Thu, Aug 31, 2023 at 1:09 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> The driver has an ID table, but it uses the wrong API for retrieving match
> data and that will lead to a crash, if it is instantiated by user space or
> using ID. From this, there is no user for the ID table and let's drop it
> from the driver as it saves some memory.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Helen Koike <helen.koike@collabora.com>
> ---
> v5->v6:
> * No change.
> v4->v5:
> * Added Rb tag from Andy and Helen.
> v3->v4:
> * Added Rb tag from Laurent and Douglas Anderson.
> v2->v3:
> * Updated commit header.
> v1->v2:
> * Dropped ID table support.
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 7 -------
> 1 file changed, 7 deletions(-)
I think this has had enough time to marinate, so landed to drm-misc-next:
39e0b96d61b6 drm/bridge/analogix/anx78xx: Drop ID table
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table
@ 2023-09-06 15:41 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:41 UTC (permalink / raw)
To: Biju Das
Cc: Neil Armstrong, Zhu Wang, Laurent Pinchart, Robert Foss,
Andrzej Hajda, Jonas Karlman, dri-devel, linux-kernel,
Jernej Skrabec, Helen Koike, Laurent Pinchart,
Uwe Kleine-König, Andy Shevchenko
Hi,
On Thu, Aug 31, 2023 at 1:09 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> The driver has an ID table, but it uses the wrong API for retrieving match
> data and that will lead to a crash, if it is instantiated by user space or
> using ID. From this, there is no user for the ID table and let's drop it
> from the driver as it saves some memory.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Helen Koike <helen.koike@collabora.com>
> ---
> v5->v6:
> * No change.
> v4->v5:
> * Added Rb tag from Andy and Helen.
> v3->v4:
> * Added Rb tag from Laurent and Douglas Anderson.
> v2->v3:
> * Updated commit header.
> v1->v2:
> * Dropped ID table support.
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 7 -------
> 1 file changed, 7 deletions(-)
I think this has had enough time to marinate, so landed to drm-misc-next:
39e0b96d61b6 drm/bridge/analogix/anx78xx: Drop ID table
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers
2023-08-31 8:09 ` Biju Das
@ 2023-09-06 15:42 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:42 UTC (permalink / raw)
To: Biju Das
Cc: Neil Armstrong, Jernej Skrabec, Robert Foss, Thomas Zimmermann,
Jonas Karlman, dri-devel, linux-kernel, Maxime Ripard,
Laurent Pinchart, Laurent Pinchart, Andrzej Hajda,
Andy Shevchenko
Hi,
On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> This patch is based on commit c9e358dfc4a8 ("driver-core: remove
> conditionals around devicetree pointers").
>
> Having conditional around the of_node pointer of the drm_bridge
> structure turns out to make driver code use ugly #ifdef blocks. Drop the
> conditionals to simplify drivers. While this slightly increases the size
> of struct drm_bridge on non-OF system, the number of bridges used today
> and foreseen tomorrow on those systems is very low, so this shouldn't be
> an issue.
>
> So drop #if conditionals by adding struct device_node forward declaration.
>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> v5->v6:
> * Updated commit description.
> * Added Rb tag from Douglas Anderson and Laurent
> v5:
> * Split from patch#2
> * Updated commit description
> * Added struct device_node forward declaration.
> ---
> include/drm/drm_bridge.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I think this has had enough time to marinate, so landed to drm-misc-next:
d8dfccde2709 drm/bridge: Drop conditionals around of_node pointers
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers
@ 2023-09-06 15:42 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:42 UTC (permalink / raw)
To: Biju Das
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
dri-devel, linux-kernel, Andy Shevchenko, Laurent Pinchart
Hi,
On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> This patch is based on commit c9e358dfc4a8 ("driver-core: remove
> conditionals around devicetree pointers").
>
> Having conditional around the of_node pointer of the drm_bridge
> structure turns out to make driver code use ugly #ifdef blocks. Drop the
> conditionals to simplify drivers. While this slightly increases the size
> of struct drm_bridge on non-OF system, the number of bridges used today
> and foreseen tomorrow on those systems is very low, so this shouldn't be
> an issue.
>
> So drop #if conditionals by adding struct device_node forward declaration.
>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> v5->v6:
> * Updated commit description.
> * Added Rb tag from Douglas Anderson and Laurent
> v5:
> * Split from patch#2
> * Updated commit description
> * Added struct device_node forward declaration.
> ---
> include/drm/drm_bridge.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I think this has had enough time to marinate, so landed to drm-misc-next:
d8dfccde2709 drm/bridge: Drop conditionals around of_node pointers
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
2023-08-31 8:09 ` Biju Das
@ 2023-09-06 15:42 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:42 UTC (permalink / raw)
To: Biju Das
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Uwe Kleine-König, Zhu Wang, Adrián Larumbe,
Thierry Reding, Ville Syrjälä,
Guillaume BRUN, Rob Herring, Sandor Yu, Sam Ravnborg,
Ondrej Jirman, dri-devel, linux-kernel, Andy Shevchenko
Hi,
On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> v5->v6:
> * Added Rb tag from Douglas Anderson.
> * Dropped conditionals from remaining drm/bridge drivers.
> v5:
> * Split from patch#2
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 --
> drivers/gpu/drm/bridge/panel.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
> 4 files changed, 8 deletions(-)
I think this has had enough time to marinate, so landed to drm-misc-next:
481fc9e7e11d drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
@ 2023-09-06 15:42 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:42 UTC (permalink / raw)
To: Biju Das
Cc: Neil Armstrong, Zhu Wang, Andy Shevchenko, Robert Foss,
Andrzej Hajda, Sam Ravnborg, Jonas Karlman, Sandor Yu, dri-devel,
Adrián Larumbe, Guillaume BRUN, Jernej Skrabec,
linux-kernel, Ondrej Jirman, Laurent Pinchart,
Uwe Kleine-König, Thierry Reding
Hi,
On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> v5->v6:
> * Added Rb tag from Douglas Anderson.
> * Dropped conditionals from remaining drm/bridge drivers.
> v5:
> * Split from patch#2
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 --
> drivers/gpu/drm/bridge/panel.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 --
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 --
> 4 files changed, 8 deletions(-)
I think this has had enough time to marinate, so landed to drm-misc-next:
481fc9e7e11d drm/bridge: Drop CONFIG_OF conditionals around of_node pointers
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
2023-08-31 8:09 ` Biju Das
@ 2023-09-06 15:42 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:42 UTC (permalink / raw)
To: Biju Das
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Jernej Skrabec, Jonas Karlman, linux-kernel,
dri-devel, Laurent Pinchart, Andy Shevchenko
Hi,
On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and
> drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> drm_bridge.h.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v6:
> * New patch.
> ---
> drivers/gpu/drm/bridge/panel.c | 3 ---
> 1 file changed, 3 deletions(-)
Just to be explicit, I'm _not_ landing this patch though I've landed
patches #1 - #3 from this series.
-Doug
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
@ 2023-09-06 15:42 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2023-09-06 15:42 UTC (permalink / raw)
To: Biju Das
Cc: Neil Armstrong, Robert Foss, Andrzej Hajda, Jonas Karlman,
linux-kernel, Jernej Skrabec, dri-devel, Andy Shevchenko,
Laurent Pinchart
Hi,
On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and
> drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> drm_bridge.h.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v6:
> * New patch.
> ---
> drivers/gpu/drm/bridge/panel.c | 3 ---
> 1 file changed, 3 deletions(-)
Just to be explicit, I'm _not_ landing this patch though I've landed
patches #1 - #3 from this series.
-Doug
^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
2023-09-06 15:42 ` Doug Anderson
@ 2023-09-06 18:15 ` Biju Das
-1 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-09-06 18:15 UTC (permalink / raw)
To: Doug Anderson
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, David Airlie,
Daniel Vetter, Jernej Skrabec, Jonas Karlman, linux-kernel,
dri-devel, Laurent Pinchart, Andy Shevchenko
Hi Doug Anderson,
> Subject: Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional
> around *_of_get_bridge()
>
> Hi,
>
> On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> >
> > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > and
> > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > drm_bridge.h.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v6:
> > * New patch.
> > ---
> > drivers/gpu/drm/bridge/panel.c | 3 ---
> > 1 file changed, 3 deletions(-)
>
> Just to be explicit, I'm _not_ landing this patch though I've landed
> patches #1 - #3 from this series.
Thank you.
Cheers,
Biju
^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()
@ 2023-09-06 18:15 ` Biju Das
0 siblings, 0 replies; 30+ messages in thread
From: Biju Das @ 2023-09-06 18:15 UTC (permalink / raw)
To: Doug Anderson
Cc: Neil Armstrong, Robert Foss, Andrzej Hajda, Jonas Karlman,
linux-kernel, Jernej Skrabec, dri-devel, Andy Shevchenko,
Laurent Pinchart
Hi Doug Anderson,
> Subject: Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional
> around *_of_get_bridge()
>
> Hi,
>
> On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> >
> > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge()
> > and
> > drmm_of_get_bridge() as it is guarded with #if..#else blocks in
> > drm_bridge.h.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v6:
> > * New patch.
> > ---
> > drivers/gpu/drm/bridge/panel.c | 3 ---
> > 1 file changed, 3 deletions(-)
>
> Just to be explicit, I'm _not_ landing this patch though I've landed
> patches #1 - #3 from this series.
Thank you.
Cheers,
Biju
^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2023-09-06 18:16 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-31 8:09 [PATCH v6 0/4] Drop ID table and conditionals around of_node pointers Biju Das
2023-08-31 8:09 ` Biju Das
2023-08-31 8:09 ` [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table Biju Das
2023-08-31 8:09 ` Biju Das
2023-09-06 15:41 ` Doug Anderson
2023-09-06 15:41 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers Biju Das
2023-08-31 8:09 ` Biju Das
2023-09-06 15:42 ` Doug Anderson
2023-09-06 15:42 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF " Biju Das
2023-08-31 8:09 ` Biju Das
2023-08-31 9:29 ` Laurent Pinchart
2023-08-31 9:29 ` Laurent Pinchart
2023-08-31 16:14 ` Andy Shevchenko
2023-08-31 16:14 ` Andy Shevchenko
2023-09-06 15:42 ` Doug Anderson
2023-09-06 15:42 ` Doug Anderson
2023-08-31 8:09 ` [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge() Biju Das
2023-08-31 8:09 ` Biju Das
2023-08-31 9:31 ` Laurent Pinchart
2023-08-31 9:31 ` Laurent Pinchart
2023-08-31 10:47 ` Biju Das
2023-08-31 10:47 ` Biju Das
2023-08-31 16:16 ` Andy Shevchenko
2023-08-31 16:16 ` Andy Shevchenko
2023-09-06 15:42 ` Doug Anderson
2023-09-06 15:42 ` Doug Anderson
2023-09-06 18:15 ` Biju Das
2023-09-06 18:15 ` Biju Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.