All of lore.kernel.org
 help / color / mirror / Atom feed
* [android-common:android15-6.1 5681/11516] kernel/sched/pelt.c:477:5: warning: no previous declaration for 'sched_pelt_multiplier'
@ 2023-08-31  6:43 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-08-31  6:43 UTC (permalink / raw)
  To: cros-kernel-buildreports; +Cc: oe-kbuild-all

Hi Jing-Ting,

FYI, the error/warning still remains.

tree:   https://android.googlesource.com/kernel/common android15-6.1
head:   2a9967e15f99010ec06ac089b42a2ac20f2a57cb
commit: 0baa11384bf87212556a5cdce26a471ccadd11c7 [5681/11516] FROMLIST: sched/pelt: Introduce PELT multiplier
config: x86_64-randconfig-r032-20230831 (https://download.01.org/0day-ci/archive/20230831/202308311447.w4hymchJ-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308311447.w4hymchJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308311447.w4hymchJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from kernel/sched/build_policy.c:49:0:
>> kernel/sched/pelt.c:477:5: warning: no previous declaration for 'sched_pelt_multiplier' [-Wmissing-declarations]
    int sched_pelt_multiplier(struct ctl_table *table, int write, void *buffer,
        ^~~~~~~~~~~~~~~~~~~~~


vim +/sched_pelt_multiplier +477 kernel/sched/pelt.c

   476	
 > 477	int sched_pelt_multiplier(struct ctl_table *table, int write, void *buffer,
   478				  size_t *lenp, loff_t *ppos)
   479	{
   480		static DEFINE_MUTEX(mutex);
   481		unsigned int old;
   482		int ret;
   483	
   484		mutex_lock(&mutex);
   485		old = sysctl_sched_pelt_multiplier;
   486		ret = proc_dointvec(table, write, buffer, lenp, ppos);
   487		if (ret)
   488			goto undo;
   489		if (!write)
   490			goto done;
   491	
   492		switch (sysctl_sched_pelt_multiplier)  {
   493		case 1:
   494			fallthrough;
   495		case 2:
   496			fallthrough;
   497		case 4:
   498			WRITE_ONCE(sched_pelt_lshift,
   499				   sysctl_sched_pelt_multiplier >> 1);
   500			goto done;
   501		default:
   502			ret = -EINVAL;
   503		}
   504	
   505	undo:
   506		sysctl_sched_pelt_multiplier = old;
   507	done:
   508		mutex_unlock(&mutex);
   509	
   510		return ret;
   511	}
   512	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-08-31  6:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-31  6:43 [android-common:android15-6.1 5681/11516] kernel/sched/pelt.c:477:5: warning: no previous declaration for 'sched_pelt_multiplier' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.