* [PATCH] drm/mediatek: dp: Remove redundant dev_err_probe() for platform_get_irq()
@ 2023-09-01 6:58 ` Jinjie Ruan
0 siblings, 0 replies; 3+ messages in thread
From: Jinjie Ruan @ 2023-09-01 6:58 UTC (permalink / raw)
To: dri-devel, linux-mediatek, linux-arm-kernel, Chun-Kuang Hu,
Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
AngeloGioacchino Del Regno, CK Hu, Alexandre Mergnat
Cc: ruanjinjie
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
to platform_get_irq*()") and commit 2043727c2882 ("driver core:
platform: Make use of the helper function dev_err_probe()"), there is
no need to call the dev_err_probe() function directly to print a custom
message when handling an error from platform_get_irq() function as it is
going to display an appropriate error message in case of a failure.
Fixes: 828c91231fbe ("drm/mediatek: dp: Don't register HPD interrupt handler for eDP case")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/gpu/drm/mediatek/mtk_dp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index 2cb47f663756..5bebd8bdd188 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2597,8 +2597,7 @@ static int mtk_dp_probe(struct platform_device *pdev)
if (mtk_dp->data->bridge_type != DRM_MODE_CONNECTOR_eDP) {
mtk_dp->irq = platform_get_irq(pdev, 0);
if (mtk_dp->irq < 0)
- return dev_err_probe(dev, mtk_dp->irq,
- "failed to request dp irq resource\n");
+ return mtk_dp->irq;
spin_lock_init(&mtk_dp->irq_thread_lock);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] drm/mediatek: dp: Remove redundant dev_err_probe() for platform_get_irq()
@ 2023-09-01 6:58 ` Jinjie Ruan
0 siblings, 0 replies; 3+ messages in thread
From: Jinjie Ruan @ 2023-09-01 6:58 UTC (permalink / raw)
To: dri-devel, linux-mediatek, linux-arm-kernel, Chun-Kuang Hu,
Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
AngeloGioacchino Del Regno, CK Hu, Alexandre Mergnat
Cc: ruanjinjie
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
to platform_get_irq*()") and commit 2043727c2882 ("driver core:
platform: Make use of the helper function dev_err_probe()"), there is
no need to call the dev_err_probe() function directly to print a custom
message when handling an error from platform_get_irq() function as it is
going to display an appropriate error message in case of a failure.
Fixes: 828c91231fbe ("drm/mediatek: dp: Don't register HPD interrupt handler for eDP case")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/gpu/drm/mediatek/mtk_dp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index 2cb47f663756..5bebd8bdd188 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2597,8 +2597,7 @@ static int mtk_dp_probe(struct platform_device *pdev)
if (mtk_dp->data->bridge_type != DRM_MODE_CONNECTOR_eDP) {
mtk_dp->irq = platform_get_irq(pdev, 0);
if (mtk_dp->irq < 0)
- return dev_err_probe(dev, mtk_dp->irq,
- "failed to request dp irq resource\n");
+ return mtk_dp->irq;
spin_lock_init(&mtk_dp->irq_thread_lock);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] drm/mediatek: dp: Remove redundant dev_err_probe() for platform_get_irq()
@ 2023-09-01 6:58 ` Jinjie Ruan
0 siblings, 0 replies; 3+ messages in thread
From: Jinjie Ruan @ 2023-09-01 6:58 UTC (permalink / raw)
To: dri-devel, linux-mediatek, linux-arm-kernel, Chun-Kuang Hu,
Philipp Zabel, David Airlie, Daniel Vetter, Matthias Brugger,
AngeloGioacchino Del Regno, CK Hu, Alexandre Mergnat
Cc: ruanjinjie
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
to platform_get_irq*()") and commit 2043727c2882 ("driver core:
platform: Make use of the helper function dev_err_probe()"), there is
no need to call the dev_err_probe() function directly to print a custom
message when handling an error from platform_get_irq() function as it is
going to display an appropriate error message in case of a failure.
Fixes: 828c91231fbe ("drm/mediatek: dp: Don't register HPD interrupt handler for eDP case")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/gpu/drm/mediatek/mtk_dp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
index 2cb47f663756..5bebd8bdd188 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2597,8 +2597,7 @@ static int mtk_dp_probe(struct platform_device *pdev)
if (mtk_dp->data->bridge_type != DRM_MODE_CONNECTOR_eDP) {
mtk_dp->irq = platform_get_irq(pdev, 0);
if (mtk_dp->irq < 0)
- return dev_err_probe(dev, mtk_dp->irq,
- "failed to request dp irq resource\n");
+ return mtk_dp->irq;
spin_lock_init(&mtk_dp->irq_thread_lock);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-01 6:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-01 6:58 [PATCH] drm/mediatek: dp: Remove redundant dev_err_probe() for platform_get_irq() Jinjie Ruan
2023-09-01 6:58 ` Jinjie Ruan
2023-09-01 6:58 ` Jinjie Ruan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.