* [PATCH v2 1/2] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size
2023-09-05 9:55 [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018 Vignesh Viswanathan
@ 2023-09-05 9:55 ` Vignesh Viswanathan
2023-09-05 16:07 ` Konrad Dybcio
2023-09-05 9:55 ` [PATCH v2 2/2] hwspinlock: qcom: Remove IPQ6018 SOC specific compatible Vignesh Viswanathan
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Vignesh Viswanathan @ 2023-09-05 9:55 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel, ohad, baolin.wang, linux-remoteproc
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, Vignesh Viswanathan, stable
IPQ6018's TCSR Mutex HW lock register has 32 locks of size 4KB each.
Total size of the TCSR Mutex registers is 128KB.
Fix size of the tcsr_mutex hwlock register to 0x20000.
Changes in v2:
- Drop change to remove qcom,ipq6018-tcsr-mutex compatible string
- Added Fixes and stable tags
Cc: stable@vger.kernel.org
Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
---
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 47b8b1d6730a..9793279e2ced 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -393,7 +393,7 @@ gcc: gcc@1800000 {
tcsr_mutex: hwlock@1905000 {
compatible = "qcom,ipq6018-tcsr-mutex", "qcom,tcsr-mutex";
- reg = <0x0 0x01905000 0x0 0x1000>;
+ reg = <0x0 0x01905000 0x0 0x20000>;
#hwlock-cells = <1>;
};
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size
2023-09-05 9:55 ` [PATCH v2 1/2] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size Vignesh Viswanathan
@ 2023-09-05 16:07 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-09-05 16:07 UTC (permalink / raw)
To: Vignesh Viswanathan, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel, ohad, baolin.wang, linux-remoteproc
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 5.09.2023 11:55, Vignesh Viswanathan wrote:
> IPQ6018's TCSR Mutex HW lock register has 32 locks of size 4KB each.
> Total size of the TCSR Mutex registers is 128KB.
>
> Fix size of the tcsr_mutex hwlock register to 0x20000.
>
> Changes in v2:
> - Drop change to remove qcom,ipq6018-tcsr-mutex compatible string
> - Added Fixes and stable tags
>
> Cc: stable@vger.kernel.org
> Fixes: 5bf635621245 ("arm64: dts: ipq6018: Add a few device nodes")
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] hwspinlock: qcom: Remove IPQ6018 SOC specific compatible
2023-09-05 9:55 [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018 Vignesh Viswanathan
2023-09-05 9:55 ` [PATCH v2 1/2] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size Vignesh Viswanathan
@ 2023-09-05 9:55 ` Vignesh Viswanathan
2023-09-05 16:08 ` Konrad Dybcio
2023-09-20 3:58 ` (subset) [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018 Bjorn Andersson
2023-09-20 17:02 ` Bjorn Andersson
3 siblings, 1 reply; 7+ messages in thread
From: Vignesh Viswanathan @ 2023-09-05 9:55 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel, ohad, baolin.wang, linux-remoteproc
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, Vignesh Viswanathan, stable
IPQ6018 has 32 tcsr_mutex hwlock registers with stride 0x1000.
The compatible string qcom,ipq6018-tcsr-mutex is mapped to
of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
and doesn't match the HW present in IPQ6018.
Remove IPQ6018 specific compatible string so that it fallsback to
of_tcsr_mutex data which maps to the correct configuration for IPQ6018.
Changes in v2:
- Updated commit message
- Added Fixes and stable tags
Cc: stable@vger.kernel.org
Fixes: 5d4753f741d8 ("hwspinlock: qcom: add support for MMIO on older SoCs")
Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
---
drivers/hwspinlock/qcom_hwspinlock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
index a0fd67fd2934..814dfe8697bf 100644
--- a/drivers/hwspinlock/qcom_hwspinlock.c
+++ b/drivers/hwspinlock/qcom_hwspinlock.c
@@ -115,7 +115,6 @@ static const struct of_device_id qcom_hwspinlock_of_match[] = {
{ .compatible = "qcom,sfpb-mutex", .data = &of_sfpb_mutex },
{ .compatible = "qcom,tcsr-mutex", .data = &of_tcsr_mutex },
{ .compatible = "qcom,apq8084-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
- { .compatible = "qcom,ipq6018-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
{ .compatible = "qcom,msm8226-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
{ .compatible = "qcom,msm8974-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
{ .compatible = "qcom,msm8994-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 2/2] hwspinlock: qcom: Remove IPQ6018 SOC specific compatible
2023-09-05 9:55 ` [PATCH v2 2/2] hwspinlock: qcom: Remove IPQ6018 SOC specific compatible Vignesh Viswanathan
@ 2023-09-05 16:08 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-09-05 16:08 UTC (permalink / raw)
To: Vignesh Viswanathan, agross, andersson, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
linux-kernel, ohad, baolin.wang, linux-remoteproc
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara,
quic_varada, stable
On 5.09.2023 11:55, Vignesh Viswanathan wrote:
> IPQ6018 has 32 tcsr_mutex hwlock registers with stride 0x1000.
> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
> and doesn't match the HW present in IPQ6018.
>
> Remove IPQ6018 specific compatible string so that it fallsback to
> of_tcsr_mutex data which maps to the correct configuration for IPQ6018.
>
> Changes in v2:
> - Updated commit message
> - Added Fixes and stable tags
>
> Cc: stable@vger.kernel.org
> Fixes: 5d4753f741d8 ("hwspinlock: qcom: add support for MMIO on older SoCs")
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018
2023-09-05 9:55 [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018 Vignesh Viswanathan
2023-09-05 9:55 ` [PATCH v2 1/2] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size Vignesh Viswanathan
2023-09-05 9:55 ` [PATCH v2 2/2] hwspinlock: qcom: Remove IPQ6018 SOC specific compatible Vignesh Viswanathan
@ 2023-09-20 3:58 ` Bjorn Andersson
2023-09-20 17:02 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2023-09-20 3:58 UTC (permalink / raw)
To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-msm, devicetree, linux-kernel, ohad, baolin.wang,
linux-remoteproc, Vignesh Viswanathan
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara, quic_varada
On Tue, 05 Sep 2023 15:25:33 +0530, Vignesh Viswanathan wrote:
> IPQ6018 has 32 tcsr_mutex hwlock registers of 0x1000 size each.
> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
> and doesn't match the HW present in IPQ6018.
>
> This series fixes the following:
> 1. Fix the tcsr_mutex register size to 0x20000 in IPQ6018 DTSI.
> 2. Remove IPQ6018 specific compatible in hwspinlock driver so that it
> falls back to pick of_tcsr_mutex data.
>
> [...]
Applied, thanks!
[1/2] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size
commit: 72fc3d58b87b0d622039c6299b89024fbb7b420f
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: (subset) [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018
2023-09-05 9:55 [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018 Vignesh Viswanathan
` (2 preceding siblings ...)
2023-09-20 3:58 ` (subset) [PATCH v2 0/2] Fix tcsr_mutex register for IPQ6018 Bjorn Andersson
@ 2023-09-20 17:02 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2023-09-20 17:02 UTC (permalink / raw)
To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-msm, devicetree, linux-kernel, ohad, baolin.wang,
linux-remoteproc, Vignesh Viswanathan
Cc: quic_kathirav, quic_anusha, quic_sjaganat, quic_srichara, quic_varada
On Tue, 05 Sep 2023 15:25:33 +0530, Vignesh Viswanathan wrote:
> IPQ6018 has 32 tcsr_mutex hwlock registers of 0x1000 size each.
> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
> and doesn't match the HW present in IPQ6018.
>
> This series fixes the following:
> 1. Fix the tcsr_mutex register size to 0x20000 in IPQ6018 DTSI.
> 2. Remove IPQ6018 specific compatible in hwspinlock driver so that it
> falls back to pick of_tcsr_mutex data.
>
> [...]
Applied, thanks!
[2/2] hwspinlock: qcom: Remove IPQ6018 SOC specific compatible
commit: 823313068617bf2414c6067504b4e2ce5768e601
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread