From: Rob Herring <robh@kernel.org> To: Billy Tsai <billy_tsai@aspeedtech.com> Cc: jdelvare@suse.com, linux@roeck-us.net, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, corbet@lwn.net, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, p.zabel@pengutronix.de, naresh.solanki@9elements.com, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, BMC-SW@aspeedtech.com, patrick@stwcx.xyz Subject: Re: [PATCH v8 1/3] dt-bindings: hwmon: fan: Add fan binding to schema Date: Tue, 5 Sep 2023 12:00:10 -0500 [thread overview] Message-ID: <20230905170010.GA3505375-robh@kernel.org> (raw) In-Reply-To: <20230830123202.3408318-2-billy_tsai@aspeedtech.com> On Wed, Aug 30, 2023 at 08:32:00PM +0800, Billy Tsai wrote: > From: Naresh Solanki <naresh.solanki@9elements.com> > > Add common fan properties bindings to a schema. > > Bindings for fan controllers can reference the common schema for the > fan > > child nodes: > > patternProperties: > "^fan@[0-2]": > type: object > $ref: fan-common.yaml# unevaluatedProperties: false > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > --- > .../devicetree/bindings/hwmon/fan-common.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml > new file mode 100644 > index 000000000000..a69b4d553e45 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause Drop 'or-later'. It's GPL2 only. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Fan Properties > + > +maintainers: > + - Naresh Solanki <naresh.solanki@9elements.com> > + - Billy Tsai <billy_tsai@aspeedtech.com> > + > +properties: > + max-rpm: > + description: > + Max RPM supported by fan. > + $ref: /schemas/types.yaml#/definitions/uint32 Physics will limit this to something much less than 2^32. Add some constraints. 10000? > + > + min-rpm: > + description: > + Min RPM supported by fan. > + $ref: /schemas/types.yaml#/definitions/uint32 ditto > + > + pulses-per-revolution: > + description: > + The number of pulse from fan sensor per revolution. > + $ref: /schemas/types.yaml#/definitions/uint32 Needs constraints. I assume this is never more than 4 (or 2 even)? > + div: Too generic of a name. > + description: > + Fan clock divisor But what is a fan clock? > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + target-rpm: > + description: > + Target RPM the fan should be configured during driver probe. What driver? By the time the OS driver runs, a bunch of other boot software has already run on modern systems. So this value would likely be used much earlier. The point is that when exactly is outside the scope of DT. This is "what RPM do I use in case of no other information (e.g. temperature)". > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + mode: Too generic. > + description: > + Select the operational mode of the fan. What are modes? Spin and don't spin? > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + pwms: > + description: > + PWM provider. maxItems: 1 I don't think there are fans with more than 1 PWM input? > + > + tach-ch: > + description: > + The tach channel used for the fan. > + $ref: /schemas/types.yaml#/definitions/uint32 The existing ASpeed version of this property allows more than 1 entry. I don't understand how a fan would have 2 tach signals, but if so, the generic property should allow for that. Perhaps 'reg' should be defined in here with some text saying 'reg' corresponds to the fan controller specific id which may be the PWM+TACH channel, PWM channel (deprecated), or TACH channel. I think there are examples of all 3 of these cases. > + > + label: > + description: > + Optional fan label > + > + fan-supply: > + description: > + Power supply for fan. > + > +additionalProperties: true > + > +... > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Billy Tsai <billy_tsai@aspeedtech.com> Cc: jdelvare@suse.com, linux@roeck-us.net, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, andrew@aj.id.au, corbet@lwn.net, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, p.zabel@pengutronix.de, naresh.solanki@9elements.com, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, BMC-SW@aspeedtech.com, patrick@stwcx.xyz Subject: Re: [PATCH v8 1/3] dt-bindings: hwmon: fan: Add fan binding to schema Date: Tue, 5 Sep 2023 12:00:10 -0500 [thread overview] Message-ID: <20230905170010.GA3505375-robh@kernel.org> (raw) In-Reply-To: <20230830123202.3408318-2-billy_tsai@aspeedtech.com> On Wed, Aug 30, 2023 at 08:32:00PM +0800, Billy Tsai wrote: > From: Naresh Solanki <naresh.solanki@9elements.com> > > Add common fan properties bindings to a schema. > > Bindings for fan controllers can reference the common schema for the > fan > > child nodes: > > patternProperties: > "^fan@[0-2]": > type: object > $ref: fan-common.yaml# unevaluatedProperties: false > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > --- > .../devicetree/bindings/hwmon/fan-common.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml > new file mode 100644 > index 000000000000..a69b4d553e45 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause Drop 'or-later'. It's GPL2 only. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Fan Properties > + > +maintainers: > + - Naresh Solanki <naresh.solanki@9elements.com> > + - Billy Tsai <billy_tsai@aspeedtech.com> > + > +properties: > + max-rpm: > + description: > + Max RPM supported by fan. > + $ref: /schemas/types.yaml#/definitions/uint32 Physics will limit this to something much less than 2^32. Add some constraints. 10000? > + > + min-rpm: > + description: > + Min RPM supported by fan. > + $ref: /schemas/types.yaml#/definitions/uint32 ditto > + > + pulses-per-revolution: > + description: > + The number of pulse from fan sensor per revolution. > + $ref: /schemas/types.yaml#/definitions/uint32 Needs constraints. I assume this is never more than 4 (or 2 even)? > + div: Too generic of a name. > + description: > + Fan clock divisor But what is a fan clock? > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + target-rpm: > + description: > + Target RPM the fan should be configured during driver probe. What driver? By the time the OS driver runs, a bunch of other boot software has already run on modern systems. So this value would likely be used much earlier. The point is that when exactly is outside the scope of DT. This is "what RPM do I use in case of no other information (e.g. temperature)". > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + mode: Too generic. > + description: > + Select the operational mode of the fan. What are modes? Spin and don't spin? > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + pwms: > + description: > + PWM provider. maxItems: 1 I don't think there are fans with more than 1 PWM input? > + > + tach-ch: > + description: > + The tach channel used for the fan. > + $ref: /schemas/types.yaml#/definitions/uint32 The existing ASpeed version of this property allows more than 1 entry. I don't understand how a fan would have 2 tach signals, but if so, the generic property should allow for that. Perhaps 'reg' should be defined in here with some text saying 'reg' corresponds to the fan controller specific id which may be the PWM+TACH channel, PWM channel (deprecated), or TACH channel. I think there are examples of all 3 of these cases. > + > + label: > + description: > + Optional fan label > + > + fan-supply: > + description: > + Power supply for fan. > + > +additionalProperties: true > + > +... > -- > 2.25.1 >
next prev parent reply other threads:[~2023-09-05 17:00 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-30 12:31 [PATCH v8 0/3] Support pwm/tach driver for aspeed ast26xx Billy Tsai 2023-08-30 12:31 ` Billy Tsai 2023-08-30 12:32 ` [PATCH v8 1/3] dt-bindings: hwmon: fan: Add fan binding to schema Billy Tsai 2023-08-30 12:32 ` Billy Tsai 2023-09-05 17:00 ` Rob Herring [this message] 2023-09-05 17:00 ` Rob Herring 2023-09-07 7:17 ` Billy Tsai 2023-09-07 7:17 ` Billy Tsai 2023-09-07 19:43 ` Rob Herring 2023-09-07 19:43 ` Rob Herring 2023-09-08 8:49 ` Billy Tsai 2023-09-08 8:49 ` Billy Tsai 2023-09-12 15:11 ` Rob Herring 2023-09-12 15:11 ` Rob Herring 2023-08-30 12:32 ` [PATCH v8 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control Billy Tsai 2023-08-30 12:32 ` Billy Tsai 2023-09-05 17:07 ` Rob Herring 2023-09-05 17:07 ` Rob Herring 2023-09-07 7:24 ` Billy Tsai 2023-09-07 7:24 ` Billy Tsai 2023-08-30 12:32 ` [PATCH v8 3/3] hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach Billy Tsai 2023-08-30 12:32 ` Billy Tsai 2023-09-01 4:54 ` Potin Lai 2023-09-01 4:54 ` Potin Lai 2023-09-01 5:10 ` Billy Tsai 2023-09-01 5:10 ` Billy Tsai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230905170010.GA3505375-robh@kernel.org \ --to=robh@kernel.org \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=billy_tsai@aspeedtech.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=jdelvare@suse.com \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=naresh.solanki@9elements.com \ --cc=p.zabel@pengutronix.de \ --cc=patrick@stwcx.xyz \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.