* [PATCH] firewire: allow deactivating the IEEE1394 menuconfig section at once
@ 2023-09-06 8:12 Jan Engelhardt
2023-09-07 10:16 ` Takashi Sakamoto
0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2023-09-06 8:12 UTC (permalink / raw)
To: o-takashi; +Cc: linux1394-devel, linux-kernel
Presently, one needs to enter "FireWire (IEEE 1394) subsystem --->",
then deselect all options individually. Speed up that process by
making the "--->" line be togglable in its own right.
Signed-off-by: Jan Engelhardt <jengelh@inai.de>
---
drivers/firewire/Kconfig | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
index 0a6596b027db..be1a9e685782 100644
--- a/drivers/firewire/Kconfig
+++ b/drivers/firewire/Kconfig
@@ -1,8 +1,18 @@
# SPDX-License-Identifier: GPL-2.0-only
-menu "IEEE 1394 (FireWire) support"
+menuconfig FIREWIRE_SUPPORT
+ bool "IEEE 1394 (FireWire) support"
+ default y
depends on PCI || COMPILE_TEST
# firewire-core does not depend on PCI but is
# not useful without PCI controller driver
+ help
+ Support for FireWire.
+
+ The answer to this question will not directly affect the
+ kernel: saying N will just cause the configurator to skip all
+ the questions about FireWire.
+
+if FIREWIRE_SUPPORT
config FIREWIRE
tristate "FireWire driver stack"
@@ -96,4 +106,4 @@ config FIREWIRE_NOSY
If unsure, say N.
-endmenu
+endif # FIREWIRE_SUPPORT
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firewire: allow deactivating the IEEE1394 menuconfig section at once
2023-09-06 8:12 [PATCH] firewire: allow deactivating the IEEE1394 menuconfig section at once Jan Engelhardt
@ 2023-09-07 10:16 ` Takashi Sakamoto
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Sakamoto @ 2023-09-07 10:16 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: linux1394-devel, linux-kernel
Hi,
On Wed, Sep 06, 2023 at 10:12:16AM +0200, Jan Engelhardt wrote:
> Presently, one needs to enter "FireWire (IEEE 1394) subsystem --->",
> then deselect all options individually. Speed up that process by
> making the "--->" line be togglable in its own right.
>
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> drivers/firewire/Kconfig | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
We are at the second half of merge window for v6.6 kernel, while the patch
looks good to me. I applied it to for-next branch and will send it to Linus
within a few days, after it passes check by for-next integration.
> diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
> index 0a6596b027db..be1a9e685782 100644
> --- a/drivers/firewire/Kconfig
> +++ b/drivers/firewire/Kconfig
> @@ -1,8 +1,18 @@
> # SPDX-License-Identifier: GPL-2.0-only
> -menu "IEEE 1394 (FireWire) support"
> +menuconfig FIREWIRE_SUPPORT
> + bool "IEEE 1394 (FireWire) support"
> + default y
> depends on PCI || COMPILE_TEST
> # firewire-core does not depend on PCI but is
> # not useful without PCI controller driver
> + help
> + Support for FireWire.
> +
> + The answer to this question will not directly affect the
> + kernel: saying N will just cause the configurator to skip all
> + the questions about FireWire.
> +
> +if FIREWIRE_SUPPORT
>
> config FIREWIRE
> tristate "FireWire driver stack"
> @@ -96,4 +106,4 @@ config FIREWIRE_NOSY
>
> If unsure, say N.
>
> -endmenu
> +endif # FIREWIRE_SUPPORT
> --
> 2.42.0
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-07 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06 8:12 [PATCH] firewire: allow deactivating the IEEE1394 menuconfig section at once Jan Engelhardt
2023-09-07 10:16 ` Takashi Sakamoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.