All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] bcachefs: Remove unneeded semicolon
@ 2023-09-13  0:57 Yang Li
  2023-09-13 10:46 ` Brian Foster
  0 siblings, 1 reply; 5+ messages in thread
From: Yang Li @ 2023-09-13  0:57 UTC (permalink / raw)
  To: kent.overstreet, bfoster; +Cc: linux-bcachefs, linux-kernel, Yang Li

./fs/bcachefs/btree_gc.c:1249:2-3: Unneeded semicolon
./fs/bcachefs/btree_gc.c:1521:2-3: Unneeded semicolon
./fs/bcachefs/btree_gc.c:1575:2-3: Unneeded semicolon
./fs/bcachefs/counters.c:46:2-3: Unneeded semicolon

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/bcachefs/btree_gc.c | 6 +++---
 fs/bcachefs/counters.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/bcachefs/btree_gc.c b/fs/bcachefs/btree_gc.c
index dac2eb76c985..56c671638c43 100644
--- a/fs/bcachefs/btree_gc.c
+++ b/fs/bcachefs/btree_gc.c
@@ -1246,7 +1246,7 @@ static int bch2_gc_done(struct bch_fs *c,
 			copy_dev_field(d[i].sectors,	"%s sectors", bch2_data_types[i]);
 			copy_dev_field(d[i].fragmented,	"%s fragmented", bch2_data_types[i]);
 		}
-	};
+	}
 
 	{
 		unsigned nr = fs_usage_u64s(c);
@@ -1518,7 +1518,7 @@ static int bch2_gc_alloc_start(struct bch_fs *c, bool metadata_only)
 		buckets->first_bucket	= ca->mi.first_bucket;
 		buckets->nbuckets	= ca->mi.nbuckets;
 		rcu_assign_pointer(ca->buckets_gc, buckets);
-	};
+	}
 
 	bch2_trans_init(&trans, c, 0, 0);
 
@@ -1572,7 +1572,7 @@ static void bch2_gc_alloc_reset(struct bch_fs *c, bool metadata_only)
 			g->dirty_sectors = 0;
 			g->cached_sectors = 0;
 		}
-	};
+	}
 }
 
 static int bch2_gc_write_reflink_key(struct btree_trans *trans,
diff --git a/fs/bcachefs/counters.c b/fs/bcachefs/counters.c
index 442a9b806a3c..26eb3d82b1cb 100644
--- a/fs/bcachefs/counters.c
+++ b/fs/bcachefs/counters.c
@@ -43,7 +43,7 @@ static void bch2_sb_counters_to_text(struct printbuf *out, struct bch_sb *sb,
 		prt_tab(out);
 		prt_printf(out, "%llu", le64_to_cpu(ctrs->d[i]));
 		prt_newline(out);
-	};
+	}
 };
 
 int bch2_sb_counters_to_cpu(struct bch_fs *c)
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] bcachefs: Remove unneeded semicolon
  2023-09-13  0:57 [PATCH -next] bcachefs: Remove unneeded semicolon Yang Li
@ 2023-09-13 10:46 ` Brian Foster
  0 siblings, 0 replies; 5+ messages in thread
From: Brian Foster @ 2023-09-13 10:46 UTC (permalink / raw)
  To: Yang Li; +Cc: kent.overstreet, linux-bcachefs, linux-kernel

On Wed, Sep 13, 2023 at 08:57:56AM +0800, Yang Li wrote:
> ./fs/bcachefs/btree_gc.c:1249:2-3: Unneeded semicolon
> ./fs/bcachefs/btree_gc.c:1521:2-3: Unneeded semicolon
> ./fs/bcachefs/btree_gc.c:1575:2-3: Unneeded semicolon
> ./fs/bcachefs/counters.c:46:2-3: Unneeded semicolon
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---

What produces these warnings? It would be help to add a sentence or two
of such context in the commit log.. even just a "XYZ reports the
following: ..."

Nit aside, patch seems fine to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/bcachefs/btree_gc.c | 6 +++---
>  fs/bcachefs/counters.c | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/bcachefs/btree_gc.c b/fs/bcachefs/btree_gc.c
> index dac2eb76c985..56c671638c43 100644
> --- a/fs/bcachefs/btree_gc.c
> +++ b/fs/bcachefs/btree_gc.c
> @@ -1246,7 +1246,7 @@ static int bch2_gc_done(struct bch_fs *c,
>  			copy_dev_field(d[i].sectors,	"%s sectors", bch2_data_types[i]);
>  			copy_dev_field(d[i].fragmented,	"%s fragmented", bch2_data_types[i]);
>  		}
> -	};
> +	}
>  
>  	{
>  		unsigned nr = fs_usage_u64s(c);
> @@ -1518,7 +1518,7 @@ static int bch2_gc_alloc_start(struct bch_fs *c, bool metadata_only)
>  		buckets->first_bucket	= ca->mi.first_bucket;
>  		buckets->nbuckets	= ca->mi.nbuckets;
>  		rcu_assign_pointer(ca->buckets_gc, buckets);
> -	};
> +	}
>  
>  	bch2_trans_init(&trans, c, 0, 0);
>  
> @@ -1572,7 +1572,7 @@ static void bch2_gc_alloc_reset(struct bch_fs *c, bool metadata_only)
>  			g->dirty_sectors = 0;
>  			g->cached_sectors = 0;
>  		}
> -	};
> +	}
>  }
>  
>  static int bch2_gc_write_reflink_key(struct btree_trans *trans,
> diff --git a/fs/bcachefs/counters.c b/fs/bcachefs/counters.c
> index 442a9b806a3c..26eb3d82b1cb 100644
> --- a/fs/bcachefs/counters.c
> +++ b/fs/bcachefs/counters.c
> @@ -43,7 +43,7 @@ static void bch2_sb_counters_to_text(struct printbuf *out, struct bch_sb *sb,
>  		prt_tab(out);
>  		prt_printf(out, "%llu", le64_to_cpu(ctrs->d[i]));
>  		prt_newline(out);
> -	};
> +	}
>  };
>  
>  int bch2_sb_counters_to_cpu(struct bch_fs *c)
> -- 
> 2.20.1.7.g153144c
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH -next] bcachefs: Remove unneeded semicolon
@ 2024-01-03  1:07 Yang Li
  0 siblings, 0 replies; 5+ messages in thread
From: Yang Li @ 2024-01-03  1:07 UTC (permalink / raw)
  To: kent.overstreet, bfoster; +Cc: linux-bcachefs, linux-kernel, Yang Li

./fs/bcachefs/super.c:1093:59-60: Unneeded semicolon
./fs/bcachefs/super.c:1097:59-60: Unneeded semicolon

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/bcachefs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 64ff7da49860..bc254d69b596 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1090,11 +1090,11 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
 		prt_newline(&buf);
 
 		prt_printf(&buf, "%pg ", fs->bdev);
-		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
+		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
 		prt_newline(&buf);
 
 		prt_printf(&buf, "%pg ", sb->bdev);
-		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
+		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
 		prt_newline(&buf);
 
 		prt_printf(&buf, "Not using older sb");
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH -next] bcachefs: Remove unneeded semicolon
@ 2023-11-22  0:43 Yang Li
  0 siblings, 0 replies; 5+ messages in thread
From: Yang Li @ 2023-11-22  0:43 UTC (permalink / raw)
  To: kent.overstreet, bfoster
  Cc: linux-bcachefs, linux-kernel, Yang Li, Abaci Robot

./fs/bcachefs/btree_write_buffer.c:285:63-64: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7602
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/bcachefs/btree_write_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/btree_write_buffer.c b/fs/bcachefs/btree_write_buffer.c
index dce61d3949f3..e01664f10a8e 100644
--- a/fs/bcachefs/btree_write_buffer.c
+++ b/fs/bcachefs/btree_write_buffer.c
@@ -282,7 +282,7 @@ static int bch2_btree_write_buffer_flush_locked(struct btree_trans *trans)
 			struct btree_write_buffered_key *n = &wb->flushing.keys.data[i[1].idx];
 
 			skipped++;
-			n->journal_seq = min_t(u64, n->journal_seq, k->journal_seq);;
+			n->journal_seq = min_t(u64, n->journal_seq, k->journal_seq);
 			k->journal_seq = 0;
 			continue;
 		}
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH -next] bcachefs: Remove unneeded semicolon
@ 2023-11-02  0:36 Yang Li
  0 siblings, 0 replies; 5+ messages in thread
From: Yang Li @ 2023-11-02  0:36 UTC (permalink / raw)
  To: kent.overstreet, bfoster
  Cc: linux-bcachefs, linux-kernel, Yang Li, Abaci Robot

./fs/bcachefs/reflink.c:112:32-33: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7114
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/bcachefs/reflink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/reflink.c b/fs/bcachefs/reflink.c
index eb31df605c2e..958d9ea718b0 100644
--- a/fs/bcachefs/reflink.c
+++ b/fs/bcachefs/reflink.c
@@ -109,7 +109,7 @@ static inline void check_indirect_extent_deleting(struct bkey_i *new, unsigned *
 	if ((*flags & BTREE_TRIGGER_INSERT) && !*bkey_refcount(new)) {
 		new->k.type = KEY_TYPE_deleted;
 		new->k.size = 0;
-		set_bkey_val_u64s(&new->k, 0);;
+		set_bkey_val_u64s(&new->k, 0);
 		*flags &= ~BTREE_TRIGGER_INSERT;
 	}
 }
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-03  1:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-13  0:57 [PATCH -next] bcachefs: Remove unneeded semicolon Yang Li
2023-09-13 10:46 ` Brian Foster
2023-11-02  0:36 Yang Li
2023-11-22  0:43 Yang Li
2024-01-03  1:07 Yang Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.