* [PATCH v4] xfs: introduce protection for drop nlink
@ 2023-09-18 6:50 cheng.lin130
2023-09-19 3:31 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: cheng.lin130 @ 2023-09-18 6:50 UTC (permalink / raw)
To: david, djwong
Cc: linux-xfs, linux-kernel, jiang.yong5, wang.liang82, liu.dong3
From: Cheng Lin <cheng.lin130@zte.com.cn>
When abnormal drop_nlink are detected on the inode,
return error, to avoid corruption propagation.
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
---
fs/xfs/xfs_inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 9e62cc500..d16cb62ce 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -919,6 +919,14 @@ xfs_droplink(
xfs_trans_t *tp,
xfs_inode_t *ip)
{
+
+ if (VFS_I(ip)->i_nlink == 0) {
+ xfs_alert(ip->i_mount,
+ "%s: Deleting inode %llu with no links.",
+ __func__, ip->i_ino);
+ return -EFSCORRUPTED;
+ }
+
xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
drop_nlink(VFS_I(ip));
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] xfs: introduce protection for drop nlink
2023-09-18 6:50 [PATCH v4] xfs: introduce protection for drop nlink cheng.lin130
@ 2023-09-19 3:31 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2023-09-19 3:31 UTC (permalink / raw)
To: cheng.lin130
Cc: david, linux-xfs, linux-kernel, jiang.yong5, wang.liang82, liu.dong3
On Mon, Sep 18, 2023 at 02:50:50PM +0800, cheng.lin130@zte.com.cn wrote:
> From: Cheng Lin <cheng.lin130@zte.com.cn>
>
> When abnormal drop_nlink are detected on the inode,
> return error, to avoid corruption propagation.
>
> Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
> ---
> fs/xfs/xfs_inode.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index 9e62cc500..d16cb62ce 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -919,6 +919,14 @@ xfs_droplink(
> xfs_trans_t *tp,
> xfs_inode_t *ip)
> {
> +
> + if (VFS_I(ip)->i_nlink == 0) {
> + xfs_alert(ip->i_mount,
> + "%s: Deleting inode %llu with no links.",
> + __func__, ip->i_ino);
We're not deleting the zero-nlink file, since we return without changing
the link count.
Also wondering why this doesn't use XFS_IS_CORRUPT? That macro already
logs a message about there being problems:
struct xfs_mount *mp = ip->i_mount;
if (XFS_IS_CORRUPT(mp, VFS_I(ip)->i_nlink == 0))
return -EFSCORRUPTED;
--D
> + return -EFSCORRUPTED;
> + }
> +
> xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
>
> drop_nlink(VFS_I(ip));
> --
> 2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-19 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 6:50 [PATCH v4] xfs: introduce protection for drop nlink cheng.lin130
2023-09-19 3:31 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.