All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
@ 2023-09-25 21:24 ` Rob Herring
  0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-09-25 21:24 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	Marijn Suijten, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
	Conor Dooley, Kuogee Hsieh
  Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel

Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index f12558960cd8..dbe398f84ffb 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -114,6 +114,7 @@ properties:
 
       port@1:
         $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: Output endpoint of the controller
         properties:
           endpoint:
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
@ 2023-09-25 21:24 ` Rob Herring
  0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-09-25 21:24 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	Marijn Suijten, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
	Conor Dooley, Kuogee Hsieh
  Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel, devicetree

Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index f12558960cd8..dbe398f84ffb 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -114,6 +114,7 @@ properties:
 
       port@1:
         $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: Output endpoint of the controller
         properties:
           endpoint:
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
  2023-09-25 21:24 ` Rob Herring
@ 2023-09-25 21:24   ` Rob Herring
  -1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-09-25 21:24 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	Marijn Suijten, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
	Conor Dooley, Kuogee Hsieh, Del Regno, Loic Poulain,
	Krishna Manikandan, Bjorn Andersson, Konrad Dybcio, Robert Foss,
	Neil Armstrong
  Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel

Make it explicit that child nodes have additional properties and the
child node schema is not complete. The complete schemas are applied
separately based the compatible strings.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/display/msm/qcom,msm8998-mdss.yaml        |  6 ++++++
 .../bindings/display/msm/qcom,qcm2290-mdss.yaml        |  6 ++++++
 .../bindings/display/msm/qcom,sc7180-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sc7280-mdss.yaml         | 10 ++++++++++
 .../bindings/display/msm/qcom,sc8280xp-mdss.yaml       |  4 ++++
 .../bindings/display/msm/qcom,sdm845-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sm6115-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm6125-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm6350-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm6375-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm8150-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm8250-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm8350-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sm8450-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sm8550-mdss.yaml         |  8 ++++++++
 15 files changed, 102 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
index e320ab1de6de..2d9edab5a30d 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
@@ -38,12 +38,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,msm8998-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -52,6 +56,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm-8998
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
index 4184b84d4c21..5ad155612b6c 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
@@ -44,18 +44,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,qcm2290-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-ctrl-6g-qcm2290
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-14nm-2290
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
index 3b9c103e504a..3432a2407caa 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
@@ -44,18 +44,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7180-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7180-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -64,6 +70,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
index 43500dad66e7..bbb727831fca 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
@@ -44,18 +44,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7280-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7280-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -64,12 +70,16 @@ patternProperties:
 
   "^edp@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7280-edp
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         enum:
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
index db680fb12b6a..af79406e1604 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
@@ -34,12 +34,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc8280xp-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         enum:
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
index d6d7ac1b2ef8..6e8b69e5ec62 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
@@ -42,18 +42,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sdm845-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sdm845-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -62,6 +68,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
index 17221b62a642..dde5c2acead5 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
@@ -32,12 +32,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6115-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         oneOf:
@@ -50,6 +54,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-14nm-2290
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
index 57f0e3647711..671c2c2aa896 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
@@ -43,12 +43,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6125-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -57,6 +61,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6125-dsi-phy-14nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
index db255b1f4c20..e1dcb453762e 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
@@ -43,12 +43,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6350-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -57,6 +61,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
index 30d36fffaedb..b15c3950f09d 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
@@ -43,12 +43,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6375-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -57,6 +61,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6375-dsi-phy-7nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
index 54cdaa827cd3..a2a8be7f64a9 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
@@ -47,12 +47,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8150-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -61,6 +65,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-7nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
index e887f031b8be..994975909fea 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
@@ -46,12 +46,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8250-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -60,6 +64,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-7nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
index 60d4aae1131b..163fc83c1e80 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
@@ -48,18 +48,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8350-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8350-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -68,6 +74,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8350-dsi-phy-5nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
index bb22940b9385..001b26e65301 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
@@ -38,12 +38,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8450-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -52,6 +56,8 @@ patternProperties:
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -60,6 +66,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8450-dsi-phy-5nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
index 48aea8005c86..1ea50a2c7c8e 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
@@ -38,12 +38,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8550-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -52,6 +56,8 @@ patternProperties:
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -60,6 +66,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8550-dsi-phy-4nm
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
@ 2023-09-25 21:24   ` Rob Herring
  0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-09-25 21:24 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	Marijn Suijten, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
	Conor Dooley, Kuogee Hsieh, Del Regno, Loic Poulain,
	Krishna Manikandan, Bjorn Andersson, Konrad Dybcio, Robert Foss,
	Neil Armstrong
  Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel, devicetree

Make it explicit that child nodes have additional properties and the
child node schema is not complete. The complete schemas are applied
separately based the compatible strings.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/display/msm/qcom,msm8998-mdss.yaml        |  6 ++++++
 .../bindings/display/msm/qcom,qcm2290-mdss.yaml        |  6 ++++++
 .../bindings/display/msm/qcom,sc7180-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sc7280-mdss.yaml         | 10 ++++++++++
 .../bindings/display/msm/qcom,sc8280xp-mdss.yaml       |  4 ++++
 .../bindings/display/msm/qcom,sdm845-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sm6115-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm6125-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm6350-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm6375-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm8150-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm8250-mdss.yaml         |  6 ++++++
 .../bindings/display/msm/qcom,sm8350-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sm8450-mdss.yaml         |  8 ++++++++
 .../bindings/display/msm/qcom,sm8550-mdss.yaml         |  8 ++++++++
 15 files changed, 102 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
index e320ab1de6de..2d9edab5a30d 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
@@ -38,12 +38,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,msm8998-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -52,6 +56,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm-8998
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
index 4184b84d4c21..5ad155612b6c 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
@@ -44,18 +44,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,qcm2290-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-ctrl-6g-qcm2290
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-14nm-2290
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
index 3b9c103e504a..3432a2407caa 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
@@ -44,18 +44,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7180-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7180-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -64,6 +70,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
index 43500dad66e7..bbb727831fca 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
@@ -44,18 +44,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7280-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7280-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -64,12 +70,16 @@ patternProperties:
 
   "^edp@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc7280-edp
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         enum:
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
index db680fb12b6a..af79406e1604 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
@@ -34,12 +34,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sc8280xp-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         enum:
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
index d6d7ac1b2ef8..6e8b69e5ec62 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
@@ -42,18 +42,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sdm845-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sdm845-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -62,6 +68,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
index 17221b62a642..dde5c2acead5 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
@@ -32,12 +32,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6115-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         oneOf:
@@ -50,6 +54,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-14nm-2290
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
index 57f0e3647711..671c2c2aa896 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
@@ -43,12 +43,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6125-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -57,6 +61,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6125-dsi-phy-14nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
index db255b1f4c20..e1dcb453762e 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
@@ -43,12 +43,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6350-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -57,6 +61,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-10nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
index 30d36fffaedb..b15c3950f09d 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
@@ -43,12 +43,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6375-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -57,6 +61,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm6375-dsi-phy-7nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
index 54cdaa827cd3..a2a8be7f64a9 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
@@ -47,12 +47,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8150-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -61,6 +65,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-7nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
index e887f031b8be..994975909fea 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
@@ -46,12 +46,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8250-dpu
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -60,6 +64,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,dsi-phy-7nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
index 60d4aae1131b..163fc83c1e80 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
@@ -48,18 +48,24 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8350-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8350-dp
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -68,6 +74,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8350-dsi-phy-5nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
index bb22940b9385..001b26e65301 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
@@ -38,12 +38,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8450-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -52,6 +56,8 @@ patternProperties:
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -60,6 +66,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8450-dsi-phy-5nm
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
index 48aea8005c86..1ea50a2c7c8e 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
@@ -38,12 +38,16 @@ properties:
 patternProperties:
   "^display-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8550-dpu
 
   "^displayport-controller@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -52,6 +56,8 @@ patternProperties:
 
   "^dsi@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         items:
@@ -60,6 +66,8 @@ patternProperties:
 
   "^phy@[0-9a-f]+$":
     type: object
+    additionalProperties: true
+
     properties:
       compatible:
         const: qcom,sm8550-dsi-phy-4nm
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
  2023-09-25 21:24 ` Rob Herring
@ 2023-09-26 12:56   ` Conor Dooley
  -1 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-09-26 12:56 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	Marijn Suijten, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
	Conor Dooley, Kuogee Hsieh, linux-arm-msm, dri-devel, freedreno,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Mon, Sep 25, 2023 at 04:24:24PM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index f12558960cd8..dbe398f84ffb 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -114,6 +114,7 @@ properties:
>  
>        port@1:
>          $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
>          description: Output endpoint of the controller
>          properties:
>            endpoint:
> -- 
> 2.40.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
@ 2023-09-26 12:56   ` Conor Dooley
  0 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-09-26 12:56 UTC (permalink / raw)
  To: Rob Herring
  Cc: freedreno, Conor Dooley, Krzysztof Kozlowski, devicetree,
	Abhinav Kumar, dri-devel, Kuogee Hsieh, linux-arm-msm,
	Dmitry Baryshkov, Marijn Suijten, Sean Paul, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Mon, Sep 25, 2023 at 04:24:24PM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index f12558960cd8..dbe398f84ffb 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -114,6 +114,7 @@ properties:
>  
>        port@1:
>          $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
>          description: Output endpoint of the controller
>          properties:
>            endpoint:
> -- 
> 2.40.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
  2023-09-25 21:24   ` Rob Herring
@ 2023-09-26 12:58     ` Conor Dooley
  -1 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-09-26 12:58 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
	Marijn Suijten, David Airlie, Daniel Vetter, Krzysztof Kozlowski,
	Conor Dooley, Kuogee Hsieh, Del Regno, Loic Poulain,
	Krishna Manikandan, Bjorn Andersson, Konrad Dybcio, Robert Foss,
	Neil Armstrong, linux-arm-msm, dri-devel, freedreno, devicetree,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 16979 bytes --]

On Mon, Sep 25, 2023 at 04:24:25PM -0500, Rob Herring wrote:
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

I cross-checked only a handful of these...
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  .../bindings/display/msm/qcom,msm8998-mdss.yaml        |  6 ++++++
>  .../bindings/display/msm/qcom,qcm2290-mdss.yaml        |  6 ++++++
>  .../bindings/display/msm/qcom,sc7180-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sc7280-mdss.yaml         | 10 ++++++++++
>  .../bindings/display/msm/qcom,sc8280xp-mdss.yaml       |  4 ++++
>  .../bindings/display/msm/qcom,sdm845-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sm6115-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm6125-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm6350-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm6375-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm8150-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm8250-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm8350-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sm8450-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sm8550-mdss.yaml         |  8 ++++++++
>  15 files changed, 102 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> index e320ab1de6de..2d9edab5a30d 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,msm8998-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -52,6 +56,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm-8998
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> index 4184b84d4c21..5ad155612b6c 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,qcm2290-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-ctrl-6g-qcm2290
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-14nm-2290
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> index 3b9c103e504a..3432a2407caa 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7180-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7180-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -64,6 +70,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> index 43500dad66e7..bbb727831fca 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7280-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7280-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -64,12 +70,16 @@ patternProperties:
>  
>    "^edp@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7280-edp
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          enum:
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> index db680fb12b6a..af79406e1604 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> @@ -34,12 +34,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc8280xp-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          enum:
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> index d6d7ac1b2ef8..6e8b69e5ec62 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> @@ -42,18 +42,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sdm845-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sdm845-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -62,6 +68,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> index 17221b62a642..dde5c2acead5 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> @@ -32,12 +32,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6115-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          oneOf:
> @@ -50,6 +54,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-14nm-2290
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> index 57f0e3647711..671c2c2aa896 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6125-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -57,6 +61,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6125-dsi-phy-14nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> index db255b1f4c20..e1dcb453762e 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6350-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -57,6 +61,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> index 30d36fffaedb..b15c3950f09d 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6375-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -57,6 +61,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6375-dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> index 54cdaa827cd3..a2a8be7f64a9 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> @@ -47,12 +47,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8150-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -61,6 +65,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> index e887f031b8be..994975909fea 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> @@ -46,12 +46,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8250-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -60,6 +64,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> index 60d4aae1131b..163fc83c1e80 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> @@ -48,18 +48,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8350-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8350-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -68,6 +74,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8350-dsi-phy-5nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> index bb22940b9385..001b26e65301 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8450-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -52,6 +56,8 @@ patternProperties:
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -60,6 +66,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8450-dsi-phy-5nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> index 48aea8005c86..1ea50a2c7c8e 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8550-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -52,6 +56,8 @@ patternProperties:
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -60,6 +66,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8550-dsi-phy-4nm
> -- 
> 2.40.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
@ 2023-09-26 12:58     ` Conor Dooley
  0 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-09-26 12:58 UTC (permalink / raw)
  To: Rob Herring
  Cc: dri-devel, Krishna Manikandan, Krzysztof Kozlowski, Del Regno,
	Marijn Suijten, Robert Foss, Kuogee Hsieh, devicetree,
	Conor Dooley, linux-arm-msm, Abhinav Kumar, Sean Paul,
	Neil Armstrong, Loic Poulain, Bjorn Andersson, linux-kernel,
	Konrad Dybcio, Dmitry Baryshkov, freedreno

[-- Attachment #1: Type: text/plain, Size: 16979 bytes --]

On Mon, Sep 25, 2023 at 04:24:25PM -0500, Rob Herring wrote:
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

I cross-checked only a handful of these...
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  .../bindings/display/msm/qcom,msm8998-mdss.yaml        |  6 ++++++
>  .../bindings/display/msm/qcom,qcm2290-mdss.yaml        |  6 ++++++
>  .../bindings/display/msm/qcom,sc7180-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sc7280-mdss.yaml         | 10 ++++++++++
>  .../bindings/display/msm/qcom,sc8280xp-mdss.yaml       |  4 ++++
>  .../bindings/display/msm/qcom,sdm845-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sm6115-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm6125-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm6350-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm6375-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm8150-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm8250-mdss.yaml         |  6 ++++++
>  .../bindings/display/msm/qcom,sm8350-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sm8450-mdss.yaml         |  8 ++++++++
>  .../bindings/display/msm/qcom,sm8550-mdss.yaml         |  8 ++++++++
>  15 files changed, 102 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> index e320ab1de6de..2d9edab5a30d 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,msm8998-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -52,6 +56,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm-8998
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> index 4184b84d4c21..5ad155612b6c 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,qcm2290-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-ctrl-6g-qcm2290
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-14nm-2290
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> index 3b9c103e504a..3432a2407caa 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7180-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7180-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -64,6 +70,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> index 43500dad66e7..bbb727831fca 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7280-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7280-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -64,12 +70,16 @@ patternProperties:
>  
>    "^edp@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc7280-edp
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          enum:
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> index db680fb12b6a..af79406e1604 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> @@ -34,12 +34,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sc8280xp-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          enum:
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> index d6d7ac1b2ef8..6e8b69e5ec62 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> @@ -42,18 +42,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sdm845-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sdm845-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -62,6 +68,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> index 17221b62a642..dde5c2acead5 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> @@ -32,12 +32,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6115-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          oneOf:
> @@ -50,6 +54,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-14nm-2290
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> index 57f0e3647711..671c2c2aa896 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6125-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -57,6 +61,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6125-dsi-phy-14nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> index db255b1f4c20..e1dcb453762e 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6350-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -57,6 +61,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> index 30d36fffaedb..b15c3950f09d 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6375-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -57,6 +61,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm6375-dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> index 54cdaa827cd3..a2a8be7f64a9 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> @@ -47,12 +47,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8150-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -61,6 +65,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> index e887f031b8be..994975909fea 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> @@ -46,12 +46,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8250-dpu
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -60,6 +64,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> index 60d4aae1131b..163fc83c1e80 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> @@ -48,18 +48,24 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8350-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8350-dp
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -68,6 +74,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8350-dsi-phy-5nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> index bb22940b9385..001b26e65301 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8450-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -52,6 +56,8 @@ patternProperties:
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -60,6 +66,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8450-dsi-phy-5nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> index 48aea8005c86..1ea50a2c7c8e 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
>  patternProperties:
>    "^display-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8550-dpu
>  
>    "^displayport-controller@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -52,6 +56,8 @@ patternProperties:
>  
>    "^dsi@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          items:
> @@ -60,6 +66,8 @@ patternProperties:
>  
>    "^phy@[0-9a-f]+$":
>      type: object
> +    additionalProperties: true
> +
>      properties:
>        compatible:
>          const: qcom,sm8550-dsi-phy-4nm
> -- 
> 2.40.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
  2023-09-25 21:24 ` Rob Herring
@ 2023-10-08 14:01   ` Dmitry Baryshkov
  -1 siblings, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2023-10-08 14:01 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Conor Dooley,
	Kuogee Hsieh, Rob Herring
  Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel


On Mon, 25 Sep 2023 16:24:24 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> 

Applied, thanks!

[1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
      https://gitlab.freedesktop.org/lumag/msm/-/commit/08bf97ab16f3
[2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
      https://gitlab.freedesktop.org/lumag/msm/-/commit/55bbcadccdec

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
@ 2023-10-08 14:01   ` Dmitry Baryshkov
  0 siblings, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2023-10-08 14:01 UTC (permalink / raw)
  To: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Conor Dooley,
	Kuogee Hsieh, Rob Herring
  Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel, devicetree


On Mon, 25 Sep 2023 16:24:24 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> 

Applied, thanks!

[1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas
      https://gitlab.freedesktop.org/lumag/msm/-/commit/08bf97ab16f3
[2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit
      https://gitlab.freedesktop.org/lumag/msm/-/commit/55bbcadccdec

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-10-08 14:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-25 21:24 [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas Rob Herring
2023-09-25 21:24 ` Rob Herring
2023-09-25 21:24 ` [PATCH 2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit Rob Herring
2023-09-25 21:24   ` Rob Herring
2023-09-26 12:58   ` Conor Dooley
2023-09-26 12:58     ` Conor Dooley
2023-09-26 12:56 ` [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas Conor Dooley
2023-09-26 12:56   ` Conor Dooley
2023-10-08 14:01 ` Dmitry Baryshkov
2023-10-08 14:01   ` Dmitry Baryshkov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.