From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
"daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
"deller@gmx.de" <deller@gmx.de>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH] backlight: pwm_bl: Disable PWM on shutdown and suspend disabled PWM emiting inactive state")
Date: Tue, 26 Sep 2023 09:30:15 +0100 [thread overview]
Message-ID: <20230926083015.GD9999@google.com> (raw)
In-Reply-To: <20230926071744.oikg3ndaq6x7yjrw@pengutronix.de>
On Tue, 26 Sep 2023, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Mar 22, 2023 at 09:51:29AM +0100, Uwe Kleine-König wrote:
> > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once
> > per backlight toggle") calling pwm_backlight_power_off() doesn't disable
> > the PWM any more. However this is necessary to suspend, because PWM
> > drivers usually refuse to suspend if they are still enabled.
> >
> > Also adapt shutdown to disable the PWM for similar reasons.
> >
> > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle")
> > Reported-by: Aisheng Dong <aisheng.dong@nxp.com>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> This patch was never applied but I think it is still needed. I assume it
> fell through the cracks?
This "patch" was sent half way through a thread and when opened in my
mail client looks like a mail reply due to the quotes below the '---'.
I'd suggest sending this again.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-09-26 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 5:13 [PATCH v2 1/2] backlight: pwm_bl: Configure pwm only once per backlight toggle Aisheng Dong
2023-03-22 7:03 ` Regression in deaeeda2051f ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state") Uwe Kleine-König
2023-03-22 8:10 ` Aisheng Dong
2023-03-22 8:51 ` [PATCH] backlight: pwm_bl: Disable PWM on shutdown and suspend " Uwe Kleine-König
2023-03-22 9:14 ` Aisheng Dong
2023-03-22 9:14 ` Aisheng Dong
2023-09-26 7:17 ` Uwe Kleine-König
2023-09-26 7:17 ` Uwe Kleine-König
2023-09-26 8:30 ` Lee Jones [this message]
2023-09-26 8:31 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926083015.GD9999@google.com \
--to=lee@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.