[PATCH v4] smartpqi: add module parameter disable_managed_interrupts

[PATCH v4] smartpqi: add module parameter disable_managed_interrupts

[Don Brace]

Add in a description for module parameter disable_managed_interrupts.

This module parameter allows users to disable automatic irq affinity
setting by turning off the PCI_IRQ_AFFINITY flag when requesting
interrupts.

When the flag PCI_IRQ_AFFINITY is set, users cannot change the interrupt
affinity through /proc/irq/<irq#>/*affinity*

Some customers would like to change interrupt affinity based on their
requirements.

Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 man4/smartpqi.4 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index 428d79a19840..613ef330aef1 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -16,6 +16,7 @@ smartpqi \- Microchip Smart Storage SCSI driver
 .RB [ lockup_action= { none | reboot | panic }]
 .RB [ expose_ld_first= { 0 | 1 }]
 .RB [ hide_vsep= { 0 | 1 }]
+.RB [ disable_managed_interrupts= { 0 | 1 }]
 .YS
 .SH DESCRIPTION
 .B smartpqi
@@ -100,6 +101,12 @@ The default value is 0 (physical devices exposed first).
 .BR hide_vsep= { 0 | 1 }
 This option disables exposure of the virtual SEP to the OS.
 The default value is 0 (virtual SEP is exposed).
+.TP
+.BR disable_managed_interrupts= { 0 | 1 }
+Disables driver utilization of Linux kernel managed interrupts for
+controllers. The managed interrupts feature automatically distributes
+interrupts to all available CPUs and assigns SMP affinity.
+The default value is 0 (managed interrupts enabled).
 .SH FILES
 .SS Device nodes
 Logical drives are accessed via the SCSI disk driver
-- 
2.42.0.158.g94e83dcf5b

[PATCH] smartpqi: add sg entry to see_also

[Don Brace]

The sg driver can interface with smartpqi. Add
this into the SEE ALSO section of the man page.

Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 man4/smartpqi.4 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
index 3de8b0c97423..7c1da3c80d57 100644
--- a/man4/smartpqi.4
+++ b/man4/smartpqi.4
@@ -462,7 +462,8 @@ which can be found by searching for the specific controller at
 .BR cciss (4),
 .BR hpsa (4),
 .BR sd (4),
-.BR st (4)
+.BR st (4),
+.BR sg (4)
 .PP
 .I Documentation/ABI/testing/sysfs\-bus\-pci\-devices\-cciss
 in the Linux kernel source tree.
-- 
2.42.0.158.g94e83dcf5b

Re: [PATCH v4] smartpqi: add module parameter disable_managed_interrupts

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]

On Wed, Sep 27, 2023 at 10:45:46AM -0500, Don Brace wrote:
> Add in a description for module parameter disable_managed_interrupts.
> 
> This module parameter allows users to disable automatic irq affinity
> setting by turning off the PCI_IRQ_AFFINITY flag when requesting
> interrupts.
> 
> When the flag PCI_IRQ_AFFINITY is set, users cannot change the interrupt
> affinity through /proc/irq/<irq#>/*affinity*
> 
> Some customers would like to change interrupt affinity based on their
> requirements.
> 
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>

Patch applied, Don.

Thanks,
Alex

> ---
>  man4/smartpqi.4 | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index 428d79a19840..613ef330aef1 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -16,6 +16,7 @@ smartpqi \- Microchip Smart Storage SCSI driver
>  .RB [ lockup_action= { none | reboot | panic }]
>  .RB [ expose_ld_first= { 0 | 1 }]
>  .RB [ hide_vsep= { 0 | 1 }]
> +.RB [ disable_managed_interrupts= { 0 | 1 }]
>  .YS
>  .SH DESCRIPTION
>  .B smartpqi
> @@ -100,6 +101,12 @@ The default value is 0 (physical devices exposed first).
>  .BR hide_vsep= { 0 | 1 }
>  This option disables exposure of the virtual SEP to the OS.
>  The default value is 0 (virtual SEP is exposed).
> +.TP
> +.BR disable_managed_interrupts= { 0 | 1 }
> +Disables driver utilization of Linux kernel managed interrupts for
> +controllers. The managed interrupts feature automatically distributes
> +interrupts to all available CPUs and assigns SMP affinity.
> +The default value is 0 (managed interrupts enabled).
>  .SH FILES
>  .SS Device nodes
>  Logical drives are accessed via the SCSI disk driver
> -- 
> 2.42.0.158.g94e83dcf5b
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] smartpqi: add sg entry to see_also

[Alejandro Colomar]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi Don,

On Wed, Sep 27, 2023 at 10:45:47AM -0500, Don Brace wrote:
> The sg driver can interface with smartpqi. Add
> this into the SEE ALSO section of the man page.
> 
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
> Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>

Patch applied.

Thanks,
Alex

> ---
>  man4/smartpqi.4 | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man4/smartpqi.4 b/man4/smartpqi.4
> index 3de8b0c97423..7c1da3c80d57 100644
> --- a/man4/smartpqi.4
> +++ b/man4/smartpqi.4
> @@ -462,7 +462,8 @@ which can be found by searching for the specific controller at
>  .BR cciss (4),
>  .BR hpsa (4),
>  .BR sd (4),
> -.BR st (4)
> +.BR st (4),
> +.BR sg (4)
>  .PP
>  .I Documentation/ABI/testing/sysfs\-bus\-pci\-devices\-cciss
>  in the Linux kernel source tree.
> -- 
> 2.42.0.158.g94e83dcf5b
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]