* [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section
@ 2023-09-29 14:19 Thomas Huth
2023-09-29 16:12 ` Leif Lindholm
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Huth @ 2023-09-29 14:19 UTC (permalink / raw)
To: Radoslaw Biernacki, Marcin Juszkiewicz, Peter Maydell, Leif Lindholm
Cc: qemu-arm, qemu-devel
These files belong to the sbsa-ref machine and thus should
be listed here.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 874234cb7b..fc415d3cea 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -954,6 +954,9 @@ R: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
L: qemu-arm@nongnu.org
S: Maintained
F: hw/arm/sbsa-ref.c
+F: hw/misc/sbsa_ec.c
+F: hw/watchdog/sbsa_gwdt.c
+F: include/hw/watchdog/sbsa_gwdt.h
F: docs/system/arm/sbsa.rst
F: tests/avocado/machine_aarch64_sbsaref.py
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section
2023-09-29 14:19 [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section Thomas Huth
@ 2023-09-29 16:12 ` Leif Lindholm
2023-10-05 14:31 ` Thomas Huth
2023-10-05 13:57 ` Markus Armbruster
2023-10-06 6:41 ` Michael Tokarev
2 siblings, 1 reply; 5+ messages in thread
From: Leif Lindholm @ 2023-09-29 16:12 UTC (permalink / raw)
To: Thomas Huth
Cc: Radoslaw Biernacki, Marcin Juszkiewicz, Peter Maydell, qemu-arm,
qemu-devel
On Fri, Sep 29, 2023 at 16:19:18 +0200, Thomas Huth wrote:
> These files belong to the sbsa-ref machine and thus should
> be listed here.
First of all, thanks for this.
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 874234cb7b..fc415d3cea 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -954,6 +954,9 @@ R: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/arm/sbsa-ref.c
> +F: hw/misc/sbsa_ec.c
Yes, pure oversight, sorry about that.
> +F: hw/watchdog/sbsa_gwdt.c
> +F: include/hw/watchdog/sbsa_gwdt.h
I just want to clarify that this is not "the watchdog for the SBSA
platform", but "the watchdog defined by Arm's SBSA specification"
(and belatedly the BSA specification)" - the specification that
sbsa-ref (intends to) provide a compliant platform implementation for.
Another such component is the "generic UART", but since that is a
subset of pl011 there is no real value in providing a dedicated model
of it.
Which I guess is a long-winded way of saying: this component does not
necessarily want/need the same maintainers as the sbsa-ref platform.
I'm still happy to maintain it, and it may make sense to keep it under
this header for now.
(In which case
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
)
Regards,
Leif
> F: docs/system/arm/sbsa.rst
> F: tests/avocado/machine_aarch64_sbsaref.py
>
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section
2023-09-29 14:19 [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section Thomas Huth
2023-09-29 16:12 ` Leif Lindholm
@ 2023-10-05 13:57 ` Markus Armbruster
2023-10-06 6:41 ` Michael Tokarev
2 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2023-10-05 13:57 UTC (permalink / raw)
To: qemu-trivial
Cc: Thomas Huth, Radoslaw Biernacki, Marcin Juszkiewicz,
Peter Maydell, Leif Lindholm, qemu-arm, qemu-devel
Nominating for qemu-trivial.
Thomas Huth <thuth@redhat.com> writes:
> These files belong to the sbsa-ref machine and thus should
> be listed here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 874234cb7b..fc415d3cea 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -954,6 +954,9 @@ R: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/arm/sbsa-ref.c
> +F: hw/misc/sbsa_ec.c
> +F: hw/watchdog/sbsa_gwdt.c
> +F: include/hw/watchdog/sbsa_gwdt.h
> F: docs/system/arm/sbsa.rst
> F: tests/avocado/machine_aarch64_sbsaref.py
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section
2023-09-29 16:12 ` Leif Lindholm
@ 2023-10-05 14:31 ` Thomas Huth
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2023-10-05 14:31 UTC (permalink / raw)
To: Leif Lindholm
Cc: Radoslaw Biernacki, Marcin Juszkiewicz, Peter Maydell, qemu-arm,
qemu-devel, QEMU Trivial
On 29/09/2023 18.12, Leif Lindholm wrote:
> On Fri, Sep 29, 2023 at 16:19:18 +0200, Thomas Huth wrote:
>> These files belong to the sbsa-ref machine and thus should
>> be listed here.
>
> First of all, thanks for this.
>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> MAINTAINERS | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 874234cb7b..fc415d3cea 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -954,6 +954,9 @@ R: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>> L: qemu-arm@nongnu.org
>> S: Maintained
>> F: hw/arm/sbsa-ref.c
>> +F: hw/misc/sbsa_ec.c
>
> Yes, pure oversight, sorry about that.
>
>> +F: hw/watchdog/sbsa_gwdt.c
>> +F: include/hw/watchdog/sbsa_gwdt.h
>
> I just want to clarify that this is not "the watchdog for the SBSA
> platform", but "the watchdog defined by Arm's SBSA specification"
> (and belatedly the BSA specification)" - the specification that
> sbsa-ref (intends to) provide a compliant platform implementation for.
Thanks for the clarification!
> Another such component is the "generic UART", but since that is a
> subset of pl011 there is no real value in providing a dedicated model
> of it.
>
> Which I guess is a long-winded way of saying: this component does not
> necessarily want/need the same maintainers as the sbsa-ref platform.
> I'm still happy to maintain it, and it may make sense to keep it under
> this header for now.
I think as long as the sbsa-ref machine is the only one in our git tree that
uses this device, it's fine if we add the sbsa watchdog to this section
here. If there will ever be another machine that uses this device, we can
still reconsider and create a dedicated section for it in the MAINTAINERS
file if necessary.
> (In which case
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> )
Thanks!
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section
2023-09-29 14:19 [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section Thomas Huth
2023-09-29 16:12 ` Leif Lindholm
2023-10-05 13:57 ` Markus Armbruster
@ 2023-10-06 6:41 ` Michael Tokarev
2 siblings, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2023-10-06 6:41 UTC (permalink / raw)
To: Thomas Huth, Radoslaw Biernacki, Marcin Juszkiewicz,
Peter Maydell, Leif Lindholm
Cc: qemu-arm, qemu-devel, QEMU Trivial
Applied to my trivial-patches tree, thanks!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-06 6:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-29 14:19 [PATCH] MAINTAINERS: Add some unowned files to the SBSA-REF section Thomas Huth
2023-09-29 16:12 ` Leif Lindholm
2023-10-05 14:31 ` Thomas Huth
2023-10-05 13:57 ` Markus Armbruster
2023-10-06 6:41 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.