* [PATCH] Added missing TARGETS in kselftest top level Makefile
@ 2023-09-30 19:41 ` Abhinav
0 siblings, 0 replies; 13+ messages in thread
From: Abhinav @ 2023-09-30 19:41 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, linux-kernel-mentees, Abhinav
Some TARGETS were missing in selftests top level Makefile.Added those.
Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
---
tools/testing/selftests/Makefile | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d9b2341b79a..14050f39cc5e 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -13,6 +13,7 @@ TARGETS += core
TARGETS += cpufreq
TARGETS += cpu-hotplug
TARGETS += damon
+TARGETS += dma
TARGETS += dmabuf-heaps
TARGETS += drivers/dma-buf
TARGETS += drivers/s390x/uvdevice
@@ -22,6 +23,7 @@ TARGETS += dt
TARGETS += efivarfs
TARGETS += exec
TARGETS += fchmodat2
+TARGETS += filelock
TARGETS += filesystems
TARGETS += filesystems/binderfs
TARGETS += filesystems/epoll
@@ -32,17 +34,21 @@ TARGETS += ftrace
TARGETS += futex
TARGETS += gpio
TARGETS += hid
+TARGETS += ia64
TARGETS += intel_pstate
TARGETS += iommu
TARGETS += ipc
TARGETS += ir
TARGETS += kcmp
TARGETS += kexec
+TARGETS += kmod
TARGETS += kvm
TARGETS += landlock
TARGETS += lib
TARGETS += livepatch
TARGETS += lkdtm
+TARGETS += locking
+TARGETS += media_tests
TARGETS += membarrier
TARGETS += memfd
TARGETS += memory-hotplug
@@ -66,14 +72,18 @@ TARGETS += pid_namespace
TARGETS += powerpc
TARGETS += prctl
TARGETS += proc
+TARGETS += ptp
TARGETS += pstore
TARGETS += ptrace
+TARGETS += rcutorture
TARGETS += openat2
TARGETS += resctrl
TARGETS += riscv
TARGETS += rlimits
TARGETS += rseq
TARGETS += rtc
+TARGETS += safesetid
+TARGETS += sched
TARGETS += seccomp
TARGETS += sgx
TARGETS += sigaltstack
@@ -99,6 +109,7 @@ TARGETS += user
TARGETS += user_events
TARGETS += vDSO
TARGETS += mm
+TARGETS += watchdog
TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] Added missing TARGETS in kselftest top level Makefile
@ 2023-09-30 19:41 ` Abhinav
0 siblings, 0 replies; 13+ messages in thread
From: Abhinav @ 2023-09-30 19:41 UTC (permalink / raw)
To: shuah; +Cc: Abhinav, linux-kernel-mentees, linux-kernel, linux-kselftest
Some TARGETS were missing in selftests top level Makefile.Added those.
Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
---
tools/testing/selftests/Makefile | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d9b2341b79a..14050f39cc5e 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -13,6 +13,7 @@ TARGETS += core
TARGETS += cpufreq
TARGETS += cpu-hotplug
TARGETS += damon
+TARGETS += dma
TARGETS += dmabuf-heaps
TARGETS += drivers/dma-buf
TARGETS += drivers/s390x/uvdevice
@@ -22,6 +23,7 @@ TARGETS += dt
TARGETS += efivarfs
TARGETS += exec
TARGETS += fchmodat2
+TARGETS += filelock
TARGETS += filesystems
TARGETS += filesystems/binderfs
TARGETS += filesystems/epoll
@@ -32,17 +34,21 @@ TARGETS += ftrace
TARGETS += futex
TARGETS += gpio
TARGETS += hid
+TARGETS += ia64
TARGETS += intel_pstate
TARGETS += iommu
TARGETS += ipc
TARGETS += ir
TARGETS += kcmp
TARGETS += kexec
+TARGETS += kmod
TARGETS += kvm
TARGETS += landlock
TARGETS += lib
TARGETS += livepatch
TARGETS += lkdtm
+TARGETS += locking
+TARGETS += media_tests
TARGETS += membarrier
TARGETS += memfd
TARGETS += memory-hotplug
@@ -66,14 +72,18 @@ TARGETS += pid_namespace
TARGETS += powerpc
TARGETS += prctl
TARGETS += proc
+TARGETS += ptp
TARGETS += pstore
TARGETS += ptrace
+TARGETS += rcutorture
TARGETS += openat2
TARGETS += resctrl
TARGETS += riscv
TARGETS += rlimits
TARGETS += rseq
TARGETS += rtc
+TARGETS += safesetid
+TARGETS += sched
TARGETS += seccomp
TARGETS += sgx
TARGETS += sigaltstack
@@ -99,6 +109,7 @@ TARGETS += user
TARGETS += user_events
TARGETS += vDSO
TARGETS += mm
+TARGETS += watchdog
TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
--
2.34.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] Added missing TARGETS in kselftest top level Makefile
2023-09-30 19:41 ` Abhinav
@ 2023-10-01 6:07 ` Greg KH
-1 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2023-10-01 6:07 UTC (permalink / raw)
To: Abhinav; +Cc: shuah, linux-kernel-mentees, linux-kernel, linux-kselftest
On Sun, Oct 01, 2023 at 01:11:06AM +0530, Abhinav wrote:
> Some TARGETS were missing in selftests top level Makefile.Added those.
> Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
You need a blank line here please.
Also, why make this change, you are saying what you did, but not why?
Have you tested to verify that these targets were actually missing and
needed to be added? If so, for what reason?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Added missing TARGETS in kselftest top level Makefile
@ 2023-10-01 6:07 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2023-10-01 6:07 UTC (permalink / raw)
To: Abhinav; +Cc: linux-kernel-mentees, shuah, linux-kernel, linux-kselftest
On Sun, Oct 01, 2023 at 01:11:06AM +0530, Abhinav wrote:
> Some TARGETS were missing in selftests top level Makefile.Added those.
> Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
You need a blank line here please.
Also, why make this change, you are saying what you did, but not why?
Have you tested to verify that these targets were actually missing and
needed to be added? If so, for what reason?
thanks,
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Added missing TARGETS in kselftest top level Makefile
2023-10-01 6:07 ` Greg KH
(?)
@ 2023-10-01 17:32 ` Abhinav Singh
-1 siblings, 0 replies; 13+ messages in thread
From: Abhinav Singh @ 2023-10-01 17:32 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel-mentees, shuah, linux-kernel, linux-kselftest
[-- Attachment #1.1: Type: text/plain, Size: 880 bytes --]
Yes I tested and saw that the targets I added was missing.
Reason for doing this is because I saw almost all dirs are included as
TARGETS inside Makefile and some dir where not included, so individually
tested whether the left out dirs are actual tests or not and if they are, I
added them.
Thank You,
Abhinav Singh
On Sun, Oct 1, 2023 at 11:37 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Oct 01, 2023 at 01:11:06AM +0530, Abhinav wrote:
> > Some TARGETS were missing in selftests top level Makefile.Added those.
> > Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
>
> You need a blank line here please.
>
> Also, why make this change, you are saying what you did, but not why?
> Have you tested to verify that these targets were actually missing and
> needed to be added? If so, for what reason?
>
> thanks,
>
> greg k-h
>
[-- Attachment #1.2: Type: text/html, Size: 1322 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] Added missing TARGETS in kselftest top level Makefile
2023-10-01 6:07 ` Greg KH
@ 2023-10-02 7:27 ` Abhinav
-1 siblings, 0 replies; 13+ messages in thread
From: Abhinav @ 2023-10-02 7:27 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, linux-kernel-mentees, Abhinav
Some tests like dma, ia64, etc. were not present in top level of
selftest Makefile, so when someone ran 'make run_tests' they would miss
these tests. This patches adds those left out tests.
Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
---
tools/testing/selftests/Makefile | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d9b2341b79a..dc138c1dcb4b 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -13,6 +13,7 @@ TARGETS += core
TARGETS += cpufreq
TARGETS += cpu-hotplug
TARGETS += damon
+TARGETS += dma
TARGETS += dmabuf-heaps
TARGETS += drivers/dma-buf
TARGETS += drivers/s390x/uvdevice
@@ -32,17 +33,21 @@ TARGETS += ftrace
TARGETS += futex
TARGETS += gpio
TARGETS += hid
+TARGETS += ia64
TARGETS += intel_pstate
TARGETS += iommu
TARGETS += ipc
TARGETS += ir
TARGETS += kcmp
TARGETS += kexec
+TARGETS += kmod
TARGETS += kvm
TARGETS += landlock
TARGETS += lib
TARGETS += livepatch
TARGETS += lkdtm
+TARGETS += locking
+TARGETS += media_tests
TARGETS += membarrier
TARGETS += memfd
TARGETS += memory-hotplug
@@ -66,6 +71,7 @@ TARGETS += pid_namespace
TARGETS += powerpc
TARGETS += prctl
TARGETS += proc
+TARGETS += ptp
TARGETS += pstore
TARGETS += ptrace
TARGETS += openat2
@@ -99,6 +105,7 @@ TARGETS += user
TARGETS += user_events
TARGETS += vDSO
TARGETS += mm
+TARGETS += watchdog
TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2] Added missing TARGETS in kselftest top level Makefile
@ 2023-10-02 7:27 ` Abhinav
0 siblings, 0 replies; 13+ messages in thread
From: Abhinav @ 2023-10-02 7:27 UTC (permalink / raw)
To: shuah; +Cc: Abhinav, linux-kernel-mentees, linux-kernel, linux-kselftest
Some tests like dma, ia64, etc. were not present in top level of
selftest Makefile, so when someone ran 'make run_tests' they would miss
these tests. This patches adds those left out tests.
Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
---
tools/testing/selftests/Makefile | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d9b2341b79a..dc138c1dcb4b 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -13,6 +13,7 @@ TARGETS += core
TARGETS += cpufreq
TARGETS += cpu-hotplug
TARGETS += damon
+TARGETS += dma
TARGETS += dmabuf-heaps
TARGETS += drivers/dma-buf
TARGETS += drivers/s390x/uvdevice
@@ -32,17 +33,21 @@ TARGETS += ftrace
TARGETS += futex
TARGETS += gpio
TARGETS += hid
+TARGETS += ia64
TARGETS += intel_pstate
TARGETS += iommu
TARGETS += ipc
TARGETS += ir
TARGETS += kcmp
TARGETS += kexec
+TARGETS += kmod
TARGETS += kvm
TARGETS += landlock
TARGETS += lib
TARGETS += livepatch
TARGETS += lkdtm
+TARGETS += locking
+TARGETS += media_tests
TARGETS += membarrier
TARGETS += memfd
TARGETS += memory-hotplug
@@ -66,6 +71,7 @@ TARGETS += pid_namespace
TARGETS += powerpc
TARGETS += prctl
TARGETS += proc
+TARGETS += ptp
TARGETS += pstore
TARGETS += ptrace
TARGETS += openat2
@@ -99,6 +105,7 @@ TARGETS += user
TARGETS += user_events
TARGETS += vDSO
TARGETS += mm
+TARGETS += watchdog
TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
--
2.34.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] Added missing TARGETS in kselftest top level Makefile
2023-10-02 7:27 ` Abhinav
@ 2023-10-02 8:58 ` Greg KH
-1 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2023-10-02 8:58 UTC (permalink / raw)
To: Abhinav; +Cc: linux-kernel-mentees, shuah, linux-kernel, linux-kselftest
On Mon, Oct 02, 2023 at 12:57:35PM +0530, Abhinav wrote:
> Some tests like dma, ia64, etc. were not present in top level of
> selftest Makefile, so when someone ran 'make run_tests' they would miss
> these tests. This patches adds those left out tests.
>
> Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
> ---
> tools/testing/selftests/Makefile | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] Added missing TARGETS in kselftest top level Makefile
@ 2023-10-02 8:58 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2023-10-02 8:58 UTC (permalink / raw)
To: Abhinav; +Cc: shuah, linux-kernel-mentees, linux-kernel, linux-kselftest
On Mon, Oct 02, 2023 at 12:57:35PM +0530, Abhinav wrote:
> Some tests like dma, ia64, etc. were not present in top level of
> selftest Makefile, so when someone ran 'make run_tests' they would miss
> these tests. This patches adds those left out tests.
>
> Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
> ---
> tools/testing/selftests/Makefile | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] Added missing TARGETS in kselftest top level Makefile
2023-10-02 8:58 ` Greg KH
@ 2023-10-02 11:46 ` Abhinav
-1 siblings, 0 replies; 13+ messages in thread
From: Abhinav @ 2023-10-02 11:46 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, linux-kernel-mentees, Abhinav
Some tests like dma, ia64, etc. were not present in top level of
selftest Makefile, so when someone ran 'make run_tests' they would miss
these tests. This patches adds those left out tests.
Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
---
I removed sched, safesetid and filelock from the Makefile, because these
tests were actually triggered when we run 'make run_tests' even though it
has not been mentioned explicitly inside top level Makefile of selftest.
tools/testing/selftests/Makefile | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d9b2341b79a..dc138c1dcb4b 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -13,6 +13,7 @@ TARGETS += core
TARGETS += cpufreq
TARGETS += cpu-hotplug
TARGETS += damon
+TARGETS += dma
TARGETS += dmabuf-heaps
TARGETS += drivers/dma-buf
TARGETS += drivers/s390x/uvdevice
@@ -32,17 +33,21 @@ TARGETS += ftrace
TARGETS += futex
TARGETS += gpio
TARGETS += hid
+TARGETS += ia64
TARGETS += intel_pstate
TARGETS += iommu
TARGETS += ipc
TARGETS += ir
TARGETS += kcmp
TARGETS += kexec
+TARGETS += kmod
TARGETS += kvm
TARGETS += landlock
TARGETS += lib
TARGETS += livepatch
TARGETS += lkdtm
+TARGETS += locking
+TARGETS += media_tests
TARGETS += membarrier
TARGETS += memfd
TARGETS += memory-hotplug
@@ -66,6 +71,7 @@ TARGETS += pid_namespace
TARGETS += powerpc
TARGETS += prctl
TARGETS += proc
+TARGETS += ptp
TARGETS += pstore
TARGETS += ptrace
TARGETS += openat2
@@ -99,6 +105,7 @@ TARGETS += user
TARGETS += user_events
TARGETS += vDSO
TARGETS += mm
+TARGETS += watchdog
TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2] Added missing TARGETS in kselftest top level Makefile
@ 2023-10-02 11:46 ` Abhinav
0 siblings, 0 replies; 13+ messages in thread
From: Abhinav @ 2023-10-02 11:46 UTC (permalink / raw)
To: shuah; +Cc: Abhinav, linux-kernel-mentees, linux-kernel, linux-kselftest
Some tests like dma, ia64, etc. were not present in top level of
selftest Makefile, so when someone ran 'make run_tests' they would miss
these tests. This patches adds those left out tests.
Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
---
I removed sched, safesetid and filelock from the Makefile, because these
tests were actually triggered when we run 'make run_tests' even though it
has not been mentioned explicitly inside top level Makefile of selftest.
tools/testing/selftests/Makefile | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d9b2341b79a..dc138c1dcb4b 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -13,6 +13,7 @@ TARGETS += core
TARGETS += cpufreq
TARGETS += cpu-hotplug
TARGETS += damon
+TARGETS += dma
TARGETS += dmabuf-heaps
TARGETS += drivers/dma-buf
TARGETS += drivers/s390x/uvdevice
@@ -32,17 +33,21 @@ TARGETS += ftrace
TARGETS += futex
TARGETS += gpio
TARGETS += hid
+TARGETS += ia64
TARGETS += intel_pstate
TARGETS += iommu
TARGETS += ipc
TARGETS += ir
TARGETS += kcmp
TARGETS += kexec
+TARGETS += kmod
TARGETS += kvm
TARGETS += landlock
TARGETS += lib
TARGETS += livepatch
TARGETS += lkdtm
+TARGETS += locking
+TARGETS += media_tests
TARGETS += membarrier
TARGETS += memfd
TARGETS += memory-hotplug
@@ -66,6 +71,7 @@ TARGETS += pid_namespace
TARGETS += powerpc
TARGETS += prctl
TARGETS += proc
+TARGETS += ptp
TARGETS += pstore
TARGETS += ptrace
TARGETS += openat2
@@ -99,6 +105,7 @@ TARGETS += user
TARGETS += user_events
TARGETS += vDSO
TARGETS += mm
+TARGETS += watchdog
TARGETS += x86
TARGETS += zram
#Please keep the TARGETS list alphabetically sorted
--
2.34.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] Added missing TARGETS in kselftest top level Makefile
2023-10-02 11:46 ` Abhinav
@ 2023-10-02 14:34 ` Shuah Khan
-1 siblings, 0 replies; 13+ messages in thread
From: Shuah Khan @ 2023-10-02 14:34 UTC (permalink / raw)
To: Abhinav, shuah
Cc: linux-kselftest, linux-kernel, linux-kernel-mentees, Shuah Khan
On 10/2/23 05:46, Abhinav wrote:
> Some tests like dma, ia64, etc. were not present in top level of
> selftest Makefile, so when someone ran 'make run_tests' they would miss
> these tests. This patches adds those left out tests.
>
> Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
> ---
>
> I removed sched, safesetid and filelock from the Makefile, because these
> tests were actually triggered when we run 'make run_tests' even though it
> has not been mentioned explicitly inside top level Makefile of selftest.
>
> tools/testing/selftests/Makefile | 7 +++++++
> 1 file changed, 7 insertions(+)
>
There are good reasons to leave out tests from the kselftest default
run.
1. test requires specific hardware or driver or system configuration
which includes kernel configuration options.
e.g: media_tests, dma
2. It is a benchmark and/or destructive test that doesn't fit into
default run category: watchdog, kmod
3. test Makefile doesn't support kselftest framework
Any patch adding a test left out of default run to the default
run has to explain the reasons why it is a good idea to add it
and more importantly showing that this doesn't impact the default
run with report from the test run "make kselftest"
Sorry. I am not going to take this patch.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] Added missing TARGETS in kselftest top level Makefile
@ 2023-10-02 14:34 ` Shuah Khan
0 siblings, 0 replies; 13+ messages in thread
From: Shuah Khan @ 2023-10-02 14:34 UTC (permalink / raw)
To: Abhinav, shuah; +Cc: linux-kernel-mentees, linux-kernel, linux-kselftest
On 10/2/23 05:46, Abhinav wrote:
> Some tests like dma, ia64, etc. were not present in top level of
> selftest Makefile, so when someone ran 'make run_tests' they would miss
> these tests. This patches adds those left out tests.
>
> Signed-off-by: Abhinav <singhabhinav9051571833@gmail.com>
> ---
>
> I removed sched, safesetid and filelock from the Makefile, because these
> tests were actually triggered when we run 'make run_tests' even though it
> has not been mentioned explicitly inside top level Makefile of selftest.
>
> tools/testing/selftests/Makefile | 7 +++++++
> 1 file changed, 7 insertions(+)
>
There are good reasons to leave out tests from the kselftest default
run.
1. test requires specific hardware or driver or system configuration
which includes kernel configuration options.
e.g: media_tests, dma
2. It is a benchmark and/or destructive test that doesn't fit into
default run category: watchdog, kmod
3. test Makefile doesn't support kselftest framework
Any patch adding a test left out of default run to the default
run has to explain the reasons why it is a good idea to add it
and more importantly showing that this doesn't impact the default
run with report from the test run "make kselftest"
Sorry. I am not going to take this patch.
thanks,
-- Shuah
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-10-02 14:34 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-30 19:41 [PATCH] Added missing TARGETS in kselftest top level Makefile Abhinav
2023-09-30 19:41 ` Abhinav
2023-10-01 6:07 ` Greg KH
2023-10-01 6:07 ` Greg KH
2023-10-01 17:32 ` Abhinav Singh
2023-10-02 7:27 ` [PATCH v2] " Abhinav
2023-10-02 7:27 ` Abhinav
2023-10-02 8:58 ` Greg KH
2023-10-02 8:58 ` Greg KH
2023-10-02 11:46 ` Abhinav
2023-10-02 11:46 ` Abhinav
2023-10-02 14:34 ` Shuah Khan
2023-10-02 14:34 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.