* [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio
@ 2023-10-02 7:00 Luca Weiss
2023-10-02 7:00 ` [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples Luca Weiss
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Luca Weiss @ 2023-10-02 7:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Stephen Boyd
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel, Luca Weiss
Update the schema to use plural _gpios label in the example. And fix a
dtbs_check warning in pm7250b.dtsi.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- Remove labels instead of updating them in documentation patch
- Link to v1: https://lore.kernel.org/r/20230929-pm7250b-gpio-fixup-v1-0-ef68543c1d3b@fairphone.com
---
Luca Weiss (2):
dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples
arm64: dts: qcom: pm7250b: Use correct node name for gpios
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
arch/arm64/boot/dts/qcom/pm7250b.dtsi | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: df964ce9ef9fea10cf131bf6bad8658fde7956f6
change-id: 20230929-pm7250b-gpio-fixup-f407ee98425a
Best regards,
--
Luca Weiss <luca.weiss@fairphone.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples
2023-10-02 7:00 [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio Luca Weiss
@ 2023-10-02 7:00 ` Luca Weiss
2023-10-02 11:16 ` Conor Dooley
` (2 more replies)
2023-10-02 7:00 ` [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios Luca Weiss
2023-10-22 15:50 ` (subset) [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio Bjorn Andersson
2 siblings, 3 replies; 8+ messages in thread
From: Luca Weiss @ 2023-10-02 7:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Stephen Boyd
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel, Luca Weiss
There's not much point in having unused labels in the binding example,
so drop them.
This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom:
Use plural _gpios node label for PMIC gpios") updating all dts files to
use the plural _gpios label instead of the singular _gpio as label but
this example wasn't updated. But since we should just drop the label
alltogether, do that.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 55e931ba5b47..9fa568603930 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -239,13 +239,13 @@ examples:
interrupt-controller;
#interrupt-cells = <4>;
- pmi8998_lsid0: pmic@2 {
+ pmic@2 {
compatible = "qcom,pmi8998", "qcom,spmi-pmic";
reg = <0x2 SPMI_USID>;
#address-cells = <1>;
#size-cells = <0>;
- pmi8998_gpio: gpio@c000 {
+ gpio@c000 {
compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio";
reg = <0xc000>;
gpio-controller;
@@ -330,7 +330,7 @@ examples:
};
};
- pm6150_gpio: gpio@c000 {
+ gpio@c000 {
compatible = "qcom,pm6150-gpio", "qcom,spmi-gpio";
reg = <0xc000>;
gpio-controller;
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios
2023-10-02 7:00 [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio Luca Weiss
2023-10-02 7:00 ` [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples Luca Weiss
@ 2023-10-02 7:00 ` Luca Weiss
2023-10-02 13:55 ` Krzysztof Kozlowski
2023-10-22 15:50 ` (subset) [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio Bjorn Andersson
2 siblings, 1 reply; 8+ messages in thread
From: Luca Weiss @ 2023-10-02 7:00 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Stephen Boyd
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel, Luca Weiss
Use gpio@ instead of pinctrl@ as that's the name expected by the
qcom,spmi-pmic.yaml schema. Update it to fix dt validation.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/pm7250b.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
index df0afe82f250..3bf7cf5d1700 100644
--- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
@@ -148,7 +148,7 @@ pm7250b_adc_tm: adc-tm@3500 {
status = "disabled";
};
- pm7250b_gpios: pinctrl@c000 {
+ pm7250b_gpios: gpio@c000 {
compatible = "qcom,pm7250b-gpio", "qcom,spmi-gpio";
reg = <0xc000>;
gpio-controller;
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples
2023-10-02 7:00 ` [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples Luca Weiss
@ 2023-10-02 11:16 ` Conor Dooley
2023-10-02 13:54 ` Krzysztof Kozlowski
2023-10-05 13:55 ` (subset) " Lee Jones
2 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2023-10-02 11:16 UTC (permalink / raw)
To: Luca Weiss
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Stephen Boyd,
~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
On Mon, Oct 02, 2023 at 09:00:11AM +0200, Luca Weiss wrote:
> There's not much point in having unused labels in the binding example,
> so drop them.
>
> This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom:
> Use plural _gpios node label for PMIC gpios") updating all dts files to
> use the plural _gpios label instead of the singular _gpio as label but
> this example wasn't updated. But since we should just drop the label
> alltogether, do that.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 55e931ba5b47..9fa568603930 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -239,13 +239,13 @@ examples:
> interrupt-controller;
> #interrupt-cells = <4>;
>
> - pmi8998_lsid0: pmic@2 {
> + pmic@2 {
> compatible = "qcom,pmi8998", "qcom,spmi-pmic";
> reg = <0x2 SPMI_USID>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pmi8998_gpio: gpio@c000 {
> + gpio@c000 {
> compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio";
> reg = <0xc000>;
> gpio-controller;
> @@ -330,7 +330,7 @@ examples:
> };
> };
>
> - pm6150_gpio: gpio@c000 {
> + gpio@c000 {
> compatible = "qcom,pm6150-gpio", "qcom,spmi-gpio";
> reg = <0xc000>;
> gpio-controller;
>
> --
> 2.42.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples
2023-10-02 7:00 ` [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples Luca Weiss
2023-10-02 11:16 ` Conor Dooley
@ 2023-10-02 13:54 ` Krzysztof Kozlowski
2023-10-05 13:55 ` (subset) " Lee Jones
2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-02 13:54 UTC (permalink / raw)
To: Luca Weiss, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel
On 02/10/2023 09:00, Luca Weiss wrote:
> There's not much point in having unused labels in the binding example,
> so drop them.
>
> This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom:
> Use plural _gpios node label for PMIC gpios") updating all dts files to
> use the plural _gpios label instead of the singular _gpio as label but
> this example wasn't updated. But since we should just drop the label
> alltogether, do that.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios
2023-10-02 7:00 ` [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios Luca Weiss
@ 2023-10-02 13:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-02 13:55 UTC (permalink / raw)
To: Luca Weiss, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel
On 02/10/2023 09:00, Luca Weiss wrote:
> Use gpio@ instead of pinctrl@ as that's the name expected by the
> qcom,spmi-pmic.yaml schema. Update it to fix dt validation.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples
2023-10-02 7:00 ` [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples Luca Weiss
2023-10-02 11:16 ` Conor Dooley
2023-10-02 13:54 ` Krzysztof Kozlowski
@ 2023-10-05 13:55 ` Lee Jones
2 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2023-10-05 13:55 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Stephen Boyd,
Luca Weiss
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel
On Mon, 02 Oct 2023 09:00:11 +0200, Luca Weiss wrote:
> There's not much point in having unused labels in the binding example,
> so drop them.
>
> This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom:
> Use plural _gpios node label for PMIC gpios") updating all dts files to
> use the plural _gpios label instead of the singular _gpio as label but
> this example wasn't updated. But since we should just drop the label
> alltogether, do that.
>
> [...]
Applied, thanks!
[1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples
commit: cac94656ff2b16827d7cd455f0d3746280cf3138
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio
2023-10-02 7:00 [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio Luca Weiss
2023-10-02 7:00 ` [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples Luca Weiss
2023-10-02 7:00 ` [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios Luca Weiss
@ 2023-10-22 15:50 ` Bjorn Andersson
2 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2023-10-22 15:50 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Stephen Boyd, Luca Weiss
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
devicetree, linux-kernel
On Mon, 02 Oct 2023 09:00:10 +0200, Luca Weiss wrote:
> Update the schema to use plural _gpios label in the example. And fix a
> dtbs_check warning in pm7250b.dtsi.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios
commit: 6cd8621758004d98f7c622c2d756c116c6888127
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-10-22 15:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-02 7:00 [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio Luca Weiss
2023-10-02 7:00 ` [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples Luca Weiss
2023-10-02 11:16 ` Conor Dooley
2023-10-02 13:54 ` Krzysztof Kozlowski
2023-10-05 13:55 ` (subset) " Lee Jones
2023-10-02 7:00 ` [PATCH v2 2/2] arm64: dts: qcom: pm7250b: Use correct node name for gpios Luca Weiss
2023-10-02 13:55 ` Krzysztof Kozlowski
2023-10-22 15:50 ` (subset) [PATCH v2 0/2] Small updates / fixups for PMIC spmi-gpio Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.