* [PATCH 1/2] extcon: max77693: add device-tree compatible string
[not found] <CGME20231005104339eucas1p17e2b8f2886bbd529c207e68e8de18b01@eucas1p1.samsung.com>
@ 2023-10-05 10:43 ` Marek Szyprowski
[not found] ` <CGME20231005104339eucas1p147e85630eec0ec4b476a21ed2cd3650d@eucas1p1.samsung.com>
2023-10-05 10:58 ` [PATCH 1/2] extcon: max77693: " Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Marek Szyprowski @ 2023-10-05 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: Marek Szyprowski, Chanwoo Choi, Krzysztof Kozlowski, MyungJoo Ham
Commit 57f706bf7307 ("ARM: dts: samsung: exynos4412-midas: add USB
connector and USB OTG") added a 'muic' node to the MAX77693 PMIC
definition in various device-tree files. Since that commit, the newly
created MFD cell gained its own of_node and compatible string. This
changed its modalias, what in turn broke automated loading of the driver
module, because the new modalias is based on the of_node compatible
string, not the platform device name.
Fix this by adding the needed device-tree compatible string.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/extcon/extcon-max77693.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 1f1d9ab0c5c7..5fb9c413a23b 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -1258,6 +1258,12 @@ static int max77693_muic_probe(struct platform_device *pdev)
return ret;
}
+static const struct of_device_id of_max77693_muic_dt_match[] = {
+ { .compatible = "maxim,max77693-muic", },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, of_max77693_muic_dt_match);
+
static struct platform_driver max77693_muic_driver = {
.driver = {
.name = DEV_NAME,
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] extcon: max77843: add device-tree compatible string
[not found] ` <CGME20231005104339eucas1p147e85630eec0ec4b476a21ed2cd3650d@eucas1p1.samsung.com>
@ 2023-10-05 10:43 ` Marek Szyprowski
2023-10-05 10:57 ` Krzysztof Kozlowski
2023-10-06 6:41 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Marek Szyprowski @ 2023-10-05 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: Marek Szyprowski, Chanwoo Choi, Krzysztof Kozlowski, MyungJoo Ham
Add the needed device-tree compatible string to the MAX77843 extcon
driver, so it can be automatically loaded when compiled as a kernel
module and given device-tree contains separate 'muic' node under the main
MAX77843 PMIC node.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/extcon/extcon-max77843.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 1bc0426ce3f1..e04ebdda886a 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -946,6 +946,12 @@ static const struct platform_device_id max77843_muic_id[] = {
};
MODULE_DEVICE_TABLE(platform, max77843_muic_id);
+static const struct of_device_id of_max77843_muic_dt_match[] = {
+ { .compatible = "maxim,max77843-muic", },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, of_max77843_muic_dt_match);
+
static struct platform_driver max77843_muic_driver = {
.driver = {
.name = "max77843-muic",
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] extcon: max77843: add device-tree compatible string
2023-10-05 10:43 ` [PATCH 2/2] extcon: max77843: " Marek Szyprowski
@ 2023-10-05 10:57 ` Krzysztof Kozlowski
2023-10-06 6:41 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-05 10:57 UTC (permalink / raw)
To: Marek Szyprowski, linux-kernel; +Cc: Chanwoo Choi, MyungJoo Ham
On 05/10/2023 12:43, Marek Szyprowski wrote:
> Add the needed device-tree compatible string to the MAX77843 extcon
> driver, so it can be automatically loaded when compiled as a kernel
> module and given device-tree contains separate 'muic' node under the main
> MAX77843 PMIC node.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] extcon: max77693: add device-tree compatible string
2023-10-05 10:43 ` [PATCH 1/2] extcon: max77693: add device-tree compatible string Marek Szyprowski
[not found] ` <CGME20231005104339eucas1p147e85630eec0ec4b476a21ed2cd3650d@eucas1p1.samsung.com>
@ 2023-10-05 10:58 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-05 10:58 UTC (permalink / raw)
To: Marek Szyprowski, linux-kernel; +Cc: Chanwoo Choi, MyungJoo Ham
On 05/10/2023 12:43, Marek Szyprowski wrote:
> Commit 57f706bf7307 ("ARM: dts: samsung: exynos4412-midas: add USB
> connector and USB OTG") added a 'muic' node to the MAX77693 PMIC
> definition in various device-tree files. Since that commit, the newly
> created MFD cell gained its own of_node and compatible string. This
> changed its modalias, what in turn broke automated loading of the driver
> module, because the new modalias is based on the of_node compatible
> string, not the platform device name.
>
> Fix this by adding the needed device-tree compatible string.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] extcon: max77843: add device-tree compatible string
2023-10-05 10:43 ` [PATCH 2/2] extcon: max77843: " Marek Szyprowski
2023-10-05 10:57 ` Krzysztof Kozlowski
@ 2023-10-06 6:41 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-06 6:41 UTC (permalink / raw)
To: Marek Szyprowski, linux-kernel
Cc: Chanwoo Choi, Krzysztof Kozlowski, MyungJoo Ham
On 05/10/2023 12:43, Marek Szyprowski wrote:
> Add the needed device-tree compatible string to the MAX77843 extcon
> driver, so it can be automatically loaded when compiled as a kernel
> module and given device-tree contains separate 'muic' node under the main
> MAX77843 PMIC node.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/extcon/extcon-max77843.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 1bc0426ce3f1..e04ebdda886a 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -946,6 +946,12 @@ static const struct platform_device_id max77843_muic_id[] = {
> };
> MODULE_DEVICE_TABLE(platform, max77843_muic_id);
>
> +static const struct of_device_id of_max77843_muic_dt_match[] = {
> + { .compatible = "maxim,max77843-muic", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, of_max77843_muic_dt_match);
As robot reports, there is indeed no user of it. :/ You need to include
it in driver OF table or add maybe_unused.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-06 6:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20231005104339eucas1p17e2b8f2886bbd529c207e68e8de18b01@eucas1p1.samsung.com>
2023-10-05 10:43 ` [PATCH 1/2] extcon: max77693: add device-tree compatible string Marek Szyprowski
[not found] ` <CGME20231005104339eucas1p147e85630eec0ec4b476a21ed2cd3650d@eucas1p1.samsung.com>
2023-10-05 10:43 ` [PATCH 2/2] extcon: max77843: " Marek Szyprowski
2023-10-05 10:57 ` Krzysztof Kozlowski
2023-10-06 6:41 ` Krzysztof Kozlowski
2023-10-05 10:58 ` [PATCH 1/2] extcon: max77693: " Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.