* [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
@ 2023-10-07 3:23 ` Ma Ke
0 siblings, 0 replies; 8+ messages in thread
From: Ma Ke @ 2023-10-07 3:23 UTC (permalink / raw)
To: kherbst, lyude, dakr, airlied, daniel, noralf, tzimmermann,
mripard, jani.nikula, make_ruc2021
Cc: dri-devel, nouveau, linux-kernel
In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
index 670c9739e5e1..4a08e61f3336 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
@@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
struct drm_display_mode *mode;
mode = drm_mode_duplicate(encoder->dev, tv_mode);
+ if (!mode)
+ continue;
mode->clock = tv_norm->tv_enc_mode.vrefresh *
mode->htotal / 1000 *
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
@ 2023-10-07 3:23 ` Ma Ke
0 siblings, 0 replies; 8+ messages in thread
From: Ma Ke @ 2023-10-07 3:23 UTC (permalink / raw)
To: kherbst, lyude, dakr, airlied, daniel, noralf, tzimmermann,
mripard, jani.nikula, make_ruc2021
Cc: nouveau, linux-kernel, dri-devel
In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
index 670c9739e5e1..4a08e61f3336 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
@@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
struct drm_display_mode *mode;
mode = drm_mode_duplicate(encoder->dev, tv_mode);
+ if (!mode)
+ continue;
mode->clock = tv_norm->tv_enc_mode.vrefresh *
mode->htotal / 1000 *
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Nouveau] [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
@ 2023-10-07 3:23 ` Ma Ke
0 siblings, 0 replies; 8+ messages in thread
From: Ma Ke @ 2023-10-07 3:23 UTC (permalink / raw)
To: kherbst, lyude, dakr, airlied, daniel, noralf, tzimmermann,
mripard, jani.nikula, make_ruc2021
Cc: nouveau, linux-kernel, dri-devel
In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
index 670c9739e5e1..4a08e61f3336 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
@@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
struct drm_display_mode *mode;
mode = drm_mode_duplicate(encoder->dev, tv_mode);
+ if (!mode)
+ continue;
mode->clock = tv_norm->tv_enc_mode.vrefresh *
mode->htotal / 1000 *
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
2023-10-07 3:23 ` Ma Ke
(?)
@ 2023-10-12 17:58 ` Danilo Krummrich
-1 siblings, 0 replies; 8+ messages in thread
From: Danilo Krummrich @ 2023-10-12 17:58 UTC (permalink / raw)
To: Ma Ke
Cc: jani.nikula, nouveau, linux-kernel, mripard, noralf, dri-devel, daniel
On 10/7/23 05:23, Ma Ke wrote:
> In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate()
> is assigned to mode, which will lead to a NULL pointer dereference
> on failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
> ---
> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> index 670c9739e5e1..4a08e61f3336 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> @@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
> struct drm_display_mode *mode;
>
> mode = drm_mode_duplicate(encoder->dev, tv_mode);
> + if (!mode)
> + continue;
>
> mode->clock = tv_norm->tv_enc_mode.vrefresh *
> mode->htotal / 1000 *
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
@ 2023-10-12 17:58 ` Danilo Krummrich
0 siblings, 0 replies; 8+ messages in thread
From: Danilo Krummrich @ 2023-10-12 17:58 UTC (permalink / raw)
To: Ma Ke
Cc: tzimmermann, kherbst, jani.nikula, nouveau, linux-kernel,
mripard, noralf, dri-devel
On 10/7/23 05:23, Ma Ke wrote:
> In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate()
> is assigned to mode, which will lead to a NULL pointer dereference
> on failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
> ---
> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> index 670c9739e5e1..4a08e61f3336 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> @@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
> struct drm_display_mode *mode;
>
> mode = drm_mode_duplicate(encoder->dev, tv_mode);
> + if (!mode)
> + continue;
>
> mode->clock = tv_norm->tv_enc_mode.vrefresh *
> mode->htotal / 1000 *
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
@ 2023-10-12 17:58 ` Danilo Krummrich
0 siblings, 0 replies; 8+ messages in thread
From: Danilo Krummrich @ 2023-10-12 17:58 UTC (permalink / raw)
To: Ma Ke
Cc: kherbst, lyude, airlied, daniel, noralf, tzimmermann, mripard,
jani.nikula, nouveau, linux-kernel, dri-devel
On 10/7/23 05:23, Ma Ke wrote:
> In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate()
> is assigned to mode, which will lead to a NULL pointer dereference
> on failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
> ---
> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> index 670c9739e5e1..4a08e61f3336 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> @@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
> struct drm_display_mode *mode;
>
> mode = drm_mode_duplicate(encoder->dev, tv_mode);
> + if (!mode)
> + continue;
>
> mode->clock = tv_norm->tv_enc_mode.vrefresh *
> mode->htotal / 1000 *
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
@ 2023-10-13 1:18 ` Ma Ke
0 siblings, 0 replies; 8+ messages in thread
From: Ma Ke @ 2023-10-13 1:18 UTC (permalink / raw)
To: kherbst, lyude, dakr, airlied, daniel, tzimmermann, noralf,
mripard, jani.nikula, make_ruc2021
Cc: dri-devel, nouveau, linux-kernel
In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference on
failure of drm_mode_duplicate(). The same applies to drm_cvt_mode().
Add a check to avoid null pointer dereference.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
index 670c9739e5e1..9c3dc9a5bb46 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
@@ -258,6 +258,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder,
if (modes[i].hdisplay == output_mode->hdisplay &&
modes[i].vdisplay == output_mode->vdisplay) {
mode = drm_mode_duplicate(encoder->dev, output_mode);
+ if (!mode)
+ continue;
mode->type |= DRM_MODE_TYPE_PREFERRED;
} else {
@@ -265,6 +267,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder,
modes[i].vdisplay, 60, false,
(output_mode->flags &
DRM_MODE_FLAG_INTERLACE), false);
+ if (!mode)
+ continue;
}
/* CVT modes are sometimes unsuitable... */
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference
@ 2023-10-13 1:18 ` Ma Ke
0 siblings, 0 replies; 8+ messages in thread
From: Ma Ke @ 2023-10-13 1:18 UTC (permalink / raw)
To: kherbst, lyude, dakr, airlied, daniel, tzimmermann, noralf,
mripard, jani.nikula, make_ruc2021
Cc: nouveau, linux-kernel, dri-devel
In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference on
failure of drm_mode_duplicate(). The same applies to drm_cvt_mode().
Add a check to avoid null pointer dereference.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
index 670c9739e5e1..9c3dc9a5bb46 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
@@ -258,6 +258,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder,
if (modes[i].hdisplay == output_mode->hdisplay &&
modes[i].vdisplay == output_mode->vdisplay) {
mode = drm_mode_duplicate(encoder->dev, output_mode);
+ if (!mode)
+ continue;
mode->type |= DRM_MODE_TYPE_PREFERRED;
} else {
@@ -265,6 +267,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder,
modes[i].vdisplay, 60, false,
(output_mode->flags &
DRM_MODE_FLAG_INTERLACE), false);
+ if (!mode)
+ continue;
}
/* CVT modes are sometimes unsuitable... */
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-10-13 1:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-07 3:23 [PATCH] drm/nouveau/dispnv04: fix a possible null pointer dereference Ma Ke
2023-10-07 3:23 ` [Nouveau] " Ma Ke
2023-10-07 3:23 ` Ma Ke
2023-10-12 17:58 ` [Nouveau] " Danilo Krummrich
2023-10-12 17:58 ` Danilo Krummrich
2023-10-12 17:58 ` Danilo Krummrich
2023-10-13 1:18 Ma Ke
2023-10-13 1:18 ` Ma Ke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.