* [PATCH v2 1/2] dt-bindings: zynqmp: add destination mailbox compatible
@ 2023-10-07 4:27 ` Tanmay Shah
0 siblings, 0 replies; 5+ messages in thread
From: Tanmay Shah @ 2023-10-07 4:27 UTC (permalink / raw)
To: jassisinghbrar, robh+dt, krzysztof.kozlowski+dt, conor+dt,
michal.simek, shubhrajyoti.datta
Cc: linux-kernel, devicetree, linux-arm-kernel, Tanmay Shah
Current dt-bindings does not contain compatible property
for child mailbox node. Child mailbox nodes are used
to represent destination (remote) IPI agents. The compatible
property for all destination mailboxes must be required to
identify the node.
This addition of new required property does not break ABI
as current driver does not use this compatible property
but, new features in driver should use this property.
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
Changes in v2:
- Fix commit message about breaking ABI
.../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
index aeaddbf574b0..8b15a0532120 100644
--- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
+++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
@@ -74,6 +74,10 @@ patternProperties:
type: object # DT nodes are json objects
additionalProperties: false
properties:
+
+ compatible:
+ const: xlnx,zynqmp-ipi-dest-mailbox
+
xlnx,ipi-id:
description:
Remote Xilinx IPI agent ID of which the mailbox is connected to.
@@ -95,6 +99,7 @@ patternProperties:
- const: remote_response_region
required:
+ - compatible
- reg
- reg-names
- "#mbox-cells"
@@ -124,6 +129,7 @@ examples:
ranges;
mailbox: mailbox@ff9905c0 {
+ compatible = "xlnx,zynqmp-ipi-dest-mailbox";
reg = <0x0 0xff9905c0 0x0 0x20>,
<0x0 0xff9905e0 0x0 0x20>,
<0x0 0xff990e80 0x0 0x20>,
base-commit: 7d730f1bf6f39ece2d9f3ae682f12e5b593d534d
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] dt-bindings: zynqmp: add destination mailbox compatible
@ 2023-10-07 4:27 ` Tanmay Shah
0 siblings, 0 replies; 5+ messages in thread
From: Tanmay Shah @ 2023-10-07 4:27 UTC (permalink / raw)
To: jassisinghbrar, robh+dt, krzysztof.kozlowski+dt, conor+dt,
michal.simek, shubhrajyoti.datta
Cc: linux-kernel, devicetree, linux-arm-kernel, Tanmay Shah
Current dt-bindings does not contain compatible property
for child mailbox node. Child mailbox nodes are used
to represent destination (remote) IPI agents. The compatible
property for all destination mailboxes must be required to
identify the node.
This addition of new required property does not break ABI
as current driver does not use this compatible property
but, new features in driver should use this property.
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
Changes in v2:
- Fix commit message about breaking ABI
.../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
index aeaddbf574b0..8b15a0532120 100644
--- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
+++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
@@ -74,6 +74,10 @@ patternProperties:
type: object # DT nodes are json objects
additionalProperties: false
properties:
+
+ compatible:
+ const: xlnx,zynqmp-ipi-dest-mailbox
+
xlnx,ipi-id:
description:
Remote Xilinx IPI agent ID of which the mailbox is connected to.
@@ -95,6 +99,7 @@ patternProperties:
- const: remote_response_region
required:
+ - compatible
- reg
- reg-names
- "#mbox-cells"
@@ -124,6 +129,7 @@ examples:
ranges;
mailbox: mailbox@ff9905c0 {
+ compatible = "xlnx,zynqmp-ipi-dest-mailbox";
reg = <0x0 0xff9905c0 0x0 0x20>,
<0x0 0xff9905e0 0x0 0x20>,
<0x0 0xff990e80 0x0 0x20>,
base-commit: 7d730f1bf6f39ece2d9f3ae682f12e5b593d534d
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] dts: zynqmp: add destination mailbox compatible
2023-10-07 4:27 ` Tanmay Shah
@ 2023-10-07 4:27 ` Tanmay Shah
-1 siblings, 0 replies; 5+ messages in thread
From: Tanmay Shah @ 2023-10-07 4:27 UTC (permalink / raw)
To: jassisinghbrar, robh+dt, krzysztof.kozlowski+dt, conor+dt,
michal.simek, shubhrajyoti.datta
Cc: linux-kernel, devicetree, linux-arm-kernel, Tanmay Shah
Each node should have compatible string to identify
itself. Add missing compatible string for zynqmp
destination mailbox node.
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index b61fc99cd911..8aebac27742e 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp_ipi {
ipi_mailbox_pmu1: mailbox@ff9905c0 {
bootph-all;
+ compatible = "xlnx,zynqmp-ipi-dest-mailbox";
reg = <0x0 0xff9905c0 0x0 0x20>,
<0x0 0xff9905e0 0x0 0x20>,
<0x0 0xff990e80 0x0 0x20>,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] dts: zynqmp: add destination mailbox compatible
@ 2023-10-07 4:27 ` Tanmay Shah
0 siblings, 0 replies; 5+ messages in thread
From: Tanmay Shah @ 2023-10-07 4:27 UTC (permalink / raw)
To: jassisinghbrar, robh+dt, krzysztof.kozlowski+dt, conor+dt,
michal.simek, shubhrajyoti.datta
Cc: linux-kernel, devicetree, linux-arm-kernel, Tanmay Shah
Each node should have compatible string to identify
itself. Add missing compatible string for zynqmp
destination mailbox node.
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index b61fc99cd911..8aebac27742e 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp_ipi {
ipi_mailbox_pmu1: mailbox@ff9905c0 {
bootph-all;
+ compatible = "xlnx,zynqmp-ipi-dest-mailbox";
reg = <0x0 0xff9905c0 0x0 0x20>,
<0x0 0xff9905e0 0x0 0x20>,
<0x0 0xff990e80 0x0 0x20>,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: zynqmp: add destination mailbox compatible
2023-10-07 4:27 ` Tanmay Shah
(?)
(?)
@ 2023-10-12 14:46 ` Rob Herring
-1 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-10-12 14:46 UTC (permalink / raw)
To: Tanmay Shah
Cc: conor+dt, shubhrajyoti.datta, linux-arm-kernel,
krzysztof.kozlowski+dt, robh+dt, devicetree, linux-kernel,
jassisinghbrar, michal.simek
On Fri, 06 Oct 2023 21:27:01 -0700, Tanmay Shah wrote:
> Current dt-bindings does not contain compatible property
> for child mailbox node. Child mailbox nodes are used
> to represent destination (remote) IPI agents. The compatible
> property for all destination mailboxes must be required to
> identify the node.
>
> This addition of new required property does not break ABI
> as current driver does not use this compatible property
> but, new features in driver should use this property.
>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
>
> Changes in v2:
> - Fix commit message about breaking ABI
>
> .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-12 14:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-07 4:27 [PATCH v2 1/2] dt-bindings: zynqmp: add destination mailbox compatible Tanmay Shah
2023-10-07 4:27 ` Tanmay Shah
2023-10-07 4:27 ` [PATCH v2 2/2] dts: " Tanmay Shah
2023-10-07 4:27 ` Tanmay Shah
2023-10-12 14:46 ` [PATCH v2 1/2] dt-bindings: " Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.