From: Jai Luthra <j-luthra@ti.com> To: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Maxime Ripard <mripard@kernel.org>, <niklas.soderlund+renesas@ragnatech.se>, Benoit Parrot <bparrot@ti.com>, Vaishnav Achath <vaishnav.a@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, <nm@ti.com>, <devarsht@ti.com>, <j-luthra@ti.com>, <a-bhatia1@ti.com>, Martyn Welch <martyn.welch@collabora.com>, Julien Massot <julien.massot@collabora.com> Subject: [PATCH v10 00/13] CSI2RX support on J721E and AM62 Date: Mon, 9 Oct 2023 18:39:26 +0530 [thread overview] Message-ID: <20231009-upstream_csi-v10-0-330aaed24c5d@ti.com> (raw) From: Pratyush Yadav <p.yadav@ti.com> Hi, This series adds support for CSI2 capture on J721E. It includes some fixes to the Cadence CSI2RX driver, and adds the TI CSI2RX wrapper driver. J721E CSI2RX driver can also be extended to support multi-stream capture, filtering different CSI Virtual Channels (VC) or Data Types (DT) to different DMA channels. A WIP series based on v7 is available for reference at https://github.com/jailuthra/linux/commits/csi_multi_wip I will rebase the multi-stream patches on the current series (v10) and post them after this series is merged. Signed-off-by: Jai Luthra <j-luthra@ti.com> --- Changes in v10: =============== Range-diff: https://gist.github.com/jailuthra/dab73c3949a6271cf3d0fd3d3b111c5b For [05/13] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops - Remove redundant checks in set_fmt() as we ensure pad is SINK For [13/13] media: ti: Add CSI2RX support for J721E - Fix bug around YUV422 pixel ordering in setup_shim(). Now we passthrough the incoming order of pixels over MIPI (U->Y->V->Y etc.) when storing in memory - Only allocate 32KiB of memory for the drain buffer, which is the upper bound of the PSI-L endpoint's internal FIFO storage (2048 x 128-bits) - Allocate drain buffer in probe() instead of start_streaming() - Set other colorspace/encoding properties in the initial device format - Make the module compilable with COMPILE_TEST if Cadence dependencies are missing - Address Laurent's review comments around naming and other minor comments - Address Tomi's comments around better explaining the scenarios where DMA drain is required - Change module/patch authorship to myself - Link to v9: https://lore.kernel.org/r/20230811-upstream_csi-v9-0-8943f7a68a81@ti.com --- Jai Luthra (2): media: dt-bindings: cadence-csi2rx: Add TI compatible string media: ti: Add CSI2RX support for J721E Pratyush Yadav (11): media: dt-bindings: Make sure items in data-lanes are unique media: cadence: csi2rx: Unregister v4l2 async notifier media: cadence: csi2rx: Cleanup media entity properly media: cadence: csi2rx: Add get_fmt and set_fmt pad ops media: cadence: csi2rx: Configure DPHY using link freq media: cadence: csi2rx: Soft reset the streams before starting capture media: cadence: csi2rx: Set the STOP bit when stopping a stream media: cadence: csi2rx: Fix stream data configuration media: cadence: csi2rx: Populate subdev devnode media: cadence: csi2rx: Add link validation media: dt-bindings: Add TI J721E CSI2RX .../devicetree/bindings/media/cdns,csi2rx.yaml | 1 + .../bindings/media/ti,j721e-csi2rx-shim.yaml | 100 ++ .../bindings/media/video-interfaces.yaml | 1 + MAINTAINERS | 7 + drivers/media/platform/cadence/cdns-csi2rx.c | 176 ++- drivers/media/platform/ti/Kconfig | 12 + drivers/media/platform/ti/Makefile | 1 + drivers/media/platform/ti/j721e-csi2rx/Makefile | 2 + .../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 1159 ++++++++++++++++++++ 9 files changed, 1452 insertions(+), 7 deletions(-) --- base-commit: 2a860505b617cf8fda4ebff6cf05d3f774145440 change-id: 20230727-upstream_csi-acbeabe038d8 Best regards, -- Jai Luthra <j-luthra@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jai Luthra <j-luthra@ti.com> To: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Maxime Ripard <mripard@kernel.org>, <niklas.soderlund+renesas@ragnatech.se>, Benoit Parrot <bparrot@ti.com>, Vaishnav Achath <vaishnav.a@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, <nm@ti.com>, <devarsht@ti.com>, <j-luthra@ti.com>, <a-bhatia1@ti.com>, Martyn Welch <martyn.welch@collabora.com>, Julien Massot <julien.massot@collabora.com> Subject: [PATCH v10 00/13] CSI2RX support on J721E and AM62 Date: Mon, 9 Oct 2023 18:39:26 +0530 [thread overview] Message-ID: <20231009-upstream_csi-v10-0-330aaed24c5d@ti.com> (raw) From: Pratyush Yadav <p.yadav@ti.com> Hi, This series adds support for CSI2 capture on J721E. It includes some fixes to the Cadence CSI2RX driver, and adds the TI CSI2RX wrapper driver. J721E CSI2RX driver can also be extended to support multi-stream capture, filtering different CSI Virtual Channels (VC) or Data Types (DT) to different DMA channels. A WIP series based on v7 is available for reference at https://github.com/jailuthra/linux/commits/csi_multi_wip I will rebase the multi-stream patches on the current series (v10) and post them after this series is merged. Signed-off-by: Jai Luthra <j-luthra@ti.com> --- Changes in v10: =============== Range-diff: https://gist.github.com/jailuthra/dab73c3949a6271cf3d0fd3d3b111c5b For [05/13] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops - Remove redundant checks in set_fmt() as we ensure pad is SINK For [13/13] media: ti: Add CSI2RX support for J721E - Fix bug around YUV422 pixel ordering in setup_shim(). Now we passthrough the incoming order of pixels over MIPI (U->Y->V->Y etc.) when storing in memory - Only allocate 32KiB of memory for the drain buffer, which is the upper bound of the PSI-L endpoint's internal FIFO storage (2048 x 128-bits) - Allocate drain buffer in probe() instead of start_streaming() - Set other colorspace/encoding properties in the initial device format - Make the module compilable with COMPILE_TEST if Cadence dependencies are missing - Address Laurent's review comments around naming and other minor comments - Address Tomi's comments around better explaining the scenarios where DMA drain is required - Change module/patch authorship to myself - Link to v9: https://lore.kernel.org/r/20230811-upstream_csi-v9-0-8943f7a68a81@ti.com --- Jai Luthra (2): media: dt-bindings: cadence-csi2rx: Add TI compatible string media: ti: Add CSI2RX support for J721E Pratyush Yadav (11): media: dt-bindings: Make sure items in data-lanes are unique media: cadence: csi2rx: Unregister v4l2 async notifier media: cadence: csi2rx: Cleanup media entity properly media: cadence: csi2rx: Add get_fmt and set_fmt pad ops media: cadence: csi2rx: Configure DPHY using link freq media: cadence: csi2rx: Soft reset the streams before starting capture media: cadence: csi2rx: Set the STOP bit when stopping a stream media: cadence: csi2rx: Fix stream data configuration media: cadence: csi2rx: Populate subdev devnode media: cadence: csi2rx: Add link validation media: dt-bindings: Add TI J721E CSI2RX .../devicetree/bindings/media/cdns,csi2rx.yaml | 1 + .../bindings/media/ti,j721e-csi2rx-shim.yaml | 100 ++ .../bindings/media/video-interfaces.yaml | 1 + MAINTAINERS | 7 + drivers/media/platform/cadence/cdns-csi2rx.c | 176 ++- drivers/media/platform/ti/Kconfig | 12 + drivers/media/platform/ti/Makefile | 1 + drivers/media/platform/ti/j721e-csi2rx/Makefile | 2 + .../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 1159 ++++++++++++++++++++ 9 files changed, 1452 insertions(+), 7 deletions(-) --- base-commit: 2a860505b617cf8fda4ebff6cf05d3f774145440 change-id: 20230727-upstream_csi-acbeabe038d8 Best regards, -- Jai Luthra <j-luthra@ti.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-10-09 13:10 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-09 13:09 Jai Luthra [this message] 2023-10-09 13:09 ` [PATCH v10 00/13] CSI2RX support on J721E and AM62 Jai Luthra 2023-10-09 13:09 ` [PATCH v10 01/13] media: dt-bindings: Make sure items in data-lanes are unique Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 02/13] media: dt-bindings: cadence-csi2rx: Add TI compatible string Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 03/13] media: cadence: csi2rx: Unregister v4l2 async notifier Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 04/13] media: cadence: csi2rx: Cleanup media entity properly Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 05/13] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 06/13] media: cadence: csi2rx: Configure DPHY using link freq Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 07/13] media: cadence: csi2rx: Soft reset the streams before starting capture Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 08/13] media: cadence: csi2rx: Set the STOP bit when stopping a stream Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 09/13] media: cadence: csi2rx: Fix stream data configuration Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 10/13] media: cadence: csi2rx: Populate subdev devnode Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 11/13] media: cadence: csi2rx: Add link validation Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 12/13] media: dt-bindings: Add TI J721E CSI2RX Jai Luthra 2023-10-09 13:09 ` Jai Luthra 2023-10-09 13:09 ` [PATCH v10 13/13] media: ti: Add CSI2RX support for J721E Jai Luthra 2023-10-09 13:09 ` Jai Luthra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231009-upstream_csi-v10-0-330aaed24c5d@ti.com \ --to=j-luthra@ti.com \ --cc=a-bhatia1@ti.com \ --cc=bparrot@ti.com \ --cc=conor+dt@kernel.org \ --cc=devarsht@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=julien.massot@collabora.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=martyn.welch@collabora.com \ --cc=mchehab+samsung@kernel.org \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=niklas.soderlund+renesas@ragnatech.se \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@linux.intel.com \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=vaishnav.a@ti.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.