* [PATCH 0/6] usb: gadget: Convert to use module_platform_driver()
@ 2023-10-17 20:44 ` Uwe Kleine-König
0 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Michael Grzeschik, linux-usb, linux-arm-kernel, kernel, Li Yang,
linuxppc-dev, Aaro Koskinen, Alan Stern, Gaosheng Cui,
Vladimir Zapolskiy, Yoshihiro Shimoda, Pavel Machek, Paolo Abeni,
Steven Rostedt (Google),
Arnd Bergmann, linux-kbuild
Hello,
module_platform_driver_probe() is an alternative to
module_platform_driver(). Comparing the two the former has the advantage
that the probe and remove callbacks can live in .init.text and
.exit.text respectively. The latter has the advantage that it's a bit
easier to use correctly and you can bind/unbind via sysfs and/or
hotplug.
There are considerations about deprecating
module_platform_driver_probe()[1] as very few drivers use it, still less
make actually use of the advantages and saving a few bytes isn't as
important any more as it was (say) 10 years ago.
Given that the drivers below drivers/usb/gadget making use of
module_platform_driver_probe() doesn't benefit from the advantages
at all (probe and remove are all defined in .text), convert these
drivers to module_platform_driver().
Best regards
Uwe
[1] https://lore.kernel.org/linux-kbuild/20231017132045.afswdgcv4axjf6jj@pengutronix.de
Uwe Kleine-König (6):
usb: gadget: at91-udc: Convert to use module_platform_driver()
usb: gadget: fsl-udc: Convert to use module_platform_driver()
usb: gadget: fusb300-udc: Convert to use module_platform_driver()
usb: gadget: lpc32xx-udc: Convert to use module_platform_driver()
usb: gadget: m66592-udc: Convert to use module_platform_driver()
usb: gadget: r8a66597-udc: Convert to use module_platform_driver()
drivers/usb/gadget/udc/at91_udc.c | 3 ++-
drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++-
drivers/usb/gadget/udc/fusb300_udc.c | 7 ++++---
drivers/usb/gadget/udc/lpc32xx_udc.c | 3 ++-
drivers/usb/gadget/udc/m66592-udc.c | 3 ++-
drivers/usb/gadget/udc/r8a66597-udc.c | 3 ++-
6 files changed, 14 insertions(+), 8 deletions(-)
base-commit: 4d5ab2376ec576af173e5eac3887ed0b51bd8566
--
2.42.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/6] usb: gadget: Convert to use module_platform_driver()
@ 2023-10-17 20:44 ` Uwe Kleine-König
0 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alexandre Belloni, Michael Grzeschik, Pavel Machek,
Arnd Bergmann, Aaro Koskinen, linux-kbuild, Yoshihiro Shimoda,
linux-usb, Nicolas Ferre, Steven Rostedt (Google),
Claudiu Beznea, Vladimir Zapolskiy, Alan Stern, kernel,
Paolo Abeni, Li Yang, linuxppc-dev, Gaosheng Cui,
linux-arm-kernel
Hello,
module_platform_driver_probe() is an alternative to
module_platform_driver(). Comparing the two the former has the advantage
that the probe and remove callbacks can live in .init.text and
.exit.text respectively. The latter has the advantage that it's a bit
easier to use correctly and you can bind/unbind via sysfs and/or
hotplug.
There are considerations about deprecating
module_platform_driver_probe()[1] as very few drivers use it, still less
make actually use of the advantages and saving a few bytes isn't as
important any more as it was (say) 10 years ago.
Given that the drivers below drivers/usb/gadget making use of
module_platform_driver_probe() doesn't benefit from the advantages
at all (probe and remove are all defined in .text), convert these
drivers to module_platform_driver().
Best regards
Uwe
[1] https://lore.kernel.org/linux-kbuild/20231017132045.afswdgcv4axjf6jj@pengutronix.de
Uwe Kleine-König (6):
usb: gadget: at91-udc: Convert to use module_platform_driver()
usb: gadget: fsl-udc: Convert to use module_platform_driver()
usb: gadget: fusb300-udc: Convert to use module_platform_driver()
usb: gadget: lpc32xx-udc: Convert to use module_platform_driver()
usb: gadget: m66592-udc: Convert to use module_platform_driver()
usb: gadget: r8a66597-udc: Convert to use module_platform_driver()
drivers/usb/gadget/udc/at91_udc.c | 3 ++-
drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++-
drivers/usb/gadget/udc/fusb300_udc.c | 7 ++++---
drivers/usb/gadget/udc/lpc32xx_udc.c | 3 ++-
drivers/usb/gadget/udc/m66592-udc.c | 3 ++-
drivers/usb/gadget/udc/r8a66597-udc.c | 3 ++-
6 files changed, 14 insertions(+), 8 deletions(-)
base-commit: 4d5ab2376ec576af173e5eac3887ed0b51bd8566
--
2.42.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/6] usb: gadget: Convert to use module_platform_driver()
@ 2023-10-17 20:44 ` Uwe Kleine-König
0 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alexandre Belloni, Michael Grzeschik, Pavel Machek,
Arnd Bergmann, Aaro Koskinen, linux-kbuild, Yoshihiro Shimoda,
linux-usb, Steven Rostedt (Google),
Claudiu Beznea, Vladimir Zapolskiy, Alan Stern, kernel,
Paolo Abeni, Li Yang, linuxppc-dev, Gaosheng Cui,
linux-arm-kernel
Hello,
module_platform_driver_probe() is an alternative to
module_platform_driver(). Comparing the two the former has the advantage
that the probe and remove callbacks can live in .init.text and
.exit.text respectively. The latter has the advantage that it's a bit
easier to use correctly and you can bind/unbind via sysfs and/or
hotplug.
There are considerations about deprecating
module_platform_driver_probe()[1] as very few drivers use it, still less
make actually use of the advantages and saving a few bytes isn't as
important any more as it was (say) 10 years ago.
Given that the drivers below drivers/usb/gadget making use of
module_platform_driver_probe() doesn't benefit from the advantages
at all (probe and remove are all defined in .text), convert these
drivers to module_platform_driver().
Best regards
Uwe
[1] https://lore.kernel.org/linux-kbuild/20231017132045.afswdgcv4axjf6jj@pengutronix.de
Uwe Kleine-König (6):
usb: gadget: at91-udc: Convert to use module_platform_driver()
usb: gadget: fsl-udc: Convert to use module_platform_driver()
usb: gadget: fusb300-udc: Convert to use module_platform_driver()
usb: gadget: lpc32xx-udc: Convert to use module_platform_driver()
usb: gadget: m66592-udc: Convert to use module_platform_driver()
usb: gadget: r8a66597-udc: Convert to use module_platform_driver()
drivers/usb/gadget/udc/at91_udc.c | 3 ++-
drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++-
drivers/usb/gadget/udc/fusb300_udc.c | 7 ++++---
drivers/usb/gadget/udc/lpc32xx_udc.c | 3 ++-
drivers/usb/gadget/udc/m66592-udc.c | 3 ++-
drivers/usb/gadget/udc/r8a66597-udc.c | 3 ++-
6 files changed, 14 insertions(+), 8 deletions(-)
base-commit: 4d5ab2376ec576af173e5eac3887ed0b51bd8566
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/6] usb: gadget: at91-udc: Convert to use module_platform_driver()
2023-10-17 20:44 ` Uwe Kleine-König
@ 2023-10-17 20:44 ` Uwe Kleine-König
-1 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Michael Grzeschik, linux-usb, linux-arm-kernel, kernel,
Arnd Bergmann, linux-kbuild
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/at91_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index 922b4187004b..30ea4a9d5301 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -2000,6 +2000,7 @@ static int at91udc_resume(struct platform_device *pdev)
#endif
static struct platform_driver at91_udc_driver = {
+ .probe = at91udc_probe,
.remove = at91udc_remove,
.shutdown = at91udc_shutdown,
.suspend = at91udc_suspend,
@@ -2010,7 +2011,7 @@ static struct platform_driver at91_udc_driver = {
},
};
-module_platform_driver_probe(at91_udc_driver, at91udc_probe);
+module_platform_driver(at91_udc_driver);
MODULE_DESCRIPTION("AT91 udc driver");
MODULE_AUTHOR("Thomas Rathbone, David Brownell");
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/6] usb: gadget: at91-udc: Convert to use module_platform_driver()
@ 2023-10-17 20:44 ` Uwe Kleine-König
0 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alexandre Belloni, Michael Grzeschik, Arnd Bergmann,
linux-kbuild, linux-usb, Claudiu Beznea, kernel,
linux-arm-kernel
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/at91_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index 922b4187004b..30ea4a9d5301 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -2000,6 +2000,7 @@ static int at91udc_resume(struct platform_device *pdev)
#endif
static struct platform_driver at91_udc_driver = {
+ .probe = at91udc_probe,
.remove = at91udc_remove,
.shutdown = at91udc_shutdown,
.suspend = at91udc_suspend,
@@ -2010,7 +2011,7 @@ static struct platform_driver at91_udc_driver = {
},
};
-module_platform_driver_probe(at91_udc_driver, at91udc_probe);
+module_platform_driver(at91_udc_driver);
MODULE_DESCRIPTION("AT91 udc driver");
MODULE_AUTHOR("Thomas Rathbone, David Brownell");
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/6] usb: gadget: fsl-udc: Convert to use module_platform_driver()
2023-10-17 20:44 ` Uwe Kleine-König
@ 2023-10-17 20:44 ` Uwe Kleine-König
-1 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Li Yang, linux-usb, linuxppc-dev, kernel, Arnd Bergmann, linux-kbuild
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index ee5705d336e3..2693a10eb0c7 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2666,6 +2666,7 @@ static const struct platform_device_id fsl_udc_devtype[] = {
};
MODULE_DEVICE_TABLE(platform, fsl_udc_devtype);
static struct platform_driver udc_driver = {
+ .probe = fsl_udc_probe,
.remove = fsl_udc_remove,
.id_table = fsl_udc_devtype,
/* these suspend and resume are not usb suspend and resume */
@@ -2679,7 +2680,7 @@ static struct platform_driver udc_driver = {
},
};
-module_platform_driver_probe(udc_driver, fsl_udc_probe);
+module_platform_driver(udc_driver);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_AUTHOR(DRIVER_AUTHOR);
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/6] usb: gadget: fsl-udc: Convert to use module_platform_driver()
@ 2023-10-17 20:44 ` Uwe Kleine-König
0 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, linux-kbuild, linux-usb, Li Yang, kernel, linuxppc-dev
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index ee5705d336e3..2693a10eb0c7 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2666,6 +2666,7 @@ static const struct platform_device_id fsl_udc_devtype[] = {
};
MODULE_DEVICE_TABLE(platform, fsl_udc_devtype);
static struct platform_driver udc_driver = {
+ .probe = fsl_udc_probe,
.remove = fsl_udc_remove,
.id_table = fsl_udc_devtype,
/* these suspend and resume are not usb suspend and resume */
@@ -2679,7 +2680,7 @@ static struct platform_driver udc_driver = {
},
};
-module_platform_driver_probe(udc_driver, fsl_udc_probe);
+module_platform_driver(udc_driver);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_AUTHOR(DRIVER_AUTHOR);
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/6] usb: gadget: fusb300-udc: Convert to use module_platform_driver()
2023-10-17 20:44 ` Uwe Kleine-König
` (3 preceding siblings ...)
(?)
@ 2023-10-17 20:44 ` Uwe Kleine-König
-1 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Aaro Koskinen, Alan Stern, Gaosheng Cui, linux-usb, kernel,
Arnd Bergmann, linux-kbuild
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/fusb300_udc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c
index bd03d475f927..873265634ccc 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.c
+++ b/drivers/usb/gadget/udc/fusb300_udc.c
@@ -1506,10 +1506,11 @@ static int fusb300_probe(struct platform_device *pdev)
}
static struct platform_driver fusb300_driver = {
- .remove_new = fusb300_remove,
- .driver = {
+ .probe = fusb300_probe,
+ .remove_new = fusb300_remove,
+ .driver = {
.name = udc_name,
},
};
-module_platform_driver_probe(fusb300_driver, fusb300_probe);
+module_platform_driver(fusb300_driver);
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/6] usb: gadget: lpc32xx-udc: Convert to use module_platform_driver()
2023-10-17 20:44 ` Uwe Kleine-König
@ 2023-10-17 20:44 ` Uwe Kleine-König
-1 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Vladimir Zapolskiy, linux-usb, linux-arm-kernel, kernel,
Arnd Bergmann, linux-kbuild
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index fe62db32dd0e..a917cc9a32ab 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3254,6 +3254,7 @@ MODULE_DEVICE_TABLE(of, lpc32xx_udc_of_match);
#endif
static struct platform_driver lpc32xx_udc_driver = {
+ .probe = lpc32xx_udc_probe,
.remove = lpc32xx_udc_remove,
.shutdown = lpc32xx_udc_shutdown,
.suspend = lpc32xx_udc_suspend,
@@ -3264,7 +3265,7 @@ static struct platform_driver lpc32xx_udc_driver = {
},
};
-module_platform_driver_probe(lpc32xx_udc_driver, lpc32xx_udc_probe);
+module_platform_driver(lpc32xx_udc_driver);
MODULE_DESCRIPTION("LPC32XX udc driver");
MODULE_AUTHOR("Kevin Wells <kevin.wells@nxp.com>");
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/6] usb: gadget: lpc32xx-udc: Convert to use module_platform_driver()
@ 2023-10-17 20:44 ` Uwe Kleine-König
0 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Vladimir Zapolskiy, linux-usb, linux-arm-kernel, kernel,
Arnd Bergmann, linux-kbuild
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index fe62db32dd0e..a917cc9a32ab 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3254,6 +3254,7 @@ MODULE_DEVICE_TABLE(of, lpc32xx_udc_of_match);
#endif
static struct platform_driver lpc32xx_udc_driver = {
+ .probe = lpc32xx_udc_probe,
.remove = lpc32xx_udc_remove,
.shutdown = lpc32xx_udc_shutdown,
.suspend = lpc32xx_udc_suspend,
@@ -3264,7 +3265,7 @@ static struct platform_driver lpc32xx_udc_driver = {
},
};
-module_platform_driver_probe(lpc32xx_udc_driver, lpc32xx_udc_probe);
+module_platform_driver(lpc32xx_udc_driver);
MODULE_DESCRIPTION("LPC32XX udc driver");
MODULE_AUTHOR("Kevin Wells <kevin.wells@nxp.com>");
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/6] usb: gadget: m66592-udc: Convert to use module_platform_driver()
2023-10-17 20:44 ` Uwe Kleine-König
` (5 preceding siblings ...)
(?)
@ 2023-10-17 20:44 ` Uwe Kleine-König
-1 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Yoshihiro Shimoda, Pavel Machek, Paolo Abeni,
Steven Rostedt (Google),
Aaro Koskinen, linux-usb, kernel, Arnd Bergmann, linux-kbuild
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/m66592-udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c
index e05f45a4b56b..bfaa5291e6c8 100644
--- a/drivers/usb/gadget/udc/m66592-udc.c
+++ b/drivers/usb/gadget/udc/m66592-udc.c
@@ -1687,10 +1687,11 @@ static int m66592_probe(struct platform_device *pdev)
/*-------------------------------------------------------------------------*/
static struct platform_driver m66592_driver = {
+ .probe = m66592_probe,
.remove_new = m66592_remove,
.driver = {
.name = udc_name,
},
};
-module_platform_driver_probe(m66592_driver, m66592_probe);
+module_platform_driver(m66592_driver);
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/6] usb: gadget: r8a66597-udc: Convert to use module_platform_driver()
2023-10-17 20:44 ` Uwe Kleine-König
` (6 preceding siblings ...)
(?)
@ 2023-10-17 20:44 ` Uwe Kleine-König
-1 siblings, 0 replies; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-17 20:44 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Yoshihiro Shimoda, linux-usb, kernel, Arnd Bergmann, linux-kbuild
module_platform_driver_probe() has the advantage that the .probe() and
.remove() calls can live in .init.text and .exit.text respectively and
so some memory is saved. The downside is that dynamic bind and unbind
are impossible. As the driver doesn't benefit from the advantages (both
.probe and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/usb/gadget/udc/r8a66597-udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c
index 51b665f15c8e..db4a10a979f9 100644
--- a/drivers/usb/gadget/udc/r8a66597-udc.c
+++ b/drivers/usb/gadget/udc/r8a66597-udc.c
@@ -1964,13 +1964,14 @@ static int r8a66597_probe(struct platform_device *pdev)
/*-------------------------------------------------------------------------*/
static struct platform_driver r8a66597_driver = {
+ .probe = r8a66597_probe,
.remove_new = r8a66597_remove,
.driver = {
.name = udc_name,
},
};
-module_platform_driver_probe(r8a66597_driver, r8a66597_probe);
+module_platform_driver(r8a66597_driver);
MODULE_DESCRIPTION("R8A66597 USB gadget driver");
MODULE_LICENSE("GPL");
--
2.42.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-10-17 21:02 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17 20:44 [PATCH 0/6] usb: gadget: Convert to use module_platform_driver() Uwe Kleine-König
2023-10-17 20:44 ` Uwe Kleine-König
2023-10-17 20:44 ` Uwe Kleine-König
2023-10-17 20:44 ` [PATCH 1/6] usb: gadget: at91-udc: " Uwe Kleine-König
2023-10-17 20:44 ` Uwe Kleine-König
2023-10-17 20:44 ` [PATCH 2/6] usb: gadget: fsl-udc: " Uwe Kleine-König
2023-10-17 20:44 ` Uwe Kleine-König
2023-10-17 20:44 ` [PATCH 3/6] usb: gadget: fusb300-udc: " Uwe Kleine-König
2023-10-17 20:44 ` [PATCH 4/6] usb: gadget: lpc32xx-udc: " Uwe Kleine-König
2023-10-17 20:44 ` Uwe Kleine-König
2023-10-17 20:44 ` [PATCH 5/6] usb: gadget: m66592-udc: " Uwe Kleine-König
2023-10-17 20:44 ` [PATCH 6/6] usb: gadget: r8a66597-udc: " Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.