From: "Michael S. Tsirkin" <mst@redhat.com> To: Yishai Hadas <yishaih@nvidia.com> Cc: alex.williamson@redhat.com, jasowang@redhat.com, jgg@nvidia.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, parav@nvidia.com, feliu@nvidia.com, jiri@nvidia.com, kevin.tian@intel.com, joao.m.martins@oracle.com, si-wei.liu@oracle.com, leonro@nvidia.com, maorg@nvidia.com Subject: Re: [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy IO admin commands Date: Wed, 25 Oct 2023 12:31:30 -0400 [thread overview] Message-ID: <20231025122913-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <c6c849b6-e1ff-4319-a199-5abcac032a25@nvidia.com> On Wed, Oct 25, 2023 at 05:03:55PM +0300, Yishai Hadas wrote: > > Yes - I think some kind of API will be needed to setup/cleanup. > > Then 1st call to setup would do the list/use dance? some ref counting? > > OK, we may work to come in V2 with that option in place. > > Please note that the initialization 'list/use' commands would be done as > part of the admin queue activation but we can't enable the admin queue for > the upper layers before that it was done. I don't know what does this mean. > So, we may consider skipping the ref count set/get as part of the > initialization flow with some flag/detection of the list/use commands as the > ref count setting enables the admin queue for upper-layers which we would > like to prevent by that time. You can init on 1st use but you can't destroy after last use. For symmetry it's better to just have explicit constructor/destructor. > > > > And maybe the API should just be > > bool virtio_pci_admin_has_legacy_io() > > This can work as well. > > In that case, the API will just get the VF PCI to get from it the PF + > 'admin_queue' context and will check internally that all current 5 legacy > commands are supported. > > Yishai Yes, makes sense. -- MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Yishai Hadas <yishaih@nvidia.com> Cc: kvm@vger.kernel.org, maorg@nvidia.com, virtualization@lists.linux-foundation.org, jgg@nvidia.com, jiri@nvidia.com, leonro@nvidia.com Subject: Re: [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy IO admin commands Date: Wed, 25 Oct 2023 12:31:30 -0400 [thread overview] Message-ID: <20231025122913-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <c6c849b6-e1ff-4319-a199-5abcac032a25@nvidia.com> On Wed, Oct 25, 2023 at 05:03:55PM +0300, Yishai Hadas wrote: > > Yes - I think some kind of API will be needed to setup/cleanup. > > Then 1st call to setup would do the list/use dance? some ref counting? > > OK, we may work to come in V2 with that option in place. > > Please note that the initialization 'list/use' commands would be done as > part of the admin queue activation but we can't enable the admin queue for > the upper layers before that it was done. I don't know what does this mean. > So, we may consider skipping the ref count set/get as part of the > initialization flow with some flag/detection of the list/use commands as the > ref count setting enables the admin queue for upper-layers which we would > like to prevent by that time. You can init on 1st use but you can't destroy after last use. For symmetry it's better to just have explicit constructor/destructor. > > > > And maybe the API should just be > > bool virtio_pci_admin_has_legacy_io() > > This can work as well. > > In that case, the API will just get the VF PCI to get from it the PF + > 'admin_queue' context and will check internally that all current 5 legacy > commands are supported. > > Yishai Yes, makes sense. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-10-25 16:32 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-17 13:42 [PATCH V1 vfio 0/9] Introduce a vfio driver over virtio devices Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 1/9] virtio-pci: Fix common config map for modern device Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 2/9] virtio: Define feature bit for administration virtqueue Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 3/9] virtio-pci: Introduce admin virtqueue Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 4/9] virtio-pci: Introduce admin command sending function Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 5/9] virtio-pci: Introduce admin commands Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy IO " Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 20:33 ` kernel test robot 2023-10-17 20:33 ` kernel test robot 2023-10-22 1:14 ` kernel test robot 2023-10-22 1:14 ` kernel test robot 2023-10-24 21:01 ` Michael S. Tsirkin 2023-10-24 21:01 ` Michael S. Tsirkin 2023-10-25 9:18 ` Yishai Hadas via Virtualization 2023-10-25 10:17 ` Michael S. Tsirkin 2023-10-25 10:17 ` Michael S. Tsirkin 2023-10-25 13:00 ` Yishai Hadas 2023-10-25 13:00 ` Yishai Hadas via Virtualization 2023-10-25 13:04 ` Michael S. Tsirkin 2023-10-25 13:04 ` Michael S. Tsirkin 2023-10-25 13:44 ` Michael S. Tsirkin 2023-10-25 13:44 ` Michael S. Tsirkin 2023-10-25 14:03 ` Yishai Hadas 2023-10-25 14:03 ` Yishai Hadas via Virtualization 2023-10-25 16:31 ` Michael S. Tsirkin [this message] 2023-10-25 16:31 ` Michael S. Tsirkin 2023-10-25 9:36 ` Yishai Hadas 2023-10-25 9:36 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 7/9] vfio/pci: Expose vfio_pci_core_setup_barmap() Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 8/9] vfio/pci: Expose vfio_pci_iowrite/read##size() Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 13:42 ` [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices Yishai Hadas 2023-10-17 13:42 ` Yishai Hadas via Virtualization 2023-10-17 20:24 ` Alex Williamson 2023-10-17 20:24 ` Alex Williamson 2023-10-18 9:01 ` Yishai Hadas 2023-10-18 9:01 ` Yishai Hadas via Virtualization 2023-10-18 12:51 ` Alex Williamson 2023-10-18 12:51 ` Alex Williamson 2023-10-18 13:06 ` Parav Pandit 2023-10-18 13:06 ` Parav Pandit via Virtualization 2023-10-18 16:33 ` Jason Gunthorpe 2023-10-18 18:29 ` Alex Williamson 2023-10-18 18:29 ` Alex Williamson 2023-10-18 19:28 ` Jason Gunthorpe 2023-10-24 19:57 ` Alex Williamson 2023-10-24 19:57 ` Alex Williamson 2023-10-25 14:35 ` Yishai Hadas 2023-10-25 14:35 ` Yishai Hadas via Virtualization 2023-10-25 16:28 ` Michael S. Tsirkin 2023-10-25 16:28 ` Michael S. Tsirkin 2023-10-25 19:13 ` Alex Williamson 2023-10-25 19:13 ` Alex Williamson 2023-10-26 12:08 ` Yishai Hadas 2023-10-26 12:08 ` Yishai Hadas via Virtualization 2023-10-26 12:12 ` Michael S. Tsirkin 2023-10-26 12:12 ` Michael S. Tsirkin 2023-10-26 12:40 ` Parav Pandit 2023-10-26 12:40 ` Parav Pandit via Virtualization 2023-10-26 13:15 ` Michael S. Tsirkin 2023-10-26 13:15 ` Michael S. Tsirkin 2023-10-26 13:28 ` Parav Pandit 2023-10-26 13:28 ` Parav Pandit via Virtualization 2023-10-26 15:06 ` Michael S. Tsirkin 2023-10-26 15:06 ` Michael S. Tsirkin 2023-10-26 15:09 ` Parav Pandit 2023-10-26 15:09 ` Parav Pandit via Virtualization 2023-10-26 15:46 ` Michael S. Tsirkin 2023-10-26 15:46 ` Michael S. Tsirkin 2023-10-26 15:56 ` Parav Pandit 2023-10-26 15:56 ` Parav Pandit via Virtualization 2023-10-26 17:55 ` Alex Williamson 2023-10-26 17:55 ` Alex Williamson 2023-10-26 19:49 ` Michael S. Tsirkin 2023-10-26 19:49 ` Michael S. Tsirkin 2023-10-29 16:13 ` Yishai Hadas via Virtualization 2023-10-29 16:13 ` Yishai Hadas 2023-10-22 8:20 ` [PATCH V1 vfio 0/9] " Yishai Hadas 2023-10-22 8:20 ` Yishai Hadas via Virtualization 2023-10-22 9:12 ` Michael S. Tsirkin 2023-10-22 9:12 ` Michael S. Tsirkin 2023-10-23 15:33 ` Alex Williamson 2023-10-23 15:33 ` Alex Williamson 2023-10-23 15:42 ` Jason Gunthorpe 2023-10-23 16:09 ` Alex Williamson 2023-10-23 16:09 ` Alex Williamson 2023-10-23 16:20 ` Jason Gunthorpe 2023-10-23 16:45 ` Alex Williamson 2023-10-23 16:45 ` Alex Williamson 2023-10-23 17:27 ` Jason Gunthorpe 2023-10-25 8:34 ` Tian, Kevin 2023-10-25 8:34 ` Tian, Kevin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231025122913-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=feliu@nvidia.com \ --cc=jasowang@redhat.com \ --cc=jgg@nvidia.com \ --cc=jiri@nvidia.com \ --cc=joao.m.martins@oracle.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=leonro@nvidia.com \ --cc=maorg@nvidia.com \ --cc=parav@nvidia.com \ --cc=si-wei.liu@oracle.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=yishaih@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.