* [PATCH] reiserfs: UBSAN: array-index-out-of-bounds in direntry_create_vi
@ 2023-10-26 12:56 Bragatheswaran Manickavel
2023-11-04 12:58 ` Bragatheswaran Manickavel
0 siblings, 1 reply; 2+ messages in thread
From: Bragatheswaran Manickavel @ 2023-10-26 12:56 UTC (permalink / raw)
To: reiserfs-devel
Cc: Bragatheswaran Manickavel, linux-kernel, syzbot+e5bb9eb00a5a5ed2a9a2
deh defined as an array of type __u16[], and issue is
triggered when it's trying to access an element at
index 1, which is out of bounds because the array
has only one element at index 0.
Reported-by: syzbot+e5bb9eb00a5a5ed2a9a2@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=e5bb9eb00a5a5ed2a9a2
Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
---
fs/reiserfs/item_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/reiserfs/item_ops.c b/fs/reiserfs/item_ops.c
index 3a5a752d96c7..ccf547c5e8e1 100644
--- a/fs/reiserfs/item_ops.c
+++ b/fs/reiserfs/item_ops.c
@@ -484,7 +484,7 @@ static int direntry_create_vi(struct virtual_node *vn,
vn->vn_mode);
dir_u->entry_sizes[i] =
(j ? deh_location(&deh[j - 1]) : ih_item_len(vi->vi_ih)) -
- deh_location(&deh[j]) + DEH_SIZE;
+ deh_location(&deh[j - 1]) + DEH_SIZE;
}
size += (dir_u->entry_count * sizeof(short));
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reiserfs: UBSAN: array-index-out-of-bounds in direntry_create_vi
2023-10-26 12:56 [PATCH] reiserfs: UBSAN: array-index-out-of-bounds in direntry_create_vi Bragatheswaran Manickavel
@ 2023-11-04 12:58 ` Bragatheswaran Manickavel
0 siblings, 0 replies; 2+ messages in thread
From: Bragatheswaran Manickavel @ 2023-11-04 12:58 UTC (permalink / raw)
To: reiserfs-devel; +Cc: linux-kernel, syzbot+e5bb9eb00a5a5ed2a9a2
On 26/10/23 18:26, Bragatheswaran Manickavel wrote:
> deh defined as an array of type __u16[], and issue is
> triggered when it's trying to access an element at
> index 1, which is out of bounds because the array
> has only one element at index 0.
>
> Reported-by: syzbot+e5bb9eb00a5a5ed2a9a2@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=e5bb9eb00a5a5ed2a9a2
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
> fs/reiserfs/item_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/item_ops.c b/fs/reiserfs/item_ops.c
> index 3a5a752d96c7..ccf547c5e8e1 100644
> --- a/fs/reiserfs/item_ops.c
> +++ b/fs/reiserfs/item_ops.c
> @@ -484,7 +484,7 @@ static int direntry_create_vi(struct virtual_node *vn,
> vn->vn_mode);
> dir_u->entry_sizes[i] =
> (j ? deh_location(&deh[j - 1]) : ih_item_len(vi->vi_ih)) -
> - deh_location(&deh[j]) + DEH_SIZE;
> + deh_location(&deh[j - 1]) + DEH_SIZE;
> }
>
> size += (dir_u->entry_count * sizeof(short));
Could someone help in reviewing the changes. I see reiserfs was marked with
obsolete but still wanted to know whether this patch is correct and can be
taken (if possible)
Thanks,
Bragathe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-04 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-26 12:56 [PATCH] reiserfs: UBSAN: array-index-out-of-bounds in direntry_create_vi Bragatheswaran Manickavel
2023-11-04 12:58 ` Bragatheswaran Manickavel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.