[PATCH] eal/unix: lower log level for reading files

* [PATCH] eal/unix: lower log level for reading files
@ 2023-10-27  8:00 David Marchand
  2023-10-27  9:00 ` Morten Brørup
  0 siblings, 1 reply; 5+ messages in thread
From: David Marchand @ 2023-10-27  8:00 UTC (permalink / raw)
  To: dev; +Cc: ktraynor

The eal_parse_sysfs_value helper both returns an error code and logs an
error level message when something goes wrong.
On the other hand, internal users of this helper either ignore this
error code (like when trying to find out some numa information from the
Linux sysfs, or discovering some optional feature), or add their own error
logging when reading the file actually matters.

Lower this helper log messages to debug level as it provides no useful
information to final DPDK users.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/eal/unix/eal_filesystem.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/eal/unix/eal_filesystem.c b/lib/eal/unix/eal_filesystem.c
index afbab9368a..282df50347 100644
--- a/lib/eal/unix/eal_filesystem.c
+++ b/lib/eal/unix/eal_filesystem.c
@@ -84,20 +84,20 @@ int eal_parse_sysfs_value(const char *filename, unsigned long *val)
 	char *end = NULL;
 
 	if ((f = fopen(filename, "r")) == NULL) {
-		RTE_LOG(ERR, EAL, "%s(): cannot open sysfs value %s\n",
+		RTE_LOG(DEBUG, EAL, "%s(): cannot open sysfs value %s\n",
 			__func__, filename);
 		return -1;
 	}
 
 	if (fgets(buf, sizeof(buf), f) == NULL) {
-		RTE_LOG(ERR, EAL, "%s(): cannot read sysfs value %s\n",
+		RTE_LOG(DEBUG, EAL, "%s(): cannot read sysfs value %s\n",
 			__func__, filename);
 		fclose(f);
 		return -1;
 	}
 	*val = strtoul(buf, &end, 0);
 	if ((buf[0] == '\0') || (end == NULL) || (*end != '\n')) {
-		RTE_LOG(ERR, EAL, "%s(): cannot parse sysfs value %s\n",
+		RTE_LOG(DEBUG, EAL, "%s(): cannot parse sysfs value %s\n",
 				__func__, filename);
 		fclose(f);
 		return -1;
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread