All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] cmd: acpi: fix acpi list command
@ 2023-11-12  7:03 Heinrich Schuchardt
  2023-11-12  7:03 ` [PATCH v2 1/2] acpi: fix struct acpi_xsdt Heinrich Schuchardt
  2023-11-12  7:03 ` [PATCH v2 2/2] cmd: acpi: fix acpi list command Heinrich Schuchardt
  0 siblings, 2 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2023-11-12  7:03 UTC (permalink / raw)
  To: Simon Glass; +Cc: Bin Meng, Andy Shevchenko, u-boot, Heinrich Schuchardt

The size of the ACPI table header is not a multiple of 8. We have to mark
struct acpi_xsdt as packed to correctly access field Entry.

Add a unit test for the offsets of field Entry in the RSDT and XSDT tables.

ACPI tables may comprise either RSDT, XSDT, or both. The current code fails
to check the presence of the RSDT table before accessing it. This leads to
an exception if the RSDT table is not provided.

The XSDT table takes precedence over the RSDT table.

Addresses in the XSDT table are 64-bit. Adjust the output accordingly.

As the RSDT table has to be ignored if the XSDT command is present there is
no need to compare the tables in a display command. Anyway the
specification does not require that the sequence of addresses in the RSDT
and XSDT table are the same.

The FACS table header does not provide revision information. Correct the
description of dump_hdr().

Adjust the ACPI test to match the changed output format of the 'acpi list'
command.

v2:
	merge patch 2 and 3
	remove leading zeros from address output

Heinrich Schuchardt (2):
  acpi: fix struct acpi_xsdt
  cmd: acpi: fix acpi list command

 cmd/acpi.c                | 48 +++++++++++++++++++++++----------------
 include/acpi/acpi_table.h |  2 +-
 test/dm/acpi.c            | 28 +++++++++++++++--------
 3 files changed, 49 insertions(+), 29 deletions(-)

-- 
2.40.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-11-18 19:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-12  7:03 [PATCH v2 0/2] cmd: acpi: fix acpi list command Heinrich Schuchardt
2023-11-12  7:03 ` [PATCH v2 1/2] acpi: fix struct acpi_xsdt Heinrich Schuchardt
2023-11-12 20:01   ` Simon Glass
2023-11-12  7:03 ` [PATCH v2 2/2] cmd: acpi: fix acpi list command Heinrich Schuchardt
2023-11-12 20:01   ` Simon Glass
2023-11-18 19:02     ` Heinrich Schuchardt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.