From: Simon Horman <horms@kernel.org>
To: Christian Hopps <chopps@chopps.org>
Cc: devel@linux-ipsec.org,
Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org, Christian Hopps <chopps@labn.net>
Subject: Re: [RFC ipsec-next 1/8] iptfs: config: add CONFIG_XFRM_IPTFS
Date: Sun, 12 Nov 2023 09:57:05 +0000 [thread overview]
Message-ID: <20231112095705.GG705326@kernel.org> (raw)
In-Reply-To: <20231110113719.3055788-2-chopps@chopps.org>
On Fri, Nov 10, 2023 at 06:37:12AM -0500, Christian Hopps wrote:
> From: Christian Hopps <chopps@labn.net>
>
> Signed-off-by: Christian Hopps <chopps@labn.net>
Hi Christian,
thanks for your patchset.
Some feedback from my side, I hope it is useful.
> ---
> net/xfrm/Kconfig | 9 +++++++++
> net/xfrm/Makefile | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
> index 3adf31a83a79..d07852069e68 100644
> --- a/net/xfrm/Kconfig
> +++ b/net/xfrm/Kconfig
> @@ -134,6 +134,15 @@ config NET_KEY_MIGRATE
>
> If unsure, say N.
>
> +config XFRM_IPTFS
> + bool "IPsec IPTFS (RFC 9347) encapsulation support"
> + depends on XFRM
> + help
> + Information on the IPTFS encapsulation can be found
> + in RFC 9347.
nit: the indentation of the above seems inconsistent
> +
> + If unsure, say N.
> +
> config XFRM_ESPINTCP
> bool
>
> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
> index cd47f88921f5..9b870a3274a7 100644
> --- a/net/xfrm/Makefile
> +++ b/net/xfrm/Makefile
> @@ -20,4 +20,5 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
> obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
> obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
> obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
> obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
Unfortunately, this breaks allmodconfig builds.
Please ensure that each patch survives an allyesconfig and an allmodconfig
build with W=1 set without new warnings or failures. [1].
I also recommend checking that no new sparse warnings are introduced.
[1] https://docs.kernel.org/process/maintainer-netdev.html#expected-level-of-testing
next prev parent reply other threads:[~2023-11-12 9:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 11:37 [RFC ipsec-next] Add IP-TFS mode to xfrm Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 1/8] iptfs: config: add CONFIG_XFRM_IPTFS Christian Hopps
2023-11-12 9:57 ` Simon Horman [this message]
2023-11-12 11:29 ` Christian Hopps
2023-11-12 19:49 ` [devel-ipsec] " Antony Antony
2023-11-13 2:31 ` Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 2/8] iptfs: uapi: ip: add ip_tfs_*_hdr packet formats Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 3/8] iptfs: uapi: IPPROTO_AGGFRAG AGGFRAG in ESP Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 4/8] iptfs: sysctl: allow configuration of global default values Christian Hopps
2023-11-12 8:26 ` [devel-ipsec] " Michael Richardson
2023-11-12 10:28 ` Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 5/8] iptfs: netlink: add config (netlink) options Christian Hopps
2023-11-10 18:09 ` kernel test robot
2023-11-10 18:22 ` Christian Hopps
2023-11-10 18:58 ` Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 6/8] iptfs: xfrm: Add mode_cbs module functionality Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 7/8] iptfs: xfrm: add generic iptfs defines and functionality Christian Hopps
2023-11-12 19:44 ` [devel-ipsec] " Antony Antony
2023-11-12 21:00 ` Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 8/8] iptfs: impl: add new iptfs xfrm mode impl Christian Hopps
2023-11-10 15:19 ` kernel test robot
2023-11-10 17:31 ` kernel test robot
2023-11-12 10:02 ` Simon Horman
2023-11-12 11:35 ` Christian Hopps
2023-11-12 19:45 ` [devel-ipsec] [RFC ipsec-next] Add IP-TFS mode to xfrm Antony Antony
2023-11-13 2:31 ` Christian Hopps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231112095705.GG705326@kernel.org \
--to=horms@kernel.org \
--cc=chopps@chopps.org \
--cc=chopps@labn.net \
--cc=devel@linux-ipsec.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.