All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Richardson <mcr@sandelman.ca>
To: Christian Hopps <chopps@chopps.org>,
	devel@linux-ipsec.org, netdev@vger.kernel.org,
	Christian Hopps <chopps@labn.net>
Subject: Re: [devel-ipsec] [RFC ipsec-next 4/8] iptfs: sysctl: allow configuration of global default values
Date: Sun, 12 Nov 2023 09:26:24 +0100	[thread overview]
Message-ID: <3808085.1699777584@dyas> (raw)
In-Reply-To: <20231110113719.3055788-5-chopps@chopps.org>

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]


>>>>> Christian Hopps <chopps@labn.net> writes:
Christian Hopps via Devel <devel@linux-ipsec.org> wrote:
    > Add sysctls for the changing the IPTFS default SA values.

Add sysctls for the changing the IPTFS default SA values.

+xfrm_iptfs_idelay - UNSIGNED INTEGER
+        The default IPTFS initial output delay. The initial output delay is the
+        amount of time prior to servicing the output queue after queueing the
+        first packet on said queue.

I'm guessing this is in miliseconds, but the documentation here does not say.

+xfrm_iptfs_rewin - UNSIGNED INTEGER
+        The default IPTFS reorder window size. The reorder window size dictates
+        the maximum number of IPTFS tunnel packets in a sequence that may arrive
+        out of order.
+
+        Default 3.

Why three?
Is there some experimental reason to pick three?
It seems that maybe the reorder window size could have been a per-SA attribute.

I read through the rest of the patches, and they seem great, but I didn't
read with a lot of comprehension.  I found the explanatory comments and
diagrams very well done!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]

  reply	other threads:[~2023-11-12  8:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10 11:37 [RFC ipsec-next] Add IP-TFS mode to xfrm Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 1/8] iptfs: config: add CONFIG_XFRM_IPTFS Christian Hopps
2023-11-12  9:57   ` Simon Horman
2023-11-12 11:29     ` Christian Hopps
2023-11-12 19:49   ` [devel-ipsec] " Antony Antony
2023-11-13  2:31     ` Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 2/8] iptfs: uapi: ip: add ip_tfs_*_hdr packet formats Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 3/8] iptfs: uapi: IPPROTO_AGGFRAG AGGFRAG in ESP Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 4/8] iptfs: sysctl: allow configuration of global default values Christian Hopps
2023-11-12  8:26   ` Michael Richardson [this message]
2023-11-12 10:28     ` [devel-ipsec] " Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 5/8] iptfs: netlink: add config (netlink) options Christian Hopps
2023-11-10 18:09   ` kernel test robot
2023-11-10 18:22     ` Christian Hopps
2023-11-10 18:58       ` Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 6/8] iptfs: xfrm: Add mode_cbs module functionality Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 7/8] iptfs: xfrm: add generic iptfs defines and functionality Christian Hopps
2023-11-12 19:44   ` [devel-ipsec] " Antony Antony
2023-11-12 21:00     ` Christian Hopps
2023-11-10 11:37 ` [RFC ipsec-next 8/8] iptfs: impl: add new iptfs xfrm mode impl Christian Hopps
2023-11-10 15:19   ` kernel test robot
2023-11-10 17:31   ` kernel test robot
2023-11-12 10:02   ` Simon Horman
2023-11-12 11:35     ` Christian Hopps
2023-11-12 19:45 ` [devel-ipsec] [RFC ipsec-next] Add IP-TFS mode to xfrm Antony Antony
2023-11-13  2:31   ` Christian Hopps

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3808085.1699777584@dyas \
    --to=mcr@sandelman.ca \
    --cc=chopps@chopps.org \
    --cc=chopps@labn.net \
    --cc=devel@linux-ipsec.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.